Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

2017-08-27 Thread Antoine Tenart
Hi Russell, On Fri, Aug 25, 2017 at 11:43:13PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 25, 2017 at 04:48:12PM +0200, Antoine Tenart wrote: > > The link mode (speed, duplex) was forced based on what the phylib > > returns. This should not be the case, and only forced by ethtool > > fun

Re: [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of the PHY mode

2017-08-27 Thread Antoine Tenart
Hi Russell, On Fri, Aug 25, 2017 at 11:46:16PM +0100, Russell King - ARM Linux wrote: > On Fri, Aug 25, 2017 at 04:48:16PM +0200, Antoine Tenart wrote: > > This patch adds logic to reconfigure the comphy/gop when the link status > > change at runtime. This is very useful on boards such as the mcbi

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-27 Thread Pavel Machek
Hi! > >No, tag_ksz part probably is not acceptable. Do you see solution > >better than just copying it into tag_ksz1 file? > > You could have all Micrel tag implementations live under net/dsa/tag_ksz.c > and have e.g: DSA_TAG_PROTO_KSZ for the current (newer) switches and > DSA_TAG_PROTO_KSZ_LE

[patch net-next 3/3] net/sched: Change act_api and act_xxx modules to use IDR

2017-08-27 Thread Chris Mi
Typically, each TC filter has its own action. All the actions of the same type are saved in its hash table. But the hash buckets are too small that it degrades to a list. And the performance is greatly affected. For example, it takes about 0m11.914s to insert 64K rules. If we convert the hash table

[patch net-next 0/3] net/sched: Improve getting objects by indexes

2017-08-27 Thread Chris Mi
Using current TC code, it is very slow to insert a lot of rules. In order to improve the rules update rate in TC, we introduced the following two changes: 1) changed cls_flower to use IDR to manage the filters. 2) changed all act_xxx modules to use IDR instead of a small

[patch net-next 1/3] idr: Add new APIs to support unsigned long

2017-08-27 Thread Chris Mi
The following new APIs are added: int idr_alloc_ext(struct idr *idr, void *ptr, unsigned long *index, unsigned long start, unsigned long end, gfp_t gfp); static inline void *idr_remove_ext(struct idr *idr, unsigned long id); static inline void *idr_find_ext(const struct idr *idr,

[patch net-next 2/3] net/sched: Change cls_flower to use IDR

2017-08-27 Thread Chris Mi
Currently, all filters with the same priority are linked in a doubly linked list. Every filter should have a unique handle. To make the handle unique, we need to iterate the list every time to see if the handle exists or not when inserting a new filter. It is time-consuming. For example, it takes a

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-27 Thread Pavel Machek
Hi! > > No, tag_ksz part probably is not acceptable. Do you see solution > > better than just copying it into tag_ksz1 file? > > How about something like this, which needs further work to actually > compile, but should give you the idea. If that's acceptable, yes, I can do something similar. I d

[PATCH net-next v3 0/3] NCSI VLAN Filtering Support

2017-08-27 Thread Samuel Mendoza-Jonas
This series (mainly patch 2) adds VLAN filtering to the NCSI implementation. A fair amount of code already exists in the NCSI stack for VLAN filtering but none of it is actually hooked up. This goes the final mile and fixes a few bugs in the existing code found along the way (patch 1). Patch 3 add

[PATCH net-next v3 1/3] net/ncsi: Fix several packet definitions

2017-08-27 Thread Samuel Mendoza-Jonas
Signed-off-by: Samuel Mendoza-Jonas --- v2: Rebased on latest net-next net/ncsi/ncsi-cmd.c | 10 +- net/ncsi/ncsi-pkt.h | 2 +- net/ncsi/ncsi-rsp.c | 3 ++- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c index 5e03ed190e18..7567

[PATCH net-next v3 2/3] net/ncsi: Configure VLAN tag filter

2017-08-27 Thread Samuel Mendoza-Jonas
Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI stack process new VLAN tags and configure the channel VLAN filter appropriately. Several VLAN tags can be set and a "Set VLAN Filter" packet must be sent for each one, meaning the ncsi_dev_state_config_svf state must be repeated.

[PATCH net-next v3 3/3] ftgmac100: Support NCSI VLAN filtering when available

2017-08-27 Thread Samuel Mendoza-Jonas
Register the ndo_vlan_rx_{add,kill}_vid callbacks and set the NETIF_F_HW_VLAN_CTAG_FILTER if NCSI is available. This allows the VLAN core to notify the NCSI driver when changes occur so that the remote NCSI channel can be properly configured to filter on the set VLAN tags. Signed-off-by: Samuel Me

Re: [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()

2017-08-27 Thread Dan Carpenter
On Sun, Aug 27, 2017 at 11:16:06PM +, Waskiewicz Jr, Peter wrote: > On 8/27/17 3:26 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Sun, 27 Aug 2017 21:18:37 +0200 > > > > Omit an extra message for a memory allocation failure in this function. > > > > This issue was detected

[PATCH] net: stmmac: constify clk_div_table

2017-08-27 Thread Arvind Yadav
clk_div_table are not supposed to change at runtime. meson8b_dwmac structure is working with const clk_div_table. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH net-next v7 05/10] landlock: Add LSM hooks related to filesystem

2017-08-27 Thread Alexei Starovoitov
On Sun, Aug 27, 2017 at 03:31:35PM +0200, Mickaël Salaün wrote: > > > How can you add 3rd argument? All FS events would have to get it, > > but in some LSM hooks such argument will be meaningless, whereas > > in other places it will carry useful info that rule can operate on. > > Would that mean t

Re: [PATCH net-next v7 04/10] bpf: Define handle_fs and add a new helper bpf_handle_fs_get_mode()

2017-08-27 Thread James Morris
On Mon, 21 Aug 2017, Mickaël Salaün wrote: > @@ -85,6 +90,8 @@ enum bpf_arg_type { > > ARG_PTR_TO_CTX, /* pointer to context */ > ARG_ANYTHING, /* any (initialized) argument is ok */ > + > + ARG_CONST_PTR_TO_HANDLE_FS, /* pointer to an abstract FS struct */

Re: [kernel-hardening] Re: [PATCH net-next v7 02/10] bpf: Add eBPF program subtype and is_valid_subtype() verifier

2017-08-27 Thread James Morris
On Wed, 23 Aug 2017, Mickaël Salaün wrote: > >> + struct { > >> + __u32 abi; /* minimal ABI version, cf. user doc */ > > > > the concept of abi (version) sounds a bit weird to me. > > Why bother with it at all? > > Once the first set of patches lands the kernel as whole will h

Re: [PATCH net-next v7 02/10] bpf: Add eBPF program subtype and is_valid_subtype() verifier

2017-08-27 Thread James Morris
On Tue, 22 Aug 2017, Alexei Starovoitov wrote: > more general question: what is the status of security/ bits? > I'm assuming they still need to be reviewed and explicitly acked by James, > right? Yep, along with other core security developers where possible. -- James Morris

Re: [kernel-hardening] [PATCH net-next v7 00/10] Landlock LSM: Toward unprivileged sandboxing

2017-08-27 Thread James Morris
On Mon, 21 Aug 2017, Mickaël Salaün wrote: > ## Why a new LSM? Are SELinux, AppArmor, Smack and Tomoyo not good enough? > > The current access control LSMs are fine for their purpose which is to give > the > *root* the ability to enforce a security policy for the *system*. What is > missing is a

Re: Get ARP/ND tables from kernel

2017-08-27 Thread Waskiewicz Jr, Peter
On 8/27/17 9:25 PM, Bassam Alsanie wrote: > Hello everyone, > I looking into a good way (stable and compatible with large number of > distros) to get the arp/nd cache from kernel to user space, for both > IP4 and IP6. > > It seem IOCTL (SIOCGARP) can't do that, you can only get MAC address > from

[PATCH net] ipv6: do not set sk_destruct in IPV6_ADDRFORM sockopt

2017-08-27 Thread Xin Long
ChunYu found a kernel warn_on during syzkaller fuzzing: [40226.038539] WARNING: CPU: 5 PID: 23720 at net/ipv4/af_inet.c:152 inet_sock_destruct+0x78d/0x9a0 [40226.144849] Call Trace: [40226.147590] [40226.149859] dump_stack+0xe2/0x186 [40226.176546] __warn+0x1a4/0x1e0 [40226.180066] warn_slow

Re: [PATCH RFC WIP 0/5] IGMP snooping for local traffic

2017-08-27 Thread Florian Fainelli
Hi Andrew, On 08/26/2017 01:56 PM, Andrew Lunn wrote: > This is a WIP patchset i would like comments on from bridge, > switchdev and hardware offload people. > > The linux bridge supports IGMP snooping. It will listen to IGMP > reports on bridge ports and keep track of which groups have been >

Re: [PATCH net-next] bridge: fdb add and delete tracepoints

2017-08-27 Thread Florian Fainelli
On 08/27/2017 02:33 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > Tracepoints to trace bridge forwarding database updates. Thanks for adding this! > > Signed-off-by: Roopa Prabhu > --- > include/trace/events/bridge.h | 98 > +++ > net/bridge/br_fdb

linux-next: manual merge of the net-next tree with the rockchip tree

2017-08-27 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: arch/arm64/boot/dts/rockchip/rk3328-evb.dts between commit: 0e54e062692a ("arm64: dts: rockchip: add mmc nodes for rk3328 evaluation board") 57fca160b2be ("arm64: dts: rockchip: add cpu regulator for rk3328 evaluati

Get ARP/ND tables from kernel

2017-08-27 Thread Bassam Alsanie
Hello everyone, I looking into a good way (stable and compatible with large number of distros) to get the arp/nd cache from kernel to user space, for both IP4 and IP6. It seem IOCTL (SIOCGARP) can't do that, you can only get MAC address from provided IP address. But IOCTL can't give the the full a

Re: [PATCH net-next 3/4] net/core: Add violation counters to VF statisctics

2017-08-27 Thread Jakub Kicinski
On Sun, 27 Aug 2017 14:06:17 +0300, Saeed Mahameed wrote: > From: Eugenia Emantayev > > Add receive and transmit violation counters to be > displayed in iproute2 VF statistics. > > Signed-off-by: Eugenia Emantayev > Signed-off-by: Saeed Mahameed > --- > include/linux/if_link.h | 2 ++ >

Re: [PATCH net-next 1/4] net: Add SRIOV VGT+ support

2017-08-27 Thread Jakub Kicinski
On Sun, 27 Aug 2017 14:06:15 +0300, Saeed Mahameed wrote: > From: Mohamad Haj Yahia > > VGT+ is a security feature that gives the administrator the ability of > controlling the allowed vlan-ids list that can be transmitted/received > from/to the VF. > The allowed vlan-ids list is called "trunk".

[net-next 04/15] i40e: Use correct flag to enable egress traffic for unicast promisc

2017-08-27 Thread Jeff Kirsher
From: Akeem G Abodunrin Albeit, we usually set true promiscuous mode for both multicast and unicast at the same time - however, it is possible to set it individually, so using allmulti flag which is only for allmulticast might caused unwanted behavior in mirroring egress traffic promiscuous for u

[net-next 02/15] i40e: Store the requested FEC information

2017-08-27 Thread Jeff Kirsher
From: Mariusz Stachura Store information about FEC modes, that were requested. It will be used in printing link status information function and this way there is no need to call admin queue there. Signed-off-by: Mariusz Stachura Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- driver

[net-next 13/15] i40e: invert logic for checking incorrect cpu vs irq affinity

2017-08-27 Thread Jeff Kirsher
From: Jacob Keller In commit 96db776a3682 ("i40e/vf: fix interrupt affinity bug") we added some code to force exit of polling in case we did not have the correct CPU. This is important since it was possible for the IRQ affinity to be changed while the CPU is pegged at 100%. This can result in the

[net-next 11/15] i40e: move enabling icr0 into i40e_update_enable_itr

2017-08-27 Thread Jeff Kirsher
From: Jacob Keller If we don't have MSI-X enabled, we handle interrupts on all icr0. This is a special case, so let's move the conditional into i40e_update_enable_itr() in order to make i40e_napi_poll easier to read about. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jef

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2017-08-27

2017-08-27 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Sudheer updates code comments and state variable so that adminq_subtask will have accutate information whenever it gets scheduled. Mariusz stores information about FEC modes, to be used to printing link states information, so that we do not ne

[net-next 06/15] i40e: force VMDQ device name truncation

2017-08-27 Thread Jeff Kirsher
From: Jacob Keller In new versions of GCC since 7.x a new warning exists which warns when a string is truncated before all of the format can be completed. When we setup VMDQ netdev names we are copying a pre-existing interface name which could be up to 15 characters in length. Since we also add

[net-next 09/15] i40e: Fix for unused value issue found by static analysis

2017-08-27 Thread Jeff Kirsher
From: Carolyn Wyborny This patch fixes an issue where an error return value is set, but without an immediate exit, the value can be overwritten by the following code execution. The condition at this point is not fatal, so remove the error assignment and comment the intent for future code mainta

[net-next 05/15] i40evf: fix possible snprintf truncation of q_vector->name

2017-08-27 Thread Jeff Kirsher
From: Jacob Keller The q_vector names are based on the interface name with a driver prefix, the type of q_vector setup, and the queue number. We previously set the size of this variable to IFNAMSIZ + 9, which is incorrect, because we actually include a minimum of 14 characters extra beyond the in

[net-next 03/15] i40e: prevent snprintf format specifier truncation

2017-08-27 Thread Jeff Kirsher
From: Jacob Keller Increase the size of the prefix buffer so that it can hold enough characters for every possible input. Although 20 is enough for all expected inputs, it is possible for the values to be larger than expected, resulting in a possibly truncated string. Additionally, lets use sizeo

[net-next 12/15] i40e: initialize our affinity_mask based on cpu_possible_mask

2017-08-27 Thread Jeff Kirsher
From: Jacob Keller On older kernels a call to irq_set_affinity_hint does not guarantee that the IRQ affinity will be set. If nothing else on the system sets the IRQ affinity this can result in a bug in the i40e_napi_poll() routine where we notice that our interrupt fired on the "wrong" CPU accord

[net-next 14/15] i40e/i40evf: remove ULTRA latency mode

2017-08-27 Thread Jeff Kirsher
From: Jacob Keller Since commit c56625d59726 ("i40e/i40evf: change dynamic interrupt thresholds") a new higher latency ITR setting called I40E_ULTRA_LATENCY was added with a cryptic comment about how it was meant for adjusting Rx more aggressively when streaming small packets. This mode was atte

[net-next 07/15] i40e/i40evf: support for VF VLAN tag stripping control

2017-08-27 Thread Jeff Kirsher
From: Mariusz Stachura This patch gives VF capability to control VLAN tag stripping via ethtool. As rx-vlan-offload was fixed before, now the VF is able to change it using "ethtool --offload rxvlan on/off" settings. Signed-off-by: Mariusz Stachura Signed-off-by: Jeff Kirsher --- drivers/net/

[net-next 08/15] i40e: 25G FEC status improvements

2017-08-27 Thread Jeff Kirsher
From: Mariusz Stachura This patch improves the system log message. The log message will be expanded to include the FEC mode the FW requested before link was established. Signed-off-by: Mariusz Stachura Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i

[net-next 15/15] i40e/i40evf: avoid dynamic ITR updates when polling or low packet rate

2017-08-27 Thread Jeff Kirsher
From: Jacob Keller The dynamic ITR algorithm depends on a calculation of usecs which assumes that the interrupts have been firing constantly at the interrupt throttle rate. This is not guaranteed because we could have a low packet rate, or have been polling in software. We'll estimate whether th

[net-next 10/15] i40e: remove workaround for resetting XPS

2017-08-27 Thread Jeff Kirsher
From: Jacob Keller Since commit 3ffa037d7f78 ("i40e: Set XPS bit mask to zero in DCB mode") we've tried to reset the XPS settings by building a custom empty CPU mask. This workaround is not necessary because we're not really removing the XPS setting, but simply setting it so that no CPU is valid

[net-next 01/15] i40e: Update state variable for adminq subtask

2017-08-27 Thread Jeff Kirsher
From: Sudheer Mogilappagari During NVM update, state machine gets into unrecoverable state because i40e_clean_adminq_subtask can get scheduled after the admin queue command but before other state variables are updated. This causes incorrect input to i40e_nvmupd_check_wait_event and state transiti

Re: [PATCH] ARM: dts: rk3228-evb: Fix the compiling error

2017-08-27 Thread Stephen Rothwell
Hi Dave, On Sun, 27 Aug 2017 16:59:43 -0700 (PDT) David Miller wrote: > > Sorry, I wasn't aware that this should go via my tree, I'll take care of > this soon. Thanks. -- Cheers, Stephen Rothwell

Re: [PATCH] ARM: dts: rk3228-evb: Fix the compiling error

2017-08-27 Thread David Miller
From: Stephen Rothwell Date: Mon, 28 Aug 2017 08:32:54 +1000 > Hi Dave (Miller), > > On Tue, 22 Aug 2017 21:52:51 +1000 Stephen Rothwell > wrote: >> >> Thanks. >> >> On Tue, 22 Aug 2017 17:24:25 +0800 David Wu wrote: >> > >> > This patch solves the following error: >> > arch/arm/boot/dts/rk3

Re: [PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()

2017-08-27 Thread Waskiewicz Jr, Peter
On 8/27/17 3:26 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 27 Aug 2017 21:18:37 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. Did coccinelle trip on the message or the fact yo

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-27 Thread Joe Perches
On Sun, 2017-08-27 at 18:53 +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 27, 2017 at 09:19:19AM -0700, Joe Perches wrote: > > On Sun, 2017-08-27 at 18:13 +0200, Greg Kroah-Hartman wrote: > > > On Sun, Aug 27, 2017 at 08:35:43AM -0700, Joe Perches wrote: > > > > On Sun, 2017-08-27 at 17:03 +0200,

Re: [PATCH] igb: check memory allocation failure

2017-08-27 Thread Waskiewicz Jr, Peter
On 8/27/17 2:42 AM, Christophe JAILLET wrote: > Check memory allocation failures and return -ENOMEM in such cases, as > already done for other memory allocations in this function. > > This avoids NULL pointers dereference. > > Signed-off-by: Christophe JAILLET > --- > drivers/net/ethernet/inte

Re: [PATCH] ARM: dts: rk3228-evb: Fix the compiling error

2017-08-27 Thread Stephen Rothwell
Hi Dave (Miller), On Tue, 22 Aug 2017 21:52:51 +1000 Stephen Rothwell wrote: > > Thanks. > > On Tue, 22 Aug 2017 17:24:25 +0800 David Wu wrote: > > > > This patch solves the following error: > > arch/arm/boot/dts/rk3228-evb.dtb: ERROR (phandle_references): Reference to > > non-existent node o

RE: [PATCH] DSA support for Micrel KSZ8895

2017-08-27 Thread Woojung.Huh
Pavel, Thanks for update and sorry about email format (due to web-access version) I'll do review when getting back to office later this week. - Woojung From: Pavel Machek [pa...@denx.de] Sent: Sunday, August 27, 2017 8:36 AM To: Woojung Huh - C21699; natha

[PATCH net-next] bridge: fdb add and delete tracepoints

2017-08-27 Thread Roopa Prabhu
From: Roopa Prabhu Tracepoints to trace bridge forwarding database updates. Signed-off-by: Roopa Prabhu --- include/trace/events/bridge.h | 98 +++ net/bridge/br_fdb.c | 7 net/core/net-traces.c | 6 +++ 3 files changed, 111 inse

Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket

2017-08-27 Thread Vallish Vaidyeshwara
On Tue, Aug 22, 2017 at 09:30:30PM -0700, David Miller wrote: > From: Vallish Vaidyeshwara > Date: Wed, 23 Aug 2017 00:10:25 + > > > I am submitting 2 patch series to enable hires timer to timeout > > datagram sockets (AF_UNIX & AF_INET domain) and test code to test > > timeout accuracy on th

[PATCH] connector: Delete an error message for a failed memory allocation in cn_queue_alloc_callback_entry()

2017-08-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 27 Aug 2017 21:18:37 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/connector/cn_queue.c | 4 +--- 1 file changed, 1 insertion(+),

Re: [PATCH V2 net-next] net-next/hinic: Fix MTU limitation

2017-08-27 Thread Andrew Lunn
On Mon, Aug 28, 2017 at 01:20:26AM +0800, Aviad Krawczyk wrote: > Fix the hw MTU limitation by setting max_mtu > > Signed-off-by: Aviad Krawczyk > Signed-off-by: Zhao Chen Reviewed-by: Andrew Lunn Andrew

[PATCH net-next] net-next/hinic: fix comparison of a uint16_t type with -1

2017-08-27 Thread Aviad Krawczyk
Remove the search for index of constant buffer size Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c | 37 +--- drivers/net/ethernet/huawei/hinic/hinic_hw_qp.h | 21 ++ 2 files changed, 22 insertions(+),

[PATCH V2 net-next] net-next/hinic: Fix MTU limitation

2017-08-27 Thread Aviad Krawczyk
Fix the hw MTU limitation by setting max_mtu Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_ma

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-27 Thread Florian Fainelli
On August 27, 2017 5:36:58 AM PDT, Pavel Machek wrote: >Hi! > >So I fought with the driver a bit more, and now I have something that >kind-of-works. > >"great great hack" belows worries me. > >Yeah, disabled code needs to be removed before merge. > >No, tag_ksz part probably is not acceptable. Do

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-27 Thread Greg Kroah-Hartman
On Sun, Aug 27, 2017 at 09:19:19AM -0700, Joe Perches wrote: > On Sun, 2017-08-27 at 18:13 +0200, Greg Kroah-Hartman wrote: > > On Sun, Aug 27, 2017 at 08:35:43AM -0700, Joe Perches wrote: > > > On Sun, 2017-08-27 at 17:03 +0200, Greg Kroah-Hartman wrote: > > > > The IRDA code has long been obsolet

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-27 Thread Andrew Lunn
> No, tag_ksz part probably is not acceptable. Do you see solution > better than just copying it into tag_ksz1 file? How about something like this, which needs further work to actually compile, but should give you the idea. Andrew index 99e38af85fc5..843e77b7c270 100644 --- a/net/dsa/ds

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-27 Thread Andrew Lunn
> +/** > + * sw_r_phy - read data from PHY register > + * @sw: The switch instance. > + * @phy: PHY address to read. > + * @reg: PHY register to read. > + * @val: Buffer to store the read data. > + * > + * This routine reads data from the PHY register. > + */ > +static void

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-27 Thread Joe Perches
On Sun, 2017-08-27 at 18:13 +0200, Greg Kroah-Hartman wrote: > On Sun, Aug 27, 2017 at 08:35:43AM -0700, Joe Perches wrote: > > On Sun, 2017-08-27 at 17:03 +0200, Greg Kroah-Hartman wrote: > > > The IRDA code has long been obsolete and broken. So, to keep people > > > from trying to use it, and to

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-27 Thread Greg Kroah-Hartman
On Sun, Aug 27, 2017 at 08:35:43AM -0700, Joe Perches wrote: > On Sun, 2017-08-27 at 17:03 +0200, Greg Kroah-Hartman wrote: > > The IRDA code has long been obsolete and broken. So, to keep people > > from trying to use it, and to prevent people from having to maintain it, > > let's move it to driv

Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-27 Thread Joe Perches
On Sun, 2017-08-27 at 17:03 +0200, Greg Kroah-Hartman wrote: > The IRDA code has long been obsolete and broken. So, to keep people > from trying to use it, and to prevent people from having to maintain it, > let's move it to drivers/staging/ so that we can delete it entirely from > the kernel in a

[PATCH 1/4] irda: move net/irda/ to drivers/staging/irda/net/

2017-08-27 Thread Greg Kroah-Hartman
It's time to get rid of IRDA. It's long been broken, and no one seems to use it anymore. So move it to staging and after a while, we can delete it from there. To start, move the network irda core from net/irda to drivers/staging/irda/net/ Signed-off-by: Greg Kroah-Hartman --- drivers/staging/

[PATCH 0/4] irda: move it to drivers/staging so we can delete it

2017-08-27 Thread Greg Kroah-Hartman
The IRDA code has long been obsolete and broken. So, to keep people from trying to use it, and to prevent people from having to maintain it, let's move it to drivers/staging/ so that we can delete it entirely from the kernel in a few releases. Greg Kroah-Hartman (4): irda: move net/irda/ to dr

[PATCH 4/4] staging: irda: add a TODO file.

2017-08-27 Thread Greg Kroah-Hartman
The irda code will be deleted in a future kernel release, so no need to have anyone do any new work on it. Signed-off-by: Greg Kroah-Hartman --- drivers/staging/irda/TODO | 4 1 file changed, 4 insertions(+) create mode 100644 drivers/staging/irda/TODO diff --git a/drivers/staging/irda/TO

[PATCH 2/4] irda: move drivers/net/irda to drivers/staging/irda/drivers

2017-08-27 Thread Greg Kroah-Hartman
Move the irda drivers from drivers/net/irda/ to drivers/staging/irda/drivers as they will be deleted in a future kernel release. Signed-off-by: Greg Kroah-Hartman --- drivers/net/Makefile| 1 - drivers/staging/Makefile|

[PATCH 3/4] irda: move include/net/irda into staging subdirectory

2017-08-27 Thread Greg Kroah-Hartman
And finally, move the irda include files into drivers/staging/irda/include/net/irda. Yes, it's a long path, but it makes it easy for us to just add a Makefile directory path addition and all of the net and drivers code "just works". Signed-off-by: Greg Kroah-Hartman --- drivers/staging/irda/dri

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-27 Thread David Ahern
On 8/25/17 8:49 PM, Alexei Starovoitov wrote: > >> +if (prog && curr_recursive && !new_recursive) >> +/* if a parent has recursive prog attached, only >> + * allow recursive programs in descendent cgroup >> + */ >> +return -EINVAL; >> + >> o

Re: [PATCH v2 net-next 1/8] bpf: Add support for recursively running cgroup sock filters

2017-08-27 Thread David Ahern
On 8/25/17 8:00 PM, Daniel Borkmann wrote: > Can you elaborate on the semantical changes for the programs > setting the new flag which are not using below cgroup_bpf_run_filter_sk() > helper to walk back to root? You mean other cgroup based programs -- BPF_CGROUP_* ? If so, any reason not to allow

Re: [PATCH] DSA support for Micrel KSZ8895

2017-08-27 Thread Andrew Lunn
On Sun, Aug 27, 2017 at 02:36:58PM +0200, Pavel Machek wrote: > Hi! > > So I fought with the driver a bit more, and now I have something that > kind-of-works. Thanks for keeping on working on this. > "great great hack" belows worries me. > > Yeah, disabled code needs to be removed before merg

Re: [PATCH net-next 4/8] net: ethernet: add the Alpine Ethernet driver

2017-08-27 Thread Chocron, Jonathan
This is a fixed version of my previous response (using proper indentation and leaving only the specific questions responded to). > > +/* MDIO */ > > +#define AL_ETH_MDIO_C45_DEV_MASK 0x1f > > +#define AL_ETH_MDIO_C45_DEV_SHIFT16 > > +#define AL_ETH_MDIO_C45_REG_MASK 0x > > + >

Re: [PATCH net-next v7 05/10] landlock: Add LSM hooks related to filesystem

2017-08-27 Thread Mickaël Salaün
On 26/08/2017 03:16, Alexei Starovoitov wrote: > On Fri, Aug 25, 2017 at 10:16:39AM +0200, Mickaël Salaün wrote: >>> +/* a directory inode contains only one dentry */ +HOOK_NEW_FS(inode_create, 3, + struct inode *, dir, + struct dentry *, dentry, + umode_t, mode,

[PATCH v4 4/7] dpaa_eth: enable Rx hashing control

2017-08-27 Thread Madalin Bucur
Allow ethtool control of the Rx flow hashing. By default RSS is enabled, this allows to turn it off by bypassing the FMan Keygen block and sending all traffic on the default Rx frame queue. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 113

[PATCH v4 0/7] Add RSS to DPAA 1.x Ethernet driver

2017-08-27 Thread Madalin Bucur
This patch set introduces Receive Side Scaling for the DPAA Ethernet driver. Documentation is updated with details related to the new feature and limitations that apply. Added also a small fix. v2: removed a C++ style comment v3: move struct fman to header file to avoid exporting a function v4: ad

[PATCH v4 3/7] dpaa_eth: use multiple Rx frame queues

2017-08-27 Thread Madalin Bucur
Add a block of 128 Rx frame queues per port. The FMan hardware will send traffic on one of these queues based on the FMan port Parse Classify Distribute setup. The hash computed by the FMan Keygen block will select the Rx FQ. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/d

[PATCH v4 2/7] fsl/fman: enable FMan Keygen

2017-08-27 Thread Madalin Bucur
From: Iordache Florinel-R70177 Add support for the FMan Keygen with a hardcoded scheme to spread incoming traffic on a FQ range based on source and destination IPs and ports. Signed-off-by: Iordache Florinel Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/Makefile |

[PATCH v4 1/7] fsl/fman: move struct fman to header file

2017-08-27 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman.c | 80 + drivers/net/ethernet/freescale/fman/fman.h | 75 +++ drivers/net/ethernet/freescale/fman/fman_port.c | 8 +-- 3 files changed, 82 insertions(+), 81 deletions(

[PATCH v4 6/7] Documentation: networking: add RSS information

2017-08-27 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- Documentation/networking/dpaa.txt | 68 ++- 1 file changed, 67 insertions(+), 1 deletion(-) diff --git a/Documentation/networking/dpaa.txt b/Documentation/networking/dpaa.txt index 76e016d..f88194f 100644 --- a/Documentation/n

[PATCH v4 5/7] dpaa_eth: add NETIF_F_RXHASH

2017-08-27 Thread Madalin Bucur
Set the skb hash when then FMan Keygen hash result is available. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 23 +++--- drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 1 + drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 9 +++

[PATCH v4 7/7] dpaa_eth: check allocation result

2017-08-27 Thread Madalin Bucur
Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 73ca8d7..4225806 100644 --- a/drivers/net/ethernet/freescal

Re: Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session]

2017-08-27 Thread Greg KH
On Wed, Aug 23, 2017 at 08:14:15PM +0200, Marcel Holtmann wrote: > Hi Jiri, > > >>> It looks like bnep_session has same pattern as the issue reported in > >>> old rfcomm: > >>> > >>> while (1) { > >>> set_current_state(TASK_INTERRUPTIBLE); > >>> if (condition) > >>>

Re: [PATCH 0/4] net: stmmac: revert the EMAC bindings

2017-08-27 Thread Chen-Yu Tsai
On Sat, Aug 26, 2017 at 3:12 AM, Maxime Ripard wrote: > Hi, > > The bindings of the stmmac glue for the new Allwinner EMAC controller > are still controversial and being discussed, even though they've been > merged in 4.13. > > In order not to introduce any binding we do not really want to commit

[PATCH] DSA support for Micrel KSZ8895

2017-08-27 Thread Pavel Machek
Hi! So I fought with the driver a bit more, and now I have something that kind-of-works. "great great hack" belows worries me. Yeah, disabled code needs to be removed before merge. No, tag_ksz part probably is not acceptable. Do you see solution better than just copying it into tag_ksz1 file?

[PATCH net-next 2/4] net/mlx5: Add SRIOV VGT+ support

2017-08-27 Thread Saeed Mahameed
From: Mohamad Haj Yahia Implementing the VGT+ feature via acl tables. The acl tables will hold the actual needed rules which is only the intersection of the requested vlan-ids list and the allowed vlan-ids list from the administrator. Signed-off-by: Mohamad Haj Yahia Signed-off-by: Eugenia Eman

[PATCH net-next 0/4] SRIOV VF VGT+ and violation counters support

2017-08-27 Thread Saeed Mahameed
Hi Dave This series provides two security SRIOV related features (VGT+ and VF violation counters). VGT+ is a security feature that gives the administrator the ability of controlling the allowed VGT vlan IDs list that can be transmitted/received from/to the VF. The allowed VGT vlan IDs list is c

[PATCH net-next 1/4] net: Add SRIOV VGT+ support

2017-08-27 Thread Saeed Mahameed
From: Mohamad Haj Yahia VGT+ is a security feature that gives the administrator the ability of controlling the allowed vlan-ids list that can be transmitted/received from/to the VF. The allowed vlan-ids list is called "trunk". Admin can add/remove a range of allowed vlan-ids via iptool. Example:

[PATCH net-next 4/4] net/mlx5e: E-switch, Add steering drop counters

2017-08-27 Thread Saeed Mahameed
From: Eugenia Emantayev Add flow counters to count packets dropped due to drop rules configured in eswitch egress and ingress ACLs. These counters will count VFs violations and incoming traffic drops. Will be presented on hypervisor via standard 'ip -s link show' command. Example: "ip -s link sh

[PATCH net-next 3/4] net/core: Add violation counters to VF statisctics

2017-08-27 Thread Saeed Mahameed
From: Eugenia Emantayev Add receive and transmit violation counters to be displayed in iproute2 VF statistics. Signed-off-by: Eugenia Emantayev Signed-off-by: Saeed Mahameed --- include/linux/if_link.h | 2 ++ include/uapi/linux/if_link.h | 2 ++ net/core/rtnetlink.c | 10 +

Re: [PATCH net] bridge: check for null fdb->dst before notifying switchdev drivers

2017-08-27 Thread Arkadi Sharshevsky
On 08/27/2017 07:13 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > current switchdev drivers dont seem to support offloading fdb > entries pointing to the bridge device which have fdb->dst > not set to any port. This patch adds a NULL fdb->dst check in > the switchdev notifier code. > > This

Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings only on default

2017-08-27 Thread Neftin, Sasha
On 8/27/2017 11:32, Neftin, Sasha wrote: On 8/27/2017 11:30, Neftin, Sasha wrote: On 8/25/2017 18:06, Willem de Bruijn wrote: From: Willem de Bruijn Devices that support FLAG2_DMA_BURST have different default values for RDTR and RADV. Apply burst mode default settings only when no explicit va

Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings only on default

2017-08-27 Thread Neftin, Sasha
On 8/27/2017 11:30, Neftin, Sasha wrote: On 8/25/2017 18:06, Willem de Bruijn wrote: From: Willem de Bruijn Devices that support FLAG2_DMA_BURST have different default values for RDTR and RADV. Apply burst mode default settings only when no explicit value was passed at module load. The RDTR d

Re: [patch net-next 11/12] mlxsw: spectrum_dpipe: Add support for IPv4 host table dump

2017-08-27 Thread Arkadi Sharshevsky
On 08/25/2017 10:51 PM, David Ahern wrote: > On 8/25/17 2:26 AM, Arkadi Sharshevsky wrote: >> >> >> On 08/24/2017 10:26 PM, David Ahern wrote: >>> On 8/23/17 11:40 PM, Jiri Pirko wrote: +static int +mlxsw_sp_dpipe_table_host_entries_get(struct mlxsw_sp *mlxsw_sp, +

Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings only on default

2017-08-27 Thread Neftin, Sasha
On 8/25/2017 18:06, Willem de Bruijn wrote: From: Willem de Bruijn Devices that support FLAG2_DMA_BURST have different default values for RDTR and RADV. Apply burst mode default settings only when no explicit value was passed at module load. The RDTR default is zero. If the module is loaded fo

Re: [PATCH] pktgen: add a new sample script for 40G and above link testing

2017-08-27 Thread Tariq Toukan
On 25/08/2017 12:26 PM, Robert Hoo wrote: (Sorry for yesterday's wrong sending, I finally fixed my MTA and git send-email settings.) It's hard to benchmark 40G+ network bandwidth using ordinary tools like iperf, netperf (see reference 1). Pktgen, packet generator from Kernel sapce, shall be a

[PATCH] be2net: Fix some u16 fields appropriately

2017-08-27 Thread Haishuang Yan
In be_tx_compl_process, frag_index declared as u32, so it's better to declare last_index as u32 also. CC: Ajit Khaparde Fixes: b0fd2eb28bd4 ("be2net: Declare some u16 fields as u32 to improve performance") Signed-off-by: Haishuang Yan --- drivers/net/ethernet/emulex/benet/be.h | 2 +- driv