Re: Driver profiles RFC

Fri, Aug 11, 2017 at 11:57:38PM CEST, kubak...@wp.pl wrote: >On Tue, 8 Aug 2017 16:15:41 +0300, Arkadi Sharshevsky wrote: >> Driver <--> Devlink API >> === >> Each driver will register his resources with default values at init in >> a similar way to DPIPE table registration. In

Re: [PATCH net-next] liquidio: update debug console logging mechanism

On Fri, Aug 11, 2017 at 06:43:14PM -0700, Felix Manlunas wrote: > From: Rick Farrington > > - remove logging dependency upon global func octeon_console_debug_enabled() > - abstract debug console logging using console structure (via function ptr) > to allow for more flexible logging > > Signed-of

Re: [PATCH 1/2] mpls: add handlers

On Sat, Aug 12, 2017 at 6:35 AM, Amine Kherbouche wrote: > > > On 11/08/2017 16:37, Roopa Prabhu wrote: >> >> On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter >> wrote: >>> >>> On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote: Mpls handler allows creation/deletion of mpl

Re: [PATCH 2/2] drivers: add vpls support

On Sat, Aug 12, 2017 at 6:40 AM, Amine Kherbouche wrote: > > > On 11/08/2017 17:14, Roopa Prabhu wrote: >> >> On Fri, Aug 11, 2017 at 5:55 AM, David Lamparter >> wrote: >>> >>> On Thu, Aug 10, 2017 at 10:28:37PM +0200, Amine Kherbouche wrote: This commit introduces the support of VPLS v

[PATCH] liquidio: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only. drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 11 +++ 1 file changed, 3 in

[PATCH] qlge: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- This code was tested by compilation only. drivers/net/ethernet/qlogic/qlge/qlge_dbg.c | 47 + 1 file ch

Linux MPLS traceroute failure

Testing MPLS from Linux kernel 4.12. The trace route is duplicete pe-p hop. This is not visible MPLS label on traceroute. root@ne-vlezay80:~# traceroute -e 10.10.10.4 traceroute to 10.10.10.4 (10.10.10.4), 30 hops max, 60 byte packets 1 10.5.5.1 (10.5.5.1) 0.028 ms 0.005 ms 0.006 ms 2 10.4

NACK: [PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static

On 12/08/17 23:00, Colin King wrote: > From: Colin Ian King > > The function btc8723b2ant_dac_swing is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'btc8723b2ant_dac_swing' was not declared. Should it be static? > > Si

[PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static

From: Colin Ian King The function btc8723b2ant_dac_swing is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'btc8723b2ant_dac_swing' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/net/wireless/

[PATCH] tap: make struct tap_fops static

From: Colin Ian King The structure tap_fops is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'tap_fops' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/net/tap.c | 2 +- 1 file changed, 1 inser

[PATCH] virtio-net: make array guest_offloads static

From: Colin Ian King The array guest_offloads is local to the source and does not need to be in global scope, so make it static. Also tweak formatting. Cleans up sparse warnings: symbol 'guest_offloads' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/net/virti

[PATCH] of_mdio: merge branch tails in of_phy_register_fixed_link()

Looks like gcc isn't always able to figure out that 3 *if* branches in of_phy_register_fixed_link() calling fixed_phy_register() at their ends are similar enough and thus can be merged. The "manual" merge saves 40 bytes of the object code (AArch64 gcc 4.8.5), and still saves 12 bytes even if gcc

Re: [net-next 08/15] i40e/i40evf: organize and re-number feature flags

From: Jeff Kirsher Date: Sat, 12 Aug 2017 04:08:41 -0700 > Also ensure that the flags variable is actually a u64 to guarantee > 64bits of space on all architectures. Why? You don't need 64-bits, you only need 27. This will be unnecessarily expensive on 32-bit platforms. Please don't do this.

Re: [net-next 3/4] i40evf: prevent VF close returning before state tranistions to DOWN

It seems like you sent two copies of this patch, one here which seems part of a 4 patch series, and then another for the 03/15 copy. Please sort that out.

Re: [net-next 01/15] i40e/i40evf: fix some minor type mismatches

From: Jeff Kirsher Date: Sat, 12 Aug 2017 04:08:33 -0700 > @@ -1830,7 +1830,7 @@ static struct sk_buff *i40e_construct_skb(struct > i40e_ring *rx_ring, > /* prefetch first cache line of first page */ > prefetch(xdp->data); > #if L1_CACHE_BYTES < 128 > - prefetch(xdp->data + L1_C

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

Hi Ido, >> - if ((rt->dst.dev == dev || !dev) && >> + if ((rt->dst.dev == dev || !dev || >> + rt->rt6i_idev->dev == dev) && > > Can you please explain why this line is needed? While host routes aren't > removed from the FIB by rt6_ifdown() (when dst.dev goes down), they are > remo

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

Hey Kalle Still, a problem: On 08/12/2017 01:35 AM, Kalle Valo wrote: > Kalle Valo writes: > >> Andreas Born writes: >> >>> Earlier today I submitted the patch (bonding: require speed/duplex >>> only for 802.3ad, alb and tlb) [2] that only partially reverts what is >>> a regression following m

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Fri, Aug 11, 2017 at 8:37 PM, David Ahern wrote: > On 8/11/17 6:25 PM, Wei Wang wrote: >> By "a patch to fix that" do you mean after your patch, for every rt6, >> rt6->rt6i_idev will be the same as rt6->dst.dev? > > FIB entries should have them the same device with my patch. > > The copies done

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Fri, Aug 11, 2017 at 8:07 PM, John Stultz wrote: > On Fri, Aug 11, 2017 at 5:31 PM, John Stultz wrote: >> On Fri, Aug 11, 2017 at 5:10 PM, Wei Wang wrote: If after Cong's fix, the issue still happens, could you help try the patch attached and collect all logs when you try the reprod

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

> Looks good so far! I've not hit the issue yet. > Great. I will prepare an official patch then. > Thanks so much for sorting out a fix! > > If its useful: > Tested-by: John Stultz Sure will do. Thanks. Wei On Fri, Aug 11, 2017 at 8:07 PM, John Stultz wrote: > On Fri, Aug 11, 2017 at 5:31 PM

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

Hi Wei, On Fri, Aug 11, 2017 at 05:10:02PM -0700, Wei Wang wrote: > I think we have a potential fix for this issue. > Martin and I found that when addrconf_dst_alloc() creates a rt6, it is > possible that rt6->dst.dev points to loopback device while > rt6->rt6i_idev->dev points to a real device. >

Re: Performance comparision / qdisc / no qdisc / queueing linux kernel 4.12

On Fri, Aug 11, 2017 at 4:16 PM, Stephen Hemminger wrote: > Any of the current qdisc that do rate control are single threaded. > Since bandwidth is a shared resource, the qdisc has to acquire a lock > and update cache shared data structures. > > Don't expect HTB or HFSC to be free. > This is a wel

[PATCH] net/i40evf: use cpumask_copy() for assigning cpumask

Using direct assignment for a cpumask is wrong, cpumask_copy() should be used instead. Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross --- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40evf

[PATCH] net/i40e: use cpumask_copy() for assigning cpumask

Using direct assignment for a cpumask is wrong, cpumask_copy() should be used instead. Cc: sta...@vger.kernel.org Signed-off-by: Juergen Gross --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_

Re: [PATCH] New Chapter on CodingStyle .

On Sat, 12 Aug 2017 14:23:18 +0300 Corcodel Marian wrote: > --- > Documentation/CodingStyle | 28 > 1 file changed, 28 insertions(+) > > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle > index 9a70ddd..864dd8b 100644 > --- a/Documentation/CodingSt

Re: [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured

On Thu, Aug 10, 2017 at 05:11:51PM +, Ohad Oz wrote: > Patch allows Mellanox devices on system with no PCI, but with I2C only. > Did you test mlx5 device on such system? Did it work for you? What is the changelog between v0 and v1 of these patches? > Signed-off-by: Ohad Oz > --- > drivers

Re: [PATCH 2/2] drivers: add vpls support

On 11/08/2017 17:14, Roopa Prabhu wrote: On Fri, Aug 11, 2017 at 5:55 AM, David Lamparter wrote: On Thu, Aug 10, 2017 at 10:28:37PM +0200, Amine Kherbouche wrote: This commit introduces the support of VPLS virtual device, that allows performing L2VPN multipoint to multipoint communication o

Re: [PATCH 1/2] mpls: add handlers

On 11/08/2017 16:37, Roopa Prabhu wrote: On Fri, Aug 11, 2017 at 5:34 AM, David Lamparter wrote: On Thu, Aug 10, 2017 at 10:28:36PM +0200, Amine Kherbouche wrote: Mpls handler allows creation/deletion of mpls routes without using rtnetlink. When an incoming mpls packet matches this route, th

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Fri, 11 Aug 2017 19:51:10 +0200 Paweł Staszewski wrote: > Hi > > I made some tests for performance comparison. Thanks for doing this. Feel free to Cc me, if you do more of these tests (so I don't miss them on the mailing list). I don't understand stand if you are reporting a potential pro

[iproute PATCH 49/51] lib/ll_map: Make sure im->name is NULL-terminated

Signed-off-by: Phil Sutter --- lib/ll_map.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ll_map.c b/lib/ll_map.c index 4e4556c9ac80b..4d06eb69f138a 100644 --- a/lib/ll_map.c +++ b/lib/ll_map.c @@ -120,11 +120,11 @@ int ll_remember_index(const struct sockaddr_nl *who

[iproute PATCH 32/51] ss: Make sure index variable is >= 0

This shouldn't happen but relying upon external data without checking may lead to unexpected results. Signed-off-by: Phil Sutter --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index d767b1103ea81..4d2f75b571ea6 100644 --- a/misc/ss.c +++ b

[iproute PATCH 02/51] devlink: No need for this self-assignment

dl_argv_handle_both() will either assign to handle_bit or error out in which case the variable is not used by the caller. Signed-off-by: Phil Sutter --- devlink/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index de41a9f4aae10

[iproute PATCH 24/51] ifstat, nstat: Check fdopen() return value

Prevent passing NULL FILE pointer to fgets() later. Fix both tools in a single patch since the code changes are basically identical. Signed-off-by: Phil Sutter --- misc/ifstat.c | 16 +++- misc/nstat.c | 16 +++- 2 files changed, 22 insertions(+), 10 deletions(-) diff

[iproute PATCH 12/51] iproute_lwtunnel: csum_mode value checking was ineffective

ila_csum_name2mode() returning -1 on error but being declared as returning __u8 doesn't make much sense. Change the code to correctly detect this issue. Checking for __u8 overruns shouldn't be necessary though since ila_csum_name2mode() return values are well-defined. Signed-off-by: Phil Sutter -

[iproute PATCH 44/51] tipc/bearer: Fix resource leak in error path

Signed-off-by: Phil Sutter --- tipc/bearer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tipc/bearer.c b/tipc/bearer.c index 810344f672af1..c3d4491f8f6ef 100644 --- a/tipc/bearer.c +++ b/tipc/bearer.c @@ -163,6 +163,7 @@ static int nl_add_udp_enable_opts(struct nlmsghdr *nlh, struct o

[iproute PATCH 46/51] tipc/node: Fix socket fd check in cmd_node_get_addr()

socket() returns -1 on error, not 0. Signed-off-by: Phil Sutter --- tipc/node.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tipc/node.c b/tipc/node.c index 201fe1a4df3bd..fe085aec9b4ac 100644 --- a/tipc/node.c +++ b/tipc/node.c @@ -109,7 +109,8 @@ static int cmd_node_ge

[iproute PATCH 43/51] tc/tc_filter: Make sure filter name is not empty

The later check for 'k[0] != 0' requires a non-empty filter name, otherwise NULL pointer dereference in 'q' might happen. Signed-off-by: Phil Sutter --- tc/tc_filter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tc/tc_filter.c b/tc/tc_filter.c index b13fb9185d4fd..a799edb35886d 100644

[iproute PATCH 15/51] ipvrf: Fix error path of vrf_switch()

Apart from trying to close(-1), this also leaked memory. Signed-off-by: Phil Sutter --- ip/ipvrf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ip/ipvrf.c b/ip/ipvrf.c index 92e2db98ca7d7..75cc026d072b8 100644 --- a/ip/ipvrf.c +++ b/ip/ipvrf.c @@ -373,12 +373,12 @

[iproute PATCH 06/51] iplink_vrf: Complain if main table is not found

Signed-off-by: Phil Sutter --- ip/iplink_vrf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ip/iplink_vrf.c b/ip/iplink_vrf.c index 917630e853375..809eda5de8f6e 100644 --- a/ip/iplink_vrf.c +++ b/ip/iplink_vrf.c @@ -131,7 +131,10 @@ __u32 ipvrf_get_table(const char *nam

[iproute PATCH 07/51] ipmaddr: Avoid accessing uninitialized data

Looks like this can only happen if /proc/net/igmp is malformed, but better be sure. Signed-off-by: Phil Sutter --- ip/ipmaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipmaddr.c b/ip/ipmaddr.c index 4f726fdd976f1..85a69e779563d 100644 --- a/ip/ipmaddr.c +++ b/ip/ip

[iproute PATCH 42/51] tc/q_netem: Don't dereference possibly NULL pointer

Assuming 'opt' might be NULL, move the call to RTA_PAYLOAD to after the check since it dereferences its parameter. Signed-off-by: Phil Sutter --- tc/q_netem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tc/q_netem.c b/tc/q_netem.c index 0975ae111de97..7e3330512041a 100

[iproute PATCH 17/51] lib/bpf: Don't leak fp in bpf_find_mntpt()

If fopen() succeeded but len != PATH_MAX, the function leaks the open FILE pointer. Fix this by checking len value before calling fopen(). Signed-off-by: Phil Sutter --- lib/bpf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/bpf.c b/lib/bpf.c index 4f52ad4a8f023..1

[iproute PATCH 37/51] netem/maketable: Check return value of fscanf()

Signed-off-by: Phil Sutter --- netem/maketable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netem/maketable.c b/netem/maketable.c index ad660e7d457f0..ccb8f0c68b062 100644 --- a/netem/maketable.c +++ b/netem/maketable.c @@ -38,8 +38,8 @@ readdoubles(FILE *fp, int *num

[iproute PATCH 18/51] lib/fs: Fix format string in find_fs_mount()

A field width of 4096 allows fscanf() to store that amount of characters into the given buffer, though that doesn't include the terminating NULL byte. Decrease the value by one to leave space for it. Signed-off-by: Phil Sutter --- lib/fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[iproute PATCH 19/51] lib/fs: Fix and simplify make_path()

Calling stat() before mkdir() is racey: The entry might change in between. Also, the call to stat() seems to exist only to check if the directory exists already. So simply call mkdir() unconditionally and catch only errors other than EEXIST. Signed-off-by: Phil Sutter --- lib/fs.c | 20 +

[iproute PATCH 16/51] xfrm_state: Make sure alg_name is NULL-terminated

Signed-off-by: Phil Sutter --- ip/xfrm_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/xfrm_state.c b/ip/xfrm_state.c index e11c93bf1c3b5..7c0389038986e 100644 --- a/ip/xfrm_state.c +++ b/ip/xfrm_state.c @@ -125,7 +125,8 @@ static int xfrm_algo_parse(struct xfrm_a

[iproute PATCH 14/51] ipvrf: Don't try to close an invalid fd

Signed-off-by: Phil Sutter --- ip/ipvrf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ip/ipvrf.c b/ip/ipvrf.c index 0094cf8557cd7..92e2db98ca7d7 100644 --- a/ip/ipvrf.c +++ b/ip/ipvrf.c @@ -268,7 +268,7 @@ static int vrf_configure_cgroup(const char *path, int ifind

[iproute PATCH 50/51] Check user supplied interface name lengths

The original problem was that something like: | strncpy(ifr.ifr_name, *argv, IFNAMSIZ); might leave ifr.ifr_name unterminated if length of *argv exceeds IFNAMSIZ. In order to fix this, I thought about replacing all those cases with (equivalent) calls to snprintf() or even introducing strlcpy(). B

[iproute PATCH 08/51] ipntable: No need to check and assign to parms_rta

This variable is initialized at declaration and nowhere else does any assignment to it happen, so just drop the check. Signed-off-by: Phil Sutter --- ip/ipntable.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ip/ipntable.c b/ip/ipntable.c index 879626ee4f491..1837909fa42e7 100644 --- a/i

[iproute PATCH 04/51] ipaddress: Avoid accessing uninitialized variable lcl

If no address was given, ipaddr_modify() accesses uninitialized data when assigning to req.ifa.ifa_prefixlen. Signed-off-by: Phil Sutter --- ip/ipaddress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index 3c9decb51b412..9307c9416dde3 10064

[iproute PATCH 33/51] ss: Don't leak fd in tcp_show_netlink_file()

Signed-off-by: Phil Sutter --- misc/ss.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 4d2f75b571ea6..cda5e3b6a2d6f 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -2687,41 +2687,44 @@ static int tcp_show_netlink_file(

[iproute PATCH 34/51] ss: Make sure scanned index value to unix_state_map is sane

Signed-off-by: Phil Sutter --- misc/ss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index cda5e3b6a2d6f..667b8faad6528 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -3150,7 +3150,8 @@ static int unix_show(struct filter *f) if (flags &

[iproute PATCH 28/51] nstat: Avoid passing negative fd to fdopen()

Introduce a wrapper which does the sanity checking and returns NULL in case fd is invalid. Signed-off-by: Phil Sutter --- misc/nstat.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/misc/nstat.c b/misc/nstat.c index 23e1569d7872b..c1e7ddec271e2 100644 --- a/

[iproute PATCH 30/51] ss: Skip useless check in parse_hostcond()

The passed 'addr' parameter is dereferenced by caller before and in parse_hostcond() multiple times before this check, so assume it is always true. Signed-off-by: Phil Sutter --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index b4f89c85c2d

[iproute PATCH 41/51] tc/q_multiq: Don't pass garbage in TCA_OPTIONS

multiq_parse_opt() doesn't change 'opt' at all. So at least make sure it doesn't fill TCA_OPTIONS attribute with garbage from stack. Signed-off-by: Phil Sutter --- tc/q_multiq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/q_multiq.c b/tc/q_multiq.c index 7823931494563.

[iproute PATCH 40/51] tc/m_xt: Fix for potential string buffer overflows

- Use strncpy() when writing to target->t->u.user.name and make sure the final byte remains untouched (xtables_calloc() set it to zero). - 'tname' length sanitization was completely wrong: If it's length exceeded the 16 bytes available in 'k', passing a length value of 16 to strncpy() would o

[iproute PATCH 39/51] tc/m_gact: Drop dead code

The use of 'ok' variable in parse_gact() is ineffective: The second conditional increments it either if *argv is 'gact' or if parse_action_control() doesn't fail (in which case exit() is called). So this is effectively an unconditional increment and since no decrement happens anywhere, all remainin

[iproute PATCH 03/51] ipaddress: Make buffer for filter.flushb static

The buffer is accessed outside of the function defining it, so make it static. Signed-off-by: Phil Sutter --- ip/ipaddress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index 4d37c5e045071..3c9decb51b412 100644 --- a/ip/ipaddress.c +++ b/ip

[iproute PATCH 45/51] tipc/bearer: Prevent NULL pointer dereference

Signed-off-by: Phil Sutter --- tipc/bearer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tipc/bearer.c b/tipc/bearer.c index c3d4491f8f6ef..0598328ab1f1b 100644 --- a/tipc/bearer.c +++ b/tipc/bearer.c @@ -438,8 +438,8 @@ static int cmd_bearer_enable(struct nlmsghdr *nl

[iproute PATCH 00/51] Fix potential issues detected by Coverity tool

Covscan really wasn't amused (indicated by the number of patches in this series). Try to make it happy. Phil Sutter (51): devlink: Check return code of strslashrsplit() devlink: No need for this self-assignment ipaddress: Make buffer for filter.flushb static ipaddress: Avoid accessing unin

[iproute PATCH 20/51] lib/inet_proto: Make sure destination buffers are NULL-terminated

Signed-off-by: Phil Sutter --- lib/inet_proto.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/inet_proto.c b/lib/inet_proto.c index ceda082b12a2e..87ed4769fc3da 100644 --- a/lib/inet_proto.c +++ b/lib/inet_proto.c @@ -35,8 +35,10 @@ const char *inet_proto_n2a(in

[iproute PATCH 36/51] netem/maketable: Check return value of fstat()

Otherwise info.st_size may contain garbage. Signed-off-by: Phil Sutter --- netem/maketable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netem/maketable.c b/netem/maketable.c index 6aff927be7040..ad660e7d457f0 100644 --- a/netem/maketable.c +++ b/netem/maketable.c @@

[iproute PATCH 23/51] ifstat: Fix memleak in error case

Signed-off-by: Phil Sutter --- misc/ifstat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/misc/ifstat.c b/misc/ifstat.c index a853ee6d7e3b3..8fa354265a9a1 100644 --- a/misc/ifstat.c +++ b/misc/ifstat.c @@ -143,8 +143,10 @@ static int get_nlmsg_extended(const struct socka

[iproute PATCH 47/51] examples: Some shell fixes to cbq.init

This addresses the following issues: - $@ is an array, so don't use it in quoted strings - use $* instead. - Add missing quotes to components of [ ] expressions. These are not strictly necessary since the output of 'wc -l' should be a single word only, but in case of errors, bash prints "inte

[iproute PATCH 09/51] ipntable: Make sure filter.name is NULL-terminated

Signed-off-by: Phil Sutter --- ip/ipntable.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/ipntable.c b/ip/ipntable.c index 1837909fa42e7..30907146e85a3 100644 --- a/ip/ipntable.c +++ b/ip/ipntable.c @@ -631,7 +631,8 @@ static int ipntable_show(int argc, char **argv)

[iproute PATCH 11/51] iproute: Check mark value input

Signed-off-by: Phil Sutter --- ip/iproute.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 89caac124f489..5fe8a3a75d5b7 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -1495,7 +1495,8 @@ static int iproute_list_flush_or_save(int argc, c

[iproute PATCH 05/51] iplink_can: Prevent overstepping array bounds

can_state_names array contains at most CAN_STATE_MAX fields, so allowing an index to it to be equal to that number is wrong. While here, also make sure the array is indeed that big so nothing bad happens if CAN_STATE_MAX ever increases. Signed-off-by: Phil Sutter --- ip/iplink_can.c | 4 ++-- 1

[iproute PATCH 48/51] ifcfg: Quote left-hand side of [ ] expression

This prevents word-splitting and therefore leads to more accurate error message in case 'grep -c' prints something other than a number. Signed-off-by: Phil Sutter --- ip/ifcfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ifcfg b/ip/ifcfg index 083d9df36742f..30a2dc49816

[iproute PATCH 10/51] iproute: Fix for missing 'Oifs:' display

Covscan complained about dead code but after reading it, I assume the author's intention was to prefix the interface list with 'Oifs: '. Initializing first to 1 and setting it to 0 after above prefix was printed should fix it. Signed-off-by: Phil Sutter --- ip/iproute.c | 8 +--- 1 file chan

[iproute PATCH 13/51] iproute_lwtunnel: Argument to strerror must be positive

Signed-off-by: Phil Sutter --- ip/iproute_lwtunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute_lwtunnel.c b/ip/iproute_lwtunnel.c index 398ab5e077ed8..1a3dc4d4c0ed9 100644 --- a/ip/iproute_lwtunnel.c +++ b/ip/iproute_lwtunnel.c @@ -643,7 +643,7 @@ static int l

[iproute PATCH 01/51] devlink: Check return code of strslashrsplit()

This function shouldn't fail because all callers of __dl_argv_handle_port() make sure the passed string contains enough slashes already, but better make sure if this changes in future the function won't access uninitialized data. Signed-off-by: Phil Sutter --- devlink/devlink.c | 16

[iproute PATCH 38/51] tc/em_ipset: Don't leak sockfd on error path

Signed-off-by: Phil Sutter --- tc/em_ipset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tc/em_ipset.c b/tc/em_ipset.c index fab975f5ea563..b59756515d239 100644 --- a/tc/em_ipset.c +++ b/tc/em_ipset.c @@ -84,6 +84,7 @@ static int get_version(unsigned int *version) res = getsockopt

[iproute PATCH 26/51] lnstat_util: Simplify alloc_and_open() a bit

Relying upon callers and using unsafe strcpy() is probably not the best idea. Aside from that, using snprintf() allows to format the string for lf->path in one go. Signed-off-by: Phil Sutter --- misc/lnstat_util.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/misc/ln

[iproute PATCH 27/51] nstat: Fix for potential NULL pointer dereference

If the string at 'p' contains neither space not newline, 'p' will become NULL. Make sure this isn't the case before dereferencing it. Signed-off-by: Phil Sutter --- misc/nstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/nstat.c b/misc/nstat.c index a4dd405d43a93..2

[iproute PATCH 25/51] ifstat: Fix memleak in dump_kern_db() for json output

Looks like this was forgotten when converting to common json output formatter. Fixes: fcc16c2287bf8 ("provide common json output formatter") Signed-off-by: Phil Sutter --- misc/ifstat.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/misc/ifstat.c b/misc/ifstat.c inde

[iproute PATCH 31/51] ss: Drop useless assignment

After '*b = *a', 'b->next' already has the same value as 'a->next'. Signed-off-by: Phil Sutter --- misc/ss.c | 1 - 1 file changed, 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index 5ea388fbf1c1a..d767b1103ea81 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -1440,7 +1440,6 @@ static int remembe

[iproute PATCH 35/51] ss: Fix potential memleak in unix_stats_print()

Fixes: 2d0e538f3e1cd ("ss: Drop list traversal from unix_stats_print()") Signed-off-by: Phil Sutter --- misc/ss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index 667b8faad6528..7d84b83c8ad71 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -3170,8 +3170

[iproute PATCH 51/51] lib/bpf: Check return value of write()

This is merely to silence the compiler warning. If write to stderr failed, assume that printing an error message will fail as well so don't even try. Signed-off-by: Phil Sutter --- lib/bpf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/bpf.c b/lib/bpf.c index 1dcb261

[iproute PATCH 29/51] ss: Use C99 initializer in netlink_show_one()

This has the additional benefit of initializing st.ino to zero which is used later in is_sctp_assoc() function. Signed-off-by: Phil Sutter --- misc/ss.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index f0d1c22f75cff..b4f89c85c2d52 1006

[iproute PATCH 21/51] lib/libnetlink: Don't pass NULL parameter to memcpy()

Both addattr_l() and rta_addattr_l() may be called with NULL data pointer and 0 alen parameters. Avoid calling memcpy() in that case. Signed-off-by: Phil Sutter --- lib/libnetlink.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/libnetlink.c b/lib/libnetlink.c inde

[iproute PATCH 22/51] lib/rt_names: Drop dead code in rtnl_rttable_n2a()

Since 'id' is 32bit unsigned, it can never exceed RT_TABLE_MAX (which is defined to 0x). Therefore drop that never matching conditional. Signed-off-by: Phil Sutter --- lib/rt_names.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/rt_names.c b/lib/rt_names.c index 04c15ff5b15f

[net-next 06/15] i40e: remove workaround for Open Firmware MAC address

From: Jacob Keller Since commit b499ffb0a22c ("i40e: Look up MAC address in Open Firmware or IDPROM"), we've had support for obtaining the MAC address form Open Firmware or IDPROM. This code relied on sending the Open Firmware address directly to the device firmware instead of relying on our MAC

[net-next 05/15] i40e: separate hw_features from runtime changing flags

From: Jacob Keller The number of flags found in pf->flags has grown quite large, and there are a lot of different types of flags. Most of the flags are simply hardware features which are enabled on some firmware or some MAC types. Other flags are dynamic run-time flags which enable or disable cer

[net-next 07/15] i40e: Detect ATR HW Evict NVM issue and disable the feature

From: Anjali Singhai Jain This patch fixes a problem with the HW ATR eviction feature where the NVM setting was incorrect. This patch detects the issue on X720 adapters and disables the feature if the NVM setting is incorrect. Without this patch, HW ATR Evict feature does not work on broken NVM

[net-next 12/15] i40evf: use netdev variable in reset task

From: Alan Brady If we're going to bother initializing a variable to reference it we might as well use it. Signed-off-by: Alan Brady Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[net-next 02/15] i40e/i40evf: adjust packet size to account for double VLANs

From: Mitch Williams Now that the kernel supports double VLAN tags, we should at least play nice. Adjust the max packet size to account for two VLAN tags, not just one. Signed-off-by: Mitch Williams Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e

[net-next 04/15] i40e: Fix a bug with VMDq RSS queue allocation

From: Anjali Singhai Jain The X722 pf flag setup should happen before the VMDq RSS queue count is initialized for VMDq VSI to get the right number of queues for RSS in case of X722 devices. Signed-off-by: Anjali Singhai Jain Signed-off-by: Alice Michael Tested-by: Andrew Bowers Signed-off-by:

[net-next 01/15] i40e/i40evf: fix some minor type mismatches

From: Jesse Brandeburg This patch fixes two trivial type mismatches, one where we were returning an enum type, but pretending it was an int, and the other where we were using a void* for offset math, but it is communicated more clearly and correctly to use a u8*, which we then cast to void* for p

[net-next 13/15] i40e: use cpumask_copy instead of direct assignment

From: Jacob Keller According to the header file cpumask.h, we shouldn't be directly copying a cpumask_t, since its a bitmap and might not be copied correctly. Lets use the provided cpumask_copy() function instead. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 3/4] i40evf: prevent VF close returning before state tranistions to DOWN

From: Sudheer Mogilappagari Currently i40evf_close() can return before state transitions to __I40EVF_DOWN because of the latency involved in processing and receiving response from PF driver and scheduling of VF watchdog_task. Due to this inconsistency an immediate call to i40evf_open() fails beca

[net-next 10/15] i40e: move check for avoiding VID=0 filters into i40e_vsi_add_vlan

From: Jacob Keller In i40e_vsi_add_vlan we treat attempting to add VID=0 as an error, because it does not do what the caller might expect. We already special case VID=0 in i40e_vlan_rx_add_vid so that we avoid this error when adding the VLAN. This special casing is necessary so that we do not ad

[net-next 09/15] i40e/i40evf: use cmpxchg64 when updating private flags in ethtool

From: Jacob Keller When a user gives an invalid command to change a private flag which is not supported, either because it is read-only, or the device is not capable of the feature, we simply ignore the request. A naive solution would simply be to report error codes when one of the flags was not

[net-next 03/15] i40evf: prevent VF close returning before state transitions to DOWN

From: Sudheer Mogilappagari Currently i40evf_close() can return before state transitions to __I40EVF_DOWN because of the latency involved in processing and receiving response from PF driver and scheduling of VF watchdog_task. Due to this inconsistency an immediate call to i40evf_open() fails beca

[net-next 15/15] i40e: synchronize nvmupdate command and adminq subtask

From: Sudheer Mogilappagari During NVM update, state machine gets into unrecoverable state because i40e_clean_adminq_subtask can get scheduled after the admin queue command but before other state variables are updated. This causes incorrect input to i40e_nvmupd_check_wait_event and state transiti

[net-next 11/15] i40e/i40evf: rename vf_offload_flags to vf_cap_flags in struct virtchnl_vf_resource

From: Stefan Assmann The current name of vf_offload_flags indicates that the bitmap is limited to offload related features. Make this more generic by renaming it to vf_cap_flags, which allows for other capabilities besides offloading to be added. Signed-off-by: Stefan Assmann Tested-by: Andrew

[net-next 08/15] i40e/i40evf: organize and re-number feature flags

From: Jacob Keller Now that we've reduced the number of flags, organize similar flags together and re-number them accordingly. Also ensure that the flags variable is actually a u64 to guarantee 64bits of space on all architectures. One alternative approach considered, but not implemented here,

[net-next 14/15] i40e: prevent changing ITR if adaptive-rx/tx enabled

From: Alan Brady Currently the driver allows the user to change (or even disable) interrupt moderation if adaptive-rx/tx is enabled when this should not be the case. Adaptive RX/TX will not respect the user's ITR settings so allowing the user to change it is weird. This bug would also allow the

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2017-08-12

This series contains updates to i40e and i40evf only. Jesse fixes two type mismatches, one where we were returning an enum type, but pretending it was an integer. The other was where we were using a void* for offset math, but it is communicated more clearly to use a u8*, which we can then cast to

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

Kalle Valo writes: > Andreas Born writes: > >> Earlier today I submitted the patch (bonding: require speed/duplex >> only for 802.3ad, alb and tlb) [2] that only partially reverts what is >> a regression following my aforementioned logic. This seems to me like >> the best solution in the short t