Make c_can_pci_data structures const as they are only used during
a copy operation.
Signed-off-by: Bhumika Goyal
---
drivers/net/can/c_can/c_can_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/c_can/c_can_pci.c
b/drivers/net/can/c_can/c_can_pci.c
in
> -Original Message-
> From: Florian Westphal [mailto:f...@strlen.de]
> Subject: Re: XFRM pcpu cache issue
>
> I dropped the stale_bundle() check vs. rfc, that was a stupid thing
> to do because that is what would detect this
>
> Does this help?
Yes, this fixes the regression for me.
From: Markus Elfring
Date: Sat, 5 Aug 2017 22:30:04 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code pla
From: Markus Elfring
Date: Sat, 5 Aug 2017 22:10:41 +0200
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signe
From: Markus Elfring
Date: Sat, 5 Aug 2017 21:39:06 +0200
The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix affected source code places.
Signed-off-by: Markus Elfring
---
drivers/atm/iphase.c | 57
From: Markus Elfring
Date: Sun, 6 Aug 2017 08:18:28 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Adjust 11 function calls together with a variable assignment
Delete five error messages for a failed memory allocation
Adjust fou
On Sun, Aug 6, 2017 at 5:08 AM, Marcelo Ricardo Leitner
wrote:
> On Sat, Aug 05, 2017 at 08:31:09PM +0800, Xin Long wrote:
>> Chen Wei found a kernel call trace when modprobe sctp_probe with
>> bufsize set with a huge value.
>>
>> It's because in sctpprobe_init when alloc memory for sctpw.fifo,
>>
Begin forwarded message:
Date: Sat, 05 Aug 2017 23:57:48 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 196595] New: Regression IGMP sysctl init values if not
IP_MULTICAST
https://bugzilla.kernel.org/show_bug.cgi?id=196595
Bug ID: 196
Several DSA core setup functions take many arguments, mostly because of
the legacy code. This patch series removes the useless args of these
functions, where either the dsa_switch or dsa_port argument is enough.
Changes in v2:
- ds->dev is already assigned by dsa_switch_alloc
Vivien Didelot (3)
dsa_slave_create currently takes 4 arguments while it only needs the
related dsa_port and its name. Remove all other arguments.
Signed-off-by: Vivien Didelot
---
net/dsa/dsa2.c | 2 +-
net/dsa/dsa_priv.h | 3 +--
net/dsa/legacy.c | 2 +-
net/dsa/slave.c| 14 +++---
4 files c
dsa_switch_alloc() already assigns ds-dev, which can be used in
dsa_switch_setup_one and dsa_cpu_dsa_setups instead of requiring an
additional struct device argument.
Signed-off-by: Vivien Didelot
---
net/dsa/legacy.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff -
dsa_cpu_dsa_setup currently takes 4 arguments but they are all available
from the dsa_port argument. Remove all others.
Signed-off-by: Vivien Didelot
---
net/dsa/dsa.c | 10 +-
net/dsa/dsa2.c | 4 ++--
net/dsa/dsa_priv.h | 3 +--
net/dsa/legacy.c | 4 +---
4 files changed,
Hi Andrew,
Andrew Lunn writes:
>> @@ -251,8 +251,9 @@ dsa_switch_setup(struct dsa_switch_tree *dst, struct
>> net_device *master,
>> ds->cd = cd;
>> ds->ops = ops;
>> ds->priv = priv;
>> +ds->dev = parent;
>
> Is this even needed? dsa_switch_alloc() does ds->dev = dev.
You a
Hi Daniel,
>>>
>>> So the only arch that sets __ARCH_WANT_SYSCALL_DEPRECATED
>>> is score:
>>>
>>>$ git grep -n __ARCH_WANT_SYSCALL_DEPRECATED
>>>arch/score/include/uapi/asm/unistd.h:7:#define
>>> __ARCH_WANT_SYSCALL_DEPRECATED
>>>include/uapi/asm-generic/unistd.h:837:#ifdef
>>> __ARC
On Sat, Aug 05, 2017 at 08:31:09PM +0800, Xin Long wrote:
> Chen Wei found a kernel call trace when modprobe sctp_probe with
> bufsize set with a huge value.
>
> It's because in sctpprobe_init when alloc memory for sctpw.fifo,
> the size is got from userspace. If it is too large, kernel will
> fai
With
4.13-rc3 have kernel panic when deleting qdisc - will try to get panic trace
W dniu 2017-08-05 o 18:38, Paweł Staszewski pisze:
Hi
Want to send some comparisions about poor performance of kernel when
simple queueing is enabled
So first - kernel performance for forwarded udp packets
Hi
Want to send some comparisions about poor performance of kernel when
simple queueing is enabled
So first - kernel performance for forwarded udp packets generated from
pktgen:
UDP stream ~10Mpps - random destination from network 172.16.0.0/12 +
random udp port
Forwarding performance
From: Jiri Pirko
Let dsa_slave_setup_tc be a splitter for specific setup_tc types and
push out cls_matchall specific code into a separate function.
Signed-off-by: Jiri Pirko
---
net/dsa/slave.c | 33 +
1 file changed, 21 insertions(+), 12 deletions(-)
diff --gi
From: Jiri Pirko
Let mlx5e_setup_tc (former mlx5e_ndo_setup_tc) be a splitter for specific
setup_tc types and push out cls_flower and mqprio specific codes into
separate functions. Also change the return values so they are the same
as in the rest of the drivers.
Signed-off-by: Jiri Pirko
---
d
From: Jiri Pirko
Let __ixgbe_setup_tc be a splitter for specific setup_tc types and push out
cls_u32 and mqprio specific codes into separate functions. Also change
the return values so they are the same as in the rest of the drivers.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/intel/ixg
From: Jiri Pirko
Let mlx5e_rep_setup_tc (former mlx5e_rep_ndo_setup_tc) be a splitter for
specific setup_tc types and push out cls_flower specific code into
a separate function.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 49 ++--
1 file
From: Jiri Pirko
To sync-up with the naming in the rest of the driver, rename the cls arg.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectru
From: Jiri Pirko
Let cxgb_setup_tc be a splitter for specific setup_tc types and push out
cls_u32 specific code into a separate function.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 42 +++--
1 file changed, 26 insertions(+), 16 deletions
From: Jiri Pirko
Since the type is always present, push it to be a separate argument to
ndo_setup_tc. On the way, name the type enum and use it for arg type.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c| 6 +++---
drivers/net/ethernet/broadcom/bnx2x/bnx2x
From: Jiri Pirko
prio is not cls_flower specific, but it is meaningful for all
classifiers. Seems that only mlxsw cares about the value. Obviously,
cls offload in other drivers is broken.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 2 +-
include/net/pk
From: Jiri Pirko
Change the return value from -EINVAL to -EOPNOTSUPP. The rest of the
drivers have it like that, so be aligned.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c| 2 +-
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +-
drivers/net/ethernet/bro
From: Jiri Pirko
As ndo_setup_tc is generic offload op for whole tc subsystem, does not
really make sense to have cls-specific args. So move them under
cls_common structurure which is embedded in all cls structs.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c
From: Jiri Pirko
Get rid of struct tc_to_netdev which is now just unnecessary container
and rather pass per-type structures down to drivers directly.
Along with that, consolidate the naming of per-type structure variables
in cls_*.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/amd/xgbe/xg
From: Jiri Pirko
Change the flows a bit in preparation of follow-up changes in
ndo_setup_tc args. Also, change the error code to align with the rest of
the drivers.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/netronome/nfp/bpf/main.c | 16 ++--
drivers/net/ethernet/net
From: Jiri Pirko
Let mlxsw_sp_setup_tc be a splitter for specific setup_tc types and push
out cls_flower and cls_matchall specific codes into separate functions.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 81 --
1 file changed, 51 ins
From: Jiri Pirko
This patchset focuses on ndo_setup_tc and its args.
Currently there are couple of things that do not make much sense.
The type is passed in struct tc_to_netdev, but as it is always
required, should be arg of the ndo. Other things are passed as args
but they are only relevant for
From: Jiri Pirko
In order to be aligned with the rest of the types, rename
TC_SETUP_MATCHALL to TC_SETUP_CLSMATCHALL.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +-
include/linux/netdevice.h | 2 +-
net/dsa/slave.c
From: Jiri Pirko
Since this is specific to flower now, make it part of the flower offload
struct.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
include/linux/netdevice.h| 1 -
include/net/pkt_cls.h| 1
From: Colin Ian King
Trivial fix to spelling mistake in dev_err error message and also
split overly long line to avoid a checkpatch warning.
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -
Hi Roopa,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Roopa-Prabhu/lwtunnel-replace-EXPORT_SYMBOL-with-EXPORT_SYMBOL_GPL/20170805-212202
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce
From: Markus Elfring
Date: Sat, 5 Aug 2017 14:04:42 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code pla
Chen Wei found a kernel call trace when modprobe sctp_probe with
bufsize set with a huge value.
It's because in sctpprobe_init when alloc memory for sctpw.fifo,
the size is got from userspace. If it is too large, kernel will
fail and give a warning.
As there will be a fallback allocation later, t
From: Markus Elfring
Date: Sat, 5 Aug 2017 13:51:04 +0200
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus
From: Markus Elfring
Date: Sat, 5 Aug 2017 12:45:34 +0200
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Link:
http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Sig
From: Markus Elfring
Date: Fri, 4 Aug 2017 22:20:08 +0200
The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
---
drivers/atm/idt77252.c | 13 -
From: Markus Elfring
Date: Sat, 5 Aug 2017 14:22:33 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Adjust four function calls together with a variable assignment
Delete an error message for a failed memory allocation in seven funct
This patch is to remove the typedef sctp_subtype_t, and
replace with union sctp_subtype in the places where it's
using this typedef.
Note that it doesn't fix many indents although it should,
as sctp_disposition_t's removal would mess them up again.
So better to fix them when removing sctp_disposit
This patch is to remove the typedef sctp_event_t, and
replace with enum sctp_event in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 6 ++
include/net/sctp/sm.h| 12 +---
net/sctp/primitive.c | 2 +-
net/sctp/sm_
This patch is to remove the typedef sctp_event_timeout_t, and
replace with enum sctp_event_timeout in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/command.h | 4 ++--
include/net/sctp/constants.h | 8
net/sctp/sm_sideeffect.c | 6 +++---
3
This patch is to remove the typedef sctp_event_other_t, and
replace with enum sctp_event_other in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/net/sctp/consta
This patch is to remove the typedef sctp_event_primitive_t, and
replace with enum sctp_event_primitive in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/net/sct
This patch is to remove the typedef sctp_state_t, and
replace with enum sctp_state in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/command.h | 4 ++--
include/net/sctp/constants.h | 4 ++--
include/net/sctp/sctp.h | 2 +-
include/net/sctp/sm.h
This patch is to remove the typedef sctp_transport_cmd_t, and
replace with enum sctp_transport_cmd in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 4 ++--
include/net/sctp/structs.h | 7 ---
net/sctp/associola.c | 2 +-
3 file
This patch is to remove the typedef sctp_ierror_t, and
replace with enum sctp_ierror in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 5 ++---
net/sctp/sm_make_chunk.c | 23 ---
net/sctp/sm_statefuns.c | 28
This patch is to remove the typedef sctp_xmit_t, and
replace with enum sctp_xmit in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 4 +--
include/net/sctp/structs.h | 9 ---
net/sctp/output.c| 60 ++
This patch is to remove the typedef sctp_scope_t, and
replace with enum sctp_scope in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 4 ++--
include/net/sctp/sctp.h | 4 ++--
include/net/sctp/structs.h | 17 +
net/sct
As we know, typedef is suggested not to use in kernel, even checkpatch.pl
also gives warnings about it. Now sctp is using it for many structures.
All this kind of typedef's using should be removed. This patchset is the
part 5 to remove all typedefs in include/net/sctp/constants.h.
Just as the par
This patch is to remove the typedef sctp_lower_cwnd_t, and
replace with enum sctp_lower_cwnd in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 4 ++--
include/net/sctp/structs.h | 3 ++-
net/sctp/transport.c | 2 +-
3 files changed,
This patch is to remove the typedef sctp_sock_state_t, and
replace with enum sctp_sock_state in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 6 +++---
include/net/sctp/sctp.h | 3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
d
This patch is to remove the typedef sctp_scope_policy_t and keep
it's members as an anonymous enum.
It is also to define SCTP_SCOPE_POLICY_MAX to replace the num 3
in sysctl.c to make codes clear.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 6 --
net/sctp/sysctl.c
This patch is to remove the typedef sctp_retransmit_reason_t, and
replace with enum sctp_retransmit_reason in the places where it's
using this typedef.
Signed-off-by: Xin Long
---
include/net/sctp/constants.h | 4 ++--
include/net/sctp/structs.h | 4 ++--
net/sctp/outqueue.c | 2 +-
3
As we know in some target's checkentry it may dereference par.entryinfo
to check entry stuff inside. But when sched action calls xt_check_target,
par.entryinfo is set with NULL. It would cause kernel panic when calling
some targets.
It can be reproduce with:
# tc qd add dev eth1 ingress handle f
Commit 55917a21d0cc ("netfilter: x_tables: add context to know if
extension runs from nft_compat") introduced a member nft_compat to
xt_tgchk_param structure.
But it didn't set it's value for ipt_init_target. With unexpected
value in par.nft_compat, it may return unexpected result in some
target's
Will be used instead of '3' in upcomming patches.
Signed-off-by: Egil Hjelmeland
Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
drivers/net/dsa/lan9303-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c
ind
lan9303_enable_packet_processing, lan9303_disable_packet_processing()
Pass port number (0,1,2) as parameter instead of port offset.
Because other functions in the module pass port numbers.
And to enable simplifications in following patch.
Introduce lan9303_write_switch_port().
Signed-off-by: Egil
This series is purely non functional.
It changes the lan9303_enable_packet_processing,
lan9303_disable_packet_processing() to pass port number (0,1,2) as
parameter instead of port offset. This aligns them with
other functions in the module, and makes it possible to simplify the code.
The lan9303
Simplify usage of lan9303_enable_packet_processing,
lan9303_disable_packet_processing()
Signed-off-by: Egil Hjelmeland
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
drivers/net/dsa/lan9303-core.c | 24 ++--
1 file changed, 10 insertions(+), 14 deletions(-)
dif
The lan9303_enable_packet_processing, lan9303_disable_packet_processing
functions operate on port, so the names should reflect that.
And to align with lan9303_disable_processing(), rename:
lan9303_enable_packet_processing -> lan9303_enable_processing_port
lan9303_disable_packet_processing -> lan93
In lan9303_get_ethtool_stats: Get rid of 0x400 constant magic
by using new lan9303_read_switch_reg() inside loop.
Reduced scope of two variables.
Signed-off-by: Egil Hjelmeland
Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
---
drivers/net/dsa/lan9303-core.c | 26 --
This patch implements the following seg6local actions.
- SEG6_LOCAL_ACTION_END: regular SRH processing. The DA of the packet
is updated to the next segment and forwarded accordingly.
- SEG6_LOCAL_ACTION_END_X: same as above, except that the packet is
forwarded to the specified IPv6 next-hop.
This patch exports the seg6_do_srh_encap() and seg6_do_srh_inline()
functions. It also removes the CONFIG_IPV6_SEG6_INLINE knob
that enabled the compilation of seg6_do_srh_inline(). This function
is now built-in.
Signed-off-by: David Lebrun
---
include/net/seg6.h | 2 ++
net/ipv6/Kconfig
This patch implements a new type of lightweight tunnel named seg6local.
A seg6local lwt is defined by a type of action and a set of parameters.
The action represents the operation to perform on the packets matching the
lwt's route, and is not necessarily an encapsulation. The set of parameters
are
This patch adds the necessary functions to parse, fill, and compare
seg6local rtnetlink attributes, for all defined action parameters.
- The SRH parameter defines an SRH to be inserted or encapsulated.
- The TABLE parameter defines the table to use for the route lookup of
the next segment or the
v2: use EXPORT_SYMBOL_GPL
The current implementation of IPv6 SR supports SRH insertion/encapsulation
and basic segment endpoint behavior (i.e., processing of an SRH contained in
a packet whose active segment (IPv6 DA) is routed to the local node). This
behavior simply consists of updating the DA t
The seg6_validate_srh() function only allows SRHs whose active segment is
the first segment of the path. However, an application may insert an SRH
whose active segment is not the first one. Such an application might be
for example an SR-aware Virtual Network Function.
This patch enables to insert
Now xt_tgchk_param par in ipt_init_target is a local varibale,
par.net is not initialized there. Later when xt_check_target
calls target's checkentry in which it may access par.net, it
would cause kernel panic.
Jaroslav found this panic when running:
# ip link add TestIface type dummy
# tc qd
From: Casey Leedom
cxgb4vf Ethernet driver now queries PCIe configuration space to
determine if it can send TLPs to it with the Relaxed Ordering
Attribute set, just like the pf did.
Signed-off-by: Casey Leedom
Signed-off-by: Ding Tianhong
Reviewed-by: Casey Leedom
---
drivers/net/ethernet/ch
From: Casey Leedom
The patch adds a new flag PCI_DEV_FLAGS_NO_RELAXED_ORDERING to indicate that
Relaxed Ordering (RO) attribute should not be used for Transaction Layer
Packets (TLP) targetted towards these affected root complexes. Current list
of affected parts include some Intel Xeon processors
When bit4 is set in the PCIe Device Control register, it indicates
whether the device is permitted to use relaxed ordering.
On some platforms using relaxed ordering can have performance issues or
due to erratum can cause data-corruption. In such cases devices must avoid
using relaxed ordering.
Thi
Some devices have problems with Transaction Layer Packets with the Relaxed
Ordering Attribute set. This patch set adds a new PCIe Device Flag,
PCI_DEV_FLAGS_NO_RELAXED_ORDERING, a set of PCI Quirks to catch some known
devices with Relaxed Ordering issues, and a use of this new flag by the
cxgb4 dr
From: Casey Leedom
cxgb4 Ethernet driver now queries PCIe configuration space to determine
if it can send TLPs to it with the Relaxed Ordering Attribute set.
Remove the enable_pcie_relaxed_ordering() to avoid enable PCIe Capability
Device Control[Relaxed Ordering Enable] at probe routine, to mak
76 matches
Mail list logo
