GCC 7 added a new -Wimplicit-fallthrough warning. It's only enabled
with W=1, but since linux/jhash.h is included in over hundred places
(including other global headers) it seems worthwhile fixing this
warning.
Signed-off-by: Jakub Kicinski
---
If it looks good, would it be OK to take it via the
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
Arvind Yadav (10):
[PATCH 01/10] isdn: hisax: constify pci_device_id.
[PATCH 02/10] isdn: hisax: hfc4s8s_l1: constif
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
File size before:
textdata bss dec hex filename
1368620644416 201664ec6 drivers/isdn/
On Fri, Jul 14, 2017 at 12:37:05PM +0200, Arnd Bergmann wrote:
> On Fri, Jul 14, 2017 at 12:08 PM, Joe Perches wrote:
> > On Fri, 2017-07-14 at 11:25 +0200, Arnd Bergmann wrote:
> >> We test whether a bit is set in a mask here, which is correct
> >> but gcc warns about it as it thinks it might be
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
File size before:
textdata bss dec hex filename
10512 536 4 110522b2c drivers/isdn/
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
File size before:
textdata bss dec hex filename
5989 576 0656519a5 isdn/hisax/hi
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
File size before:
textdata bss dec hex filename
6224 655 868871ae7 isdn/hardware
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
File size before:
textdata bss dec hex filename
6345015361492 66478 103ae isdn/hardware
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
File size before:
textdata bss dec hex filename
139594080 24 18063468f isdn/hardware
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
File size before:
textdata bss dec hex filename
109411776 16 1273331bd isdn/hardware
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
File size before:
textdata bss dec hex filename
99631936 16 119152e8b isdn/hardware
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
File size before:
textdata bss dec hex filename
216561024 96 2277658f8 isdn/hardware
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by work with
const pci_device_id. So mark the non-const structs as const.
File size before:
textdata bss dec hex filename
11803 544 1 12348303c isdn/hardware
On 7/14/2017 1:36 AM, Jamal Hadi Salim wrote:
On 17-07-11 06:18 AM, Amritha Nambiar wrote:
This patch introduces a new hardware offload mode in mqprio
which makes full use of the mqprio options, the TCs, the
queue configurations and the bandwidth rates for the TCs.
This is achieved by setting th
On Wed, 2017-07-12 at 16:50 +0200, Andrew Lunn wrote:
> > +static int mtk_clk_enable(struct mtk_eth *eth)
> > +{
> > + int clk, ret;
> > +
> > + for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
> > + if (eth->clks[clk]) {
> > + ret = clk_prepare_enable(eth->clks[clk]);
> >
Support bandwidth rate limit information for a traffic
class in addition to the number of TCs and associated
queue configuration data. This is supported in the new
hardware offload mode in mqprio by setting the value of
'hw' option to 2. This new hardware offload mode in mqprio
makes full use of th
On Fri, Jul 14, 2017 at 7:15 PM, Stephen Hemminger
wrote:
> On Fri, 14 Jul 2017 18:54:02 -0400
> Neal Cardwell wrote:
>
>> On Fri, Jul 14, 2017 at 6:36 PM, Stephen Hemminger
>> wrote:
>> > On Fri, 14 Jul 2017 17:49:21 -0400
>> > Neal Cardwell wrote:
>> >
>> >> In bbr_set_pacing_rate(), which de
On Fri, 14 Jul 2017 18:54:02 -0400
Neal Cardwell wrote:
> On Fri, Jul 14, 2017 at 6:36 PM, Stephen Hemminger
> wrote:
> > On Fri, 14 Jul 2017 17:49:21 -0400
> > Neal Cardwell wrote:
> >
> >> In bbr_set_pacing_rate(), which decides whether to cut the pacing
> >> rate, there was some code that
In case we fail to map a single fragment, we would be leaving the
transmit ring populated with stale entries.
This commit introduces the helper function bcmgenet_put_txcb()
which takes care of rewinding the per-ring write pointer back to
where we left.
It also consolidates the functionality of bc
Two issues were observed in a review of the bcmgenet driver support for
fragmented SKBs which are addressed by this patch set.
The first addresses a problem that could occur if the driver is not able
to DMA map a fragment of the SKB. This would be a highly unusual event
but it would leave the har
Since the skb is attached to the first control block of a fragmented
skb it is possible that the skb could be freed when reclaiming that
control block before all fragments of the skb have been consumed by
the hardware and unmapped.
This commit introduces first_cb and last_cb pointers to the skb
co
On Fri, Jul 14, 2017 at 6:36 PM, Stephen Hemminger
wrote:
> On Fri, 14 Jul 2017 17:49:21 -0400
> Neal Cardwell wrote:
>
>> In bbr_set_pacing_rate(), which decides whether to cut the pacing
>> rate, there was some code that considered exiting STARTUP to be
>> equivalent to the notion of filling th
The 07/14/2017 09:04, David Miller wrote:
> From: Arnd Bergmann
> Date: Fri, 14 Jul 2017 14:07:05 +0200
>
> > gcc reports that the temporary buffer for computing the
> > string length may be too small here:
> >
> > drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function
> 'lio_get_eeprom_
On Fri, 14 Jul 2017 17:49:21 -0400
Neal Cardwell wrote:
> In bbr_set_pacing_rate(), which decides whether to cut the pacing
> rate, there was some code that considered exiting STARTUP to be
> equivalent to the notion of filling the pipe (i.e.,
> bbr_full_bw_reached()). Specifically, as the code w
On 14/07/2017 23:28, Florian Fainelli wrote:
> On 07/14/2017 02:08 PM, Mason wrote:
>
>> I've discussed this subject in the past, but we never reached
>> a conclusion, AFAIR.
>>
>> The Atheros 8035 GigE PHY has IMO 2 quirks wrt to clock delays.
>>
>> https://www.redeszone.net/app/uploads/2014/04/A
On 07/14/2017 01:48 PM, Moritz Fischer wrote:
> Add support for the National Instruments XGE 1/10G network device.
>
> It uses the EEPROM on the board via NVMEM.
>
> Signed-off-by: Moritz Fischer
> ---
> +
> +static void nixge_handle_link_change(struct net_device *ndev)
> +{
> + struct nixg
Introduce a helper to initialize the BBR pacing rate unconditionally,
based on the current cwnd and RTT estimate. This is a pure refactor,
but is needed for two following fixes.
Fixes: 0f8782ea1497 ("tcp_bbr: add BBR congestion control")
Signed-off-by: Neal Cardwell
Signed-off-by: Yuchung Cheng
Fixes the following behavior: for connections that had no RTT sample
at the time of initializing congestion control, BBR was initializing
the pacing rate to a high nominal rate (based an a guess of RTT=1ms,
in case this is LAN traffic). Then BBR never adjusted the pacing rate
downward upon obtainin
Fix a corner case noticed by Eric Dumazet, where BBR's setting
sk->sk_pacing_rate to 0 during initialization could theoretically
cause packets in the sending host to hang if there were packets "in
flight" in the pacing infrastructure at the time the BBR congestion
control state is initialized. This
In bbr_set_pacing_rate(), which decides whether to cut the pacing
rate, there was some code that considered exiting STARTUP to be
equivalent to the notion of filling the pipe (i.e.,
bbr_full_bw_reached()). Specifically, as the code was structured,
exiting STARTUP and going into PROBE_RTT could caus
Introduce a helper to convert a BBR bandwidth and gain factor to a
pacing rate in bytes per second. This is a pure refactor, but is
needed for two following fixes.
Fixes: 0f8782ea1497 ("tcp_bbr: add BBR congestion control")
Signed-off-by: Neal Cardwell
Signed-off-by: Yuchung Cheng
Signed-off-by:
On 07/14/2017 02:08 PM, Mason wrote:
> Hello,
>
> I've discussed this subject in the past, but we never reached
> a conclusion, AFAIR.
>
> The Atheros 8035 GigE PHY has IMO 2 quirks wrt to clock delays.
>
> https://www.redeszone.net/app/uploads/2014/04/AR8035.pdf
>
>
> 1) RX clock delay
>
> C
Mugunthan's address bounces. Removing it.
Adding Grygorii's address instead.
On 14/07/2017 23:08, Mason wrote:
> Hello,
>
> I've discussed this subject in the past, but we never reached
> a conclusion, AFAIR.
>
> The Atheros 8035 GigE PHY has IMO 2 quirks wrt to clock delays.
>
> https://www.r
Hello,
I've discussed this subject in the past, but we never reached
a conclusion, AFAIR.
The Atheros 8035 GigE PHY has IMO 2 quirks wrt to clock delays.
https://www.redeszone.net/app/uploads/2014/04/AR8035.pdf
1) RX clock delay
Commit 2e5f9f281ee8369f56d403b4a52942f19b6978f8
In fact, RX clo
This adds bindings for the NI XGE 1G/10G network device.
Signed-off-by: Moritz Fischer
---
Documentation/devicetree/bindings/net/nixge.txt | 32 +
1 file changed, 32 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/nixge.txt
diff --git a/Documentat
Add support for the National Instruments XGE 1/10G network device.
It uses the EEPROM on the board via NVMEM.
Signed-off-by: Moritz Fischer
---
Changes from v1:
- Added dependency on ARCH_ZYNQ (Kbuild)
- Removed unused variables
- Use of_phy_connect as suggested
- Removed masking of (un)support
Hi Alexander,
[auto build test WARNING on net-next/master]
[also build test WARNING on next-20170714]
[cannot apply to v4.12]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Alexander-Potapenko
I did an experiment with one of our internal bpf programs.
The program has 1563 insns.
Without Edward's patch:
processed 13634 insns, stack depth 160
With Edward's patch:
processed 15807 insns, stack depth 160
So the number of processed insns regressed by roughly 16%.
Did anybody do any similar
On Fri, Jul 14, 2017 at 2:52 PM, Andy Shevchenko
wrote:
> On Fri, 2017-07-14 at 14:07 +0200, Arnd Bergmann wrote:
>> gcc-7 notices that the pin_table is an array of 16-bit numbers,
>> but we assume it can be printed as a two-character hexadecimal
>> string:
>>
>> drivers/gpio/gpiolib-acpi.c: In fu
On Fri, Jul 14, 2017 at 10:37 PM, Arnd Bergmann wrote:
> On Fri, Jul 14, 2017 at 9:18 PM, Andy Shevchenko
> wrote:
>> On Fri, Jul 14, 2017 at 3:07 PM, Arnd Bergmann wrote:
>>> gcc points out a possible format string overflow for a large value of
>>> 'zone':
>> Here we need to convert
>>
>> int
When there is an established connection in direction A->B, it is
possible to receive a packet on port B which then executes
ct(commit,force) without first performing ct() - ie, a lookup.
In this case, we would expect that this packet can delete the existing
entry so that we can commit a connection
On Fri, Jul 14, 2017 at 9:18 PM, Andy Shevchenko
wrote:
> On Fri, Jul 14, 2017 at 3:07 PM, Arnd Bergmann wrote:
>> gcc points out a possible format string overflow for a large value of 'zone':
>>
>> drivers/platform/x86/alienware-wmi.c: In function 'alienware_wmi_init':
>> drivers/platform/x86/al
On Fri, Jul 14, 2017 at 3:07 PM, Arnd Bergmann wrote:
> gcc points out a possible format string overflow for a large value of 'zone':
>
> drivers/platform/x86/alienware-wmi.c: In function 'alienware_wmi_init':
> drivers/platform/x86/alienware-wmi.c:461:24: error: '%02X' directive writing
> betwee
On Fri, Jul 14, 2017 at 1:35 PM, Alexander Potapenko wrote:
> On Fri, Jul 14, 2017 at 7:04 PM, Neal Cardwell wrote:
>> On Fri, Jul 14, 2017 at 12:54 PM, Alexander Potapenko
>> wrote:
>>> KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(),
>>> which originated from the TCP requ
Hi Alexander,
[auto build test ERROR on net-next/master]
[also build test ERROR on next-20170714]
[cannot apply to v4.12]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Alexander-Potapenko/sctp
On 07/14/2017 11:42 AM, Joe Stringer wrote:
On 14 July 2017 at 09:10, Greg Rose wrote:
> When there is an established connection in direction A->B, it is
> possible to receive a packet on port B which then executes
> ct(commit,force) without first performing ct() - ie, a lookup.
> In this case,
On 14 July 2017 at 09:10, Greg Rose wrote:
> When there is an established connection in direction A->B, it is
> possible to receive a packet on port B which then executes
> ct(commit,force) without first performing ct() - ie, a lookup.
> In this case, we would expect that this packet can delete th
> -Original Message-
> From: Arnd Bergmann [mailto:a...@arndb.de]
> Sent: Friday, July 14, 2017 7:07 AM
> To: linux-ker...@vger.kernel.org; Darren Hart ; Andy
> Shevchenko
> Cc: Greg Kroah-Hartman ; Linus Torvalds
> ; Guenter Roeck ;
> a...@linux-foundation.org; netdev@vger.kernel.org; Dav
On 14 July 2017 at 09:10, Greg Rose wrote:
> When there is an established connection in direction A->B, it is
> possible to receive a packet on port B which then executes
> ct(commit,force) without first performing ct() - ie, a lookup.
> In this case, we would expect that this packet can delete th
This patch adjusts the timeout formula to schedule the TCP loss probe
(TLP). The previous formula uses 2*SRTT or 1.5*RTT + DelayACKMax if
only one packet is in flight. It keeps a lower bound of 10 msec which
is too large for short RTT connections (e.g. within a data-center).
The new formula = 2*RTT
Let bondvf.sh ignore this NIC if it has been configured, to prevent
user configuration from being overwritten unexpectly.
Signed-off-by: Simon Xiao
---
tools/hv/bondvf.sh | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/tools/hv/bondvf.sh b/tools/h
From: Alexander Potapenko
Date: Fri, 14 Jul 2017 19:33:54 +0200
> On Fri, Jul 14, 2017 at 7:23 PM, David Miller wrote:
>> From: Alexander Potapenko
>> Date: Fri, 14 Jul 2017 18:33:01 +0200
>>
>>> On Fri, Jul 14, 2017 at 5:58 PM, David Miller wrote:
From: Alexander Potapenko
Date: Fr
Reviewed-by: Casey Leedom
On Fri, Jul 14, 2017 at 7:04 PM, Neal Cardwell wrote:
> On Fri, Jul 14, 2017 at 12:54 PM, Alexander Potapenko
> wrote:
>> KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(),
>> which originated from the TCP request socket created in
>> cookie_v6_check():
> ...
>> --- a/net/ipv6
On Fri, Jul 14, 2017 at 7:23 PM, David Miller wrote:
> From: Alexander Potapenko
> Date: Fri, 14 Jul 2017 18:33:01 +0200
>
>> On Fri, Jul 14, 2017 at 5:58 PM, David Miller wrote:
>>> From: Alexander Potapenko
>>> Date: Fri, 14 Jul 2017 12:03:29 +0200
>>>
v2: per comment from David Miller,
From: Alexander Potapenko
Date: Fri, 14 Jul 2017 18:33:01 +0200
> On Fri, Jul 14, 2017 at 5:58 PM, David Miller wrote:
>> From: Alexander Potapenko
>> Date: Fri, 14 Jul 2017 12:03:29 +0200
>>
>>> v2: per comment from David Miller, make sure the whole iterator->length
>>> fits into the rem
On Fri, Jul 14, 2017 at 12:54 PM, Alexander Potapenko wrote:
> KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(),
> which originated from the TCP request socket created in
> cookie_v6_check():
...
> --- a/net/ipv6/syncookies.c
> +++ b/net/ipv6/syncookies.c
> @@ -216,6 +216,7 @@
KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(),
which originated from the TCP request socket created in
cookie_v6_check():
==
BUG: KMSAN: use of uninitialized memory in tcp_transmit_skb+0xf77/0x3ec0
CPU: 1 PID
If the length field of the iterator (|pos.p| or |err|) is past the end
of the chunk, we shouldn't access it.
This bug has been detected by KMSAN. For the following pair of system
calls:
socket(PF_INET6, SOCK_STREAM, 0x84 /* IPPROTO_??? */) = 3
sendto(3, "A", 1, MSG_OOB, {sa_family=AF_INET6, s
On Fri, Jul 14, 2017 at 5:58 PM, David Miller wrote:
> From: Alexander Potapenko
> Date: Fri, 14 Jul 2017 12:03:29 +0200
>
>> v2: per comment from David Miller, make sure the whole iterator->length
>> fits into the remaining buffer.
>
> Please compile and functionally test your changes:
>
>
When there is an established connection in direction A->B, it is
possible to receive a packet on port B which then executes
ct(commit,force) without first performing ct() - ie, a lookup.
In this case, we would expect that this packet can delete the existing
entry so that we can commit a connection
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:00 +0200
> One string we pass into the cs->info buffer might be too long,
> as pointed out by gcc:
>
> drivers/isdn/divert/isdn_divert.c: In function 'll_callback':
> drivers/isdn/divert/isdn_divert.c:488:22: error: '%d' directive writing
> betwe
From: Xin Long
Date: Fri, 14 Jul 2017 22:07:33 +0800
> Marcelo noticed an array overflow caused by commit c28445c3cb07
> ("sctp: add reconf_enable in asoc ep and netns"), in which sctp
> would add SCTP_CID_RECONF into extensions when reconf_enable is
> set in sctp_make_init and sctp_make_init_ack
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:03 +0200
> gcc warns that the temporary buffer might be too small here:
>
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_probe':
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:16: error: '%d'
> directive writing b
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:02 +0200
> gcc notices that large queue numbers would overflow the queue name
> string:
>
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c: In function
> 'bnx2x_get_strings':
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3165:25: err
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:05 +0200
> gcc reports that the temporary buffer for computing the
> string length may be too small here:
>
> drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function
> 'lio_get_eeprom_len':
> /drivers/net/ethernet/cavium/liquidio/lio_etht
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:04 +0200
> gcc-7 notices that "-event-%d" could be more than 11 characters long
> if we had larger 'vector' numbers:
>
> drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_activate_dev':
> drivers/net/vmxnet3/vmxnet3_drv.c:2095:40: error: 'sp
From: Arnd Bergmann
Date: Fri, 14 Jul 2017 14:07:01 +0200
> We get a warning for the port_name string that might be longer than
> six characters if we had more than 10 ports:
>
> drivers/net/ethernet/sun/niu.c: In function 'niu_put_parent':
> drivers/net/ethernet/sun/niu.c:9563:21: error: '%d' d
From: Alexander Potapenko
Date: Fri, 14 Jul 2017 12:03:29 +0200
> v2: per comment from David Miller, make sure the whole iterator->length
> fits into the remaining buffer.
Please compile and functionally test your changes:
In file included from ./include/linux/compiler.h:58:0,
From: Timur Tabi
Date: Thu, 13 Jul 2017 15:45:41 -0500
> If the interface is not up, then don't try to close it during a
> shutdown. This avoids possible double free of the IRQ, which
> can happen during a shutdown.
>
> Fixes: 03eb3eb4d4d5 ("net: qcom/emac: add shutdown function")
> Signed-off-
From: Petr Kulhavy
Date: Thu, 13 Jul 2017 19:40:57 +0200
> This change enables the use of SW timestamping on Raspberry PI.
>
> smsc95xx uses the usbnet transmit function usbnet_start_xmit(), which
> implements software timestamping. However the SOF_TIMESTAMPING_TX_SOFTWARE
> capability was missi
From: Roman Mashak
Date: Thu, 13 Jul 2017 13:12:18 -0400
> Make name consistent with other TC event notification routines, such as
> tcf_add_notify() and tcf_del_notify()
>
> Signed-off-by: Roman Mashak
Applied.
Hi All,
Andrew Lunn writes:
> I've been testing IGMP snooping support with DSA, putting MDB entries
> into the switch so that traffic only goes out ports where there has
> been an interest indicated via IGMP. It mostly works, but i've come
> across one use case which does not.
>
> I have a multi
From: Iván Briano
Date: Thu, 13 Jul 2017 09:46:58 -0700
> When PACKET_QDISC_BYPASS is not used, Tx queue selection will be done
> before the packet is enqueued, taking into account any mappings set by
> a queuing discipline such as mqprio without hardware offloading. This
> selection may be affec
From: Ganesh Goudar
Date: Thu, 13 Jul 2017 18:36:50 +0530
> Check ptp_clock_register() return not only for NULL but
> also for error pointers, and also nullify adapter->ptp_clock
> if ptp_clock_register() fails.
>
> Fixes: 9c33e4208bce ("cxgb4: Add PTP Hardware Clock (PHC) support")
> Reported-b
From: Nikolay Aleksandrov
Date: Thu, 13 Jul 2017 16:09:10 +0300
> With 802.1ad support the vlan_ingress code started checking for vlan
> protocol mismatch which causes the current tag to be inserted and the
> bridge vlan protocol & pvid to be set. The vlan tag insertion changes
> the skb mac_head
From:
Date: Thu, 13 Jul 2017 18:57:54 +0800
> From: LiuJian
>
> The current code only support DT method to control xge led.
> This patch is the implementation of acpi method to control xge led.
>
> Signed-off-by: LiuJian
> Reviewed-by: John Garry
> Reviewed-by: Yunsheng Lin
> Reviewed-by: D
From: Cong Wang
Date: Wed, 12 Jul 2017 15:56:41 -0700
> When we convert atomic_t to refcount_t, a new kernel warning
> on "increment on 0" is introduced in the netpoll code,
> zap_completion_queue(). In fact for this special case, we know
> the refcount is 0 and we just have to set it to 1 to sat
From: Enrico Mioso
Date: Tue, 11 Jul 2017 17:21:52 +0200
> Some firmwares in Huawei E3372H devices have been observed to switch back
> to NTB 32-bit format after altsetting switch.
> This patch implements a driver flag to check for the device settings and
> set NTB format to 16-bit again if neede
From: Martin Blumenstingl
Date: Mon, 10 Jul 2017 14:35:23 +0200
> mdio_mux_init parses the child nodes of the MDIO mux. When using
> "mdio-mux-mmioreg" the child nodes are describing the register value
> that is written to switch between the MDIO busses.
>
> The change which makes the error mess
Hi Folks
I've been testing IGMP snooping support with DSA, putting MDB entries
into the switch so that traffic only goes out ports where there has
been an interest indicated via IGMP. It mostly works, but i've come
across one use case which does not.
I have a multicast listener running on the hos
Marcelo noticed an array overflow caused by commit c28445c3cb07
("sctp: add reconf_enable in asoc ep and netns"), in which sctp
would add SCTP_CID_RECONF into extensions when reconf_enable is
set in sctp_make_init and sctp_make_init_ack.
Then now when all ext chunks are set, 4 ext chunk ids can be
On 07/14/2017 05:07 AM, Arnd Bergmann wrote:
gcc-7 warns that the key might exceed five bytes for lage index
values:
drivers/hwmon/applesmc.c: In function 'applesmc_show_fan_position':
drivers/hwmon/applesmc.c:906:18: error: '%d' directive writing between 1 and 5
bytes into a region of size 4 [
On 07/14/2017 06:07 AM, Arnd Bergmann wrote:
> gcc-7 points out that a large controller number would overflow the
> string length for the procfs name and the firmware version string:
>
> drivers/block/DAC960.c: In function 'DAC960_Probe':
> drivers/block/DAC960.c:6591:38: warning: 'sprintf' may wr
On 7/13/2017 9:26 PM, Ding Tianhong wrote:
> There is no code to enable the PCIe Relaxed Ordering bit in the configuration
> space,
> it is only be enable by default according to the PCIe Standard Specification,
> what we
> do is to distinguish the RC problematic platform and clear the Relaxed
>
On Fri, Jul 14, 2017 at 02:07:14PM +0200, Arnd Bergmann wrote:
> gcc-7 points out that a negative port_num value would overflow
> the string buffer:
>
> drivers/infiniband/hw/mlx4/sysfs.c: In function
> 'mlx4_ib_device_register_sysfs':
> drivers/infiniband/hw/mlx4/sysfs.c:251:16: error: 'sprintf'
On Fri, 2017-07-14 at 14:07 +0200, Arnd Bergmann wrote:
> gcc-7 notices that the pin_table is an array of 16-bit numbers,
> but we assume it can be printed as a two-character hexadecimal
> string:
>
> drivers/gpio/gpiolib-acpi.c: In function
> 'acpi_gpiochip_request_interrupt':
> drivers/gpio/gpio
On 14/07/17 13:07, Arnd Bergmann wrote:
> gcc warns that the temporary buffer might be too small here:
>
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_probe':
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:16: error: '%d'
> directive writing between 1 and 10 byte
On Fri, 14 Jul 2017 14:07:12 +0200,
Arnd Bergmann wrote:
>
> With gcc-7, we get various warnings about a possible string overflow:
>
> sound/pci/rme9652/hdspm.c: In function 'snd_hdspm_create_alsa_devices':
> sound/pci/rme9652/hdspm.c:2123:17: error: ' MIDIoverMADI' directive writing
> 13 bytes
We print a 256 byte event string into a buffer that is only 161
bytes long, this is clearly wrong:
drivers/scsi/gdth_proc.c: In function 'gdth_show_info':
drivers/scsi/gdth.c:3660:41: error: '%s' directive writing up to 255 bytes into
a region of size between 141 and 150 [-Werror=format-overflow=
gcc notices that we would overflow the buffer for the
inquiry of the product name if we have too many adapters:
drivers/scsi/gdth.c: In function 'gdth_next':
drivers/scsi/gdth.c:2357:29: warning: 'sprintf' may write a terminating nul
past the end of the destination [-Wformat-overflow=]
s
gcc-7 notices that we copy a fixed length string into another
string of the same size, with additional characters:
drivers/media/usb/usbvision/usbvision-i2c.c: In function
'usbvision_i2c_register':
drivers/media/usb/usbvision/usbvision-i2c.c:190:36: error: '%d' directive
writing between 1 and 11
With gcc-7, we get various warnings about a possible string overflow:
sound/pci/rme9652/hdspm.c: In function 'snd_hdspm_create_alsa_devices':
sound/pci/rme9652/hdspm.c:2123:17: error: ' MIDIoverMADI' directive writing 13
bytes into a region of size between 1 and 32 [-Werror=format-overflow=]
soun
gcc-7 points out that a negative port_num value would overflow
the string buffer:
drivers/infiniband/hw/mlx4/sysfs.c: In function 'mlx4_ib_device_register_sysfs':
drivers/infiniband/hw/mlx4/sysfs.c:251:16: error: 'sprintf' may write a
terminating nul past the end of the destination [-Werror=forma
gcc points out a minor bug in the handling of unknown
cookie types, which could result in a string overflow
when the integer is copied into a 3-byte string:
fs/fscache/object-list.c: In function 'fscache_objlist_show':
fs/fscache/object-list.c:265:19: error: 'sprintf' may write a terminating nul
We have space for exactly one character for the index in "max7315_%d_base",
but as gcc points out having more would cause an string overflow:
arch/x86/platform/intel-mid/device_libs/platform_max7315.c: In function
'max7315_platform_data':
arch/x86/platform/intel-mid/device_libs/platform_max7315.c
gcc-7 points out that a large controller number would overflow the
string length for the procfs name and the firmware version string:
drivers/block/DAC960.c: In function 'DAC960_Probe':
drivers/block/DAC960.c:6591:38: warning: 'sprintf' may write a terminating nul
past the end of the destination
gcc-7 notices that the pin_table is an array of 16-bit numbers,
but we assume it can be printed as a two-character hexadecimal
string:
drivers/gpio/gpiolib-acpi.c: In function 'acpi_gpiochip_request_interrupt':
drivers/gpio/gpiolib-acpi.c:206:24: warning: '%02X' directive writing between 2
and 4
gcc points out a possible format string overflow for a large value of 'zone':
drivers/platform/x86/alienware-wmi.c: In function 'alienware_wmi_init':
drivers/platform/x86/alienware-wmi.c:461:24: error: '%02X' directive writing
between 2 and 8 bytes into a region of size 6 [-Werror=format-overflow
gcc-7 warns that the key might exceed five bytes for lage index
values:
drivers/hwmon/applesmc.c: In function 'applesmc_show_fan_position':
drivers/hwmon/applesmc.c:906:18: error: '%d' directive writing between 1 and 5
bytes into a region of size 4 [-Werror=format-overflow=]
sprintf(newkey, FAN_I
1 - 100 of 125 matches
Mail list logo
