[PATCH 0/9] v2 ipv4/ipv6 refcount conversions

2017-07-03 Thread Elena Reshetova
Changes in v2: * rebase on top of net-next * currently by default refcount_t = atomic_t (*) and uses all atomic standard operations unless CONFIG_REFCOUNT_FULL is enabled. This is a compromise for the systems that are critical on performance (such as net) and cannot accept even slight d

[PATCH 1/9] net, ipv6: convert ipv6_txoptions.refcnt from atomic_t to refcount_t

2017-07-03 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 3/9] net, ipv6: convert inet6_ifaddr.refcnt from atomic_t to refcount_t

2017-07-03 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 4/9] net, ipv6: convert ifmcaddr6.mca_refcnt from atomic_t to refcount_t

2017-07-03 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 2/9] net, ipv6: convert inet6_dev.refcnt from atomic_t to refcount_t

2017-07-03 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 6/9] net, ipv6: convert xfrm6_tunnel_spi.refcnt from atomic_t to refcount_t

2017-07-03 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 5/9] net, ipv6: convert ifacaddr6.aca_refcnt from atomic_t to refcount_t

2017-07-03 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 9/9] net, ipv4: convert fib_info.fib_clntref from atomic_t to refcount_t

2017-07-03 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 7/9] net, ipv6: convert ip6addrlbl_entry.refcnt from atomic_t to refcount_t

2017-07-03 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

[PATCH 8/9] net, ipv4: convert cipso_v4_doi.refcount from atomic_t to refcount_t

2017-07-03 Thread Elena Reshetova
refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by: Hans Liljestrand Signed-off-

Re: [PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer type

2017-07-03 Thread Jiri Pirko
Tue, Jul 04, 2017 at 02:14:25AM CEST, robert.mcc...@rockwellcollins.com wrote: >This is to support user-space modification of the qdisc stab. > >Signed-off-by: McCabe, Robert J >--- > include/uapi/linux/pkt_sched.h | 1 + > net/sched/sch_api.c| 2 ++ > 2 files changed, 3 insertions(+) >

Re: 'skb' buffer address information leakage

2017-07-03 Thread Jakub Kicinski
On Tue, 4 Jul 2017 13:12:18 +0800, Dison River wrote: > drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c:167 > seq_printf(file, " frag=%p", skb); FWIW that's actually not a skb pointer. The structure is defined like this: struct nfp_net_tx_buf { union { stru

'skb' buffer address information leakage

2017-07-03 Thread Dison River
Hi all: I'd found several address leaks of "skb" buffer.When i have a arbitrary address write vulnerability in kernel(enabled kASLR),I can use skb's address find sk_destruct's address and overwrite it. And then,invoke close(sock_fd) function can trigger the shellcode(sk_destruct func). In kernel 4

[PATCH] net: ethernet: mediatek: fixed deadlock captured by lockdep

2017-07-03 Thread sean.wang
From: Sean Wang Lockdep found an inconsistent lock state when mtk_get_stats64 is called in user context while NAPI updates MAC statistics in softirq. Use spin_trylock_bh/spin_unlock_bh fix following lockdep warning. [ 81.321030] WARNING: inconsistent lock state [ 81.325266] 4.12.0-rc1-00035

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

2017-07-03 Thread Paul E. McKenney
On Mon, Jul 03, 2017 at 05:39:36PM -0700, Paul E. McKenney wrote: > On Mon, Jul 03, 2017 at 03:49:42PM -0700, Linus Torvalds wrote: > > On Mon, Jul 3, 2017 at 3:30 PM, Paul E. McKenney > > wrote: > > > > > > That certainly is one interesting function, isn't it? I wonder what > > > happens if you

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

2017-07-03 Thread Paul E. McKenney
On Mon, Jul 03, 2017 at 03:49:42PM -0700, Linus Torvalds wrote: > On Mon, Jul 3, 2017 at 3:30 PM, Paul E. McKenney > wrote: > > > > That certainly is one interesting function, isn't it? I wonder what > > happens if you replace the raw_spin_is_locked() calls with an > > unlock under a trylock chec

[PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer type

2017-07-03 Thread McCabe, Robert J
This is to support user-space modification of the qdisc stab. Signed-off-by: McCabe, Robert J --- include/uapi/linux/pkt_sched.h | 1 + net/sched/sch_api.c| 2 ++ 2 files changed, 3 insertions(+) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index 099b

[PATCH 1/1] tc: custom qdisc pkt size translation table

2017-07-03 Thread McCabe, Robert J
Added the "custom" linklayer qdisc stab option. Allows the user to specify the pkt size translation parameters from stdin. Example: tc qdisc add ... stab tsize 8 linklayer custom htb Custom size table: InputSizeStart -> IntputSizeEnd: OutputSize 0 -> 511 :

Re: [PATCH] vmalloc: respect the GFP_NOIO and GFP_NOFS flags

2017-07-03 Thread Mikulas Patocka
On Mon, 3 Jul 2017, Michal Hocko wrote: > We can add a warning (or move it from kvmalloc) and hope that the > respective maintainers will fix those places properly. The reason I > didn't add the warning to vmalloc and kept it in kvmalloc was to catch > only new users rather than suddenly splat o

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

2017-07-03 Thread Linus Torvalds
On Mon, Jul 3, 2017 at 3:30 PM, Paul E. McKenney wrote: > > That certainly is one interesting function, isn't it? I wonder what > happens if you replace the raw_spin_is_locked() calls with an > unlock under a trylock check? ;-) Deadlock due to interrupts again? Didn't your spin_unlock_wait() p

[PATCH net-next] mpls: route get support

2017-07-03 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds RTM_GETROUTE doit handler for mpls routes. Input: RTA_DST - input label RTA_NEWDST - labels in packet for multipath selection By default the getroute handler returns matched nexthop label, via and oif With RTM_F_FIB_MATCH flag, full matched route is returned.

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

2017-07-03 Thread Paul E. McKenney
On Mon, Jul 03, 2017 at 06:13:38PM +0100, Will Deacon wrote: > On Mon, Jul 03, 2017 at 09:40:22AM -0700, Linus Torvalds wrote: > > On Mon, Jul 3, 2017 at 9:18 AM, Paul E. McKenney > > wrote: > > > > > > Agreed, and my next step is to look at spin_lock() followed by > > > spin_is_locked(), not nece

[PATCH net-next] bridge: allow ext learned entries to change ports

2017-07-03 Thread Roopa Prabhu
From: Nikolay Aleksandrov current code silently ignores change of port in the request message. This patch makes sure the port is modified and notification is sent to userspace. Fixes: cf6b8e1eedff ("bridge: add API to notify bridge driver of learned FBD on offloaded device") Signed-off-by: Niko

Re: [RFC/RFT PATCH 2/4] net: ethernat: ti: cpts: enable irq

2017-07-03 Thread Ivan Khoronzhuk
On Mon, Jul 03, 2017 at 02:31:06PM -0500, Grygorii Strashko wrote: > > > On 06/30/2017 08:31 PM, Ivan Khoronzhuk wrote: > > On Tue, Jun 13, 2017 at 06:16:21PM -0500, Grygorii Strashko wrote: > >> There are two reasons for this change: > >> 1) enabling of HW_TS_PUSH events as suggested by Richard

Re: [PATCH net-next] qed: initialize ll2_syn_handle at start of function

2017-07-03 Thread David Miller
From: Michal Kalderon Date: Mon, 3 Jul 2017 21:55:25 +0300 > Fix compilation warning > qed_iwarp.c:1721:5: warning: ll2_syn_handle may be used > uninitialized in this function > > Signed-off-by: Michal Kalderon > Signed-off-by: Ariel Elior Applied, thanks for fixing this so fast.

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

2017-07-03 Thread Paul E. McKenney
On Mon, Jul 03, 2017 at 09:40:22AM -0700, Linus Torvalds wrote: > On Mon, Jul 3, 2017 at 9:18 AM, Paul E. McKenney > wrote: > > > > Agreed, and my next step is to look at spin_lock() followed by > > spin_is_locked(), not necessarily the same lock. > > Hmm. Most (all?) "spin_is_locked()" really sh

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

2017-07-03 Thread Paul E. McKenney
On Mon, Jul 03, 2017 at 04:04:14PM -0400, Alan Stern wrote: > On Mon, 3 Jul 2017, Paul E. McKenney wrote: > > > On Mon, Jul 03, 2017 at 10:39:49AM -0400, Alan Stern wrote: > > > On Sat, 1 Jul 2017, Manfred Spraul wrote: > > > > > > > As we want to remove spin_unlock_wait() and replace it with exp

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

2017-07-03 Thread Alan Stern
On Mon, 3 Jul 2017, Paul E. McKenney wrote: > On Mon, Jul 03, 2017 at 10:39:49AM -0400, Alan Stern wrote: > > On Sat, 1 Jul 2017, Manfred Spraul wrote: > > > > > As we want to remove spin_unlock_wait() and replace it with explicit > > > spin_lock()/spin_unlock() calls, we can use this to simplify

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

2017-07-03 Thread Alan Stern
On Mon, 3 Jul 2017, Manfred Spraul wrote: > >>> + /* 2) read nf_conntrack_locks_all, with ACQUIRE semantics */ > >>> + if (likely(smp_load_acquire(&nf_conntrack_locks_all) == false)) > >>> + return; > >> As far as I can tell, this read does not need to have ACQUIRE > >> semantics. > >> > >

Re: [RFC/RFT PATCH 2/4] net: ethernat: ti: cpts: enable irq

2017-07-03 Thread Grygorii Strashko
On 06/30/2017 08:31 PM, Ivan Khoronzhuk wrote: > On Tue, Jun 13, 2017 at 06:16:21PM -0500, Grygorii Strashko wrote: >> There are two reasons for this change: >> 1) enabling of HW_TS_PUSH events as suggested by Richard Cochran and >> discussed in [1] >> 2) fixing an TX timestamping miss issue whic

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

2017-07-03 Thread Manfred Spraul
On 07/03/2017 07:14 PM, Paul E. McKenney wrote: On Mon, Jul 03, 2017 at 10:39:49AM -0400, Alan Stern wrote: On Sat, 1 Jul 2017, Manfred Spraul wrote: As we want to remove spin_unlock_wait() and replace it with explicit spin_lock()/spin_unlock() calls, we can use this to simplify the locking.

[PATCH net-next] qed: initialize ll2_syn_handle at start of function

2017-07-03 Thread Michal Kalderon
Fix compilation warning qed_iwarp.c:1721:5: warning: ll2_syn_handle may be used uninitialized in this function Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/

Re: [PATCH net-next 00/12] qed: Add iWARP support for QL4xxxx

2017-07-03 Thread Kalderon, Michal
From: David Miller Sent: Monday, July 3, 2017 11:59 AM > You really have to compile test your work and do something with > the warnings: > drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1721:5: warning: ‘ll2_syn_handle’ > may be used uninitialized in this funct > This one is completely legitimate

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

2017-07-03 Thread Paul E. McKenney
On Mon, Jul 03, 2017 at 10:39:49AM -0400, Alan Stern wrote: > On Sat, 1 Jul 2017, Manfred Spraul wrote: > > > As we want to remove spin_unlock_wait() and replace it with explicit > > spin_lock()/spin_unlock() calls, we can use this to simplify the > > locking. > > > > In addition: > > - Reading n

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

2017-07-03 Thread Will Deacon
On Mon, Jul 03, 2017 at 09:40:22AM -0700, Linus Torvalds wrote: > On Mon, Jul 3, 2017 at 9:18 AM, Paul E. McKenney > wrote: > > > > Agreed, and my next step is to look at spin_lock() followed by > > spin_is_locked(), not necessarily the same lock. > > Hmm. Most (all?) "spin_is_locked()" really sh

[PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak

2017-07-03 Thread Eduardo Valentin
We currently get the following kmemleak report: unreferenced object 0x8800039d9820 (size 32): comm "softirq", pid 0, jiffies 4295212383 (age 792.416s) hex dump (first 32 bytes): 00 0c e0 03 00 88 ff ff ff 02 00 00 00 00 00 00 00 00 00 01 ff 11 00 02 86 dd 00 00 ff

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-07-03 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 08:05:06PM +0800, Jason Wang wrote: > > > On 2017年06月28日 12:01, Michael S. Tsirkin wrote: > > On Wed, Jun 28, 2017 at 11:40:30AM +0800, Jason Wang wrote: > > > > > > On 2017年06月28日 11:31, Michael S. Tsirkin wrote: > > > > On Wed, Jun 28, 2017 at 10:45:18AM +0800, Jason Wa

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

2017-07-03 Thread Linus Torvalds
On Mon, Jul 3, 2017 at 9:18 AM, Paul E. McKenney wrote: > > Agreed, and my next step is to look at spin_lock() followed by > spin_is_locked(), not necessarily the same lock. Hmm. Most (all?) "spin_is_locked()" really should be about the same thread that took the lock (ie it's about asserts and lo

Re: [CRIU] BUG: Dentry ffff9f795a08fe60{i=af565f, n=lo} still in use (1) [unmount of proc proc]

2017-07-03 Thread Andrei Vagin
On Fri, Jun 30, 2017 at 12:11:07PM -0700, Andrei Vagin wrote: > On Thu, Jun 29, 2017 at 08:42:23PM -0500, Eric W. Biederman wrote: > > Andrei Vagin writes: > > > > > On Thu, Jun 29, 2017 at 12:06 PM, Eric W. Biederman > > > wrote: > > >> Andrei Vagin writes: > > >> > > >>> Hello, > > >>> > > >>

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

2017-07-03 Thread Paul E. McKenney
On Mon, Jul 03, 2017 at 02:15:14PM +0100, Will Deacon wrote: > On Fri, Jun 30, 2017 at 03:18:40PM -0700, Paul E. McKenney wrote: > > On Fri, Jun 30, 2017 at 02:13:39PM +0100, Will Deacon wrote: > > > On Fri, Jun 30, 2017 at 05:38:15AM -0700, Paul E. McKenney wrote: > > > > I also need to check all

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

2017-07-03 Thread Alan Stern
On Sat, 1 Jul 2017, Manfred Spraul wrote: > As we want to remove spin_unlock_wait() and replace it with explicit > spin_lock()/spin_unlock() calls, we can use this to simplify the > locking. > > In addition: > - Reading nf_conntrack_locks_all needs ACQUIRE memory ordering. > - The new code avoids

Re: [PATCH iproute2 V2 1/4] rdma: Add basic infrastructure for RDMA tool

2017-07-03 Thread Yuval Shaia
On Mon, Jul 03, 2017 at 05:06:55PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > RDMA devices are cross-functional devices from one side, > but very tailored for the specific markets from another. > > Such diversity caused to spread of RDMA related configuration > across various tool

locking issues in macvtap (looks like due to tap: Extending tap device create/destroy APIs)

2017-07-03 Thread Christian Borntraeger
Sainath, with rcu debugging and lock debugging I get the following splats. I think doing a mutex_lock while in an rcu read-side is not allowed, since mutex_lock can sleep. This is in 4.11 and 4.12 and seems to be introduced with commit d9f1f61c0801a7("tap: Extending tap device create/destroy APIs

[PATCH iproute2 V2 4/4] rdma: Add initial manual for the tool

2017-07-03 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- man/man8/Makefile | 3 +- man/man8/rdma.8 | 82 +++ 2 files changed, 84 insertions(+), 1 deletion(-) create mode 100644 man/man8/rdma.8 diff --git a/man/man8/Makefile b/man/man8/Mak

[PATCH iproute2 V2 3/4] rdma: Add link object

2017-07-03 Thread Leon Romanovsky
From: Leon Romanovsky Link (port) object represent struct ib_port to the user space. Link properties: * Port capabilities * IB subnet prefix * LID, SM_LID and LMC * Port state * Physical state Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/link.c | 280

[PATCH iproute2 V2 2/4] rdma: Add dev object

2017-07-03 Thread Leon Romanovsky
From: Leon Romanovsky Device (dev) object represents struct ib_device to the user space. Device properties: * Device capabilities * FW version to the device output * node_guid and sys_image_guid * node_type Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/dev.c| 235 +++

[PATCH iproute2 V2 1/4] rdma: Add basic infrastructure for RDMA tool

2017-07-03 Thread Leon Romanovsky
From: Leon Romanovsky RDMA devices are cross-functional devices from one side, but very tailored for the specific markets from another. Such diversity caused to spread of RDMA related configuration across various tools, e.g. devlink, ip, ethtool, ib specific and vendor specific solutions. This

[PATCH iproute2 V2 0/4] RDMAtool

2017-07-03 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This is second version of series implementing the RDAMtool - the tool to configure RDMA devices. The initial proposal was sent as RFC [1] and was based on sysfs entries as POC. The current series was rewritten completely to work with RDMA netlinks as a source of user<

[PATCH net v2 0/1] reflect mark on tcp syn ack packets

2017-07-03 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Changes from v1(Lorenzo): unconditionally set skb->mark = ireq->ir_mark; Jamal Hadi Salim (1): net: reflect mark on tcp syn ack packets net/ipv4/ip_output.c | 3 ++- net/ipv4/tcp_output.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) -- 1.9.1

[PATCH net v2 1/1] net: reflect mark on tcp syn ack packets

2017-07-03 Thread Jamal Hadi Salim
From: Jamal Hadi Salim SYN-ACK responses on a server in response to a SYN from a client did not get the injected skb mark that was tagged on the SYN packet. Fixes: 84f39b08d786 ("net: support marking accepting TCP sockets") Reviewed-by: Lorenzo Colitti Signed-off-by: Jamal Hadi Salim --- net/

Re: [PATCH net 1/2] vxlan: fix hlist corruption

2017-07-03 Thread Waiman Long
On 07/03/2017 04:23 AM, Jiri Benc wrote: > On Sun, 2 Jul 2017 16:06:10 -0400, Waiman Long wrote: >> I didn't see any init code for hlist4 and hlist6. Is vxlan_dev going to >> be *zalloc'ed so that they are guaranteed to be NULL? If not, you may >> need to add init code as not both hlists will be h

Re: [PATCH RFC 08/26] locking: Remove spin_unlock_wait() generic definitions

2017-07-03 Thread Will Deacon
On Fri, Jun 30, 2017 at 03:18:40PM -0700, Paul E. McKenney wrote: > On Fri, Jun 30, 2017 at 02:13:39PM +0100, Will Deacon wrote: > > On Fri, Jun 30, 2017 at 05:38:15AM -0700, Paul E. McKenney wrote: > > > I also need to check all uses of spin_is_locked(). There might no > > > longer be any that re

Re: [PATCH RFC 2/2] kproxy: Kernel proxy

2017-07-03 Thread David Miller
From: Tom Herbert Date: Thu, 29 Jun 2017 11:27:05 -0700 > A proc file (/prox/net/kproxy) is created to list all the running > kernel proxies and relevant statistics for them. proc is deprecated for dumping information like this, please use sock diag instead.

Re: [PATCH RFC 1/2] skbuff: Function to send an skbuf on a socket

2017-07-03 Thread David Miller
From: Tom Herbert Date: Thu, 29 Jun 2017 11:27:04 -0700 > +int skb_send_sock(struct sk_buff *skb, struct socket *sock, unsigned int > offset) > +{ > + unsigned int sent = 0; > + unsigned int ret; > + unsigned short fragidx; Please use reverse christmas tree ordering for these local

Re: pull-request: wireless-drivers-next 2017-07-03

2017-07-03 Thread David Miller
From: Kalle Valo Date: Mon, 03 Jul 2017 14:39:07 +0300 > here's the late pull request to net-next I mentioned about last week to > get some new iwlwifi hw support to 4.13. > > If this is too late just drop the request and let me know, I can then > resend it for 4.14 after the merge window. These

Re: [PATCH] openvswitch: fix mis-ordered comment lines for ovs_skb_cb

2017-07-03 Thread David Miller
From: Daniel Axtens Date: Mon, 3 Jul 2017 21:46:43 +1000 > I was trying to wrap my head around meaning of mru, and realised > that the second line of the comment defining it had somehow > ended up after the line defining cutlen, leading to much confusion. > > Reorder the lines to make sense. >

Re: [PATCH 0/2] Fixes for errors reported by 0day on net-next tree

2017-07-03 Thread David Miller
From: Elena Reshetova Date: Mon, 3 Jul 2017 14:50:26 +0300 > Despite the fact that we have automatic testing enabled > on all our branches, there s390-config related errors got through. > I will investigate separately why it happened. > Sorry for the inconvince and please pull. Update your net-

[PATCH 1/2] net, iucv: fixing error from refcount conversion

2017-07-03 Thread Elena Reshetova
Fixing "net/iucv/af_iucv.c:405:22: error: passing argument 1 of 'atomic_read' from incompatible pointer type" --- net/iucv/af_iucv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index ac033e4..1485331 100644 --- a/net/iucv/af_iucv.c ++

[PATCH 2/2] drivers, s390: fix errors resulting from refcount conversions

2017-07-03 Thread Elena Reshetova
For some reason it looks like our tree hasn't been tested with s390-default_defconfig, so this commit fixes errors reported from it. --- drivers/s390/net/ctcm_fsms.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/s390/net/ctcm_fsms.c b/drivers/s390/net/ctc

[PATCH 0/2] Fixes for errors reported by 0day on net-next tree

2017-07-03 Thread Elena Reshetova
Despite the fact that we have automatic testing enabled on all our branches, there s390-config related errors got through. I will investigate separately why it happened. Sorry for the inconvince and please pull. Elena Reshetova (2): net, iucv: fixing error from refcount conversion drivers, s39

[PATCH] openvswitch: fix mis-ordered comment lines for ovs_skb_cb

2017-07-03 Thread Daniel Axtens
I was trying to wrap my head around meaning of mru, and realised that the second line of the comment defining it had somehow ended up after the line defining cutlen, leading to much confusion. Reorder the lines to make sense. Signed-off-by: Daniel Axtens --- net/openvswitch/datapath.h | 2 +- 1

pull-request: wireless-drivers-next 2017-07-03

2017-07-03 Thread Kalle Valo
Hi Dave, here's the late pull request to net-next I mentioned about last week to get some new iwlwifi hw support to 4.13. If this is too late just drop the request and let me know, I can then resend it for 4.14 after the merge window. These patches were included in today's linux-next build and I

[PATCH net] ixgbe: fix masking of bits read from IXGBE_VXLANCTRL register

2017-07-03 Thread Sabrina Dubroca
In ixgbe_clear_udp_tunnel_port(), we read the IXGBE_VXLANCTRL register and then try to mask some bits out of the value, using the logical instead of bitwise and operator. Fixes: a21d0822ff69 ("ixgbe: add support for geneve Rx offload") Signed-off-by: Sabrina Dubroca --- drivers/net/ethernet/inte

Re: [PATCH 00/17] v3 net generic subsystem refcount conversions

2017-07-03 Thread Eric Dumazet
On Mon, 2017-07-03 at 09:57 +, Reshetova, Elena wrote: > Thank you very much for the report! This is an underflow (dec/sub from > zero) that is reported by WARNING. > I guess it is unlikely that actual code underflows, so the most > probable cause is that it attempted to do refcount_inc/add()

Re: [PATCH net-next] net: avoid one splat in fib_nl_delrule()

2017-07-03 Thread David Miller
From: Eric Dumazet Date: Mon, 03 Jul 2017 02:54:33 -0700 > From: Eric Dumazet > > We need to use refcount_set() on a newly created rule to avoid > following error : ... > Fixes: 717d1e993ad8 ("net: convert fib_rule.refcnt from atomic_t to > refcount_t") > Signed-off-by: Eric Dumazet Applie

Re: [PATCH net-next] net: make sk_ehashfn() static

2017-07-03 Thread David Miller
From: Eric Dumazet Date: Mon, 03 Jul 2017 02:57:54 -0700 > From: Eric Dumazet > > sk_ehashfn() is only used from a single file. > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH 1/1] mlx4_en: make mlx4_log_num_mgm_entry_size static

2017-07-03 Thread Sergei Shtylyov
Hello! On 7/3/2017 8:35 AM, Zhu Yanjun wrote: The variable mlx4_log_num_mgm_entry_size is only called in main.c. s/called/used/. CC: Joe Jin CC: Junxiao Bi Signed-off-by: Zhu Yanjun [...] MBR, Sergei

[PATCH net-next] net: make sk_ehashfn() static

2017-07-03 Thread Eric Dumazet
From: Eric Dumazet sk_ehashfn() is only used from a single file. Signed-off-by: Eric Dumazet --- include/net/inet_hashtables.h |1 - net/ipv4/inet_hashtables.c|2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/net/inet_hashtables.h b/include/net/inet_hasht

RE: [PATCH 00/17] v3 net generic subsystem refcount conversions

2017-07-03 Thread Reshetova, Elena
> On Fri, 2017-06-30 at 13:07 +0300, Elena Reshetova wrote: > > Changes in v3: > > Rebased on top of the net-next tree. > > > > Changes in v2: > > No changes in patches apart from rebases, but now by > > default refcount_t = atomic_t (*) and uses all atomic standard operations > > unless CONFIG_

Re: [PATCH NET V5 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-07-03 Thread Yunsheng Lin
Hi, Andrew On 2017/7/1 23:17, Andrew Lunn wrote: > On Sat, Jul 01, 2017 at 11:57:32AM +, linyunsheng wrote: >> Hi, Andrew >> >> I am agreed wih you on this. >> But self test is also a feature of our product, and our >> customer way choose to diagnose a problem using >> self test, even if self

[PATCH net-next] net: avoid one splat in fib_nl_delrule()

2017-07-03 Thread Eric Dumazet
From: Eric Dumazet We need to use refcount_set() on a newly created rule to avoid following error : [ 64.601749] [ cut here ] [ 64.601757] WARNING: CPU: 0 PID: 6476 at lib/refcount.c:184 refcount_sub_and_test+0x75/0xa0 [ 64.601758] Modules linked in: w1_therm wire

Re: [PATCH 1/1] mlx4_en: make mlx4_log_num_mgm_entry_size static

2017-07-03 Thread David Miller
From: Zhu Yanjun Date: Mon, 3 Jul 2017 01:35:19 -0400 > The variable mlx4_log_num_mgm_entry_size is only called in main.c. > > CC: Joe Jin > CC: Junxiao Bi > Signed-off-by: Zhu Yanjun Applied, thank you.

Re: [PATCH] net: core: Fix slab-out-of-bounds in netdev_stats_to_stats64

2017-07-03 Thread David Miller
From: Alban Browaeys Date: Mon, 3 Jul 2017 03:20:13 +0200 > commit 9256645af098 ("net/core: relax BUILD_BUG_ON in > netdev_stats_to_stats64") made an attempt to read beyond > the size of the source a possibility. > > Fix to only copy src size to dest. As dest might be bigger than src. ... > Si

Re: [PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump()

2017-07-03 Thread David Miller
From: Christos Gkekas Date: Sun, 2 Jul 2017 23:16:11 +0100 > Pointer hdr in netxen_setup_minidump() is set but never used, thus > should be removed. > > Signed-off-by: Christos Gkekas Applied, thanks.

Re: [PATCH net 0/2] vxlan, geneve: fix hlist corruption

2017-07-03 Thread David Miller
From: Jiri Benc Date: Sun, 2 Jul 2017 19:00:56 +0200 > Fix memory corruption introduced with the support of both IPv4 and IPv6 > sockets in a single device. The same bug is present in VXLAN and Geneve. > > Signed-off-by: Jiri Benc Series applied and queued up for -stable, thanks.

Re: [PATCH net-next] net/mlxfw: Properly handle dependancy with non-loadable mlx5

2017-07-03 Thread David Miller
From: Or Gerlitz Date: Sun, 2 Jul 2017 18:57:28 +0300 > If mlx5 is set to be built-in and mlxfw as a module, we > get a link error: > > drivers/built-in.o: In function `mlx5_firmware_flash': > (.text+0x5aed72): undefined reference to `mlxfw_firmware_flash' > > Since we don't want to mandate se

Re: [PATCH 00/17] v3 net generic subsystem refcount conversions

2017-07-03 Thread Eric Dumazet
On Fri, 2017-06-30 at 13:07 +0300, Elena Reshetova wrote: > Changes in v3: > Rebased on top of the net-next tree. > > Changes in v2: > No changes in patches apart from rebases, but now by > default refcount_t = atomic_t (*) and uses all atomic standard operations > unless CONFIG_REFCOUNT_FULL is e

Re: [PATCH net-next 0/7] Misc BPF helper/verifier improvements

2017-07-03 Thread David Miller
From: Daniel Borkmann Date: Sun, 2 Jul 2017 02:13:24 +0200 > Miscellanous improvements I still had in my queue, it adds a new > bpf_skb_adjust_room() helper for cls_bpf, exports to fdinfo whether > tail call array owner is JITed, so iproute2 error reporting can be > improved on that regard, a sm

Re: [PATCH] net: cdc_mbim: apply "NDP to end" quirk to HP lt4132

2017-07-03 Thread David Miller
From: Tore Anderson Date: Sat, 1 Jul 2017 15:20:02 +0200 > The HP lt4132 LTE/HSPA+ 4G Module (03f0:a31d) is a rebranded Huawei > ME906s-158 device. It, like the ME906s-158, requires the "NDP to end" > quirk for correct operation. > > Signed-off-by: Tore Anderson Applied, thank you.

Re: [PATCH net-next] net/packet: Fix Tx queue selection for AF_PACKET

2017-07-03 Thread David Miller
From: Iván Briano Date: Fri, 30 Jun 2017 14:02:32 -0700 > When PACKET_QDISC_BYPASS is not used, Tx queue selection will be done > before the packet is enqueued, taking into account any mappings set by > a queuing discipline such as mqprio without hardware offloading. This > selection may be affec

Re: [PATCH v2] Documentation: fix wrong example command

2017-07-03 Thread David Miller
From: Matteo Croce Date: Fri, 30 Jun 2017 18:21:47 +0200 > In the IPVLAN documentation there is an example command line where the > master and slave interface names are inverted. > Fix the command line and also add the optional `name' keyword to better > describe what the command is doing. > > v

Re: [PATCH net-next] vxlan: correctly set vxlan->net when creating the device in a netns

2017-07-03 Thread David Miller
From: Sabrina Dubroca Date: Fri, 30 Jun 2017 15:50:00 +0200 > Commit a985343ba906 ("vxlan: refactor verification and application of > configuration") modified vxlan device creation, and replaced the > assignment of vxlan->net to src_net with dev_net(netdev) in ->setup(). > > But dev_net(netdev)

Re: [PATCH net-next v8 0/2] Add loopback support in phy_driver and hns ethtool fix

2017-07-03 Thread David Miller
From: Lin Yun Sheng Date: Fri, 30 Jun 2017 17:44:14 +0800 > This Patch Set add set_loopback in phy_driver and use it to setup loopback > when doing ethtool phy self_test. Series applied, thank you.

Re: [PATCH net-next 00/12] qed: Add iWARP support for QL4xxxx

2017-07-03 Thread David Miller
You really have to compile test your work and do something with the warnings: drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1721:5: warning: ‘ll2_syn_handle’ may be used uninitialized in this funct This one is completely legitimate, you can goto "err" and use the ll2_syn_handle without it being i

Re: linux-next: build failure after merge of the akpm tree

2017-07-03 Thread David Miller
From: Stephen Rothwell Date: Fri, 30 Jun 2017 16:32:41 +1000 > From: Stephen Rothwell > Date: Fri, 30 Jun 2017 16:24:35 +1000 > Subject: [PATCH] net/mlx5: fix memcpy limit? > > Signed-off-by: Stephen Rothwell Applied, thanks.

Re: [PATCH net] ipv6: dad: don't remove dynamic addresses if link is down

2017-07-03 Thread David Miller
From: Sabrina Dubroca Date: Thu, 29 Jun 2017 16:56:54 +0200 > Currently, when the link for $DEV is down, this command succeeds but the > address is removed immediately by DAD (1): > > ip addr add ::12/64 dev $DEV valid_lft 3600 preferred_lft 1800 > > In the same situation, this will suc

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

2017-07-03 Thread David Miller
From: Jim Baxter Date: Wed, 28 Jun 2017 21:35:29 +0100 > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources but wish to maximise the

Re: [PATCH net-next 00/12] qed: Add iWARP support for QL4xxxx

2017-07-03 Thread David Miller
From: Michal Kalderon Date: Sun, 2 Jul 2017 10:29:20 +0300 > This patch series adds iWARP support to our QL4 networking adapters. > The code changes span across qed and qedr drivers, but this series contains > changes to qed only. Once the series is accepted, the qedr series will > be submitt

Re: [PATCH net 1/2] vxlan: fix hlist corruption

2017-07-03 Thread Jiri Benc
On Sun, 2 Jul 2017 16:06:10 -0400, Waiman Long wrote: > I didn't see any init code for hlist4 and hlist6. Is vxlan_dev going to > be *zalloc'ed so that they are guaranteed to be NULL? If not, you may > need to add init code as not both hlists will be hashed and so one of > them may contain invalid

Re: linux-next: build failure after merge of the akpm tree

2017-07-03 Thread Stephen Rothwell
Hi all, On Fri, 30 Jun 2017 16:32:41 +1000 Stephen Rothwell wrote: > > After merging the akpm tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from include/linux/bitmap.h:8:0, > from include/linux/cpumask.h:11, > fro

Re: [PATCH net-next] vxlan: correctly set vxlan->net when creating the device in a netns

2017-07-03 Thread Matthias Schiffer
On 06/30/2017 03:50 PM, Sabrina Dubroca wrote: > Commit a985343ba906 ("vxlan: refactor verification and application of > configuration") modified vxlan device creation, and replaced the > assignment of vxlan->net to src_net with dev_net(netdev) in ->setup(). > > But dev_net(netdev) is not the same

Re: linux-next: manual merge of the net-next tree with the net tree

2017-07-03 Thread Saeed Mahameed
On Mon, Jul 3, 2017 at 4:43 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got conflicts in: > > drivers/net/ethernet/mellanox/mlx5/core/health.c > include/linux/mlx5/driver.h > > between commit: > > 2a0165a034ac ("net/mlx5: Cancel delayed recovery wo

Re: linux-next: manual merge of the net-next tree with the arm64 tree

2017-07-03 Thread Daniel Borkmann
On 07/03/2017 03:37 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in: arch/arm64/net/bpf_jit_comp.c between commit: 425e1ed73e65 ("arm64: fix endianness annotation for 'struct jit_ctx' and friends") from the arm64 tree and commit:

[PATCH] mwifiex: uninit wakeup info when failed to add card

2017-07-03 Thread Jeffy Chen
We inited wakeup info at the beginning of mwifiex_add_card, so we need to uninit it in the error handling. It's much the same as what we did in: 36908c4 mwifiex: uninit wakeup info when removing device Signed-off-by: Jeffy Chen --- drivers/net/wireless/marvell/mwifiex/main.c | 2 ++ 1 file ch

Re: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA

2017-07-03 Thread Arnd Bergmann
On Sun, Jul 2, 2017 at 10:45 AM, Saeed Mahameed wrote: > On Fri, Jun 30, 2017 at 10:25 PM, Arnd Bergmann wrote: >> On Fri, Jun 30, 2017 at 8:58 PM, Ilan Tayari wrote: >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile b/drivers/net/ethernet/mellanox/mlx5/core/Makefile >>>