Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-06-27 Thread Jakub Kicinski
On Tue, 27 Jun 2017 23:27:34 -0700, Dustin Byford wrote: > On Tue Jun 27 03:22, Jakub Kicinski wrote: > > On Sat, 24 Jun 2017 12:19:43 -0700, Roopa Prabhu wrote: > > > Encoding: Types of encoding > > > Off: Turning off any encoding > > > RS : enforcing RS-FEC encoding on supported speed

Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-06-27 Thread Dustin Byford
Hi Jakub, On Tue Jun 27 03:22, Jakub Kicinski wrote: > On Sat, 24 Jun 2017 12:19:43 -0700, Roopa Prabhu wrote: > > Encoding: Types of encoding > > Off: Turning off any encoding > > RS : enforcing RS-FEC encoding on supported speeds > > BaseR : enforcing Base R encoding on supported spe

Re: [PATCH/RFC net-next 8/9] nfp: add a stats handler for flower offloads

2017-06-27 Thread Jakub Kicinski
On Wed, 28 Jun 2017 01:21:48 +0200, Simon Horman wrote: > From: Pieter Jansen van Vuuren > > Previously there was no way of updating flow rule stats after they > have been offloaded to hardware. This is solved by keeping track of > stats received from hardware and providing this to the TC handler

Re: [PATCH/RFC net-next 7/9] nfp: add metadata to each flow offload

2017-06-27 Thread Jakub Kicinski
On Wed, 28 Jun 2017 01:21:47 +0200, Simon Horman wrote: > From: Pieter Jansen van Vuuren > > Adds metadata describing the mask id of each flow and keeps track of > flows installed in hardware. Previously a flow could not be removed > from hardware as there was no way of knowing if that a specific

Re: [PATCH/RFC net-next 4/9] nfp: extend flower add flow offload

2017-06-27 Thread Jakub Kicinski
On Wed, 28 Jun 2017 01:21:44 +0200, Simon Horman wrote: > diff --git a/drivers/net/ethernet/netronome/nfp/flower/offload.c > b/drivers/net/ethernet/netronome/nfp/flower/offload.c > index 9127c28ea9c3..8ad72f57493d 100644 > --- a/drivers/net/ethernet/netronome/nfp/flower/offload.c > +++ b/drivers/n

Re: [PATCH/RFC net-next 3/9] nfp: provide infrastructure for offloading flower based TC filters

2017-06-27 Thread Jakub Kicinski
On Wed, 28 Jun 2017 01:21:43 +0200, Simon Horman wrote: > From: Pieter Jansen van Vuuren > > Adds a flower based TC offload handler for representor devices, this > is in addition to the bpf based offload handler. The changes in this > patch will be used in a follow-up patch to add tc flower offlo

[PATCH net-next 2/2] bpf: Add test for syscall on fd array/htab lookup

2017-06-27 Thread Martin KaFai Lau
Checks are added to the existing sockex3 and test_map_in_map test. Signed-off-by: Martin KaFai Lau Acked-by: Daniel Borkmann --- samples/bpf/sockex3_user.c | 15 ++- samples/bpf/test_map_in_map_user.c | 17 + 2 files changed, 31 insertions(+), 1 deletion(-)

[PATCH net-next 1/2] bpf: Add syscall lookup support for fd array and htab

2017-06-27 Thread Martin KaFai Lau
This patch allows userspace to do BPF_MAP_LOOKUP_ELEM on BPF_MAP_TYPE_PROG_ARRAY, BPF_MAP_TYPE_ARRAY_OF_MAPS and BPF_MAP_TYPE_HASH_OF_MAPS. The lookup returns a prog-id or map-id to the userspace. The userspace can then use the BPF_PROG_GET_FD_BY_ID or BPF_MAP_GET_FD_BY_ID to get a fd. Signed-off

[PATCH net-next 0/2] bpf: Add syscall lookup support for fd array and htab

2017-06-27 Thread Martin KaFai Lau
This patchset adds BPF_MAP_LOOKUP_ELEM syscall support for BPF_MAP_TYPE_PROG_ARRAY, BPF_MAP_TYPE_ARRAY_OF_MAPS and BPF_MAP_TYPE_HASH_OF_MAPS Martin KaFai Lau (2): bpf: Add syscall lookup support for fd array and htab bpf: Add test for syscall on fd array/htab lookup include/linux/bpf.h

[PATCH net] mlxsw: spectrum_router: Fix NULL pointer dereference

2017-06-27 Thread Ido Schimmel
In case a VLAN device is enslaved to a bridge we shouldn't create a router interface (RIF) for it when it's configured with an IP address. This is already handled by the driver for other types of netdevs, such as physical ports and LAG devices. If this IP address is then removed and the interface

Re: [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes

2017-06-27 Thread Dustin Byford
Hi Gal, On Sun Jun 25 16:38, Gal Pressman wrote: > > > ... > > > > SHOW FEC option: > > root@tor: ethtool --show-fec swp1 > > FEC parameters for swp1: > > Active FEC encodings: RS > > Configured FEC encodings: RS | BaseR > > > > ETHTOOL DEVNAME output modification: > > > > ethtool devname outpu

Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-27 Thread Daniel Vetter
On Tue, Jun 27, 2017 at 10:51 PM, Jeff Kirsher wrote: > This was submitted and accepted into David Miller's net-next tree. I can > see if Dave can pull it into his net tree. DOes stable need to pick this > up as well? Nah if it landed somewhere at least I'm happy, we can carry the fixup for a w

Re: [PATCH net v2] net: sched: Fix one possible panic when no destroy callback

2017-06-27 Thread Eric Dumazet
On Wed, 2017-06-28 at 12:53 +0800, gfree.w...@vip.163.com wrote: > From: Gao Feng > > When qdisc fail to init, qdisc_create would invoke the destroy callback > to cleanup. But there is no check if the callback exists really. So it > would cause the panic if there is no real destroy callback like

[PATCH net v2] net: sched: Fix one possible panic when no destroy callback

2017-06-27 Thread gfree . wind
From: Gao Feng When qdisc fail to init, qdisc_create would invoke the destroy callback to cleanup. But there is no check if the callback exists really. So it would cause the panic if there is no real destroy callback like the qdisc codel, fq, and so on. Take codel as an example following: When a

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-27 Thread Leon Romanovsky
On Tue, Jun 27, 2017 at 03:18:59PM -0700, Stephen Hemminger wrote: > On Tue, 27 Jun 2017 20:46:15 +0300 > Leon Romanovsky wrote: > > > On Tue, Jun 27, 2017 at 11:37:35AM -0600, Jason Gunthorpe wrote: > > > On Tue, Jun 27, 2017 at 08:33:01PM +0300, Leon Romanovsky wrote: > > > > > > > My initial pl

Re: [PATCH iproute2 V1 3/6] rdma: Add device capability parsing

2017-06-27 Thread Leon Romanovsky
On Tue, Jun 27, 2017 at 04:04:49PM -0700, Stephen Hemminger wrote: > On Tue, 27 Jun 2017 17:39:17 +0300 > Leon Romanovsky wrote: > > > +static const char *dev_caps[64] = { > > + "RESIZE_MAX_WR", > > + "BAD_PKEY_CNTR", > > + "BAD_QKEY_CNTR", > > + "RAW_MULTI", > > + "AUTO_PATH_MIG", > > +

[no subject]

2017-06-27 Thread системы администратор
внимания; Ваши сообщения превысил лимит памяти, который составляет 5 Гб, определенных администратором, который в настоящее время работает на 10.9GB, Вы не сможете отправить или получить новую почту, пока вы повторно не проверить ваш почтовый ящик почты. Чтобы восстановить работоспособность Ваше

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 11:40:30AM +0800, Jason Wang wrote: > > > On 2017年06月28日 11:31, Michael S. Tsirkin wrote: > > On Wed, Jun 28, 2017 at 10:45:18AM +0800, Jason Wang wrote: > > > On 2017年06月28日 10:17, Michael S. Tsirkin wrote: > > > > On Wed, Jun 28, 2017 at 10:14:34AM +0800, Jason Wang wrot

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Jason Wang
On 2017年06月28日 11:31, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 10:45:18AM +0800, Jason Wang wrote: On 2017年06月28日 10:17, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 10:14:34AM +0800, Jason Wang wrote: On 2017年06月28日 10:02, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 09:

Re: Re: [net PATCH] net: sched: Fix one possible panic when no destroy callback

2017-06-27 Thread Cong Wang
On Tue, Jun 27, 2017 at 5:54 PM, Gao Feng wrote: > At 2017-06-28 01:49:50, "Eric Dumazet" wrote: >>On Tue, 2017-06-27 at 10:08 -0700, Cong Wang wrote: >>> On Tue, Jun 27, 2017 at 9:50 AM, Eric Dumazet >>> wrote: >>> > On Tue, 2017-06-27 at 09:30 -0700, Cong Wang wrote: >>> >> On Mon, Jun 26, 20

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 10:45:18AM +0800, Jason Wang wrote: > > > On 2017年06月28日 10:17, Michael S. Tsirkin wrote: > > On Wed, Jun 28, 2017 at 10:14:34AM +0800, Jason Wang wrote: > > > > > > On 2017年06月28日 10:02, Michael S. Tsirkin wrote: > > > > On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wa

Re: [net] virtio-net: serialize tx routine during reset

2017-06-27 Thread McCabe, Robert J
Acked-by: Robert McCabe

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Jason Wang
On 2017年06月28日 10:17, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 10:14:34AM +0800, Jason Wang wrote: On 2017年06月28日 10:02, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wang wrote: We should allow csumed packet for small buffer, otherwise XDP_PASS won't wo

[PATCH v2] datapath: Avoid using stack larger than 1024.

2017-06-27 Thread Tonghao Zhang
When compiling OvS-master on 4.4.0-81 kernel, there is a warning: CC [M] /root/ovs/datapath/linux/datapath.o /root/ovs/datapath/linux/datapath.c: In function ‘ovs_flow_cmd_set’: /root/ovs/datapath/linux/datapath.c:1221:1: warning: the frame size of 1040 bytes is larger than 10

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 10:14:34AM +0800, Jason Wang wrote: > > > On 2017年06月28日 10:02, Michael S. Tsirkin wrote: > > On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wang wrote: > > > We should allow csumed packet for small buffer, otherwise XDP_PASS > > > won't work correctly. > > > > > > Fixes

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Jason Wang
On 2017年06月28日 10:02, Michael S. Tsirkin wrote: On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wang wrote: We should allow csumed packet for small buffer, otherwise XDP_PASS won't work correctly. Fixes commit bb91accf2733 ("virtio-net: XDP support for small buffers") Signed-off-by: Jason Wan

Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wang wrote: > We should allow csumed packet for small buffer, otherwise XDP_PASS > won't work correctly. > > Fixes commit bb91accf2733 ("virtio-net: XDP support for small buffers") > Signed-off-by: Jason Wang The issue would be VIRTIO_NET_HDR_F_DAT

Re: [PATCH net] virtio-net: serialize tx routine during reset

2017-06-27 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 09:51:03AM +0800, Jason Wang wrote: > We don't hold any tx lock when trying to disable TX during reset, this > would lead a use after free since ndo_start_xmit() tries to access > the virtqueue which has already been freed. Fix this by using > netif_tx_disable() before freei

[PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP

2017-06-27 Thread Jason Wang
We should allow csumed packet for small buffer, otherwise XDP_PASS won't work correctly. Fixes commit bb91accf2733 ("virtio-net: XDP support for small buffers") Signed-off-by: Jason Wang --- The patch is needed for -stable. --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH net] virtio-net: serialize tx routine during reset

2017-06-27 Thread Jason Wang
We don't hold any tx lock when trying to disable TX during reset, this would lead a use after free since ndo_start_xmit() tries to access the virtqueue which has already been freed. Fix this by using netif_tx_disable() before freeing the vqs, this could make sure no tx after vq freeing. Reported-b

Re: [PATCH NET V5 2/2] net: hns: Use phy_driver to setup Phy loopback

2017-06-27 Thread Yunsheng Lin
Hi, Andrew On 2017/6/27 21:29, Andrew Lunn wrote: - phy_write(phy_dev, COPPER_CONTROL_REG, val); + err = phy_resume(phy_dev); >>> >>> Maybe this was discussed with an earlier version of these patches. Why >>> are using phy_resume() and phy_suspend()? >> When self_test i

Re:Re: [net PATCH] net: sched: Fix one possible panic when no destroy callback

2017-06-27 Thread Gao Feng
At 2017-06-28 01:49:50, "Eric Dumazet" wrote: >On Tue, 2017-06-27 at 10:08 -0700, Cong Wang wrote: >> On Tue, Jun 27, 2017 at 9:50 AM, Eric Dumazet wrote: >> > On Tue, 2017-06-27 at 09:30 -0700, Cong Wang wrote: >> >> On Mon, Jun 26, 2017 at 6:35 PM, wrote: >> >> > From: Gao Feng >> >> > >> >>

Re: [PATCH NET V6 1/2] net: phy: Add phy loopback support in net phy framework

2017-06-27 Thread Yunsheng Lin
Hi, Madalin On 2017/6/27 19:48, Madalin-cristian Bucur wrote: >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Lin Yun Sheng >> Sent: Tuesday, June 27, 2017 2:01 PM >> To: da...@davemloft.net; and...@lunn.ch; f.faine...@gmail

Re: [PATCH/RFC net-next 2/9] nfp: add phys_switch_id support

2017-06-27 Thread Jakub Kicinski
On Wed, 28 Jun 2017 01:21:42 +0200, Simon Horman wrote: > Add phys_switch_id support by allowing lookup of > SWITCHDEV_ATTR_ID_PORT_PARENT_ID via the nfp_repr_port_attr_get > switchdev operation. > > This is visible to user-space in the phys_switch_id attribute > of a netdev. > > e.g. > cd /sys/d

[PATCH/RFC net-next 7/9] nfp: add metadata to each flow offload

2017-06-27 Thread Simon Horman
From: Pieter Jansen van Vuuren Adds metadata describing the mask id of each flow and keeps track of flows installed in hardware. Previously a flow could not be removed from hardware as there was no way of knowing if that a specific flow was installed. This is solved by storing the offloaded flows

[PATCH/RFC net-next 8/9] nfp: add a stats handler for flower offloads

2017-06-27 Thread Simon Horman
From: Pieter Jansen van Vuuren Previously there was no way of updating flow rule stats after they have been offloaded to hardware. This is solved by keeping track of stats received from hardware and providing this to the TC handler on request. Signed-off-by: Pieter Jansen van Vuuren Signed-off-

[PATCH/RFC net-next 9/9] nfp: add control message passing capabilities to flower offloads

2017-06-27 Thread Simon Horman
From: Pieter Jansen van Vuuren Previously the flower offloads never sends messages to the hardware, and never registers a handler for receiving messages from hardware. This patch enables the flower offloads to send control messages to hardware when adding and removing flow rules. Additionally it

[PATCH/RFC net-next 4/9] nfp: extend flower add flow offload

2017-06-27 Thread Simon Horman
From: Pieter Jansen van Vuuren Extends the flower flow add function by calculating which match fields are present in the flower offload structure and allocating the appropriate space to describe these. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Simon Horman --- drivers/net/etherne

[PATCH/RFC net-next 2/9] nfp: add phys_switch_id support

2017-06-27 Thread Simon Horman
Add phys_switch_id support by allowing lookup of SWITCHDEV_ATTR_ID_PORT_PARENT_ID via the nfp_repr_port_attr_get switchdev operation. This is visible to user-space in the phys_switch_id attribute of a netdev. e.g. cd /sys/devices/pci:00/:00:01.0/:01:00.0 find . -name phys_switch_id |

[PATCH/RFC net-next 5/9] nfp: extend flower matching capabilities

2017-06-27 Thread Simon Horman
From: Pieter Jansen van Vuuren Extends matching capabilities for flower offloads to include vlan, layer 2, layer 3 and layer 4 type matches. This includes both exact and wildcard matching. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/n

[PATCH/RFC net-next 1/9] net: switchdev: add SET_SWITCHDEV_OPS helper

2017-06-27 Thread Simon Horman
Add a helper to allow switchdev ops to be set if NET_SWITCHDEV is configured and do nothing otherwise. This allows for slightly cleaner code which uses switchdev but does not select NET_SWITCHDEV. Signed-off-by: Simon Horman --- include/net/switchdev.h | 4 1 file changed, 4 insertions(+)

[PATCH/RFC net-next 3/9] nfp: provide infrastructure for offloading flower based TC filters

2017-06-27 Thread Simon Horman
From: Pieter Jansen van Vuuren Adds a flower based TC offload handler for representor devices, this is in addition to the bpf based offload handler. The changes in this patch will be used in a follow-up patch to add tc flower offload to the NFP. The flower app enables tc offloads on representors

[PATCH/RFC net-next 6/9] nfp: add basic action capabilities to flower offloads

2017-06-27 Thread Simon Horman
From: Pieter Jansen van Vuuren Adds push vlan, pop vlan, output and drop action capabilities to flower offloads. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/Makefile| 1 + drivers/net/ethernet/netronome/nfp/flower/action

[PATCH/RFC net-next 0/9] introduce flower offload capabilities

2017-06-27 Thread Simon Horman
Hi, this series adds flower offload to the NFP driver. It builds on recent work to add representor and a skeleton flower app - now the app does what its name says. In general the approach taken is to allow some flows within the universe of possible flower matches and tc actions to be offloaded. I

Re: [PATCH iproute2 0/3] ip-link: XDP flags and offload mode

2017-06-27 Thread Stephen Hemminger
On Mon, 26 Jun 2017 17:23:50 -0700 Jakub Kicinski wrote: > Hi! > > This series adds support for specifying DRV_MODE and new HW_MODE > flags when binding an XDP program to the driver. It also teaches > ip link about "xdpoffload" attachment mode. > > Examples: > # ip link set dev p4p1 xdpoffload

Re: [PATCH iproute2 net-next] bpf: Add support for IFLA_XDP_PROG_ID

2017-06-27 Thread Stephen Hemminger
On Wed, 21 Jun 2017 14:29:42 -0700 Martin KaFai Lau wrote: > This patch adds support to the newly added IFLA_XDP_PROG_ID. > > ./ip link show dev eth0 > 3: eth0: mtu 1500 xdpgeneric/id:2 qdisc > [...] > > Signed-off-by: Martin KaFai Lau Applied to net-next

Re: [PATCH iproute2] bpf: indicate lderr when bpf_apply_relo_data fails

2017-06-27 Thread Daniel Borkmann
On 06/28/2017 01:09 AM, Stephen Hemminger wrote: On Tue, 27 Jun 2017 02:48:36 +0200 Daniel Borkmann wrote: When LLVM wrongly generates a rodata relo entry (llvm BZ #33599), then just bail out instead of probing for prog w/o reloc, which will fail in this case anyway. Signed-off-by: Daniel Bor

Re: [PATCH iproute2] bpf: indicate lderr when bpf_apply_relo_data fails

2017-06-27 Thread Stephen Hemminger
On Tue, 27 Jun 2017 02:48:36 +0200 Daniel Borkmann wrote: > When LLVM wrongly generates a rodata relo entry (llvm BZ #33599), > then just bail out instead of probing for prog w/o reloc, which > will fail in this case anyway. > > Signed-off-by: Daniel Borkmann Applied, but don't you want a reas

Re: [PATCH] man: ip-route.8: Mention that lower metric means higher priority

2017-06-27 Thread Stephen Hemminger
On Wed, 21 Jun 2017 21:59:45 +0200 Lukas Braun wrote: > This is quite counter-intuitive when using the 'preference' keyword. > > Signed-off-by: Lukas Braun I think it goes back to some wording in RFC. But your addition makes sense. Applied.

Re: [iproute PATCH] man: Collect names of man pages automatically

2017-06-27 Thread Stephen Hemminger
On Tue, 27 Jun 2017 21:00:25 +0200 Phil Sutter wrote: > As it turned out, forgetting to add a man page to the respective > Makefile when introducing it is a common mistake. Overcome this once and > for all by using $(wildcard) function in Makefiles. > > Fixes: 7124942942e53 ("genl: add manpage")

Re: [PATCH iproute2 V1 3/6] rdma: Add device capability parsing

2017-06-27 Thread Stephen Hemminger
On Tue, 27 Jun 2017 17:39:17 +0300 Leon Romanovsky wrote: > +static const char *dev_caps[64] = { > + "RESIZE_MAX_WR", > + "BAD_PKEY_CNTR", > + "BAD_QKEY_CNTR", > + "RAW_MULTI", > + "AUTO_PATH_MIG", > + "CHANGE_PHY_PORT", > + "UD_AV_PORT_ENFORCE", > + "CURR_QP_STATE

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-27 Thread Stephen Hemminger
On Tue, 27 Jun 2017 20:46:15 +0300 Leon Romanovsky wrote: > On Tue, Jun 27, 2017 at 11:37:35AM -0600, Jason Gunthorpe wrote: > > On Tue, Jun 27, 2017 at 08:33:01PM +0300, Leon Romanovsky wrote: > > > > > My initial plan was to put all parsers under their respective names, in > > > the similar w

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-27 Thread Stephen Hemminger
On Tue, 27 Jun 2017 20:33:01 +0300 Leon Romanovsky wrote: > On Tue, Jun 27, 2017 at 10:41:50AM -0600, Jason Gunthorpe wrote: > > On Tue, Jun 27, 2017 at 12:21:29PM +0300, Leon Romanovsky wrote: > > > > What will be the output of such command? > > > > $ rdma dev show mlx5_4 > > > > > > ip-lik

RE: [net-next v2 6/6] ixgbe: Add malicious driver detection support

2017-06-27 Thread Tantilov, Emil S
>-Original Message- >From: Or Gerlitz [mailto:gerlitz...@gmail.com] >Sent: Tuesday, June 27, 2017 2:07 PM >To: Tantilov, Emil S >Cc: Kirsher, Jeffrey T ; David Miller >; Greenwalt, Paul ; Linux >Netdev List ; nhor...@redhat.com; >sassm...@redhat.com; jogre...@redhat.com >Subject: Re: [net-

[PATCH] net: stmmac: Add additional registers for dwmac1000_dma ethtool

2017-06-27 Thread thor . thayer
From: Thor Thayer Version 3.70a of the Designware has additional DMA registers so add those to the ethtool DMA Register dump. Offset 9 - Receive Interrupt Watchdog Timer Register Offset 10 - AXI Bus Mode Register Offset 11 - AHB or AXI Status Register Offset 22 - HW Feature Register Signed-off-

[PATCH 2/2] ethtool: stmmac: Add DMA HW Feature Register

2017-06-27 Thread thor . thayer
From: Thor Thayer This patch adds the DMA HW Feature Register which is at the end of the DMA registers and is documented in Version 3.70a. Signed-off-by: Thor Thayer --- stmmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stmmac.c b/stmmac.c index e1bb291..7d7bebd 1006

[PATCH 1/2] ethtool: stmmac: Fix Designware ethtool register dump

2017-06-27 Thread thor . thayer
From: Thor Thayer The commit fbf68229ffe7 ("net: stmmac: unify registers dumps methods") modified the register dump to store the DMA registers at the DMA register offset (0x1000) but ethtool (stmmac.c) looks for the DMA registers after the MAC registers which is offset 12. This patch adds the DM

[PATCH 0/2] ethtool: stmmac: Fix DMA register dump

2017-06-27 Thread thor . thayer
From: Thor Thayer The DMA register dump structure changed which requires this change to the indexing of the DMA registers. Also dump the DMA HW Feature Register. Thor Thayer (2): ethtool: stmmac: Fix Designware ethtool register dump ethtool: stmmac: Add DMA HW Feature Register stmmac.c | 7

Re: [PATCH] datapath: Avoid using stack larger than 1024.

2017-06-27 Thread Pravin Shelar
On Tue, Jun 27, 2017 at 2:20 AM, Tonghao Zhang wrote: > When compiling OvS-master on 4.4.0-81 kernel, > there is a warning: > > CC [M] /root/ovs/datapath/linux/datapath.o > /root/ovs/datapath/linux/datapath.c: In function > ‘ovs_flow_cmd_set’: > /root/ovs/datapath/linux/datapath.c

Re: [net-next v2 6/6] ixgbe: Add malicious driver detection support

2017-06-27 Thread Or Gerlitz
On Tue, Jun 27, 2017 at 11:59 PM, Tantilov, Emil S wrote: >>-Original Message- >>From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On >>Behalf Of Or Gerlitz >>Sent: Tuesday, June 27, 2017 2:08 AM >>To: Kirsher, Jeffrey T >>Cc: David Miller ; Greenwalt, Paul >>; Linu

RE: [net-next v2 6/6] ixgbe: Add malicious driver detection support

2017-06-27 Thread Tantilov, Emil S
>-Original Message- >From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On >Behalf Of Or Gerlitz >Sent: Tuesday, June 27, 2017 2:08 AM >To: Kirsher, Jeffrey T >Cc: David Miller ; Greenwalt, Paul >; Linux Netdev List ; >nhor...@redhat.com; sassm...@redhat.com; jogre...

Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-27 Thread Jeff Kirsher
On Wed, 2017-06-28 at 05:28 +1000, Dave Airlie wrote: > On 20 June 2017 at 18:49, Daniel Vetter wrote: > > On Wed, Jun 07, 2017 at 01:07:33AM +, Brown, Aaron F wrote: > > > > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] > > > > On Behalf > > > > Of Jeff Kirsher > > > > Sen

[PATCH net-next 1/2] vxlan: change vxlan_validate() to use netlink_ext_ack for error reporting

2017-06-27 Thread Matthias Schiffer
The kernel log is not where users expect error messages for netlink requests; as we have extended acks now, we can replace pr_debug() with NL_SET_ERR_MSG_ATTR(). While we're at it, also fix the !is_valid_ether_addr() error message (as it not only rejects the all-zero address, but also multicast ad

[PATCH net-next 2/2] vxlan: add back error messages to vxlan_config_validate() as extended netlink acks

2017-06-27 Thread Matthias Schiffer
When refactoring the vxlan config validation, some kernel log messages were removed. This brings them back using the new netlink_ext_ack support, and adds some more in the recently added code handling link-local IPv6 addresses. Signed-off-by: Matthias Schiffer --- drivers/net/vxlan.c | 43 ++

Re: RFC: sk leak in sock_graft?

2017-06-27 Thread Sowmini Varadhan
On (06/27/17 15:59), Sowmini Varadhan wrote: > > Why does rds-tcp need to call sock_graft() without those invariants > > met? > > It would certainly help to declare "dont use sock_creeate_kern() > if you are going to accept on this socket"- I dont see that being > mandated anywhere. I can look i

Re: [PATCH v3 07/11] tty: improve tty_insert_flip_char() fast path

2017-06-27 Thread Arnd Bergmann
On Mon, Jun 26, 2017 at 3:58 PM, Arnd Bergmann wrote: > * With asan-stack=1, gcc uses at least 64 bytes per such variable > (two times ASAN_RED_ZONE_SIZE), while clang only uses 16 bytes > (2 * (1< use any more space than with kasan completely disabled > (no -fsanitize=kernel-address). I

Re: RFC: sk leak in sock_graft?

2017-06-27 Thread Sowmini Varadhan
On (06/27/17 15:38), David Miller wrote: > > It could simply be the case that rds-tcp is the first setup that > created that situation where there is a parent->sk already. Possibly, I noticed that other callers call sock_create_lite() and I dont know the history here - this seems to have been the

Re: [PATCH net-next 00/14] nfp: get_phys_port_name for representors and SR-IOV reorder

2017-06-27 Thread David Miller
From: Jakub Kicinski Date: Tue, 27 Jun 2017 00:50:14 -0700 > This series starts by making the error message if FW cannot be located > easier to understand. Then I move some functions from PCI probe files > into library code (nfpcore) where they belong, and remove one function > which is never us

Re: [PATCH] net: usb: asix88179_178a: Add support for the Belkin B2B128

2017-06-27 Thread David Miller
From: "Andrew F. Davis" Date: Mon, 26 Jun 2017 12:41:20 -0500 > The Belkin B2B128 is a USB 3.0 Hub + Gigabit Ethernet Adapter, the > Ethernet adapter uses the ASIX AX88179 USB 3.0 to Gigabit Ethernet > chip supported by this driver, add the USB ID for the same. > > This patch is based on work by

Re: [PATCH net-next 0/2] ipv6: udp: exploit dev_scratch helpers

2017-06-27 Thread David Miller
From: Paolo Abeni Date: Mon, 26 Jun 2017 19:01:49 +0200 > When bringing in the recent cache optimization for the UDP protocol, I forgot > to leverage the newly introduced scratched area helpers in the UDPv6 code > path. > As a result, the UDPv6 implementation suffers some unnecessary performance

Re: [PATCH v2] fsl/fman: add dependency on HAS_DMA

2017-06-27 Thread David Miller
From: Madalin Bucur Date: Mon, 26 Jun 2017 18:47:00 +0300 > A previous commit (5567e989198b5a8d) inserted a dependency on DMA > API that requires HAS_DMA to be added in Kconfig. > > Signed-off-by: Madalin Bucur Applied, thank you.

Re: [RFC PATCH net-next 1/3] ethtool: Add link down reason callback

2017-06-27 Thread David Miller
From: Andrew Lunn Date: Mon, 26 Jun 2017 15:34:39 +0200 > I still fear this is going to be an ethtool call with only one user. That is my fear as well. We are also in a sort-of moratorium for adding new major ethtool features until the conversion of ethtool over to netlink occurs.

Re: [PATCH net-next] tcp: fix null ptr deref in getsockopt(..., TCP_ULP, ...)

2017-06-27 Thread David Miller
From: Dave Watson Date: Mon, 26 Jun 2017 08:36:47 -0700 > If icsk_ulp_ops is unset, it dereferences a null ptr. > Add a null ptr check. > > BUG: KASAN: null-ptr-deref in copy_to_user include/linux/uaccess.h:168 > [inline] > BUG: KASAN: null-ptr-deref in do_tcp_getsockopt.isra.33+0x24f/0x1e30 >

Re: RFC: sk leak in sock_graft?

2017-06-27 Thread David Miller
From: Sowmini Varadhan Date: Sat, 24 Jun 2017 09:08:27 -0400 > We're seeing a memleak when we run an infinite loop that > loads/unloads rds-tcp, and runs some traffic between each > load/unload. > > Analysis shows that this is happening for the following reason: > > inet_accept -> sock_graft

Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-27 Thread Dave Airlie
On 20 June 2017 at 18:49, Daniel Vetter wrote: > On Wed, Jun 07, 2017 at 01:07:33AM +, Brown, Aaron F wrote: >> > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf >> > Of Jeff Kirsher >> > Sent: Tuesday, June 6, 2017 1:46 PM >> > To: David Miller ; Nikula, Jani >> >

[iproute PATCH] man: Collect names of man pages automatically

2017-06-27 Thread Phil Sutter
As it turned out, forgetting to add a man page to the respective Makefile when introducing it is a common mistake. Overcome this once and for all by using $(wildcard) function in Makefiles. Fixes: 7124942942e53 ("genl: add manpage") Fixes: 958cd210942c8 ("ifcfg: add manpage") Fixes: e1b7f883e50de

Re: [PATCH net] net: prevent sign extension in dev_get_stats()

2017-06-27 Thread David Miller
From: Eric Dumazet Date: Tue, 27 Jun 2017 07:02:20 -0700 > From: Eric Dumazet > > Similar to the fix provided by Dominik Heidler in commit > 9b3dc0a17d73 ("l2tp: cast l2tp traffic counter to unsigned") > we need to take care of 32bit kernels in dev_get_stats(). > > When using atomic_long_read(

Re: [net-next] net: remove policy-routing.txt documentation

2017-06-27 Thread David Miller
From: Vincent Bernat Date: Tue, 27 Jun 2017 15:42:57 +0200 > It dates back from 2.1.16 and is obsolete since 2.1.68 when the current > rule system has been introduced. > > Signed-off-by: Vincent Bernat Applied. I am very surprised that document was still there :)

Re: [PATCH net-next] vxlan: fix incorrect nlattr access in MTU check

2017-06-27 Thread David Miller
From: Matthias Schiffer Date: Tue, 27 Jun 2017 14:42:43 +0200 > The access to the wrong variable could lead to a NULL dereference and > possibly other invalid memory reads in vxlan newlink/changelink requests > with a IFLA_MTU attribute. > > Fixes: a985343ba906 "vxlan: refactor verification and

Re: [PATCH 1/1] tc: custom qdisc pkt size translation table

2017-06-27 Thread Eric Dumazet
On Tue, 2017-06-27 at 12:37 -0500, Robert McCabe wrote: > Yeah, sorry didn't even think about that. > I guess my first question would be is there another way via the > iproute2 project where a user could > configure the stab->data pkt size translation table used in the > __qdisc_calculate_pkt_len m

Re: [PATCH 1/1] tc: custom qdisc pkt size translation table

2017-06-27 Thread Robert McCabe
Yeah, sorry didn't even think about that. I guess my first question would be is there another way via the iproute2 project where a user could configure the stab->data pkt size translation table used in the __qdisc_calculate_pkt_len method in the kernel source (net/sched/sched_api.c)? Also, let's s

Re: [net PATCH] net: sched: Fix one possible panic when no destroy callback

2017-06-27 Thread Eric Dumazet
On Tue, 2017-06-27 at 10:08 -0700, Cong Wang wrote: > On Tue, Jun 27, 2017 at 9:50 AM, Eric Dumazet wrote: > > On Tue, 2017-06-27 at 09:30 -0700, Cong Wang wrote: > >> On Mon, Jun 26, 2017 at 6:35 PM, wrote: > >> > From: Gao Feng > >> > > >> > When qdisc fail to init, qdisc_create would invoke

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-27 Thread Leon Romanovsky
On Tue, Jun 27, 2017 at 11:37:35AM -0600, Jason Gunthorpe wrote: > On Tue, Jun 27, 2017 at 08:33:01PM +0300, Leon Romanovsky wrote: > > > My initial plan was to put all parsers under their respective names, in > > the similar way as I did for caps: $ rdma dev show mlx5_4 caps > > I think you should

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Corentin Labbe
On Tue, Jun 27, 2017 at 07:29:37PM +0200, Maxime Ripard wrote: > On Tue, Jun 27, 2017 at 02:37:48PM +0200, Corentin Labbe wrote: > > On Tue, Jun 27, 2017 at 11:33:56AM +0100, Andre Przywara wrote: > > > Hi, > > > > > > On 27/06/17 11:23, Icenowy Zheng wrote: > > > > > > > > > > > > 于 2017年6月27日

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Florian Fainelli
On 06/27/2017 10:29 AM, Maxime Ripard wrote: > On Tue, Jun 27, 2017 at 02:37:48PM +0200, Corentin Labbe wrote: >> On Tue, Jun 27, 2017 at 11:33:56AM +0100, Andre Przywara wrote: >>> Hi, >>> >>> On 27/06/17 11:23, Icenowy Zheng wrote: 于 2017年6月27日 GMT+08:00 下午6:15:58, Andre Przywara

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-27 Thread Jason Gunthorpe
On Tue, Jun 27, 2017 at 08:33:01PM +0300, Leon Romanovsky wrote: > My initial plan was to put all parsers under their respective names, in > the similar way as I did for caps: $ rdma dev show mlx5_4 caps I think you should have a useful summary display similar to 'ip a' and other commands. guid(

Re: [RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session

2017-06-27 Thread Marcel Holtmann
Hi Jeffy, > It looks like bnep_session has same pattern as the issue reported in > old rfcomm: > > while (1) { > set_current_state(TASK_INTERRUPTIBLE); > if (condition) > break; > // may call might_sleep here > sc

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-27 Thread Leon Romanovsky
On Tue, Jun 27, 2017 at 10:41:50AM -0600, Jason Gunthorpe wrote: > On Tue, Jun 27, 2017 at 12:21:29PM +0300, Leon Romanovsky wrote: > > > What will be the output of such command? > > > $ rdma dev show mlx5_4 > > > > ip-like style: > > > > $ rdma dev show mlx5_4 > > 5: mlx5_4: > > caps: > PORT

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Maxime Ripard
On Tue, Jun 27, 2017 at 02:37:48PM +0200, Corentin Labbe wrote: > On Tue, Jun 27, 2017 at 11:33:56AM +0100, Andre Przywara wrote: > > Hi, > > > > On 27/06/17 11:23, Icenowy Zheng wrote: > > > > > > > > > 于 2017年6月27日 GMT+08:00 下午6:15:58, Andre Przywara > > > 写到: > > >> Hi, > > >> > > >> On 27/

Re: ARM GLX Khadas VIM Pro - Ethernet detected as only 10Mbps and stalled after some traffic

2017-06-27 Thread crow
Hi, There are other user reporting same issue while using mainline kernel but using Ubuntu, so this is for sure not Distribution related. For me see the [0]. I hope someone would get time after 4.12 release to try fix this issue. Regards, [0] http://forum.khadas.com/t/ubuntu-server-rom-linux-mai

Re: [net PATCH] net: sched: Fix one possible panic when no destroy callback

2017-06-27 Thread Cong Wang
On Tue, Jun 27, 2017 at 9:50 AM, Eric Dumazet wrote: > On Tue, 2017-06-27 at 09:30 -0700, Cong Wang wrote: >> On Mon, Jun 26, 2017 at 6:35 PM, wrote: >> > From: Gao Feng >> > >> > When qdisc fail to init, qdisc_create would invoke the destroy callback >> > to cleanup. But there is no check if t

Re: [PATCH v2] netfilter: nfnetlink: Improve input length sanitization in nfnetlink_rcv

2017-06-27 Thread Pablo Neira Ayuso
On Tue, Jun 27, 2017 at 05:58:25PM +0200, Pablo Neira Ayuso wrote: > On Wed, Jun 07, 2017 at 03:50:38PM +0200, Mateusz Jurczyk wrote: > > Verify that the length of the socket buffer is sufficient to cover the > > nlmsghdr structure before accessing the nlh->nlmsg_len field for further > > input san

Re: [PATCH 1/1] tc: custom qdisc pkt size translation table

2017-06-27 Thread Eric Dumazet
On Tue, 2017-06-27 at 11:29 -0500, McCabe, Robert J wrote: > Added the "custom" linklayer qdisc stab option. > This allows the user to specify the pkt size translation > parameters from stdin. > Example: >tc qdisc add ... stab tsize 8 linklayer custom htb >Custom size table: >InputSizeS

Re: [net PATCH] net: sched: Fix one possible panic when no destroy callback

2017-06-27 Thread Eric Dumazet
On Tue, 2017-06-27 at 09:30 -0700, Cong Wang wrote: > On Mon, Jun 26, 2017 at 6:35 PM, wrote: > > From: Gao Feng > > > > When qdisc fail to init, qdisc_create would invoke the destroy callback > > to cleanup. But there is no check if the callback exists really. So it > > would cause the panic if

Re: [PATCH iproute2 3/5] rdma: Add device capability parsing

2017-06-27 Thread Jason Gunthorpe
On Tue, Jun 27, 2017 at 12:21:29PM +0300, Leon Romanovsky wrote: > > What will be the output of such command? > > $ rdma dev show mlx5_4 > > ip-like style: > > $ rdma dev show mlx5_4 > 5: mlx5_4: > caps: SYS_IMAGE_GUID, RC_RNR_NAK_GEN, MEM_WINDOW, UD_IP_CSUM, UD_TSO, XRC, > MEM_MGT_EXTENSI

[PATCH 1/1] tc: custom qdisc pkt size translation table

2017-06-27 Thread McCabe, Robert J
Added the "custom" linklayer qdisc stab option. This allows the user to specify the pkt size translation parameters from stdin. Example: tc qdisc add ... stab tsize 8 linklayer custom htb Custom size table: InputSizeStart -> IntputSizeEnd: Output Pkt Size 0 - 255: 400 256 - 511: 800

Re: [PATCH] datapath: Avoid using stack larger than 1024.

2017-06-27 Thread Greg Rose
On 06/27/2017 12:03 AM, Tonghao Zhang wrote: When compiling OvS-master on 4.4.0-81 kernel, there is a warning: CC [M] /root/ovs/datapath/linux/datapath.o /root/ovs/datapath/linux/datapath.c: In function ‘ovs_flow_cmd_set’: /root/ovs/datapath/linux/datapath.c:1221:1: warning:

Re: [net PATCH] net: sched: Fix one possible panic when no destroy callback

2017-06-27 Thread Cong Wang
On Mon, Jun 26, 2017 at 6:35 PM, wrote: > From: Gao Feng > > When qdisc fail to init, qdisc_create would invoke the destroy callback > to cleanup. But there is no check if the callback exists really. So it > would cause the panic if there is no real destroy callback like these > qdisc codel, pfi

[PATCH] rxrpc: remove unused static variables

2017-06-27 Thread Sebastian Andrzej Siewior
The rxrpc_security_methods and rxrpc_security_sem user has been removed in 648af7fca159 ("rxrpc: Absorb the rxkad security module"). This was noticed by kbuild test robot for the -RT tree but is also true for !RT. Reported-by: kbuild test robot Cc: "David S. Miller" Cc: David Howells Cc: netdev

Re: [PATCH v6 05/21] net-next: stmmac: Add dwmac-sun8i

2017-06-27 Thread Maxime Ripard
On Tue, Jun 27, 2017 at 11:33:56AM +0100, Andre Przywara wrote: > Hi, > > On 27/06/17 11:23, Icenowy Zheng wrote: > > > > > > 于 2017年6月27日 GMT+08:00 下午6:15:58, Andre Przywara > > 写到: > >> Hi, > >> > >> On 27/06/17 10:41, Maxime Ripard wrote: > >>> On Tue, Jun 27, 2017 at 10:02:45AM +0100, Andr

  1   2   3   >