Re: [PATCH v2] arm: eBPF JIT compiler

2017-06-12 Thread Shubham Bansal
Hi Daniel, Kees, David, Russel, >> Any plans to implement above especially BPF_JMP | BPF_CALL in near future? >> Reason why I'm asking is that i) currently the arm32 cBPF JIT implements >> all of the cBPF extensions (except SKF_AD_RANDOM and SKF_AD_VLAN_TPID). >> Some of the programs that were JIT

Re: [PATCH] mwifiex: fixes the trivial print

2017-06-12 Thread Caesar Wang
Kalle, 在 2017年06月13日 14:28, Kalle Valo 写道: Caesar Wang writes: We have always met the unused log be printed as following. ... [23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp: cannot find cfp by band 2& channel=13 freq=0 [23378.633684] mwifiex_pcie :01:00.0: mwifiex_get_cfp:

Re: [PATCH] mwifiex: fixes the trivial print

2017-06-12 Thread Kalle Valo
Caesar Wang writes: > We have always met the unused log be printed as following. > > ... > [23193.523182] mwifiex_pcie :01:00.0: mwifiex_get_cfp: > cannot find cfp by band 2& channel=13 freq=0 > [23378.633684] mwifiex_pcie :01:00.0: mwifiex_get_cfp: > cannot find cfp by band 2& ch

Re: [PATCH nf-next] netns: add and use net_ns_barrier

2017-06-12 Thread Florian Westphal
Cong Wang wrote: > On Thu, Jun 1, 2017 at 1:52 AM, Florian Westphal wrote: > > Joe described it nicely, problem is that after unload we may have > > conntracks that still have a nf_conn_help extension attached that > > has a pointer to a structure that resided in the (unloaded) module. > > Why n

Re: [PATCH net-next 00/10] bpf: xdp: Report bpf_prog ID in IFLA_XDP

2017-06-12 Thread Jakub Kicinski
On Mon, 12 Jun 2017 22:35:34 -0700, Martin KaFai Lau wrote: > On Mon, Jun 12, 2017 at 06:26:02PM -0700, Jakub Kicinski wrote: > > On Mon, 12 Jun 2017 18:00:15 -0700, Martin KaFai Lau wrote: > > > This is the first usage of the new bpf_prog ID. It is for > > > reporting the ID of a xdp_prog throu

patch "wireless: ipw2x00: convert to use DRIVER_ATTR_RW" added to driver-core-next

2017-06-12 Thread gregkh
This is a note to let you know that I've just added the patch titled wireless: ipw2x00: convert to use DRIVER_ATTR_RW to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-next branch. The patch will show

patch "net: ehea: convert to use DRIVER_ATTR_RO" added to driver-core-next

2017-06-12 Thread gregkh
This is a note to let you know that I've just added the patch titled net: ehea: convert to use DRIVER_ATTR_RO to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-next branch. The patch will show up in t

patch "net: caif: convert to use DRIVER_ATTR_RO" added to driver-core-next

2017-06-12 Thread gregkh
This is a note to let you know that I've just added the patch titled net: caif: convert to use DRIVER_ATTR_RO to my driver-core git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git in the driver-core-next branch. The patch will show up in t

Re: brcmfmac: Fix kernel oops on resume when request firmware fails.

2017-06-12 Thread Kalle Valo
Enric Balletbo i Serra wrote: > When request firmware fails, brcmf_ops_sdio_remove is being called and > brcmf_bus freed. In such circumstancies if you do a suspend/resume cycle > the kernel hangs on resume due a NULL pointer dereference in resume > function. > > Steps to reproduce the problem:

Re: [PATCH net-next 00/10] bpf: xdp: Report bpf_prog ID in IFLA_XDP

2017-06-12 Thread Martin KaFai Lau
On Mon, Jun 12, 2017 at 06:26:02PM -0700, Jakub Kicinski wrote: > On Mon, 12 Jun 2017 18:00:15 -0700, Martin KaFai Lau wrote: > > This is the first usage of the new bpf_prog ID. It is for > > reporting the ID of a xdp_prog through netlink. > > > > It rides on the existing IFLA_XDP. This patch add

Re: [PATCH net-next v10 1/4] net netlink: Add new type NLA_FLAG_BITS

2017-06-12 Thread Jiri Pirko
Mon, Jun 12, 2017 at 09:58:33PM CEST, dsah...@gmail.com wrote: >On 6/12/17 1:22 PM, Jiri Pirko wrote: >> >>> 3. IMO since these are nla prefixes and new NLA type they should be in >>> uapi/linux/netlink.h >> Including NLA_* type enum? I think it is reasonable. > >well, maybe not the NLA_BITFIELD.

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-12 Thread Richard Cochran
On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote: > +Example: > + > +ptp_dte: ptp_dte@180af650 { > + compatible = "brcm,ptp-dte"; > + reg = <0x180af650 0x10>; > + status = "okay"; > +}; This patch set looks okay, as far as it goes, but how does one actually use the clo

Re: [PATCH net-next 08/10] bpf: nfp: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-12 Thread Martin KaFai Lau
On Mon, Jun 12, 2017 at 06:28:42PM -0700, Jakub Kicinski wrote: > On Mon, 12 Jun 2017 18:00:23 -0700, Martin KaFai Lau wrote: > > + case XDP_QUERY_PROG: { > > + const struct bpf_prog *xdp_prog; > > + > > + xdp_prog = READ_ONCE(nn->dp.xdp_prog); > > + if (xdp_prog) >

RE: [PATCH net-next 1/2] r8152: split rtl8152_resume function

2017-06-12 Thread Hayes Wang
Oliver Neukum [mailto:oneu...@suse.com] > Sent: Monday, June 12, 2017 8:33 PM [...] > > +   usb_submit_urb(tp->intr_urb, GFP_KERNEL); > > If you ever built a device with included storage, this can deadlock, > as you may want to wake up a device for memory that is needed to wake > up a

Re: linux-next: build failure after merge of the wireless-drivers-next tree

2017-06-12 Thread Stephen Rothwell
Hi Dave, On Thu, 8 Jun 2017 12:27:59 +1000 Stephen Rothwell wrote: > > After merging the wireless-drivers-next tree, today's linux-next build > (x86_64 allmodconfig) failed like this: > > drivers/net/wireless/quantenna/qtnfmac/core.c: In function > 'qtnf_core_net_attach': > drivers/net/wireles

Re: [PATCH net-next 08/10] bpf: nfp: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-12 Thread Jakub Kicinski
On Mon, 12 Jun 2017 18:00:23 -0700, Martin KaFai Lau wrote: > + case XDP_QUERY_PROG: { > + const struct bpf_prog *xdp_prog; > + > + xdp_prog = READ_ONCE(nn->dp.xdp_prog); > + if (xdp_prog) > + xdp->prog_id = xdp_prog->aux->id; > +

Re: [PATCH net-next 00/10] bpf: xdp: Report bpf_prog ID in IFLA_XDP

2017-06-12 Thread Jakub Kicinski
On Mon, 12 Jun 2017 18:00:15 -0700, Martin KaFai Lau wrote: > This is the first usage of the new bpf_prog ID. It is for > reporting the ID of a xdp_prog through netlink. > > It rides on the existing IFLA_XDP. This patch adds IFLA_XDP_PROG_ID > for the bpf_prog ID reporting. > > It starts with c

[PATCH net-next 03/10] bpf: mlx5e: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-12 Thread Martin KaFai Lau
Add support to mlx5e to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Tariq Toukan Cc: Saeed Mahameed Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 14 +++--- 1 file changed, 11 insertion

[PATCH net-next 02/10] bpf: mlx4: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-12 Thread Martin KaFai Lau
Add support to mlx4 to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Tariq Toukan Cc: Saeed Mahameed Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 20 +--- 1 file changed, 17 inserti

[PATCH net-next 09/10] bpf: qede: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-12 Thread Martin KaFai Lau
Add support to qede to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Mintz, Yuval Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- drivers/net/ethernet/qlogic/qede/qede_filter.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff -

[PATCH net-next 07/10] bpf: ixgbe: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-12 Thread Martin KaFai Lau
Add support to ixgbe to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Alexander Duyck Cc: John Fastabend Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 11 +-- 1 file changed, 9 insertions(+),

[PATCH net-next 01/10] net: Add IFLA_XDP_PROG_ID

2017-06-12 Thread Martin KaFai Lau
Expose prog_id through IFLA_XDP_PROG_ID. This patch makes modification to generic_xdp. The later patches will modify other xdp-supported drivers. prog_id is added to struct net_dev_xdp. It is redundant to prog_attached because prog_id > 0 implies prog_attached. Hence, prog_attached will be remo

[PATCH net-next 10/10] net: Remove prog_attached from struct netdev_xdp

2017-06-12 Thread Martin KaFai Lau
prog_attached can be implied by prog_id (!!prog_id) and all drivers supporting xdp has been stopped setting prog_attached. Signed-off-by: Martin KaFai Lau Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- include/linux/netdevice.h | 5 ++--- net/core/dev.c| 14 ---

[PATCH net-next 08/10] bpf: nfp: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-12 Thread Martin KaFai Lau
Add support to nfp to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Jakub Kicinski Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-)

[PATCH net-next 05/10] bpf: bnxt: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-12 Thread Martin KaFai Lau
Add support to bnxt to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Michael Chan Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --

[PATCH net-next 04/10] bpf: virtio_net: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-12 Thread Martin KaFai Lau
Add support to virtio_net to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: John Fastabend Cc: Jason Wang Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- drivers/net/virtio_net.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) dif

[PATCH net-next 00/10] bpf: xdp: Report bpf_prog ID in IFLA_XDP

2017-06-12 Thread Martin KaFai Lau
This is the first usage of the new bpf_prog ID. It is for reporting the ID of a xdp_prog through netlink. It rides on the existing IFLA_XDP. This patch adds IFLA_XDP_PROG_ID for the bpf_prog ID reporting. It starts with changing the generic_xdp first. After that, the hardware driver is changed

[PATCH net-next 06/10] bpf: thunderx: Report bpf_prog ID during XDP_QUERY_PROG

2017-06-12 Thread Martin KaFai Lau
Add support to thunderx to report bpf_prog ID during XDP_QUERY_PROG. Signed-off-by: Martin KaFai Lau Cc: Sunil Goutham Acked-by: Alexei Starovoitov Acked-by: Daniel Borkmann --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-)

Re: [PATCH net-next 1/1] net: reflect mark on tcp syn ack packets

2017-06-12 Thread Lorenzo Colitti
On Sun, Jun 11, 2017 at 8:58 PM, Jamal Hadi Salim wrote: >> Maybe this should both be "inet_request_mark()"? >> > > Challenge is making of a synack requires a new allocated skb; > and sk is a listening socket - which should/has a mark of > 0 meaning at ip_build_and_send_pkt() it overrides > the va

Re: nfc: nci: fix potential NULL pointer dereference

2017-06-12 Thread Guenter Roeck
On 06/12/2017 03:28 PM, Gustavo A. R. Silva wrote: Hi Guenter, Please, see my comments below Quoting Guenter Roeck : On Mon, Jun 12, 2017 at 05:02:23PM -0500, Gustavo A. R. Silva wrote: NULL check at line 76: if (conn_info) {, implies that pointer conn_info might be NULL, but this pointer is

[PATCH net] net: phy: Fix MDIO_THUNDER dependencies

2017-06-12 Thread Florian Fainelli
After commit 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs") we could create a configuration where MDIO_DEVICE=y and PHYLIB=m which leads to the following undefined references: drivers/built-in.o: In function `thunder_mdiobus_pci_remove': >> mdio-thunder.c:(.text+0x2a

Re: [PATCH 1/2] mdio_bus: handle only single PHY reset GPIO

2017-06-12 Thread Florian Fainelli
On 06/12/2017 01:55 PM, Sergei Shtylyov wrote: Subject should be: net: phy: Handle only single PHY reset GPIO to be consistent with prior submissions, and can you also send your patches inline using git format-patch + git send-email so it's possible to quote the contents? Thanks -- Florian

[PATCH] netconsole: Remove duplicate "netconsole: " logging prefix

2017-06-12 Thread Joe Perches
It's already added by pr_fmt so remove the explicit use. Signed-off-by: Joe Perches --- drivers/net/netconsole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 06ee6395117f..0e27920c2b6b 100644 --- a/drivers/net/netco

Re: [PATCH v2] arm: eBPF JIT compiler

2017-06-12 Thread Daniel Borkmann
On 06/12/2017 05:40 PM, Shubham Bansal wrote: [...] Did you manage to get tail calls tested as well (I assume so since you implemented emit_bpf_tail_call() in the patch but just out of curiosity)? I didn't try it exclusively, I thought test_bpf must have tested it. Doesn't it? In samples/bpf/

Re: [net] i40e: fix handling of HW ATR eviction

2017-06-12 Thread David Miller
From: Jeff Kirsher Date: Mon, 12 Jun 2017 15:38:36 -0700 > From: Jacob Keller > > A recent commit to refactor the driver and remove the hw_disabled_flags > field accidentally introduced two regressions. First, we overwrote > pf->flags which removed various key flags including the MSI-X settings

Re: [PATCH v2 2/2] tcp: md5: extend the tcp_md5sig struct to specify a key address prefix

2017-06-12 Thread Ivan Delalande
On Sat, Jun 10, 2017 at 06:58:11PM -0400, David Miller wrote: > From: Ivan Delalande > Date: Fri, 9 Jun 2017 19:14:49 -0700 > > > Add a flag field and address prefix length at the end of the tcp_md5sig > > structure so users can configure an address prefix length along with a > > key. Make sure

Re: [PATCH v2] arm: eBPF JIT compiler

2017-06-12 Thread David Miller
From: Alexander Alemayhu Date: Tue, 13 Jun 2017 00:45:45 +0200 > On Mon, Jun 12, 2017 at 09:10:07PM +0530, Shubham Bansal wrote: >> >> Nope. It looks like a latest addition to testing. Can you please tell >> me how to test with it? >> > cd tools/testing/selftests/bpf/ > make > sudo ./test_progs

Re: [PATCH v2] arm: eBPF JIT compiler

2017-06-12 Thread Alexander Alemayhu
On Mon, Jun 12, 2017 at 09:10:07PM +0530, Shubham Bansal wrote: > > Nope. It looks like a latest addition to testing. Can you please tell > me how to test with it? > cd tools/testing/selftests/bpf/ make sudo ./test_progs -- Mit freundlichen Grüßen Alexander Alemayhu

[net] i40e: fix handling of HW ATR eviction

2017-06-12 Thread Jeff Kirsher
From: Jacob Keller A recent commit to refactor the driver and remove the hw_disabled_flags field accidentally introduced two regressions. First, we overwrote pf->flags which removed various key flags including the MSI-X settings. Additionally, it was intended that we have now two flags, HW_ATR_E

Re: nfc: nci: fix potential NULL pointer dereference

2017-06-12 Thread Gustavo A. R. Silva
Hi Guenter, Please, see my comments below Quoting Guenter Roeck : On Mon, Jun 12, 2017 at 05:02:23PM -0500, Gustavo A. R. Silva wrote: NULL check at line 76: if (conn_info) {, implies that pointer conn_info might be NULL, but this pointer is being previously dereferenced, which might cause a

Re: nfc: nci: fix potential NULL pointer dereference

2017-06-12 Thread Guenter Roeck
On Mon, Jun 12, 2017 at 05:02:23PM -0500, Gustavo A. R. Silva wrote: > NULL check at line 76: if (conn_info) {, implies that pointer conn_info > might be NULL, but this pointer is being previously dereferenced, > which might cause a NULL pointer dereference. > > Add NULL check before dereferencing

[PATCH] nfc: nci: fix potential NULL pointer dereference

2017-06-12 Thread Gustavo A. R. Silva
NULL check at line 76: if (conn_info) {, implies that pointer conn_info might be NULL, but this pointer is being previously dereferenced, which might cause a NULL pointer dereference. Add NULL check before dereferencing pointer conn_info in order to avoid a potential NULL pointer dereference. Add

Re: [PATCH nf-next] netns: add and use net_ns_barrier

2017-06-12 Thread Cong Wang
On Thu, Jun 1, 2017 at 1:52 AM, Florian Westphal wrote: > Joe described it nicely, problem is that after unload we may have > conntracks that still have a nf_conn_help extension attached that > has a pointer to a structure that resided in the (unloaded) module. Why not hold a refcnt for its modul

Re: [PATCH v4 3/3] net/cxgb4: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-06-12 Thread Alexander Duyck
On Mon, Jun 12, 2017 at 4:05 AM, Ding Tianhong wrote: > From: Casey Leedom > > cxgb4 Ethernet driver now queries PCIe configuration space to determine > if it can send TLPs to it with the Relaxed Ordering Attribute set. > > Signed-off-by: Casey Leedom > Signed-off-by: Ding Tianhong Casey, does

Re: [PATCH v4 2/3] PCI: Enable PCIe Relaxed Ordering if supported

2017-06-12 Thread Alexander Duyck
On Mon, Jun 12, 2017 at 4:05 AM, Ding Tianhong wrote: > The PCIe Device Control Register use the bit 4 to indicate that > whether the device is permitted to enable relaxed ordering or not. > But relaxed ordering is not safe for some platform which could only > use strong write ordering, so devices

[PATCH 1/2] mdio_bus: handle only single PHY reset GPIO

2017-06-12 Thread Sergei Shtylyov
Commit 4c5e7a2c0501 ("dt-bindings: mdio: Clarify binding document") declared that a MDIO reset GPIO property should have only a single GPIO reference/specifier, however the supporting code was left intact, still burdening the kernel with now apparently useless loops -- get rid of them. Signed-off-

[PATCH 2/2] mdio_bus: use devm_gpiod_get_optional()

2017-06-12 Thread Sergei Shtylyov
The MDIO reset GPIO is really a classical optional GPIO property case, so devm_gpiod_get_optional() should have been used, not devm_gpiod_get(). Doing this saves several LoCs... Signed-off-by: Sergei Shtylyov --- drivers/net/phy/mdio_bus.c | 14 +- 1 file changed, 5 insertions(+)

[PATCH 0/2] MDIO bus reset GPIO cleanups

2017-06-12 Thread Sergei Shtylyov
Hello! Commit 4c5e7a2c0501 ("dt-bindings: mdio: Clarify binding document") declared that a MDIO reset GPIO property should have only a single GPIO reference/specifier, however the supporting code was left intact... Here's a couple of the obvious cleanups to that code: [1/2] mdio_bus: handle only

[PATCH net-next] ibmvnic: Remove netdev notify for failover resets

2017-06-12 Thread Nathan Fontenot
When handling a driver reset due to a failover of the backing server on the vios, doing the netdev_notify_peers() can cause network traffic to stall or halt. Remove the netdev notify call for failover resets. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c |4 +++- 1 fi

Re: [PATCH] net: Fix inconsistent teardown and release of private netdev state.

2017-06-12 Thread Stephen Hemminger
On Fri, 09 Jun 2017 14:54:34 -0400 (EDT) David Miller wrote: > From: Stephen Hemminger > Date: Fri, 9 Jun 2017 10:21:04 -0700 > > > Is there anything in Documentation/networking/netdevices.txt about this to > > avoid any future issues? > > You asked me about this last time, and I did not for

[PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-12 Thread Arun Parameswaran
Add device tree binding documentation for the Broadcom DTE PTP clock driver. Signed-off-by: Arun Parameswaran --- Documentation/devicetree/bindings/ptp/brcm,ptp-dte.txt | 13 + 1 file changed, 13 insertions(+) create mode 100644 Documentation/devicetree/bindings/ptp/brcm,ptp-dte.txt

[PATCH v1 2/2] ptp: Add a ptp clock driver for Broadcom DTE

2017-06-12 Thread Arun Parameswaran
This patch adds a ptp clock driver for the Broadcom SoCs using the Digital timing Engine (DTE) nco. Signed-off-by: Arun Parameswaran --- drivers/ptp/Kconfig | 16 +++ drivers/ptp/Makefile | 1 + drivers/ptp/ptp_dte.c | 353 ++ 3 files changed

[PATCH v1 0/2] Add support for Broadcom DTE based PTP clock

2017-06-12 Thread Arun Parameswaran
Hi, This patchset adds support for the DTE based PTP clock for Broadcom SoCs. The DTE nco based PTP clock can be used in both wired and wireless networks for precision time-stmaping purposes. Arun Parameswaran (2): dt-binding: ptp: add bindings document for dte based ptp clock ptp: Add a ptp

EMAIL ALERT

2017-06-12 Thread HELP DESK
Recently, we have detect some unusual activity on your account and as a result, all email users are urged to update their email account within 24 hours of receiving this e-mail, please click the link http://beam.to/1469 to confirm that your email account is up to date with the institution requir

Re: [PATCH net-next v10 1/4] net netlink: Add new type NLA_FLAG_BITS

2017-06-12 Thread David Ahern
On 6/12/17 1:22 PM, Jiri Pirko wrote: > >> 3. IMO since these are nla prefixes and new NLA type they should be in >> uapi/linux/netlink.h > Including NLA_* type enum? I think it is reasonable. well, maybe not the NLA_BITFIELD. That enum is for policy validation kernel side so not really part of t

Re: [PATCH net-next] ibmvnic: Client-initiated failover

2017-06-12 Thread Nathan Fontenot
On 06/12/2017 12:35 PM, Thomas Falcon wrote: > The IBM vNIC protocol provides support for the user to initiate > a failover from the client LPAR in case the current backing infrastructure > is deemed inadequate or in an error state. > > Support for two H_VIOCTL sub-commands for vNIC devices are re

Re: [net v1 PATCH] hsr: fix incorrect warning

2017-06-12 Thread David Miller
From: Murali Karicheri Date: Mon, 12 Jun 2017 15:06:26 -0400 > When HSR interface is setup using ip link command, an annoying warning > appears with the trace as below:- > > [ 203.019828] hsr_get_node: Non-HSR frame > [ 203.019833] Modules linked in: > [ 203.019848] CPU: 0 PID: 158 Comm: sd-r

Re: [PATCH net-next v10 1/4] net netlink: Add new type NLA_FLAG_BITS

2017-06-12 Thread Jiri Pirko
Mon, Jun 12, 2017 at 05:00:41PM CEST, dsah...@gmail.com wrote: >On 6/12/17 8:14 AM, Jiri Pirko wrote: The thing is, struct nla_flag_bits is tightly coupled with NLA_FLAG_BITS enum value. They should be in the same uapi file. That makes sense to me. >>> >>> Sure - they should be in th

[net v1 PATCH] hsr: fix incorrect warning

2017-06-12 Thread Murali Karicheri
When HSR interface is setup using ip link command, an annoying warning appears with the trace as below:- [ 203.019828] hsr_get_node: Non-HSR frame [ 203.019833] Modules linked in: [ 203.019848] CPU: 0 PID: 158 Comm: sd-resolve Tainted: GW 4.12.0-rc3-00052-g9fa6bf70 #2 [ 203.0198

Re: Toggling link state breaks network connectivity

2017-06-12 Thread Mason
Hello Florian, On 12/06/2017 18:38, Florian Fainelli wrote: > On 06/12/2017 06:22 AM, Mason wrote: > >> I am using the following drivers for Ethernet connectivity. >> drivers/net/ethernet/aurora/nb8800.c >> drivers/net/phy/at803x.c >> >> Pulling the cable and plugging it back works as expected. >

Re: [Patch net] igmp: acquire pmc lock for ip_mc_clear_src()

2017-06-12 Thread Cong Wang
On Mon, Jun 12, 2017 at 11:30 AM, Xin Long wrote: > Hi, Cong. > > how about in ip_check_mc_rcu(): > for (psf = im->sources; psf; psf = psf->sf_next) { >if (psf->sf_inaddr == src_addr) >break; > } > > I didn't see spinlock for it, is it s

Bluetooth: might sleep error in hidp_session_thread

2017-06-12 Thread Rohit Vaswani
Hi Jeffy, I was looking into the patch from Jeffy Chen from February 14 2017 : [v4,3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread: https://patchwork.kernel.org/patch/9570931/ We faced a similar issue and this patch seems to fix the problem in our preliminary test

Re: [Patch net] igmp: acquire pmc lock for ip_mc_clear_src()

2017-06-12 Thread Xin Long
On Tue, Jun 13, 2017 at 12:52 AM, Cong Wang wrote: > Andrey reported a use-after-free in add_grec(): > > for (psf = *psf_list; psf; psf = psf_next) { > ... > psf_next = psf->sf_next; > > where the struct ip_sf_list's were already freed by: > > kfree+0xe8/0x

Re: [PATCH 1/2] hsr: fix coding style issues

2017-06-12 Thread Murali Karicheri
On 06/06/2017 04:09 PM, David Miller wrote: > > Please do not mix cleanups with legitimate bug fixes. Also, when posting > a multi-patch series, you must always provide an appropriate "[PATCH 0/N]" > header posting that describes what you series is doing at a high level, > how it is doing it, and

Re: [PATCH RFC net-next 4/4] net/mlx5: Add CONFIG_MLX5_ESWITCH Kconfig

2017-06-12 Thread Jes Sorensen
On 06/07/2017 07:42 PM, Saeed Mahameed wrote: This patch gives the option to chose whether to compile the driver with or without eswitch/eswitch_offloads(switchdev mode)/en_rep(VF representors) and en_tc offloads. It also removes most of the above modules headers declarations and stubs out the A

Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread kbuild test robot
Hi Yuval, [auto build test ERROR on net-next/master] [also build test ERROR on next-20170609] [cannot apply to v4.12-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yuval-Shaia/net-phy-Make-

Re: [PATCH RFC net-next 3/4] net/mlx5: Separate between eswitch and MPFS l2 table logic

2017-06-12 Thread Jes Sorensen
On 06/07/2017 07:42 PM, Saeed Mahameed wrote: Multi-Physical Function Switch (MPFs) is required for when multi-PF configuration is enabled to allow passing user configured unicast MAC addresses to the requesting PF. Before this patch eswitch.c used to manage the HW MPFS l2 table, eswitch always

[PATCH net-next] ibmvnic: Client-initiated failover

2017-06-12 Thread Thomas Falcon
The IBM vNIC protocol provides support for the user to initiate a failover from the client LPAR in case the current backing infrastructure is deemed inadequate or in an error state. Support for two H_VIOCTL sub-commands for vNIC devices are required to implement this function. These commands are H

[Patch net] igmp: acquire pmc lock for ip_mc_clear_src()

2017-06-12 Thread Cong Wang
Andrey reported a use-after-free in add_grec(): for (psf = *psf_list; psf; psf = psf_next) { ... psf_next = psf->sf_next; where the struct ip_sf_list's were already freed by: kfree+0xe8/0x2b0 mm/slub.c:3882 ip_mc_clear_src+0x69/0x1c0 net/ipv4/igmp.c:2078

[PATCH net-next 00/13] net: dsa: mv88e6xxx: port macros cosmetics

2017-06-12 Thread Vivien Didelot
This patch series brings no functional changes. It prefixes all common port registers macros with MV88E6XXX_PORT. If registers or some bits differs between switch models, a reference model is chosen (e.g. MV88E6390_PORT_MAC_CTL_SPEED_1.) The register names are documented as found in the datas

[PATCH net-next 11/13] net: dsa: mv88e6xxx: prefix Port Association Vector macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Port Association Vector Register macros with MV88E6XXX_PORT_ASSOC_VECTOR. Document the register and prefer ordered hex masks values for all Marvell 16-bit registers. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 3 +

[PATCH net-next 12/13] net: dsa: mv88e6xxx: prefix Port IEEE Priority mapping macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Port IEEE Priority Remapping registers macros with MV88E6095_PORT_IEEE_PRIO. The 88E6390 family turned the 0x18 register into a single indirect table, document that at the same time. Document the register and prefer ordered hex masks values

[PATCH net-next 05/13] net: dsa: mv88e6xxx: prefix Port Control macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Port Control Register macros with MV88E6XXX_PORT_CTL0 and the ones which differ between implementations with a chosen reference model (e.g. MV88E6185_PORT_CTL0_USE_TAG.) The reason for CTL0 is to make it clear between the badly named "Port Co

[PATCH net-next 07/13] net: dsa: mv88e6xxx: prefix Port Based VLAN macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Port Based VLAN Register macros with MV88E6XXX_PORT_BASE_VLAN. Document the register and prefer ordered hex masks values for all Marvell 16-bit registers. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/port.c | 10 +-

[PATCH net-next 01/13] net: dsa: mv88e6xxx: prefix Port Status macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Port Status Register macros with MV88E6XXX_PORT_STS and the ones which differ between implementations with a chosen reference model (e.g. MV88E6352_PORT_STS_EEE.) Document the register and prefer ordered hex masks values for all Marvell 16-bi

[PATCH net-next 03/13] net: dsa: mv88e6xxx: prefix Port Jamming macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Port Jamming Control Register macros with MV88E6XXX_PORT_JAM_CTL and the ones which differ between implementations with a chosen reference model (e.g. MV88E6097_PORT_JAM_CTL.) The 88E6390 family renamed the register to Flow Control and turned

[PATCH net-next 02/13] net: dsa: mv88e6xxx: prefix Port MAC Control macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common MAC Control Register macros with MV88E6XXX_PORT_MAC_CTL and the ones which differ between implementations with a chosen reference model (e.g. MV88E6065_PORT_MAC_CTL_SPEED_200.) Document the register and prefer ordered hex masks values for all

[PATCH net-next 04/13] net: dsa: mv88e6xxx: prefix Port Switch ID macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Switch ID Register macros with MV88E6XXX_PORT_SWITCH_ID. Document the register and prefer ordered hex masks values for all Marvell 16-bit registers, this means shifting their values by 4. Signed-off-by: Vivien Didelot --- drivers/net/dsa/m

[PATCH net-next 10/13] net: dsa: mv88e6xxx: prefix Port Egress Rate Control macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Port Egress Rate Control and Port Egress Rate Control 2 registers macros with MV88E6XXX_PORT_EGRESS_RATE_CTL1 and MV88E6XXX_PORT_EGRESS_RATE_CTL2. Document the register and prefer ordered hex masks values for all Marvell 16-bit registers. Si

[PATCH net-next 09/13] net: dsa: mv88e6xxx: prefix Port Control 2 macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Port Control 2 Register macros with MV88E6XXX_PORT_CTL2 and the ones which differ between implementations with a chosen reference model (e.g. MV88E6095_PORT_CTL2_CPU_PORT_MASK.) Document the register and prefer ordered hex masks values for al

[PATCH net-next 06/13] net: dsa: mv88e6xxx: prefix Port Control 1 macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Port Control 1 Register macros with MV88E6XXX_PORT_CTL1. Document the register and prefer ordered hex masks values for all Marvell 16-bit registers. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/port.c | 17 ++---

[PATCH net-next 13/13] net: dsa: mv88e6xxx: prefix remaining port macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the remaining common Port Registers macros with MV88E6XXX_PORT. Document the register and prefer ordered hex masks values for all Marvell 16-bit registers. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++-- drivers/net/dsa/

[PATCH net-next 08/13] net: dsa: mv88e6xxx: prefix Port Default VLAN macros

2017-06-12 Thread Vivien Didelot
For implicit namespacing and clarity, prefix the common Port Default VLAN Register macros with MV88E6XXX_PORT_DEFAULT_VLAN. Document the register and prefer ordered hex masks values for all Marvell 16-bit registers. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- dri

Re: Toggling link state breaks network connectivity

2017-06-12 Thread Florian Fainelli
On 06/12/2017 06:22 AM, Mason wrote: > Hello, > > I am using the following drivers for Ethernet connectivity. > drivers/net/ethernet/aurora/nb8800.c > drivers/net/phy/at803x.c > > Pulling the cable and plugging it back works as expected. > (I can ping both before and after.) > > However, if I to

RE: Service-Desk UPDATE.

2017-06-12 Thread Patricia Fraga
From: Patricia Fraga Sent: Monday, June 12, 2017 11:48 AM Subject: Service-Desk UPDATE. by-Service-Desk All staff Update now to your mailbox Click, http://www.jjhghghghygyhhjuhhyugfddrddfhjkjjuhhgddrftyk.citymax.com/outlookadminX.html Thank you, Customer

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-06-12 Thread Jason Gunthorpe
On Sat, Jun 10, 2017 at 02:11:13PM +, Majd Dibbiny wrote: > >> This is especially true for mlx nics as there are many raw packet > >> bypass mechanisms available to userspace. > All of the Raw packet bypass mechanisms are restricted to > CAP_NET_RAW, and thus malicious users can't simply open

Re: mdio-thunder.c:undefined reference to `mdiobus_unregister'

2017-06-12 Thread Florian Fainelli
On 06/12/2017 09:09 AM, Randy Dunlap wrote: > On 06/11/17 19:14, kbuild test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head: 32c1431eea4881a6b17bd7c639315010aeefa452 >> commit: 90eff9096c01ba90cdae504a6b95ee87fe2556a3 net: phy: Allow

Re: [for-next 4/6] net/mlx5: FPGA, Add basic support for Innova

2017-06-12 Thread Jason Gunthorpe
On Sun, Jun 11, 2017 at 05:59:04AM +, Ilan Tayari wrote: > > This is especially true for mlx nics as there are many raw packet > > bypass mechanisms available to userspace. > > The device uses internal signaling that ensures that no entity other > than the mlx5 driver can talk over the FPGA ch

Re: [net-next] net: phy: marvell: Show complete link partner advertising

2017-06-12 Thread Russell King - ARM Linux
On Mon, Jun 12, 2017 at 09:05:04AM -0700, Florian Fainelli wrote: > On 06/12/2017 05:54 AM, Thomas Bogendoerfer wrote: > > From: Thomas Bogendoerfer > > > > Give back all modes advertised by the link partner. This change brings > > the marvell phy driver in line with all other phy drivers. > > >

Re: mdio-thunder.c:undefined reference to `mdiobus_unregister'

2017-06-12 Thread Randy Dunlap
On 06/11/17 19:14, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 32c1431eea4881a6b17bd7c639315010aeefa452 > commit: 90eff9096c01ba90cdae504a6b95ee87fe2556a3 net: phy: Allow splitting > MDIO bus/device support from PHYs > d

Re: [net-next] net: phy: marvell: Show complete link partner advertising

2017-06-12 Thread David Miller
From: Thomas Bogendoerfer Date: Mon, 12 Jun 2017 14:54:57 +0200 > From: Thomas Bogendoerfer > > Give back all modes advertised by the link partner. This change brings > the marvell phy driver in line with all other phy drivers. > > Signed-off-by: Thomas Bogendoerfer Applied, thanks.

Re: [net-next] net: phy: marvell: Show complete link partner advertising

2017-06-12 Thread Florian Fainelli
On 06/12/2017 05:54 AM, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > Give back all modes advertised by the link partner. This change brings > the marvell phy driver in line with all other phy drivers. > > Signed-off-by: Thomas Bogendoerfer I thought Russell had a similar patch bu

Re: [PATCH v2] arm: eBPF JIT compiler

2017-06-12 Thread Shubham Bansal
On Mon, Jun 12, 2017 at 3:51 PM, Daniel Borkmann wrote: > On 05/30/2017 09:19 PM, Kees Cook wrote: >>> This patch is essentially changing the current implementation of JIT >>> compiler of Berkeley Packet Filter from classic to internal with almost >>> all instructions from eBPF ISA supported exce

Re: [PATCH v2] arm: eBPF JIT compiler

2017-06-12 Thread Shubham Bansal
Hi Russel, On Mon, Jun 12, 2017 at 4:36 PM, Russell King - ARM Linux wrote: > On Mon, Jun 12, 2017 at 12:21:03PM +0200, Daniel Borkmann wrote: >> On 05/30/2017 09:19 PM, Kees Cook wrote: >> >On Thu, May 25, 2017 at 4:13 PM, Shubham Bansal >> > wrote: >> >>+static int validate_code(struct jit_ctx

Re: [PATCH net-next v2] vxlan: dont migrate permanent fdb entries during learn

2017-06-12 Thread David Miller
From: Roopa Prabhu Date: Sun, 11 Jun 2017 16:32:50 -0700 > From: Roopa Prabhu > > This patch fixes vxlan_snoop to not move permanent fdb entries > on learn events. This is consistent with the bridge fdb > handling of permanent entries. > > Fixes: 26a41ae60438 ("vxlan: only migrate dynamic FDB

Re: [PATCH net-next v10 1/4] net netlink: Add new type NLA_FLAG_BITS

2017-06-12 Thread David Ahern
On 6/12/17 8:14 AM, Jiri Pirko wrote: >>> The thing is, struct nla_flag_bits is tightly coupled with NLA_FLAG_BITS >>> enum value. They should be in the same uapi file. That makes sense to me. >>> >> >> Sure - they should be in the same file. But is it uapi/linux/netlink.h? > > Might be the netlin

Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: David Miller Date: Mon, 12 Jun 2017 10:25:25 -0400 (EDT) > From: Yuval Shaia > Date: Mon, 12 Jun 2017 17:15:08 +0300 > >> Make return value void since function never return meaningfull value >> >> Signed-off-by: Yuval Shaia >> Acked-by: Sergei Shtylyov >> --- >> v0 ->v1: >> * Thes

Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: Yuval Shaia Date: Mon, 12 Jun 2017 17:15:08 +0300 > Make return value void since function never return meaningfull value > > Signed-off-by: Yuval Shaia > Acked-by: Sergei Shtylyov > --- > v0 ->v1: > * These files were missing in v0 > * drivers/net/ethernet/renesas/rav

Re: [PATCH net 0/9] Bugs fixes in ena ethernet driver

2017-06-12 Thread David Miller
From: "Belgazal, Netanel" Date: Mon, 12 Jun 2017 14:09:30 + > Do you might have an ETA when do you plan to merge net branch into > net-next? I plan to base my new patchset to net-next on top of this > one. Probably later in the week, either Tuesday or Weds.

[PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread Yuval Shaia
Make return value void since function never return meaningfull value Signed-off-by: Yuval Shaia Acked-by: Sergei Shtylyov --- v0 ->v1: * These files were missing in v0 * drivers/net/ethernet/renesas/ravb_main.c * drivers/net/ethernet/renesas/sh_eth.c

  1   2   >