On Wed, 2017-06-07 at 01:20 +0200, Seraphime Kirkovski wrote:
> Those constants have been unused for quite some time now.
>
> Signed-off-by: Seraphime Kirkovski
> ---
> I've compile-tested it.
Thanks. I've applied it to our internal tree and it will reach the
mainline at some point.
--
Cheers
The mvpp22_port_mii_set() function was added by 2697582144dd, but the
function directly returns without doing anything. This return was used
when debugging and wasn't removed before sending the patch. Fix this.
Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
Signed-off-by
On Tue, Jun 06, 2017 at 09:08:22PM -0700, Eric Dumazet wrote:
> On Tue, 2017-06-06 at 17:54 -0700, Ivan Delalande wrote:
>> diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h
>> index 38a2b07afdff..52ac30aa0652 100644
>> --- a/include/uapi/linux/tcp.h
>> +++ b/include/uapi/linux/tcp.h
Cc the reporter.
On Tue, Jun 06, 2017 at 12:14:39PM -0700, Stephen Hemminger wrote:
>
>
> Begin forwarded message:
>
> Date: Sat, 03 Jun 2017 06:25:05 +
> From: bugzilla-dae...@bugzilla.kernel.org
> To: step...@networkplumber.org
> Subject: [Bug 195969] New: ipsec icmp and udp works, tcp do
On Tue, 2017-06-06 at 18:34 -0600, David Ahern wrote:
> On 6/6/17 6:27 PM, Eric Dumazet wrote:
> > Good catch, but it looks like similar fix is needed a few lines before.
> >
> > diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
> > index
> > deea901746c8570c5e801e40592c91e3b62812e0..b214443dc
On Tue, Jun 6, 2017 at 7:17 PM, Jason Gunthorpe
wrote:
> On Tue, Jun 06, 2017 at 06:52:15AM +, Ilan Tayari wrote:
>
>> So neither the host stack nor the network are aware of them.
>> They exist momentarily only on the internal traces on the board and not
>> anywhere else.
>
> Is that really tr
On Tue, 2017-06-06 at 17:54 -0700, Ivan Delalande wrote:
> Replace padding in the socket option structure tcp_md5sig with a new
> flag field and address prefix length so it can be specified when
> configuring a new key with the TCP_MD5SIG socket option.
>
> Signed-off-by: Bob Gilligan
> Signed-of
On Wed, Jun 7, 2017 at 12:46 AM, Jes Sorensen wrote:
> On 06/05/2017 05:53 PM, Saeed Mahameed wrote:
>>
>> On Mon, Jun 5, 2017 at 11:51 PM, Jes Sorensen wrote:
>>>
>>> On 06/03/2017 03:37 PM, Or Gerlitz wrote:
On Fri, Jun 2, 2017 at 11:22 PM, Jes Sorensen wrote:
>
>
>
On Wed, Jun 7, 2017 at 1:44 AM, Alexei Starovoitov
wrote:
> On Tue, Jun 06, 2017 at 03:01:51PM -0400, David Miller wrote:
>> From: Alexei Starovoitov
>> Date: Tue, 6 Jun 2017 11:55:33 -0700
>>
>> > If in the future mlx will make it into the nic in a way that
>> > encryption shares all memory mana
2017-06-06 19:11 GMT-07:00 Vivien Didelot :
> Hi Florian,
>
> Florian Fainelli writes:
>
>> +static inline struct dsa_port *dsa_ds_get_cpu_dp(struct dsa_switch *ds)
>> +{
>> + return &ds->ports[fls(ds->cpu_port_mask) - 1];
>> +}
>
> So as I said in v2, now that a driver is guaranteed that dp->
Florian Fainelli writes:
> In preparation for supporting multiple CPU ports, remove
> dst->master_netdev and ds->master_netdev and replace them with only one
> instance of the common object we have for a port: struct
> dsa_port::netdev. ds->master_netdev is currently write only and would be
> hel
Hi Florian,
Since you'll respin a v3, there are still a few typos here:
Florian Fainelli writes:
> This patch series prepares the ground for adding mutliple CPU port support to
multiple
> DSA, and starts by removing redundant pieces of inform
Hi Florian,
Florian Fainelli writes:
> +static inline struct dsa_port *dsa_ds_get_cpu_dp(struct dsa_switch *ds)
> +{
> + return &ds->ports[fls(ds->cpu_port_mask) - 1];
> +}
So as I said in v2, now that a driver is guaranteed that dp->cpu_dp is
correctly assigned at setup time, isn't better
Both the IMX51 and IMX53 datasheet indicates that the MIB counters
should be cleared during setup. Otherwise random numbers are returned
via ethtool -S. Add a quirk and a function to do this.
Tested on an IMX51.
Signed-off-by: Andrew Lunn
---
drivers/net/ethernet/freescale/fec.h | 4
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf
> Of Jeff Kirsher
> Sent: Tuesday, June 6, 2017 1:46 PM
> To: David Miller ; Nikula, Jani
>
> Cc: Ursulin, Tvrtko ; daniel.vet...@ffwll.ch; intel-
> g...@lists.freedesktop.org; linux-ker...@vger.kernel.org;
> jani.nik...
From: Florian Westphal
Date: Tue, 6 Jun 2017 23:57:35 +0200
> David Miller wrote:
>> From: Alexander Potapenko
>> Date: Tue, 6 Jun 2017 15:56:54 +0200
>>
>> > KMSAN reported a use of uninitialized memory in dev_set_alias(),
>> > which was caused by calling strlcpy() (which in turn called strl
This allows the keys used for TCP MD5 signature to be used for whole
range of addresses, specified with a prefix length, instead of only one
address as it currently is.
Signed-off-by: Bob Gilligan
Signed-off-by: Eric Mowat
Signed-off-by: Ivan Delalande
---
include/net/tcp.h | 6 +++--
net/i
Replace padding in the socket option structure tcp_md5sig with a new
flag field and address prefix length so it can be specified when
configuring a new key with the TCP_MD5SIG socket option.
Signed-off-by: Bob Gilligan
Signed-off-by: Eric Mowat
Signed-off-by: Ivan Delalande
---
include/uapi/li
On Tue, Jun 06, 2017 at 03:44:53PM -0700, Alexei Starovoitov wrote:
> On Tue, Jun 06, 2017 at 03:01:51PM -0400, David Miller wrote:
> > From: Alexei Starovoitov
> > Date: Tue, 6 Jun 2017 11:55:33 -0700
> >
> > > If in the future mlx will make it into the nic in a way that
> > > encryption shares
On 06/06/2017 05:27 PM, Eric Dumazet wrote:
On Tue, 2017-06-06 at 18:00 -0600, David Ahern wrote:
On 6/6/17 3:06 PM, Ben Greear wrote:
This bug has been around forever, and we recently got an intern and
stuck him with
trying to reproduce it on the latest kernel. It is still here. I'm not
supe
On 6/6/17 6:27 PM, Eric Dumazet wrote:
> Good catch, but it looks like similar fix is needed a few lines before.
>
> diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
> index
> deea901746c8570c5e801e40592c91e3b62812e0..b214443dc8346cef3690df7f27cc48a864028865
> 100644
> --- a/net/ipv6/ip6_fib
On Tue, 2017-06-06 at 18:00 -0600, David Ahern wrote:
> On 6/6/17 3:06 PM, Ben Greear wrote:
> > This bug has been around forever, and we recently got an intern and
> > stuck him with
> > trying to reproduce it on the latest kernel. It is still here. I'm not
> > super excited
> > about trying to
Oleksij Rempel wrote:
> Yes, this is "normal" problem. The firmware has no error handler for PCI
> bus related exceptions. So if we filed to read PCI bus first time, we
> have choice to Ooops and stall or Ooops and reboot ASAP. So we reboot
> and provide an kernel "firmware panic!" message.
> Every
On 06/06/2017 05:03 PM, Florian Fainelli wrote:
> Hi all,
>
> This patch series prepares the ground for adding mutliple CPU port support to
> DSA, and starts by removing redundant pieces of information such as
> master_netdev which is cpu_dp->ethernet. Finally drivers are moved away from
> directl
Relocate master_ethtool_ops and master_orig_ethtool_ops into struct
dsa_port in order to be both consistent, and make things self contained
within the dsa_port structure.
This is a preliminary change to supporting multiple CPU port interfaces.
Reviewed-by: Vivien Didelot
Signed-off-by: Florian F
Out of the few drivers that do access ds->dst->cpu_dp, there is only a
handful for which we cannot substitute that for either an existing and
equivalent piece of information (b53, bcm_sf2, qca8k), and there is only
one for which we need to introduce a helper: mt7530. We do introduce
dsa_ds_get_cpu_
Hi all,
This patch series prepares the ground for adding mutliple CPU port support to
DSA, and starts by removing redundant pieces of information such as
master_netdev which is cpu_dp->ethernet. Finally drivers are moved away from
directly accessing ds->dst->cpu_dp and use appropriate helper funct
Introduce a helper function which will return a reference to the CPU
port used in a dsa_switch_tree. Right now this is a singleton, but this
will change once we introduce multi-CPU port support, so ease the
transition by converting the affected code paths.
Reviewed-by: Vivien Didelot
Signed-off-b
In preparation for supporting multiple CPU ports, remove
dst->master_netdev and ds->master_netdev and replace them with only one
instance of the common object we have for a port: struct
dsa_port::netdev. ds->master_netdev is currently write only and would be
helpful in the case where we have two sw
In preparation for supporting multiple CPU ports with DSA, have the
dsa_port structure know which CPU it is associated with. This will be
important in order to make sure the correct CPU is used for transmission
of the frames. If not for functional reasons, for performance (e.g: load
balancing) and
On 6/6/17 3:06 PM, Ben Greear wrote:
> This bug has been around forever, and we recently got an intern and
> stuck him with
> trying to reproduce it on the latest kernel. It is still here. I'm not
> super excited
> about trying to fix this, but we can easily test patches if someone has a
> patch
From: Colin Ian King
key has previously been null checked so the subsequent null check
is redundant as key can never be null at that point, so remove it.
Detected by CoverityScan, CID#1357164 ("Logically dead code")
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/intel/i40evf/i40evf_et
On Tue, Jun 06, 2017 at 12:35:30PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 6/6/2017 1:08 AM, Eugeniu Rosca wrote:
>
> >Commit a47b70ea86bd ("ravb: unmap descriptors when freeing rings") has
> >introduced the issue seen in [1] reproduced on H3ULCB board.
> >
> >Fix this by relocating the RX
Those constants have been unused for quite some time now.
Signed-off-by: Seraphime Kirkovski
---
I've compile-tested it.
drivers/net/wireless/intel/iwlwifi/dvm/commands.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/commands.h
b/drivers/net/
On Wed, 2017-06-07 at 00:12 +0200, Juan José Echevarria wrote:
> Hi,
>
> This is my first post, hope I'm not using the mailing list wrongly.
>
> As proposed in an old thread
> (https://www.spinics.net/lists/netdev/msg329144.html), when we send
> SYN cookies and then exit this mode, tcp_synq_no_re
On Tue, Jun 06, 2017 at 03:01:51PM -0400, David Miller wrote:
> From: Alexei Starovoitov
> Date: Tue, 6 Jun 2017 11:55:33 -0700
>
> > If in the future mlx will make it into the nic in a way that
> > encryption shares all memory management logic and there is no fpga
> > at all then it indeed will
On 06/06/2017 09:56 AM, Daniel Borkmann wrote:
On 06/02/2017 01:42 AM, Alexei Starovoitov wrote:
On Wed, May 31, 2017 at 06:16:00PM -0700, Chenbo Feng wrote:
From: Chenbo Feng
Currently loading a cgroup skb eBPF program require a CAP_SYS_ADMIN
capability while attaching the program to a cgro
querido usuario
Su buzón de correo ha excedido el límite de almacenamiento de 20 GB establecido
por el administrador, actualmente se está ejecutando a 20,9 GB, no puede enviar
o recibir nuevos mensajes hasta que varify su buzón. Vuelva a validar su cuenta
por correo, rellene y envíe los datos s
Hi,
This is my first post, hope I'm not using the mailing list wrongly.
As proposed in an old thread
(https://www.spinics.net/lists/netdev/msg329144.html), when we send
SYN cookies and then exit this mode, tcp_synq_no_recent_overflow()
returns false if cookies are received until 2 minutes later
(
David Miller wrote:
> From: Alexander Potapenko
> Date: Tue, 6 Jun 2017 15:56:54 +0200
>
> > KMSAN reported a use of uninitialized memory in dev_set_alias(),
> > which was caused by calling strlcpy() (which in turn called strlen())
> > on the user-supplied non-terminated string.
> >
> > Signed
Changing the mtu is currently not supported in the ibmvnic driver.
Implement .ndo_change_mtu in the driver so that attempting to use ifconfig
to change the mtu will fail and present the user with an error message.
Signed-off-by: John Allen
---
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/d
On 06/05/2017 05:53 PM, Saeed Mahameed wrote:
On Mon, Jun 5, 2017 at 11:51 PM, Jes Sorensen wrote:
On 06/03/2017 03:37 PM, Or Gerlitz wrote:
On Fri, Jun 2, 2017 at 11:22 PM, Jes Sorensen wrote:
On 05/28/2017 02:03 AM, Or Gerlitz wrote:
On Sun, May 28, 2017 at 5:23 AM, Jes Sorensen
wrot
On Tue, Jun 6, 2017 at 10:36 PM, David Miller wrote:
> From: Alexander Potapenko
> Date: Tue, 6 Jun 2017 15:56:54 +0200
>
>> KMSAN reported a use of uninitialized memory in dev_set_alias(),
>> which was caused by calling strlcpy() (which in turn called strlen())
>> on the user-supplied non-termi
Hello,
This bug has been around forever, and we recently got an intern and stuck him
with
trying to reproduce it on the latest kernel. It is still here. I'm not super
excited
about trying to fix this, but we can easily test patches if someone has a
patch to try.
Test case is to create 1000 m
Define the target port membership of the VLAN entry in
mv88e6xxx_port_vlan_add where ds is scoped.
Allow the DSA core to call later the port_vlan_add operation for CPU or
DSA ports, by using the Unmodified membership for these ports, as in the
current behavior.
Signed-off-by: Vivien Didelot
---
The current code in DSA does not support cross-chip VLAN. This means
that in a multi-chip environment such as this one (similar to ZII Rev B)
[CPU] (mdio)
(eth0) | : : :
_|_______
[__sw0__]--[__sw1__]--[__sw2_
In a multi-chip switch fabric, it is currently the responsibility of the
driver to add the CPU or DSA (interconnecting chips together) ports as
members of a new VLAN entry. This makes the drivers more complicated.
We want the DSA drivers to be stupid and the DSA core being the one
responsible for
Now that the DSA core adds the CPU and DSA ports itself to the new VLAN
entry, there is no need to include them as members of this VLAN when
initializing a new VTU entry.
As of now, initialize a new VTU entry with all ports excluded.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6xxx/c
Now that the VLAN object is propagated to every switch chip of the
switch fabric, we can easily ensure that they all support the required
VLAN operations before modifying an entry on a single switch.
To achieve that, remove the condition skipping other target switches,
and add a bitmap of VLAN mem
The mv88e6xxx driver currently tries to be smart and remove by itself a
VLAN entry from the VTU when the driven switch sees no user ports as
members of the VLAN.
This is bad in a multi-chip switch fabric, since a chip in between
others may have no bridge port members, but still needs to be aware o
On Tue, 2017-06-06 at 16:23 +0200, Paolo Abeni wrote:
> when udp_recvmsg() is executed, on x86_64 and other archs, most skb
> fields are on cold cachelines.
> If the skb are linear and the kernel don't need to compute the udp
> csum, only a handful of skb fields are required by udp_recvmsg().
> Sin
1) Made TCP congestion control documentation match current reality,
from Anmol Sarma.
2) Various build warning and failure fixes from Arnd Bergmann.
3) Fix SKB list leak in ipv6_gso_segment().
4) Use after free in ravb driver, from Eugeniu Rosca.
5) Don't use udp_poll() in ping protocol dri
On Tue, 2017-06-06 at 16:23 +0200, Paolo Abeni wrote:
> Since UDP no more uses sk->destructor, we can clear completely
> the skb head state before enqueuing. Amend and use
> skb_release_head_state() for that.
>
> All head states share a single cacheline, which is not
> normally used/accesses on de
On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
> From: Jani Nikula
> Date: Wed, 31 May 2017 18:50:43 +0300
>
> > From: Chris Wilson
> >
> > An error during suspend (e100e_pm_suspend),
>
> ...
> > lead to complete failure:
>
> ...
> > The unwind failures stems from commit 2800209994f
From: Daniel Borkmann
Date: Tue, 06 Jun 2017 22:27:15 +0200
> On 06/06/2017 10:26 PM, David Miller wrote:
>> From: Chenbo Feng
>> Date: Tue, 6 Jun 2017 13:24:11 -0700
>>
>>> On Tue, Jun 6, 2017 at 9:40 AM, Daniel Borkmann
>>> wrote:
>>>
On 06/06/2017 02:04 PM, Daniel Borkmann wrote:
>
From: Daniel Borkmann
Date: Tue, 6 Jun 2017 18:38:04 +0200
> Commit fb9a307d11d6 ("bpf: Allow CGROUP_SKB eBPF program to
> access sk_buff") enabled programs of BPF_PROG_TYPE_CGROUP_SKB
> type to use ld_abs/ind instructions. However, at this point,
> we cannot use them, since offsets relative to
From: Alexander Potapenko
Date: Tue, 6 Jun 2017 15:56:54 +0200
> KMSAN reported a use of uninitialized memory in dev_set_alias(),
> which was caused by calling strlcpy() (which in turn called strlen())
> on the user-supplied non-terminated string.
>
> Signed-off-by: Alexander Potapenko
We sho
From: Colin King
Date: Tue, 6 Jun 2017 14:10:49 +0100
> From: Colin Ian King
>
> The check that queue is less or equal to zero is always true
> because queue is a u32; queue is decremented and will wrap around
> and never go -ve. Fix this by making queue an int.
>
> Detected by CoverityScan,
On 06/06/2017 10:26 PM, David Miller wrote:
From: Chenbo Feng
Date: Tue, 6 Jun 2017 13:24:11 -0700
On Tue, Jun 6, 2017 at 9:40 AM, Daniel Borkmann
wrote:
On 06/06/2017 02:04 PM, Daniel Borkmann wrote:
On 06/01/2017 03:15 AM, Chenbo Feng wrote:
From: Chenbo Feng
This allows cgroup eBPF
From: Chenbo Feng
Date: Tue, 6 Jun 2017 13:24:11 -0700
> On Tue, Jun 6, 2017 at 9:40 AM, Daniel Borkmann
> wrote:
>
>> On 06/06/2017 02:04 PM, Daniel Borkmann wrote:
>>
>>> On 06/01/2017 03:15 AM, Chenbo Feng wrote:
>>>
From: Chenbo Feng
This allows cgroup eBPF program to classi
From: Niklas Cassel
Date: Tue, 6 Jun 2017 09:25:00 +0200
> stmmac_tso_allocator can fail to set the Last Descriptor bit
> on a descriptor that actually was the last descriptor.
>
> This happens when the buffer of the last descriptor ends
> up having a size of exactly TSO_MAX_BUFF_SIZE.
>
> When
From: Jason Wang
Date: Tue, 6 Jun 2017 14:09:49 +0800
> Tun actually expects a symmetric hash for queue selecting to work
> correctly, otherwise packets belongs to a single flow may be
> redirected to the wrong queue. So this patch switch to use
> __skb_get_hash_symmetric().
>
> Signed-off-by:
From: Max Filippov
Date: Mon, 5 Jun 2017 18:31:16 -0700
> ethoc_reset enables device interrupts, ethoc_interrupt may schedule a
> NAPI poll before NAPI is enabled in the ethoc_open, which results in
> device being unable to send or receive anything until it's closed and
> reopened. In case the d
On Tue, Jun 06, 2017 at 03:00:15PM -0400, David Miller wrote:
> He's adjusting the Makefile so that it build macb_main.c into macb.o
Duh, sorry, brain shutting down...
Thanks,
Richard
Please do not mix cleanups with legitimate bug fixes. Also, when posting
a multi-patch series, you must always provide an appropriate "[PATCH 0/N]"
header posting that describes what you series is doing at a high level,
how it is doing it, and why it is doing it that way.
For this, submit the er
From: Nikolay Aleksandrov
Date: Tue, 6 Jun 2017 01:26:24 +0300
> We might call br_afspec() with p == NULL which is a valid use case if
> the action is on the bridge device itself, but the bridge tunnel code
> dereferences the p pointer without checking, so check if p is null
> first.
>
> Report
From: Vivien Didelot
Date: Mon, 5 Jun 2017 18:17:16 -0400
> The register bits used for the frame mode were masked with DSA (0x1)
> instead of the mask value (0x3) in the 6085 implementation of
> port_set_frame_mode. Fix this.
>
> Fixes: 56995cbc3540 ("net: dsa: mv88e6xxx: Refactor CPU and DSA p
From: Eugeniu Rosca
Date: Tue, 6 Jun 2017 00:08:10 +0200
> Commit a47b70ea86bd ("ravb: unmap descriptors when freeing rings") has
> introduced the issue seen in [1] reproduced on H3ULCB board.
>
> Fix this by relocating the RX skb ringbuffer free operation, so that
> swiotlb page unmapping can b
On Tue, 6 Jun 2017 11:17:57 +0200, Jiri Pirko wrote:
> >> >What were your plans with pre-netdev config?
> >>
> >> We need to pass come initial resource division. Generally the consensus
> >> is to have these options exposed through devlink, let the user configure
> >> them all and then to have
From: Stephen Hemminger
Date: Mon, 5 Jun 2017 14:10:10 -0700
> + nvdev = rtnl_dereference(ndevctx->nvdev);
> + if (nvdev)
> + rdev = nvdev->extension;
> +
> + if (rdev) {
> + if (ndev->flags & IFF_PROMISC)
> + rndis_
Hi Russell, Alexei, David, Daniel, kees,
Any update on this patch moving forward?
Best,
Shubham Bansal
On Wed, May 31, 2017 at 12:49 AM, Kees Cook wrote:
> Forwarding this to net-dev and eBPF folks, who weren't on CC...
>
> -Kees
>
> On Thu, May 25, 2017 at 4:13 PM, Shubham Bansal
> wrote:
>>
From: Martin KaFai Lau
Date: Mon, 5 Jun 2017 12:15:45 -0700
> This patch series:
> 1) Introduce ID for both bpf_prog and bpf_map.
> 2) Add bpf commands to iterate the prog IDs and map
>IDs of the system.
> 3) Add bpf commands to get a prog/map fd from an ID
> 4) Add bpf command to get prog/ma
On 06/06/2017 11:25 AM, Vivien Didelot wrote:
> Hi Florian,
>
> Florian Fainelli writes:
>
>> This patch series prepares the ground for adding mutliple CPU port support to
>
>multiple
>
>> DS
From: Eric Dumazet
DRAM supply shortage and poor memory pressure tracking in TCP
stack makes any change in SO_SNDBUF/SO_RCVBUF (or equivalent autotuning
limits) and tcp_mem[] quite hazardous.
TCPMemoryPressures SNMP counter is an indication of tcp_mem sysctl
limits being hit, but only tracking n
From: Richard Haines
Date: Mon, 5 Jun 2017 16:44:40 +0100
> When using CALIPSO with IPPROTO_UDP it is possible to trigger a GPF as the
> IP header may have moved.
>
> Also update the payload length after adding the CALIPSO option.
>
> Signed-off-by: Richard Haines
Applied and queued up for -
From: Ganesh Goudar
Date: Mon, 5 Jun 2017 18:34:20 +0530
> Implement ndo_set_vf_rate() for mgmt interface to support rate-limiting
> of VF traffic using 'ip' command.
>
> Based on the original work of Kumar Sanghvi
>
> Signed-off-by: Ganesh Goudar
Applied to net-next, thanks Ganesh.
From: Colin King
Date: Mon, 5 Jun 2017 10:04:52 +0100
> From: Colin Ian King
>
> The current comparison of entry < 0 will never be true since entry is an
> unsigned integer. Make entry an int to ensure -ve error return values
> from the call to jumbo_frm are correctly being caught.
>
> Detect
From: Joe Perches
Date: Mon, 5 Jun 2017 05:22:50 -0700
> Using this extension reduces the object size.
>
> $ size drivers/net/ppp/ppp_mppe.o*
>text data bss dec hex filename
>5683 216 859071713 drivers/net/ppp/ppp_mppe.o.new
>5808
Begin forwarded message:
Date: Sat, 03 Jun 2017 06:25:05 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 195969] New: ipsec icmp and udp works, tcp doesn't work
https://bugzilla.kernel.org/show_bug.cgi?id=195969
Bug ID: 195969
From: Yuval Shaia
Date: Mon, 5 Jun 2017 10:18:40 +0300
> It's unused, so remove it.
>
> Signed-off-by: Yuval Shaia
> ---
> v0 -> v1:
> * Add commit message
> * Update Documentation/networking/phy.txt
> * Modify commit header message
Applied to net-next, thanks.
From: Alexei Starovoitov
Date: Tue, 6 Jun 2017 11:55:33 -0700
> If in the future mlx will make it into the nic in a way that
> encryption shares all memory management logic and there is no fpga
> at all then it indeed will be similar to tc offload. Right now it's
> not and needs different sw arch
From: Richard Cochran
Date: Tue, 6 Jun 2017 20:39:33 +0200
> On Fri, Jun 02, 2017 at 03:27:41PM +0100, Rafal Ozieblo wrote:
>> drivers/net/ethernet/cadence/macb.c | 3568
>> --
>> drivers/net/ethernet/cadence/macb_main.c | 3568
>> ++
On Tue, Jun 06, 2017 at 02:38:24PM -0400, David Miller wrote:
> From: Alexei Starovoitov
> Date: Tue, 6 Jun 2017 11:34:59 -0700
>
> > fpga is a separate device with its own phy and mac layers, its
> > own queues, packet parsing and rdma logic.
>
> Because that's how they bolted it onto the ASIC
On 05/06/17 08:06, Y Song wrote:
> On Fri, Jun 2, 2017 at 7:42 AM, Edward Cree wrote:
>> Test "helper access to variable memory: stack, bitwise AND + JMP, correct
>> bounds" is listed as expected to pass, but it passes zero in the 'size'
>> argument, an ARG_CONST_SIZE, to bpf_probe_read; I belie
On Fri, Jun 02, 2017 at 03:27:41PM +0100, Rafal Ozieblo wrote:
> drivers/net/ethernet/cadence/macb.c | 3568
> --
> drivers/net/ethernet/cadence/macb_main.c | 3568
> ++
You deleted macb.c, and so ...
> diff --git a/drivers/net/ethern
From: Alexei Starovoitov
Date: Tue, 6 Jun 2017 11:34:59 -0700
> fpga is a separate device with its own phy and mac layers, its
> own queues, packet parsing and rdma logic.
Because that's how they bolted it onto the ASIC in current
implementation, it might not always be that way and be fully
inte
On Tue, Jun 06, 2017 at 08:54:50AM +, Rafal Ozieblo wrote:
> Would "ENOTSUP" be sufficient ?
You mean EOPNOTSUPP? Yes, sounds ok to me. EFAULT is surely wrong.
Thanks,
Richard
Florian Fainelli writes:
> On 06/06/2017 11:09 AM, Vivien Didelot wrote:
>> Florian Fainelli writes:
>>
>>> - phy_mode = of_get_phy_mode(ds->dst->cpu_dp->dn);
>>> + phy_mode = of_get_phy_mode(ds->ports[QCA8K_CPU_PORT].dn);
>>
>> Is it necessary to use QCA8K_CPU_PORT?
>>
>>> +static inline
On Tue, Jun 06, 2017 at 01:47:26PM -0400, David Miller wrote:
> From: Alexei Starovoitov
> Date: Tue, 6 Jun 2017 10:42:35 -0700
>
> > so it's like rdma, but without using kernel rdma stack?
>
> No sockets here, just transformation rules. It's like offloading
> a complex TC rule to hardware vers
On Fri, Jun 02, 2017 at 03:28:10PM +0100, Rafal Ozieblo wrote:
> +static s32 gem_get_ptp_max_adj(void)
> +{
> + return 64E6;
> +}
This is a floating point constant. Please use integer instead.
> +
> +static int gem_get_ts_info(struct net_device *dev,
> +struct ethtool
Hi Florian,
Florian Fainelli writes:
> This patch series prepares the ground for adding mutliple CPU port support to
multiple
> DSA, and starts by removing redundant pieces of information such
On 06/06/2017 11:09 AM, Vivien Didelot wrote:
> Florian Fainelli writes:
>
>> -phy_mode = of_get_phy_mode(ds->dst->cpu_dp->dn);
>> +phy_mode = of_get_phy_mode(ds->ports[QCA8K_CPU_PORT].dn);
>
> Is it necessary to use QCA8K_CPU_PORT?
>
>> +static inline struct dsa_port *dsa_ds_get_cpu_dp
Florian Fainelli writes:
> - phy_mode = of_get_phy_mode(ds->dst->cpu_dp->dn);
> + phy_mode = of_get_phy_mode(ds->ports[QCA8K_CPU_PORT].dn);
Is it necessary to use QCA8K_CPU_PORT?
> +static inline struct dsa_port *dsa_ds_get_cpu_dp(struct dsa_switch *ds)
> +{
> + return &ds->ports[fl
On 06/06/2017 10:24 AM, Vivien Didelot wrote:
> Hi Florian,
>
> Florian Fainelli writes:
>
>> -struct net_device *p = ds->dst[ds->index].master_netdev;
>> +struct net_device *p = ds->dst[ds->index].cpu_dp->netdev;
>
>ds->dst->cpu_dp->netdev
>
> ds->dst i
Florian Fainelli writes:
> Introduce a helper function which will return a reference to the CPU
> port used in a dsa_switch_tree. Right now this is a singleton, but this
> will change once we introduce multi-CPU port support, so ease the
> transition by converting the affected code paths.
>
> Sig
From: Alexei Starovoitov
Date: Tue, 6 Jun 2017 10:42:35 -0700
> so it's like rdma, but without using kernel rdma stack?
No sockets here, just transformation rules. It's like offloading
a complex TC rule to hardware version of that transformation.
Yes, there is state, but I argue that it is no
On Tue, Jun 06, 2017 at 10:17:09AM -0600, Jason Gunthorpe wrote:
> On Tue, Jun 06, 2017 at 06:52:15AM +, Ilan Tayari wrote:
>
> > So neither the host stack nor the network are aware of them.
> > They exist momentarily only on the internal traces on the board and not
> > anywhere else.
>
> Is
Florian Fainelli writes:
> In preparation for supporting multiple CPU ports with DSA, have the
> dsa_slave_priv structure know which CPU it is associated with. This will
dsa_port
> be important in order to make sure the correct CPU is used for
> transmission of the frames. If not for functi
Florian Fainelli writes:
> Relocate master_ethtool_ops and master_orig_ethtool_ops into struct
> dsa_port in order to be both consistent, and make things self contained
> within the dsa_port structure.
>
> This is a preliminary change to supporting multiple CPU port interfaces.
>
> Signed-off-by:
Hi Florian,
Florian Fainelli writes:
> - struct net_device *p = ds->dst[ds->index].master_netdev;
> + struct net_device *p = ds->dst[ds->index].cpu_dp->netdev;
ds->dst->cpu_dp->netdev
ds->dst is not an array anymore, lucky sf2 switch index is always 0 ;-)
1 - 100 of 217 matches
Mail list logo
