Re: [PATCH V2 net 1/1] smc: switch to usage of IB_PD_UNSAFE_GLOBAL_RKEY

2017-05-13 Thread Christoph Hellwig
On Sat, May 13, 2017 at 02:29:48PM +0300, Leon Romanovsky wrote: > I'm glad that you moved to use IB_PD_UNSAFE_GLOBAL_RKEY, so the users > will see the warning in their dmesg log. > > However can you please update your commit log? There is need to add > description of security issue (access to who

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-13 Thread Christoph Hellwig
Dave, this patch has not been superceeded by anything, can you explain why it has been marked as such in patchworks? On Thu, May 11, 2017 at 02:57:43PM +, Bart Van Assche wrote: > On Wed, 2017-05-10 at 09:26 +0200, Christoph Hellwig wrote: > > The driver has a lot of quality issues due to the

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

2017-05-13 Thread David Ahern
On 5/4/17 2:43 PM, Phil Sutter wrote: > So in summary, given that very little change happens to iproute2's > internal libnetlink, I don't see much urge to make it use libmnl as > backend. In my opinion it just adds another potential source of errors. > > Eventually this should be a maintainer leve

[PATCH iproute2] ip: add support for more MPLS labels

2017-05-13 Thread David Ahern
Kernel now supports up to 30 labels but not defined as part of the uapi. iproute2 handles up to 8 labels but in a non-consistent way. Update ip to handle more labels, but in a more programmatic way. For the MPLS address family, the data field in inet_prefix is used for labels. Increase that field

[PATCH] rtlwifi: rtl8723ae:fix spelling mistake: "Coexistance" -> "Coexistence"

2017-05-13 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in RT_TRACE text Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/hw.c b/drivers/net/wir

Re: arch: arm: bpf: Converting cBPF to eBPF for arm 32 bit

2017-05-13 Thread Shubham Bansal
Finally finished testing. "test_bpf: Summary: 314 PASSED, 0 FAILED, [274/306 JIT'ed]" Will send the patch after code refactoring. Thanks for all the help you guys. I really really appreciate it. Special thanks to Kees and Daniel. :) Best, Shubham Bansal On Thu, May 11, 2017 at 9:00 PM, Kees C

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-13 Thread Jan Moskyto Matejka
On Sat, May 13, 2017 at 11:13:38AM -0600, David Ahern wrote: > On 5/13/17 4:54 AM, Jan Moskyto Matejka wrote: > >> I see 2 problems: > >> 1. the kernel is not telling the user the supplied buffer is too small > >> (ie., if a single route does not fit in the skb then it should fail and > >> return a

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-13 Thread David Ahern
On 5/13/17 4:54 AM, Jan Moskyto Matejka wrote: >> I see 2 problems: >> 1. the kernel is not telling the user the supplied buffer is too small >> (ie., if a single route does not fit in the skb then it should fail and >> return an error code to the user), > > Definitely. I want just to note that th

Re: [PATCH v2 net-next 5/5] dsa: add maintainer of Microchip KSZ switches

2017-05-13 Thread Andrew Lunn
On Fri, May 12, 2017 at 08:08:01PM +, woojung@microchip.com wrote: > From: Woojung Huh > > Adding maintainer of Microchip KSZ switches. > > Signed-off-by: Woojung Huh > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > ind

Re: [PATCH v2 net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

2017-05-13 Thread Andrew Lunn
> +static int get_vlan_table(struct dsa_switch *ds, u16 vid, u32 *vlan_table) > +{ > + struct ksz_device *dev = ds->priv; > + u8 data; > + int timeout = 1000; > + > + ksz_write16(dev, REG_SW_VLAN_ENTRY_INDEX__2, vid & VLAN_INDEX_M); > + ksz_write8(dev, REG_SW_VLAN_CTRL, VLAN_REA

Re: [PATCH v2 net-next 4/5] dsa: Add spi support to Microchip KSZ switches

2017-05-13 Thread Andrew Lunn
On Fri, May 12, 2017 at 08:08:00PM +, woojung@microchip.com wrote: > From: Woojung Huh > > A sample SPI configuration for Microchip KSZ switches. > > Signed-off-by: Woojung Huh Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

2017-05-13 Thread Andrew Lunn
On Fri, May 12, 2017 at 08:07:58PM +, woojung@microchip.com wrote: > +static void ksz_config_cpu_port(struct dsa_switch *ds) > +{ > + struct ksz_device *dev = ds->priv; > + int i; > + > + ds->num_ports = dev->port_cnt; > + > + for (i = 0; i < ds->num_ports; i++) { > +

Re: [PATCH v2 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

2017-05-13 Thread Andrew Lunn
On Fri, May 12, 2017 at 08:07:56PM +, woojung@microchip.com wrote: > From: Woojung Huh > > Adding Microchip 9477 Phy included in KSZ9477 Switch. > > Signed-off-by: Woojung Huh Signed-off-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next 1/5] dsa: add support for Microchip KSZ tail tagging

2017-05-13 Thread Andrew Lunn
On Fri, May 12, 2017 at 08:07:54PM +, woojung@microchip.com wrote: > + padlen = (skb->len >= ETH_ZLEN) ? 0 : ETH_ZLEN - skb->len; > + > + if (skb_tailroom(skb) >= padlen + KSZ_INGRESS_TAG_LEN) { > + nskb = skb; > + } else { > + nskb = alloc_skb(NET_IP_ALI

Re: [PATCH V2 net 1/1] smc: switch to usage of IB_PD_UNSAFE_GLOBAL_RKEY

2017-05-13 Thread Leon Romanovsky
On Fri, May 12, 2017 at 07:09:52PM +0200, Ursula Braun wrote: > This patch makes users aware of the current security implications > when using smc. > > The final fix to resolve the reported security issue is worked on; > respective patches will follow as soon as possible. > > Signed-off-by: Ursula

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-13 Thread Jan Moskyto Matejka
On Sat, May 13, 2017 at 12:52:47AM -0600, David Ahern wrote: > On 5/12/17 3:41 PM, Jan Moskyto Matejka wrote: > > On Fri, May 12, 2017 at 10:26:08AM -0700, David Ahern wrote: > >> On 5/12/17 8:24 AM, David Miller wrote: > >>> From: Jan Moskyto Matejka > >>> Date: Fri, 12 May 2017 13:15:10 +0200 >

You Just Won Qatar Foundation Donation**Treat Urgently

2017-05-13 Thread QATAR
Dear Beneficiary, You have been selected to receive (950,000.00 EURO) as charity donations / aid from the Qatar Foundation. Please kindly provide the below information details mention. 1. Your Full Name: 2. Country: 3. Marital Status: 4. Age: 5. Occupation: 6. Telephone: 7. Home Address: Note:

Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries

2017-05-13 Thread Mickaël Salaün
On 13/02/2017 02:43, David Ahern wrote: > On 2/12/17 2:23 PM, Mickaël Salaün wrote: >> diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore >> new file mode 100644 >> index ..a7562a5ef4c2 >> --- /dev/null >> +++ b/samples/bpf/.gitignore >> @@ -0,0 +1,32 @@ >> +fds_example >> +l

Re: [PATCH iproute2 -master 1/2] bpf: update printing of generic xdp mode

2017-05-13 Thread Daniel Borkmann
On 05/13/2017 11:01 AM, Sergei Shtylyov wrote: On 5/13/2017 3:32 AM, Daniel Borkmann wrote: Follow-up to d67b9cd28c1d ("xdp: refine xdp api with regards to generic xdp") in order to update the XDP dumping part. Signed-off-by: Daniel Borkmann --- ip/iplink_xdp.c | 19 +++ 1 fi

Re: [PATCH iproute2 -master 1/2] bpf: update printing of generic xdp mode

2017-05-13 Thread Sergei Shtylyov
Hello! On 5/13/2017 3:32 AM, Daniel Borkmann wrote: Follow-up to d67b9cd28c1d ("xdp: refine xdp api with regards to generic xdp") in order to update the XDP dumping part. Signed-off-by: Daniel Borkmann --- ip/iplink_xdp.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletion