RE: Why do we need MSG_SENDPAGE_NOTLAST?

2017-05-05 Thread Ilya Lesokhin
I don't follow. Why can't splice use MSG_MORE for the individual pages? Why does tcp_sendpage need to know if the MORE indicator is coming from the user or from splice? I also don't understand your comment about partial writes. Thanks, Ilya > -Original Message- > From: Eric Dumazet [mai

[PATCH] net: dsa: loop: Check for memory allocation failure

2017-05-05 Thread Christophe JAILLET
If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. Return -ENOMEM instead, as done for some other memory allocation just a few lines above. Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver") Signed-off-by: Christophe JAILLET --- drivers/net/dsa/dsa_loop.c | 3 +++ 1 file changed, 3 ins

Re: [PATCH net-next 4/5] dsa: Microchip KSZ switches SPI devicetree configuration

2017-05-05 Thread Andrew Lunn
On Fri, May 05, 2017 at 11:18:05PM +, woojung@microchip.com wrote: > From: Woojung Huh > > A sample SPI configuration for Microchip KSZ switches. > > Signed-off-by: Woojung Huh > --- > Documentation/devicetree/bindings/net/dsa/ksz.txt | 73 > +++ > 1 file changed,

Re: [PATCH net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

2017-05-05 Thread Andrew Lunn
> +}, { > + .phy_id = PHY_ID_KSZ9477, > + .phy_id_mask= MICREL_PHY_ID_MASK, > + .name = "Microchip KSZ9477", > + .features = PHY_GBIT_FEATURES, > + .flags = PHY_HAS_MAGICANEG, Is this magic still used anywhere? I could not find anything.

Re: [PATCH net-next 1/5] dsa: add support for Microchip KSZ tail tagging

2017-05-05 Thread Andrew Lunn
> +static struct sk_buff *ksz_xmit(struct sk_buff *skb, struct net_device *dev) > +{ > + struct dsa_slave_priv *p = netdev_priv(dev); > + struct sk_buff *nskb; > + int padlen; > + u8 *tag; > + > + padlen = 0; > + if (skb->len < 60) > + padlen = 60 - skb->len; > +

[PATCH] bonding: make multi if nla_put_failure check into one

2017-05-05 Thread Hangbin Liu
Signed-off-by: Hangbin Liu --- drivers/net/bonding/bond_netlink.c | 148 + 1 file changed, 52 insertions(+), 96 deletions(-) diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c index 47a8103..e745ca3 100644 --- a/drivers/net/b

[PATCH] bonding: check nla_put_be32 return value

2017-05-05 Thread Hangbin Liu
Signed-off-by: Hangbin Liu --- drivers/net/bonding/bond_netlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c index c502c13..47a8103 100644 --- a/drivers/net/bonding/bond_netlink.c +++ b/drivers/net

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

2017-05-05 Thread Ding Tianhong
On 2017/5/5 22:04, Alexander Duyck wrote: > On Thu, May 4, 2017 at 2:01 PM, Casey Leedom wrote: >> | From: Alexander Duyck >> | Sent: Wednesday, May 3, 2017 9:02 AM >> | ... >> | It sounds like we are more or less in agreement. My only concern is >> | really what we default this to. On x86 I wo

Re: bpf pointer alignment validation

2017-05-05 Thread David Miller
From: David Miller Date: Fri, 05 May 2017 16:20:44 -0400 (EDT) > Anyways, I'll play with this design and see what happens... > Feedback is of course welcome. Here is a prototype that works for me with test_pkt_access.c, which otherwise won't load on sparc. diff --git a/include/linux/bpf_verifie

Re: [PATCH net] bnxt_en: allocate enough space for ->ntp_fltr_bmap

2017-05-05 Thread Michael Chan
On Fri, May 5, 2017 at 5:49 PM, Dan Carpenter wrote: > We have the number of longs, but we need to calculate the number of > bytes required. > > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") > Signed-off-by: Dan Carpenter Acked-by: Michael Chan David, please send this to -stab

[PATCH net] bnxt_en: allocate enough space for ->ntp_fltr_bmap

2017-05-05 Thread Dan Carpenter
We have the number of longs, but we need to calculate the number of bytes required. Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index b3ba66032980..

RE: [PATCH net-next 1/5] dsa: add support for Microchip KSZ tail tagging

2017-05-05 Thread Woojung.Huh
> > + padlen = 0; > > + if (skb->len < 60) > > + padlen = 60 - skb->len; > > Can you use ETH_ZLEN instead of 60 such that it is clear this is padding > to a minimum packet size (minus FCS)? > > > + > > + nskb = alloc_skb(NET_IP_ALIGN + skb->len + padlen + 2, > GFP_ATOMIC); > > Ca

Re: [PATCH net-next 1/5] dsa: add support for Microchip KSZ tail tagging

2017-05-05 Thread Florian Fainelli
On 05/05/2017 04:17 PM, woojung@microchip.com wrote: > From: Woojung Huh > > Adding support for the Microchip KSZ switch family tail tagging. > > Signed-off-by: Woojung Huh > --- > include/net/dsa.h | 1 + > net/dsa/Kconfig| 3 ++ > net/dsa/Makefile | 1 + > net/dsa/dsa.c |

[PATCH net-next 3/5] dsa: add DSA switch driver for Microchip KSZ9477

2017-05-05 Thread Woojung.Huh
From: Woojung Huh The KSZ9477 is a fully integrated layer 2, managed, 7 ports GigE switch with numerous advanced features. 5 ports incorporate 10/100/1000 Mbps PHYs. The other 2 ports have interfaces that can be configured as SGMII, RGMII, MII or RMII. Either of these may connect directly to a ho

[PATCH net-next 5/5] dsa: add maintainer of Microchip KSZ switches

2017-05-05 Thread Woojung.Huh
From: Woojung Huh Adding maintainer of Microchip KSZ switches. Signed-off-by: Woojung Huh --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 45b173a..e65e501 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8370,6 +8370,15 @@ F: dri

[PATCH net-next 0/5] dsa: add Microchip KSZ9477 DSA driver

2017-05-05 Thread Woojung.Huh
From: Woojung Huh This series of patches is for Microchip KSZ9477 DSA driver. KSZ9477 is 7 ports GigE switch with numerous advanced features. 5 ports are 10/100/1000 Mbps internal PHYs and 2 ports have Interfaces to SGMII, RGMII, MII or RMII. This patch supports VLAN, MDB, FDB and port mirroring

[PATCH net-next 4/5] dsa: Microchip KSZ switches SPI devicetree configuration

2017-05-05 Thread Woojung.Huh
From: Woojung Huh A sample SPI configuration for Microchip KSZ switches. Signed-off-by: Woojung Huh --- Documentation/devicetree/bindings/net/dsa/ksz.txt | 73 +++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/dsa/ksz.txt diff -

[PATCH net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

2017-05-05 Thread Woojung.Huh
From: Woojung Huh Adding Microchip 9477 Phy included in KSZ9477 Switch. Signed-off-by: Woojung Huh --- drivers/net/phy/micrel.c | 12 include/linux/micrel_phy.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 6a5

[PATCH net-next 1/5] dsa: add support for Microchip KSZ tail tagging

2017-05-05 Thread Woojung.Huh
From: Woojung Huh Adding support for the Microchip KSZ switch family tail tagging. Signed-off-by: Woojung Huh --- include/net/dsa.h | 1 + net/dsa/Kconfig| 3 ++ net/dsa/Makefile | 1 + net/dsa/dsa.c | 3 ++ net/dsa/dsa_priv.h | 3 ++ net/dsa/tag_ksz.c | 98 ++

Re: [PATCH/RFC net-next v2 4/4] net/sched: cls_flower: allow control of tree traversal on packet parse errors

2017-05-05 Thread Cong Wang
On Fri, May 5, 2017 at 5:47 AM, Simon Horman wrote: > > # tc qdisc del dev eth0 ingress; tc qdisc add dev eth0 ingress > # tc filter add dev eth0 protocol ip parent : flower \ >indev eth0 ip_proto udp dst_port 80 truncated drop action continue > [...] > @@ -188,7 +189,7 @@ static int

[PATCH] ray_cs: Avoid reading past end of buffer

2017-05-05 Thread Kees Cook
Using memcpy() from a buffer that is shorter than the length copied means the destination buffer is being filled with arbitrary data from the kernel rodata segment. In this case, the source was made longer, since it did not match the destination structure size. Additionally removes a needless cast.

[PATCH] qlge: Avoid reading past end of buffer

2017-05-05 Thread Kees Cook
Using memcpy() from a string that is shorter than the length copied means the destination buffer is being filled with arbitrary data from the kernel rodata segment. Instead, use strncpy() which will fill the trailing bytes with zeros. This was found with the future CONFIG_FORTIFY_SOURCE feature.

[PATCH] bna: ethtool: Avoid reading past end of buffer

2017-05-05 Thread Kees Cook
Using memcpy() from a string that is shorter than the length copied means the destination buffer is being filled with arbitrary data from the kernel rodata segment. Instead, use strncpy() which will fill the trailing bytes with zeros. This was found with the future CONFIG_FORTIFY_SOURCE feature.

[PATCH] bna: Avoid reading past end of buffer

2017-05-05 Thread Kees Cook
Using memcpy() from a string that is shorter than the length copied means the destination buffer is being filled with arbitrary data from the kernel rodata segment. Instead, use strncpy() which will fill the trailing bytes with zeros. This was found with the future CONFIG_FORTIFY_SOURCE feature.

[PATCH v4 net-next 0/2] rtnetlink: Updates to rtnetlink_event()

2017-05-05 Thread Vladislav Yasevich
This is a version 4 series came out of the conversation that started as a result my first attempt to add netdevice event info to netlink messages. First is the patch to add IFLA_EVENT attribute to the netlink message. It supports only currently white-listed events. Like before, this is just an at

[PATCH V4 net-next 2/2] bonding: Prevent duplicate userspace notification

2017-05-05 Thread Vladislav Yasevich
Whenever a user changes bonding options, a NETDEV_CHANGEINFODATA notificatin is generated which results in a rtnelink message to be sent. While runnig 'ip monitor', we can actually see 2 messages, one a result of the event, and the other a result of state change that is generated bo netdev_state_c

[PATCH V3 net-next 1/2] rtnl: Add support for netdev event to link messages

2017-05-05 Thread Vladislav Yasevich
When netdev events happen, a rtnetlink_event() handler will send messages for every event in it's white list. These messages contain current information about a particular device, but they do not include the iformation about which event just happened. So, it is impossible to tell what just happen

Re: [PATCH v2] vlan: Keep NETIF_F_HW_CSUM similar to other software devices

2017-05-05 Thread Alexander Duyck
On Fri, May 5, 2017 at 1:17 PM, Vladislav Yasevich wrote: > Vlan devices, like all other software devices, enable > NETIF_F_HW_CSUM feature. However, unlike all the othe other > software devices, vlans will switch to using IP|IPV6_CSUM > features, if the underlying devices uses them. In these si

bpf pointer alignment validation

2017-05-05 Thread David Miller
Alexei and Daniel, I just wanted to let you guys know that I'm working on an alignment tracker in the BPF verifier. After trying several approaches I think what is going to work is to maintain state like this: 1) For non-pointer registers, we record what we can prove is the minimum alignment

Re: [PATCH v5 04/20] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon

2017-05-05 Thread Rob Herring
On Mon, May 01, 2017 at 02:45:04PM +0200, Corentin Labbe wrote: > This patch adds documentation for Device-Tree bindings for the > syscon present in allwinner devices. > > Signed-off-by: Corentin Labbe > --- > .../devicetree/bindings/misc/allwinner,syscon.txt | 19 > +++ > 1

[PATCH v2] vlan: Keep NETIF_F_HW_CSUM similar to other software devices

2017-05-05 Thread Vladislav Yasevich
Vlan devices, like all other software devices, enable NETIF_F_HW_CSUM feature. However, unlike all the othe other software devices, vlans will switch to using IP|IPV6_CSUM features, if the underlying devices uses them. In these situations, checksum offload features on the vlan device can't be con

Re: [PATCH] vlan: Keep NETIF_F_HW_CSUM similar to other software devices

2017-05-05 Thread Vlad Yasevich
On 05/05/2017 04:01 PM, Alexander Duyck wrote: > On Fri, May 5, 2017 at 12:20 PM, Vladislav Yasevich > wrote: >> Vlan devices, like all other software devices, enable >> NETIF_F_HW_CSUM feature. However, unlike all the othe other >> software devices, vlans will switch to using IP|IPV6_CSUM >> fe

Re: [PATCH] vlan: Keep NETIF_F_HW_CSUM similar to other software devices

2017-05-05 Thread Alexander Duyck
On Fri, May 5, 2017 at 12:20 PM, Vladislav Yasevich wrote: > Vlan devices, like all other software devices, enable > NETIF_F_HW_CSUM feature. However, unlike all the othe other > software devices, vlans will switch to using IP|IPV6_CSUM > features, if the underlying devices uses them. In these s

[PATCH net] tcp: make congestion control optionally skip slow start after idle

2017-05-05 Thread Wei Wang
From: Wei Wang Congestion control modules that want full control over congestion control behavior do not want the cwnd modifications controlled by the sysctl_tcp_slow_start_after_idle code path. So skip those code paths for CC modules that use the cong_control() API. As an example, those cwnd eff

Re: [PATCH v4 binutils] Add BPF support to binutils...

2017-05-05 Thread David Miller
From: David Miller Date: Mon, 01 May 2017 23:51:58 -0400 (EDT) > From: Alexei Starovoitov > Date: Mon, 1 May 2017 20:49:21 -0700 > >> (gdb) x/10i bpf_prog1 >>0x0 : ldimm64 r0, 590618314553 >>0x10 : stdw[r1+-8], r10 >>0x18 : lddwr10, [r1+-8] >>0x20 : add

[PATCH] vlan: Keep NETIF_F_HW_CSUM similar to other software devices

2017-05-05 Thread Vladislav Yasevich
Vlan devices, like all other software devices, enable NETIF_F_HW_CSUM feature. However, unlike all the othe other software devices, vlans will switch to using IP|IPV6_CSUM features, if the underlying devices uses them. In these situations, checksum offload features on the vlan device can't be con

Re: [PATCH v4 binutils] Add BPF support to binutils...

2017-05-05 Thread David Miller
From: Alexei Starovoitov Date: Fri, 5 May 2017 11:24:19 -0700 > Yonghong fixed llvm bug with big-endian dwarf [1] > and binutils worked out of the box :) > > $ ./bin/clang -O2 -target bpfeb -c -g test.c > $ /w/binutils-gdb/bld/binutils/objdump -S test.o > > test.o: file format elf64-bpfbe >

Re: [PATCH] net: alx: handle pci_alloc_irq_vectors return correctly

2017-05-05 Thread David Miller
From: Rakesh Pandit Date: Fri, 5 May 2017 14:28:23 +0300 > It was introduced while switching to pci_alloc_irq_vectors recently > and fixes: ... > Fixes: f3297f68 ("net: alx: switch to pci_alloc_irq_vectors") > Signed-off-by: Rakesh Pandit Applied, thanks.

Re: [RFC iproute2 0/8] RDMA tool

2017-05-05 Thread Bart Van Assche
On Thu, 2017-05-04 at 21:45 +0300, Leon Romanovsky wrote: > It is not hard to create new tool, the hardest part is to ensure that it is > part of the distributions. Did you count how many months we are trying to > add rdma-core to debian? Hello Leon, Sorry but I was not aware that the effort to a

Re: [PATCH v4 binutils] Add BPF support to binutils...

2017-05-05 Thread Alexei Starovoitov
On 5/1/17 8:49 PM, Alexei Starovoitov wrote: On 4/30/17 9:07 AM, David Miller wrote: This is mainly a synchronization point, I still need to look more deeply into Alexei's -g issue. New in this version from v3: - Remove tailcall from opcode table - Rearrange relocations so that numbers match

admin

2017-05-05 Thread administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar subuzón de correo electrónico. Para revalidar su buzón de corre

Re: net/smc and the RDMA core

2017-05-05 Thread Jason Gunthorpe
On Fri, May 05, 2017 at 07:06:56PM +0200, Ursula Braun wrote: > We do not see that just loading the smc module causes this issue.The security > risk starts with the first connection, that actually uses smc. This is only > possible if an AF_SMC socket connection is created while the so-called > pne

Re: net/smc and the RDMA core

2017-05-05 Thread Ursula Braun
On 05/04/2017 05:31 PM, Jason Gunthorpe wrote: > On Thu, May 04, 2017 at 03:08:39PM +0200, Ursula Braun wrote: >> >> >> On 05/04/2017 10:48 AM, h...@lst.de wrote: >>> On Thu, May 04, 2017 at 11:43:50AM +0300, Sagi Grimberg wrote: I would also suggest that you stop exposing the DMA MR for rem

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

2017-05-05 Thread Mike Manning
On 03/05/17 19:24, Mike Manning wrote: > On 03/05/17 18:58, Cong Wang wrote: >> On Tue, May 2, 2017 at 11:30 AM, Mike Manning wrote: >>> While this is not reproducible manually, Andrey's syzkaller program hit >>> the warning "IPv6: Freeing alive inet6 address" with this part trace: >>> >>> inet6_i

Re: [patch iproute2 v2 0/2] devlink: Add support for pipeline

2017-05-05 Thread Stephen Hemminger
On Wed, 3 May 2017 13:25:21 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Arkadi says: > > Add support for pipeline debug (dpipe). As a preparation step the netlink > attribute validation was changed before adding new dpipe attributes. > --- > v1->v2 > - Change netlink attribute validation.

Re: [PATCH iproute] tc: Reflect HW offload status

2017-05-05 Thread Stephen Hemminger
On Thu, 4 May 2017 16:15:15 +0300 Or Gerlitz wrote: > Currently there is no way of querying whether a filter is > offloaded to HW or not when using "both" policy (where none > of skip_sw or skip_hw flags are set by user-space). > > Add two new flags, "in hw" and "not in hw" such that user > spa

Re: [PATCH iproute2] vxlan: Add support for modifying vxlan device attributes

2017-05-05 Thread Stephen Hemminger
On Thu, 4 May 2017 17:26:23 -0700 Girish Moodalbail wrote: > On 5/4/17 5:07 PM, Stephen Hemminger wrote: > > On Thu, 4 May 2017 14:46:34 -0700 > > Girish Moodalbail wrote: > > > >> Ability to change vxlan device attributes was added to kernel through > >> commit 8bcdc4f3a20b ("vxlan: add chan

Re: [PATCH] misplaced EXPORT_SYMBOL_GPL(ping_hash) in net/ipv4/ping.c

2017-05-05 Thread David Miller
From: Vladis Dronov Date: Fri, 5 May 2017 18:17:16 +0200 > Move misplaced EXPORT_SYMBOL_GPL(ping_hash) to a proper place. > > Signed-off-by: Vladis Dronov Please use a proper subject line with an appropriate subsystem prefix. Also you must indicate the intended target tree (net or net-next)

Re: [PATCH net-next] ibmvnic: Track state of adapter napis

2017-05-05 Thread David Miller
From: John Allen Date: Fri, 5 May 2017 11:31:58 -0500 > Track the state of ibmvnic napis. The driver can get into states where it > can be reset when napis are already disabled and attempting to disable them > again will cause the driver to hang. > > Signed-off-by: John Allen The net-next tree

[PATCH net-next] ibmvnic: Track state of adapter napis

2017-05-05 Thread John Allen
Track the state of ibmvnic napis. The driver can get into states where it can be reset when napis are already disabled and attempting to disable them again will cause the driver to hang. Signed-off-by: John Allen --- diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmv

[PATCH] misplaced EXPORT_SYMBOL_GPL(ping_hash) in net/ipv4/ping.c

2017-05-05 Thread Vladis Dronov
Move misplaced EXPORT_SYMBOL_GPL(ping_hash) to a proper place. Signed-off-by: Vladis Dronov --- Actually, this is so small and unimportant (it just hurts my perfectionism), so does not worth a separate patch. Please, feel free to make it a part of some patch of yours. net/ipv4/ping.c | 2 +- 1

Question about packet_mmap & huge pages

2017-05-05 Thread DESBRUS Maxime
Hello, I am currently evaluating various 0-copy packet capture frameworks on Linux. One of them is packet mmap, provided by the mainline Linux kernel. I want to capture on one network interface with several raw sockets, each being used in a dedicated thread (to spread the processing load on seve

Re: [PATCH v3 net] tcp: randomize timestamps on syncookies

2017-05-05 Thread David Miller
From: Eric Dumazet Date: Fri, 05 May 2017 06:56:54 -0700 > From: Eric Dumazet > > Whole point of randomization was to hide server uptime, but an attacker > can simply start a syn flood and TCP generates 'old style' timestamps, > directly revealing server jiffies value. > > Also, TSval sent by

admin

2017-05-05 Thread administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar subuzón de correo electrónico. Para revalidar su buzón de corre

Re: [PATCH net] bridge: netlink: account for IFLA_BRPORT_{B,M}CAST_FLOOD size and policy

2017-05-05 Thread David Miller
From: Tobias Klauser Date: Fri, 5 May 2017 16:36:53 +0200 > The attribute sizes for IFLA_BRPORT_MCAST_FLOOD and > IFLA_BRPORT_BCAST_FLOOD weren't accounted for in br_port_info_size() > when they were added. Do so now and also add the corresponding policy > entries: > > Cc: Nikolay Aleksandrov

Re: [PATCH net] bridge: netlink: account for IFLA_BRPORT_{B,M}CAST_FLOOD size and policy

2017-05-05 Thread Nikolay Aleksandrov
On 05/05/17 17:36, Tobias Klauser wrote: > The attribute sizes for IFLA_BRPORT_MCAST_FLOOD and > IFLA_BRPORT_BCAST_FLOOD weren't accounted for in br_port_info_size() > when they were added. Do so now and also add the corresponding policy > entries: > > Cc: Nikolay Aleksandrov > Cc: Mike Manning

Re: [PATCH 0/4] TI Bluetooth serdev support

2017-05-05 Thread Adam Ford
On Sun, Apr 30, 2017 at 11:04 AM, Sebastian Reichel wrote: > Hi, > > On Sun, Apr 30, 2017 at 10:14:20AM -0500, Adam Ford wrote: >> On Wed, Apr 5, 2017 at 1:30 PM, Rob Herring wrote: >> > This series adds serdev support to the HCI LL protocol used on TI BT >> > modules and enables support on HiKey

Re: [PATCH] xen-netfront: avoid crashing on resume after a failure in talk_to_netback()

2017-05-05 Thread Vitaly Kuznetsov
David Miller writes: > From: Vitaly Kuznetsov > Date: Thu, 4 May 2017 14:23:04 +0200 > >> Unavoidable crashes in netfront_resume() and netback_changed() after a >> previous fail in talk_to_netback() (e.g. when we fail to read MAC from >> xenstore) were discovered. The failure path in talk_to_ne

[PATCH net] bridge: netlink: account for IFLA_BRPORT_{B,M}CAST_FLOOD size and policy

2017-05-05 Thread Tobias Klauser
The attribute sizes for IFLA_BRPORT_MCAST_FLOOD and IFLA_BRPORT_BCAST_FLOOD weren't accounted for in br_port_info_size() when they were added. Do so now and also add the corresponding policy entries: Cc: Nikolay Aleksandrov Cc: Mike Manning Fixes: b6cb5ac8331b ("net: bridge: add per-port multica

[PATCHv4] wlcore: add wl1285 compatible

2017-05-05 Thread Sebastian Reichel
Motorola Droid 4 uses a WL1285C. With differences between the chips not being public let's add explicit binding for wl1285 instead of relying on wl1283 being very similar. Reviewed-by: Rob Herring Acked-by: Kalle Valo Acked-by: Tony Lindgren Signed-off-by: Sebastian Reichel --- Hi Dave, I pre

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

2017-05-05 Thread Alexander Duyck
On Thu, May 4, 2017 at 2:01 PM, Casey Leedom wrote: > | From: Alexander Duyck > | Sent: Wednesday, May 3, 2017 9:02 AM > | ... > | It sounds like we are more or less in agreement. My only concern is > | really what we default this to. On x86 I would say we could probably > | default this to disab

[PATCH v3 net] tcp: randomize timestamps on syncookies

2017-05-05 Thread Eric Dumazet
From: Eric Dumazet Whole point of randomization was to hide server uptime, but an attacker can simply start a syn flood and TCP generates 'old style' timestamps, directly revealing server jiffies value. Also, TSval sent by the server to a particular remote address vary depending on syncookies be

Re: [PATCH net-next ] tcp: add new parameter tcp_inherit_buffsize to control the initial buffer size for new passive connetion

2017-05-05 Thread Eric Dumazet
On Fri, 2017-05-05 at 18:22 +0800, 单卫 wrote: > > > 2017-05-02 23:05 GMT+08:00 Eric Dumazet : > > > Hi Shan > > 1) Your patch never reached netdev, because it was sent in > HTML format. > > 2) During Linus merge window, net-next i

[PATCH v4 1/4] can: m_can: move Message RAM initialization to function

2017-05-05 Thread Quentin Schulz
To avoid possible ECC/parity checksum errors when reading an uninitialized buffer, the entire Message RAM is initialized when probing the driver. This initialization is done in the same function reading the Device Tree properties. This patch moves the RAM initialization to a separate function so i

[PATCH v4 3/4] can: m_can: factorize clock gating and ungating

2017-05-05 Thread Quentin Schulz
This creates a function to ungate M_CAN clocks and another to gate the same clocks, then swaps all gating/ungating code with their respective function. Signed-off-by: Quentin Schulz --- added in v4 drivers/net/can/m_can/m_can.c | 45 +-- 1 file changed,

[PATCH v4 2/4] can: m_can: make m_can_start and m_can_stop symmetric

2017-05-05 Thread Quentin Schulz
This moves clocks gating outside of the m_can_stop function as the m_can_start function does not (and cannot, at least in current implementation) ungate clocks. This way, both functions can now be used symmetrically. Signed-off-by: Quentin Schulz --- added in v4 drivers/net/can/m_can/m_can.c |

[PATCH v4 4/4] can: m_can: add deep Suspend/Resume support

2017-05-05 Thread Quentin Schulz
This adds Power Management deep Suspend/Resume support for Bosch M_CAN chip. When entering deep sleep, the clocks are gated, the interrupts are disabled. When resuming from deep sleep, the chip needs to be reinitialized, the clocks ungated and the interrupts enabled. Signed-off-by: Quentin Schulz

Re: [PATCH v2 net] tcp: randomize timestamps on syncookies

2017-05-05 Thread Eric Dumazet
On Fri, 2017-05-05 at 11:36 +0200, Florian Westphal wrote: > Eric Dumazet wrote: > > From: Eric Dumazet > > > > Whole point of randomization was to hide server uptime, but an attacker > > can simply start a syn flood and TCP generates 'old style' timestamps, > > directly revealing server jiffies

Re: [RFC iproute2 0/8] RDMA tool

2017-05-05 Thread Leon Romanovsky
On Fri, May 05, 2017 at 08:54:57AM +0200, Jiri Benc wrote: > On Thu, 4 May 2017 21:02:08 +0300, Leon Romanovsky wrote: > > In order to close object model, ensure reuse of existing code and make this > > tool usable from day one, we decided to implement wrappers over legacy sysfs > > prior to imple

[PATCH/RFC iproute2/net-next v2 1/2] tc: flower: update headers for TCA_FLOWER_META_TRUNCATED

2017-05-05 Thread Simon Horman
This change is proposed for net-next. Signed-off-by: Simon Horman --- include/linux/pkt_cls.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h index f1129e383b2a..dfbd5137e275 100644 --- a/include/linux/pkt_cls.h +++ b/include/linux/pkt_cls.

[PATCH/RFC iproute2/net-next v2 2/2] tc: flower: allow control of tree traversal on packet parse errors

2017-05-05 Thread Simon Horman
Allow control how the tree of qdisc, classes and filters is further traversed if an error is encountered when parsing the packet in order to match the cls_flower filters at a particular prio. By default continue to the next filter, the behaviour without this patch. A use-case for this is to allow

[PATCH/RFC iproute2/net-next v2 0/2] tc: flower: allow control of tree traversal on packet parse errors

2017-05-05 Thread Simon Horman
Hi, this series is intended to allow control how the tree of qdisc, classes and filters is further traversed if an error is encountered when parsing the packet in order to match the cls_flower filters at a particular prio. Please see the changelog of the last patch of this series for a more detai

[PATCH/RFC net-next v2 2/4] flow dissector: return error on icmp dissection under-run

2017-05-05 Thread Simon Horman
Return an error from __skb_flow_dissect() if insufficient packet data is present when dissecting icmp type and code. Without this patch the absence of the ICMP type and code in truncated ICMPv4 or IPVPv6 packets is treated the way same as the presence of a code and type of value of zero. And with

[PATCH/RFC net-next v2 0/4] net/sched: cls_flower: avoid false matching of truncated packets

2017-05-05 Thread Simon Horman
Hi, this series is intended to avoid false-positives which match truncated packets against flower classifiers which match on: * zero L4 ports or; * zero ICMP code or type This requires updating the flow dissector to return an error in such cases and updating flower to not match on the result of a

[PATCH/RFC net-next v2 4/4] net/sched: cls_flower: allow control of tree traversal on packet parse errors

2017-05-05 Thread Simon Horman
Allow control how the tree of qdisc, classes and filters is further traversed if an error is encountered when parsing the packet in order to match the cls_flower filters at a particular prio. By default continue to the next filter, the behaviour without this patch. A use-case for this is to allow

[PATCH/RFC net-next v2 3/4] net/sched: cls_flower: do not match if dissection fails

2017-05-05 Thread Simon Horman
If the flow skb_flow_dissect() returns an error it indicates that dissection was incomplete for some reason. Matching using the result of an incomplete dissection may cause unexpected results. For example: * A match on zero layer 4 ports will also match packets truncated at the end of the IP hea

[PATCH/RFC net-next v2 1/4] flow dissector: return error on port dissection under-run

2017-05-05 Thread Simon Horman
Return an error from __skb_flow_dissect() if insufficient packet data is present when dissecting layer 4 ports. Without this patch the absence of ports in truncated - e.g. UDP - packets is treated the same way by the flow dissector as the presence of ports with a value of zero. And without this pa

Re: FEC on i.MX 7 transmit queue timeout

2017-05-05 Thread Andrew Lunn
> No, it is not workaround. As i said, quque1 and queue2 are for AVB paths > have higher priority in transmition. Does this higher priority result in the low priority queue being starved? Is that why the timer goes off? What happens when somebody does use AVB. Are we back to the same problem? Thi

Re: net/key: slab-out-of-bounds in pfkey_compile_policy

2017-05-05 Thread Andrey Konovalov
On Fri, May 5, 2017 at 11:11 AM, Steffen Klassert wrote: > On Tue, May 02, 2017 at 06:45:03PM +0200, Andrey Konovalov wrote: >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> On commit d3b5d35290d729a2518af00feca867385a1b08fa (4.11). >> >> A reproducer

Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver

2017-05-05 Thread Corentin Labbe
On Mon, May 01, 2017 at 02:45:00PM +0200, Corentin Labbe wrote: > Hello > > This patch series add the driver for dwmac-sun8i which handle the Ethernet MAC > present on Allwinner H3/H5/A83T/A64 SoCs. > > This driver is the continuation of the sun8i-emac driver. > During the development, it appeare

Re: [PATCH v3 2/2] can: m_can: add deep Suspend/Resume support

2017-05-05 Thread Marc Kleine-Budde
On 05/05/2017 01:46 PM, Quentin Schulz wrote: > This adds Power Management deep Suspend/Resume support for Bosch M_CAN > chip. > > When entering deep sleep, the clocks are gated, the interrupts are > disabled. When resuming from deep sleep, the chip needs to be > reinitialized, the clocks ungated

[PATCH v3 1/2] can: m_can: move Message RAM initialization to function

2017-05-05 Thread Quentin Schulz
To avoid possible ECC/parity checksum errors when reading an uninitialized buffer, the entire Message RAM is initialized when probing the driver. This initialization is done in the same function reading the Device Tree properties. This patch moves the RAM initialization to a separate function so i

[PATCH v3 2/2] can: m_can: add deep Suspend/Resume support

2017-05-05 Thread Quentin Schulz
This adds Power Management deep Suspend/Resume support for Bosch M_CAN chip. When entering deep sleep, the clocks are gated, the interrupts are disabled. When resuming from deep sleep, the chip needs to be reinitialized, the clocks ungated and the interrupts enabled. Signed-off-by: Quentin Schulz

[PATCH] net: alx: handle pci_alloc_irq_vectors return correctly

2017-05-05 Thread Rakesh Pandit
It was introduced while switching to pci_alloc_irq_vectors recently and fixes: [ 60.527052] alx :03:00.0 enp3s0: Enabling MSI-X interrupts failed! [ 60.529323] BUG: unable to handle kernel NULL pointer dereference at 00b8 [ 60.531589] IP: alx_alloc_napis+0xe6/0x1e0 [alx] [

RE: Question about SOCK_SEQPACKET

2017-05-05 Thread David Laight
From: Steven Whitehouse > Sent: 05 May 2017 11:34 ... > Just before the part that you've quoted, the description for > SOCK_SEQPACKET says: > "The SOCK_SEQPACKET socket type is similar to the SOCK_STREAM type, and > is also connection-oriented. The only difference between these types is > that reco

Re: Question about SOCK_SEQPACKET

2017-05-05 Thread Steven Whitehouse
Hi, On 05/05/17 11:09, Sowmini Varadhan wrote: On (05/05/17 10:45), Steven Whitehouse wrote: I do wonder if the man page for recvmsg is wrong, or at least a bit confusing. SOCK_SEQPACKET is stream based not message based - it just happens to have EOR markers in the stream. There is no reason t

RE: SSE instructions for fast packet copy?

2017-05-05 Thread David Laight
From: Tom Herbert > Sent: 05 May 2017 06:51 > To: Linux Kernel Network Developers > Subject: SSE instructions for fast packet copy? > > Hi, > > I am thinking about the possibility of using SSE in kernel for > speeding up the kernel memcpy particularly for copy to userspace > emeory, and maybe eve

Re: [PATCH 0/9] net: thunderx: Adds XDP support

2017-05-05 Thread Sunil Kovvuri
On Thu, May 4, 2017 at 2:09 AM, Rami Rosen wrote: > Thanks, Sunil. > >>with network stack: 0.32 Mpps >>with XDP (XDP_TX): 3 Mpps >>and XDP_DROP: 3.8 Mpps > > Interesting; May I ask - which packet size did you use ? Packet size is 64bytes. Thanks, Sunil. > > Regards, > Rami Rosen

Re: Question about SOCK_SEQPACKET

2017-05-05 Thread Sowmini Varadhan
On (05/05/17 10:45), Steven Whitehouse wrote: > > I do wonder if the man page for recvmsg is wrong, or at least a bit > confusing. SOCK_SEQPACKET is stream based not message based - it just > happens to have EOR markers in the stream. There is no reason that the whole > message needs to be returne

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-05 Thread Amir Goldstein
On Fri, May 5, 2017 at 12:57 PM, Christoph Hellwig wrote: > On Fri, May 05, 2017 at 12:50:31PM +0300, Amir Goldstein wrote: >> To complete the picture for folks not cc'ed on my patches, >> xfs use case suggests there is also justification for the additional helpers: >> >> uuid_is_null() / uuid_equ

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-05 Thread Christoph Hellwig
On Fri, May 05, 2017 at 12:50:31PM +0300, Amir Goldstein wrote: > To complete the picture for folks not cc'ed on my patches, > xfs use case suggests there is also justification for the additional helpers: > > uuid_is_null() / uuid_equal() > guid_is_null() / guid_equal() The is_null is useful and

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-05 Thread Amir Goldstein
On Fri, May 5, 2017 at 12:24 PM, Andy Shevchenko wrote: > On Fri, 2017-05-05 at 10:06 +0300, Amir Goldstein wrote: [...] >> I think with this semantic change, our proposals can reach common >> grounds >> and satisfy a wider group of users (i.e. filesystem developers). >> >> Christoph also suggeste

Re: [PATCH] mac80211: Create ieee80211_if_process_skb from ieee80211_iface_work

2017-05-05 Thread Joe Perches
On Fri, 2017-05-05 at 11:39 +0200, Johannes Berg wrote: > On Fri, 2017-05-05 at 02:34 -0700, Joe Perches wrote: > > On Fri, 2017-05-05 at 11:06 +0200, Johannes Berg wrote: > > > > o Use explicit casts to proper types instead of casts to (void *) > > > >   and have the compiler do the implicit cast

Re: Question about SOCK_SEQPACKET

2017-05-05 Thread Steven Whitehouse
Hi, On 05/05/17 06:18, Sam Kumar wrote: Hello, I have recently had occasion to use SOCK_SEQPACKET sockets on Linux, and noticed some odd behavior. When using sendmsg and recvmsg with these sockets, it seems that the "end-of-record" flag (MSG_EOR) is not being propagated correctly. It depends wh

Re: [PATCH] mac80211: Create ieee80211_if_process_skb from ieee80211_iface_work

2017-05-05 Thread Johannes Berg
On Fri, 2017-05-05 at 02:34 -0700, Joe Perches wrote: > On Fri, 2017-05-05 at 11:06 +0200, Johannes Berg wrote: > > > o Use explicit casts to proper types instead of casts to (void *) > > >   and have the compiler do the implicit cast > > > > I see no advantage in this, why? All it does is make th

Re: [PATCH v2 net] tcp: randomize timestamps on syncookies

2017-05-05 Thread Florian Westphal
Eric Dumazet wrote: > From: Eric Dumazet > > Whole point of randomization was to hide server uptime, but an attacker > can simply start a syn flood and TCP generates 'old style' timestamps, > directly revealing server jiffies value. > > Also, TSval sent by the server to a particular remote addr

Re: [PATCH] mac80211: Create ieee80211_if_process_skb from ieee80211_iface_work

2017-05-05 Thread Joe Perches
On Fri, 2017-05-05 at 11:06 +0200, Johannes Berg wrote: > > o Use explicit casts to proper types instead of casts to (void *) > >   and have the compiler do the implicit cast > > I see no advantage in this, why? All it does is make the code longer, > and if anything changes, you have to change it

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-05 Thread Andy Shevchenko
On Fri, 2017-05-05 at 10:06 +0300, Amir Goldstein wrote: > On Fri, May 5, 2017 at 9:20 AM, Dan Williams > wrote: > > On Thu, May 4, 2017 at 2:21 AM, Andy Shevchenko > > wrote: > > > for (i = 0; i < NFIT_UUID_MAX; i++) > > > -   if (memcmp(to_nfit_uuid(i), spa->range_guid, 16

Re: net/key: slab-out-of-bounds in pfkey_compile_policy

2017-05-05 Thread Steffen Klassert
On Tue, May 02, 2017 at 06:45:03PM +0200, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit d3b5d35290d729a2518af00feca867385a1b08fa (4.11). > > A reproducer and .config are attached. > >

Re: [PATCH] mac80211: Create ieee80211_if_process_skb from ieee80211_iface_work

2017-05-05 Thread Johannes Berg
> o Use explicit casts to proper types instead of casts to (void *) >   and have the compiler do the implicit cast I see no advantage in this, why? All it does is make the code longer, and if anything changes, you have to change it in multiple places now. johannes

  1   2   >