David Miller wrote:
> I guess this is fine, but I think you can use one of the two "sk_padding"
> bits in struct sock instead of making the structure larger.
It shouldn't make the structure larger since there's a hole in the structure:
unsigned intsk_padding : 2,
From: David Howells
Date: Mon, 06 Mar 2017 15:04:44 +
> Fix the general case by:
>
> (1) Double up all the locking keys used in sockets so that one set are
> used if the socket is created by userspace and the other set is used
> if the socket is created by the kernel.
>
> (2) St
It is difficult to make sure the state of the interrupt when this
function is called. As such, it is safer to use spin_lock_irqsave
than spin_lock_irq.
Cc: Joe Jin
Cc: Junxiao Bi
Signed-off-by: Zhu Yanjun
---
net/rds/ib_cm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --gi
The function ib_dealloc_fmr will never be called. As such, it should
be removed.
Cc: Joe Jin
Cc: Junxiao Bi
Signed-off-by: Zhu Yanjun
---
net/rds/ib_fmr.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/rds/ib_fmr.c b/net/rds/ib_fmr.c
index 4fe8f4f..b807df6 100644
The function rds_ib_map_fmr is used only in the ib_fmr.c
file. As such, the static type is added to limit it in this file.
Cc: Joe Jin
Cc: Junxiao Bi
Signed-off-by: Zhu Yanjun
---
net/rds/ib_fmr.c | 5 +++--
net/rds/ib_mr.h | 2 --
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git
When rdma_accept fails, rdma_reject is called in it. As such, it is
not necessary to execute rdma_reject again.
Cc: Joe Jin
Cc: Junxiao Bi
Signed-off-by: Zhu Yanjun
---
net/rds/ib_cm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
index
When some errors occur, the scatter/gather list mapped to DMA addresses
should be handled.
Cc: Joe Jin
Cc: Junxiao Bi
Signed-off-by: Zhu Yanjun
---
net/rds/ib_fmr.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/net/rds/ib_fmr.c b/net/rds/ib_fmr
> On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote:
> > refcount_t type and corresponding API should be
> > used instead of atomic_t when the variable is used as
> > a reference counter. This allows to avoid accidental
> > refcounter overflows that might lead to use-after-free
> > si
> On 03/08/2017 08:49 AM, Reshetova, Elena wrote:
> >> On 03/06/2017 09:21 AM, Elena Reshetova wrote:
> >>> refcount_t type and corresponding API should be
> >>> used instead of atomic_t when the variable is used as
> >>> a reference counter. This allows to avoid accidental
> >>> refcounter overfl
From: Jiri Pirko
Date: Mon, 6 Mar 2017 21:22:09 +0100
> From: Jiri Pirko
>
> This warnings may be hit even in case they should not - in case user
> puts a TC-flower rule which failed to be offloaded. So just remove them.
>
> Reported-by: Petr Machata
> Reported-by: Ido Schimmel
> Fixes: com
From: Jiri Pirko
Date: Mon, 6 Mar 2017 21:25:19 +0100
> Couple of cosmetic mlxsw patches
Series applied, thanks Jiri.
From: Eric Dumazet
Date: Mon, 06 Mar 2017 11:23:55 -0800
> From: Eric Dumazet
>
> __sk_dst_set() must be called while we own the socket.
>
> We can get proper lockdep coverage using lockdep_sock_is_held()
> and rcu_dereference_protected()
>
> Signed-off-by: Eric Dumazet
Applied.
On Wed, Mar 08, 2017 at 02:40:25PM -0800, Jeff Kirsher wrote:
> On Wed, 2017-03-08 at 17:19 +0100, Romain Perier wrote:
> > The PCI pool API is deprecated. This commit replaces the PCI pool old
> > API by the appropriate function with the DMA pool API.
> >
> > Signed-off-by: Romain Perier
> > Ack
From: Alexander Potapenko
Date: Mon, 6 Mar 2017 19:46:14 +0100
> KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of
> uninitialized memory in selinux_socket_bind():
...
> (the line numbers are relative to 4.8-rc6, but the bug persists upstream)
>
> , when I run the follow
From: David Ahern
Date: Mon, 6 Mar 2017 08:53:04 -0800
> KASAN detected a use-after-free:
>
> [ 269.467067] BUG: KASAN: use-after-free in vrf_xmit+0x7f1/0x827 [vrf] at
> addr 8800350a21c0
> [ 269.467067] Read of size 4 by task ssh/1879
> [ 269.467067] CPU: 1 PID: 1879 Comm: ssh Not tain
From: Jiri Pirko
Date: Mon, 6 Mar 2017 16:39:50 +0100
> This patchset follows-up the discussion about future extensions of flow
> dissector and tries to address the mentioned concerns. Some parts are
> cut out into sub-functions. Also, the processing of the code (ARP, MPLS)
> is made dependent o
From: Christian Lamparter
Date: Mon, 6 Mar 2017 14:34:27 +0100
> Julian Margetson reported a panic on his SAM460EX with Kernel 4.11-rc1:
...
> The problem is caused by emac_dt_phy_probe() returing success (0)
> for existing device-trees configurations that do not specify a
> "phy-handle" proper
From: Jarod Wilson
Date: Mon, 6 Mar 2017 08:48:58 -0500
> This restores the ability to set a team device's mtu to anything higher
> than 1500. Similar to the reported issue with bonding, the team driver
> calls ether_setup(), which sets an initial max_mtu of 1500, while the
> underlying hardware
From: Philippe Reynes
Date: Sun, 5 Mar 2017 23:46:00 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Sun, 5 Mar 2017 23:21:06 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Sun, 5 Mar 2017 22:25:39 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Sun, 5 Mar 2017 00:04:18 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Sat, 4 Mar 2017 16:16:12 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Sat, 4 Mar 2017 17:50:06 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Tue, 28 Feb 2017 23:49:38 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Philippe Reynes
Date: Sat, 4 Mar 2017 12:42:39 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes
From: Shannon Nelson
Date: Wed, 8 Mar 2017 15:04:45 -0800
> On 3/6/2017 3:15 PM, Shannon Nelson wrote:
>> These patches remove some problems in handling of carrier state
>> with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and
>> add stats for debug and tracking of point-to-point connec
On Wed, Mar 8, 2017 at 3:55 PM, Laura Abbott wrote:
> On 03/08/2017 02:36 PM, Kees Cook wrote:
>> On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote:
>>> [ 28.474232] rodata_test: test data was not read only
>>> [...]
>>
>> In my tests so far, I've never been able to get rodata_test to fail
On Thu, Mar 9, 2017 at 3:40 PM, Eric Dumazet wrote:
> On Thu, 2017-03-09 at 14:42 +1100, Jonathan Maxwell wrote:
>> Sorry let me resend in plain text mode.
>>
>> On Thu, Mar 9, 2017 at 1:10 PM, Eric Dumazet wrote:
>> > On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote:
>> >> We have seen a few
On Thu, 2017-03-09 at 14:42 +1100, Jonathan Maxwell wrote:
> Sorry let me resend in plain text mode.
>
> On Thu, Mar 9, 2017 at 1:10 PM, Eric Dumazet wrote:
> > On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote:
> >> We have seen a few incidents lately where a dst_enty has been freed
> >> with
When debugging https://github.com/daurnimator/lua-http/issues/73 which
uses https://github.com/wahern/dns we ran into an issue where modern
linux kernels return EINVAL if you try and re-use a udp socket.
The issue seems to occur if you go from a local destination ip to a
non-local one.
>From conne
Sorry let me resend in plain text mode.
On Thu, Mar 9, 2017 at 1:10 PM, Eric Dumazet wrote:
> On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote:
>> We have seen a few incidents lately where a dst_enty has been freed
>> with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that
>>
On Thu, 2017-03-09 at 12:15 +1100, Jon Maxwell wrote:
> We have seen a few incidents lately where a dst_enty has been freed
> with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that
> dst_entry. If the conditions/timings are right a crash then ensues when the
> freed dst_entry is r
From: Lev Urusov
The driver will not be able to take into account the correct number
of device SPI registers if it is not equal to 128.
Signed-off-by: Lev Urusov
---
drivers/net/phy/spi_ks8995.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/spi_ks8995.c b/
On Mon, 6 Mar 2017 13:06:00 +0100
Daniel Borkmann wrote:
> Jan-Erik reported an assertion in bpf_prog_to_subdir() failed where
> type was BPF_PROG_TYPE_UNSPEC, which is only used in bpf_init_env()
> to auto-mount and cache the bpf fs mount point.
>
> Therefore, make sure when bpf_init_env() is
On Mon, 6 Mar 2017 11:06:18 +0200
Roi Dayan wrote:
> While at it also fixed missing double dash for long opts.
>
> Signed-off-by: Roi Dayan
Applied to master (for 4.11) this doesn't have to wait until net-next (4.12)
On 03/08/2017 05:43 PM, Lev Urusov wrote:
> From: Lev Urusov
>
> The driver will not be able to take into account the correct number
> of device SPI registers if it is not equal to 128.
You would want to fix a couple of things with this patchset, since you
are fixing a bug, can you provide the p
On Wed, Mar 08, 2017 at 02:43:44PM -0800, Linus Torvalds wrote:
On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote:
The issue seems to be accessing buff first (can be read or write access)
and then doing set_memory_ro() doesn't make it read-only immediately,
meaning the subsequent call into
We have seen a few incidents lately where a dst_enty has been freed
with a dangling TCP socket reference (sk->sk_dst_cache) pointing to that
dst_entry. If the conditions/timings are right a crash then ensues when the
freed dst_entry is referenced later on. A Common crashing back trace is:
#8 [] p
In original driver was implemented support for half-
and full-duplex modes, but it was not enabled. Instead
of it ks8851_rx_1msg method always returns "true" that
means "full-duplex" mode.
This patch replaces hard-coded functionality with
flexible solution that supports both SPI modes.
Signed-off
Dear Friend,
I assume that this message will reach you in good health. My name is
Mrs. Aruna Sabbah,the foreign operation manager of the African
Development Bank Burkina Faso (ADB) I have the opportunity of
transferring the left over funds what of ($25.2Million Dollars) from
the account of our ban
On 03/08/2017 02:36 PM, Kees Cook wrote:
> On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote:
>> [ 28.474232] rodata_test: test data was not read only
>> [...]
>
> In my tests so far, I've never been able to get rodata_test to fail
> (Qemu 2.5.0, Ubuntu). I'll retry with your .config and se
Mahesh Bandewar wrote:
>From: Mahesh Bandewar
>
>Few cleanup patches that I have accumulated over some time now.
>
>(a) First two patches are basically to move the work-queue initialization
>from every ndo_open / bond_open operation to once at the beginning while
>port creation. Work-que
On Wed, 8 Mar 2017 16:46:57 +0100
Corentin Labbe wrote:
> Printing copyright does not give any useful information on the boot
> process.
> Furthermore, the email address printed is obsolete since
> commit ba57b6f20429 ("MAINTAINERS: fix bouncing tun/tap entries")
>
> Signed-off-by: Corentin Lab
Set DCB_CAP_DCBX_HOST capability flag only if the firmware LLDP agent
is not running.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 2 +-
3 files changed
If we call bnxt_reset_task() due to tx timeout, we should call
bnxt_ulp_stop() to inform the RDMA driver about the error and the
impending reset.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/d
In some situations, the firmware will return 0 for autoneg supported
speed. This may happen if the firmware detects no SFP module, for
example. The driver should ignore this so that we don't end up with
an invalid autoneg setting with nothing advertised. When SFP module
is inserted, we'll get th
The firmware call to do function reset is done too late. It is causing
the rings that have been reserved to be freed. In NPAR mode, this bug
is causing us to run out of rings.
Fixes: 391be5c27364 ("bnxt_en: Implement new scheme to reserve tx rings.")
Signed-off-by: Michael Chan
---
drivers/net
Fixes include moving the initial function reset, notifying the RDMA driver
during tx timeout, setting dcbx_cap properly depending on whether the
firmware agent is running or not, and an autoneg related improvement.
Michael Chan (4):
bnxt_en: Perform function reset earlier during probe.
bnxt_e
While running a single stream UDPv6 test, we observed that amount
of CPU spent in NET_RX softirq was much greater than UDPv4 for an
equivalent receive rate. The test here was run on an ARM64 based
Android system. On further analysis with perf, we found that UDPv6
was spending significant time in th
On 03/08/2017 11:36 PM, Kees Cook wrote:
On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote:
[ 28.474232] rodata_test: test data was not read only
[...]
In my tests so far, I've never been able to get rodata_test to fail
(Qemu 2.5.0, Ubuntu). I'll retry with your .config and see if I can
On 3/6/2017 3:15 PM, Shannon Nelson wrote:
These patches remove some problems in handling of carrier state
with the ldmvsw vswitch, remove an xoff misuse in sunvnet, and
add stats for debug and tracking of point-to-point connections
between the ldom VMs.
Further testing shows a problem in one
On 03/08/2017 01:03 PM, Alexander Duyck wrote:
On Wed, Mar 8, 2017 at 11:30 AM, tndave wrote:
On 03/08/2017 07:39 AM, Alexander Duyck wrote:
On Tue, Mar 7, 2017 at 3:43 PM, tndave
wrote:
Hi,
I have few questions regarding ixgbe flow director. As per my
understanding flow director in i
On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote:
>
> The issue seems to be accessing buff first (can be read or write access)
> and then doing set_memory_ro() doesn't make it read-only immediately,
> meaning the subsequent call into probe_kernel_write() will succeed without
> error.
>
> Then
The fjes driver is used only by FUJITSU servers and almost of all
servers in the world never use it. But currently if ACPI PNP0C02
is defined in the ACPI table, the following message is always shown:
"FUJITSU Extended Socket Network Device Driver - version 1.2
- Copyright (c) 2015 FUJITSU LIMI
On Wed, 2017-03-08 at 17:19 +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commit replaces the PCI pool old
> API by the appropriate function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> Acked-by: Peter Senna Tschudin
> Tested-by: Peter Senna Tschudin
> ---
> d
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/hyperv/netvsc_drv.c | 39 +---
On Wed, Mar 8, 2017 at 2:27 PM, Daniel Borkmann wrote:
> [ 28.474232] rodata_test: test data was not read only
> [...]
In my tests so far, I've never been able to get rodata_test to fail
(Qemu 2.5.0, Ubuntu). I'll retry with your .config and see if I can
recheck under Qemu 2.7.1. Do you see the
[ + Kees, Laura, and Dave ]
On 03/08/2017 08:25 PM, Linus Torvalds wrote:
Adding x86 people too, since this seems to be something off about
ARCH_HAS_SET_MEMORY for x86-32.
The code seems to be shared between x86-32 and 64, I'm not seeing why
set_memory_r[ow]() should fail on one but not the oth
When the aquantia device mtu is changed the net_device structure is not
updated. As a result the ip command does not properly reflect the mtu change.
Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the
assignment ndev->mtu = new_mtu; This is not true in the case where the
Inside the kernel you should use "u32", "u16", "u8", etc. for purely
internal things, and for datastructures exported to userspace you
should use "__u32", "__u16", "__u8".
Furthermore, if the members have specific endianness you should
properly use the "__le32", "__le16", "__be32", "__be16" etc.
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/fjes/fjes_ethtool.c | 19 +--
1 files cha
On Wed, Mar 8, 2017 at 11:30 AM, tndave wrote:
>
>
> On 03/08/2017 07:39 AM, Alexander Duyck wrote:
>>
>> On Tue, Mar 7, 2017 at 3:43 PM, tndave
>> wrote:
>>>
>>> Hi,
>>>
>>> I have few questions regarding ixgbe flow director. As per my
>>> understanding flow director in ixgbe can work in 2 exclu
On 03/08/2017 07:39 AM, Alexander Duyck wrote:
On Tue, Mar 7, 2017 at 3:43 PM, tndave
wrote:
Hi,
I have few questions regarding ixgbe flow director. As per my
understanding flow director in ixgbe can work in 2 exclusive ways,
a. Using ATR filters - where flow director is setup in HW by
driv
On 03/08/2017 07:40 PM, Kees Cook wrote:
On Mon, Mar 6, 2017 at 10:11 AM, Kees Cook wrote:
On Fri, Mar 3, 2017 at 7:23 PM, Daniel Borkmann wrote:
Latter shows that memory protecting the kernel seems not working either
on i386 (!). Test suite output:
[...]
[ 12.692836] Write protectin
The ethtool api {get|set}_settings is deprecated.
We move this driver to new api {get|set}_link_ksettings.
As I don't have the hardware, I'd be very pleased if
someone may test this patch.
Signed-off-by: Philippe Reynes
---
drivers/net/ethernet/via/via-velocity.c | 62 +---
Hello!
I've found a bug in TUN/TAP driver with offloads - when Qemu is trying
to set offloads on tap device, there is no error, but offloads are not
appied.
The cause of this is that udev in recent systemd is using ethtool to
disable offloads. So, udev is setting tun->dev->wanted_features via
etht
Hi David,
On 03/07/2017 04:44 PM, David Miller wrote:
From: Yasuaki Ishimatsu
Date: Thu, 2 Mar 2017 11:56:44 -0500
+
/* fjes_init_module - Driver Registration Routine */
static int __init fjes_init_module(void)
{
int result;
+ bool found = false;
+
Please order local variab
On Wed, 2017-03-08 at 12:11 -0700, Subash Abhinov Kasiviswanathan wrote:
> On 2017-03-08 11:40, Eric Dumazet wrote:
> > Well, this 'optimization' actually hurts when UDP sockets are not
> > connected, since this adds an extra cache line miss per incoming
> > packet.
> >
> > (DNS servers for examp
From: Mahesh Bandewar
Few cleanup patches that I have accumulated over some time now.
(a) First two patches are basically to move the work-queue initialization
from every ndo_open / bond_open operation to once at the beginning while
port creation. Work-queue initialization is an unnecess
Adding x86 people too, since this seems to be something off about
ARCH_HAS_SET_MEMORY for x86-32.
The code seems to be shared between x86-32 and 64, I'm not seeing why
set_memory_r[ow]() should fail on one but not the other.
Considering that it seems to be flaky even on 32-bit, maybe it's
timing-
From: Joao Pinto
Date: Wed, 8 Mar 2017 11:03:10 +
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index af57f8d..df3b1ee 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stm
From: Joao Pinto
Date: Wed, 8 Mar 2017 11:03:09 +
> This patch adds the RX and TX scheduling algorithms programming.
> It introduces the multiple queues configuration function
> (stmmac_mtl_configuration) in stmmac_main.
>
> Signed-off-by: Joao Pinto
> ---
> drivers/net/ethernet/stmicro/s
From: Joao Pinto
Date: Wed, 8 Mar 2017 11:03:14 +
> +static int dwmac4_irq_mtl_status(struct mac_device_info *hw, u32 chan)
> +{
> + void __iomem *ioaddr = hw->pcsr;
> + u32 mtl_int_qx_status = readl(ioaddr + MTL_INT_STATUS);
> + int ret = 0;
Please order local variable declarat
I see.
Perhaps on the man page add
EXAMPLES
See https://www.kernel.org/doc/Documentation/networking/vrf.txt
https://www.google.com/search?q=ip+linux+command+usage+examples
(I thought the latter would be hopeless, but actually found lots!)
From: Mahesh Bandewar
Initializing work-queues every time ifup operation performed is unnecessary
and can be performed only once when the port is created.
Signed-off-by: Mahesh Bandewar
---
drivers/net/bonding/bond_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
On 2017-03-08 11:40, Eric Dumazet wrote:
Well, this 'optimization' actually hurts when UDP sockets are not
connected, since this adds an extra cache line miss per incoming
packet.
(DNS servers for example)
Hi Eric
Thanks for your comments. Would it be preferable to disable early demux
for
Alexandre Belloni writes:
> Hi,
>
> On 08/03/2017 at 15:13:40 +, Kalle Valo wrote:
>> Alexandre Belloni wrote:
>> > last_qual never really holds a time. It only holds jiffies. Make it the
>> > same type as jiffies.
>> >
>> > Signed-off-by: Alexandre Belloni
>>
>> The title should start wi
From: Mahesh Bandewar
In preparation to move the work-queue initialization to port creation
from current port_open phase. Work-queue initialization does not make
sense every time we do 'ifup/ifdown'. So moving to port creation phase.
Arp monitoring work depends on the bonding mode and that is no
From: Mahesh Bandewar
LACP state-machine defines "port-moved" state when the same ActorSystemID
and Port are seen in a LACPDU received on different port. The state is
never set since it's not implemented. However the state-machine attempts
to clear that state occasionally. LACP state machine is a
From: Mahesh Bandewar
Many of the bond param variables are declared global while it's not
really necessary for these variables to be global. So moving them to
the location these are used.
Signed-off-by: Mahesh Bandewar
---
drivers/net/bonding/bond_main.c | 11 +--
1 file changed, 5 ins
From: Mahesh Bandewar
Eliminate hard-coded value and use the default that is set.
Signed-off-by: Mahesh Bandewar
---
drivers/net/bonding/bond_main.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_mai
While running a single stream UDPv6 test, we observed that amount
of CPU spent in NET_RX softirq was much greater than UDPv4 for an
equivalent receive rate. The test here was run on an ARM64 based
Android system. On further analysis with perf, we found that UDPv6
was spending significant time in th
On Wed, 2017-03-08 at 11:24 -0700, Subash Abhinov Kasiviswanathan wrote:
> While running a single stream UDPv6 test, we observed that amount
> of CPU spent in NET_RX softirq was much greater than UDPv4 for an
> equivalent receive rate. The test here was run on an ARM64 based
> Android system. On fu
On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote:
> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations.
>
On Mon, Mar 6, 2017 at 10:11 AM, Kees Cook wrote:
> On Fri, Mar 3, 2017 at 7:23 PM, Daniel Borkmann wrote:
>> Latter shows that memory protecting the kernel seems not working either
>> on i386 (!). Test suite output:
>>
>> [...]
>> [ 12.692836] Write protecting the kernel text: 13416k
>>
On Wed, Mar 08, 2017 at 12:16:05PM +1100, Stephen Rothwell wrote:
> Hi Paul,
>
> On Mon, 13 Feb 2017 17:43:24 +1100 Stephen Rothwell
> wrote:
> >
> > On Sun, 12 Feb 2017 20:37:48 -0800 "Paul E. McKenney"
> > wrote:
> > >
> > > I chickened out on that commit for this merge window, so it will co
On 03/08/2017 08:49 AM, Reshetova, Elena wrote:
>> On 03/06/2017 09:21 AM, Elena Reshetova wrote:
>>> refcount_t type and corresponding API should be
>>> used instead of atomic_t when the variable is used as
>>> a reference counter. This allows to avoid accidental
>>> refcounter overflows that migh
On Sat, Mar 04, 2017 at 06:00:02PM +0800, Ying Xue wrote:
> Regarding RFC 792, the first 64 bits of the original SCTP datagram's
> data could be contained in ICMP packet, such as:
>
> 0 1 2 3
> 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
KMSAN reports a use of uninitialized memory in put_cmsg() because
msg.msg_flags in recvfrom haven't been initialized properly.
The flag values don't affect the result on this path, but it's still a
good idea to initialize them explicitly.
Signed-off-by: Alexander Potapenko
---
Changes since v1:
On Wed, 2017-03-08 at 17:25 +0100, Paolo Abeni wrote:
> - no changes, tested with several different workload
>
> Suggested-by: Cong Wang
> Signed-off-by: Paolo Abeni
> ---
> net/core/sock.c | 96
> ++---
> 1 file changed, 78 insertions(+),
We really only need the device pointer on the fast path, stash it at
the beginning of the adapter structure and move pci_dev pointer down.
This saves up a few lines of code.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_net.h | 6 ++-
.../net/ethernet/netronome/
NSP reports to us port labels. First id is the id of the physical
port, the other one tells us which logical interface is it within a
split port. Instead of printing them as string keep them in integer
format. Compute which interfaces are part of port split.
On netdev side use port labels and s
Some firmware images may reuse CRC32 hardware to compute RXHASH.
Make sure we report the correct hash function. Note that we don't
support changing functions at runtime. That would also require
a few more additions to the way the key is set because different
functions have different key sizes.
S
Make use of return code from napi_complete_done() to avoid rearming
interrupts when busy polling is on.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/netronome/
Reorder variables longest to shortest to comply with netdev coding style.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
b/drivers/n
CRC32 engines are usually easily available in hardware and generate
OK spread for RSS hash. Add CRC32 RSS hash function to ethtool API.
Signed-off-by: Jakub Kicinski
---
include/linux/ethtool.h | 2 ++
net/core/ethtool.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/include/linux/e
We already print most of ring configuration including descriptors
in debugfs, add the few missing pieces and remove debug prints.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 9 -
drivers/net/ethernet/netronome/nfp/nfp_net_debugfs.c | 13 +
We only need FW version in the first cache line of adapter struct
because we need to know the metadata format. To save space add a
metadata format bit.
Signed-off-by: Jakub Kicinski
---
drivers/net/ethernet/netronome/nfp/nfp_net.h| 2 ++
drivers/net/ethernet/netronome/nfp/nfp_net_common
From: Simon Horman
Prevent theoretical buffer overrun by returning an error if
the number of entries returned by the firmware does not match those
present.
Also use a common handling error path.
Found by inspection.
Signed-off-by: Simon Horman
Tested-by: Jakub Kicinski
---
.../ethernet/netr
1 - 100 of 187 matches
Mail list logo
