Re: [PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

2017-03-04 Thread Jamal Hadi Salim
On 17-03-04 07:01 PM, Alexey Khoroshilov wrote: Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Acked-by: Jamal Hadi Salim cheers, jamal

[GIT] Networking

2017-03-04 Thread David Miller
1) Fix double-free in batman-adv, from Sven Eckelmann. 2) Fix packet stats for fast-RX path, from Joannes Berg. 3) Netfilter's ip_route_me_harder() doesn't handle request sockets properly, fix from Florian Westphal. 4) Fix sendmsg deadlock in rxrpc, from David Howells. 5) Add missing RCU lo

[PATCH] net/sched: act_skbmod: remove unneeded rcu_read_unlock in tcf_skbmod_dump

2017-03-04 Thread Alexey Khoroshilov
Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- net/sched/act_skbmod.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sched/act_skbmod.c b/net/sched/act_skbmod.c index 3b7074e23024..c736627f8f4a 100644 --- a/net/sched/act_skbmod.c +++

Re: net/sched: act_skbmod: rcu_read_unlock in tcf_skbmod_dump?

2017-03-04 Thread Jamal Hadi Salim
On 17-03-04 03:49 PM, Alexey Khoroshilov wrote: Hello! rcu_read_unlock() in tcf_skbmod_dump() looks suspicious to me. It does look suspicious. You want to send a patch or should I? cheers, jamal

[PATCH] net: sun: sungem: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sun/sungem.c | 98 +-

Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Philippe Reynes
Hi Robert, On 3/4/17, Robert Jarzmik wrote: > Philippe Reynes writes: > >> The ethtool api {get|set}_settings is deprecated. >> We move this driver to new api {get|set}_link_ksettings. >> >> As I don't have the hardware, I'd be very pleased if >> someone may test this patch. > I have the hardwar

net/sched: act_skbmod: rcu_read_unlock in tcf_skbmod_dump?

2017-03-04 Thread Alexey Khoroshilov
Hello! rcu_read_unlock() in tcf_skbmod_dump() looks suspicious to me. What does it mean there? -- Thank you, Alexey Khoroshilov Linux Verification Center, ISPRAS web: http://linuxtesting.org

Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Robert Jarzmik
Philippe Reynes writes: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. I have the hardware. Do you want anything specific to be tested, like set

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

2017-03-04 Thread Eric Dumazet
On Sat, 2017-03-04 at 19:57 +0100, Dmitry Vyukov wrote: > On Fri, Mar 3, 2017 at 8:12 PM, David Ahern wrote: > > On 3/3/17 6:39 AM, Dmitry Vyukov wrote: > >> I am getting heap out-of-bounds reports in > >> fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone while running > >> syzkaller fuzzer

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

2017-03-04 Thread Dmitry Vyukov
On Sat, Mar 4, 2017 at 7:57 PM, Dmitry Vyukov wrote: > On Fri, Mar 3, 2017 at 8:12 PM, David Ahern wrote: >> On 3/3/17 6:39 AM, Dmitry Vyukov wrote: >>> I am getting heap out-of-bounds reports in >>> fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone while running >>> syzkaller fuzzer on 862

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

2017-03-04 Thread Dmitry Vyukov
On Fri, Mar 3, 2017 at 8:12 PM, David Ahern wrote: > On 3/3/17 6:39 AM, Dmitry Vyukov wrote: >> I am getting heap out-of-bounds reports in >> fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone while running >> syzkaller fuzzer on 86292b33d4b79ee03e2f43ea0381ef85f077c760. They all >> follow th

[PATCH] net: sun: niu: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sun/niu.c | 37 -

[PATCH] net: sun: cassini: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sun/cassini.c | 98 +++--

[PATCH net-next 1/1] decnet: Use TCP nagle macro instead of literal number in decnet

2017-03-04 Thread fgao
From: Gao Feng Use existing TCP nagle macro TCP_NAGLE_OFF and TCP_NAGLE_CORK instead of the literal number 1 and 2 in the current decnet codes. Signed-off-by: Gao Feng --- net/decnet/af_decnet.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/net/decnet/af_dec

[net] netfilter: nat: sctp: fix ICMP packet to be dropped accidently

2017-03-04 Thread Ying Xue
Regarding RFC 792, the first 64 bits of the original SCTP datagram's data could be contained in ICMP packet, such as: 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

[PATCH v2] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- Changelog: v2: - also update comment (feeback from Russel King) driver

Re: [PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Russell King - ARM Linux
On Sat, Mar 04, 2017 at 11:11:32AM +0100, Philippe Reynes wrote: > > // lp->port = cmd->port; Hi, Review looks good. However, please also update the above comment as well. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line

[PATCH] net: smsc: smc91x: use new api ethtool_{get|set}_link_ksettings

2017-03-04 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/smsc/smc91x.c | 45 +++--

Re: Passionate Partner

2017-03-04 Thread M. G
Dear Sir, Did you recieved my mail? I have sent it twice without a response. Mr Masella Giuseppe

Re: [Bug 194749] New: kernel bonding does not work in a network nameservice in versions above 3.10.0-229.20.1

2017-03-04 Thread Jiri Pirko
Fri, Mar 03, 2017 at 07:11:32PM CET, xiyou.wangc...@gmail.com wrote: >On Fri, Mar 3, 2017 at 8:03 AM, Jiri Pirko wrote: >> If that use case exists I believe it is an abuse. Soft devices that are >> by definition in upper-lower relationships with other devices should not >> move to other namespaces