Re: [patch net] lib: Remove string from parman config selection

2017-02-23 Thread Geert Uytterhoeven
Hi Jiri, On Thu, Feb 23, 2017 at 10:57 AM, Jiri Pirko wrote: > From: Jiri Pirko > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. > > Reported-by: Geert Uytterhoeven > Fixes: 44

[PATCH net] sctp: set sin_port for addr param when checking duplicate address

2017-02-23 Thread Xin Long
Commit b8607805dd15 ("sctp: not copying duplicate addrs to the assoc's bind address list") tried to check for duplicate address before copying to asoc's bind_addr list from global addr list. But all the addrs' sin_ports in global addr list are 0 while the addrs' sin_ports are bp->port in asoc's bi

Re: [PATCH net-next 2/2] sctp: add support for MSG_MORE

2017-02-23 Thread Xin Long
On Fri, Feb 24, 2017 at 12:04 AM, David Laight wrote: > From: Xin Long >> Sent: 23 February 2017 03:46 >> On Tue, Feb 21, 2017 at 10:27 PM, David Laight >> wrote: >> > From: Xin Long >> >> Sent: 18 February 2017 17:53 >> >> This patch is to add support for MSG_MORE on sctp. >> >> >> >> It adds f

Re: [PATCH net-next v4 4/7] gtp: consolidate gtp socket rx path

2017-02-23 Thread Harald Welte
Hi Tom, On Thu, Feb 23, 2017 at 10:07:03AM -0800, Tom Herbert wrote: > I'm looking at the GTP encapsulation, it's not particularly complex. > Is there any real reason why we can't just implement a netdev > interface with static tunnels and configuration to do performance > testing and development?

[PATCH v1 net] net: phy: Fix LED mode in DT single property.

2017-02-23 Thread Raju Lakkaraju
From: Raju Lakkaraju Fix the LED mode DT parameters combine to a single property and change the vendor prefix i.e. mscc. Signed-off-by: Raju Lakkaraju --- Change set: v0: Fix the LED mode DT parameters combine to a single property v1: Fix the build test ERROR .../devicetree/bindings/net/mscc-

[PATCH 3/3] mwifiex: wake system up when receives a wake irq

2017-02-23 Thread Jeffy Chen
Currrently we are disabling this wake irq after receiving it. If this happens before we finish suspend and the pm event check is disabled, the system will continue suspending, and this irq would not work again. We may need to abort system suspend to avoid that. Signed-off-by: Jeffy Chen --- dr

Re: [PATCH net] net: phy: Fix LED mode in DT single property.

2017-02-23 Thread kbuild test robot
Hi Raju, [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Raju-Lakkaraju/net-phy-Fix-LED-mode-in-DT-single-property/20170224-140414 config: x86_64-randconfig-x007-201708 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

2017-02-23 Thread Raju Lakkaraju
Hi Rob, Thank you for code review comments. On Tue, Feb 21, 2017 at 10:42:38AM -0600, Rob Herring wrote: > EXTERNAL EMAIL > > > > Do i need to change from "vsc8531, led-0-mode" to "mscc, led-0-mode" > > Is this your suggestion? > > Well, there shouldn't be a space there, but yess, mscc is the

[PATCH net] net: phy: Fix LED mode in DT single property.

2017-02-23 Thread Raju Lakkaraju
From: Raju Lakkaraju Fix the LED mode DT parameters combine to a single property and change the vendor prefix i.e. mscc. Signed-off-by: Raju Lakkaraju --- .../devicetree/bindings/net/mscc-phy-vsc8531.txt | 20 - drivers/net/phy/mscc.c | 50 +---

[PATCH net-next 0/1] net: Add support for rmnet_data driver

2017-02-23 Thread Subash Abhinov Kasiviswanathan
This patch adds support for the rmnet_data driver which is required to support recent chipsets using Qualcomm Technologies, Inc. modems. The data from hardware follows the multiplexing and aggregation protocol (MAP). This driver can be used to register onto any physical network device in IP mode.

[PATCH net-next 1/1] net: rmnet_data: Initial implementation

2017-02-23 Thread Subash Abhinov Kasiviswanathan
RmNet Data driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded and bridge modes. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a

Re: [PATCH] iproute2: hide devices starting with period by default

2017-02-23 Thread David Miller
From: David Ahern Date: Thu, 23 Feb 2017 18:07:07 -0700 > On 2/23/17 5:30 PM, Stephen Hemminger wrote: >> On Thu, 23 Feb 2017 16:39:52 -0700 >> David Ahern wrote: >> >>> On 2/23/17 12:50 PM, Stephen Hemminger wrote: Some use cases create Linux networking devices which are not intended for

Re: net: possible deadlock in skb_queue_tail

2017-02-23 Thread Florian Westphal
Andrey Konovalov wrote: [ CC Paolo ] > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit c470abd4fde40ea6a0846a2beab642a578c0b8cd (4.10). > > Unfortunately I can't reproduce it. This needs NETLINK_BROADCAST_ERROR enabled on a netlink socket that then s

Re: [PATCH] iproute2: hide devices starting with period by default

2017-02-23 Thread Stephen Hemminger
On Thu, 23 Feb 2017 18:07:07 -0700 David Ahern wrote: > On 2/23/17 5:30 PM, Stephen Hemminger wrote: > > On Thu, 23 Feb 2017 16:39:52 -0700 > > David Ahern wrote: > > > >> On 2/23/17 12:50 PM, Stephen Hemminger wrote: > >>> Some use cases create Linux networking devices which are not intend

Re: [PATCH] iproute2: hide devices starting with period by default

2017-02-23 Thread David Ahern
On 2/23/17 5:30 PM, Stephen Hemminger wrote: > On Thu, 23 Feb 2017 16:39:52 -0700 > David Ahern wrote: > >> On 2/23/17 12:50 PM, Stephen Hemminger wrote: >>> Some use cases create Linux networking devices which are not intended for >>> use >>> by normal networking. This is an enhancement to ip c

Re: [PATCH] iproute2: hide devices starting with period by default

2017-02-23 Thread Stephen Hemminger
On Thu, 23 Feb 2017 16:39:52 -0700 David Ahern wrote: > On 2/23/17 12:50 PM, Stephen Hemminger wrote: > > Some use cases create Linux networking devices which are not intended for > > use > > by normal networking. This is an enhancement to ip command to hide network > > devices starting with per

[PATCH] uapi: fix rdma/mlx5-abi.h userspace compilation errors

2017-02-23 Thread Dmitry V. Levin
Consistently use types from linux/types.h to fix the following rdma/mlx5-abi.h userspace compilation errors: /usr/include/rdma/mlx5-abi.h:69:25: error: 'u64' undeclared here (not in a function) MLX5_LIB_CAP_4K_UAR = (u64)1 << 0, /usr/include/rdma/mlx5-abi.h:69:29: error: expected ',' or '}' bef

Re: VXLAN RCU error

2017-02-23 Thread Pravin Shelar
On Thu, Feb 23, 2017 at 12:20 AM, Jakub Kicinski wrote: > On Wed, 22 Feb 2017 20:30:31 -0800, Jakub Kicinski wrote: >> On Wed, 22 Feb 2017 14:27:45 -0800, Jakub Kicinski wrote: >> > [ 1571.067134] === >> > [ 1571.071842] [ ERR: suspicious RCU usage. ] >> > [ 1571.07654

Re: netvsc NAPI

2017-02-23 Thread Stephen Hemminger
On Thu, 23 Feb 2017 18:24:06 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Wed, 22 Feb 2017 09:33:16 -0800 > > > NAPI for netvsc is ready but the merge coordination is a nuisance. > > > > Since netvsc NAPI support requires other changes that are proceeding through > > GregK

Re: [PATCH] iproute2: hide devices starting with period by default

2017-02-23 Thread David Ahern
On 2/23/17 12:50 PM, Stephen Hemminger wrote: > Some use cases create Linux networking devices which are not intended for use > by normal networking. This is an enhancement to ip command to hide network > devices starting with period (like files in normal directory). Interfaces > whose > name sta

Re: netvsc NAPI

2017-02-23 Thread David Miller
From: Stephen Hemminger Date: Wed, 22 Feb 2017 09:33:16 -0800 > NAPI for netvsc is ready but the merge coordination is a nuisance. > > Since netvsc NAPI support requires other changes that are proceeding through > GregKH's char-misc tree. I would like to send the two patches after current > net

[PATCH net] net/mlx4_en: fix overflow in mlx4_en_init_timestamp()

2017-02-23 Thread Eric Dumazet
From: Eric Dumazet The cited commit makes a great job of finding optimal shift/multiplier values assuming a 10 seconds wrap around, but forgot to change the overflow_period computation. It overflows in cyclecounter_cyc2ns(), and the final result is 804 ms, which is silly. Lets simply use 5 seco

[PATCH net] net: phy: Add missing driver check in phy_aneg_done()

2017-02-23 Thread Florian Fainelli
Dan's static checker caught a potential code path in phy_state_machine() where we were not checking phydev->drv which is in phy_aneg_done(). Reported-by: Dan Carpenter Fixes: 25149ef9d25c ("net: phy: Check phydev->drv") Signed-off-by: Florian Fainelli --- drivers/net/phy/phy.c | 2 +- 1 file ch

Re: [PATCH v5 07/10] bpf: Add a Landlock sandbox example

2017-02-23 Thread Mickaël Salaün
On 22/02/2017 02:26, Mickaël Salaün wrote: > Add a basic sandbox tool to create a process isolated from some part of > the system. This sandbox create a read-only environment. It is only > allowed to write to a character device such as a TTY: > > # :> X > # echo $? > 0 > # ./samples/bpf/l

[PATCH] net: realtek: r8169: use new api ethtool_{get|set}_link_ksettings

2017-02-23 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/realtek/r8169.c | 41 ---

[PATCH] iproute2: hide devices starting with period by default

2017-02-23 Thread Stephen Hemminger
Some use cases create Linux networking devices which are not intended for use by normal networking. This is an enhancement to ip command to hide network devices starting with period (like files in normal directory). Interfaces whose name start with "." are not shown by default, and the -a (or -all

Re: [PATCH v4 4/5] ipv6: addrconf: fix 48 bit 6lowpan autoconfiguration

2017-02-23 Thread David Miller
From: Luiz Augusto von Dentz Date: Tue, 21 Feb 2017 12:38:10 +0200 > From: Alexander Aring > > This patch adds support for 48 bit 6LoWPAN address length > autoconfiguration which is the case for BTLE 6LoWPAN. > > Signed-off-by: Alexander Aring > Signed-off-by: Luiz Augusto von Dentz > Review

[GIT] Networking

2017-02-23 Thread David Miller
1) Some 'const'ing in qlogic networking drivers, from Bhumika Goyal. 2) Fix scheduling while atomic in l2tp network namespace exit by deferring the work to the workqueue. From Ridge Kennedy. 3) Fix use after free in dccp timewait handling, from Andrey Ryabinin. 4) mlx5e CQE compression engi

Re: [PATCH net] bpf: Fix bpf_xdp_event_output

2017-02-23 Thread David Miller
From: Martin KaFai Lau Date: Thu, 23 Feb 2017 10:40:34 -0800 > Fix a typo. xdp->data instead of xdp should be copied to the perf-event's > dst_buff. > > Fixes: 4de16969523c ("bpf: enable event output helper also for xdp types") > Reported-by: Huapeng Zhou > Tested-by: Feixiong Zhang > Acked-by

Re: [PATCH net] bpf: Fix bpf_xdp_event_output

2017-02-23 Thread Daniel Borkmann
On 02/23/2017 07:40 PM, Martin KaFai Lau wrote: Fix a typo. xdp->data instead of xdp should be copied to the perf-event's dst_buff. Fixes: 4de16969523c ("bpf: enable event output helper also for xdp types") Reported-by: Huapeng Zhou Tested-by: Feixiong Zhang Acked-by: Alexei Starovoitov Cc: D

[PATCH net] bpf: Fix bpf_xdp_event_output

2017-02-23 Thread Martin KaFai Lau
Fix a typo. xdp->data instead of xdp should be copied to the perf-event's dst_buff. Fixes: 4de16969523c ("bpf: enable event output helper also for xdp types") Reported-by: Huapeng Zhou Tested-by: Feixiong Zhang Acked-by: Alexei Starovoitov Cc: Daniel Borkmann Signed-off-by: Martin KaFai Lau -

Re: [PATCH net-next 2/2] sctp: add support for MSG_MORE

2017-02-23 Thread Marcelo Ricardo Leitner
On Fri, Feb 24, 2017 at 02:16:02AM +0800, Xin Long wrote: > On Fri, Feb 24, 2017 at 1:40 AM, Marcelo Ricardo Leitner > wrote: > > On Thu, Feb 23, 2017 at 04:04:10PM +, David Laight wrote: > >> From: Xin Long > >> > Sent: 23 February 2017 03:46 > >> > On Tue, Feb 21, 2017 at 10:27 PM, David Lai

Re: [PATCH net-next 2/2] sctp: add support for MSG_MORE

2017-02-23 Thread Xin Long
On Fri, Feb 24, 2017 at 1:40 AM, Marcelo Ricardo Leitner wrote: > On Thu, Feb 23, 2017 at 04:04:10PM +, David Laight wrote: >> From: Xin Long >> > Sent: 23 February 2017 03:46 >> > On Tue, Feb 21, 2017 at 10:27 PM, David Laight >> > wrote: >> > > From: Xin Long >> > >> Sent: 18 February 2017

RE:

2017-02-23 Thread Qin's Yanjun
How are you today and your family? I require your attention and honest co-operation about some issues which i will really want to discuss with you which. Looking forward to read from you soon. Qin's __ Sky Silk, http://aknet.kz

Re: [PATCH net-next v4 4/7] gtp: consolidate gtp socket rx path

2017-02-23 Thread Tom Herbert
On Thu, Feb 23, 2017 at 8:46 AM, Harald Welte wrote: > Hi Tom, > > On Thu, Feb 23, 2017 at 08:28:47AM -0800, Tom Herbert wrote: > >> If there is a way for us to test this without setting up a full mobile >> network please provide details on how to do that in the commit log. > > There are different

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Emil Velikov
On 23 February 2017 at 17:18, Joe Perches wrote: > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: >> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: >> > There are ~4300 uses of pr_warn and ~250 uses of the older >> > pr_warning in the kernel source tree. >> > >> > Make the use of pr_w

Re: [PATCH 0/7] net: stmmac: Fixes and Tegra186 support

2017-02-23 Thread David Miller
The net-next tree is closed, therefore it is not appropriate to submit feature patches or cleanups at this time. Please wait for the merge window to be finished and the net-next tree to open back up before resubmitting this patch series. Thanks.

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread David Miller
From: Andreas Schultz Date: Thu, 23 Feb 2017 18:19:16 +0100 (CET) > When we are talking about the xmit path, then currently none of the > receivers we are talking to is going to be Linux and we have no > idea how they will behave nor do we have any influence on them. Do > we really need to make a

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Joe Perches
On Thu, 2017-02-23 at 17:41 +, Emil Velikov wrote: > On 23 February 2017 at 17:18, Joe Perches wrote: > > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > > > > There are ~4300 uses of pr_warn and ~250 uses of the older > > > >

[PATCH net]ipv6: Provide ipv6 version of "disable_policy" sysctl

2017-02-23 Thread David Forster
This provides equivalent functionality to the existing ipv4 "disable_policy" systcl. ie. Allows IPsec processing to be skipped on terminating packets on a per-interface basis. Signed-off-by: David Forster --- include/linux/ipv6.h | 1 + include/uapi/linux/ipv6.h | 1 + net/ipv6/addrconf

Re: [PATCH net-next 2/2] sctp: add support for MSG_MORE

2017-02-23 Thread Marcelo Ricardo Leitner
On Thu, Feb 23, 2017 at 04:04:10PM +, David Laight wrote: > From: Xin Long > > Sent: 23 February 2017 03:46 > > On Tue, Feb 21, 2017 at 10:27 PM, David Laight > > wrote: > > > From: Xin Long > > >> Sent: 18 February 2017 17:53 > > >> This patch is to add support for MSG_MORE on sctp. > > >> >

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread David Miller
From: Harald Welte Date: Thu, 23 Feb 2017 17:50:51 +0100 > I understand and support the motivation to design robust systsems even > in the presence of broken/ignorant specs, but I think this is one of the > situations where it is useless (and IMHO impossible) to do anything > about it. I think a

[PATCH 7/7] net: stmmac: dwc-qos: Add Tegra186 support

2017-02-23 Thread Thierry Reding
From: Thierry Reding The NVIDIA Tegra186 SoC contains an instance of the Synopsys DWC ethernet QOS IP core. The binding that it uses is slightly different from existing ones because of the integration (clocks, resets, ...). Signed-off-by: Thierry Reding --- .../ethernet/stmicro/stmmac/dwmac-dw

[PATCH 1/7] net: stmmac: Rename clk_ptp_ref clock to ptp_ref

2017-02-23 Thread Thierry Reding
From: Thierry Reding There aren't currently any users of the "clk_ptp_ref", but there are other references to "ptp_ref", so I'm leaning towards considering that a typo. Fix it. Signed-off-by: Thierry Reding --- Documentation/devicetree/bindings/net/stmmac.txt | 6 +++--- drivers/net/ether

[PATCH 2/7] net: stmmac: Balance PTP reference clock enable/disable

2017-02-23 Thread Thierry Reding
From: Thierry Reding clk_prepare_enable() and clk_disable_unprepare() for this clock aren't properly balanced, which can trigger a WARN_ON() in the common clock framework. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 drivers/net/ethernet/stm

[PATCH 3/7] net: stmmac: Check for DMA mapping errors

2017-02-23 Thread Thierry Reding
From: Thierry Reding When DMA mapping an SKB fragment, the mapping must be checked for errors, otherwise the DMA debug code will complain upon unmap. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driver

[PATCH 4/7] net: stmmac: Parse FIFO sizes from feature registers

2017-02-23 Thread Thierry Reding
From: Thierry Reding New version of this core encode the FIFO sizes in one of the feature registers. Use these sizes as default, but still allow device tree to override them for backwards compatibility. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/common.h | 3 +++

[PATCH 6/7] net: stmmac: dwc-qos: Split out ->probe() and ->remove()

2017-02-23 Thread Thierry Reding
From: Thierry Reding Split out the binding specific parts of ->probe() and ->remove() to enable the driver to support variants of the binding. This is useful in order to keep backwards-compatibility while making it easy for a sub- driver to deal only with the updated bindings rather than having t

[PATCH 5/7] net: stmmac: Program RX queue size and flow control

2017-02-23 Thread Thierry Reding
From: Thierry Reding Program the receive queue size based on the RX FIFO size and enable hardware flow control for large FIFOs. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 12 +++ drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c | 43 +++

[PATCH 0/7] net: stmmac: Fixes and Tegra186 support

2017-02-23 Thread Thierry Reding
found on NVIDIA Tegra186 SoCs. This is based on next-20170223. Thanks, Thierry Thierry Reding (7): net: stmmac: Rename clk_ptp_ref clock to ptp_ref net: stmmac: Balance PTP reference clock enable/disable net: stmmac: Check for DMA mapping errors net: stmmac: Parse FIFO sizes from feature

Re: [PATCH net-next v3 3/3] A Sample of using socket cookie and uid for traffic monitoring

2017-02-23 Thread Willem de Bruijn
> +/* This test is a demo of using get_socket_uid and get_socket_cookie > + * helper function to do per socket based network traffic monitoring. > + * It requires iptable version higher then 1.6.1. to load pined eBPF > + * program into the xt_bpf match. iptable -> iptables (everywhre pined -> pinn

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Andreas Schultz
- On Feb 23, 2017, at 5:42 PM, pablo pa...@netfilter.org wrote: > On Thu, Feb 23, 2017 at 03:21:13PM +0100, Andreas Schultz wrote: >> - On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: > [...] >> > According to specs, section 4.4.2.3 Encapsulated T-PDU, TS 29.281. >> > >> >

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Joe Perches
On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > > There are ~4300 uses of pr_warn and ~250 uses of the older > > pr_warning in the kernel source tree. > > > > Make the use of pr_warn consistent across all kernel files. > > > > This ex

Re: [PATCH net-next v3 2/3] Add a eBPF helper function to retrieve socket uid

2017-02-23 Thread Willem de Bruijn
> +BPF_CALL_1(bpf_get_socket_uid, struct sk_buff *, skb) > +{ > + struct sock *sk = sk_to_full_sk(skb->sk); > + kuid_t kuid = sock_net_uid(dev_net(skb->dev), sk); dev_net cannot handle a NULL skb->dev

RE: [PATCH 00/11] Omni-Path Virtual Network Interface Controller (VNIC)

2017-02-23 Thread Harold Cook
Thank you! I guess we are on the right track... --- Harold -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Vishwanathapura, Niranjana Sent: Wednesday, February 22, 2017 11:07 PM To: dledf...@redhat.com Cc: linux-r...@vger.kernel

Re: [PATCH iproute2] tc: flower: Fix parsing ip address

2017-02-23 Thread Stephen Hemminger
On Wed, 22 Feb 2017 16:05:01 +0200 Roi Dayan wrote: > Fix order of arguments when passed to __flower_parse_ip_addr. > > Fixes: ("f888f4e20534 tc: flower: Support matching ARP") > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey Applied

Re: [PATCH iproute2] ip: Add support for MPLS netconf

2017-02-23 Thread Stephen Hemminger
On Tue, 21 Feb 2017 09:23:31 -0800 David Ahern wrote: > Add support for MPLS netconf to ip monitor and ip netconf commands. > Changes to header files not included as those are typically pulled > in my a header sync with the kernel. > > Signed-off-by: David Ahern Applied

Re: [PATCH net-next v3 0/3] net: core: Two Helper function about socket information

2017-02-23 Thread Willem de Bruijn
On Wed, Feb 22, 2017 at 11:42 PM, Chenbo Feng wrote: > From: Chenbo Feng > > Introduce two eBpf helper function to get the socket cookie and > socket uid for each packet. The helper function is useful when > the *sk field inside sk_buff is not empty. These helper functions > can be used on socket

Re: [PATCH iproute2 master] {f,m}_bpf: dump tag over insns

2017-02-23 Thread Stephen Hemminger
On Thu, 23 Feb 2017 13:07:14 +0100 Daniel Borkmann wrote: > We already export TCA_BPF_TAG resp. TCA_ACT_BPF_TAG from kernel commit > f1f7714ea51c ("bpf: rework prog_digest into prog_tag"), thus also dump > it when filter/actions are shown. > > Signed-off-by: Daniel Borkmann Applied

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Harald Welte
Hi Tom, On Thu, Feb 23, 2017 at 08:35:13AM -0800, Tom Herbert wrote: > On Thu, Feb 23, 2017 at 6:00 AM, Pablo Neira Ayuso > wrote: > > On Thu, Feb 23, 2017 at 10:35:56AM +0100, Andreas Schultz wrote: > >> - On Feb 22, 2017, at 10:47 PM, Tom Herbert t...@herbertland.com wrote: > >> So in a co

Re: [PATCH net-next v4 4/7] gtp: consolidate gtp socket rx path

2017-02-23 Thread Harald Welte
Hi Tom, On Thu, Feb 23, 2017 at 08:28:47AM -0800, Tom Herbert wrote: > If there is a way for us to test this without setting up a full mobile > network please provide details on how to do that in the commit log. There are different ways how to do this. With the existing in-kernel code (that lac

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Pablo Neira Ayuso
On Thu, Feb 23, 2017 at 03:21:13PM +0100, Andreas Schultz wrote: > - On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: [...] > > According to specs, section 4.4.2.3 Encapsulated T-PDU, TS 29.281. > > > > "The UDP Source Port is a locally allocated port number at the sending > > GTP

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Tom Herbert
On Thu, Feb 23, 2017 at 6:21 AM, Andreas Schultz wrote: > - On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: > >> On Wed, Feb 22, 2017 at 01:47:17PM -0800, Tom Herbert wrote: >>> On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: >>> > On Thu, Feb 16, 2017 at 11:58 PM, Andreas Sc

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Tom Herbert
On Thu, Feb 23, 2017 at 6:00 AM, Pablo Neira Ayuso wrote: > On Thu, Feb 23, 2017 at 10:35:56AM +0100, Andreas Schultz wrote: >> - On Feb 22, 2017, at 10:47 PM, Tom Herbert t...@herbertland.com wrote: > [...] >> > This shouldn't be taken as a HW requirement and it's unlikely we'd add >> > expli

Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings

2017-02-23 Thread Santosh Shilimkar
On 2/23/2017 4:47 AM, kbuild test robot wrote: net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some

Re: [PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID

2017-02-23 Thread Jiri Benc
On Thu, 23 Feb 2017 17:19:41 +0100, Matthias Schiffer wrote: > The incorrect check caused an off-by-one error: the maximum VID 0xff > was unusable. > > Fixes: d342894c5d2f ("vxlan: virtual extensible lan") > Signed-off-by: Matthias Schiffer > --- > v2: check against VXLAN_N_VID instead of cha

Re: [PATCH net-next v4 4/7] gtp: consolidate gtp socket rx path

2017-02-23 Thread Tom Herbert
On Thu, Feb 23, 2017 at 1:19 AM, Andreas Schultz wrote: > Hi Tom, > > - On Feb 22, 2017, at 6:41 PM, Tom Herbert t...@herbertland.com wrote: > >> On Tue, Feb 21, 2017 at 2:18 AM, Andreas Schultz wrote: >>> Add network device to gtp context in preparation for splitting >>> the TEID from the ne

[PATCH] wireless/atmel: remove time_t usage

2017-02-23 Thread Alexandre Belloni
last_qual never really holds a time. It only holds jiffies. Make it the same type as jiffies. Signed-off-by: Alexandre Belloni --- drivers/net/wireless/atmel/atmel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/atmel/atmel.c b/drivers/net/wireless/atm

Re: [PATCH net] vxlan: don't allow overwrite of config src addr

2017-02-23 Thread Jiri Benc
On Mon, 20 Feb 2017 17:25:28 +, Brian Russell wrote: > --- a/drivers/net/vxlan.c > +++ b/drivers/net/vxlan.c > @@ -2019,7 +2019,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct > net_device *dev, > > dst_port = rdst->remote_port ? rdst->remote_port : > vxlan->cfg.ds

[PATCH net v2] vxlan: correctly validate VXLAN ID against VXLAN_N_VID

2017-02-23 Thread Matthias Schiffer
The incorrect check caused an off-by-one error: the maximum VID 0xff was unusable. Fixes: d342894c5d2f ("vxlan: virtual extensible lan") Signed-off-by: Matthias Schiffer --- v2: check against VXLAN_N_VID instead of changing operator drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+

[PATCH net 1/1] tipc: move premature initilalization of stack variables

2017-02-23 Thread Jon Maloy
In the function tipc_rcv() we initialize a couple of stack variables from the message header before that same header has been validated. In rare cases when the arriving header is non-linar, the validation function itself may linearize the buffer by calling skb_may_pull(), while the wrongly initiali

RE: [PATCH net-next 2/2] sctp: add support for MSG_MORE

2017-02-23 Thread David Laight
From: Xin Long > Sent: 23 February 2017 03:46 > On Tue, Feb 21, 2017 at 10:27 PM, David Laight > wrote: > > From: Xin Long > >> Sent: 18 February 2017 17:53 > >> This patch is to add support for MSG_MORE on sctp. > >> > >> It adds force_delay in sctp_datamsg to save MSG_MORE, and sets it after >

Re: [PATCH net] vxlan: don't allow overwrite of config src addr

2017-02-23 Thread Jiri Benc
On Mon, 20 Feb 2017 17:25:28 +, Brian Russell wrote: > When using IPv6 transport and a default dst, a pointer to the configured > source address is passed into the route lookup. If no source address is > configured, then the value is overwritten. > > IPv6 route lookup ignores egress ifindex ma

Re: [PATCH] bpf: fix spelling mistake: "proccessed" -> "processed"

2017-02-23 Thread David Miller
From: Colin King Date: Thu, 23 Feb 2017 00:20:53 + > From: Colin Ian King > > trivial fix to spelling mistake in verbose log message > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH 0/8] Netfilter fixes for net

2017-02-23 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 23 Feb 2017 12:14:01 +0100 > The following patchset contains Netfilter fixes for your net tree, > they are: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git Pulled, thanks a lot!

Re: [PATCH net V3 0/5] mlx4 misc fixes

2017-02-23 Thread David Miller
From: Tariq Toukan Date: Thu, 23 Feb 2017 12:02:40 +0200 > This patchset contains misc bug fixes from Eric Dumazet and our team > to the mlx4 Core and Eth drivers. > > Series generated against net commit: > eee2faabc63d tcp: account for ts offset only if tsecr not zero ... > v3: > * Rebased, co

Re: [patch net] lib: Remove string from parman config selection

2017-02-23 Thread David Miller
From: Jiri Pirko Date: Thu, 23 Feb 2017 10:57:45 +0100 > From: Jiri Pirko > > As reported by Geert, remove the string so the user does not see this > config option. The option is explicitly selected only as a dependency of > in-kernel users. > > Reported-by: Geert Uytterhoeven > Fixes: 44091d

Re: [PATCH 1/1] forcedeth: Remove return from a void function

2017-02-23 Thread David Miller
From: Zhu Yanjun Date: Thu, 23 Feb 2017 03:22:49 -0500 > In a void function, it is not necessary to append a return statement in it. > > Signed-off-by: Zhu Yanjun Applied.

Re: [PATCH v2] uapi: fix linux/seg6.h and linux/seg6_iptunnel.h userspace compilation errors

2017-02-23 Thread David Miller
From: "Dmitry V. Levin" Date: Thu, 23 Feb 2017 14:30:34 +0300 > Include in uapi/linux/seg6.h to fix the following > linux/seg6.h userspace compilation error: > > /usr/include/linux/seg6.h:31:18: error: array type has incomplete element > type 'struct in6_addr' > struct in6_addr segments[0];

Re: [PATCH v2] uapi: fix linux/rds.h userspace compilation errors

2017-02-23 Thread David Miller
From: "Dmitry V. Levin" Date: Thu, 23 Feb 2017 14:35:23 +0300 > Consistently use types from linux/types.h to fix the following > linux/rds.h userspace compilation errors: > > /usr/include/linux/rds.h:198:2: error: unknown type name 'u8' > u8 rx_traces; > /usr/include/linux/rds.h:199:2: error:

Re: [PATCH] uapi: fix linux/ip6_tunnel.h userspace compilation errors

2017-02-23 Thread David Miller
From: "Dmitry V. Levin" Date: Thu, 23 Feb 2017 01:38:03 +0300 > Include and to fix the following > linux/ip6_tunnel.h userspace compilation errors: > > /usr/include/linux/ip6_tunnel.h:23:12: error: 'IFNAMSIZ' undeclared here (not > in a function) > char name[IFNAMSIZ]; /* name of tunnel dev

Re: [PATCH] uapi: fix linux/llc.h userspace compilation error

2017-02-23 Thread David Miller
From: "Dmitry V. Levin" Date: Thu, 23 Feb 2017 01:38:26 +0300 > Include to fix the following linux/llc.h userspace > compilation error: > > /usr/include/linux/llc.h:26:27: error: 'IFHWADDRLEN' undeclared here (not in > a function) > unsigned char sllc_mac[IFHWADDRLEN]; > > Signed-off-by:

Re: [PATCH RFC v2 00/12] socket sendmsg MSG_ZEROCOPY

2017-02-23 Thread David Miller
From: Willem de Bruijn Date: Wed, 22 Feb 2017 11:38:49 -0500 > From: Willem de Bruijn > > RFCv2: > > I have received a few requests for status and rebased code of this > feature. We have been running this code internally, discovering and > fixing various bugs. With net-next closed, now seems l

Re: [PATCH net 0/6] Mellanox mlx5e fixes for 4.11-rc1

2017-02-23 Thread David Miller
From: Saeed Mahameed Date: Wed, 22 Feb 2017 17:20:10 +0200 > This series includes some important bug fixes for mlx5e driver. > > Three misc fixes: > From Mohamad, compilation fix on s390 system > From Me, A fix for driver unload when switchdev mode is on. > From Tariq, HW LRO frag size optimiza

Re: [PATCH net] vxlan: correctly validate VXLAN ID against VXLAN_VID_MASK

2017-02-23 Thread Jiri Benc
On Thu, 23 Feb 2017 13:59:02 +0100, Matthias Schiffer wrote: > The incorrect check caused an off-by-one error: the maximum VID 0xff > was unusable. > > Fixes: d342894c5d2f ("vxlan: virtual extensible lan") > Signed-off-by: Matthias Schiffer > --- > drivers/net/vxlan.c | 2 +- > 1 file change

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

2017-02-23 Thread Rob Herring
On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate > define pr_warning

Re: [PATCH net v5] bpf: add helper to compare network namespaces

2017-02-23 Thread Eric W. Biederman
David Ahern writes: > On 2/19/17 9:17 PM, Eric W. Biederman wrote: @@ -2597,6 +2598,39 @@ static const struct bpf_func_proto bpf_xdp_event_output_proto = { .arg5_type = ARG_CONST_STACK_SIZE, }; +BPF_CALL_3(bpf_sk_netns_cmp, struct sock *, sk, u64, ns_dev,

Re: ip route get oddly fails for ipv6

2017-02-23 Thread Leon Goldberg
Forgot to mention: [root@localhost tests]# uname -r 3.10.0-514.2.2.el7.x86_64 [root@localhost tests]# cat /etc/redhat-release CentOS Linux release 7.2.1511 (Core) On Thu, Feb 23, 2017 at 4:43 PM, Leon Goldberg wrote: > Hey, > > For some reason ip route get fails to retrieve ipv6 routes, althoug

ip route get oddly fails for ipv6

2017-02-23 Thread Leon Goldberg
Hey, For some reason ip route get fails to retrieve ipv6 routes, although the subject destination is indeed reachable: [root@localhost tests]# ip -6 route 2001:1::/64 dev eth1 proto kernel metric 256 fe80::/64 dev eth0 proto kernel metric 256 fe80::/64 dev eth1 proto kernel metric 256 [roo

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Andreas Schultz
- On Feb 23, 2017, at 2:49 PM, pablo pa...@netfilter.org wrote: > On Wed, Feb 22, 2017 at 01:47:17PM -0800, Tom Herbert wrote: >> On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: >> > On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz >> > wrote: >> >> Hi Or, >> >> - On Feb 16, 2017, a

Re: [PATCH v3 net-next 08/14] mlx4: use order-0 pages for RX

2017-02-23 Thread Tariq Toukan
On 23/02/2017 4:18 AM, Alexander Duyck wrote: On Wed, Feb 22, 2017 at 6:06 PM, Eric Dumazet wrote: On Wed, 2017-02-22 at 17:08 -0800, Alexander Duyck wrote: Right but you were talking about using both halves one after the other. If that occurs you have nothing left that you can reuse. Th

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Pablo Neira Ayuso
On Thu, Feb 23, 2017 at 10:35:56AM +0100, Andreas Schultz wrote: > - On Feb 22, 2017, at 10:47 PM, Tom Herbert t...@herbertland.com wrote: [...] > > This shouldn't be taken as a HW requirement and it's unlikely we'd add > > explicit GTP support in flow_dissector. If we can't get entropy in the

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Or Gerlitz
On 2/23/2017 3:49 PM, Pablo Neira Ayuso wrote: "The UDP Source Port is a locally allocated port number at the sending GTP-U entity." and the proposed patch goes in that direction, agree?

Re: [PATCH net-next] net/gtp: Add udp source port generation according to flow hash

2017-02-23 Thread Pablo Neira Ayuso
On Wed, Feb 22, 2017 at 01:47:17PM -0800, Tom Herbert wrote: > On Wed, Feb 22, 2017 at 1:29 PM, Or Gerlitz wrote: > > On Thu, Feb 16, 2017 at 11:58 PM, Andreas Schultz wrote: > >> Hi Or, > >> - On Feb 16, 2017, at 3:59 PM, Or Gerlitz ogerl...@mellanox.com wrote: > >> > >>> Generate the source

Re: Software loopback with phy 88E1116R and marvell MV78100 gbe

2017-02-23 Thread Andrew Lunn
On Thu, Feb 23, 2017 at 12:28:10PM +0100, Paolo Minazzi wrote: > On Thu, Feb 23, 2017 at 11:59 AM, Andrew Lunn wrote: > >> I tried to do the same things on 88E1116R, setting the but 14 of reg 0. > >> But If I do it I lose the link, and the test program does not work. > >> I tried to force the link

[PATCH] net: stmmac: unify registers dumps methods

2017-02-23 Thread Corentin Labbe
The stmmac driver have two methods for registers dumps: via ethtool and at init (if NETIF_MSG_HW is enabled). It is better to keep only one method, ethtool, since the other was ugly. This patch convert all dump_regs() function from "printing regs" to "fill the reg_space used by ethtool". Signed-

[PATCH net] vxlan: correctly validate VXLAN ID against VXLAN_VID_MASK

2017-02-23 Thread Matthias Schiffer
The incorrect check caused an off-by-one error: the maximum VID 0xff was unusable. Fixes: d342894c5d2f ("vxlan: virtual extensible lan") Signed-off-by: Matthias Schiffer --- drivers/net/vxlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan.c b/drivers/

[PATCH] RDS: IB: fix ifnullfree.cocci warnings

2017-02-23 Thread kbuild test robot
net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on check

[PATCH net] sctp: deny peeloff operation on asocs with threads sleeping on it

2017-02-23 Thread Marcelo Ricardo Leitner
commit 2dcab5984841 ("sctp: avoid BUG_ON on sctp_wait_for_sndbuf") attempted to avoid a BUG_ON call when the association being used for a sendmsg() is blocked waiting for more sndbuf and another thread did a peeloff operation on such asoc, moving it to another socket. As Ben Hutchings noticed, the

[PATCH iproute2 master] {f,m}_bpf: dump tag over insns

2017-02-23 Thread Daniel Borkmann
We already export TCA_BPF_TAG resp. TCA_ACT_BPF_TAG from kernel commit f1f7714ea51c ("bpf: rework prog_digest into prog_tag"), thus also dump it when filter/actions are shown. Signed-off-by: Daniel Borkmann --- tc/f_bpf.c | 9 + tc/m_bpf.c | 9 + 2 files changed, 18 insertions(+)

  1   2   >