Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

On Tue, Dec 13, 2016 at 1:52 AM, Doug Ledford wrote: > On 12/9/2016 1:47 AM, Selvin Xavier wrote: >> This series introduces the RoCE driver for the Broadcom >> NetXtreme-E 10/25/40/50 gigabit RoCE HCAs. >> This driver is dependent on the bnxt_en NIC driver and is >> based on the bnxt_re branch in

Re: netlink: GPF in sock_sndtimeo

On 2016-12-09 23:40, Cong Wang wrote: > On Fri, Dec 9, 2016 at 8:13 PM, Cong Wang wrote: > > On Fri, Dec 9, 2016 at 3:01 AM, Richard Guy Briggs wrote: > >> On 2016-12-08 22:57, Cong Wang wrote: > >>> On Thu, Dec 8, 2016 at 10:02 PM, Richard Guy Briggs > >>> wrote: > >>> > I also tried to extend

Re: Synopsys Ethernet QoS

On 12/12/2016 5:25 PM, Niklas Cassel wrote: On 12/12/2016 11:19 AM, Joao Pinto wrote: Hi, Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu: Le 12/09/16 à 16:16, Andy Shevchenko a écrit : On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli wrote: It's kind of sad that customers of that

Re: stmmac DT property snps,axi_all

Hello Niklas, Alex, my fault and a step behind... Current code is OK when manage the AAL that, although it is passed from the axi structure, it is always used to program, for all the chip versions, the writable bit inside the DMA_BUS_MODE register. So I guess no extra patch is needed. Regards Pe

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

On Mon, Dec 12, 2016 at 8:52 PM, Selvin Xavier wrote: >> CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_rcfw.c >> CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_sp.c >> CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c >> drivers/infiniband/hw/bnxtre/bnxt_qplib_fp.c:1015:22: warning: c

Re: [PATCH V2 18/22] bnxt_re: Support for DCB

On Sat, Dec 10, 2016 at 7:20 PM, Or Gerlitz wrote: > On Fri, Dec 9, 2016 at 8:48 AM, Selvin Xavier > wrote: >> This patch queries the configured RoCE APP Priority on the host >> using the dcbnl API and programs the RoCE FW with the corresponding >> Traffic Class(es) for the priority. > >> +#defin

[PATCH net] virtio-net: correctly enable multiqueue

Commit 4490001029012539937ff02778fe6180613fa949 ("virtio-net: enable multiqueue by default") blindly set the affinity instead of queues during probe which can cause a mismatch of #queues between guest and host. This patch fixes it by setting queues. Reported-by: Theodore Ts'o Tested-by: Theodore

Re: [PATCH V2 13/22] bnxt_re: Support QP verbs

On Mon, Dec 12, 2016 at 11:57 PM, Leon Romanovsky wrote: > It can help to review if you break this function into smaller pieces and > get rid of switch->switch->if construction. Thanks Leon. I will address this and your previous comments in v3 patch set.

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

On Mon, Dec 12, 2016 at 10:37 PM, Jason Gunthorpe wrote: > On Sat, Dec 10, 2016 at 11:06:58AM +0530, Selvin Xavier wrote: >> On Fri, Dec 9, 2016 at 12:17 PM, Selvin Xavier >> wrote: >> > I am preparing a git repository with these changes as per Jason's >> > comment and will share the details late

[PATCH iproute2 1/2] tc: flower: Fix typo in the flower man page

Replace vlan_eth_type with vlan_ethtype. Fixes: 745d91726006 ("tc: flower: Introduce vlan support") Signed-off-by: Roi Dayan Reviewed-by: Hadar Hen Zion --- man/man8/tc-flower.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/man8/tc-flower.8 b/man/man8/tc-flower.8 i

[PATCH iproute2 2/2] tc: tunnel_key: Add tc-tunnel_key man page to Makefile

To be installed with the other man pages. Fixes: d57639a475a9 ("tc/act_tunnel: Introduce ip tunnel action") Signed-off-by: Roi Dayan Reviewed-by: Amir Vadai --- man/man8/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/man/man8/Makefile b/man/man8/Makefile index de6f249..d4cb01a 100

[PATCH iproute2 0/2] Man page fixes

Hi, The 2 patches are man page related only. First fixes a typo and second adding missing man page to the Makefile. Thanks Roi Dayan (2): tc: flower: Fix typo in the flower man page tc: tunnel_key: Add tc-tunnel_key man page to Makefile man/man8/Makefile| 1 + man/man8/tc-flower.8 | 4

Re: [PATCH net-next 00/27] Remove VLAN CFI bit abuse

On Tue, Dec 13, 2016 at 01:12:32AM +0100, Michał Mirosław wrote: > Dear NetDevs > > This series removes an abuse of VLAN CFI bit in Linux networking stack. > Currently Linux always clears the bit on outgoing traffic and presents > it cleared to userspace (even via AF_PACKET/tcpdump when hw-acceler

Re: [PATCH v2] audit: use proper refcount locking on audit_sock

On 2016-12-12 15:18, Paul Moore wrote: > On Mon, Dec 12, 2016 at 5:03 AM, Richard Guy Briggs wrote: > > Resetting audit_sock appears to be racy. > > > > audit_sock was being copied and dereferenced without using a refcount on > > the source sock. > > > > Bump the refcount on the underlying sock wh

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

On Mon, Dec 12, 2016 at 10:24 PM, Jonathan Toppins wrote: > CHECK drivers/infiniband/hw/bnxtre/bnxt_re_debugfs.c > CHECK drivers/infiniband/hw/bnxtre/bnxt_qplib_res.c > drivers/infiniband/hw/bnxtre/bnxt_qplib_res.c:729:6: warning: symbol > 'bnxt_qplib_cleanup_pkey_tbl' was not declared. Shou

Re: [PATCH v2] audit: use proper refcount locking on audit_sock

On 2016-12-12 12:10, Paul Moore wrote: > On Mon, Dec 12, 2016 at 5:03 AM, Richard Guy Briggs wrote: > > Resetting audit_sock appears to be racy. > > > > audit_sock was being copied and dereferenced without using a refcount on > > the source sock. > > > > Bump the refcount on the underlying sock wh

Re: [PATCH V2 for-next 00/11] Code improvements & fixes for HNS RoCE driver

On 11/15/2016 1:10 PM, Salil Mehta wrote: > This patchset introduces some code improvements and fixes > for the identified problems in the HNS RoCE driver. > > Lijun Ou (4): > IB/hns: Add the interface for querying QP1 > IB/hns: add self loopback for CM > IB/hns: Modify the condition of noti

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

On Tue, Dec 13, 2016 at 11:43:00AM +0800, Jason Wang wrote: > Thanks for reporting this issue. Looks like I blindly set the affinity > instead of queues during probe. Could you please try the following patch to > see if it works? This fixed things, thanks!!

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

On Tue, Dec 13, 2016 at 5:22 AM, Doug Ledford wrote: > > There are outstanding review comments to be addressed still yet, and the > v2 patchset doesn't compile for me in 0day testing. I'm going to bounce > this one to 4.11. I will address all review comments and fix the 0day compilation error an

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

On 2016年12月13日 11:12, Theodore Ts'o wrote: On Tue, Dec 13, 2016 at 04:28:17AM +0200, Michael S. Tsirkin wrote: That's unfortunate, of course. It could be a hypervisor or a guest kernel bug. ideas: - does host have mq capability? how many queues? - how about # of msix vectors? - after you send

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

On Mon, Dec 12, 2016 at 10:12:43PM -0500, Theodore Ts'o wrote: > On Tue, Dec 13, 2016 at 04:28:17AM +0200, Michael S. Tsirkin wrote: > > > > That's unfortunate, of course. It could be a hypervisor or > > a guest kernel bug. ideas: > > - does host have mq capability? how many queues? > > - how abou

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

On Tue, Dec 13, 2016 at 04:28:17AM +0200, Michael S. Tsirkin wrote: > > That's unfortunate, of course. It could be a hypervisor or > a guest kernel bug. ideas: > - does host have mq capability? how many queues? > - how about # of msix vectors? > - after you send something on tx queues, > are int

Re: "virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

On Mon, Dec 12, 2016 at 06:33:43PM -0500, Theodore Ts'o wrote: > Hi, > > I was doing a last minute regression test of the ext4 tree before > sending a pull request to Linus, which I do using gce-xfstests[1], and > I found that using networking was broken on GCE on linux-next. I was > using next-2

Re: [PATCH 0/6] USB support for Broadcom NSP SoC

On 11/09/2016 01:33 AM, Yendapally Reddy Dhananjaya Reddy wrote: > This patch set contains the usb support for Broadcom NSP SoC. > The usb phy is connected through mdio interface. The mdio interface > can be used to access either internal phys or external phys using a > multiplexer. > > The first

Re: [PATCH v2 1/4] net: hix5hd2_gmac: add generic compatible string

On 2016/12/12 22:21, Rob Herring wrote: > On Mon, Dec 12, 2016 at 5:16 AM, Dongpo Li wrote: >> Hi Rob, >> >> On 2016/12/10 6:35, Rob Herring wrote: >>> On Mon, Dec 05, 2016 at 09:27:58PM +0800, Dongpo Li wrote: The "hix5hd2" is SoC name, add the generic ethernet driver name. The "hisi-

RE: [PATCH net-next 09/27] cxgb4: use __vlan_hwaccel helpers

> This also initializes vlan_proto field. > > Signed-off-by: Michał Mirosław Acked-by: Steve Wise

Re: [PATCH net-next 2/5] liquidio VF vxlan

Or Gerlitz wrote on Sat [2016-Dec-10 05:46:13 -0800]: > On Fri, Dec 9, 2016 at 12:42 AM, Vatsavayi, Raghu > wrote: > >> From: Or Gerlitz [mailto:gerlitz...@gmail.com] > >> On Thu, Dec 8, 2016 at 11:00 PM, Raghu Vatsavayi > >> wrote: > > >>> Adds VF vxlan offload support. > > >> What's the use

Re: [PATCH net-next 20/27] net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI

I assume you want to merge this together with the rest of you series, so Acked-by: Ralf Baechle Cheers, Ralf On Tue, Dec 13, 2016 at 01:12:39AM +0100, Michał Mirosław wrote: > Date: Tue, 13 Dec 2016 01:12:39 +0100 (CET) > From: Michał Mirosław > To: netdev@vger.kernel.org > Cc: Ralf Baech

Soft lockup in tc_classify

Hi All, sorry for the spam, the first time was sent with html part and was rejected. We observed an issue where a classifier instance next member is pointing back to itself, causing a CPU soft lockup. We found it by running traffic on many udp connections and then adding a new flower rule usin

[PATCH net-next 13/27] bridge: use __vlan_hwaccel helpers

This removes assumption than vlan_tci != 0 when tag is present. Signed-off-by: Michał Mirosław --- net/bridge/br_netfilter_hooks.c | 14 -- net/bridge/br_private.h | 2 +- net/bridge/br_vlan.c| 6 +++--- 3 files changed, 12 insertions(+), 10 deletions(-) diff -

[PATCH net-next 09/27] cxgb4: use __vlan_hwaccel helpers

This also initializes vlan_proto field. Signed-off-by: Michał Mirosław --- drivers/infiniband/hw/cxgb4/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index f1510cc..66a3d39 100644 --- a/drivers/infiniba

[PATCH net-next 11/27] sky2: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/marvell/sky2.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index b60ad0e..bcd20e0 100644 --- a/drivers/net/ethernet/marvell/sky2.c +++ b

[PATCH net-next 21/27] net/bpf_jit: PPC: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- arch/powerpc/net/bpf_jit_comp.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/net/bpf_jit_comp.c b/arch/powerpc/net/bpf_jit_comp.c index 7e706f3..22ae63f 100644 --- a/arch/powerpc/net/bpf_jit_comp.c +++ b/arch

[PATCH net-next 24/27] bpf_test: prepare for VLAN_TAG_PRESENT removal

Signed-off-by: Michał Mirosław --- lib/test_bpf.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 0362da0..00d3450 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -691,8 +691,13 @@ static struct bpf_test tests[] = { CL

[PATCH net-next 15/27] ipv4/tunnel: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- net/ipv4/ip_tunnel_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c index fed3d29..0004a54 100644 --- a/net/ipv4/ip_tunnel_core.c +++ b/net/ipv4/ip_tunnel_core.c @@ -120,7 +120,7 @@

[PATCH net-next 00/27] Remove VLAN CFI bit abuse

Dear NetDevs This series removes an abuse of VLAN CFI bit in Linux networking stack. Currently Linux always clears the bit on outgoing traffic and presents it cleared to userspace (even via AF_PACKET/tcpdump when hw-accelerated). This uses a new vlan_present bit in struct skbuff, and removes an a

[PATCH net-next 16/27] nfnetlink/queue: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- net/netfilter/nfnetlink_queue.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index be7627b..f268bb9 100644 --- a/net/netfilter/nfnetlink_queue.c +++ b/net/netfilter/nfn

[PATCH net-next 14/27] 8021q: use __vlan_hwaccel helpers

Signed-off-by: Michał Mirosław --- net/8021q/vlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c index e2ed698..604a67a 100644 --- a/net/8021q/vlan_core.c +++ b/net/8021q/vlan_core.c @@ -50,7 +50,7 @@ bool vlan_do_receive(s

[PATCH net-next 22/27] net/bpf_jit: SPARC: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- arch/sparc/net/bpf_jit_comp.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/sparc/net/bpf_jit_comp.c b/arch/sparc/net/bpf_jit_comp.c index a6d9204..61cc15d 100644 --- a/arch/sparc/net/bpf_jit_comp.c +++ b/arch/sparc

[PATCH net-next 02/27] net/vlan: introduce __vlan_hwaccel_copy_tag() helper

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 38be904..75e839b 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -393,6 +393,19 @@ static inl

[PATCH net-next 26/27] net/hyperv: enable passing of VLAN.CFI bit

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/netvsc_drv.c | 1 + drivers/net/hyperv/rndis_filter.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 6597d79..4e20f4c 100644 --- a/drivers/net/hyperv/netvsc_drv.c

[PATCH net-next 19/27] net/bpf_jit: ARM: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- arch/arm/net/bpf_jit_32.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c index 93d0b6d..6dbc602 100644 --- a/arch/arm/net/bpf_jit_32.c +++ b/arch/arm/net/bpf_jit_32.c @

[PATCH net-next 27/27] net/vlan: remove unused #define HAVE_VLAN_GET_TAG

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 8ff2f0e..f0b9356 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -477,8 +477,6 @@ static inline int __vlan_

[PATCH net-next 05/27] i40iw: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c index 8563769..25cf689 100644 --- a/drivers/infiniband/hw/i40iw/i4

[PATCH net-next 23/27] net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- net/core/filter.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index b146170..c3321f1 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -188,22 +188,20 @@ static u32 conve

[PATCH net-next 17/27] OVS: remove assumptions about VLAN_TAG_PRESENT bit

This leaves CFI bit toggled in API, because userspace might depend this is set for normal ethernet traffic with tag present. Signed-off-by: Michał Mirosław --- Documentation/networking/openvswitch.txt | 14 net/openvswitch/actions.c| 13 +++ net/openvswitch/flow.c

[PATCH net-next 01/27] net/vlan: introduce __vlan_hwaccel_clear_tag() helper

Signed-off-by: Michał Mirosław --- include/linux/if_vlan.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 8d5fcd6..38be904 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -382,6 +382,1

[PATCH net-next 20/27] net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- arch/mips/net/bpf_jit.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/mips/net/bpf_jit.c b/arch/mips/net/bpf_jit.c index 49a2e22..4b12b5d 100644 --- a/arch/mips/net/bpf_jit.c +++ b/arch/mips/net/bpf_jit.c @@ -1138

[PATCH net-next 18/27] net/skbuff: add macros for VLAN_PRESENT bit

Signed-off-by: Michał Mirosław --- include/linux/skbuff.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 332e767..4a85a1f 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -768,6 +768,12 @@ struct sk_buff {

[PATCH net-next 03/27] ibmvnic: fix accelerated VLAN handling

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/ibm/ibmvnic.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index c125966..c7664db 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/driv

[PATCH net-next 25/27] net: remove VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- arch/mips/net/bpf_jit.c | 3 --- arch/powerpc/net/bpf_jit_comp.c | 3 --- arch/sparc/net/bpf_jit_comp.c | 4 include/linux/if_vlan.h | 11 ++- include/linux/skbuff.h | 16 +--- lib/test_bpf.c

[PATCH net-next 07/27] gianfar: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index 56588f2..95fa647 100644 --- a/

[PATCH net-next 04/27] qlcnic: remove assumption that vlan_tci != 0

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c index fedd736..c3cc707 100644 --- a/driver

[PATCH net-next 06/27] cnic: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/ethernet/broadcom/cnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/cnic.c b/drivers/net/ethernet/broadcom/cnic.c index b1d2ac8..6e3c610 100644 --- a/drivers/net/ethernet/broadcom/cnic.c +++ b/d

[PATCH net-next 08/27] net/hyperv: remove use of VLAN_TAG_PRESENT

Signed-off-by: Michał Mirosław --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc_drv.c | 13 ++--- drivers/net/hyperv/rndis_filter.c | 4 ++-- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyp

Re: netlink: GPF in sock_sndtimeo

On Mon, Dec 12, 2016 at 2:02 AM, Richard Guy Briggs wrote: > On 2016-12-09 20:13, Cong Wang wrote: >> Netlink notifier can safely be converted to blocking one, I will send >> a patch. > > I had a quick look at how that might happen. The netlink notifier chain > is atomic. Would the registered ca

Re: [PATCH v2] audit: use proper refcount locking on audit_sock

On Mon, Dec 12, 2016 at 2:03 AM, Richard Guy Briggs wrote: > Resetting audit_sock appears to be racy. > > audit_sock was being copied and dereferenced without using a refcount on > the source sock. > > Bump the refcount on the underlying sock when we store a refrence in > audit_sock and release it

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

On 12/9/2016 1:47 AM, Selvin Xavier wrote: > This series introduces the RoCE driver for the Broadcom > NetXtreme-E 10/25/40/50 gigabit RoCE HCAs. > This driver is dependent on the bnxt_en NIC driver and is > based on the bnxt_re branch in Doug's repository. bnxt_en changes > required for this pat

Re: [iproute2 v2 net-next 0/8] Add support for vrf helper

On Sat, 10 Dec 2016 12:32:06 -0800 David Ahern wrote: > This series adds support to iproute2 to run a command against a specific > VRF. The user semnatics are similar to 'ip netns'. > > The 'ip vrf' subcommand supports 3 usages: > > 1. Run a command against a given vrf: >ip vrf exec NAM

"virtio-net: enable multiqueue by default" in linux-next breaks networking on GCE

Hi, I was doing a last minute regression test of the ext4 tree before sending a pull request to Linus, which I do using gce-xfstests[1], and I found that using networking was broken on GCE on linux-next. I was using next-20161209, and after bisecting things, I narrowed down the commit which causi

[ANNOUNCE] iproute2 4.9

Release of iproute2 for Linux 4.9, just in time for your holiday giving. Update to iproute2 utility to support new features in Linux 4.9. Mostly this is refinements to add new flags to tipc, l2tp, ss and macsec support. There are also a couple of performance enhancments for handling lots of interf

Re: Soft lockup in tc_classify

On Mon, Dec 12, 2016 at 1:18 PM, Or Gerlitz wrote: > On Mon, Dec 12, 2016 at 3:28 PM, Daniel Borkmann wrote: > >> Note that there's still the RCU fix missing for the deletion race that >> Cong will still send out, but you say that the only thing you do is to >> add a single rule, but no other ope

[PATCH] net: cirrus: ep93xx: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/cirrus/ep93xx_eth.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/cirrus

Re: Soft lockup in inet_put_port on 4.6

On Mon, Dec 12, 2016 at 1:44 PM, Hannes Frederic Sowa wrote: On 12.12.2016 19:05, Josef Bacik wrote: On Fri, Dec 9, 2016 at 11:14 PM, Eric Dumazet wrote: On Fri, 2016-12-09 at 19:47 -0800, Eric Dumazet wrote: Hmm... Is your ephemeral port range includes the port your load balanci

Re: [PATCH for-next 0/6] IB/hns: Bug Fixes for HNS RoCE Driver

On 11/29/2016 6:10 PM, Salil Mehta wrote: > This patch-set contains bug fixes for the HNS RoCE driver. > > Lijun Ou (1): > IB/hns: Fix the IB device name > > Shaobo Xu (2): > IB/hns: Fix the bug when free mr > IB/hns: Fix the bug when free cq > > Wei Hu (Xavier) (3): > IB/hns: Fix the bu

Re: [PATCH V3 for-next 00/11] Code improvements & fixes for HNS RoCE driver

On 11/23/2016 2:40 PM, Salil Mehta wrote: > This patchset introduces some code improvements and fixes > for the identified problems in the HNS RoCE driver. > > Lijun Ou (4): > IB/hns: Add the interface for querying QP1 > IB/hns: add self loopback for CM > IB/hns: Modify the condition of noti

Re: Soft lockup in inet_put_port on 4.6

On Mon, Dec 12, 2016 at 1:44 PM, Hannes Frederic Sowa wrote: On 12.12.2016 19:05, Josef Bacik wrote: On Fri, Dec 9, 2016 at 11:14 PM, Eric Dumazet wrote: On Fri, 2016-12-09 at 19:47 -0800, Eric Dumazet wrote: Hmm... Is your ephemeral port range includes the port your load balancing

Re: Soft lockup in tc_classify

On Mon, Dec 12, 2016 at 3:28 PM, Daniel Borkmann wrote: > Note that there's still the RCU fix missing for the deletion race that > Cong will still send out, but you say that the only thing you do is to > add a single rule, but no other operation in involved during that test? What's missing to ha

Re: [RFC PATCH net-next v3 1/2] macb: Add 1588 support in Cadence GEM.

On Mon, Dec 12, 2016 at 10:22:43AM +, andrei.pistir...@microchip.com wrote: > Richard, are you agree with this? Yes, but please trim your replies next time. Scrolling through pages of quoted headers and stale content in order to read one line is very annoying. Thanks, Richard

Re: [PATCH V2 10/22] bnxt_re: Support for CQ verbs

On 12/09/2016 01:48 AM, Selvin Xavier wrote: > This patch implements support for create_cq, destroy_cq and req_notify_cq > verbs. > > Signed-off-by: Eddie Wai > Signed-off-by: Devesh Sharma > Signed-off-by: Somnath Kotur > Signed-off-by: Sriharsha Basavapatna > Signed-off-by: Selvin Xavier >

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

12.12.2016, 20:18, "Leon Romanovsky" : > On Mon, Dec 12, 2016 at 03:04:28PM +0200, Ozgur Karatas wrote: >>  Dear Romanovsky; > > Please avoid top-posting in your replies. > Thanks Dear Leon; thanks for the information., I will pay attention. >>  I'm trying to learn english and I apologize for

Re: [PATCH v2] audit: use proper refcount locking on audit_sock

On Mon, Dec 12, 2016 at 5:03 AM, Richard Guy Briggs wrote: > Resetting audit_sock appears to be racy. > > audit_sock was being copied and dereferenced without using a refcount on > the source sock. > > Bump the refcount on the underlying sock when we store a refrence in > audit_sock and release it

Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

Hi Andrew, Andrew Lunn writes: > Humm, it looks like we are doing the atu_get wrong. We are looking for > a specific MAC address. Yet we seem to be walking the whole table to > find it, rather than getting the hardware to do the search. We are not doing it wrong, the hardware does the search.

Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

On Mon, Dec 12, 2016 at 08:37:50AM -0800, Florian Fainelli wrote: > On 12/12/2016 07:22 AM, Volodymyr Bendiuga wrote: > > Hi, > > > > I apologise for incorrectly formatted patch, I will fix and resend it. > > The problem with the ATU right now is that it is too slow when inserting > > entries. > >

Re: Soft lockup in tc_classify

On Mon, Dec 12, 2016 at 8:04 AM, Shahar Klein wrote: > > > On 12/12/2016 3:28 PM, Daniel Borkmann wrote: >> >> Hi Shahar, >> >> On 12/12/2016 10:43 AM, Shahar Klein wrote: >>> >>> Hi All, >>> >>> sorry for the spam, the first time was sent with html part and was >>> rejected. >>> >>> We observed a

Re: Soft lockup in inet_put_port on 4.6

On 12.12.2016 19:05, Josef Bacik wrote: > On Fri, Dec 9, 2016 at 11:14 PM, Eric Dumazet > wrote: >> On Fri, 2016-12-09 at 19:47 -0800, Eric Dumazet wrote: >> >>> >>> Hmm... Is your ephemeral port range includes the port your load >>> balancing app is using ? >> >> I suspect that you might have p

Re: [PATCH V2 13/22] bnxt_re: Support QP verbs

On Thu, Dec 08, 2016 at 10:48:07PM -0800, Selvin Xavier wrote: > This patch implements create_qp, destroy_qp, query_qp and modify_qp verbs. > > v2: Fixed sparse warnings > > Signed-off-by: Eddie Wai > Signed-off-by: Devesh Sharma > Signed-off-by: Somnath Kotur > Signed-off-by: Sriharsha Basavapa

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

On Mon, Dec 12, 2016 at 03:04:28PM +0200, Ozgur Karatas wrote: > Dear Romanovsky; Please avoid top-posting in your replies. Thanks > > I'm trying to learn english and I apologize for my mistake words and phrases. > So, I think the code when call to "sg_set_buf" and next time set memory and > bu

Re: Designing a safe RX-zero-copy Memory Model for Networking

On Mon, 12 Dec 2016, Jesper Dangaard Brouer wrote: > Hmmm. If you can rely on hardware setup to give you steering and > dedicated access to the RX rings. In those cases, I guess, the "push" > model could be a more direct API approach. If the hardware does not support steering then one should be

Re: Soft lockup in inet_put_port on 4.6

On Fri, Dec 9, 2016 at 11:14 PM, Eric Dumazet wrote: On Fri, 2016-12-09 at 19:47 -0800, Eric Dumazet wrote: Hmm... Is your ephemeral port range includes the port your load balancing app is using ? I suspect that you might have processes doing bind( port = 0) that are trapped into the bind

Re: Soft lockup in tc_classify

On 12/12/2016 3:28 PM, Daniel Borkmann wrote: Hi Shahar, On 12/12/2016 10:43 AM, Shahar Klein wrote: Hi All, sorry for the spam, the first time was sent with html part and was rejected. We observed an issue where a classifier instance next member is pointing back to itself, causing a CPU so

Re: [PATCH] sh_eth: add wake-on-lan support via magic packet

On 12/12/2016 06:49 PM, Niklas Söderlund wrote: Thanks for your feedback. Not at all, it's my duty now. :-) I should probably have warned you not to post the new version to netdev -- DaveM has closed his net-next.git tree (ahead of the usual time, which would have been 4.9 release), so

Re: [PATCH v2] audit: use proper refcount locking on audit_sock

On Mon, Dec 12, 2016 at 5:03 AM, Richard Guy Briggs wrote: > Resetting audit_sock appears to be racy. > > audit_sock was being copied and dereferenced without using a refcount on > the source sock. > > Bump the refcount on the underlying sock when we store a refrence in > audit_sock and release it

Re: Designing a safe RX-zero-copy Memory Model for Networking

On Mon, 12 Dec 2016 06:49:03 -0800 John Fastabend wrote: > On 16-12-12 06:14 AM, Mike Rapoport wrote: > > On Mon, Dec 12, 2016 at 10:40:42AM +0100, Jesper Dangaard Brouer wrote: > >> > >> On Mon, 12 Dec 2016 10:38:13 +0200 Mike Rapoport > >> wrote: > >> > >>> Hello Jesper, > >>> > >>> On Mo

Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

Hi all, Florian Fainelli writes: > Seeing such a change makes me wonder if we should not try to push some > of this hashtable abstraction (provided that we agree we want it) at a > higher layer, like net/dsa/slave.c? That is the major reason why I am reluctant to cache stuffs in drivers. In mo

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

On Sat, Dec 10, 2016 at 11:06:58AM +0530, Selvin Xavier wrote: > On Fri, Dec 9, 2016 at 12:17 PM, Selvin Xavier > wrote: > > I am preparing a git repository with these changes as per Jason's > > comment and will share the details later today. > > Please use bnxt_re branch in this git repository.

Re: [PATCH net-next 0/2] Add ethtool set regs support

On 12/11/2016 07:22 AM, Andrew Lunn wrote: > On Sun, Dec 11, 2016 at 02:18:00PM +0200, Saeed Mahameed wrote: >> On Wed, Dec 7, 2016 at 4:41 AM, Andrew Lunn wrote: >>> On Wed, Dec 07, 2016 at 12:33:08AM +0200, Saeed Mahameed wrote: Hi Dave, This series adds the support for setting de

Re: [PATCH V2 00/22] Broadcom RoCE Driver (bnxt_re)

On 12/09/2016 01:47 AM, Selvin Xavier wrote: > This series introduces the RoCE driver for the Broadcom > NetXtreme-E 10/25/40/50 gigabit RoCE HCAs. > This driver is dependent on the bnxt_en NIC driver and is > based on the bnxt_re branch in Doug's repository. bnxt_en changes > required for this p

Re: fib_frontend: Add network specific broadcasts, when it takes a sense

On 12.12.2016 15:44, Brandon Philips wrote: > On Mon, Dec 12, 2016 at 9:30 AM, Jiri Benc wrote: >> On Fri, 9 Dec 2016 15:41:52 -0800, Brandon Philips wrote: >>> The issue we have: when creating the VXLAN interface and assigning it >>> an address we see a broadcast route being added by the Kernel.

RE: Re: Synopsys Ethernet QoS

Niklas Cassel wrote at Monday, December 12, 2016 9:25 AM: ... > However, I've noticed that NVIDIA has extended the DWC EQoS DT binding, > I don't how easy it would be for them to switch to stmmac's DT binding. > (Adding Stephen Warren to CC.) I don't believe there's any issue switching drivers, so

Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

On 12/12/2016 07:22 AM, Volodymyr Bendiuga wrote: > Hi, > > I apologise for incorrectly formatted patch, I will fix and resend it. > The problem with the ATU right now is that it is too slow when inserting > entries. > When the OS boots up, it might insert some multicast entries into the > atu (if

Re: [PATCH] net:phy fix driver reference count error when attach and detach phy device

On 12/12/2016 12:49 AM, maowenan wrote: > > > On 2016/12/5 16:47, maowenan wrote: >> >> >> On 2016/12/2 17:45, David Laight wrote: >>> From: Mao Wenan Sent: 30 November 2016 10:23 The nic in my board use the phy dev from marvell, and the system will load the marvell phy driver auto

Re: Misalignment, MIPS, and ip_hdr(skb)->version

David Laight writes: > From: Måns Rullgård >> Sent: 10 December 2016 13:25 > ... >> I solved this problem in an Ethernet driver by copying the initial part >> of the packet to an aligned skb and appending the remainder using >> skb_add_rx_frag(). The kernel network stack only cares about the >>

Re: [PATCH 0/2] net: ethernet: hisilicon: set dev->dev.parent before PHY connect

On 12/12/2016 04:03 AM, Dongpo Li wrote: > This patch series builds atop: > ec988ad78ed6d184a7f4ca6b8e962b0e8f1de461 ("phy: Don't increment MDIO bus > refcount unless it's a different owner") > > I have checked all the hisilicon ethernet driver and found only two drivers > need to be fixed to make

Re: [PATCH 1/2] net: ethernet: hisi_femac: Call SET_NETDEV_DEV()

On 12/12/2016 04:03 AM, Dongpo Li wrote: > The hisi_femac driver calls into PHYLIB which now checks for > net_device->dev.parent, so make sure we do set it before calling into > any MDIO/PHYLIB related function. > > Fixes: ec988ad78ed6 ("phy: Don't increment MDIO bus refcount unless it's a > diff

Re: [PATCH 2/2] net: ethernet: hip04: Call SET_NETDEV_DEV()

On 12/12/2016 04:03 AM, Dongpo Li wrote: > The hip04 driver calls into PHYLIB which now checks for > net_device->dev.parent, so make sure we do set it before calling into > any MDIO/PHYLIB related function. > > Fixes: ec988ad78ed6 ("phy: Don't increment MDIO bus refcount unless it's a > different

Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

Hi Volodymyr, Volodymyr Bendiuga writes: > +struct pvec_tbl_entry { > +struct hlist_node entry; > +u32 key_crc32; /* key */ > +u16 pvec; > +struct pvec_tbl_key { > +u8 addr[ETH_ALEN]; > +u16 fid; > +} key; > +}; > + > struc

Re: Re: Synopsys Ethernet QoS

On 12/12/2016 11:19 AM, Joao Pinto wrote: > Hi, > > Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu: >> Le 12/09/16 à 16:16, Andy Shevchenko a écrit : >>> On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli >>> wrote: >>> It's kind of sad that customers of that IP (stmmac, amd-xgbe, sxg

RE: Misalignment, MIPS, and ip_hdr(skb)->version

From: Måns Rullgård > Sent: 10 December 2016 13:25 ... > I solved this problem in an Ethernet driver by copying the initial part > of the packet to an aligned skb and appending the remainder using > skb_add_rx_frag(). The kernel network stack only cares about the > headers, so the alignment of the

[PATCHv2 1/5] sh_eth: add generic wake-on-lan support via magic packet

Add generic functionality to support Wake-on-Lan using MagicPacket which are supported by at least a few versions of sh_eth. Only add functionality for WoL, no specific sh_eth version are marked to support WoL yet. WoL is enabled in the suspend callback by setting MagicPacket detection and disabli

  1   2   >