> From: Pan Bian
>
> When calling dma_mapping_error(), the value of return variable rc is 0.
> And when the call returns an unexpected value, rc is not set to a negative
> errno. Thus, it will return 0 on the error path, and its callers cannot detect
> the bug. This patch fixes the bug, assigning
On 12/2/2016 7:02 PM, Baicar, Tyler wrote:
> Hello Sasha,
>
> Were you able to reproduce this issue?
>
> Do you have a patch fixing the close function inconsistencies that you
> mentioned which I could try out?
>
> Thanks,
> Tyler
>
> On 11/21/2016 1:40 PM, Baicar, Tyler wrote:
>> On 11/17/2016
On Sat, 2016-12-03 at 23:07 -0800, Eric Dumazet wrote:
> From: Eric Dumazet
>
> 1) Old code was hard to maintain, due to complex lock chains.
>(We probably will be able to remove some kfree_rcu() in callers)
>
> 2) Using a single timer to update all estimators does not scale.
>
> 3) Code wa
From: Eric Dumazet
1) Old code was hard to maintain, due to complex lock chains.
(We probably will be able to remove some kfree_rcu() in callers)
2) Using a single timer to update all estimators does not scale.
3) Code was buggy on 32bit kernel (WRITE_ONCE() on 64bit quantity
is not suppo
From: Eric Dumazet
1) Old code was hard to maintain, due to complex lock chains.
(We probably will be able to remove some kfree_rcu() in callers)
2) Using a single timer to update all estimators does not scale.
3) Code was buggy on 32bit kernel (WRITE_ONCE() on 64bit quantity
is not suppo
From: Pan Bian
Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate
memory, and jumps to label "lbl" if the allocation fails. Label "lbl"
first cleans memory and then returns variable rc. Before calling the
macro, the value of variable rc is 0. Because 0 means no error, the
calle
From: Pan Bian
When the call to qlcnic_alloc_mbx_args() fails, returning variable "err"
seems improper. With reference to the context, returing variable
"config" may be better.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189101
Signed-off-by: Pan Bian
---
drivers/net/ethernet/qlogic
From: Pan Bian
When calling dma_mapping_error(), the value of return variable rc is 0.
And when the call returns an unexpected value, rc is not set to a
negative errno. Thus, it will return 0 on the error path, and its
callers cannot detect the bug. This patch fixes the bug, assigning
"-ENOMEM" t
Hi WingMan,
[auto build test ERROR on net/master]
[also build test ERROR on v4.9-rc7 next-20161202]
[cannot apply to net-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Grygorii-Stra
From: Pan Bian
It returns variable "error" when ioremap_nocache() returns a NULL
pointer. The value of "error" is 0 then, which will mislead the callers
to believe that there is no error. This patch fixes the bug, returning
"-ENOMEM".
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189021
On Fri, Dec 02, 2016 at 12:49:45PM -0800, John Fastabend wrote:
> This adds support for dynamically setting the LRO feature flag. The
> message to control guest features in the backend uses the
> CTRL_GUEST_OFFLOADS msg type.
>
> Signed-off-by: John Fastabend
> ---
> drivers/net/virtio_net.c |
From: Pan Bian
When the calls to kzalloc() fail, the value of return variable ret may
be 0. 0 means success in this context. This patch fixes the bug,
assigning "-ENOMEM" to ret before calling kzalloc().
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188971
Signed-off-by: Pan Bian
---
From: Pan Bian
In function hfc4s8s_probe(), the value of return variable err should be
negative on failures. However, when the call to request_region() returns
NULL, the value of err is 0. This patch fixes the bug, assiging
"-ENOMEM" to err on the path that request_region() fails.
Bugzilla: http
Made kernel accept IPv6 routes with IPv4-mapped address as next-hop.
It is possible to configure IP interfaces with IPv4-mapped addresses, and
one can add IPv6 routes for IPv4-mapped destinations/prefixes, yet prior
to this fix the kernel returned an EINVAL when attempting to add an IPv6
route wit
From: Pan Bian
Date: Sat, 3 Dec 2016 21:49:08 +0800
> From: Pan Bian
>
> In function dcbnl_cee_fill(), returns the value of variable err on
> errors. However, on some error paths (e.g. nla put fails), its value may
> be 0. It may be better to explicitly set a negative errno to variable
> err b
From: Arnd Bergmann
Date: Sat, 3 Dec 2016 00:04:32 +0100
> ptp now depends on the optional POSIX_TIMERS setting and fails to build
> if we select it without that:
>
> warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK which has unmet
> direct dependencies (NET && POSIX_TIMERS)
> warning:
From: Marcelo Ricardo Leitner
Date: Fri, 2 Dec 2016 20:51:51 -0200
> @@ -144,7 +144,21 @@ static void tcp_measure_rcv_mss(struct sock *sk, const
> struct sk_buff *skb)
>*/
> len = skb_shinfo(skb)->gso_size ? : skb->len;
> if (len >= icsk->icsk_ack.rcv_mss) {
> -
From: Erik Nordmark
Date: Fri, 2 Dec 2016 14:00:08 -0800
> Implemented RFC7527 Enhanced DAD.
> IPv6 duplicate address detection can fail if there is some temporary
> loopback of Ethernet frames. RFC7527 solves this by including a random
> nonce in the NS messages used for DAD, and if an NS is re
The check of the return value of sock_register() is ineffective.
"if(!err)" seems to be a typo. It is better to propagate the error code
to the callers of caif_sktinit_module(). This patch removes the check
statment and directly returns the result of sock_register().
Bugzilla: https://bugzilla.ker
From: Andrew Lunn
Date: Sat, 3 Dec 2016 04:35:15 +0100
> This is the second batch of patches adding support for the
> MV88e6390. They are not sufficient to make it work properly.
>
> The mv88e6390 has a much expanded set of priority maps. Refactor the
> existing code, and implement basic suppor
From: Sabrina Dubroca
Date: Sat, 3 Dec 2016 01:33:26 +0100
> I'd like to try something based on static analysis. We'd need a way to
> tag cached pointers to skb->data (via ip_hdr() or whatever), and
> propagate the notion that pskb_expand_head() makes these cached
> pointers stale through layers
From: John Fastabend
Date: Fri, 02 Dec 2016 12:49:45 -0800
> + if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS)) {
> + sg_init_one(&sg, &offloads, sizeof(uint64_t));
> + if (!virtnet_send_command(vi,
> + VIRTIO_NET_CT
Hello,
I was wondering if there was any way I could search what flow tables,
flow groups, flow rules exist for mlx5_core driver.
I am aware of the QUERY_* commands but I need to provide a valid
tableId or groupId to retrieve the information.
Let's say because of any bug, one of the flow table o
Thanks a lot Mohamad. This is really helpful.
On Mon, Aug 22, 2016 at 6:39 PM, Mohamad Haj Yahia
wrote:
> On Thu, Aug 18, 2016 at 12:41 PM, domingo montoya
> wrote:
>> Hi All,
>>
>> Is there any way we can support both VST and VGT modes at the same time in
>> mlx5?
>>
>> For e.g,
>>
>> If i sen
subscribe linux-netdev
On Fri, Dec 02, 2016 at 04:07:09PM -0800, Rick Jones wrote:
> On 12/02/2016 03:23 PM, Martin KaFai Lau wrote:
> >When XDP prog is attached, it is currently limiting
> >MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN) which is 1514
> >in x86.
> >
> >AFAICT, since mlx4 is doing one page per packet for
Reserve XDP_PACKET_HEADROOM and honor bpf_xdp_adjust_head()
when XDP prog is active. This patch only affects the code
path when XDP is active.
Signed-off-by: Martin KaFai Lau
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 17 +++--
drivers/net/ethernet/mellanox/mlx4/en_rx.c
The XDP prog checks if the incoming packet matches any VIP:PORT
combination in the BPF hashmap. If it is, it will encapsulate
the packet with a IPv4/v6 header as instructed by the value of
the BPF hashmap and then XDP_TX it out.
The VIP:PORT -> IP-Encap-Info can be specified by the cmd args
of th
This series adds a helper to allow head adjusting in XDP prog. mlx4
driver has been modified to support this feature. An example is written
to encapsulate a packet with an IPv4/v6 header and then XDP_TX it
out.
v2:
1. Make a variable name change in bpf_xdp_adjust_head() in patch 1
2. Ensure no l
This patch allows XDP prog to extend/remove the packet
data at the head (like adding or removing header). It is
done by adding a new XDP helper bpf_xdp_adjust_head().
It also renames bpf_helper_changes_skb_data() to
bpf_helper_changes_pkt_data() to better reflect
that XDP prog does not work on sk
When XDP is active in mlx4, mlx4 is using one page/pkt.
At the same time (i.e. when XDP is active), it is currently
limiting MTU to be FRAG_SZ0 - ETH_HLEN - (2 * VLAN_HLEN)
which is 1514 in x86. AFAICT, we can at least raise the MTU
limit up to PAGE_SIZE - ETH_HLEN - (2 * VLAN_HLEN) which this
pat
Hi Lino,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Lino-Sanfilippo/net-ethernet-slicoss-add-slicoss-gigabit-ethernet-driver/20161126-202438
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1
On Sat, 2016-12-03 at 19:16 -0500, David Miller wrote:
> From: Eric Dumazet
> Date: Sat, 3 Dec 2016 11:14:57 -0800
>
> > diff --git a/include/linux/tcp.h b/include/linux/tcp.h
> > index d8be083ab0b0..fc5848dad7a4 100644
> > --- a/include/linux/tcp.h
> > +++ b/include/linux/tcp.h
> > @@ -186,7 +1
From: Jiri Pirko
Date: Sat, 3 Dec 2016 16:44:57 +0100
> Ido says:
>
> In kernel 4.9 the switchdev-specific FIB offload mechanism was replaced
> by a new FIB notification chain to which modules could register in order
> to be notified about the addition and deletion of FIB entries. The
> motivat
From: Stephen Hemminger
Date: Fri, 2 Dec 2016 14:53:58 -0800
> Fixes commit 21609ae32aaf6c6fab0e ("net/sched: Introduce act_tunnel_key")
> The file is necessary for iproute2 headers but was not being
> copied by make install_headers
>
> Signed-off-by: Stephen Hemminger
This seems to already b
From: Stephen Hemminger
Date: Fri, 2 Dec 2016 14:53:59 -0800
> Fixes commit 735cffe5d800 ("net_sched: Introduce skbmod action")
> Not used by iproute2 but maybe in future.
>
> Signed-off-by: Stephen Hemminger
Applied.
From: Eric Dumazet
Date: Sat, 03 Dec 2016 10:59:18 -0800
> On Sat, 2016-12-03 at 10:36 -0800, Cong Wang wrote:
>> Cc: Hadar Hen Zion
>> Cc: Jiri Pirko
>> Signed-off-by: Cong Wang
>> ---
>> net/sched/act_mirred.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/
From: Stephen Hemminger
Date: Fri, 2 Dec 2016 14:54:00 -0800
> File is in uapi directory but not being copied on
> make install_headers
>
> Fixes commit 4ec9c8fbbc22 ("netfilter: nft_log: complete
> NFTA_LOG_FLAGS attr support").
>
> Signed-off-by: Stephen Hemminger
Also applied.
Someone h
From: Eric Dumazet
Date: Sat, 3 Dec 2016 11:14:57 -0800
> diff --git a/include/linux/tcp.h b/include/linux/tcp.h
> index d8be083ab0b0..fc5848dad7a4 100644
> --- a/include/linux/tcp.h
> +++ b/include/linux/tcp.h
> @@ -186,7 +186,6 @@ struct tcp_sock {
> u32 tsoffset; /* timestamp
From: Jeff Kirsher
Date: Sat, 3 Dec 2016 01:19:12 -0800
> This series contains updates to i40e and i40evf only.
Pulled, thanks Jeff.
From: Yuchung Cheng
Date: Sat, 3 Dec 2016 14:46:22 -0800
> The commit of SOF_TIMESTAMPING_OPT_STATS didn't include the
> new header for avr32, causing build to break. The patch fixes it.
>
> Fixes: 1c885808e456 ("tcp: SOF_TIMESTAMPING_OPT_STATS option for
> SO_TIMESTAMPING")
> Reported-by: Pau
On 12/03/2016 09:31 PM, Alexei Starovoitov wrote:
From: Gianluca Borello
Occasionally, clang (e.g. version 3.8.1) translates a sum between two
constant operands using a BPF_OR instead of a BPF_ADD. The verifier is
currently not handling this scenario, and the destination register type
becomes U
On Sat, Dec 03, 2016 at 10:22:28AM +0100, Michał Mirosław wrote:
> This All-in-one patch removes abuse of VLAN CFI bit, so it can be passed
> intact through linux networking stack.
>
> Signed-off-by: Michał Mirosław
> ---
>
> Dear NetDevs
>
> I guess this needs to be split to the prep..convert[
On Mon, Nov 28, 2016 at 05:04:25PM -0600, Grygorii Strashko wrote:
> This also change overflow polling period when HW_TS_PUSH feature is
> enabled - overflow check work will be scheduled more often (every
> 200ms) for proper HW_TS_PUSH events reporting.
For proper reporting, you should make use of
The commit of SOF_TIMESTAMPING_OPT_STATS didn't include the
new header for avr32, causing build to break. The patch fixes it.
Fixes: 1c885808e456 ("tcp: SOF_TIMESTAMPING_OPT_STATS option for
SO_TIMESTAMPING")
Reported-by: Paul Gortmaker
Signed-off-by: Yuchung Cheng
---
arch/avr32/include/uapi/
Le 12/03/16 à 13:35, Rob Herring a écrit :
> On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote:
>> Add documentations for macb mdio driver.
>
> Bindings document h/w, not drivers.
>
>>
>> Signed-off-by: Harini Katakam
>> ---
>> .../devicetree/bindings/net/macb-mdio.txt | 3
On Sat, 2016-12-03 at 16:12 -0500, David Miller wrote:
> Applied.
Thanks David.
I also have to get rid of the WRITE_ONCE() done in est_timer(), since it
does not work properly on 32bit kernels.
It will target net-next, since it is not a very serious problem.
On Mon, Nov 28, 2016 at 03:19:27PM +0530, Harini Katakam wrote:
> Add documentations for macb mdio driver.
Bindings document h/w, not drivers.
>
> Signed-off-by: Harini Katakam
> ---
> .../devicetree/bindings/net/macb-mdio.txt | 31
> ++
> 1 file changed, 31 inser
From: Edward Cree
Date: Fri, 2 Dec 2016 15:51:33 +
> Logically, EFX_BUG_ON_PARANOID can never be correct. For, BUG_ON should
> only be used if it is not possible to continue without potential harm;
> and since the non-DEBUG driver will continue regardless (as the BUG_ON is
> compiled out)
From: Eric Dumazet
Date: Fri, 02 Dec 2016 08:11:00 -0800
> From: Eric Dumazet
>
> Under heavy stress, timer used in estimators tend to slowly be delayed
> by a few jiffies, leading to inaccuracies.
>
> Lets remember what was the last scheduled jiffies so that we get more
> precise estimations,
From: Paolo Abeni
Date: Fri, 2 Dec 2016 17:35:49 +0100
> Before commit 850cbaddb52d ("udp: use it's own memory accounting
> schema"), the udp protocol allowed sk_rmem_alloc to grow beyond
> the rcvbuf by the whole current packet's truesize. After said commit
> we allow sk_rmem_alloc to exceed th
From: Simon Wunderlich
Date: Fri, 2 Dec 2016 17:13:22 +0100
> here is another bugfix which we would like to see integrated into net,
> if this is possible now.
>
> Please pull or let me know of any problem!
Pulled, thanks.
When you post a series of related changes as a patch set, you must
provide a proper "[PATCH 0/N] ..." posting which explains what
the series is doing at a high level, how it is doing it, and why
it is doing it that way.
Please repost this entire series with a proper header posting
included.
Than
From: Sargun Dhillon
Date: Fri, 2 Dec 2016 02:42:03 -0800
> These two patches are around refactoring out some old, reusable code from the
> existing test_current_task_under_cgroup_user test, and adding a new,
> automated
> test.
>
> There is some generic cgroupsv2 setup & cleanup code, given
On 12/03/2016 06:38 PM, Pan Bian wrote:
In function caif_sktinit_module(), the check of the return value of
sock_register() seems ineffective. This patch fixes it.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751
Signed-off-by: Pan Bian
---
net/caif/caif_socket.c | 2 +-
1 file ch
From: Alexei Starovoitov
Date: Thu, 1 Dec 2016 18:31:12 -0800
> silence some of the clang compiler warnings like:
> include/linux/fs.h:2693:9: warning: comparison of unsigned enum expression <
> 0 is always false
> arch/x86/include/asm/processor.h:491:30: warning: taking address of packed
> mem
All 3 patches applied to net-next, thanks.
From: Alexey Dobriyan
Date: Fri, 2 Dec 2016 03:59:06 +0300
> nla_ok() consists of 3 clauses:
>
> 1) int rem >= (int)sizeof(struct nlattr)
>
> 2) u16 nla_len >= sizeof(struct nlattr)
>
> 3) u16 nla_len <= int rem
>
> The statement is that clause (1) is redundant.
>
> What it
From: Zhang Shengju
Date: Fri, 2 Dec 2016 09:51:02 +0800
> This patch serial replace 'set' function to 'reset', since the
> offset is zero. It's not necessary to use set, reset function is
> straightforward, and will remove the unnecessary add operation in
> set function.
Series applied, thank
From: Iyappan Subramanian
Date: Thu, 1 Dec 2016 16:41:36 -0800
> This patch set adds,
>
> 1. Jumbo frame support
> 2. Pause frame based flow control
>
> and fixes RSS for non-TCP/UDP packets.
>
> Signed-off-by: Iyappan Subramanian
Series applied, thanks.
From: Corentin Labbe
Date: Thu, 1 Dec 2016 16:19:41 +0100
> stmmac_mdio_{read|write} and stmmac_mdio_{read|write}_gmac4 are not
> enought different for being split.
> The only differences between thoses two functions are shift/mask for
> addr/reg/clk_csr.
>
> This patch introduce a per platform
From: Grygorii Strashko
Date: Thu, 1 Dec 2016 17:34:26 -0600
> @@ -167,10 +167,10 @@ static struct cpdma_control_info controls[] = {
>
> /* various accessors */
> #define dma_reg_read(ctlr, ofs) __raw_readl((ctlr)->dmaregs +
> (ofs))
> -#define chan_read(chan, fld) __raw
From: Corentin Labbe
Date: Thu, 1 Dec 2016 16:19:40 +0100
> This patch simply rename regValue to value, like it was named in other
> mdio functions.
>
> Signed-off-by: Corentin Labbe
Applied.
From: Gianluca Borello
Occasionally, clang (e.g. version 3.8.1) translates a sum between two
constant operands using a BPF_OR instead of a BPF_ADD. The verifier is
currently not handling this scenario, and the destination register type
becomes UNKNOWN_VALUE even if it's still storing a constant.
From: Paul Gortmaker
Date: Thu, 1 Dec 2016 15:25:28 -0500
> As of commit 8f32b90981dcdb355516fb95953133f8d4e6b11d
> ("net: ethernet: ti: davinci_cpdma: add set rate for a channel") the
> ARM allmodconfig builds would fail modpost with:
>
> ERROR: "cpdma_chan_set_weight" [drivers/net/ethernet/ti/
From: Marc Kleine-Budde
Date: Thu, 1 Dec 2016 21:21:44 +0100
> this is a pull request of 4 patches for net-next/master.
>
> There are two patches by Chris Paterson for the rcar_can and rcar_canfd
> device tree binding documentation. And a patch by Geert Uytterhoeven
> that corrects the order of
From: Salil Mehta
Date: Thu, 1 Dec 2016 16:59:14 +
> It looks to me the cumbersome check in the PATCH V2 should
> be retained.
I really want something simpler with small checks that are
done in logical pieces in a straigtforward progression.
The code in V2 is completely unreadable.
On 12/03/2016 08:32 PM, Martin KaFai Lau wrote:
On Sat, Dec 03, 2016 at 04:24:13PM +0100, Jesper Dangaard Brouer wrote:
On Fri, 2 Dec 2016 15:23:30 -0800
Martin KaFai Lau wrote:
-bool bpf_helper_changes_skb_data(void *func)
+BPF_CALL_2(bpf_xdp_adjust_head, struct xdp_buff *, xdp, int, offset)
On Sat, Dec 03, 2016 at 04:24:13PM +0100, Jesper Dangaard Brouer wrote:
> On Fri, 2 Dec 2016 15:23:30 -0800
> Martin KaFai Lau wrote:
>
> > -bool bpf_helper_changes_skb_data(void *func)
> > +BPF_CALL_2(bpf_xdp_adjust_head, struct xdp_buff *, xdp, int, offset)
> > +{
> > + /* Both mlx4 and mlx5 d
From: Arnd Bergmann
Date: Mon, 28 Nov 2016 15:19:43 +0100
> As David Miller pointed out for for the previous patch, the whitespace
> in some functions looks rather odd. This was caused by commit 6329da5f258a
> ("obsolete config in kernel source: USE_INTERNAL_TIMER"), which removed
> some conditio
From: Pavel Machek
Date: Thu, 1 Dec 2016 11:32:18 +0100
> Fix english in documentation, make documentation match reality, remove
> options that were removed from code.
>
> Signed-off-by: Pavel Machek
Applied.
From: Salil Mehta
Date: Thu, 1 Dec 2016 12:09:22 +
> But maybe now since we don't have any method to de-multiplex the kind of
> checksum error (cannot depend upon register) we can have below code
> re-arrangement:
>
> hns_nic_rx_checksum() {
> /* check supported L3 protocol */
>
Implement ethtooll::nway_restart by utilizing mii_nway_restart.
Signed-off-by: Florian Fainelli
---
drivers/net/ethernet/realtek/r8169.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/ethernet/realtek/r8169.c
index 2830190aaace..f9
Hi Dave,
Here's a set of Bluetooth & 802.15.4 patches for net-next (i.e. 4.10
kernel):
- Fix for a potential NULL deref in the ieee802154 netlink code
- Fix for the ED values of the at86rf2xx driver
- Documentation updates to ieee802154
- Cleanups to u8 vs __u8 usage
- Timer API usage cleanu
On 16-12-03 08:19 AM, Willem de Bruijn wrote:
> On Fri, Dec 2, 2016 at 12:22 PM, Jesper Dangaard Brouer
> wrote:
>>
>> On Thu, 1 Dec 2016 10:11:08 +0100 Florian Westphal wrote:
>>
>>> In light of DPDKs existence it make a lot more sense to me to provide
>>> a). a faster mmap based interface (poss
Under very high TX stress, CPU handling NIC TX completions can spend
considerable amount of cycles handling TSQ (TCP Small Queues) logic.
This patch series avoids some atomic operations, but most notable
patch is the 3rd one, allowing other cpus processing ACK packets and
calling tcp_write_xmit()
Hello beautiful, How you doing today? I hope you are doing well. My name is
Bentley, from the US. I'm in Syria right now fighting ISIS. I want to get to
know you better, if I may be so bold. I consider myself an easy-going man, and
I am currently looking for a relationship in which I feel loved.
tsq_flags being in the same cache line than sk_wmem_alloc
makes a lot of sense. Both fields are changed from tcp_wfree()
and more generally by various TSQ related functions.
Prior patch made room in struct sock and added sk_tsq_flags,
this patch deletes tsq_flags from struct tcp_sock.
Signed-off-
Group fields used in TX path, and keep some cache lines mostly read
to permit sharing among cpus.
Gained two 4 bytes holes on 64bit arches.
Added a place holder for tcp tsq_flags, next to sk_wmem_alloc
to speed up tcp_wfree() in the following patch.
I have not added cacheline_aligned_in_smp,
Always allow the two first skbs in write queue to be sent,
regardless of sk_wmem_alloc/sk_pacing_rate values.
This helps a lot in situations where TX completions are delayed either
because of driver latencies or softirq latencies.
Test is done with no cache line misses.
Signed-off-by: Eric Dumaz
Under high stress, I've seen tcp_tasklet_func() consuming
~700 usec, handling ~150 tcp sockets.
By setting TCP_TSQ_DEFERRED in tcp_wfree(), we give a chance
for other cpus/threads entering tcp_write_xmit() to grab it,
allowing tcp_tasklet_func() to skip sockets that already did
an xmit cycle.
In
Adding a likely() in tcp_mtu_probe() moves its code which used to
be inlined in front of tcp_write_xmit()
We still have a cache line miss to access icsk->icsk_mtup.enabled,
we will probably have to reorganize fields to help data locality.
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp_output.c |
Instead of atomically clear TSQ_THROTTLED and atomically set TSQ_QUEUED
bits, use one cmpxchg() to perform a single locked operation.
Since the following patch will also set TCP_TSQ_DEFERRED here,
this cmpxchg() will make this addition free.
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp_output.c
This is a cleanup, to ease code review of following patches.
Old 'enum tsq_flags' is renamed, and a new enumeration is added
with the flags used in cmpxchg() operations as opposed to
single bit operations.
Signed-off-by: Eric Dumazet
---
include/linux/tcp.h | 11 ++-
net/ipv4/tcp_outp
Under high load, tcp_wfree() has an atomic operation trying
to schedule a tasklet over and over.
We can schedule it only if our per cpu list was empty.
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp_output.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_outp
On Sat, 2016-12-03 at 10:36 -0800, Cong Wang wrote:
> Cc: Hadar Hen Zion
> Cc: Jiri Pirko
> Signed-off-by: Cong Wang
> ---
> net/sched/act_mirred.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c
> index bb09ba3..2d9fa6e
On Sat, Dec 3, 2016 at 2:49 AM, Jiri Pirko wrote:
> Fri, Dec 02, 2016 at 09:31:41PM CET, simon.hor...@netronome.com wrote:
>>Allow dissection of ICMP(V6) type and code. This re-uses transport layer
>>port dissection code as although ICMP is not a transport protocol and their
>>type and code are no
On Sat, Dec 3, 2016 at 1:56 AM, Pan Bian wrote:
> Function bnxt_hwrm_stat_ctx_alloc() always returns 0, even if the call
> to _hwrm_send_message() fails. It may be better to propagate the errors
> to the caller of bnxt_hwrm_stat_ctx_alloc().
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?i
Cc: Hadar Hen Zion
Cc: Jiri Pirko
Signed-off-by: Cong Wang
---
net/sched/act_mirred.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c
index bb09ba3..2d9fa6e 100644
--- a/net/sched/act_mirred.c
+++ b/net/sched/act_mirred.c
@@ -3
On Sat, Dec 3, 2016 at 9:41 AM, Cong Wang wrote:
> On Sat, Dec 3, 2016 at 4:56 AM, Andrey Konovalov
> wrote:
>> Hi!
>>
>> I'm seeing lots of the following error reports while running the
>> syzkaller fuzzer.
>>
>> Reports appeared when I updated to 3c49de52 (Dec 2) from 2caceb32 (Dec 1).
>>
>> =
On Sat, Dec 03, 2016 at 06:06:08PM +0200, Or Gerlitz wrote:
> On Sat, Dec 3, 2016 at 3:17 PM, Simon Horman wrote:
>
> > in net-next I am observing what appears to be an regression in net-next due
> > to:
> > 7091d8c7055d ("net/sched: cls_flower: Add offload support using egress
> > Hardware dev
On Sat, Dec 3, 2016 at 4:56 AM, Andrey Konovalov wrote:
> Hi!
>
> I'm seeing lots of the following error reports while running the
> syzkaller fuzzer.
>
> Reports appeared when I updated to 3c49de52 (Dec 2) from 2caceb32 (Dec 1).
>
>
On Sat, 2016-12-03 at 07:00 -0800, Eric Dumazet wrote:
> On Wed, 2016-11-16 at 07:26 -0800, Eric Dumazet wrote:
> > From: Eric Dumazet
> >
> > Calling napi_hash_del() before netif_napi_del() is dangerous
> > if a synchronize_rcu() is not enforced before NAPI struct freeing.
> >
> > Lets leave th
From: PanBian
Hello Sergei,
On Sat, Dec 03, 2016 at 04:17:51PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/3/2016 2:18 PM, Pan Bian wrote:
>
> >In function caif_sktinit_module(), the check of the return value of
> >sock_register() seems ineffective. This patch fixes it.
> >
> >Bugzilla: h
On Fri, Dec 2, 2016 at 12:22 PM, Jesper Dangaard Brouer
wrote:
>
> On Thu, 1 Dec 2016 10:11:08 +0100 Florian Westphal wrote:
>
>> In light of DPDKs existence it make a lot more sense to me to provide
>> a). a faster mmap based interface (possibly AF_PACKET based) that allows
>> to map nic directl
On Sat, Dec 3, 2016 at 3:17 PM, Simon Horman wrote:
> in net-next I am observing what appears to be an regression in net-next due
> to:
> 7091d8c7055d ("net/sched: cls_flower: Add offload support using egress
> Hardware device")
>
> The problem occurs when adding a flower filter (without offloa
From: Ido Schimmel
Convert rocker to offload FIBs in deferred work in a similar fashion to
mlxsw, which was converted in the previous commits.
Signed-off-by: Ido Schimmel
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/rocker/rocker_main.c | 58 +-
drivers/net/
From: Ido Schimmel
Commit b90eb7549499 ("fib: introduce FIB notification infrastructure")
introduced a new notification chain to notify listeners (f.e., switchdev
drivers) about addition and deletion of routes.
However, upon registration to the chain the FIB tables can already be
populated, whic
From: Ido Schimmel
As explained in the previous commit, modules are going to need to take a
reference on fib info and then drop it using fib_info_put().
Add the fib_info_hold() helper to make the code more readable and also
symmetric with fib_info_put().
Signed-off-by: Ido Schimmel
Suggested-b
From: Jiri Pirko
Ido says:
In kernel 4.9 the switchdev-specific FIB offload mechanism was replaced
by a new FIB notification chain to which modules could register in order
to be notified about the addition and deletion of FIB entries. The
motivation for this change was that switchdev drivers nee
1 - 100 of 162 matches
Mail list logo
