Re: [net-next 1/5] qede: use reset to set network header

2016-12-01 Thread Mintz, Yuval
> Since offset is zero, it's not necessary to use set function. Reset > function is straightforward, and will remove the unnecessary add > operation in set function. Thanks. Acked-by: Yuval Mintz [For #2 for bnx2x as well]

Re: [PATCH v3 0/3] Add QLogic FastLinQ iSCSI (qedi) driver.

2016-12-01 Thread Rangankar, Manish
Hi Dave, Please consider applying the qed patches 1 & 2 to net-next. Patch 3, qedi, goes to SCSI. Martin P. is ok to have you take qedi (already Acked) through your tree. Please let us know which way you prefer. Thanks, Manish On 01/12/16 1:51 PM, "Rangankar, Manish" wrote: >This series intr

Re: iproute2 public git outdated?

2016-12-01 Thread Phil Sutter
On Thu, Dec 01, 2016 at 10:39:10PM +0200, Rami Rosen wrote: > I suggest that you will try again now, it seems that the iproute2 git > repo was updated in the last 2-4 hours, and "git log" in master shows > now a patch from 30 of November (actually it is your "Add notes about > dropped IPv4 route ca

Re: [PATCH 2/3] netns: add dummy struct inside "struct net_generic"

2016-12-01 Thread Cong Wang
On Thu, Dec 1, 2016 at 9:42 PM, Cong Wang wrote: > On Thu, Dec 1, 2016 at 5:12 PM, Alexey Dobriyan wrote: >> struct net_generic { >> - unsigned int len; >> - struct rcu_head rcu; >> + struct { >> + unsigned int len; >> + struct rcu_head rcu; >> +

[PATCH net-next v4] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-12-01 Thread Erik Nordmark
Implemented RFC7527 Enhanced DAD. IPv6 duplicate address detection can fail if there is some temporary loopback of Ethernet frames. RFC7527 solves this by including a random nonce in the NS messages used for DAD, and if an NS is received with the same nonce it is assumed to be a looped back DAD pro

Re: [PATCH 2/3] netns: add dummy struct inside "struct net_generic"

2016-12-01 Thread Cong Wang
On Thu, Dec 1, 2016 at 5:12 PM, Alexey Dobriyan wrote: > struct net_generic { > - unsigned int len; > - struct rcu_head rcu; > + struct { > + unsigned int len; > + struct rcu_head rcu; > + } s; > > void *ptr[0]; > }; I think you can pu

Re: [PATCH net-next v3] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-12-01 Thread Erik Nordmark
On 12/1/16 2:28 PM, Hannes Frederic Sowa wrote: Reviewed-by: Hannes Frederic Sowa Thanks - I'll add that. Also got a warning from the kbuild test robot for route.c which I'll fix. Thanks! @@ -794,6 +808,17 @@ static void ndisc_recv_ns(struct sk_buff *skb) have_ifp: if (if

Re: linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

2016-12-01 Thread Kalle Valo
Stephen Rothwell writes: > Hi all, > > Today's linux-next merge of the wireless-drivers-next tree got a > conflict in: > > drivers/net/wireless/ath/ath10k/mac.c > > between commit: > > f3fe4e93dd63 ("mac80211: add a HW flag for supporting HW TX fragmentation") > > from the net-next tree and c

Re: [PATCH 23/39] Annotate hardware config module parameters in drivers/net/wireless/

2016-12-01 Thread Kalle Valo
David Howells writes: > When the kernel is running in secure boot mode, we lock down the kernel to > prevent userspace from modifying the running kernel image. Whilst this > includes prohibiting access to things like /dev/mem, it must also prevent > access by means of configuring driver modules

Re: [PATCH main-v4.9-rc7] net/ipv6: allow sysctl to change link-local address generation mode

2016-12-01 Thread Cong Wang
On Thu, Dec 1, 2016 at 6:14 PM, Felix Jia wrote: > +static void addrconf_addrgenmode_change(struct net *net) > +{ > + struct net_device *dev; > + struct inet6_dev *idev; > + > + read_lock(&dev_base_lock); > + for_each_netdev(net, dev) { > + rcu_read_lock(); >

[PATCH net-next] samples/bpf: silence compiler warnings

2016-12-01 Thread Alexei Starovoitov
silence some of the clang compiler warnings like: include/linux/fs.h:2693:9: warning: comparison of unsigned enum expression < 0 is always false arch/x86/include/asm/processor.h:491:30: warning: taking address of packed member 'sp0' of class or structure 'x86_hw_tss' may result in an unaligned p

[PATCH main-v4.9-rc7] net/ipv6: allow sysctl to change link-local address generation mode

2016-12-01 Thread Felix Jia
The address generation mode for IPv6 link-local can only be configured by netlink messages. This patch adds the ability to change the address generation mode via sysctl. An possible improvement is to remove the addrgenmode variable from the idev structure and use the systcl storage for the flag.

Hi

2016-12-01 Thread Sydney
Can we talk please

[net-next 2/5] bnx2x: use reset to set network header

2016-12-01 Thread Zhang Shengju
Since offset is zero, it's not necessary to use set function. Reset function is straightforward, and will remove the unnecessary add operation in set function. Signed-off-by: Zhang Shengju --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[net-next 3/5] mlx4: use reset to set mac header

2016-12-01 Thread Zhang Shengju
Since offset is zero, it's not necessary to use set function. Reset function is straightforward, and will remove the unnecessary add operation in set function. Signed-off-by: Zhang Shengju --- drivers/net/ethernet/mellanox/mlx4/en_selftest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[net-next 1/5] qede: use reset to set network header

2016-12-01 Thread Zhang Shengju
Since offset is zero, it's not necessary to use set function. Reset function is straightforward, and will remove the unnecessary add operation in set function. Signed-off-by: Zhang Shengju --- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[net-next 0/5] use reset to set headers

2016-12-01 Thread Zhang Shengju
This patch serial replace 'set' function to 'reset', since the offset is zero. It's not necessary to use set, reset function is straightforward, and will remove the unnecessary add operation in set function. Zhang Shengju (5): qede: use reset to set network header bnx2x: use reset to set ne

[net-next 5/5] staging: wilc1000: use reset to set mac header

2016-12-01 Thread Zhang Shengju
Since offset is zero, it's not necessary to use set function. Reset function is straightforward, and will remove the unnecessary add operation in set function. Signed-off-by: Zhang Shengju --- drivers/staging/wilc1000/linux_mon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[net-next 4/5] iwlwifi: use reset to set transport header

2016-12-01 Thread Zhang Shengju
Since offset is zero, it's not necessary to use set function. Reset function is straightforward, and will remove the unnecessary add operation in set function. Signed-off-by: Zhang Shengju --- drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH v8 3/8] thunderbolt: Communication with the ICM (firmware)

2016-12-01 Thread Andy Lutomirski
On 09/28/2016 07:44 AM, Amir Levy wrote: This patch provides the communication protocol between the Intel Connection Manager(ICM) firmware that is operational in the Thunderbolt controller in non-Apple hardware. The ICM firmware-based controller is used for establishing and maintaining the Thunde

[PATCH net-next 2/8] drivers: net: xgene: Configure classifier with pagepool

2016-12-01 Thread Iyappan Subramanian
This patch configures classifier with the pagepool information. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 16 ++-- drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 2 ++ drivers/net/ethernet/apm/xgene/xg

[PATCH net-next 5/8] drivers: net: xgene: fix: RSS for non-TCP/UDP

2016-12-01 Thread Iyappan Subramanian
This patch fixes RSS feature, for non-TCP/UDP packets. Signed-off-by: Khuong Dinh Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 90 - drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 1 + 2 files changed, 89 insertions(+), 2 d

[PATCH net-next 7/8] drivers: net: xgene: Add flow control initialization

2016-12-01 Thread Iyappan Subramanian
This patch adds flow control/pause frame initialization and advertising capabilities. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 57 +++ drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 7 +++ dri

[PATCH net-next 3/8] drivers: net: xgene: Add support for Jumbo frame

2016-12-01 Thread Iyappan Subramanian
This patch adds support for jumbo frame, by allocating additional buffer (page) pool and configuring the hardware. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 3 + drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 305

[PATCH net-next 4/8] drivers: net: xgene: Add change_mtu function

2016-12-01 Thread Iyappan Subramanian
This patch implements ndo_change_mtu() callback function that enables mtu change. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 6 ++ drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 20 drivers

[PATCH net-next 1/8] drivers: net: xgene: Add helper function

2016-12-01 Thread Iyappan Subramanian
This is a prepartion patch and adds xgene_enet_get_fpsel() helper function to get buffer pool number. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 4 ++-- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 19 +++

[PATCH net-next 0/8] drivers: net: xgene: Add Jumbo and Pause frame support

2016-12-01 Thread Iyappan Subramanian
This patch set adds, 1. Jumbo frame support 2. Pause frame based flow control and fixes RSS for non-TCP/UDP packets. Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (8): drivers: net: xgene: Add helper function drivers: net: xgene: Configure classifier with pagepool drivers: ne

[PATCH net-next 6/8] drivers: net: xgene: Add flow control configuration

2016-12-01 Thread Iyappan Subramanian
This patch adds functions to configure mac, when flow control and pause frame settings change. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 48 + drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 6 +++

[PATCH net-next 8/8] drivers: net: xgene: ethtool: Add get/set_pauseparam

2016-12-01 Thread Iyappan Subramanian
This patch adds get_pauseparam and set_pauseparam functions. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- .../net/ethernet/apm/xgene/xgene_enet_ethtool.c| 70 ++ 1 file changed, 70 insertions(+) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet

Re: [PATCH next] arp: avoid sending ucast probes to 00:00:00:00:00:00

2016-12-01 Thread Eric Dumazet
On Thu, 2016-12-01 at 15:47 -0800, Mahesh Bandewar (महेश बंडेवार) wrote: > [...] > >> @@ -371,10 +372,12 @@ static void arp_solicit(struct neighbour *neigh, > >> struct sk_buff *skb) > >> > >> probes -= NEIGH_VAR(neigh->parms, UCAST_PROBES); > >> if (probes < 0) { > >> + me

Re: [PATCH next] arp: avoid sending ucast probes to 00:00:00:00:00:00

2016-12-01 Thread महेश बंडेवार
[...] >> @@ -371,10 +372,12 @@ static void arp_solicit(struct neighbour *neigh, >> struct sk_buff *skb) >> >> probes -= NEIGH_VAR(neigh->parms, UCAST_PROBES); >> if (probes < 0) { >> + memset(&null_dev_hw_addr, 0, dev->addr_len); >> if (!(neigh->nud_state & NU

Re: Initial thoughts on TXDP

2016-12-01 Thread Rick Jones
On 12/01/2016 02:12 PM, Tom Herbert wrote: We have consider both request size and response side in RPC. Presumably, something like a memcache server is most serving data as opposed to reading it, we are looking to receiving much smaller packets than being sent. Requests are going to be quite smal

linux-next: manual merge of the wireless-drivers-next tree with the net-next tree

2016-12-01 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the wireless-drivers-next tree got a conflict in: drivers/net/wireless/ath/ath10k/mac.c between commit: f3fe4e93dd63 ("mac80211: add a HW flag for supporting HW TX fragmentation") from the net-next tree and commit: ff32eeb86aa1 ("ath10k: advertize har

Re: Initial thoughts on TXDP

2016-12-01 Thread Tom Herbert
On Thu, Dec 1, 2016 at 2:47 PM, Hannes Frederic Sowa wrote: > Side note: > > On 01.12.2016 20:51, Tom Herbert wrote: >>> > E.g. "mini-skb": Even if we assume that this provides a speedup >>> > (where does that come from? should make no difference if a 32 or >>> > 320 byte buffer gets allocated).

[PATCH 6/7] net: ethernet: ti: cpsw: add support for descs_pool_size dt property

2016-12-01 Thread Grygorii Strashko
The CPSW CPDMA can process buffer descriptors placed as in internal CPPI RAM as in DDR. This patch adds support in CPSW and CPDMA for descs_pool_size DT property, which defines total number of CPDMA CPPI descriptors to be used for both ingress/egress packets processing: - memory size required for

[PATCH 2/7] net: ethernet: ti: cpdma: fix desc re-queuing

2016-12-01 Thread Grygorii Strashko
The currently processing cpdma descriptor with EOQ flag set may contain two values in Next Descriptor Pointer field: - valid pointer: means CPDMA missed addition of new desc in queue; - null: no more descriptors in queue. In the later case, it's not required to write to HDP register, but now CPDMA

[PATCH 1/7] net: ethernet: ti: cpdma: am437x: allow descs to be plased in ddr

2016-12-01 Thread Grygorii Strashko
It's observed that cpsw/cpdma is not working properly when CPPI descriptors are placed in DDR instead of internal CPPI RAM on am437x SoC: - rx/tx silently stops processing packets; - or - after boot it's working for sometime, but stuck once Network load is increased (ping is working, but iperf is n

[PATCH 0/7] net: ethernet: ti: cpsw: support placing CPDMA descriptors into DDR

2016-12-01 Thread Grygorii Strashko
This series intended to add support for placing CPDMA descriptors into DDR by introducing new DT property "descs_pool_size" to specify buffer descriptor's pool size. The "descs_pool_size" defines total number of CPDMA CPPI descriptors to be used for both ingress/egress packets processing. If not sp

[PATCH 3/7] net: ethernet: ti: cpdma: minimize number of parameters in cpdma_desc_pool_create/destroy()

2016-12-01 Thread Grygorii Strashko
Update cpdma_desc_pool_create/destroy() to accept only one parameter struct cpdma_ctlr*, as this structure contains all required information for pool creation/destruction. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/davinci_cpdma.c | 66 - 1 file

[PATCH 4/7] net: ethernet: ti: cpdma: use devm_ioremap

2016-12-01 Thread Grygorii Strashko
Use devm_ioremap() and simplify the code. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/davinci_cpdma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index db0a7fd..ba892b

[PATCH 7/7] Documentation: DT: net: cpsw: remove no_bd_ram property

2016-12-01 Thread Grygorii Strashko
Even if no_bd_ram property is described in TI CPSW bindings the support for it has never been introduced in CPSW driver, so there are no real users of it. Hence, remove no_bd_ram property. Signed-off-by: Grygorii Strashko --- Documentation/devicetree/bindings/net/cpsw.txt | 3 --- arch/arm/boot/

[PATCH 5/7] Documentation: DT: net: cpsw: allow to specify descriptors pool size

2016-12-01 Thread Grygorii Strashko
Add optional property "descs_pool_size" to specify buffer descriptor's pool size. The "descs_pool_size" should define total number of CPDMA CPPI descriptors to be used for both ingress/egress packets processing. If not specified - the default value 256 will be used which will allow to place descrip

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Hannes Frederic Sowa
On 02.12.2016 00:14, Ido Schimmel wrote: [...] >> Basically, if you delete a node right now the kernel might simply do a >> RCU_INIT_POINTER(ptr_location, NULL), which has absolutely no barriers >> or synchronization with the reader side. Thus you might get a callback >> from the notifier for a d

[PATCH 3/3] netns: fix net_generic() "id - 1" bloat

2016-12-01 Thread Alexey Dobriyan
net_generic() function is both a) inline and b) used ~600 times. It has the following code inside ... ptr = ng->ptr[id - 1]; ... "id" is never compile time constant so compiler is forced to subtract 1. And those decrements or LEA [r32 - 1] instructions add

Re: [PATCH next] arp: avoid sending ucast probes to 00:00:00:00:00:00

2016-12-01 Thread Eric Dumazet
On Thu, 2016-12-01 at 14:56 -0800, Mahesh Bandewar wrote: > From: Mahesh Bandewar > > If initial broadcast probe(s) is/are lost, the neigh entry wont have > valid address of the neighbour. In a situation like this, the fall > back should be to send a broadcast probe, however the code logic > cont

[PATCH] netlink: 2-clause nla_ok()

2016-12-01 Thread Alexey Dobriyan
nla_ok() consists of 3 clauses: 1) int rem >= (int)sizeof(struct nlattr) 2) u16 nla_len >= sizeof(struct nlattr) 3) u16 nla_len <= int rem The statement is that clause (1) is redundant. What it does is ensuring that "rem" is a positive number, so that in clause (3) posi

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Ido Schimmel
On Thu, Dec 01, 2016 at 10:57:52PM +0100, Hannes Frederic Sowa wrote: > On 30.11.2016 19:22, Ido Schimmel wrote: > > On Wed, Nov 30, 2016 at 05:49:56PM +0100, Hannes Frederic Sowa wrote: > >> On 30.11.2016 17:32, Ido Schimmel wrote: > >>> On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic So

[PATCH 2/3] netns: add dummy struct inside "struct net_generic"

2016-12-01 Thread Alexey Dobriyan
This is precursor to fixing "[id - 1]" bloat inside net_generic(). Name "s" is chosen to complement name "u" often used for dummy unions. Signed-off-by: Alexey Dobriyan --- include/net/netns/generic.h |6 -- net/core/net_namespace.c|8 2 files changed, 8 insertions(+),

[PATCH 1/3] netns: publish net_generic correctly

2016-12-01 Thread Alexey Dobriyan
Publishing net_generic pointer is done with silly mistake: new array is published BEFORE setting freshly acquired pernet subsystem pointer. memcpy rcu_assign_pointer kfree_rcu ng->ptr[id - 1] = data; This bug was introduced with commit dec827d174d7f76c457238800183c

[PATCH next] arp: avoid sending ucast probes to 00:00:00:00:00:00

2016-12-01 Thread Mahesh Bandewar
From: Mahesh Bandewar If initial broadcast probe(s) is/are lost, the neigh entry wont have valid address of the neighbour. In a situation like this, the fall back should be to send a broadcast probe, however the code logic continues sending ucast probes to 00:00:00:00:00:00. The default value of

Re: Initial thoughts on TXDP

2016-12-01 Thread Hannes Frederic Sowa
On 01.12.2016 21:13, Sowmini Varadhan wrote: > On (12/01/16 11:05), Tom Herbert wrote: >> >> Polling does not necessarily imply that networking monopolizes the CPU >> except when the CPU is otherwise idle. Presumably the application >> drives the polling when it is ready to receive work. > > I'm n

stmmac: turn coalescing / NAPI off in stmmac

2016-12-01 Thread Pavel Machek
> > @@ -2771,12 +2771,8 @@ static netdev_features_t stmmac_fix_features(struct > > net_device *dev, > > features &= ~NETIF_F_CSUM_MASK; > > > > /* Disable tso if asked by ethtool */ > > - if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) { > > - if (features & NETIF

Re: Initial thoughts on TXDP

2016-12-01 Thread Hannes Frederic Sowa
Side note: On 01.12.2016 20:51, Tom Herbert wrote: >> > E.g. "mini-skb": Even if we assume that this provides a speedup >> > (where does that come from? should make no difference if a 32 or >> > 320 byte buffer gets allocated). >> > > It's the zero'ing of three cache lines. I believe we talked ab

Re: [PATCH net-next v3] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-12-01 Thread Hannes Frederic Sowa
On 01.12.2016 00:39, Erik Nordmark wrote: > Implemented RFC7527 Enhanced DAD. > IPv6 duplicate address detection can fail if there is some temporary > loopback of Ethernet frames. RFC7527 solves this by including a random > nonce in the NS messages used for DAD, and if an NS is received with the >

Re: [PATCH] mm: page_alloc: High-order per-cpu page allocator v3

2016-12-01 Thread Paolo Abeni
On Thu, 2016-12-01 at 18:34 +0100, Jesper Dangaard Brouer wrote: > (Cc. netdev, we might have an issue with Paolo's UDP accounting and > small socket queues) > > On Wed, 30 Nov 2016 16:35:20 + > Mel Gorman wrote: > > > > I don't quite get why you are setting the socket recv size > > > (with

Re: [PATCH 1/1] NET: usb: qmi_wwan: add support for Telit LE922A PID 0x1040

2016-12-01 Thread Bjørn Mork
Daniele Palmas writes: > This patch adds support for PID 0x1040 of Telit LE922A. LGTM Acked-by: Bjørn Mork

Re: Initial thoughts on TXDP

2016-12-01 Thread Tom Herbert
On Thu, Dec 1, 2016 at 1:47 PM, Rick Jones wrote: > On 12/01/2016 12:18 PM, Tom Herbert wrote: >> >> On Thu, Dec 1, 2016 at 11:48 AM, Rick Jones wrote: >>> >>> Just how much per-packet path-length are you thinking will go away under >>> the >>> likes of TXDP? It is admittedly "just" netperf but

Re: [WIP] net+mlx4: auto doorbell

2016-12-01 Thread Eric Dumazet
On Thu, 2016-12-01 at 15:20 -0500, David Miller wrote: > From: Eric Dumazet > Date: Thu, 01 Dec 2016 09:04:17 -0800 > > > On Thu, 2016-12-01 at 17:04 +0100, Jesper Dangaard Brouer wrote: > > > >> When qdisc layer or trafgen/af_packet see this indication it knows it > >> should/must flush the que

Re: [WIP] net+mlx4: auto doorbell

2016-12-01 Thread Eric Dumazet
On Thu, 2016-12-01 at 13:32 -0800, Alexander Duyck wrote: > A few years back when I did something like this on ixgbe I was told by > you that the issue was that doing something like this would add too > much latency. I was just wondering what the latency impact is on a > change like this and if t

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Hannes Frederic Sowa
On 30.11.2016 19:22, Ido Schimmel wrote: > On Wed, Nov 30, 2016 at 05:49:56PM +0100, Hannes Frederic Sowa wrote: >> On 30.11.2016 17:32, Ido Schimmel wrote: >>> On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic Sowa wrote: On 30.11.2016 11:09, Jiri Pirko wrote: > From: Ido Schimmel

[PATCH] net: ethernet: ti: davinci_cpdma: sanitize inter-module API

2016-12-01 Thread Arnd Bergmann
The davinci_cpdma module is a helper library that is used by the actual device drivers and does nothing by itself, so all its API functions need to be exported. Four new functions were added recently without an export, so now we get a build error: ERROR: "cpdma_chan_set_weight" [drivers/net/ether

Re: [flamebait] xdp, well meaning but pointless

2016-12-01 Thread Tom Herbert
On Thu, Dec 1, 2016 at 1:27 PM, Hannes Frederic Sowa wrote: > On 01.12.2016 22:12, Tom Herbert wrote: >> On Thu, Dec 1, 2016 at 12:44 PM, Hannes Frederic Sowa >> wrote: >>> Hello, >>> >>> this is a good conversation and I simply want to bring my worries >>> across. I don't have good solutions for

Re: Initial thoughts on TXDP

2016-12-01 Thread Rick Jones
On 12/01/2016 12:18 PM, Tom Herbert wrote: On Thu, Dec 1, 2016 at 11:48 AM, Rick Jones wrote: Just how much per-packet path-length are you thinking will go away under the likes of TXDP? It is admittedly "just" netperf but losing TSO/GSO does some non-trivial things to effective overhead (servi

Re: DSA vs. SWTICHDEV ?

2016-12-01 Thread Murali Karicheri
Hi Andrew, On 12/01/2016 12:31 PM, Andrew Lunn wrote: > Hi Murali > >> 2. Switch mode where it implements a simple Ethernet switch. Currently >>it doesn't have address learning capability, but in future it >>can. > > If it does not have address learning capabilities, does it act like a >

Re: [WIP] net+mlx4: auto doorbell

2016-12-01 Thread Alexander Duyck
On Mon, Nov 28, 2016 at 10:58 PM, Eric Dumazet wrote: > On Mon, 2016-11-21 at 10:10 -0800, Eric Dumazet wrote: > > >> Not sure it this has been tried before, but the doorbell avoidance could >> be done by the driver itself, because it knows a TX completion will come >> shortly (well... if softirqs

Re: [PATCH iproute2] ip: update link types to show 6lowpan and ieee802.15.4 monitor

2016-12-01 Thread Stefan Schmidt
Hello. On 28.10.2016 11:42, Stefan Schmidt wrote: > Both types have been missing here and thus ip always showed > only the numbers. > > Based on a suggestion from Alexander Aring. > > Signed-off-by: Stefan Schmidt Did you somehow mangle this patch manually? Looking at the patch in your git re

Re: [flamebait] xdp, well meaning but pointless

2016-12-01 Thread Hannes Frederic Sowa
On 01.12.2016 22:12, Tom Herbert wrote: > On Thu, Dec 1, 2016 at 12:44 PM, Hannes Frederic Sowa > wrote: >> Hello, >> >> this is a good conversation and I simply want to bring my worries >> across. I don't have good solutions for the problems XDP tries to solve >> but I fear we could get caught up

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Ido Schimmel
On Thu, Dec 01, 2016 at 10:09:19PM +0100, Hannes Frederic Sowa wrote: > On 01.12.2016 21:54, Ido Schimmel wrote: > > On Thu, Dec 01, 2016 at 09:40:48PM +0100, Hannes Frederic Sowa wrote: > >> On 01.12.2016 21:04, David Miller wrote: > >>> > >>> Hannes and Ido, > >>> > >>> It looks like we are very

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Hannes Frederic Sowa
On 01.12.2016 21:54, Ido Schimmel wrote: > On Thu, Dec 01, 2016 at 09:40:48PM +0100, Hannes Frederic Sowa wrote: >> On 01.12.2016 21:04, David Miller wrote: >>> >>> Hannes and Ido, >>> >>> It looks like we are very close to having this in mergable shape, can >>> you guys work out this final issue a

Re: [patch] net: renesas: ravb: unintialized return value

2016-12-01 Thread Sergei Shtylyov
Hello! On 12/01/2016 11:57 PM, Dan Carpenter wrote: We want to set the other "err" variable here so that we can return it later. My version of GCC misses this issue but I caught it with a static checker. Fixes: 9f70eb339f52 ("net: ethernet: renesas: ravb: fix fixed-link phydev leaks") H

Re: [flamebait] xdp, well meaning but pointless

2016-12-01 Thread Tom Herbert
On Thu, Dec 1, 2016 at 12:44 PM, Hannes Frederic Sowa wrote: > Hello, > > this is a good conversation and I simply want to bring my worries > across. I don't have good solutions for the problems XDP tries to solve > but I fear we could get caught up in maintenance problems in the long > term given

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Hannes Frederic Sowa
On 30.11.2016 17:32, Ido Schimmel wrote: > Hi Hannes, > > On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic Sowa wrote: >> On 30.11.2016 11:09, Jiri Pirko wrote: >>> From: Ido Schimmel >>> >>> Make sure the device has a complete view of the FIB tables by invoking >>> their dump during mod

[patch] net: renesas: ravb: unintialized return value

2016-12-01 Thread Dan Carpenter
We want to set the other "err" variable here so that we can return it later. My version of GCC misses this issue but I caught it with a static checker. Fixes: 9f70eb339f52 ("net: ethernet: renesas: ravb: fix fixed-link phydev leaks") Signed-off-by: Dan Carpenter --- Applies to the net tree for

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Ido Schimmel
On Thu, Dec 01, 2016 at 09:40:48PM +0100, Hannes Frederic Sowa wrote: > On 01.12.2016 21:04, David Miller wrote: > > > > Hannes and Ido, > > > > It looks like we are very close to having this in mergable shape, can > > you guys work out this final issue and figure out if it really is > > a merge

Re: [PATCH net] tcp: warn on bogus MSS and try to amend it

2016-12-01 Thread marcelo . leitner
On Thu, Dec 01, 2016 at 03:29:49PM -0500, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 30 Nov 2016 11:14:32 -0200 > > > There have been some reports lately about TCP connection stalls caused > > by NIC drivers that aren't setting gso_size on aggregated packets on rx > > path.

Re: [flamebait] xdp, well meaning but pointless

2016-12-01 Thread Hannes Frederic Sowa
Hello, this is a good conversation and I simply want to bring my worries across. I don't have good solutions for the problems XDP tries to solve but I fear we could get caught up in maintenance problems in the long term given the ideas floating around on how to evolve XDP currently. On 01.12.2016

Re: [net PATCH 0/2] Don't use lco_csum to compute IPv4 checksum

2016-12-01 Thread David Miller
From: Jeff Kirsher Date: Wed, 30 Nov 2016 13:15:22 -0800 > On Wed, 2016-11-30 at 09:47 -0500, David Miller wrote: >> From: Alexander Duyck >> Date: Mon, 28 Nov 2016 10:42:18 -0500 >> >> > When I implemented the GSO partial support in the Intel drivers I was >> using >> > lco_csum to compute the

Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op

2016-12-01 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> index ab52c37..9e51405 100644 >> --- a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> +++ b/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h >> @@ -765,6 +765,9 @@ struct mv88e6xxx_

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Hannes Frederic Sowa
On 01.12.2016 21:04, David Miller wrote: > > Hannes and Ido, > > It looks like we are very close to having this in mergable shape, can > you guys work out this final issue and figure out if it really is > a merge stopped or not? Sure, if the fib notification register could be done under protecti

Re: [PATCH net-next 0/3] sfc: defalconisation fixups

2016-12-01 Thread David Miller
From: Edward Cree Date: Thu, 1 Dec 2016 16:59:13 + > A bug fix, the Kconfig change, and cleaning up a bit more unused code. > > Edward Cree (3): > sfc: fix debug message format string in efx_farch_handle_rx_not_ok > sfc: don't select SFC_FALCON > sfc: remove RESET_TYPE_RX_RECOVERY Ser

Re: iproute2 public git outdated?

2016-12-01 Thread Rami Rosen
Hi Phil, I suggest that you will try again now, it seems that the iproute2 git repo was updated in the last 2-4 hours, and "git log" in master shows now a patch from 30 of November (actually it is your "Add notes about dropped IPv4 route cache" patch) Regards, Rami Rosen On 1 December 2016 at 14

Re: Initial thoughts on TXDP

2016-12-01 Thread Tom Herbert
On Thu, Dec 1, 2016 at 12:13 PM, Sowmini Varadhan wrote: > On (12/01/16 11:05), Tom Herbert wrote: >> >> Polling does not necessarily imply that networking monopolizes the CPU >> except when the CPU is otherwise idle. Presumably the application >> drives the polling when it is ready to receive wor

pull-request: can-next 2016-12-01

2016-12-01 Thread Marc Kleine-Budde
://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-4.10-20161201 for you to fetch changes up to 0d8f8efd32bace9f222fcc92d4a3132d877e5df6: net: can: usb: kvaser_usb: fix spelling mistake of "outstanding" (2016-12-01 14:2

Re: [PATCH v3 net-next 3/3] openvswitch: Fix skb->protocol for vlan frames.

2016-12-01 Thread Pravin Shelar
On Wed, Nov 30, 2016 at 6:30 AM, Jiri Benc wrote: > On Tue, 29 Nov 2016 15:30:53 -0800, Jarno Rajahalme wrote: >> Do not always set skb->protocol to be the ethertype of the L3 header. >> For a packet with non-accelerated VLAN tags skb->protocol needs to be >> the ethertype of the outermost non-acc

Re: [PATCH net-next 5/6] net: dsa: mv88e6xxx: add helper for switch ready

2016-12-01 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > As we have seen in the past, this sort of loop is broken if we end up > sleeping for a long time. Please take the opportunity to replace it > with one of our _wait() helpers, e.g. mv88e6xxx_g1_wait() That won't work. the _wait() helpers are made to wait on self-

Re: [PATCH net] tcp: warn on bogus MSS and try to amend it

2016-12-01 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 30 Nov 2016 11:14:32 -0200 > There have been some reports lately about TCP connection stalls caused > by NIC drivers that aren't setting gso_size on aggregated packets on rx > path. This causes TCP to assume that the MSS is actually the size of the > aggre

[PATCH -next] net: ethernet: ti: davinci_cpdma: add missing EXPORTs

2016-12-01 Thread Paul Gortmaker
As of commit 8f32b90981dcdb355516fb95953133f8d4e6b11d ("net: ethernet: ti: davinci_cpdma: add set rate for a channel") the ARM allmodconfig builds would fail modpost with: ERROR: "cpdma_chan_set_weight" [drivers/net/ethernet/ti/ti_cpsw.ko] undefined! ERROR: "cpdma_chan_get_rate" [drivers/net/ether

Re: [RFC PATCH net-next] ipv6: implement consistent hashing for equal-cost multipath routing

2016-12-01 Thread David Miller
From: Hannes Frederic Sowa Date: Wed, 30 Nov 2016 14:12:48 +0100 > David, one question: do you remember if you measured with linked lists > at that time or also with arrays. I actually would expect small arrays > that entirely fit into cachelines to be actually faster than our current > approach,

Re: [PATCH] stmmac: simplify flag assignment

2016-12-01 Thread David Miller
From: Pavel Machek Date: Wed, 30 Nov 2016 12:44:31 +0100 > > Simplify flag assignment. > > Signed-off-by: Pavel Machek > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index ed20668..0b706a7 100644 > --- a/drivers/

Re: [RFC net-next 0/3] net: bridge: Allow CPU port configuration

2016-12-01 Thread Florian Fainelli
On 11/23/2016 05:48 AM, Ido Schimmel wrote: > Hi Florian, > > On Tue, Nov 22, 2016 at 09:56:30AM -0800, Florian Fainelli wrote: >> On 11/22/2016 09:41 AM, Ido Schimmel wrote: >>> Hi Florian, >>> >>> On Mon, Nov 21, 2016 at 11:09:22AM -0800, Florian Fainelli wrote: Hi all, This patch

[PATCH iproute2 1/1] tc: updated man page to reflect handle-id use in filter GET command.

2016-12-01 Thread Roman Mashak
Signed-off-by: Roman Mashak --- man/man8/tc.8 | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/man/man8/tc.8 b/man/man8/tc.8 index 8a47a2b..d957ffa 100644 --- a/man/man8/tc.8 +++ b/man/man8/tc.8 @@ -32,7 +32,9 @@ class-id ] qdisc DEV .B [ parent qdisc-id -.B | root ] p

Re: [WIP] net+mlx4: auto doorbell

2016-12-01 Thread David Miller
From: Eric Dumazet Date: Thu, 01 Dec 2016 09:04:17 -0800 > On Thu, 2016-12-01 at 17:04 +0100, Jesper Dangaard Brouer wrote: > >> When qdisc layer or trafgen/af_packet see this indication it knows it >> should/must flush the queue when it don't have more work left. Perhaps >> through net_tx_acti

Re: Initial thoughts on TXDP

2016-12-01 Thread Tom Herbert
On Thu, Dec 1, 2016 at 11:48 AM, Rick Jones wrote: > On 12/01/2016 11:05 AM, Tom Herbert wrote: >> >> For the GSO and GRO the rationale is that performing the extra SW >> processing to do the offloads is significantly less expensive than >> running each packet through the full stack. This is true

Re: Initial thoughts on TXDP

2016-12-01 Thread Sowmini Varadhan
On (12/01/16 11:05), Tom Herbert wrote: > > Polling does not necessarily imply that networking monopolizes the CPU > except when the CPU is otherwise idle. Presumably the application > drives the polling when it is ready to receive work. I'm not grokking that- "if the cpu is idle, we want to busy

Re: [WIP] net+mlx4: auto doorbell

2016-12-01 Thread Eric Dumazet
On Thu, 2016-12-01 at 20:17 +0100, Jesper Dangaard Brouer wrote: > On Thu, 01 Dec 2016 09:04:17 -0800 Eric Dumazet > wrote: > > > BTW, if you are doing tests on mlx4 40Gbit, > > I'm mostly testing with mlx5 50Gbit, but I do have 40G NIC in the > machines too. > > > would you check the > > fol

Re: [PATCH 2/2] net: rfkill: Add rfkill-any LED trigger

2016-12-01 Thread Michał Kępień
> Hi Michał, > > [auto build test ERROR on mac80211-next/master] > [also build test ERROR on v4.9-rc7 next-20161201] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/li

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread David Miller
Hannes and Ido, It looks like we are very close to having this in mergable shape, can you guys work out this final issue and figure out if it really is a merge stopped or not? Thanks.

Re: Initial thoughts on TXDP

2016-12-01 Thread Tom Herbert
On Wed, Nov 30, 2016 at 6:44 PM, Florian Westphal wrote: > Tom Herbert wrote: >> Posting for discussion > > Warning: You are not going to like this reply... > >> Now that XDP seems to be nicely gaining traction > > Yes, I regret to see that. XDP seems useful to create impressive > benchmark

Re: [PATCH v3 net-next 2/3] openvswitch: Use is_skb_forwardable() for length check.

2016-12-01 Thread Pravin Shelar
On Wed, Nov 30, 2016 at 5:51 AM, Jiri Benc wrote: > On Tue, 29 Nov 2016 15:30:52 -0800, Jarno Rajahalme wrote: >> @@ -504,11 +485,20 @@ void ovs_vport_send(struct vport *vport, struct >> sk_buff *skb, u8 mac_proto) >> goto drop; >> } >> >> - if (unlikely(packet_length(skb,

Re: Initial thoughts on TXDP

2016-12-01 Thread Rick Jones
On 12/01/2016 11:05 AM, Tom Herbert wrote: For the GSO and GRO the rationale is that performing the extra SW processing to do the offloads is significantly less expensive than running each packet through the full stack. This is true in a multi-layered generalized stack. In TXDP, however, we shoul

  1   2   3   >