Re: Virtio_net support vxlan encapsulation package TSO offload discuss

2016-11-16 Thread Jason Wang
On 2016年11月17日 09:31, Zhangming (James, Euler) wrote: On 2016年11月15日 11:28, Jason Wang wrote: On 2016年11月10日 14:19, Zhangming (James, Euler) wrote: On 2016年11月09日 15:14, Jason Wang wrote: On 2016年11月08日 19:58, Zhangming (James, Euler) wrote: On 2016年11月08日 19:17, Jason Wang wrote: On 2016

Re: [Patch net] net: check dead netns for peernet2id_alloc()

2016-11-16 Thread Andrei Vagin
On Wed, Nov 16, 2016 at 10:27 AM, Cong Wang wrote: > Andrei reports we still allocate netns ID from idr after we destroy > it in cleanup_net(). > > cleanup_net(): > ... > idr_destroy(&net->netns_ids); > ... > list_for_each_entry_reverse(ops, &pernet_list, list) > ops_exit_list(ops, &ne

Re: [PATCH net-next v2 3/3] net: marvell: Allow drivers to be built with COMPILE_TEST

2016-11-16 Thread kbuild test robot
Hi Florian, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-fsl-Allow-most-drivers-to-be-built-with-COMPILE_TEST/20161116-094841 config: mips-allyesconfig (attached as .config) compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1

Re: [v2] cw1200: fix bogus maybe-uninitialized warning

2016-11-16 Thread Kalle Valo
Arnd Bergmann wrote: > On x86, the cw1200 driver produces a rather silly warning about the > possible use of the 'ret' variable without an initialization > presumably after being confused by the architecture specific definition > of WARN_ON: > > drivers/net/wireless/st/cw1200/wsm.c: In function ‘

Re: wireless: fix bogus maybe-uninitialized warning

2016-11-16 Thread Kalle Valo
Arnd Bergmann wrote: > The hostap_80211_rx() function is supposed to set up the mac addresses > for four possible cases, based on two bits of input data. For > some reason, gcc decides that it's possible that none of the these > four cases apply and the addresses remain uninitialized: > > drivers

Re: p54: memset(0) whole array

2016-11-16 Thread Kalle Valo
Jiri Slaby wrote: > gcc 7 complains: > drivers/net/wireless/intersil/p54/fwio.c: In function 'p54_scan': > drivers/net/wireless/intersil/p54/fwio.c:491:4: warning: 'memset' used with > length equal to number of elements without multiplication by element size > [-Wmemset-elt-size] > > Fix that b

Re: brcmfmac: print name of connect status event

2016-11-16 Thread Kalle Valo
Rafał Miłecki wrote: > From: Rafał Miłecki > > This simplifies debugging. Format %s (%u) comes from similar debugging > message in brcmf_fweh_event_worker. > > Signed-off-by: Rafał Miłecki Patch applied to wireless-drivers-next.git, thanks. e1c122d55f9e brcmfmac: print name of connect status

Re: wlcore: Allow scans when in AP mode

2016-11-16 Thread Kalle Valo
Xander Huff wrote: > From: James Minor > > When in AP mode, scans can be done without changing firmware to > the multi-role firmware. Allow the interface to scan if forced > in the scan request. > > Signed-off-by: James Minor > Signed-off-by: Xander Huff > Reviewed-by: Ben Shelton > Reviewed

Re: [v3] mwifiex: report wakeup for wowlan

2016-11-16 Thread Kalle Valo
Rajat Jain wrote: > Register the WLAN device as a wakeup source since it can > wake the system via wake-on-wireless-lan. In an actual wowlan > event, notify the PM core that we are the current wakeup source. > This allows the PM core to update the wakeup attributes in /sys. > > This was causing w

Re: [PATCH net v2] net: nsid cannot be allocated for a dead netns

2016-11-16 Thread Cong Wang
On Wed, Nov 16, 2016 at 8:17 PM, David Miller wrote: > From: Cong Wang > Date: Wed, 16 Nov 2016 09:29:29 -0800 > >> On Wed, Nov 16, 2016 at 1:49 AM, Nicolas Dichtel >> wrote: >>> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c >>> index f61c0e02a413..63f65387f4e1 100644 >>> ---

Philanthropic Gesture

2016-11-16 Thread Susanne Hanna Ursula Klattent
Hello I want to donate a token of my Wealth as part of my Philanthropic Gesture to the world . Interested individuals or groups should contact me. Regards Susanne Hanna Ursula Klatten Email: sussanklatte...@gmail.com

Re: [PATCH net] : add a missing rcu synchronization

2016-11-16 Thread Eric Dumazet
On Wed, 2016-11-16 at 23:31 -0500, David Miller wrote: > From: Eric Dumazet > Date: Wed, 16 Nov 2016 06:31:52 -0800 > > > From: Eric Dumazet > > > > Add a missing synchronize_net() call to avoid potential use after free, > > since we explicitly call napi_hash_del() to factorize the RCU grace >

Re: [PATCH net] : add a missing rcu synchronization

2016-11-16 Thread David Miller
From: Eric Dumazet Date: Wed, 16 Nov 2016 06:31:52 -0800 > From: Eric Dumazet > > Add a missing synchronize_net() call to avoid potential use after free, > since we explicitly call napi_hash_del() to factorize the RCU grace > period. > > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet dri

Re: [patch net-next 0/4] mlxsw: Introduce support for I2C bus

2016-11-16 Thread David Miller
From: Jiri Pirko Date: Wed, 16 Nov 2016 15:20:42 +0100 > Vadim says: > > This patchset adds I2C access support for SwitchX, SwitchX2, SwitchIB, > SwitchIB2 and Spectrum silicones. Series applied, thanks.

Re: [PATCH 1/2] net: netcp: replace IS_ERR_OR_NULL by IS_ERR

2016-11-16 Thread David Miller
From: Julia Lawall Date: Wed, 16 Nov 2016 11:43:33 +0100 > knav_queue_open always returns an ERR_PTR value, never NULL. This can be > confirmed by unfolding the function calls and conforms to the function's > documentation. Thus, replace IS_ERR_OR_NULL by IS_ERR in error checks. > > The change

Re: [PATCH net] net: dsa: b53: Fix VLAN usage and how we treat CPU port

2016-11-16 Thread David Miller
From: Florian Fainelli Date: Tue, 15 Nov 2016 15:58:15 -0800 > We currently have a fundamental problem in how we treat the CPU port and > its VLAN membership. As soon as a second VLAN is configured to be > untagged, the CPU automatically becomes untagged for that VLAN as well, > and yet, we don't

Re: [PATCH net] sctp: use new rhlist interface on sctp transport rhashtable

2016-11-16 Thread David Miller
From: Xin Long Date: Tue, 15 Nov 2016 23:23:11 +0800 > Now sctp transport rhashtable uses hash(lport, dport, daddr) as the key > to hash a node to one chain. If in one host thousands of assocs connect > to one server with the same lport and different laddrs (although it's > not a normal case), al

Re: [PATCH net v2] net: nsid cannot be allocated for a dead netns

2016-11-16 Thread David Miller
From: Cong Wang Date: Wed, 16 Nov 2016 09:29:29 -0800 > On Wed, Nov 16, 2016 at 1:49 AM, Nicolas Dichtel > wrote: >> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c >> index f61c0e02a413..63f65387f4e1 100644 >> --- a/net/core/net_namespace.c >> +++ b/net/core/net_namespace.c >>

Re: [PATCH net-next 0/4] bnxt_en: Updates.

2016-11-16 Thread David Miller
From: Michael Chan Date: Wed, 16 Nov 2016 21:13:06 -0500 > New firmware spec. update, autoneg update, and UDP RSS support. Looks good, series applied, thanks Michael.

Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf

2016-11-16 Thread Joe Stringer
On 16 November 2016 at 19:39, Wangnan (F) wrote: > > > On 2016/11/17 10:46, Joe Stringer wrote: >> >> On 16 November 2016 at 18:10, Wangnan (F) wrote: >>> >>> I'm also working on improving bpf.c. Please have a look at: >>> >>> https://lkml.org/lkml/2016/11/14/1078 >>> >>> Since bpf.c is simple, I

Re: CPU port VLAN configuration [Was: Re: [PATCH net] net: dsa: b53: Fix VLAN usage and how we treat CPU port]

2016-11-16 Thread Vivien Didelot
Hi Florian, Florian Fainelli writes: >> We currently have a fundamental problem in how we treat the CPU port and >> its VLAN membership. As soon as a second VLAN is configured to be >> untagged, the CPU automatically becomes untagged for that VLAN as well, >> and yet, we don't gracefully make su

Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf

2016-11-16 Thread Wangnan (F)
On 2016/11/17 10:46, Joe Stringer wrote: On 16 November 2016 at 18:10, Wangnan (F) wrote: I'm also working on improving bpf.c. Please have a look at: https://lkml.org/lkml/2016/11/14/1078 Since bpf.c is simple, I think we can add more functions and fixes gradually, instead of a full copy.

Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf

2016-11-16 Thread Joe Stringer
On 16 November 2016 at 19:21, Wangnan (F) wrote: > > > On 2016/11/17 10:46, Joe Stringer wrote: >> >> On 16 November 2016 at 18:10, Wangnan (F) wrote: >>> >>> I'm also working on improving bpf.c. Please have a look at: >>> >>> https://lkml.org/lkml/2016/11/14/1078 >>> >>> Since bpf.c is simple, I

RE: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable

2016-11-16 Thread Hayes Wang
[...] > Fix the hw rx checksum is always enabled, and the user couldn't switch > it to sw rx checksum. > > Note that the RTL_VER_01 only supports sw rx checksum only. Besides, > the hw rx checksum for RTL_VER_02 is disabled after > commit b9a321b48af4 ("r8152: Fix broken RX checksums."). Re-enable

Re: [PATCH] net: dsa: mv88e6xxx: Respect SPEED_UNFORCED, don't set force bit

2016-11-16 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > The SPEED_UNFORCED indicates the MAC & PHY should perform > auto-negotiation to determine a speed which works. If this is called > for, don't set the force bit. If it is set, the MAC actually does > 10Gbps, why the internal PHYs don't support. > > Signed-off-by:

linux-next: build failure after merge of the tip tree

2016-11-16 Thread Stephen Rothwell
Hi all, After merging the tip tree, today's linux-next build (arm multi_v7_defconfig) failed like this: net/core/dev.c: In function 'sk_busy_loop': net/core/dev.c:5065:3: error: implicit declaration of function 'cpu_relax_lowlatency' [-Werror=implicit-function-declaration] cpu_relax_lowlatenc

Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf

2016-11-16 Thread Wangnan (F)
On 2016/11/17 10:46, Joe Stringer wrote: On 16 November 2016 at 18:10, Wangnan (F) wrote: I'm also working on improving bpf.c. Please have a look at: https://lkml.org/lkml/2016/11/14/1078 Since bpf.c is simple, I think we can add more functions and fixes gradually, instead of a full copy.

RE: [PATCH net 2/2] r8152: rx descriptor check

2016-11-16 Thread Hayes Wang
Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Tuesday, November 15, 2016 9:11 AM [...] > If it was possible to get it wrong once, it should be possible to > get it wrong twice, especially if some part of the hardware design > is recycled. I don't mean anything else. I agree with you. Howev

linux-next: manual merge of the tip tree with the net-next tree

2016-11-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tip tree got a conflict in: drivers/net/ethernet/amd/Kconfig between commits: e78332b2285d ("amd-xgbe: Add ECC status support for the device memory") abf0a1c2b26a ("amd-xgbe: Add support for SFP+ modules") from the net-next tree and commit: d1cb

Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf

2016-11-16 Thread Joe Stringer
On 16 November 2016 at 18:10, Wangnan (F) wrote: > I'm also working on improving bpf.c. Please have a look at: > > https://lkml.org/lkml/2016/11/14/1078 > > Since bpf.c is simple, I think we can add more functions and fixes > gradually, instead of a full copy. > > See my inline comment below. Ah,

Re: [PATCH] net: ethernet: faraday: To support device tree usage.

2016-11-16 Thread Greentime Hu
On Thu, Nov 17, 2016 at 12:12 AM, Arnd Bergmann wrote: > On Wednesday, November 16, 2016 3:37:15 PM CET Andrew Lunn wrote: >> On Wed, Nov 16, 2016 at 10:26:52PM +0800, Greentime Hu wrote: >> > On Wed, Nov 16, 2016 at 9:47 PM, Andrew Lunn wrote: >> > > On Wed, Nov 16, 2016 at 04:43:15PM +0800, Gre

Re: [PATCH net-next v2 3/3] net: marvell: Allow drivers to be built with COMPILE_TEST

2016-11-16 Thread kbuild test robot
Hi Florian, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-fsl-Allow-most-drivers-to-be-built-with-COMPILE_TEST/20161116-094841 config: m32r-allmodconfig (attached as .config) compiler: m32r-linux-gcc (GCC) 6.2.0 reproduce

[PATCH net-next] af_packet: Use virtio_net_hdr_to_skb().

2016-11-16 Thread Jarno Rajahalme
Use the common virtio_net_hdr_to_skb() instead of open coding it. Other call sites were changed by commit fd2a0437dc, but this one was missed, maybe because it is split in two parts of the source code. Also fix other call sites to be more uniform. Fixes: fd2a0437dc ("virtio_net: introduce virtio_

[PATCH net-next 1/4] bnxt_en: Update firmware interface spec to 1.5.4.

2016-11-16 Thread Michael Chan
Use the new FORCE_LINK_DWN bit to shutdown link during close. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 ++- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 91 +-- 2 files changed, 94 insertions(+), 5 deletions(-) diff --git a/dr

[PATCH net-next 0/4] bnxt_en: Updates.

2016-11-16 Thread Michael Chan
New firmware spec. update, autoneg update, and UDP RSS support. Michael Chan (4): bnxt_en: Update firmware interface spec to 1.5.4. bnxt_en: Enhance autoneg support. bnxt_en: Add UDP RSS support for 57X1X chips. bnxt_en: Add ethtool -n|-N rx-flow-hash support. drivers/net/ethernet/broadc

[PATCH net-next 4/4] bnxt_en: Add ethtool -n|-N rx-flow-hash support.

2016-11-16 Thread Michael Chan
To display and modify the RSS hash. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 167 +- 1 file changed, 164 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/b

[PATCH net-next 2/4] bnxt_en: Enhance autoneg support.

2016-11-16 Thread Michael Chan
On some dual port NICs, the speed setting on one port can affect the available speed on the other port. Add logic to detect these changes and adjust the advertised speed settings when necessary. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 23 +

[PATCH net-next 3/4] bnxt_en: Add UDP RSS support for 57X1X chips.

2016-11-16 Thread Michael Chan
The newer chips have proper support for 4-tuple UDP RSS. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 21 ++--- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 ++- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/

Re: [PATCHv2 perf/core 2/2] tools lib bpf: Sync with samples/bpf/libbpf

2016-11-16 Thread Wangnan (F)
I'm also working on improving bpf.c. Please have a look at: https://lkml.org/lkml/2016/11/14/1078 Since bpf.c is simple, I think we can add more functions and fixes gradually, instead of a full copy. See my inline comment below. On 2016/11/17 1:43, Joe Stringer wrote: Extend the tools/ versio

[net-next] af_packet: Use virtio_net_hdr_to_skb().

2016-11-16 Thread Jarno Rajahalme
Use the common virtio_net_hdr_to_skb() instead of open coding it. Other call sites were changed by commit fd2a0437dc, but this one was missed, maybe because it is split in two parts of the source code. Also fix other call sites to be more uniform. Fixes: fd2a0437dc ("virtio_net: introduce virtio_

Re: [PATCH net-next] netpoll: more efficient locking

2016-11-16 Thread David Miller
From: Eric Dumazet Date: Wed, 16 Nov 2016 14:54:50 -0800 > From: Eric Dumazet > > Callers of netpoll_poll_lock() own NAPI_STATE_SCHED > > Callers of netpoll_poll_unlock() have BH blocked between > the NAPI_STATE_SCHED being cleared and poll_lock is released. > > We can avoid the spinlock whic

Re: [PATCH net-next v3 2/3] net: fsl: Allow most drivers to be built with COMPILE_TEST

2016-11-16 Thread Fengguang Wu
On Wed, Nov 16, 2016 at 11:52:45AM -0800, Florian Fainelli wrote: On 11/15/2016 07:23 PM, kbuild test robot wrote: Hi Florian, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-gianfar_ptp-Rename-FS-bit-to-FIPERST/20161116

Re: Virtio_net support vxlan encapsulation package TSO offload discuss

2016-11-16 Thread Zhangming (James, Euler)
On 2016年11月15日 11:28, Jason Wang wrote: >On 2016年11月10日 14:19, Zhangming (James, Euler) wrote: >> On 2016年11月09日 15:14, Jason Wang wrote: >>> On 2016年11月08日 19:58, Zhangming (James, Euler) wrote: On 2016年11月08日 19:17, Jason Wang wrote: > On 2016年11月08日 19:13, Jason Wang wrote: >>

Re: [PATCHv2 perf/core 1/2] tools lib bpf: Sync {tools,}/include/uapi/linux/bpf.h

2016-11-16 Thread Wangnan (F)
On 2016/11/17 1:43, Joe Stringer wrote: The tools version of this header is out of date; update it to the latest version from the kernel headers. Signed-off-by: Joe Stringer --- v2: No change. --- tools/include/uapi/linux/bpf.h | 51 ++ 1 file change

Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-16 Thread Vicente Jiménez
On Wed, Nov 16, 2016 at 2:14 AM, Florian Westphal wrote: > Vicente Jiménez wrote: >> 1- add warning with pr_warn_ratelimited. I like this idea. I also >> though about adding some message but I have no kernel experience and I >> preferred to have just a working solution. > > I added this only to s

Re: Netperf UDP issue with connected sockets

2016-11-16 Thread Eric Dumazet
On Wed, 2016-11-16 at 23:40 +0100, Jesper Dangaard Brouer wrote: > Using -R 1 does not seem to help remove __ip_select_ident() > > Samples: 56K of event 'cycles', Event count (approx.): 78628132661 > Overhead CommandShared ObjectSymbol > +9.11% netperf[kernel.vmlin

[PATCH] netns: make struct pernet_operations::id unsigned int

2016-11-16 Thread Alexey Dobriyan
Make struct pernet_operations::id unsigned. There are 2 reasons to do so: 1) This field is really an index into an zero based array and thus is unsigned entity. Using negative value is out-of-bound access by definition. 2) On x86_64 unsigned 32-bit data which are mixed with pointers via array in

linux-next: manual merge of the net-next tree with the net tree

2016-11-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: kernel/bpf/verifier.c between commit: f23cc643f9ba ("bpf: fix range arithmetic for bpf map access") from the net tree and commit: de464375daf0 ("bpf: Remove unused but set variables") from the net-next tree. I fi

linux-next: manual merge of the net-next tree with the net tree

2016-11-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/linux/bpf_verifier.h between commit: f23cc643f9ba ("bpf: fix range arithmetic for bpf map access") from the net tree and commit: 57a09bf0a416 ("bpf: Detect identical PTR_TO_MAP_VALUE_OR_NULL registers") fr

linux-next: manual merge of the net-next tree with the net tree

2016-11-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c between commit: ba1ffd74df74 ("stmmac: fix PTP support for GMAC4") from the net tree and commit: f8be0d78be6e ("net: ethernet: stmmac: change dma descriptors to __

linux-next: manual merge of the net-next tree with the net tree

2016-11-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/cavium/thunder/nicvf_main.c between commit: 712c31853440 ("net: thunderx: Program LMAC credits based on MTU") from the net tree and commit: 109cc16526c6 ("ethernet/cavium: use core min/max MTU

Re: [PATCH net-next v6] cadence: Add LSO support.

2016-11-16 Thread David Miller
From: Rafal Ozieblo Date: Wed, 16 Nov 2016 10:02:34 + > New Cadence GEM hardware support Large Segment Offload (LSO): > TCP segmentation offload (TSO) as well as UDP fragmentation > offload (UFO). Support for those features was added to the driver. > --- > Changed in v2: > macb_lso_check_comp

Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-16 Thread David Miller
From: Alexandru Gagniuc Date: Wed, 16 Nov 2016 01:02:33 -0800 > With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The > VSC8601 can handle this internally. While the VSC8601 can set more > fine-grained delays, the standard skew settings work out of the box. > The same heuristic

[PATCH net-next] netpoll: more efficient locking

2016-11-16 Thread Eric Dumazet
From: Eric Dumazet Callers of netpoll_poll_lock() own NAPI_STATE_SCHED Callers of netpoll_poll_unlock() have BH blocked between the NAPI_STATE_SCHED being cleared and poll_lock is released. We can avoid the spinlock which has no contention, and use cmpxchg() on poll_owner which we need to set a

Re: [PATCH] net: bcm63xx_enet: fix build failure

2016-11-16 Thread David Miller
From: Sudip Mukherjee Date: Wed, 16 Nov 2016 22:50:16 + > The build of mips bcm63xx_defconfig was failing with the error: > drivers/net/ethernet/broadcom/bcm63xx_enet.c:1440:2: > error: expected expression before 'return' > > The return statement should be termibated with ';' and not '

[PATCH] net: bcm63xx_enet: fix build failure

2016-11-16 Thread Sudip Mukherjee
The build of mips bcm63xx_defconfig was failing with the error: drivers/net/ethernet/broadcom/bcm63xx_enet.c:1440:2: error: expected expression before 'return' The return statement should be termibated with ';' and not ','. Fixes: 42469bf5d9bb ("net: bcm63xx_enet: Utilize phy_ethtool_nway

Re: Netperf UDP issue with connected sockets

2016-11-16 Thread Rick Jones
On 11/16/2016 02:40 PM, Jesper Dangaard Brouer wrote: On Wed, 16 Nov 2016 09:46:37 -0800 Rick Jones wrote: It is a wild guess, but does setting SO_DONTROUTE affect whether or not a connect() would have the desired effect? That is there to protect people from themselves (long story about people

[PATCH iproute2 v2 7/9] l2tp: support sequence numbering

2016-11-16 Thread Asbjørn Sloth Tønnesen
This patch implement and documents the user interface for sequence numbering. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c| 23 +++ man/man8/ip-l2tp.8 | 15 +++ 2 files changed, 38 insertions(+) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index f5d411

[PATCH iproute2 v2 8/9] l2tp: show tunnel: expose UDP checksum state

2016-11-16 Thread Asbjørn Sloth Tønnesen
Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index ab35023..f2bbc0c 100644 --- a/ip/ipl2tp.c +++ b/ip/ipl2tp.c @@ -218,9 +218,24 @@ static void print_tunnel(const struct l2tp_d

[PATCH iproute2 v2 4/9] l2tp: fix L2TP_ATTR_{RECV,SEND}_SEQ handling

2016-11-16 Thread Asbjørn Sloth Tønnesen
L2TP_ATTR_RECV_SEQ and L2TP_ATTR_SEND_SEQ are declared as NLA_U8 attributes in the kernel, so let's threat them accordingly. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index 2e0e9c

[PATCH iproute2 v2 6/9] l2tp: read IPv6 UDP checksum attributes from kernel

2016-11-16 Thread Asbjørn Sloth Tønnesen
In case of an older kernel that doesn't set L2TP_ATTR_UDP_ZERO_CSUM6_{RX,TX} the old hard-coded value is being preserved, since the attribute flag will be missing. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/i

[PATCH iproute2 v2 3/9] l2tp: fix integers with too few significant bits

2016-11-16 Thread Asbjørn Sloth Tønnesen
udp6_csum_{tx,rx}, tunnel and session are the only ones currently used. recv_seq, send_seq, lns_mode and data_seq are partially implemented in a useless way. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --gi

[PATCH iproute2 v2 5/9] l2tp: fix L2TP_ATTR_UDP_CSUM handling

2016-11-16 Thread Asbjørn Sloth Tønnesen
L2TP_ATTR_UDP_CSUM is read by the kernel as a NLA_FLAG value, but is validated as a NLA_U8, so we will write it as an u8, but the value isn't actually being read by the kernel. It is written by the kernel as a NLA_U8, so we will read as such. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.

[PATCH iproute2 v2 9/9] man: ip-l2tp.8: document UDP checksum options

2016-11-16 Thread Asbjørn Sloth Tønnesen
Signed-off-by: Asbjørn Sloth Tønnesen --- man/man8/ip-l2tp.8 | 33 + 1 file changed, 33 insertions(+) diff --git a/man/man8/ip-l2tp.8 b/man/man8/ip-l2tp.8 index d4e7270..8ce630a 100644 --- a/man/man8/ip-l2tp.8 +++ b/man/man8/ip-l2tp.8 @@ -30,6 +30,12 @@ ip-l2tp -

[PATCH iproute2 v2 2/9] man: ip-l2tp.8: remove non-existent tunnel parameter name

2016-11-16 Thread Asbjørn Sloth Tønnesen
The name parameter is only valid for sessions, not tunnels. Signed-off-by: Asbjørn Sloth Tønnesen --- man/man8/ip-l2tp.8 | 3 --- 1 file changed, 3 deletions(-) diff --git a/man/man8/ip-l2tp.8 b/man/man8/ip-l2tp.8 index 4a3bb20..991d097 100644 --- a/man/man8/ip-l2tp.8 +++ b/man/man8/ip-l2tp.8 @

[PATCH iproute2 v2 1/9] man: ip-l2tp.8: fix l2spec_type documentation

2016-11-16 Thread Asbjørn Sloth Tønnesen
Signed-off-by: Asbjørn Sloth Tønnesen --- man/man8/ip-l2tp.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-l2tp.8 b/man/man8/ip-l2tp.8 index 5b7041f..4a3bb20 100644 --- a/man/man8/ip-l2tp.8 +++ b/man/man8/ip-l2tp.8 @@ -239,7 +239,7 @@ find in received L2TP packet

Re: Netperf UDP issue with connected sockets

2016-11-16 Thread Jesper Dangaard Brouer
On Wed, 16 Nov 2016 09:46:37 -0800 Rick Jones wrote: > On 11/16/2016 04:16 AM, Jesper Dangaard Brouer wrote: > > [1] Subj: High perf top ip_idents_reserve doing netperf UDP_STREAM > > - https://www.spinics.net/lists/netdev/msg294752.html > > > > Not fixed in version 2.7.0. > > - ftp://ftp.netpe

[PATCH iproute2 1/1] tc: distinguish Add/Replace filter operations

2016-11-16 Thread Roman Mashak
Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim --- tc/tc_filter.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tc/tc_filter.c b/tc/tc_filter.c index 932677a..ff8713b 100644 --- a/tc/tc_filter.c +++ b/tc/tc_filter.c @@ -226,6 +226,16 @@ int print_filter(const struc

[PATCH net 1/1] net sched filters: pass netlink message flags in event notification

2016-11-16 Thread Roman Mashak
Userland client should be able to read an event, and reflect it back to the kernel, therefore it needs to extract complete set of netlink flags. For example, this will allow "tc monitor" to distinguish Add and Replace operations. Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim ---

Re: [PATCH net] cxgb4: do not call napi_hash_del()

2016-11-16 Thread David Miller
From: Eric Dumazet Date: Wed, 16 Nov 2016 06:19:02 -0800 > From: Eric Dumazet > > Calling napi_hash_del() before netif_napi_del() is dangerous > if a synchronize_rcu() is not enforced before NAPI struct freeing. > > Lets leave this detail to core networking stack and feel > more comfortable. >

Re: [PATCH net] be2net: do not call napi_hash_del()

2016-11-16 Thread David Miller
From: Eric Dumazet Date: Wed, 16 Nov 2016 06:12:42 -0800 > From: Eric Dumazet > > Calling napi_hash_del() before netif_napi_del() is dangerous > if a synchronize_rcu() is not enforced before NAPI struct freeing. > > Lets leave this detail to core networking stack and feel > more comfortable. >

Re: [PATCH] netronome: don't access real_num_rx_queues directly

2016-11-16 Thread David Miller
From: Arnd Bergmann Date: Wed, 16 Nov 2016 15:10:49 +0100 > The netdev->real_num_rx_queues setting is only available if CONFIG_SYSFS > is enabled, so we now get a build failure when that is turned off: > > netronome/nfp/nfp_net_common.c: In function 'nfp_net_ring_swap_enable': > netronome/nfp/nf

Re: [PATCH net-next] sfc: remove napi_hash_del() call

2016-11-16 Thread David Miller
From: Eric Dumazet Date: Wed, 16 Nov 2016 06:01:47 -0800 > From: Eric Dumazet > > Calling napi_hash_del() after netif_napi_del() is pointless. > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH net-next] lwtunnel: subtract tunnel headroom from mtu on output redirect

2016-11-16 Thread David Miller
From: David Lebrun Date: Wed, 16 Nov 2016 10:05:46 +0100 > This patch changes the lwtunnel_headroom() function which is called > in ipv4_mtu() and ip6_mtu(), to also return the correct headroom > value when the lwtunnel state is OUTPUT_REDIRECT. > > This patch enables e.g. SR-IPv6 encapsulations

[PATCH net-next 2/3] RDS: TCP: Track peer's connection generation number

2016-11-16 Thread Sowmini Varadhan
The RDS transport has to be able to distinguish between two types of failure events: (a) when the transport fails (e.g., TCP connection reset) but the RDS socket/connection layer on both sides stays the same (b) when the peer's RDS layer itself resets (e.g., due to module reload or mach

[PATCH net-next 3/3] RDS: TCP: Force every connection to be initiated by numerically smaller IP address

2016-11-16 Thread Sowmini Varadhan
When 2 RDS peers initiate an RDS-TCP connection simultaneously, there is a potential for "duelling syns" on either/both sides. See commit 241b271952eb ("RDS-TCP: Reset tcp callbacks if re-using an outgoing socket in rds_tcp_accept_one()") for a description of this condition, and the arbitration log

[PATCH net-next 1/3] RDS: TCP: set RDS_FLAG_RETRANSMITTED in cp_retrans list

2016-11-16 Thread Sowmini Varadhan
As noted in rds_recv_incoming() sequence numbers on data packets can decreas for the failover case, and the Rx path is equipped to recover from this, if the RDS_FLAG_RETRANSMITTED is set on the rds header of an incoming message with a suspect sequence number. The RDS_FLAG_RETRANSMITTED is predicat

[PATCH net-next 0/3] RDS: TCP: HA/Failover fixes

2016-11-16 Thread Sowmini Varadhan
This series contains a set of fixes for bugs exposed when we ran the following in a loop between a test machine pair: while (1); do # modprobe rds-tcp on test nodes # run rds-stress in bi-dir mode between test machine pair # modprobe -r rds-tcp on test nodes done rds-stress in bi-dir

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

2016-11-16 Thread Jes Sorensen
John Heenan writes: > Barry Day has submitted real world reports for the 8192eu and 8192cu. > This needs to be acknowledged. I have submitted real world reports for > the 8723bu. Lets get this a little more clear - first of all, I have asked you to investigate which part resolves the problem. Rat

Re: net/l2tp:BUG: KASAN: use-after-free in l2tp_ip6_close

2016-11-16 Thread Guillaume Nault
On Wed, Nov 16, 2016 at 11:08:23AM -0800, Cong Wang wrote: > On Wed, Nov 16, 2016 at 8:30 AM, Guillaume Nault wrote: > > diff --git a/net/l2tp/l2tp_ip.c b/net/l2tp/l2tp_ip.c > > index fce25af..982f6c4 100644 > > --- a/net/l2tp/l2tp_ip.c > > +++ b/net/l2tp/l2tp_ip.c > > @@ -251,8 +251,6 @@ static i

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Ido Schimmel
On Wed, Nov 16, 2016 at 08:43:25PM +0100, Hannes Frederic Sowa wrote: > On 16.11.2016 19:51, Ido Schimmel wrote: > > On Wed, Nov 16, 2016 at 06:35:45PM +0100, Hannes Frederic Sowa wrote: > >> On 16.11.2016 16:18, Ido Schimmel wrote: > >>> On Wed, Nov 16, 2016 at 03:51:01PM +0100, Hannes Frederic So

HELLO

2016-11-16 Thread Wilfred Kabore
Dear Friend, Greetings and hope this mail meets you well! I want you to be my partner in the transfer of the sum of $6.7 Million dollars discovered in my department in one of the leading Banks (EcoBank Plc) here in Burkina-Faso. I shall give you more information on this proposal when I get yo

Re: [PATCH net 1/7] net: ethernet: ti: cpsw: fix bad register access in probe error path

2016-11-16 Thread Grygorii Strashko
On 11/16/2016 08:35 AM, Johan Hovold wrote: > Make sure to resume the platform device to enable clocks before > accessing the CPSW registers in the probe error path (e.g. for deferred > probe). > > Unhandled fault: external abort on non-linefetch (0x1008) at 0xd0872d08 > ... > [] (cpsw_ale_contr

Re: [PATCH net][v2] bpf: fix range arithmetic for bpf map access

2016-11-16 Thread Jann Horn
On Wed, Nov 16, 2016 at 9:25 PM, Josef Bacik wrote: > On 11/16/2016 01:41 PM, Jann Horn wrote: >> >> On Tue, Nov 15, 2016 at 3:20 PM, Josef Bacik wrote: >>> >>> On 11/15/2016 08:47 AM, Jann Horn wrote: In states_equal(): if (rold->type == NOT_INIT || (rold->type == UNKNOWN_

Re: [PATCH net][v2] bpf: fix range arithmetic for bpf map access

2016-11-16 Thread Josef Bacik
On 11/16/2016 01:41 PM, Jann Horn wrote: On Tue, Nov 15, 2016 at 3:20 PM, Josef Bacik wrote: On 11/15/2016 08:47 AM, Jann Horn wrote: In states_equal(): if (rold->type == NOT_INIT || (rold->type == UNKNOWN_VALUE && rcur->type != NOT_INIT)) < continue; I think this is broken in

Re: [patch net-next] mlxsw: spectrum_router: Adjust placement of FIB abort warning

2016-11-16 Thread David Miller
From: Jiri Pirko Date: Wed, 16 Nov 2016 09:51:58 +0100 > From: Ido Schimmel > > The recent merge commit bb598c1b8c9b ("Merge > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net") would cause > the FIB abort warning to fire whenever we flush the FIB tables - either > during module removal

Re: [BUG] X86: Removing inline decl on arch/x86/include/asm/desc.h.

2016-11-16 Thread Eric Dumazet
On Wed, 2016-11-16 at 20:16 +0100, Thomas Gleixner wrote: > On Tue, 15 Nov 2016, Corcodel Marian wrote: > > Inline declarations suppress warning message from compiler but > > most of these functions was declared static and is not used local on file. > > Huch? This is a header file and the functi

Re: [PATCH net] virtio-net: add a missing synchronize_net()

2016-11-16 Thread David Miller
From: Eric Dumazet Date: Tue, 15 Nov 2016 22:24:12 -0800 > From: Eric Dumazet > > It seems many drivers do not respect napi_hash_del() contract. > > When napi_hash_del() is used before netif_napi_del(), an RCU grace > period is needed before freeing NAPI object. > > Fixes: 91815639d880 ("virt

Re: [PATCH net-next v3 3/3] net: marvell: Allow drivers to be built with COMPILE_TEST

2016-11-16 Thread Florian Fainelli
On 11/16/2016 11:04 AM, kbuild test robot wrote: > Hi Florian, > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-gianfar_ptp-Rename-FS-bit-to-FIPERST/20161116-095805 > config: s390-allyesconfig

Re: [PATCH net-next v3 2/3] net: fsl: Allow most drivers to be built with COMPILE_TEST

2016-11-16 Thread Florian Fainelli
On 11/15/2016 07:23 PM, kbuild test robot wrote: > Hi Florian, > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-gianfar_ptp-Rename-FS-bit-to-FIPERST/20161116-095805 > config: sh-allmodconfig

Re: [PATCH net-next 0/6] Fixes for the MV88e6xxx interrupt code

2016-11-16 Thread Andrew Lunn
> Take a look at how the 'device_irq' local variable is used in > mv88e6xxx_g2_irq_setup. You assign it to 'err' in an error > path before it is ever set to anything. > > I think you meant to use the structure's 'device_irq' member > instead. Hi David Agreed. Thanks for the review. And

Re: [patch net-next 6/8] ipv4: fib: Add an API to request a FIB dump

2016-11-16 Thread Hannes Frederic Sowa
On 16.11.2016 19:51, Ido Schimmel wrote: > Hi, > > On Wed, Nov 16, 2016 at 06:35:45PM +0100, Hannes Frederic Sowa wrote: >> On 16.11.2016 16:18, Ido Schimmel wrote: >>> On Wed, Nov 16, 2016 at 03:51:01PM +0100, Hannes Frederic Sowa wrote: On 16.11.2016 15:09, Jiri Pirko wrote: > From: Ido

Re: [PATCH] net: dsa: mv88e6xxx: Respect SPEED_UNFORCED, don't set force bit

2016-11-16 Thread David Miller
From: Andrew Lunn Date: Wed, 16 Nov 2016 04:26:48 +0100 > The SPEED_UNFORCED indicates the MAC & PHY should perform > auto-negotiation to determine a speed which works. If this is called > for, don't set the force bit. If it is set, the MAC actually does > 10Gbps, why the internal PHYs don't supp

Re: [PATCH net-next 0/6] Fixes for the MV88e6xxx interrupt code

2016-11-16 Thread David Miller
From: David Miller Date: Wed, 16 Nov 2016 14:21:02 -0500 (EST) > From: Andrew Lunn > Date: Wed, 16 Nov 2016 01:56:50 +0100 > >> The interrupt code was never tested with a board who's probing >> resulted in an -EPROBE_DEFFERED. So the clean up paths never got >> tested. I now do have -EPROBE_DEF

Re: [PATCH net-next 0/6] Fixes for the MV88e6xxx interrupt code

2016-11-16 Thread David Miller
From: Andrew Lunn Date: Wed, 16 Nov 2016 01:56:50 +0100 > The interrupt code was never tested with a board who's probing > resulted in an -EPROBE_DEFFERED. So the clean up paths never got > tested. I now do have -EPROBE_DEFFERED, and things break badly during > cleanup. These are the fixes. > >

Re: [BUG] X86: Removing inline decl on arch/x86/include/asm/desc.h.

2016-11-16 Thread Thomas Gleixner
On Tue, 15 Nov 2016, Corcodel Marian wrote: > Inline declarations suppress warning message from compiler but > most of these functions was declared static and is not used local on file. Huch? This is a header file and the functions are marked inline on purpose. Can you please explain what you a

Re: [PATCH net] sctp: use new rhlist interface on sctp transport rhashtable

2016-11-16 Thread Marcelo Ricardo Leitner
On Tue, Nov 15, 2016 at 11:23:11PM +0800, Xin Long wrote: > Now sctp transport rhashtable uses hash(lport, dport, daddr) as the key > to hash a node to one chain. If in one host thousands of assocs connect > to one server with the same lport and different laddrs (although it's > not a normal case),

[PATCH 1/3] net: stmmac: replace all pr_xxx by their netdev_xxx counterpart

2016-11-16 Thread Corentin Labbe
From: LABBE Corentin The stmmac driver use lots of pr_xxx functions to print information. This is bad since we cannot know which device logs the information. (moreover if two stmmac device are present) Furthermore, it seems that it assumes wrongly that all logs will always be subsequent by using

[PATCH 3/3] net: stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

2016-11-16 Thread Corentin Labbe
From: LABBE Corentin As sugested by Joe Perches, we could replace all if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) by the simpler macro netif_xxx(priv, hw, priv->dev, ...) Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 49 ++-

[PATCH 2/3] net: stmmac: replace hardcoded function name by __func__

2016-11-16 Thread Corentin Labbe
From: LABBE Corentin Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro

  1   2   3   >