Re: [PATCH net-next 2/5] net: ethoc: Implement ethtool::nway_reset

2016-11-15 Thread Tobias Klauser
On 2016-11-15 at 20:19:46 +0100, Florian Fainelli wrote: > Implement ethtool::nway_reset using phy_ethtool_nway_reset. We are > already using dev->phydev all over the place so this comes for free. > > Signed-off-by: Florian Fainelli Reviewed-by: Tobias Klauser

[PATCH net] virtio-net: add a missing synchronize_net()

2016-11-15 Thread Eric Dumazet
From: Eric Dumazet It seems many drivers do not respect napi_hash_del() contract. When napi_hash_del() is used before netif_napi_del(), an RCU grace period is needed before freeing NAPI object. Fixes: 91815639d880 ("virtio-net: rx busy polling support") Signed-off-by: Eric Dumazet Cc: Jason Wa

Re: [PATCH] igmp: Make igmp group member RFC 3376 compliant

2016-11-15 Thread Hangbin Liu
Hi David, On Tue, Nov 08, 2016 at 10:26:25AM +0100, Michal Tesar wrote: > On Mon, Nov 07, 2016 at 08:13:45PM -0500, David Miller wrote: > > > From: Michal Tesar > > Date: Thu, 3 Nov 2016 10:38:34 +0100 > > > > > 2. If the received Query is a General Query, the interface timer is > > > used

Re: [RFC PATCH 2/2] ptr_ring_ll: pop/push multiple objects at once

2016-11-15 Thread Michael S. Tsirkin
On Tue, Nov 15, 2016 at 08:42:03PM -0800, John Fastabend wrote: > On 16-11-14 03:06 PM, Michael S. Tsirkin wrote: > > On Thu, Nov 10, 2016 at 08:44:32PM -0800, John Fastabend wrote: > >> Signed-off-by: John Fastabend > > > > This will naturally reduce the cache line bounce > > costs, but so will

Re: [RFC PATCH 2/2] ptr_ring_ll: pop/push multiple objects at once

2016-11-15 Thread John Fastabend
On 16-11-14 03:06 PM, Michael S. Tsirkin wrote: > On Thu, Nov 10, 2016 at 08:44:32PM -0800, John Fastabend wrote: >> Signed-off-by: John Fastabend > > This will naturally reduce the cache line bounce > costs, but so will a _many API for ptr-ring, > doing lock-add many-unlock. > > the number of a

Re: [RFC PATCH 1/2] net: use cmpxchg instead of spinlock in ptr rings

2016-11-15 Thread John Fastabend
On 16-11-15 05:32 AM, Jesper Dangaard Brouer wrote: > > (looks like my message didn't reach the netdev list, due to me sending > from the wrong email, forwarded message again): > > On Thu, 10 Nov 2016 20:44:08 -0800 John Fastabend > wrote: > >> --- >> include/linux/ptr_ring_ll.h | 136 >> ++

Re: [RFC PATCH 1/2] net: use cmpxchg instead of spinlock in ptr rings

2016-11-15 Thread John Fastabend
On 16-11-14 03:01 PM, Michael S. Tsirkin wrote: > On Thu, Nov 10, 2016 at 08:44:08PM -0800, John Fastabend wrote: >> >> --- >> include/linux/ptr_ring_ll.h | 136 >> +++ >> include/linux/skb_array.h | 25 >> 2 files changed, 161 insertions(+) >

RE: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

2016-11-15 Thread YUAN Linyu
No, this patch will not change dev->name, It's care about ifa->ifa_label. > - if (colon) > - memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ); > - else > - memcpy(ifa->ifa_label, dev->name, IFNAMSIZ); When

Re: [PATCH net-next V2 0/9] alx: add multi queue support

2016-11-15 Thread David Miller
From: Tobias Regnery Date: Tue, 15 Nov 2016 12:43:07 +0100 > This patchset lays the groundwork for multi queue support in the alx driver > and enables multi queue support for the tx path by default. The hardware > supports up to 4 tx queues. Series applied, thanks.

Re: [PATCH net-next v3 0/5] Adding PHY-Tunables and downshift support

2016-11-15 Thread David Miller
From: "Allan W. Nielsen" Date: Tue, 15 Nov 2016 11:19:59 +0100 > Old cover letters included below. Please do not form your cover letter by quoting older and older cover letters. Always write a clean, single, cover letter with a changelog of changed between each and every version leading up to t

Re: [PATCH net] rtnetlink: fix rtnl message size computation for XDP

2016-11-15 Thread David Miller
From: Sabrina Dubroca Date: Tue, 15 Nov 2016 11:16:35 +0100 > rtnl_xdp_size() only considers the size of the actual payload attribute, > and misses the space taken by the attribute used for nesting (IFLA_XDP). > > Fixes: d1fdd9138682 ("rtnl: add option for setting link xdp prog") > Signed-off-by

Re: [PATCH net] rtnetlink: fix rtnl_vfinfo_size

2016-11-15 Thread David Miller
From: Sabrina Dubroca Date: Tue, 15 Nov 2016 10:39:03 +0100 > The size reported by rtnl_vfinfo_size doesn't match the space used by > rtnl_fill_vfinfo. > > rtnl_vfinfo_size currently doesn't account for the nest attributes > used by statistics (added in commit 3b766cd83232), nor for struct > ifl

Re: [PATCH net-next 2/2] net: marvell: Allow drivers to be built with COMPILE_TEST

2016-11-15 Thread kbuild test robot
Hi Florian, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-ethernet-Allow-Marvell-Freescale-to-COMPILE_TEST/20161116-024633 config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.

Re: [PATCH net-next v8 0/9] dpaa_eth: Add the QorIQ DPAA Ethernet driver

2016-11-15 Thread David Miller
From: Madalin Bucur Date: Tue, 15 Nov 2016 10:41:00 +0200 > This patch series adds the Ethernet driver for the Freescale > QorIQ Data Path Acceleration Architecture (DPAA). Series applied, thanks.

[PATCH iproute2] ifstat/nstat: fix help output alignment

2016-11-15 Thread Mike Frysinger
Some lines use tabs while others use spaces. Use spaces everywhere. Signed-off-by: Mike Frysinger --- misc/ifstat.c | 24 misc/nstat.c | 22 +++--- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/misc/ifstat.c b/misc/ifstat.c index d551

Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

2016-11-15 Thread David Miller
From: YUAN Linyu Date: Wed, 16 Nov 2016 03:13:31 + > So assign label to request name will do same thing as original code. Nope. dev->name does not have the colon, it was trimmed from the string for the device lookup. So the found device's dev->name does not have the colon character, even i

Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

2016-11-15 Thread David Miller
From: YUAN Linyu Date: Wed, 16 Nov 2016 03:13:31 + > orginal code means when reqest name have colon, then label name will have > colon. And that is intentional.

Re: [PATCH net-next] tcp: allow to enable the repair mode for non-listening sockets

2016-11-15 Thread David Miller
From: Andrei Vagin Date: Mon, 14 Nov 2016 18:15:14 -0800 > The repair mode is used to get and restore sequence numbers and > data from queues. It used to checkpoint/restore connections. > > Currently the repair mode can be enabled for sockets in the established > and closed states, but for other

Re: [PATCH net] gro_cells: mark napi struct as not busy poll candidates

2016-11-15 Thread David Miller
From: Eric Dumazet Date: Mon, 14 Nov 2016 16:28:42 -0800 > From: Eric Dumazet > > Rolf Neugebauer reported very long delays at netns dismantle. > > Eric W. Biederman was kind enough to look at this problem > and noticed synchronize_net() occurring from netif_napi_del() that was > added in linu

[PATCH] net: dsa: mv88e6xxx: Respect SPEED_UNFORCED, don't set force bit

2016-11-15 Thread Andrew Lunn
The SPEED_UNFORCED indicates the MAC & PHY should perform auto-negotiation to determine a speed which works. If this is called for, don't set the force bit. If it is set, the MAC actually does 10Gbps, why the internal PHYs don't support. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/p

Re: [PATCH net-next V6 0/9] liquidio CN23XX VF support

2016-11-15 Thread David Miller
From: Raghu Vatsavayi Date: Mon, 14 Nov 2016 15:54:38 -0800 > Following is the V6 patch series for adding VF support on > CN23XX devices. This version addressed: > 1) Your concern for ordering of local variable declarations >from longest to shortest line. > 2) Removed module parameters max_vf

Re: [PATCH net-next v3 2/3] net: fsl: Allow most drivers to be built with COMPILE_TEST

2016-11-15 Thread kbuild test robot
Hi Florian, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-gianfar_ptp-Rename-FS-bit-to-FIPERST/20161116-095805 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:

Re: [PATCH] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-15 Thread David Miller
From: Alex Date: Mon, 14 Nov 2016 13:54:57 -0800 > > > On 11/14/2016 01:25 PM, Florian Fainelli wrote: >> On 11/14/2016 01:18 PM, David Miller wrote: >>> From: Alexandru Gagniuc >>> Date: Sat, 12 Nov 2016 15:32:13 -0800 >>> + if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) +

Re: [PATCH net] udp: restore UDPlite many-cast delivery

2016-11-15 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 14 Nov 2016 23:40:30 +0100 > Honor udptable parameter that is passed to __udp*_lib_mcast_deliver(), > otherwise udplite broadcast/multicast use the wrong table and it breaks. > > Fixes: 2dc41cff7545 ("udp: Use hash2 for long hash1 chains in > __udp*_lib_mcast_

Re: [PATCH 0/2] amd-xgbe: AMD XGBE driver updates 2016-11-14

2016-11-15 Thread David Miller
From: Tom Lendacky Date: Mon, 14 Nov 2016 16:28:27 -0600 > This patch series addresses some minor issues found in the recently > accepted patch series for the AMD XGBE driver. > > The following fixes are included in this driver update series: > > - Fix how a mask is applied to a Clause 37 regis

RE: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

2016-11-15 Thread YUAN Linyu
hi david, > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of David Miller > Sent: Wednesday, November 16, 2016 11:01 AM > To: cug...@163.com > Cc: netdev@vger.kernel.org; YUAN Linyu > Subject: Re: [PATCH] net: ioctl SIOCSIFADDR mi

Re: [PATCH 0/3 v5] Fixes for running a big-endian kernel on Cubieboard2

2016-11-15 Thread David Miller
From: Michael Weiser Date: Mon, 14 Nov 2016 18:58:04 +0100 > the following patches are what remains to be fixed in order to allow running a > big-endian kernel on the Cubieboard2. Series applied to net-next, thanks.

Re: [PATCH next] dctcp: update cwnd on congestion event

2016-11-15 Thread David Miller
From: Florian Westphal Date: Mon, 14 Nov 2016 16:42:01 +0100 > draft-ietf-tcpm-dctcp-02 says: > > ... when the sender receives an indication of congestion > (ECE), the sender SHOULD update cwnd as follows: > > cwnd = cwnd * (1 - DCTCP.Alpha / 2) > > So, lets do this and reduce cwnd mo

Re: [PATCH] net: ioctl SIOCSIFADDR minor cleanup

2016-11-15 Thread David Miller
From: yuan linyu Date: Tue, 15 Nov 2016 20:44:59 +0800 > @@ -1063,10 +1063,7 @@ int devinet_ioctl(struct net *net, unsigned int cmd, > void __user *arg) > if (!ifa) > break; > INIT_HLIST_NODE(&ifa->hash); > -

Re: [PATCH net-next] net: bcm63xx_enet: Fix build failure with phy_ethtool_nway_reset

2016-11-15 Thread David Miller
From: Florian Fainelli Date: Tue, 15 Nov 2016 18:21:09 -0800 > Introduced a typo making the driver no longer build, *sigh*. > > Fixes: 42469bf5d9bb ("net: bcm63xx_enet: Utilize phy_ethtool_nway_reset") > Signed-off-by: Florian Fainelli Applied.

[PATCH net-next] net: bcm63xx_enet: Fix build failure with phy_ethtool_nway_reset

2016-11-15 Thread Florian Fainelli
Introduced a typo making the driver no longer build, *sigh*. Fixes: 42469bf5d9bb ("net: bcm63xx_enet: Utilize phy_ethtool_nway_reset") Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/

Re: [PATCH] icmp: Restore resistence to abnormal messages

2016-11-15 Thread Florian Westphal
Vicente Jiménez wrote: > I agree that both patches try to solve the same problem in a very similar way. > Florian Westphal's patch do two more things: > 1- add warning with pr_warn_ratelimited. I like this idea. I also > though about adding some message but I have no kernel experience and I > pref

[PATCH resend] ethtool: add register dump support for fjes driver

2016-11-15 Thread Taku Izumi
This patch adds the register dump format for FUJITSU Extended Network device like the following: # ethtool -d es0 0x: OWNER_EPID(Owner EPID) 0x0001 0x0004: MAX_EP(Maximum EP) 0x0008 0x0010: DCTL (Device Control)

Re: [PATCH] r8169: Module parameter for opt-in of ASPM

2016-11-15 Thread Kast Bernd
On Sat, Nov 12, 2016 at 09:02:24PM -0500, David Miller wrote: > From: Kast Bernd > Date: Fri, 4 Nov 2016 00:33:06 +0100 > > > This patch adds a module parameter in order to activate ASPM. By that > > the CPU can enter deep sleep modes (PC6) and power consumption can be > > reduced (for example fr

[PATCH net-next 5/6] net: dsa: mv88e6xxx: Fix cleanup on error for g1 interrupt setup

2016-11-15 Thread Andrew Lunn
On error, remask the interrupts, release all maps, and remove the domain. This cannot be done using the mv88e6xxx_g1_irq_free() because some of these actions are not idempotent. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 31 --- 1 file changed,

[PATCH net-next 4/6] net: dsa: mv88e6xxx: Fix releasing for the global2 interrupts

2016-11-15 Thread Andrew Lunn
It is not possible to use devm_request_threaded_irq() because we have two stacked interrupt controllers in one device. The lower interrupt controller cannot be removed until the upper is fully removed. This happens too late with the devm API, resulting in error messages about removing a domain whil

[PATCH net-next 6/6] net: dsa: mv88e6xxx: Hold the mutex while freeing g1 interrupts

2016-11-15 Thread Andrew Lunn
Freeing interrupts requires switch register access to mask the interrupts. Hence we must hold the register mutex. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net

[PATCH net-next 3/6] net: dsa: mv88e6xxx: Mask g1 interrupts and free interrupt

2016-11-15 Thread Andrew Lunn
Fix the g1 interrupt free code such that is masks any further interrupts, and then releases the interrupt. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.

Re: [PATCHv2 (net.git) 0/3] stmmac: fix PTP support

2016-11-15 Thread David Miller
From: Giuseppe Cavallaro Date: Mon, 14 Nov 2016 09:27:27 +0100 > This subset of patches aim to fix the PTP support > for the stmmac and especially for 4.x chip series. > While setting PTP on an ST box with 4.00a Ethernet > core, the kernel panics due to a broken settings > of the descriptors. The

[PATCH net-next 1/6] net: dsa: mv88e6xxx: Fix typos when removing g1 interrupts

2016-11-15 Thread Andrew Lunn
Simple typos, s/g2/g1/ Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index d6d9d66b81ce..6aa81d2d8f63 100644 --- a/drivers/net/dsa/mv88e6x

[PATCH net-next 0/6] Fixes for the MV88e6xxx interrupt code

2016-11-15 Thread Andrew Lunn
The interrupt code was never tested with a board who's probing resulted in an -EPROBE_DEFFERED. So the clean up paths never got tested. I now do have -EPROBE_DEFFERED, and things break badly during cleanup. These are the fixes. This is fixing code in net-next. Andrew Lunn (6): net: dsa: mv88e6x

[PATCH net-next 2/6] net: dsa: mv88e6xxx: Fix unconditional irq freeing

2016-11-15 Thread Andrew Lunn
Trying to remove an IRQ domain that was not created results in an Opps. Add the necessary checks that the irqs were created before freeing them. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drive

Re: linux-next: build warning after merge of the net-next tree

2016-11-15 Thread Martin KaFai Lau
On Wed, Nov 16, 2016 at 11:36:47AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > kernel/bpf/bpf_lru_list.c: In function > '__bpf_lru_list_rotate_inactive.isra.3': > kernel/bpf/bpf_lru_list.c

Re: [PATCHv3 net] igmp: do not remove igmp souce list info when set link down

2016-11-15 Thread David Miller
From: Hangbin Liu Date: Mon, 14 Nov 2016 16:16:28 +0800 > In commit 24cf3af3fed5 ("igmp: call ip_mc_clear_src..."), we forgot to remove > igmpv3_clear_delrec() in ip_mc_down(), which also called ip_mc_clear_src(). > This make us clear all IGMPv3 source filter info after NETDEV_DOWN. > Move igmpv3

Re: [PATCH v4 6/6] posix-timers: make it configurable

2016-11-15 Thread John Stultz
On Thu, Nov 10, 2016 at 9:10 PM, Nicolas Pitre wrote: > Some embedded systems have no use for them. This removes about > 25KB from the kernel binary size when configured out. > > Corresponding syscalls are routed to a stub logging the attempt to > use those syscalls which should be enough of a cl

[PATCH net-next] debugfs: improve formatting of debugfs_real_fops()

2016-11-15 Thread Jakub Kicinski
Type of debugfs_real_fops() is longer than parameters and the name, so there is no way to break the declaration nicely. We have to go over 80 characters. Signed-off-by: Jakub Kicinski Acked-by: Greg Kroah-Hartman --- Sorry, I forgot to include the target tree in the tag, resending. This is fixup

Re: [PATCH net] ipv6 addrconf: Implemented enhanced DAD (RFC7527)

2016-11-15 Thread Erik Nordmark
On 11/16/16 1:00 AM, Hannes Frederic Sowa wrote: On 15.11.2016 08:57, Erik Nordmark wrote: Implemented RFC7527 Enhanced DAD. IPv6 duplicate address detection can fail if there is some temporary loopback of Ethernet frames. RFC7527 solves this by including a random nonce in the NS messages used f

[PATCH net-next v2 2/3] net: gianfar_ptp: Rename FS bit to FIPERST

2016-11-15 Thread Florian Fainelli
FS is a global symbol used by the x86 32-bit architecture, fixes builds re-definitions: >> drivers/net/ethernet/freescale/gianfar_ptp.c:75:0: warning: "FS" >> redefined #define FS(1<<28) /* FIPER start indication */ In file included from arch/x86/include/uapi/asm/ptrace

[PATCH net-next v3 3/3] net: marvell: Allow drivers to be built with COMPILE_TEST

2016-11-15 Thread Florian Fainelli
All Marvell Ethernet drivers actually build fine with COMPILE_TEST with a few warnings. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/marvell/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/etherne

[PATCH net-next v3 2/3] net: fsl: Allow most drivers to be built with COMPILE_TEST

2016-11-15 Thread Florian Fainelli
There are only a handful of Freescale Ethernet drivers that don't actually build with COMPILE_TEST: * FEC, for which we would need to define a default register layout if no supported architecture is defined * UCC_GETH which depends on PowerPC cpm.h header (which could be moved to a generic lo

[PATCH net-next v3 1/3] net: gianfar_ptp: Rename FS bit to FIPERST

2016-11-15 Thread Florian Fainelli
FS is a global symbol used by the x86 32-bit architecture, fixes builds re-definitions: >> drivers/net/ethernet/freescale/gianfar_ptp.c:75:0: warning: "FS" >> redefined #define FS(1<<28) /* FIPER start indication */ In file included from arch/x86/include/uapi/asm/ptrace

[PATCH net-next v2 1/3] net: fsl: Allow most drivers to be built with COMPILE_TEST

2016-11-15 Thread Florian Fainelli
There are only a handful of Freescale Ethernet drivers that don't actually build with COMPILE_TEST: * FEC, for which we would need to define a default register layout if no supported architecture is defined * UCC_GETH which depends on PowerPC cpm.h header (which could be moved to a generic lo

[PATCH net-next v3 0/3] net: ethernet: Allow Marvell & Freescale to COMPILE_TEST

2016-11-15 Thread Florian Fainelli
Hi David, This patch series allows most of the Freescale Ethernet drivers to be built with COMPILE_TEST and all Marvell drivers to build with COMPILE_TEST. This is helpful to increase build coverage without requiring hacking into Kconfig anymore. Changes in v3: - reorder patches to avoid introd

Re: [PATCH net-next v2 0/3] net: ethernet: Allow Marvell & Freescale to COMPILE_TEST

2016-11-15 Thread Florian Fainelli
On 11/15/2016 04:35 PM, Florian Fainelli wrote: > Hi David, > > This patch series allows most of the Freescale Ethernet drivers to be built > with COMPILE_TEST and all Marvell drivers to build with COMPILE_TEST. > > This is helpful to increase build coverage without requiring hacking into > Kconf

linux-next: build warning after merge of the net-next tree

2016-11-15 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) produced this warning: kernel/bpf/bpf_lru_list.c: In function '__bpf_lru_list_rotate_inactive.isra.3': kernel/bpf/bpf_lru_list.c:201:28: warning: 'next' may be used uninitialized in this function [-Wmaybe-uni

[PATCH net-next v2 3/3] net: marvell: Allow drivers to be built with COMPILE_TEST

2016-11-15 Thread Florian Fainelli
All Marvell Ethernet drivers actually build fine with COMPILE_TEST with a few warnings. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/marvell/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/etherne

[PATCH net-next v2 0/3] net: ethernet: Allow Marvell & Freescale to COMPILE_TEST

2016-11-15 Thread Florian Fainelli
Hi David, This patch series allows most of the Freescale Ethernet drivers to be built with COMPILE_TEST and all Marvell drivers to build with COMPILE_TEST. This is helpful to increase build coverage without requiring hacking into Kconfig anymore. Changes in v2: - rename register define clash wh

[PATCH net-next v2 2/3] net: gianfar_ptp: Rename FS bit to FIPERST

2016-11-15 Thread Florian Fainelli
FS is a global symbol used by the x86 32-bit architecture, fixes builds re-definitions: >> drivers/net/ethernet/freescale/gianfar_ptp.c:75:0: warning: "FS" >> redefined #define FS(1<<28) /* FIPER start indication */ In file included from arch/x86/include/uapi/asm/ptrace

[PATCH net-next v2 1/3] net: fsl: Allow most drivers to be built with COMPILE_TEST

2016-11-15 Thread Florian Fainelli
There are only a handful of Freescale Ethernet drivers that don't actually build with COMPILE_TEST: * FEC, for which we would need to define a default register layout if no supported architecture is defined * UCC_GETH which depends on PowerPC cpm.h header (which could be moved to a generic lo

Re: [PATCH net-next 1/2] net: fsl: Allow most drivers to be built with COMPILE_TEST

2016-11-15 Thread Florian Fainelli
On 11/15/2016 04:24 PM, kbuild test robot wrote: > Hi Florian, > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-ethernet-Allow-Marvell-Freescale-to-COMPILE_TEST/20161116-024633 > config: i386-allmodconfig (attached as .c

Re: [PATCH net-next 1/2] net: fsl: Allow most drivers to be built with COMPILE_TEST

2016-11-15 Thread kbuild test robot
Hi Florian, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-ethernet-Allow-Marvell-Freescale-to-COMPILE_TEST/20161116-024633 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduc

CPU port VLAN configuration [Was: Re: [PATCH net] net: dsa: b53: Fix VLAN usage and how we treat CPU port]

2016-11-15 Thread Florian Fainelli
Hi Andrew, Vivien, On 11/15/2016 03:58 PM, Florian Fainelli wrote: > We currently have a fundamental problem in how we treat the CPU port and > its VLAN membership. As soon as a second VLAN is configured to be > untagged, the CPU automatically becomes untagged for that VLAN as well, > and yet, we

[PATCH net-next v2 4/4] bpf: add __must_check attributes to refcount manipulating helpers

2016-11-15 Thread Daniel Borkmann
Helpers like bpf_prog_add(), bpf_prog_inc(), bpf_map_inc() can fail with an error, so make sure the caller properly checks their return value and not just ignores it (which could worst-case lead to use after free). Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- include/linux/bp

[PATCH net-next v2 1/4] bpf, mlx5: fix mlx5e_create_rq taking reference on prog

2016-11-15 Thread Daniel Borkmann
In mlx5e_create_rq(), when creating a new queue, we call bpf_prog_add() but without checking the return value. bpf_prog_add() can fail since 92117d8443bc ("bpf: fix refcnt overflow"), so we really must check it. Take the reference right when we assign it to the rq from priv->xdp_prog, and just drop

[PATCH net-next v2 0/4] Couple of BPF refcount fixes for mlx5

2016-11-15 Thread Daniel Borkmann
Various mlx5 bugs on eBPF refcount handling found during review. Last patch in series adds a __must_check to BPF helpers to make sure we won't run into it again w/o compiler complaining first. v1 -> v2: - After discussion with Alexei, we agreed upon rebasing the patches against net-next. - S

[PATCH net-next v2 3/4] bpf, mlx5: drop priv->xdp_prog reference on netdev cleanup

2016-11-15 Thread Daniel Borkmann
mlx5e_xdp_set() is currently the only place where we drop reference on the prog sitting in priv->xdp_prog when it's exchanged by a new one. We also need to make sure that we eventually release that reference, for example, in case the netdev is dismantled. Fixes: 86994156c736 ("net/mlx5e: XDP fast

[PATCH net-next v2 2/4] bpf, mlx5: fix various refcount issues in mlx5e_xdp_set

2016-11-15 Thread Daniel Borkmann
There are multiple issues in mlx5e_xdp_set(): 1) The batched bpf_prog_add() is currently not checked for errors! When doing so, it should be done at an earlier point in time to makes sure that we cannot fail anymore at the time we want to set the program for each channel. This only means

[PATCH net] net: dsa: b53: Fix VLAN usage and how we treat CPU port

2016-11-15 Thread Florian Fainelli
We currently have a fundamental problem in how we treat the CPU port and its VLAN membership. As soon as a second VLAN is configured to be untagged, the CPU automatically becomes untagged for that VLAN as well, and yet, we don't gracefully make sure that the CPU becomes tagged in the other VLANs it

Re: [PATCH] lan78xx: relocate mdix setting to phy driver

2016-11-15 Thread Florian Fainelli
On 11/15/2016 01:57 PM, woojung@microchip.com wrote: > From: Woojung Huh > > Relocate mdix code to phy driver to be called at config_init(). > > Signed-off-by: Woojung Huh > --- > drivers/net/phy/microchip.c | 43 +- > drivers/net/usb/lan78xx.c | 73 > ++-

RE: [ovs-dev] [PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

2016-11-15 Thread Yang, Yi Y
Got it, thanks, I'll follow your discussion thread. -Original Message- From: Thadeu Lima de Souza Cascardo [mailto:casca...@cascardo.eti.br] Sent: Wednesday, November 16, 2016 3:01 AM To: Yang, Yi Y ; Jiri Benc ; netdev@vger.kernel.org Cc: d...@openvswitch.org; Simon Horman ; egar...@re

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 16.11.2016 00:03, Andrew Lunn wrote: >> > + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG | >> > + SLIC_PCR_AUTONEG_RST; >> > + slic_write(sdev, SLIC_REG_WPHY, val); > >> Thats essentially what I meant by setting a fl

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Andrew Lunn
> > + val = MII_BMCR << 16 | SLIC_PCR_AUTONEG | > > +SLIC_PCR_AUTONEG_RST; > > + slic_write(sdev, SLIC_REG_WPHY, val); > Thats essentially what I meant by setting a flag in the irq handler. The mdio > function

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 15.11.2016 23:39, Florian Fainelli wrote: > On 11/15/2016 02:34 PM, Lino Sanfilippo wrote: >> On 15.11.2016 22:59, Andrew Lunn wrote: The link state is retrieved by a command to the application processor that is running on the network card. Also the register to set the phy confi

Re: linux-next: net->netns_ids is used after calling idr_destroy for it

2016-11-15 Thread Andrei Vagin
On Tue, Nov 15, 2016 at 2:21 PM, Andrei Vagin wrote: > On Tue, Nov 15, 2016 at 1:07 PM, Cong Wang wrote: >> On Tue, Nov 15, 2016 at 12:48 PM, Andrei Vagin wrote: >>> On Tue, Nov 15, 2016 at 10:50 AM, Cong Wang >>> wrote: On Tue, Nov 15, 2016 at 10:04 AM, Cong Wang wrote: > On M

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Florian Fainelli
On 11/15/2016 02:34 PM, Lino Sanfilippo wrote: > On 15.11.2016 22:59, Andrew Lunn wrote: >>> The link state is retrieved by a command to the application processor that >>> is running >>> on the network card. Also the register to set the phy configuration is >>> write-only, so >>> it is not even

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
On 15.11.2016 22:59, Andrew Lunn wrote: >> The link state is retrieved by a command to the application processor that >> is running >> on the network card. Also the register to set the phy configuration is >> write-only, so >> it is not even possible to do the usual mdio bit-banging in the Phy r

Re: linux-next: net->netns_ids is used after calling idr_destroy for it

2016-11-15 Thread Andrei Vagin
On Tue, Nov 15, 2016 at 1:07 PM, Cong Wang wrote: > On Tue, Nov 15, 2016 at 12:48 PM, Andrei Vagin wrote: >> On Tue, Nov 15, 2016 at 10:50 AM, Cong Wang wrote: >>> On Tue, Nov 15, 2016 at 10:04 AM, Cong Wang >>> wrote: On Mon, Nov 14, 2016 at 10:23 PM, Andrei Vagin wrote: > Hi Nicola

[PATCH net-next 0/2] amd-xgbe: AMD XGBE driver updates 2016-11-15

2016-11-15 Thread Tom Lendacky
This patch series addresses some minor issues found in the recently accepted patch series for the AMD XGBE driver. The following fixes are included in this driver update series: - Fix a possibly uninitialized variable in the debugfs support - Fix the GPIO pin number constraint check This patch s

[PATCH net-next 2/2] amd-xgbe: Fix maximum GPIO value check

2016-11-15 Thread Tom Lendacky
The GPIO support in the hardware allows for up to 16 GPIO pins, enumerated from 0 to 15. The driver uses the wrong value (16) to validate the GPIO pin range in the routines to set and clear the GPIO output pins. Update the code to use the correct value (15). Reported-by: Colin Ian King Signed-o

[PATCH net-next 1/2] amd-xgbe: Fix possible uninitialized variable

2016-11-15 Thread Tom Lendacky
The debugfs support in the driver uses a common routine to write the debugfs values. In this routine, if the input file position is non-zero then the write routine will not return an error and an output parameter will not have been set. Because an error isn't returned an uninitialized value will be

Re: [PATCH] net: bnx2: use new api ethtool_{get|set}_link_ksettings

2016-11-15 Thread David Miller
From: Philippe Reynes Date: Sun, 13 Nov 2016 23:33:46 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Andrew Lunn
> The link state is retrieved by a command to the application processor that is > running > on the network card. Also the register to set the phy configuration is > write-only, so > it is not even possible to do the usual mdio bit-banging in the Phy read() > and write() > functions (however the

[PATCH] lan78xx: relocate mdix setting to phy driver

2016-11-15 Thread Woojung.Huh
From: Woojung Huh Relocate mdix code to phy driver to be called at config_init(). Signed-off-by: Woojung Huh --- drivers/net/phy/microchip.c | 43 +- drivers/net/usb/lan78xx.c | 73 ++--- 2 files changed, 45 insertions(+), 71 de

Re: [Intel-wired-lan] [PATCH v2] e1000e: free IRQ regardless of __E1000_DOWN

2016-11-15 Thread Baicar, Tyler
On 11/13/2016 2:25 AM, Neftin, Sasha wrote: On 11/13/2016 10:34 AM, Neftin, Sasha wrote: On 11/11/2016 12:35 AM, Baicar, Tyler wrote: Hello Sasha, On 11/9/2016 11:19 PM, Neftin, Sasha wrote: On 11/9/2016 11:41 PM, Tyler Baicar wrote: Move IRQ free code so that it will happen regardless of th

Re: [PATCH net-next] bpf: Fix compilation warning in __bpf_lru_list_rotate_inactive

2016-11-15 Thread Alexei Starovoitov
On Tue, Nov 15, 2016 at 11:00:04AM -0800, Martin KaFai Lau wrote: > gcc-6.2.1 gives the following warning: > kernel/bpf/bpf_lru_list.c: In function > ‘__bpf_lru_list_rotate_inactive.isra.3’: > kernel/bpf/bpf_lru_list.c:201:28: warning: ‘next’ may be used uninitialized > in this function [-Wmaybe-

Re: [PATCH 00/15] net: phy: Centralize auto-negotation restart

2016-11-15 Thread David Miller
From: Florian Fainelli Date: Tue, 15 Nov 2016 10:06:29 -0800 > This patch series centralizes how ethtool::nway_reset is implemented > by providing a PHYLIB function which calls into genphy_restart_aneg(). > > All drivers below are converted to use this new helper function. Some > other have spec

[PATCH net-next 0/8] Mellanox 100G mlx5 update 2016-11-15

2016-11-15 Thread Saeed Mahameed
Hi Dave, This series contains four humble mlx5 features. from Gal, - Add the support for PCIe statistics and expose them in ethtool from Huy, - Add the support for port module events reporting and statistics - Add the support for driver version setting into FW (for display purposes only) >

[PATCH net-next 8/8] net/mlx5e: Expose PCIe statistics to ethtool

2016-11-15 Thread Saeed Mahameed
From: Gal Pressman This patch exposes two groups of PCIe counters: - Performance counters. - Timers and states counters. Queried with ethtool -S . Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 17 drivers/net/et

[PATCH net-next 1/8] net/mlx5: Make the command interface cache more flexible

2016-11-15 Thread Saeed Mahameed
From: Mohamad Haj Yahia Add more cache command size sets and more entries for each set based on the current commands set different sizes and commands frequency. Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB adapters') Signed-off-by: Mohamad Haj Yahia Signed-off-by: Saeed Mahame

[PATCH net-next 2/8] net/mlx5: Port module event hardware structures

2016-11-15 Thread Saeed Mahameed
From: Huy Nguyen Add hardware structures and constants definitions needed for module events support. Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed Signed-off-by: Leon Romanovsky --- include/linux/mlx5/device.h | 11 +++ include/linux/mlx5/mlx5_ifc.h | 3 ++- include/linu

[PATCH net-next 7/8] net/mlx5: Add MPCNT register infrastructure

2016-11-15 Thread Saeed Mahameed
From: Gal Pressman Add the needed infrastructure for future use of MPCNT register. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- include/linux/mlx5/device.h | 5 +++ include/linux/mlx5/driver.h | 1 + include/linux/mlx5/mlx5_ifc.h | 93 +++

[PATCH net-next 6/8] net/mlx5: Set driver version into firmware

2016-11-15 Thread Saeed Mahameed
From: Huy Nguyen If driver_version capability bit is enabled, set driver version to firmware after the init HCA command, for display purposes. Example of driver version: "Linux,mlx5_core,3.0-1" Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/cor

[PATCH net-next 3/8] net/mlx5: Add handling for port module event

2016-11-15 Thread Saeed Mahameed
From: Huy Nguyen For each asynchronous port module event: 1. print with ratelimit to the dmesg log 2. increment the corresponding event counter Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 12 + .../net/ethernet/mella

[PATCH net-next 5/8] net/mlx5: Set driver version infrastructure

2016-11-15 Thread Saeed Mahameed
Add driver_version capability bit is enabled, and set driver version command in mlx5_ifc firmware header. The only purpose of this command is to store a driver version/OS string in FW to be reported and displayed in various management systems, such as IPMI/BMC. Signed-off-by: Saeed Mahameed Sign

[PATCH net-next 4/8] net/mlx5e: Add port module event counters to ethtool stats

2016-11-15 Thread Saeed Mahameed
From: Huy Nguyen Add port module event counters to ethtool -S command Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 23 +- drivers/net/ethernet/mellanox/mlx5/core/en_stats.h | 17 2 files c

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-15 Thread Lino Sanfilippo
Hi, On 15.11.2016 21:54, Florian Fainelli wrote: > On 11/15/2016 12:46 PM, Lino Sanfilippo wrote: >>> Could this be pulled out into a standard PHY driver? All the SLIC >>> SLIC_PCR_ defines seems to be the same as those in mii.h. This could >>> be a standard PHY hidden behind a single register. >>

RE: [PATCH 13/15] net: ethernet: lantiq_etop: Utilize phy_ethtool_nway_reset

2016-11-15 Thread Langer, Thomas
> Subject: [PATCH 13/15] net: ethernet: lantiq_etop: Utilize > phy_ethtool_nway_reset > > Signed-off-by: Florian Fainelli > --- > drivers/net/ethernet/lantiq_etop.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > Reviewed-by: Thomas Langer

Re: [net PATCH 1/2] ipv4: Restore fib_trie_flush_external function and fix call ordering

2016-11-15 Thread Duyck, Alexander H
On Tue, 2016-11-15 at 22:07 +0100, Jiri Pirko wrote: > Tue, Nov 15, 2016 at 10:01:03PM CET, alexander.h.du...@intel.com wrote: > > > > On Tue, 2016-11-15 at 21:52 +0100, Jiri Pirko wrote: > > > > > > Tue, Nov 15, 2016 at 09:49:02PM CET, alexander.h.du...@intel.com wrote: > > > > > > > > > > > >

Re: [net PATCH 1/2] ipv4: Restore fib_trie_flush_external function and fix call ordering

2016-11-15 Thread Jiri Pirko
Tue, Nov 15, 2016 at 10:01:03PM CET, alexander.h.du...@intel.com wrote: >On Tue, 2016-11-15 at 21:52 +0100, Jiri Pirko wrote: >> Tue, Nov 15, 2016 at 09:49:02PM CET, alexander.h.du...@intel.com wrote: >> > >> > On Tue, 2016-11-15 at 21:31 +0100, Jiri Pirko wrote: >> > > >> > > Tue, Nov 15, 2016 a

Re: linux-next: net->netns_ids is used after calling idr_destroy for it

2016-11-15 Thread Cong Wang
On Tue, Nov 15, 2016 at 12:48 PM, Andrei Vagin wrote: > On Tue, Nov 15, 2016 at 10:50 AM, Cong Wang wrote: >> On Tue, Nov 15, 2016 at 10:04 AM, Cong Wang wrote: >>> On Mon, Nov 14, 2016 at 10:23 PM, Andrei Vagin wrote: Hi Nicolas, cleanup_net() calls idr_destroy(net->netns_ids) f

  1   2   3   >