Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-11 Thread Nikita Yushchenko
>>> The main reason why this isn't a concern for the igb driver is because >>> we currently pass the page up as read-only. We don't allow the stack >>> to write into the page by keeping the page count greater than 1 which >>> means that the page is shared. It isn't until we unmap the page that >>

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-11 Thread Luca Coelho
Hi Chris, On Tue, 2016-10-11 at 09:09 -0500, Chris Rorvick wrote: > On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle wrote: > > > This is not coming from the NIC itself, but from the platform's ACPI > > > tables. Can you tell us which platform you are using? > > > Interesting. I'm running a Dell XP

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

2016-10-11 Thread Cyrill Gorcunov
On Wed, Oct 12, 2016 at 01:50:22AM -0400, David Miller wrote: > > Macros that look like function calls and are also lvalues tend to be > troublesome. > > I know what you're trying to achieve, you want a named way to access > this so that the intent and semantics are clear. > > But I'd rather you

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-11 Thread Paul Bolle
Luca, On Wed, 2016-10-12 at 09:11 +0300, Luca Coelho wrote: > By "platform" I meant the PC you are using.  The ACPI table is created > by the OEM, so different PCs have different tables. Like Chris I use a Dell XPS 13 (9350), but mine came with an AC 8260 out of it's assembly plant:     Detected

[PATCH v3] Add support for ethtool operations and statistics to RDC-R6040.

2016-10-11 Thread VENKAT PRASHANTH B U
This is a patch to add support for ethtool operations and keeping up to date statistics for RDC R6040 fast ethernet MAC driver. Signed-off-by: Venkat Prashanth B U --- changelog v3: -Made the commit message more clear. -Modified the locking interface used in r6040_get_regs(). -Verified the tabs

[patch] netfilter: nft_exthdr: fix error handling in nft_exthdr_init()

2016-10-11 Thread Dan Carpenter
"err" needs to be signed for the error handling to work. Fixes: 36b701fae12a ('netfilter: nf_tables: validate maximum value of u32 netlink attributes') Signed-off-by: Dan Carpenter diff --git a/net/netfilter/nft_exthdr.c b/net/netfilter/nft_exthdr.c index a84cf3d..47beb3a 100644 --- a/net/netfi

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-11 Thread Luca Coelho
Hi Paul, On Tue, 2016-10-11 at 12:11 +0200, Paul Bolle wrote: > On Mon, 2016-10-10 at 17:02 +0300, Luca Coelho wrote: > > On Mon, 2016-10-10 at 02:19 -0500, Chris Rorvick wrote: > > This is not coming from the NIC itself, but from the platform's ACPI > > tables.  Can you tell us which platform you

[patch] netfilter: nf_tables: underflow in nft_parse_u32_check()

2016-10-11 Thread Dan Carpenter
We don't want to allow negatives here. Fixes: 36b701fae12a ('netfilter: nf_tables: validate maximum value of u32 netlink attributes') Signed-off-by: Dan Carpenter diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index b70d3ea..dd55187 100644 --- a/net/netfilter/nf_tabl

Re: HSO driver patch again [2/2]

2016-10-11 Thread David Miller
"HSO driver patch again ..." is not an appropriate Subject line when submitting patches. Please read Documentation/SubmittingPatches for how to do things properly, and in a way that will actually lead to your patches being applied. Thanks.

Re: [PATCH] strparser: Propagate correct error code in strp_recv()

2016-10-11 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 6 Oct 2016 15:41:49 +0200 > With m68k-linux-gnu-gcc-4.1: > > net/strparser/strparser.c: In function ‘strp_recv’: > net/strparser/strparser.c:98: warning: ‘err’ may be used uninitialized in > this function > > Pass "len" (which is an error code when

Re: [PATCH net 0/2] s390: af_iucv patches

2016-10-11 Thread David Miller
From: Ursula Braun Date: Fri, 7 Oct 2016 15:51:46 +0200 > here are 2 patches for the s390-only af_iucv socket family code. Series applied to net-next, thanks.

Re: [PATCH net-next 0/2] drivers: net: xgene: fix: Use GPIO to get link status

2016-10-11 Thread David Miller
From: Iyappan Subramanian Date: Thu, 6 Oct 2016 14:35:56 -0700 > Since the link value reported by the link status register is not > reliable if no SPF module inserted, this patchset fixes the issue by > using GPIO to determine the link status when no module inserted. > > Signed-off-by: Iyappan

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

2016-10-11 Thread David Miller
From: Cyrill Gorcunov Date: Thu, 6 Oct 2016 13:00:55 +0300 > v6: > - use sdiag_raw_protocol() helper which will access @pad >structure used for raw sockets protocol specification: >we can't simply rename this member without breaking uapi. Macros that look like function calls and are als

Re: [PATCH net-next v2] openvswitch: correctly fragment packet with mpls headers

2016-10-11 Thread David Miller
From: Jiri Benc Date: Wed, 5 Oct 2016 15:01:57 +0200 > If mpls headers were pushed to a defragmented packet, the refragmentation no > longer works correctly after 48d2ab609b6b ("net: mpls: Fixups for GSO"). The > network header has to be shifted after the mpls headers for the > fragmentation and

Re: [PATCH 1/2] net: mv643xx_eth: use phydev from struct net_device

2016-10-11 Thread David Miller
From: Philippe Reynes Date: Sun, 2 Oct 2016 12:06:48 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct

Re: [PATCH] net: dsa: slave: use new api ethtool_{get|set}_link_ksettings

2016-10-11 Thread David Miller
From: Philippe Reynes Date: Sun, 9 Oct 2016 17:00:53 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH] net: ti: netcp_ethss: use new api ethtool_{get|set}_link_ksettings

2016-10-11 Thread David Miller
From: Philippe Reynes Date: Sat, 8 Oct 2016 19:48:15 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH v2 1/2] net: stmmac: use phydev from struct net_device

2016-10-11 Thread David Miller
From: Philippe Reynes Date: Mon, 3 Oct 2016 08:28:19 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct

Re: [PATCH v2 2/2] net: stmmac: use new api ethtool_{get|set}_link_ksettings

2016-10-11 Thread David Miller
From: Philippe Reynes Date: Mon, 3 Oct 2016 08:28:20 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH] net: usb: lan78xx: use new api ethtool_{get|set}_link_ksettings

2016-10-11 Thread David Miller
From: Philippe Reynes Date: Sun, 9 Oct 2016 12:07:04 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH] net: ti: cpsw: use new api ethtool_{get|set}_link_ksettings

2016-10-11 Thread David Miller
From: Philippe Reynes Date: Sat, 8 Oct 2016 17:46:15 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 2/2] net: mv643xx_eth: use new api ethtool_{get|set}_link_ksettings

2016-10-11 Thread David Miller
From: Philippe Reynes Date: Sun, 2 Oct 2016 12:06:49 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-11 Thread Chris Rorvick
On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle wrote: > For what it's worth, on my machine I have twenty (!) SPLX entries, all > reading: > Name (SPLX, Package (0x04) > { > Zero, > Package (0x03) > { > 0x8000, > 0x8000, > 0x8

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-11 Thread Yuchung Cheng
On Tue, Oct 11, 2016 at 6:01 PM, Yuchung Cheng wrote: > On Tue, Oct 11, 2016 at 2:08 PM, Lawrence Brakmo wrote: >> Yuchung, thank you for your comments. Responses inline. >> >> On 10/11/16, 12:49 PM, "Yuchung Cheng" wrote: >> >>>On Mon, Oct 10, 2016 at 5:18 PM, Lawrence Brakmo wrote:

Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-11 Thread Zach Brown
On Tue, Oct 11, 2016 at 02:14:07PM -0700, Stephen Hemminger wrote: > On Tue, 11 Oct 2016 15:26:18 -0500 > Zach Brown wrote: > > > Adding led support for phy causes namespace conflicts for some > > phy drivers. > > > > The marvel skge driver declared an enum for representing the states of > > Link

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread Saeed Mahameed
On Wed, Oct 12, 2016 at 4:40 AM, Leon Romanovsky wrote: > On Tue, Oct 11, 2016 at 08:46:45AM -0700, Tom Herbert wrote: >> On Tue, Oct 11, 2016 at 4:57 AM, Saeed Mahameed >> wrote: >> > On Tue, Oct 11, 2016 at 7:50 PM, David Laight >> > wrote: >> >> From: Tom Herbert >> >>> Sent: 11 October 2016

[PATCH V2 net-next] net/mlx5: Add MLX5_ARRAY_SET64 to fix BUILD_BUG_ON

2016-10-11 Thread Saeed Mahameed
From: Tom Herbert I am hitting this in mlx5: drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c: In function reclaim_pages_cmd.clone.0: drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c:346: error: call to __compiletime_assert_346 declared with attribute error: BUILD_BUG_ON failed: __mlx5_bit

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-11 Thread Yuchung Cheng
On Tue, Oct 11, 2016 at 2:08 PM, Lawrence Brakmo wrote: > Yuchung, thank you for your comments. Responses inline. > > On 10/11/16, 12:49 PM, "Yuchung Cheng" wrote: > >>On Mon, Oct 10, 2016 at 5:18 PM, Lawrence Brakmo wrote: >>> >>> The purpose of this patch is to help balance flows across paths.

[PATCH net-next v2] bridge: add address and vlan to fdb warning messages

2016-10-11 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds vlan and address to warning messages printed in the bridge fdb code for debuggability. Signed-off-by: Roopa Prabhu --- v2 - address comments from stephen - use %u format specifier for vlan - move print string to a single line net/bridge/br_fd

Re: [PATCH net-next] bridge: add address and vlan to fdb warning messages

2016-10-11 Thread Roopa Prabhu
On 10/11/16, 3:17 PM, Stephen Hemminger wrote: > On Tue, 11 Oct 2016 14:33:51 -0700 > Roopa Prabhu wrote: > >> From: Roopa Prabhu >> >> This patch adds vlan and address to warning messages printed >> in the bridge fdb code for debuggability. >> >> Signed-off-by: Roopa Prabhu >> --- >> net/bridg

Re: [PATCH net-next] bridge: add address and vlan to fdb warning messages

2016-10-11 Thread Stephen Hemminger
On Tue, 11 Oct 2016 14:33:51 -0700 Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch adds vlan and address to warning messages printed > in the bridge fdb code for debuggability. > > Signed-off-by: Roopa Prabhu > --- > net/bridge/br_fdb.c | 11 ++- > 1 file changed, 6 insertion

Re: saddr based blackhole/unreachable route

2016-10-11 Thread Bjørnar Ness
2016-10-11 20:39 GMT+02:00 Bjørnar Ness : > Hello, netdev > > In a typical setup (eth0=internet, eth1=lan) i populate routing table > 100 with saddrs I want > dropped, and: "ip ru a pref 100 lookup table 100" > > What I would expect to see is packets with a saddr in table 100 coming > in eth0 will

[PATCH] Temporary patch for arpd

2016-10-11 Thread Pascal
Hello. I found wonderful bug in arpd daemon of iproute2 package. Somehow arpd is absolute unworkable if run program with -f flag. On my amd64 server i got "Segmentation fault" regardless -f mac-list.txt file content. The source of misc/arpd.c is not hard and i found that cause of this bug is commit

[PATCH net-next] bridge: add address and vlan to fdb warning messages

2016-10-11 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds vlan and address to warning messages printed in the bridge fdb code for debuggability. Signed-off-by: Roopa Prabhu --- net/bridge/br_fdb.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.

Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-11 Thread Stephen Hemminger
On Tue, 11 Oct 2016 15:26:18 -0500 Zach Brown wrote: > Adding led support for phy causes namespace conflicts for some > phy drivers. > > The marvel skge driver declared an enum for representing the states of > Link LED Register. The enum contained constant LED_OFF which conflicted > with declart

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-11 Thread Lawrence Brakmo
Yuchung, thank you for your comments. Responses inline. On 10/11/16, 12:49 PM, "Yuchung Cheng" wrote: >On Mon, Oct 10, 2016 at 5:18 PM, Lawrence Brakmo wrote: >> >> The purpose of this patch is to help balance flows across paths. A new >> sysctl "tcp_retrans_txhash_prob" specifies the probabili

[PATCH net] netvsc: fix checksum on UDP IPV6

2016-10-11 Thread Stephen Hemminger
The software calculation of UDP checksum in Netvsc driver was only handling IPv4 case. By using skb_checksum_help() instead all protocols can be handled. Rearrange code to eliminate goto and look like other drivers. This is a temporary solution; recent versions of Window Server etc do support UDP

Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change

2016-10-11 Thread Andrew Lunn
> Andrew, are you happy with this implementation? Sorry, been to busy with other things to follow the discussion. What would be nice to see is a comment about how the link to LEDs in the PHYs is made. Often there is a couple of LEDs in the RJ45 socket driven by the PHY. They can show link, speed,

[PATCH net] ip6_tunnel: fix ip6_tnl_lookup

2016-10-11 Thread Vadim Fedorenko
The commit ea3dc9601bda ("ip6_tunnel: Add support for wildcard tunnel endpoints.") introduces support for wildcards in tunnels endpoints, but in some rare circumstances ip6_tnl_lookup selects wrong tunnel interface relying only on source or destination address of the packet and not checking presenc

[PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace

2016-10-11 Thread Zach Brown
Adding led support for phy causes namespace conflicts for some phy drivers. The marvel skge driver declared an enum for representing the states of Link LED Register. The enum contained constant LED_OFF which conflicted with declartation found in linux/leds.h. LED_OFF changed to LED_REG_OFF Also ch

[PATCH v4 0/3] Add support for led triggers on phy link state change

2016-10-11 Thread Zach Brown
Fix skge driver that declared enum contants that conflicted with enum constants in linux/leds.h Create function that encapsulates actions taken during the adjust phy link step of phy state changes. Add support for led triggers on phy link state changes by adding a config option. When set the conf

[PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-11 Thread Zach Brown
From: Josh Cartwright Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a set of led triggers for each instantiated PHY device. There is one LED trigger per link-speed, per-phy. This allows for a user to configure their system to allow a set of LEDs to represent link state

[PATCH v4 2/3] net: phy: Encapsulate actions performed during link state changes into function phy_adjust_link

2016-10-11 Thread Zach Brown
During phy state machine state transitions some set of actions should occur whenever the link state changes. These actions should be encapsulated into a single function This patch adds the phy_adjust_link function, which is called whenever phydev->adjust_link would have been called before. Actions

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread Saeed Mahameed
On 10/11/2016 01:22 PM, Tom Herbert wrote: I am hitting this in mlx5: drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c: In function ‘reclaim_pages_cmd.clone.0’: drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c:346: error: call to ‘__compiletime_assert_346’ declared with attribute error:

[PATCH net] Revert "net: Add driver helper functions to determine checksum offloadability"

2016-10-11 Thread Stephen Hemminger
This reverts commit 6ae23ad36253a8033c5714c52b691b84456487c5. The code has been in kernel since 4.4 but there are no in tree code that uses. Unused code is broken code, remove it. Signed-off-by: Stephen Hemminger --- include/linux/netdevice.h | 78 -- net/core/dev.c

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

2016-10-11 Thread Yuchung Cheng
On Mon, Oct 10, 2016 at 5:18 PM, Lawrence Brakmo wrote: > > The purpose of this patch is to help balance flows across paths. A new > sysctl "tcp_retrans_txhash_prob" specifies the probability (0-100) that > the txhash (IPv6 flowlabel) will be changed after a non-RTO retransmit. > A probability is

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread Leon Romanovsky
On Tue, Oct 11, 2016 at 08:46:45AM -0700, Tom Herbert wrote: > On Tue, Oct 11, 2016 at 4:57 AM, Saeed Mahameed > wrote: > > On Tue, Oct 11, 2016 at 7:50 PM, David Laight > > wrote: > >> From: Tom Herbert > >>> Sent: 11 October 2016 05:22 > >> ... > >>> Fix is to create MLX5_SET64_VCHK that takes

Re: RFH: problems with adjacency graph

2016-10-11 Thread David Ahern
On 10/11/16 12:54 AM, Jiri Pirko wrote: >> >> It seems like the complete mesh is not really needed, but cscope shows >> spectrum, ixgbe and bonding all using the for_each upper and lower device >> macros. >> >> Suggestions? > > Well other possibility is to traverse the tree recursively. But that

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Doug Ledford
On 10/11/2016 2:30 PM, Jason Gunthorpe wrote: > On Tue, Oct 11, 2016 at 02:17:51PM -0400, Doug Ledford wrote: > >> Well, not exactly. Even if we put 65520 into the scripts, the kernel >> will silently drop it down to 65504. It actually won't require anyone >> change anything, they just won't get

saddr based blackhole/unreachable route

2016-10-11 Thread Bjørnar Ness
Hello, netdev In a typical setup (eth0=internet, eth1=lan) i populate routing table 100 with saddrs I want dropped, and: "ip ru a pref 100 lookup table 100" What I would expect to see is packets with a saddr in table 100 coming in eth0 will go out eth1, with replies beeing dropped, but I do not s

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Jason Gunthorpe
On Tue, Oct 11, 2016 at 02:17:51PM -0400, Doug Ledford wrote: > Well, not exactly. Even if we put 65520 into the scripts, the kernel > will silently drop it down to 65504. It actually won't require anyone > change anything, they just won't get the full value. I experimented > with this in the p

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Paolo Abeni
On Tue, 2016-10-11 at 11:42 -0600, Jason Gunthorpe wrote: > On Tue, Oct 11, 2016 at 07:37:32PM +0200, Paolo Abeni wrote: > > On Tue, 2016-10-11 at 11:32 -0600, Jason Gunthorpe wrote: > > > On Tue, Oct 11, 2016 at 07:15:44PM +0200, Paolo Abeni wrote: > > > > > > > Also the connected mode maximum mt

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Jason Gunthorpe
On Tue, Oct 11, 2016 at 08:10:07PM +0200, Paolo Abeni wrote: > The first s/g fragment (the head buffer) is not allocated with the page > allocator, so perhaps there is some not too difficult/costly way out of > this. Keep in mind, there is nothing magic about the 16 SGL limit, other than we know

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Doug Ledford
On 10/11/2016 2:10 PM, Paolo Abeni wrote: > On Tue, 2016-10-11 at 12:01 -0600, Jason Gunthorpe wrote: >>> AFAICS the max mtu is already underlying h/w dependent, how does such >>> differences are currently coped by ? (I'm sorry I lack some/a lot of IB >>> back-ground) >> >> It isn't h/w dependent.

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Paolo Abeni
On Tue, 2016-10-11 at 12:01 -0600, Jason Gunthorpe wrote: > > AFAICS the max mtu is already underlying h/w dependent, how does such > > differences are currently coped by ? (I'm sorry I lack some/a lot of IB > > back-ground) > > It isn't h/w dependent. In CM mode the MTU is 65520 because that is >

Re: [PATCH net 3/3] openvswitch: add NETIF_F_HW_VLAN_STAG_TX to internal dev

2016-10-11 Thread Eric Garver
On Mon, Oct 10, 2016 at 05:02:44PM +0200, Jiri Benc wrote: > The internal device does support 802.1AD offloading since 018c1dda5ff1 > ("openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink > attributes"). > > Signed-off-by: Jiri Benc Acked-by: Eric Garver

Re: [PATCH net] Panic when tc_lookup_action_n finds a partially initialized action.

2016-10-11 Thread Cong Wang
On Tue, Oct 11, 2016 at 2:28 AM, Krister Johansen wrote: > On Wed, Oct 05, 2016 at 11:01:38AM -0700, Cong Wang wrote: >> Does the attached patch make any sense now? Our pernet init doesn't >> rely on act_base, so even we have some race, the worst case is after >> we initialize the pernet netns for

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Jason Gunthorpe
On Tue, Oct 11, 2016 at 01:41:56PM -0400, Doug Ledford wrote: > declare the header. The problem then became that the sg setup is such > that we are limited to 16 4k pages for the sg array, so that header had > to come out of the 64k maximum mtu. Oh, that clarifies things.. Hum, so various optio

[Patch net] net_sched: reorder pernet ops and act ops registrations

2016-10-11 Thread Cong Wang
Krister reported a kernel NULL pointer dereference after tcf_action_init_1() invokes a_o->init(), it is a race condition where one thread calling tcf_register_action() to initialize the netns data after putting act ops in the global list and the other thread searching the list and then calling a_o-

Re: [PATCH net 2/3] openvswitch: fix vlan subtraction from packet length

2016-10-11 Thread Eric Garver
On Mon, Oct 10, 2016 at 05:02:43PM +0200, Jiri Benc wrote: > When the packet has its vlan tag in skb->vlan_tci, the length of the VLAN > header is not counted in skb->len. It doesn't make sense to subtract it. > > Fixes: 018c1dda5ff1 ("openvswitch: 802.1AD Flow handling, actions, vlan > parsing,

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Doug Ledford
On 10/11/2016 1:32 PM, Jason Gunthorpe wrote: > On Tue, Oct 11, 2016 at 07:15:44PM +0200, Paolo Abeni wrote: > >> Also the connected mode maximum mtu is reduced by 16 bytes to >> cope with the increased hard header len. > > Changing the MTU is going to cause annoying interop problems, can you > a

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Jason Gunthorpe
On Tue, Oct 11, 2016 at 07:37:32PM +0200, Paolo Abeni wrote: > On Tue, 2016-10-11 at 11:32 -0600, Jason Gunthorpe wrote: > > On Tue, Oct 11, 2016 at 07:15:44PM +0200, Paolo Abeni wrote: > > > > > Also the connected mode maximum mtu is reduced by 16 bytes to > > > cope with the increased hard heade

Re: [PATCH net] Panic when tc_lookup_action_n finds a partially initialized action.

2016-10-11 Thread Cong Wang
On Sat, Oct 8, 2016 at 11:13 PM, Krister Johansen wrote: > Hi Cong, > Thanks for the follow-up. > > On Thu, Oct 06, 2016 at 12:01:15PM -0700, Cong Wang wrote: >> On Wed, Oct 5, 2016 at 11:11 PM, Krister Johansen >> > pernet_operations pointer. The code in register_pernet_subsys() makes >> > no at

Re: [PATCH net 1/3] openvswitch: vlan: remove wrong likely statement

2016-10-11 Thread Eric Garver
On Mon, Oct 10, 2016 at 05:02:42PM +0200, Jiri Benc wrote: > This code is called whenever flow key is being extracted from the packet. > The packet may be as likely vlan tagged as not. > > Fixes: 018c1dda5ff1 ("openvswitch: 802.1AD Flow handling, actions, vlan > parsing, netlink attributes") > Si

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Paolo Abeni
On Tue, 2016-10-11 at 11:32 -0600, Jason Gunthorpe wrote: > On Tue, Oct 11, 2016 at 07:15:44PM +0200, Paolo Abeni wrote: > > > Also the connected mode maximum mtu is reduced by 16 bytes to > > cope with the increased hard header len. > > Changing the MTU is going to cause annoying interop problem

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Jason Gunthorpe
On Tue, Oct 11, 2016 at 07:15:44PM +0200, Paolo Abeni wrote: > Also the connected mode maximum mtu is reduced by 16 bytes to > cope with the increased hard header len. Changing the MTU is going to cause annoying interop problems, can you avoid this? Jason

[PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-11 Thread Paolo Abeni
After the commit 9207f9d45b0a ("net: preserve IP control block during GSO segmentation"), the GSO CB and the IPoIB CB conflict. That destroy the IPoIB address information cached there, causing a severe performance regression, as better described here: http://marc.info/?l=linux-kernel&m=14678727982

Re: [PATCH 04/10] i2c: i2c-sam: Add device tree bindings

2016-10-11 Thread Peter Rosin
On 2016-10-10 21:54, Rob Herring wrote: > On Fri, Oct 07, 2016 at 06:18:32PM +0300, Pantelis Antoniou wrote: >> From: Georgi Vlaev >> >> Add binding document for the i2c driver of SAM FPGA. >> >> Signed-off-by: Georgi Vlaev >> [Ported from Juniper kernel] >> Signed-off-by: Pantelis Antoniou >> -

ATENCIÓN;

2016-10-11 Thread Sistemas administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de corre

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread Tom Herbert
On Tue, Oct 11, 2016 at 4:57 AM, Saeed Mahameed wrote: > On Tue, Oct 11, 2016 at 7:50 PM, David Laight wrote: >> From: Tom Herbert >>> Sent: 11 October 2016 05:22 >> ... >>> Fix is to create MLX5_SET64_VCHK that takes an additional argument >>> that is a constant. There are two callers of MLX5_SE

RE: [PATCHv1 net] xen-netback: fix guest Rx stall detection (after guest Rx refactor)

2016-10-11 Thread Paul Durrant
> -Original Message- > From: David Vrabel [mailto:david.vra...@citrix.com] > Sent: 11 October 2016 16:48 > To: netdev@vger.kernel.org > Cc: David Vrabel ; xen-de...@lists.xenproject.org; > Paul Durrant ; Wei Liu > Subject: [PATCHv1 net] xen-netback: fix guest Rx stall detection (after gues

Re: [PATCH kernel v2] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

2016-10-11 Thread Alexander Duyck
On Mon, Oct 10, 2016 at 9:08 PM, Alexey Kardashevskiy wrote: > On 11/10/16 02:23, Alexander Duyck wrote: >> On Wed, Sep 28, 2016 at 10:21 PM, Alexey Kardashevskiy >> wrote: >>> There is at least one Chelsio 10Gb card which uses VPD area to store >>> some custom blocks (example below). However pc

[PATCHv1 net] xen-netback: fix guest Rx stall detection (after guest Rx refactor)

2016-10-11 Thread David Vrabel
If a VIF has been ready for rx_stall_timeout (60s by default) and an Rx ring is drained of all requests an Rx stall will be incorrectly detected. When this occurs and the guest Rx queue is empty, the Rx ring's event index will not be set and the frontend will not raise an event when new requests a

Re: [PATCH] doc: fix wrongly referencing dev->skb_mark

2016-10-11 Thread Ryota Ozaki
On Mon, Oct 10, 2016 at 10:49 PM, Ido Schimmel wrote: > Hi, > > On Mon, Oct 10, 2016 at 08:15:39PM +0900, Ryota Ozaki wrote: >> Section "Flooding L2 domain" says, to avoid duplicated flooding, if >> skb->offload_fwd_mark is matched with dev->skb_mark, the kernel will >> drop the packet. However, t

Re: [RFC] net: phy: smsc: Disable auto-negotiation on startup

2016-10-11 Thread Jeremy Linton
On 10/10/2016 12:41 PM, Kyle Roeschley wrote: Because the SMSC PHY completes auto-negotiation before the driver is ready to handle interrupts, the PHY state machine never realizes that we have a link. Clear the ANENABLE bit on initialization, which lets genphy_config_aneg do its thing when that c

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-11 Thread Chris Rorvick
On Tue, Oct 11, 2016 at 9:09 AM, Chris Rorvick wrote: > I didn't receive your email so I'll try to respond via Paul's. >>> If this is really bothering you, I guess I could apply this patch for >>> now. But as I said, this is not solving the actual problem. >> >> Bikeshedding: I think IWL_INFO()

Re: [PATCH 1/1] vxlan: insert ipv6 macro

2016-10-11 Thread Jiri Benc
On Tue, 11 Oct 2016 16:23:31 +0800, zyjzyj2...@gmail.com wrote: > --- a/drivers/net/vxlan.c > +++ b/drivers/net/vxlan.c > @@ -2647,15 +2647,15 @@ static struct socket *vxlan_create_sock(struct net > *net, bool ipv6, > int err; > > memset(&udp_conf, 0, sizeof(udp_conf)); > - > +#if IS

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-11 Thread Chris Rorvick
Hi Luca, I didn't receive your email so I'll try to respond via Paul's. On Tue, Oct 11, 2016 at 5:11 AM, Paul Bolle wrote: >> This is not coming from the NIC itself, but from the platform's ACPI >> tables. Can you tell us which platform you are using? Interesting. I'm running a Dell XPS 13 93

Re: slab corruption with current -git

2016-10-11 Thread Aaron Conole
Michal Kubecek writes: > On Mon, Oct 10, 2016 at 04:24:01AM -0400, David Miller wrote: >> From: David Miller >> Date: Sun, 09 Oct 2016 23:57:45 -0400 (EDT) >> >> This means that the netns is possibly getting freed up before we >> unregister the netfilter hooks. > > Sounds a bit like the issue d

Hello !

2016-10-11 Thread Benoît QUEMIN
‎ We have seen your message and are glad to know you :) We love your work and hope to hear from you soon <3 Xx

[PATCH 1/1] vxlan: insert ipv6 macro

2016-10-11 Thread zyjzyj2000
From: Zhu Yanjun The source code is related with ipv6. As such, it is better to insert ipv6 macro. Signed-off-by: Zhu Yanjun --- drivers/net/vxlan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index e7d1668..9af6600 100644

Re: slab corruption with current -git

2016-10-11 Thread Michal Kubecek
On Mon, Oct 10, 2016 at 04:24:01AM -0400, David Miller wrote: > From: David Miller > Date: Sun, 09 Oct 2016 23:57:45 -0400 (EDT) > > This means that the netns is possibly getting freed up before we > unregister the netfilter hooks. Sounds a bit like the issue discussed here: https://marc.info

Re: [PATCH net-next v10 1/1] net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.

2016-10-11 Thread Andrew Lunn
On Mon, Oct 10, 2016 at 04:13:45PM +0200, Allan W. Nielsen wrote: > Edge-Rate cleanup include the following: > - Updated device tree bindings documentation for edge-rate > - The edge-rate is now specified as a "slowdown", meaning that it is now > being specified as positive values instead of nega

[PATCH] drivers/ptp: Fix kernel memory disclosure

2016-10-11 Thread Vlad Tsyrklevich
The reserved field precise_offset->rsv is not cleared before being copied to user space, leaking kernel stack memory. Clear the struct before it's copied. Signed-off-by: Vlad Tsyrklevich --- drivers/ptp/ptp_chardev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ptp/ptp_chardev.c

[PATCH v2 iproute2 2/9] ife: print prio, mark and hash as unsigned

2016-10-11 Thread Jamal Hadi Salim
From: Roman Mashak Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim --- tc/m_ife.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tc/m_ife.c b/tc/m_ife.c index a5a7516..588bad7 100644 --- a/tc/m_ife.c +++ b/tc/m_ife.c @@ -252,7 +252,7 @@ static int print_i

Re: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread Saeed Mahameed
On Tue, Oct 11, 2016 at 7:50 PM, David Laight wrote: > From: Tom Herbert >> Sent: 11 October 2016 05:22 > ... >> Fix is to create MLX5_SET64_VCHK that takes an additional argument >> that is a constant. There are two callers of MLX5_SET64 that are >> trying to get a variable offset, change those t

[PATCH v2 iproute2 6/9] actions: add skbmod action

2016-10-11 Thread Jamal Hadi Salim
From: Jamal Hadi Salim This action is intended to be an upgrade from a usability perspective from pedit (as well as operational debugability). Compare this: sudo tc filter add dev $ETH parent 1: protocol ip prio 10 \ u32 match ip protocol 1 0xff flowid 1:2 \ action pedit munge offset -14 u8 set

RE: [PATCH net-next] mlx5: Add MLX5_SET64_VCHK to fix BUILD_BUG_ON

2016-10-11 Thread David Laight
From: Tom Herbert > Sent: 11 October 2016 05:22 ... > Fix is to create MLX5_SET64_VCHK that takes an additional argument > that is a constant. There are two callers of MLX5_SET64 that are > trying to get a variable offset, change those to call MLX5_SET64_VCHK > passing pas[0] as the argument to use

[PATCH v2 iproute2 9/9] man pages: add man page for skbmod action

2016-10-11 Thread Jamal Hadi Salim
From: Lucas Bates Signed-off-by: Lucas Bates Signed-off-by: Jamal Hadi Salim --- man/man8/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/Makefile b/man/man8/Makefile index 4ad96ce..de6f249 100644 --- a/man/man8/Makefile +++ b/man/man8/Makefile @@ -16,7 +1

[PATCH v2 iproute2 3/9] ife: improve help text

2016-10-11 Thread Jamal Hadi Salim
From: Roman Mashak Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim --- tc/m_ife.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tc/m_ife.c b/tc/m_ife.c index 588bad7..862461b 100644 --- a/tc/m_ife.c +++ b/tc/m_ife.c @@ -29,12 +29,13 @@ static void ife_expla

[PATCH v2 iproute2 5/9] action gact: list pipe as a valid action

2016-10-11 Thread Jamal Hadi Salim
From: Craig Dillabaugh Signed-off-by: Craig Dillabaugh Signed-off-by: Jamal Hadi Salim --- tc/m_gact.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tc/m_gact.c b/tc/m_gact.c index 2bfd9a7..dc04b9f 100644 --- a/tc/m_gact.c +++ b/tc/m_gact.c @@ -45,7 +45,7 @@ explain(v

[PATCH v2 iproute2 1/9] ife action: allow specifying index in hex

2016-10-11 Thread Jamal Hadi Salim
From: Roman Mashak Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim --- tc/m_ife.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/m_ife.c b/tc/m_ife.c index 0219760..a5a7516 100644 --- a/tc/m_ife.c +++ b/tc/m_ife.c @@ -152,7 +152,7 @@ static int parse_ife(str

[PATCH v2 iproute2 4/9] actions ife: Introduce encoding and decoding of tcindex metadata

2016-10-11 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim --- include/linux/tc_act/tc_ife.h | 3 ++- tc/m_ife.c| 29 +++-- 2 files changed, 25 insertions(+), 7 deletions(-) diff --git a/include/linux/tc_act/tc_ife.h b/include/linux/tc_act/tc_ife.h inde

[PATCH v2 iproute2 8/9] man pages: Add tc-ife to Makefile

2016-10-11 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim --- man/man8/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/Makefile b/man/man8/Makefile index 9213769..4ad96ce 100644 --- a/man/man8/Makefile +++ b/man/man8/Makefile @@ -16,7 +16,7 @@ MAN8PAGES = $(TA

[PATCH v2 iproute2 7/9] man pages: update ife action to include tcindex

2016-10-11 Thread Jamal Hadi Salim
From: Lucas Bates Signed-off-by: Lucas Bates Signed-off-by: Jamal Hadi Salim --- man/man8/tc-ife.8 | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/man/man8/tc-ife.8 b/man/man8/tc-ife.8 index 7b3601e..aaf0f97 100644 --- a/man/man8/tc-ife.8 +++

[PATCH v2 iproute2 0/9] Cleanup backlog

2016-10-11 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Variety of cleanup and new functionality I had sitting around on my private tree Craig Dillabaugh (1): action gact: list pipe as a valid action Jamal Hadi Salim (3): actions ife: Introduce encoding and decoding of tcindex metadata actions: add skbmod action man

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-11 Thread Paul Bolle
Hi Luca, On Mon, 2016-10-10 at 17:02 +0300, Luca Coelho wrote: > On Mon, 2016-10-10 at 02:19 -0500, Chris Rorvick wrote: > This is not coming from the NIC itself, but from the platform's ACPI > tables.  Can you tell us which platform you are using? On my machine I'm seeing the same error as Chris

Re: [PATCH v4 04/10] ARM: dts: sun8i-h3: Add dt node for the syscon control module

2016-10-11 Thread Maxime Ripard
On Mon, Oct 10, 2016 at 02:50:21PM +0200, Jean-Francois Moine wrote: > On Mon, 10 Oct 2016 14:31:51 +0200 > Maxime Ripard wrote: > > > Hi, > > > > On Fri, Oct 07, 2016 at 10:25:51AM +0200, Corentin Labbe wrote: > > > This patch add the dt node for the syscon register present on the > > > Allwinn

Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig

2016-10-11 Thread Maxime Ripard
On Mon, Oct 10, 2016 at 03:09:43PM +0200, Jean-Francois Moine wrote: > On Mon, 10 Oct 2016 14:35:11 +0200 > LABBE Corentin wrote: > > > On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > > > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > > > Enable the sun8i-ema

[PATCH net-next 0/6] FUJITSU Extended Socket driver version 1.2

2016-10-11 Thread Taku Izumi
From: Taku This patchset updates FUJITSU Extended Socket network driver into version 1.2. This includes the following enhancements: - ethtool -d support - ethtool -S enhancement - Add some debugging feature (tracepoints etc) Taku Izumi (6): fjes: ethtool -d support for fjes driver fjes

  1   2   >