Re: pull request (net): ipsec 2016-09-21

2016-09-21 Thread David Miller
From: Steffen Klassert Date: Wed, 21 Sep 2016 13:05:42 +0200 > 1) Propagate errors on security context allocation. >From Mathias Krause. > > 2) Fix inbound policy checks for inter address family tunnels. >From Thomas Zeitlhofer. > > 3) Fix an old memory leak on aead algorithm usage. >

[PATCH nf v5] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack

2016-09-21 Thread fgao
From: Gao Feng It is valid that the TCP RST packet which does not set ack flag, and bytes of ack number are zero. But current seqadj codes would adjust the "0" ack to invalid ack number. Actually seqadj need to check the ack flag before adjust it for these RST packets. The following is my test c

Re: [PATCH net-next V2 0/8] mlx5e XDP support

2016-09-21 Thread David Miller
From: Tariq Toukan Date: Wed, 21 Sep 2016 12:19:41 +0300 > This series adds XDP support in mlx5e driver. > This includes the use cases: XDP_DROP, XDP_PASS, and XDP_TX. > > Single stream performance tests show 16.5 Mpps for XDP_DROP, > and 12.4 Mpps for XDP_TX, with nice scalability for multiple

RE: [RFC v2 06/12] qedr: Add support for QP verbs

2016-09-21 Thread Amrani, Ram
> > Do you have a git tree? > We don't have a publicly accessible git tree.

Re: [patch net-next 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls

2016-09-21 Thread Ido Schimmel
On Wed, Sep 21, 2016 at 01:53:11PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Until now, in order to offload a FIB entry to HW we use switchdev op. > However that has limits. Mainly in case we need to make the HW aware of > all route prefixes configured in kernel. HW needs to know those in o

Re: pull-request: can 2016-09-21

2016-09-21 Thread David Miller
From: Marc Kleine-Budde Date: Wed, 21 Sep 2016 10:43:54 +0200 > this is another pull request of one patch for the upcoming linux-4.8 release. > > Marek Vasut fixes the CAN-FD bit rate switch in the ifi driver by configuring > the transmitter delay. Pulled, thanks.

Re: [PATCH net-next] tcp: implement TSQ for retransmits

2016-09-21 Thread David Miller
From: Eric Dumazet Date: Tue, 20 Sep 2016 22:45:58 -0700 > From: Eric Dumazet > > We saw sch_fq drops caused by the per flow limit of 100 packets and TCP > when dealing with large cwnd and bursts of retransmits. > > Even after increasing the limit to 1000, and even after commit > 10d3be569243

Re: [PATCH net-next] MAINTAINERS: Update b44 maintainer.

2016-09-21 Thread David Miller
From: Michael Chan Date: Tue, 20 Sep 2016 23:33:15 -0400 > Taking over as maintainer since Gary Zambrano is no longer working > for Broadcom. > > Signed-off-by: Michael Chan Applied, thanks.

Re: [PATCH net] net: get rid of an signed integer overflow in ip_idents_reserve()

2016-09-21 Thread David Miller
From: Eric Dumazet Date: Tue, 20 Sep 2016 18:06:17 -0700 > From: Eric Dumazet > > Jiri Pirko reported an UBSAN warning happening in ip_idents_reserve() > > [] UBSAN: Undefined behaviour in ./arch/x86/include/asm/atomic.h:156:11 > [] signed integer overflow: > [] -2117905507 + -695755206 cannot

[PATCH nf v4] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack

2016-09-21 Thread fgao
From: Gao Feng It is valid that the TCP RST packet which does not set ack flag, and bytes of ack number are zero. But current seqadj codes would adjust the "0" ack to invalid ack number. Actually seqadj need to check the ack flag before adjust it for these RST packets. The following is my test c

[PATCH iproute2 1/2] ip rule: merge ip rule flush and list, save together

2016-09-21 Thread Hangbin Liu
iprule_flush() and iprule_list_or_save() both call function rtnl_wilddump_request() and rtnl_dump_filter(). So merge them together just like other files do. Signed-off-by: Hangbin Liu --- ip/iprule.c | 121 +++- 1 file changed, 54 insertion

[PATCH iproute2 2/2] ip rule: add selector support

2016-09-21 Thread Hangbin Liu
Signed-off-by: Hangbin Liu --- ip/iprule.c| 180 +++-- man/man8/ip-rule.8 | 6 +- 2 files changed, 180 insertions(+), 6 deletions(-) diff --git a/ip/iprule.c b/ip/iprule.c index e18505f..42fb6af 100644 --- a/ip/iprule.c +++ b/ip/iprule.c

[PATCH iproute2 0/2] ip rule: merger iprule_flush and add selector support

2016-09-21 Thread Hangbin Liu
When merge iprule_flush() and iprule_list_or_save(). Renamed rtnl_filter_t filter to filter_fn because we want to use global variable 'filter' to filter nlmsg in the next patch. Hangbin Liu (2): ip rule: merge ip rule flush and list, save together ip rule: add selector support ip/iprule.c

Re: [PATCH] ptp_clock: future-proofing drivers against PTP subsystem becoming optional

2016-09-21 Thread David Miller
From: Nicolas Pitre Date: Tue, 20 Sep 2016 19:25:58 -0400 (EDT) > > Drivers must be ready to accept NULL from ptp_clock_register() if the > PTP clock subsystem is configured out. > > This patch documents that and ensures that all drivers cope well > with a NULL return. > > Signed-off-by: Nicol

Re: [PATCH nf v3] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack

2016-09-21 Thread Pablo Neira Ayuso
On top of Eric's comments. On Thu, Sep 22, 2016 at 10:22:45AM +0800, f...@ikuai8.com wrote: > diff --git a/net/netfilter/nf_conntrack_seqadj.c > b/net/netfilter/nf_conntrack_seqadj.c > index dff0f0c..3bd9c7e 100644 > --- a/net/netfilter/nf_conntrack_seqadj.c > +++ b/net/netfilter/nf_conntrack_seq

Re: [PATCHv3 net-next 0/2] Preparation for mv88e6390

2016-09-21 Thread David Miller
From: Andrew Lunn Date: Wed, 21 Sep 2016 01:40:30 +0200 > These two patches are a couple of preparation steps for supporting the > the MV88E6390 family of chips. This is a new generation from Marvell, > and will need more feature flags than are currently available in an > unsigned long. Expand to

Re: [PATCH 1/2] net: ethernet: hisilicon: hns: use phydev from struct net_device

2016-09-21 Thread David Miller
From: Philippe Reynes Date: Tue, 20 Sep 2016 22:30:11 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct

Re: [PATCH 2/2] net: ethernet: hisilicon: hns: use new api ethtool_{get|set}_link_ksettings

2016-09-21 Thread David Miller
From: Philippe Reynes Date: Tue, 20 Sep 2016 22:30:12 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH v2 0/2] make POSIX timers optional

2016-09-21 Thread David Miller
From: Nicolas Pitre Date: Tue, 20 Sep 2016 15:56:38 -0400 > Many embedded systems don't need the full POSIX timer support. > Configuring them out provides a nice kernel image size reduction. > > When POSIX timers are configured out, the PTP clock subsystem should be > left out as well. However a

Re: [PATCH] net: fec: set mac address unconditionally

2016-09-21 Thread Uwe Kleine-König
Hello, just a few nitpicks: On Wed, Sep 21, 2016 at 03:30:55PM +0200, Gavin Schenk wrote: > Fixes: 9638d19e4816 ("net: fec: add netif status check before set mac > address") This line belongs to in the S-o-B area below. > If the mac address origin is not dt, you can only safe assign a s/safe/

Re: [PATCH net-next] net: ethernet: mediatek: fix missing changes merged for conflicts overlapping commits

2016-09-21 Thread David Miller
From: Date: Tue, 20 Sep 2016 23:53:24 +0800 > From: Sean Wang > > add the missing commits about > 1) > Commit d3bd1ce4db8e843dce421e2f8f123e5251a9c7d3 > ("remove redundant free_irq for devm_request_ir allocated irq") > 2) > Commit 7c6b0d76fa02213393815e3b6d5e4a415bf3f0e2 > ("fix logic unbalance

Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()

2016-09-21 Thread David Miller
From: Jiri Benc Date: Tue, 20 Sep 2016 19:09:29 +0200 > But the point stands, we have much greater problems here than VXLAN. > And I don't think that wrapping all IP address accesses into > get/put_unaligned all around the stack is the solution. Right, and I don't like marking things as packed e

Re: [PATCH] cxgb4: fix signed wrap around when decrementing index idx

2016-09-21 Thread David Miller
From: Colin King Date: Tue, 20 Sep 2016 15:48:45 +0100 > From: Colin Ian King > > Change predecrement compare to post decrement compare to avoid an > unsigned integer wrap-around comparison when decrementing idx in > the while loop. > > For example, when idx is zero, the current situation will

Re: [PATCH net] net/mlx4_core: Fix to clean devlink resources

2016-09-21 Thread David Miller
From: Tariq Toukan Date: Tue, 20 Sep 2016 14:55:31 +0300 > From: Kamal Heib > > This patch cleans devlink resources by calling devlink_port_unregister() > to avoid the following issues: > > - Kernel panic when triggering reset flow. > - Memory leak due to unfreed resources in mlx4_init_port_in

Re: [PATCH net-next v3 0/5] cxgb4: add support for offloading TC u32 filters

2016-09-21 Thread David Miller
From: Rahul Lakkireddy Date: Tue, 20 Sep 2016 17:13:05 +0530 > This series of patches add support to offload TC u32 filters onto > Chelsio NICs. > > Patch 1 moves current common filter code to separate files > in order to provide a common api for performing packet classification > and filtering

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

2016-09-21 Thread hejianet
On 9/22/16 2:24 AM, Marcelo wrote: On Thu, Sep 22, 2016 at 12:18:46AM +0800, hejianet wrote: Hi Marcelo sorry for the late, just came back from a vacation. Hi, no problem. Hope your batteries are recharged now :-) On 9/14/16 7:55 PM, Marcelo wrote: Hi Jia, On Wed, Sep 14, 2016 at 01:58:4

Re: [PATCH v3 net-next 1/2] net: skbuff: Remove errornous length validation in skb_vlan_pop()

2016-09-21 Thread David Miller
From: Shmulik Ladkani Date: Tue, 20 Sep 2016 12:48:36 +0300 > In 93515d53b1 > "net: move vlan pop/push functions into common code" > skb_vlan_pop was moved from its private location in openvswitch to > skbuff common code. > > In case skb has non hw-accel vlan tag, the original 'pop_vlan()' ass

Re: [PATCH v3 net-next 2/2] net: skbuff: Coding: Use eth_type_vlan() instead of open coding it

2016-09-21 Thread David Miller
From: Shmulik Ladkani Date: Tue, 20 Sep 2016 12:48:37 +0300 > Fix 'skb_vlan_pop' to use eth_type_vlan instead of directly comparing > skb->protocol to ETH_P_8021Q or ETH_P_8021AD. > > Signed-off-by: Shmulik Ladkani Applied.

Re: [PATCH v2 0/2] act_vlan: Introduce TCA_VLAN_ACT_MODIFY vlan action

2016-09-21 Thread David Miller
From: Shmulik Ladkani Date: Mon, 19 Sep 2016 19:11:08 +0300 > TCA_VLAN_ACT_MODIFY allows one to change an existing tag. > > It accepts same attributes as TCA_VLAN_ACT_PUSH (protocol, id, > priority). > If packet is vlan tagged, then the tag gets overwritten according to > user specified attribut

Re: [PATCH] net: explicitly whitelist sysctls for unpriv namespaces

2016-09-21 Thread David Miller
From: Jann Horn Date: Sun, 18 Sep 2016 22:58:20 +0200 > There were two net sysctls that could be written from unprivileged net > namespaces, but weren't actually namespaced. > > To fix the existing issues and prevent stuff this from happening again in > the future, explicitly whitelist permitted

Re: [PATCH] net: explicitly whitelist sysctls for unpriv namespaces

2016-09-21 Thread David Miller
From: Jann Horn Date: Sun, 18 Sep 2016 22:58:20 +0200 > There were two net sysctls that could be written from unprivileged net > namespaces, but weren't actually namespaced. > > To fix the existing issues and prevent stuff this from happening again in > the future, explicitly whitelist permitted

Re: [PATCH net-next 9/9] rxrpc: Reduce the number of ACK-Requests sent

2016-09-21 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/David-Howells/rxrpc-Preparation-for-slow-start-algorithm/20160922-085242 config: arm-omap2plus_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 rep

Re: [PATCH nf v3] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack

2016-09-21 Thread Eric Dumazet
On Thu, 2016-09-22 at 10:22 +0800, f...@ikuai8.com wrote: > From: Gao Feng > > It is valid that the TCP RST packet which does not set ack flag, and bytes > of ack number are zero. But current seqadj codes would adjust the "0" ack > to invalid ack number. Actually seqadj need to check the ack flag

Re: [patch net-next 2/6] fib: introduce FIB info offload flag helpers

2016-09-21 Thread Ido Schimmel
On Wed, Sep 21, 2016 at 01:53:10PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > These helpers are to be used in case someone offloads the FIB entry. The > result is that if the entry is offloaded to at least one device, the > offload flag is set. > > Signed-off-by: Jiri Pirko Reviewed-by: I

Re: [patch net-next 1/6] fib: introduce FIB notification infrastructure

2016-09-21 Thread Ido Schimmel
On Wed, Sep 21, 2016 at 01:53:09PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > This allows to pass information about added/deleted FIB entries/rules to > whoever is interested. This is done in a very similar way as devinet > notifies address additions/removals. > > Signed-off-by: Jiri Pirko

Re: [PATCH net-next 3/9] rxrpc: Add per-peer RTT tracker

2016-09-21 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/David-Howells/rxrpc-Preparation-for-slow-start-algorithm/20160922-085242 config: i386-randconfig-h0-09220655 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

Re: [PATCH net-next 3/9] rxrpc: Add per-peer RTT tracker

2016-09-21 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/David-Howells/rxrpc-Preparation-for-slow-start-algorithm/20160922-085242 config: arm-omap2plus_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 rep

[PATCH] net: VRF: Fix receiving multicast traffic

2016-09-21 Thread Mark Tomlinson
The previous patch to ensure that the original iif was used when checking for forwarding also meant that this same interface was used to determine whether multicast packets should be received or not. This was incorrect, and would cause multicast packets to be dropped. The fix here is to use skb->d

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

2016-09-21 Thread Florian Fainelli
Le 21/09/2016 à 19:33, sean.w...@mediatek.com a écrit : > From: Sean Wang > > By default, GMAC0 is connected to built-in switch called > MT7530 through the proprietary interface called Turbo RGMII > (TRGMII). TRGMII also supports well for RGMII as generic external > PHY uses but requires some sli

[PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0

2016-09-21 Thread sean.wang
From: Sean Wang Add the dts property for the capability if TRGMII supported on GAMC0 Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/net/mediatek-net.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/mediatek-net.tx

[PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

2016-09-21 Thread sean.wang
From: Sean Wang adds PHY-mode "trgmii" as an extension for the operation mode of the PHY interface for PHY_INTERFACE_MODE_TRGMII. and adds a variable trgmii inside mtk_mac as the indication to make the difference between the MAC connected to internal switch or connected to external PHY by the giv

[PATCH net-next v2 2/3] net: ethernet: mediatek: add support for GMAC0 connecting with external PHY through TRGMII

2016-09-21 Thread sean.wang
From: Sean Wang Changing dynamically source clock, TX/RX delay and interface mode used by TRGMII hardware module inside PHY capability polling routine for adapting to the various speed of RGMII used by external PHY for GMAC0. Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_s

[PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

2016-09-21 Thread sean.wang
From: Sean Wang By default, GMAC0 is connected to built-in switch called MT7530 through the proprietary interface called Turbo RGMII (TRGMII). TRGMII also supports well for RGMII as generic external PHY uses but requires some slight changes to the setup of TRGMII and doesn't have well support on

[PATCH nf v3] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack

2016-09-21 Thread fgao
From: Gao Feng It is valid that the TCP RST packet which does not set ack flag, and bytes of ack number are zero. But current seqadj codes would adjust the "0" ack to invalid ack number. Actually seqadj need to check the ack flag before adjust it for these RST packets. The following is my test c

Re: [PATCH net] tcp: fix under-accounting retransmit SNMP counters

2016-09-21 Thread Eric Dumazet
On Wed, 2016-09-21 at 16:16 -0700, Yuchung Cheng wrote: > This patch fixes these under-accounting SNMP rtx stats > LINUX_MIB_TCPFORWARDRETRANS > LINUX_MIB_TCPFASTRETRANS > LINUX_MIB_TCPSLOWSTARTRETRANS > when retransmitting TSO packets > > Fixes: 10d3be569243 ("tcp-tso: do not split TSO packets at

Re: [PATCH net-next V2 0/4] mlx4 misc cleanups and improvements

2016-09-21 Thread David Miller
From: Tariq Toukan Date: Tue, 20 Sep 2016 14:39:38 +0300 > This patchset contains some cleanups and improvements from the team > to the mlx4 Eth and core drivers. > > Series generated against net-next commit: > 5a7aa362 'net sched: stylistic cleanups' Series applied, thanks.

Re: pull-request: wireless-drivers 2016-09-20

2016-09-21 Thread David Miller
From: Kalle Valo Date: Tue, 20 Sep 2016 13:20:46 +0300 > last pull request for 4.8, unless something really drastic comes up. And > a small one even, just a small fix to iwlwifi to avoid a firmware crash. > > Please let me know if there are any problems. Pulled, thanks.

Re: [PATCH net-next 8/9] rxrpc: Reduce the number of PING ACKs sent

2016-09-21 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/David-Howells/rxrpc-Preparation-for-slow-start-algorithm/20160922-085242 config: i386-randconfig-x009-201638 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

[PATCH net-next 8/9] rxrpc: Reduce the number of PING ACKs sent

2016-09-21 Thread David Howells
We don't want to send a PING ACK for every new incoming call as that just adds to the network traffic. Instead, we send a PING ACK to the first three that we receive and then once per second thereafter. This could probably be made adjustable in future. Signed-off-by: David Howells --- net/rxr

[PATCH net-next 7/9] rxrpc: Obtain RTT data by requesting ACKs on DATA packets

2016-09-21 Thread David Howells
In addition to sending a PING ACK to gain RTT data, we can set the RXRPC_REQUEST_ACK flag on a DATA packet and get a REQUESTED-ACK ACK. The ACK packet contains the serial number of the packet it is in response to, so we can look through the Tx buffer for a matching DATA packet. This requires that

[PATCH net-next 6/9] rxrpc: Add ktime_sub_ms()

2016-09-21 Thread David Howells
Add a ktime_sub_ms() to go with ktime_add_ms() and co. for use in AF_RXRPC RTT determination. Signed-off-by: David Howells --- include/linux/ktime.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/ktime.h b/include/linux/ktime.h index 2b6a204bd8d4..aa118bad1407 100644

[PATCH net-next 5/9] rxrpc: Expedite ping response transmission

2016-09-21 Thread David Howells
Expedite the transmission of a response to a PING ACK by sending it from sendmsg if one is pending. We're most likely to see a PING ACK during the client call Tx phase as the other side may use it to determine a number of parameters, such as the client's receive window size, the RTT and whether th

[PATCH net-next 9/9] rxrpc: Reduce the number of ACK-Requests sent

2016-09-21 Thread David Howells
Reduce the number of ACK-Requests we set on DATA packets that we're sending to reduce network traffic. We set the flag on odd-numbered DATA packets to start off the RTT cache until we have at least three entries in it and then probe once per second thereafter to keep it topped up. This could be m

[PATCH net-next 1/9] rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs

2016-09-21 Thread David Howells
Don't store the rxrpc protocol header in sk_buffs on the transmit queue, but rather generate it on the fly and pass it to kernel_sendmsg() as a separate iov. This reduces the amount of storage required. Note that the security header is still stored in the sk_buff as it may get encrypted along wit

[PATCH net-next 0/9] rxrpc: Preparation for slow-start algorithm

2016-09-21 Thread David Howells
Here are some patches that prepare for improvements in ACK generation and for the implementation of the slow-start part of the protocol: (1) Stop storing the protocol header in the Tx socket buffers, but rather generate it on the fly. This potentially saves a little space and makes it

[PATCH net-next 4/9] rxrpc: Send pings to get RTT data

2016-09-21 Thread David Howells
Send a PING ACK packet to the peer when we get a new incoming call from a peer we don't have a record for. The PING RESPONSE ACK packet will tell us the following about the peer: (1) its receive window size (2) its MTU sizes (3) its support for jumbo DATA packets (4) if it supports slow st

[PATCH net-next 2/9] rxrpc: Add re-sent Tx annotation

2016-09-21 Thread David Howells
Add a Tx-phase annotation for packet buffers to indicate that a buffer has already been retransmitted. This will be used by future congestion management. Re-retransmissions of a packet don't affect the congestion window managment in the same way as initial retransmissions. Signed-off-by: David H

[PATCH net-next 3/9] rxrpc: Add per-peer RTT tracker

2016-09-21 Thread David Howells
Add a function to track the average RTT for a peer. Sources of RTT data will be added in subsequent patches. The RTT data will be useful in the future for determining resend timeouts and for handling the slow-start part of the Rx protocol. Also add a pair of tracepoints, one to log transmissions

Re: XDP (eXpress Data Path) documentation

2016-09-21 Thread Tom Herbert
On Tue, Sep 20, 2016 at 2:08 AM, Jesper Dangaard Brouer wrote: > Hi all, > > As promised, I've started documenting the XDP eXpress Data Path): > > [1] > https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/index.html > > IMHO the documentation have reached a stage where it is useful

Re: [PATCHv7 net-next 00/15] BPF hardware offload (cls_bpf for now)

2016-09-21 Thread David Miller
From: Jakub Kicinski Date: Wed, 21 Sep 2016 11:43:52 +0100 > In the last year a lot of progress have been made on offloading > simpler TC classifiers. There is also growing interest in using > BPF for generic high-speed packet processing in the kernel. > It seems beneficial to tie those two tren

Re: [PATCH iproute2 net-next] iptnl: add support for collect_md flag in IPv4 and IPv6 tunnels

2016-09-21 Thread Stephen Hemminger
On Mon, 19 Sep 2016 17:03:14 -0700 Alexei Starovoitov wrote: > Signed-off-by: Alexei Starovoitov Applied, please send update to man page as well.

Re: [PATCH iproute2] ipmonitor: fix ip monitor can't work when NET_NS is not enabled

2016-09-21 Thread Stephen Hemminger
On Tue, 20 Sep 2016 02:09:02 -0700 Liping Zhang wrote: > From: Liping Zhang > > In ip monitor, netns_map_init will check getnsid is supported or not. > But when /proc/self/ns/net does not exist, we just print out error > messages and exit. So user cannot use ip monitor anymore when > CONFIG_NET

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-21 Thread Eric Dumazet
On Wed, 2016-09-21 at 19:23 +0200, Paolo Abeni wrote: > Avoid usage of common memory accounting functions, since > the logic is pretty much different. > > To account for forward allocation, a couple of new atomic_t > members are added to udp_sock: 'mem_alloced' and 'mem_freed'. > The current forwa

Re: [PATCH iproute2 3/3] ss: output TCP BBR diag information

2016-09-21 Thread Stephen Hemminger
On Tue, 20 Sep 2016 22:43:44 -0400 Neal Cardwell wrote: > Dump useful TCP BBR state information from a struct tcp_bbr_info that > was grabbed using the inet_diag API. > > We tolerate info that is shorter or longer than expected, in case the > kernel is older or newer than the ss binary. We simpl

[PATCH net] tcp: fix under-accounting retransmit SNMP counters

2016-09-21 Thread Yuchung Cheng
This patch fixes these under-accounting SNMP rtx stats LINUX_MIB_TCPFORWARDRETRANS LINUX_MIB_TCPFASTRETRANS LINUX_MIB_TCPSLOWSTARTRETRANS when retransmitting TSO packets Fixes: 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit time") Signed-off-by: Yuchung Cheng --- net/ipv4/tcp_out

[PATCH net] tcp: properly account Fast Open SYN-ACK retrans

2016-09-21 Thread Yuchung Cheng
Since the TFO socket is accepted right off SYN-data, the socket owner can call getsockopt(TCP_INFO) to collect ongoing SYN-ACK retransmission or timeout stats (i.e., tcpi_total_retrans, tcpi_retransmits). Currently those stats are only updated upon handshake completes. This patch fixes it. Signed-

[PATCH net-next v2 3/6] net/faraday: Adapt for Aspeed SoCs

2016-09-21 Thread Joel Stanley
The RXDES and TXDES registers bits in the ftgmac100 indicates EDO{R,T}R at bit position 15 for the Faraday Tech IP. However, the version of this IP present in the Aspeed SoCs has these bits at position 30 in the registers. It appers that ast2400 SoCs support both positions, with the 15th bit marke

[PATCH net-next v2 6/6] net/faraday: Mask out PHYSTS_CHG interrupt

2016-09-21 Thread Joel Stanley
The PHYSTS_CHG (the ftgmac100's PHY IRQ) is telling the system to go look at the PHY registers for a link status change. The interrupt was causing issues on Aspeed SoC where some board designs had an active high configuration, some active low, and in some cases repurposed for other functions. When

[PATCH net-next v2 1/6] net/faraday: Separate rx page storage from rxdesc

2016-09-21 Thread Joel Stanley
From: Andrew Jeffery The ftgmac100 hardware revision in e.g. the Aspeed AST2500 no longer reserves all bits in RXDES#2 but instead uses the bottom 16 bits to store MAC frame metadata. Avoid corruption by shifting struct page pointers out to their own member in struct ftgmac100. Signed-off-by: An

Re: [PATCH net-next 0/7] ftgmac100 support for ast2500

2016-09-21 Thread Joel Stanley
Please ignore this one. On Thu, Sep 22, 2016 at 8:33 AM, Joel Stanley wrote: > Hello Dave, > > This series adds support to the ftgmac100 driver for the Aspeed ast2400 and > ast2500 SoCs. In particular, they ensure the driver works correctly on the > ast2500 where the MAC block has seen some chang

[PATCH net-next v2 4/6] net/faraday: Clear stale interrupts

2016-09-21 Thread Joel Stanley
From: Gavin Shan There is stale interrupt (PHYSTS_CHG in ISR, bit#6 in 0x0) from the bootloader (uboot) when enabling the MAC. The stale interrupts aren't part of kernel and should be cleared. This clears the stale interrupts in ISR (0x0) when enabling the MAC. Signed-off-by: Gavin Shan Signed

[PATCH net-next v2 5/6] net/faraday: Configure old MDIO interface on Aspeed SoCs

2016-09-21 Thread Joel Stanley
The Aspeed SoCs have a new MDIO interface as an option in the G4 and G5 SoCs. The old one is still available, so select it in order to remain compatible with the ftgmac100 driver. Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 9 + drivers/net/ethernet/faraday

[PATCH net-next v2 0/6] ftgmac100 support for ast2500

2016-09-21 Thread Joel Stanley
Hello Dave, This series adds support to the ftgmac100 driver for the Aspeed ast2400 and ast2500 SoCs. In particular, they ensure the driver works correctly on the ast2500 where the MAC block has seen some changes in register layout. They have been tested on ast2400 and ast2500 systems with the NC

[PATCH net-next v2 2/6] net/faraday: Make EDO{R,T}R bits configurable

2016-09-21 Thread Joel Stanley
From: Andrew Jeffery These bits are #defined at a fixed location. In order to support future hardware that has chosen to move these bits around move the bits into a member of the struct ftgmac100. Signed-off-by: Andrew Jeffery Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgma

[PATCH net-next 0/7] ftgmac100 support for ast2500

2016-09-21 Thread Joel Stanley
Hello Dave, This series adds support to the ftgmac100 driver for the Aspeed ast2400 and ast2500 SoCs. In particular, they ensure the driver works correctly on the ast2500 where the MAC block has seen some changes in register layout. They have been tested on ast2400 and ast2500 systems with the NC

Re: [net-next 01/15] i40e: Introduce VF port representor/control netdevs

2016-09-21 Thread Jeff Kirsher
On Wed, 2016-09-21 at 22:21 +0300, Or Gerlitz wrote: > On Wed, Sep 21, 2016 at 7:59 PM, Samudrala, Sridhar > wrote: > > On 9/21/2016 12:04 AM, Or Gerlitz wrote: > > > >> so what happens after this patchset is applied and before the future > work is > >> submitted? RX/TX slow path through the VFP

[PATCH] L2TP:Adjust intf MTU, add underlay L3, overlay L2

2016-09-21 Thread R. Parameswaran
Take into account all of the tunnel encapsulation headers when setting up the MTU on the L2TP logical interface device. Otherwise, packets created by the applications on top of the L2TP layer are larger than they ought to be, relative to the underlay MTU, leading to needless fragmentation once th

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

2016-09-21 Thread Jesper Dangaard Brouer
On Wed, 21 Sep 2016 08:08:34 -0700 Tom Herbert wrote: > On Wed, Sep 21, 2016 at 7:48 AM, Thomas Graf wrote: > > On 09/21/16 at 07:19am, Tom Herbert wrote: > >> certain design that because of constraints on one kernel interface. As > >> a kernel developer I want flexibility on how we design an

Re: [RFC v2 07/12] qedr: Add support for memory registeration verbs

2016-09-21 Thread Sagi Grimberg
+static int qedr_set_page(struct ib_mr *ibmr, u64 addr) +{ + struct qedr_mr *mr = get_qedr_mr(ibmr); + struct qedr_pbl *pbl_table; + struct regpair *pbe; + u32 pbes_in_page; + + if (unlikely(mr->npages == mr->info.pbl_info.num_pbes)) { + DP_ERR(mr->dev

Re: [net-next 01/15] i40e: Introduce VF port representor/control netdevs

2016-09-21 Thread Or Gerlitz
On Wed, Sep 21, 2016 at 7:59 PM, Samudrala, Sridhar wrote: > On 9/21/2016 12:04 AM, Or Gerlitz wrote: >> so what happens after this patchset is applied and before the future work is >> submitted? RX/TX slow path through the VFPRs isn't supported and what >> about fast path? in other words what h

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

2016-09-21 Thread Thomas Graf
On 09/21/16 at 11:50am, Tom Herbert wrote: > 50 lines in one driver is not a big deal, 50 lines in a hundred > drivers is! I learned this lesson in BQL which was well abstracted out > to be minimally invasive but we still saw many issues because of the > pecularities of different drivers. You want

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

2016-09-21 Thread Jakub Kicinski
On Wed, 21 Sep 2016 11:50:06 -0700, Tom Herbert wrote: > On Wed, Sep 21, 2016 at 11:45 AM, Jakub Kicinski wrote: > > On Wed, 21 Sep 2016 10:39:40 -0700, Tom Herbert wrote: > >> On Wed, Sep 21, 2016 at 10:26 AM, Jakub Kicinski wrote: > >> > On Tue, 20 Sep 2016 17:01:39 -0700, Alexei Starovoito

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

2016-09-21 Thread Tom Herbert
On Wed, Sep 21, 2016 at 11:45 AM, Jakub Kicinski wrote: > On Wed, 21 Sep 2016 10:39:40 -0700, Tom Herbert wrote: >> On Wed, Sep 21, 2016 at 10:26 AM, Jakub Kicinski wrote: >> > On Tue, 20 Sep 2016 17:01:39 -0700, Alexei Starovoitov wrote: >> >> > - Reduces the amount of code and complexity need

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

2016-09-21 Thread Thomas Graf
On 09/21/16 at 05:45pm, Pablo Neira Ayuso wrote: > On Tue, Sep 20, 2016 at 06:43:35PM +0200, Daniel Mack wrote: > > The point is that from an application's perspective, restricting the > > ability to bind a port and dropping packets that are being sent is a > > very different thing. Applications wi

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

2016-09-21 Thread Jakub Kicinski
On Wed, 21 Sep 2016 10:39:40 -0700, Tom Herbert wrote: > On Wed, Sep 21, 2016 at 10:26 AM, Jakub Kicinski wrote: > > On Tue, 20 Sep 2016 17:01:39 -0700, Alexei Starovoitov wrote: > >> > - Reduces the amount of code and complexity needed in drivers to > >> >manage XDP > >> > >> hmm: > >>

[PATCH v2] tcp: fix wrong checksum calculation on MTU probing

2016-09-21 Thread Douglas Caetano dos Santos
With TCP MTU probing enabled and offload TX checksumming disabled, tcp_mtu_probe() calculated the wrong checksum when a fragment being copied into the probe's SKB had an odd length. This was caused by the direct use of skb_copy_and_csum_bits() to calculate the checksum, as it pads the fragment bein

Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show

2016-09-21 Thread Marcelo
On Thu, Sep 22, 2016 at 12:18:46AM +0800, hejianet wrote: > Hi Marcelo > > sorry for the late, just came back from a vacation. Hi, no problem. Hope your batteries are recharged now :-) > > On 9/14/16 7:55 PM, Marcelo wrote: > > Hi Jia, > > > > On Wed, Sep 14, 2016 at 01:58:42PM +0800, hejianet

Re: [ANNOUNCE] ndiv: line-rate network traffic processing

2016-09-21 Thread Willy Tarreau
Hi Tom, On Wed, Sep 21, 2016 at 10:16:45AM -0700, Tom Herbert wrote: > This does seem interesting and indeed the driver datapath looks very > much like XDP. It would be quite interesting if you could rebase and > then maybe look at how this can work with XDP that would be helpful. OK I'll assign

Re: [ANNOUNCE] ndiv: line-rate network traffic processing

2016-09-21 Thread Willy Tarreau
Hi Jesper! On Wed, Sep 21, 2016 at 06:26:39PM +0200, Jesper Dangaard Brouer wrote: > I definitely want to study it! Great, at least I've not put this online for nothing :-) > You mention XDP. If you didn't notice, I've created some documentation > on XDP (it is very "live" documentation at this

RE: [PATCH] net: fec: set mac address unconditionally

2016-09-21 Thread Andy Duan
From: Gavin Schenk Sent: Wednesday, September 21, 2016 9:31 PM > To: Andy Duan > Cc: netdev@vger.kernel.org; ker...@pengutronix.de; Gavin Schenk > > Subject: [PATCH] net: fec: set mac address unconditionally > > Fixes: 9638d19e4816 ("net: fec: add netif status check before set mac > address")

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

2016-09-21 Thread Tom Herbert
On Wed, Sep 21, 2016 at 10:26 AM, Jakub Kicinski wrote: > On Tue, 20 Sep 2016 17:01:39 -0700, Alexei Starovoitov wrote: >> > - Reduces the amount of code and complexity needed in drivers to >> >manage XDP >> >> hmm: >> 534 insertions(+), 144 deletions(-) >> looks like increase in complexity

As-salam o Alaikum

2016-09-21 Thread Saidat Abdulmumuni
Hello, I am Saidat, I sent you a message yesterday, Please did you receive it? Thank you!

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

2016-09-21 Thread Jakub Kicinski
On Tue, 20 Sep 2016 17:01:39 -0700, Alexei Starovoitov wrote: > > - Reduces the amount of code and complexity needed in drivers to > >manage XDP > > hmm: > 534 insertions(+), 144 deletions(-) > looks like increase in complexity instead. and more to come to tie this with HW offloads.

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

2016-09-21 Thread Jakub Kicinski
On Wed, 21 Sep 2016 13:55:45 +0200, Thomas Graf wrote: > > I am looking at using this for ILA router. The problem I am hitting is > > that not all packets that we need to translate go through the XDP > > path. Some would go through the kernel path, some through XDP path but > > When you say kern

[PATCH net-next 1/3] net/socket: factor out helpers for memory and queue manipulation

2016-09-21 Thread Paolo Abeni
Basic sock operations that udp code can use with its own memory accounting schema. No functional change is introduced in the existing APIs. Acked-by: Hannes Frederic Sowa Signed-off-by: Paolo Abeni --- include/linux/skbuff.h | 2 +- include/net/sock.h | 5 +++ net/core/datagram.c| 36

[PATCH net-next 3/3] udp: use it's own memory accounting schema

2016-09-21 Thread Paolo Abeni
Completely avoid default sock memory accounting and replace it with udp-specific accounting. Since the new memory accounting model does not require socket locking, remove the lock on enqueue and free and avoid using the backlog on enqueue. Be sure to clean-up rx queue memory on socket destruction

[PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-21 Thread Paolo Abeni
Avoid usage of common memory accounting functions, since the logic is pretty much different. To account for forward allocation, a couple of new atomic_t members are added to udp_sock: 'mem_alloced' and 'mem_freed'. The current forward allocation is estimated as 'mem_alloced' minus 'mem_freed' min

[PATCH net-next 0/3] udp: refactor memory accounting

2016-09-21 Thread Paolo Abeni
This patch series refactor the udp memory accounting, replacing the generic implementation with a custom one, in order to remove the needs for locking the socket on the enqueue and dequeue operations. The socket backlog usage is dropped, as well. The first patch factor out core pieces of some queu

Re: [ANNOUNCE] ndiv: line-rate network traffic processing

2016-09-21 Thread Tom Herbert
On Wed, Sep 21, 2016 at 4:28 AM, Willy Tarreau wrote: > Hi, > > Over the last 3 years I've been working a bit on high traffic processing > for various reasons. It started with the wish to capture line-rate GigE > traffic on very small fanless ARM machines and the framework has evolved > to be used

Re: [PATCH net-next V2] net/vxlan: Avoid unaligned access in vxlan_build_skb()

2016-09-21 Thread Alexei Starovoitov
On Wed, Sep 21, 2016 at 09:53:31AM -0700, Eric Dumazet wrote: > On Wed, 2016-09-21 at 09:14 -0700, Alexei Starovoitov wrote: > > > > > I think it's the opposite. Even on x86 compiler will use byte loads. > > Unless you tweaked gcc, it should still use word loads on x86. > checked that on x86-64

  1   2   3   >