[PATCH net-next] rxrpc: Make IPv6 support conditional on CONFIG_IPV6

2016-09-16 Thread David Howells
Add CONFIG_AF_RXRPC_IPV6 and make the IPv6 support code conditional on it. This is then made conditional on CONFIG_IPV6. Without this, the following can be seen: net/built-in.o: In function `rxrpc_init_peer': >> peer_object.c:(.text+0x18c3c8): undefined reference to >> `ip6_route_output_flags

[PATCH net-next] chcr/cxgb4i/cxgbit/RDMA/cxgb4: Allocate resources dynamically for all cxgb4 ULD's

2016-09-16 Thread Hariprasad Shenai
Allocate resources dynamically to cxgb4's Upper layer driver's(ULD) like cxgbit, iw_cxgb4 and cxgb4i. Allocate resources when they register with cxgb4 driver and free them while unregistering. All the queues and the interrupts for them will be allocated during ULD probe only and freed during remove

Re: [PATCHv5 net-next 05/15] bpf: expose internal verfier structures

2016-09-16 Thread Daniel Borkmann
On 09/16/2016 11:36 AM, Jakub Kicinski wrote: Move verifier's internal structures to a header file and prefix their names with bpf_ to avoid potential namespace conflicts. Those structures will soon be used by external analyzers. Signed-off-by: Jakub Kicinski Acked-by: Alexei Starovoitov Ac

Re: [PATCHv5 net-next 06/15] bpf: enable non-core use of the verfier

2016-09-16 Thread Daniel Borkmann
On 09/16/2016 11:36 AM, Jakub Kicinski wrote: Advanced JIT compilers and translators may want to use eBPF verifier as a base for parsers or to perform custom checks and validations. Add ability for external users to invoke the verifier and provide callbacks to be invoked for every intruction che

Re: Modification to skb->queue_mapping affecting performance

2016-09-16 Thread Michael Ma
2016-09-16 12:53 GMT-07:00 Eric Dumazet : > On Fri, 2016-09-16 at 10:57 -0700, Michael Ma wrote: > >> This is actually the problem - if flows from different RX queues are >> switched to the same RX queue in IFB, they'll use different processor >> context with the same tasklet, and the processor con

[PATCH net-next 2/2] bnx2x: allocate mac filtering pending list in PAGE_SIZE increments

2016-09-16 Thread Jason Baron
Currently, we can have high order page allocations that specify GFP_ATOMIC when configuring multicast MAC address filters. For example, we have seen order 2 page allocation failures with ~500 multicast addresses configured. Convert the allocation for the pending list to be done in PAGE_SIZE incre

Re: [PATCH net-next 07/14] tcp: export data delivery rate

2016-09-16 Thread kbuild test robot
Hi Yuchung, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323 config: arm-simpad_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce:

Re: [PATCH net-next 05/14] tcp: track data delivery rate for a TCP connection

2016-09-16 Thread kbuild test robot
Hi Yuchung, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323 config: cris-etrax-100lx_v2_defconfig (attached as .config) compiler: cris-linux-gcc (GCC) 6.2.0 reproduce: wget h

Re: [PATCHv5 net-next 07/15] bpf: recognize 64bit immediate loads as consts

2016-09-16 Thread Daniel Borkmann
On 09/16/2016 11:36 AM, Jakub Kicinski wrote: When running as parser interpret BPF_LD | BPF_IMM | BPF_DW instructions as loading CONST_IMM with the value stored in imm. The verifier will continue not recognizing those due to concerns about search space/program complexity increase. Signed-off-by

[PATCH net-next 1/2] bnx2x: allocate mac filtering 'mcast_list' in PAGE_SIZE increments

2016-09-16 Thread Jason Baron
Currently, we can have high order page allocations that specify GFP_ATOMIC when configuring multicast MAC address filters. For example, we have seen order 2 page allocation failures with ~500 multicast addresses configured. Convert the allocation for 'mcast_list' to be done in PAGE_SIZE increment

[PATCH net-next 0/2] bnx2x: page allocation failure

2016-09-16 Thread Jason Baron
Hi, While configuring ~500 multicast addrs, we ran into high order page allocation failures. They don't need to be high order, and thus I'm proposing to split them into at most PAGE_SIZE allocations. Below is a sample failure. Thanks, -Jason [1201902.617882] bnx2x: [bnx2x_set_mc_list:12374(eth

Re: [PATCHv5 net-next 04/15] bpf: don't (ab)use instructions to store state

2016-09-16 Thread Daniel Borkmann
On 09/16/2016 11:36 AM, Jakub Kicinski wrote: Storing state in reserved fields of instructions makes it impossible to run verifier on programs already marked as read-only. Allocate and use an array of per-instruction state instead. While touching the error path rename and move existing jump targ

[PATCH resend] sctp: Remove some redundant code

2016-09-16 Thread Christophe JAILLET
In commit 311b21774f13 ("sctp: simplify sk_receive_queue locking"), a call to 'skb_queue_splice_tail_init()' has been made explicit. Previously it was hidden in 'sctp_skb_list_tail()' Now, the code around it looks redundant. The '_init()' part of 'skb_queue_splice_tail_init()' should already do th

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Brenden Blanco
On Fri, Sep 16, 2016 at 10:36:12PM +0200, Jesper Dangaard Brouer wrote: > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS. > > Fixes: 9ecc2d

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
On Fri, 16 Sep 2016 22:36:12 +0200 Jesper Dangaard Brouer wrote: > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS. Ups, forgot to add the

[net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
The XDP_TX action can fail transmitting the frame in case the TX ring is full or port is down. In case of TX failure it should drop the frame, and not as now call 'break' which is the same as XDP_PASS. Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support") Signed-off-by: J

[v2] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-16 Thread Vincent Bernat
Commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups") introduced a regression: insertion of an IPv6 route in a table not containing the appropriate connected route for the gateway but which contained a non-connected route (like a default gateway) fails while it was previously w

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
On Fri, 16 Sep 2016 13:00:50 -0700 Eric Dumazet wrote: > > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c > > b/drivers/net/ethernet/mellanox/mlx4/en_rx.c > > index 2040dad8611d..d414c67dfd12 100644 > > --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c > > +++ b/drivers/net/ethernet/mell

[PATCH v4 net 1/1] net sched actions: fix GETing actions

2016-09-16 Thread Jamal Hadi Salim
From: Jamal Hadi Salim With the batch changes that translated transient actions into a temporary list lost in the translation was the fact that tcf_action_destroy() will eventually delete the action from the permanent location if the refcount is zero. Example of what broke: ...add a gact action

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

2016-09-16 Thread Tejun Heo
Hello, On Tue, Sep 13, 2016 at 08:14:40PM +0200, Jiri Slaby wrote: > I assume Dmitry sees the same what I am still seeing, so I reported this > some time ago: > https://lkml.org/lkml/2016/3/21/492 > > This warning is trigerred there and still occurs with "HEAD": > (pwq != wq->dfl_pwq) && (pwq->

Re: [PATCH net-next 07/14] tcp: export data delivery rate

2016-09-16 Thread Eric Dumazet
On Fri, Sep 16, 2016 at 1:03 PM, Neal Cardwell wrote: > > Looks like 'rate' should be 'rate64'. I will include this fix in the > next version of the patch series. > > neal Oh, right you are !

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread Cyrill Gorcunov
On Fri, Sep 16, 2016 at 01:55:42PM -0600, David Ahern wrote: > >> Since the display is showing sockets in addition to IPPROTO_RAW: > >> > >> $ ss -A raw > >> State Recv-Q Send-QLocal Address:Port > >> Peer Address:Port > >> UNCONN 0 0

Re: [PATCH net-next 07/14] tcp: export data delivery rate

2016-09-16 Thread Neal Cardwell
On Fri, Sep 16, 2016 at 11:56 PM, kbuild test robot wrote: > >>> net/ipv4/tcp.c:2794:3: note: in expansion of macro 'do_div' > do_div(rate, intv); > ^~ >In file included from arch/arm/include/asm/div64.h:126:0, > from include/linux/kernel.h:142, >

Re: [PATCH net-next 07/14] tcp: export data delivery rate

2016-09-16 Thread Eric Dumazet
On Sat, 2016-09-17 at 11:56 +0800, kbuild test robot wrote: > Hi Yuchung, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323 > config: arm-nhk8815_defconfig (attached as .config)

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Eric Dumazet
On Fri, 2016-09-16 at 21:47 +0200, Jesper Dangaard Brouer wrote: > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS. > > Fixes: 9ecc2d86171a

[PATCHv4 next 2/3] net: Add _nf_(un)register_hooks symbols

2016-09-16 Thread Mahesh Bandewar
From: Mahesh Bandewar Add _nf_register_hooks() and _nf_unregister_hooks() calls which allow caller to hold RTNL mutex. Signed-off-by: Mahesh Bandewar CC: Pablo Neira Ayuso --- include/linux/netfilter.h | 2 ++ net/netfilter/core.c | 51 ++- 2

[PATCHv4 next 3/3] ipvlan: Introduce l3s mode

2016-09-16 Thread Mahesh Bandewar
From: Mahesh Bandewar In a typical IPvlan L3 setup where master is in default-ns and each slave is into different (slave) ns. In this setup egress packet processing for traffic originating from slave-ns will hit all NF_HOOKs in slave-ns as well as default-ns. However same is not true for ingress

[PATCHv4 next 1/3] ipv6: Export p6_route_input_lookup symbol

2016-09-16 Thread Mahesh Bandewar
From: Mahesh Bandewar Make ip6_route_input_lookup available outside of ipv6 the module similar to ip_route_input_noref in the IPv4 world. Signed-off-by: Mahesh Bandewar --- include/net/ip6_route.h | 3 +++ net/ipv6/route.c| 7 --- 2 files changed, 7 insertions(+), 3 deletions(-) d

[PATCHv4 next 0/3] IPvlan introduce l3s mode

2016-09-16 Thread Mahesh Bandewar
From: Mahesh Bandewar Same old problem with new approach especially from suggestions from earlier patch-series. First thing is that this is introduced as a new mode rather than modifying the old (L3) mode. So the behavior of the existing modes is preserved as it is and the new L3s mode obeys ipt

Re: [PATCH v5 0/6] Add eBPF hooks for cgroups

2016-09-16 Thread Sargun Dhillon
On Wed, Sep 14, 2016 at 01:13:16PM +0200, Daniel Mack wrote: > Hi Pablo, > > On 09/13/2016 07:24 PM, Pablo Neira Ayuso wrote: > > On Tue, Sep 13, 2016 at 03:31:20PM +0200, Daniel Mack wrote: > >> On 09/13/2016 01:56 PM, Pablo Neira Ayuso wrote: > >>> On Mon, Sep 12, 2016 at 06:12:09PM +0200, Danie

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread David Ahern
On 9/16/16 1:52 PM, Cyrill Gorcunov wrote: > On Fri, Sep 16, 2016 at 01:47:57PM -0600, David Ahern wrote: I'm guessing you passed IPPROTO_RAW (255) as the protocol to socket(). If you pass something else (IPPROTO_ICMP for example) it won't work. >>> >>> True. To support IPPROTO

Re: Modification to skb->queue_mapping affecting performance

2016-09-16 Thread Eric Dumazet
On Fri, 2016-09-16 at 10:57 -0700, Michael Ma wrote: > This is actually the problem - if flows from different RX queues are > switched to the same RX queue in IFB, they'll use different processor > context with the same tasklet, and the processor context of different > tasklets might be the same.

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread Cyrill Gorcunov
On Fri, Sep 16, 2016 at 01:47:57PM -0600, David Ahern wrote: > >> > >> I'm guessing you passed IPPROTO_RAW (255) as the protocol to socket(). If > >> you pass something > >> else (IPPROTO_ICMP for example) it won't work. > > > > True. To support IPPROTO_ICMP it need enhancement. I thought start w

Re: [PATCH net-next 07/14] tcp: export data delivery rate

2016-09-16 Thread kbuild test robot
Hi Yuchung, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323 config: arm-nhk8815_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread David Ahern
On 9/16/16 1:39 PM, Cyrill Gorcunov wrote: > On Fri, Sep 16, 2016 at 01:30:28PM -0600, David Ahern wrote: >>> [root@pcs7 iproute2]# misc/ss -A raw >>> State Recv-Q Send-QLocal Address:Port >>>Peer Address:Port

[net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
The XDP_TX action can fail transmitting the frame in case the TX ring is full or port is down. In case of TX failure it should drop the frame, and not as now call 'break' which is the same as XDP_PASS. Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support") Signed-off-by: J

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread Cyrill Gorcunov
On Fri, Sep 16, 2016 at 01:30:28PM -0600, David Ahern wrote: > > [root@pcs7 iproute2]# misc/ss -A raw > > State Recv-Q Send-QLocal Address:Port > >Peer Address:Port > > > > ESTAB 0 0

Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-16 Thread David Ahern
On 9/16/16 1:15 PM, Vincent Bernat wrote: >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >> index ad4a7ff301fc..48bae2ee2e18 100644 >> --- a/net/ipv6/route.c >> +++ b/net/ipv6/route.c >> @@ -1991,9 +1991,19 @@ static struct rt6_info *ip6_route_info_create(struct >> fib6_config *cfg) >>

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread David Ahern
On 9/16/16 1:00 PM, Cyrill Gorcunov wrote: > I created veth pair and bound raw socket into it. > > [root@pcs7 iproute2]# misc/ss -A raw > State Recv-Q Send-QLocal Address:Port > Peer Address:Port

Re: [PATCH net-next 02/14] tcp: use windowed min filter library for TCP min_rtt estimation

2016-09-16 Thread Neal Cardwell
On Fri, Sep 16, 2016 at 3:21 PM, kbuild test robot wrote: > All errors (new ones prefixed by >>): > >>> net/ipv4/tcp_cdg.c:59:8: error: redefinition of 'struct minmax' > struct minmax { >^~ >In file included from include/linux/tcp.h:22:0, > from include/

Re: XDP_TX bug report on mlx4

2016-09-16 Thread Jesper Dangaard Brouer
On Fri, 16 Sep 2016 12:17:27 -0700 Brenden Blanco wrote: > On Fri, Sep 16, 2016 at 09:03:40PM +0200, Jesper Dangaard Brouer wrote: > > Hi Brenden, > > > > I've discovered a bug with XDP_TX recycling of pages in the mlx4 driver. > > > > If I increase the number of RX and TX queues/channels via e

Re: [PATCH net-next 02/14] tcp: use windowed min filter library for TCP min_rtt estimation

2016-09-16 Thread kbuild test robot
Hi Neal, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Neal-Cardwell/tcp-BBR-congestion-control-algorithm/20160917-025323 config: x86_64-randconfig-x006-201637 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: #

Re: XDP_TX bug report on mlx4

2016-09-16 Thread Brenden Blanco
On Fri, Sep 16, 2016 at 09:03:40PM +0200, Jesper Dangaard Brouer wrote: > Hi Brenden, > > I've discovered a bug with XDP_TX recycling of pages in the mlx4 driver. > > If I increase the number of RX and TX queues/channels via ethtool cmd: > ethtool -L mlx4p1 rx 10 tx 10 > > Then when running the

Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-16 Thread Vincent Bernat
❦ 16 septembre 2016 20:36 CEST, David Ahern  : >> contained a non-connected route (like a default gateway) fails while it >> was previously working: >> >> $ ip link add eth0 type dummy >> $ ip link set up dev eth0 >> $ ip addr add 2001:db8::1/64 dev eth0 >> $ ip route add ::/0 vi

XDP_TX bug report on mlx4

2016-09-16 Thread Jesper Dangaard Brouer
Hi Brenden, I've discovered a bug with XDP_TX recycling of pages in the mlx4 driver. If I increase the number of RX and TX queues/channels via ethtool cmd: ethtool -L mlx4p1 rx 10 tx 10 Then when running the xdp2 program, which does XDP_TX, the kernel will crash with page errors, because the pa

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

2016-09-16 Thread Cyrill Gorcunov
On Fri, Sep 16, 2016 at 10:06:23AM +0300, Cyrill Gorcunov wrote: > On Thu, Sep 15, 2016 at 05:45:02PM -0600, David Ahern wrote: > > > > > > Try to be selective in the -K , do not kill tcp sockets ? > > > > I am running > >ss -aKw 'dev == red' > > > > to kill raw sockets bound to device named

[PATCH net-next 13/14] tcp: increase ICSK_CA_PRIV_SIZE from 64 bytes to 88

2016-09-16 Thread Neal Cardwell
The TCP CUBIC module already uses 64 bytes. The upcoming TCP BBR module uses 88 bytes. Signed-off-by: Van Jacobson Signed-off-by: Neal Cardwell Signed-off-by: Yuchung Cheng Signed-off-by: Nandita Dukkipati Signed-off-by: Eric Dumazet Signed-off-by: Soheil Hassas Yeganeh --- include/net/inet

[PATCH net-next 09/14] tcp: export tcp_tso_autosize() and parameterize minimum number of TSO segments

2016-09-16 Thread Neal Cardwell
To allow congestion control modules to use the default TSO auto-sizing algorithm as one of the ingredients in their own decision about TSO sizing: 1) Export tcp_tso_autosize() so that CC modules can use it. 2) Change tcp_tso_autosize() to allow callers to specify a minimum number of segments p

[PATCH net-next 12/14] tcp: new CC hook to set sending rate with rate_sample in any CA state

2016-09-16 Thread Neal Cardwell
From: Yuchung Cheng This commit introduces an optional new "omnipotent" hook, cong_control(), for congestion control modules. The cong_control() function is called at the end of processing an ACK (i.e., after updating sequence numbers, the SACK scoreboard, and loss detection). At that moment we h

[PATCH net-next 06/14] tcp: track application-limited rate samples

2016-09-16 Thread Neal Cardwell
From: Soheil Hassas Yeganeh This commit adds code to track whether the delivery rate represented by each rate_sample was limited by the application. Upon each transmit, we store in the is_app_limited field in the skb a boolean bit indicating whether there is a known "bubble in the pipe": a point

[PATCH net-next 05/14] tcp: track data delivery rate for a TCP connection

2016-09-16 Thread Neal Cardwell
From: Yuchung Cheng This patch generates data delivery rate (throughput) samples on a per-ACK basis. These rate samples can be used by congestion control modules, and specifically will be used by TCP BBR in later patches in this series. Key state: tp->delivered: Tracks the total number of data

[PATCH net-next 03/14] net_sched: sch_fq: add low_rate_threshold parameter

2016-09-16 Thread Neal Cardwell
From: Eric Dumazet This commit adds to the fq module a low_rate_threshold parameter to insert a delay after all packets if the socket requests a pacing rate below the threshold. This helps achieve more precise control of the sending rate with low-rate paths, especially policers. The basic issue

[PATCH net-next 14/14] tcp_bbr: add BBR congestion control

2016-09-16 Thread Neal Cardwell
This commit implements a new TCP congestion control algorithm: BBR (Bottleneck Bandwidth and RTT). A detailed description of BBR will be published in ACM Queue, Vol. 14 No. 5, September-October 2016, as "BBR: Congestion-Based Congestion Control". BBR has significantly increased throughput and redu

[PATCH net-next 08/14] tcp: allow congestion control module to request TSO skb segment count

2016-09-16 Thread Neal Cardwell
Add the tso_segs_goal() function in tcp_congestion_ops to allow the congestion control module to specify the number of segments that should be in a TSO skb sent by tcp_write_xmit() and tcp_xmit_retransmit_queue(). The congestion control module can either request a particular number of segments in T

[PATCH net-next 07/14] tcp: export data delivery rate

2016-09-16 Thread Neal Cardwell
From: Yuchung Cheng This commit export two new fields in struct tcp_info: tcpi_delivery_rate: The most recent goodput, as measured by tcp_rate_gen(). If the socket is limited by the sending application (e.g., no data to send), it reports the highest measurement instead of the most

[PATCH net-next 04/14] tcp: count packets marked lost for a TCP connection

2016-09-16 Thread Neal Cardwell
Count the number of packets that a TCP connection marks lost. Congestion control modules can use this loss rate information for more intelligent decisions about how fast to send. Specifically, this is used in TCP BBR policer detection. BBR uses a high packet loss rate as one signal in its policer

[PATCH net-next 10/14] tcp: export tcp_mss_to_mtu() for congestion control modules

2016-09-16 Thread Neal Cardwell
Export tcp_mss_to_mtu(), so that congestion control modules can use this to help calculate a pacing rate. Signed-off-by: Van Jacobson Signed-off-by: Neal Cardwell Signed-off-by: Yuchung Cheng Signed-off-by: Nandita Dukkipati Signed-off-by: Eric Dumazet Signed-off-by: Soheil Hassas Yeganeh --

[PATCH net-next 11/14] tcp: allow congestion control to expand send buffer differently

2016-09-16 Thread Neal Cardwell
From: Yuchung Cheng Currently the TCP send buffer expands to twice cwnd, in order to allow limited transmits in the CA_Recovery state. This assumes that cwnd does not increase in the CA_Recovery. For some congestion control algorithms, like the upcoming BBR module, if the losses in recovery do n

[PATCH net-next 02/14] tcp: use windowed min filter library for TCP min_rtt estimation

2016-09-16 Thread Neal Cardwell
Refactor the TCP min_rtt code to reuse the new win_minmax library in lib/win_minmax.c to simplify the TCP code. This is a pure refactor: the functionality is exactly the same. We just moved the windowed min code to make TCP easier to read and maintain, and to allow other parts of the kernel to use

[PATCH net-next 01/14] lib/win_minmax: windowed min or max estimator

2016-09-16 Thread Neal Cardwell
This commit introduces a generic library to estimate either the min or max value of a time-varying variable over a recent time window. This is code originally from Kathleen Nichols. The current form of the code is from Van Jacobson. A single struct minmax_sample will track the estimated windowed-m

[PATCH net-next 00/14] tcp: BBR congestion control algorithm

2016-09-16 Thread Neal Cardwell
tcp: BBR congestion control algorithm This patch series implements a new TCP congestion control algorithm: BBR (Bottleneck Bandwidth and RTT). A paper with a detailed description of BBR will be published in ACM Queue, September-October 2016, as "BBR: Congestion-Based Congestion Control". BBR is wi

Re: [ethtool PATCH v1] ethtool: Document ethtool advertised speeds for 1G/10G

2016-09-16 Thread John W. Linville
On Tue, Sep 06, 2016 at 04:55:11PM -0700, Vidya Sagar Ravipati wrote: > From: Vidya Sagar Ravipati > > Man page update to include updated advertised speeds for > 1G/10G > > Signed-off-by: Vidya Sagar Ravipati Applied, thanks! -- John W. LinvilleSomeday the world will need a h

Re: [PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-16 Thread David Ahern
On 9/16/16 6:55 AM, Vincent Bernat wrote: > Commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop > lookups") introduced a regression: insertion of an IPv6 route in a table > not containing the appropriate connected route for the gateway but which > contained a non-connected route (like

Re: [PATCHv1] sunrpc: fix write space race causing stalls

2016-09-16 Thread Trond Myklebust
> On Sep 16, 2016, at 13:29, David Vrabel wrote: > > On 16/09/16 18:06, Trond Myklebust wrote: >> >>> On Sep 16, 2016, at 12:41, David Vrabel wrote: >>> >>> On 16/09/16 17:01, Trond Myklebust wrote: > On Sep 16, 2016, at 08:28, David Vrabel wrote: > > Write space becoming

Re: Modification to skb->queue_mapping affecting performance

2016-09-16 Thread Michael Ma
2016-09-15 17:51 GMT-07:00 Michael Ma : > 2016-09-14 10:46 GMT-07:00 Michael Ma : >> 2016-09-13 22:22 GMT-07:00 Eric Dumazet : >>> On Tue, 2016-09-13 at 22:13 -0700, Michael Ma wrote: >>> I don't intend to install multiple qdisc - the only reason that I'm doing this now is to leverage MQ

Re: [PATCHv3 next 3/3] ipvlan: Introduce l3s mode

2016-09-16 Thread महेश बंडेवार
On Thu, Sep 15, 2016 at 6:49 PM, David Ahern wrote: > On 9/15/16 6:14 PM, Mahesh Bandewar wrote: >> diff --git a/drivers/net/ipvlan/ipvlan.h b/drivers/net/ipvlan/ipvlan.h >> index 695a5dc9ace3..371f4548c42d 100644 >> --- a/drivers/net/ipvlan/ipvlan.h >> +++ b/drivers/net/ipvlan/ipvlan.h >> @@ -23,

Re: [PATCHv1] sunrpc: fix write space race causing stalls

2016-09-16 Thread David Vrabel
On 16/09/16 18:06, Trond Myklebust wrote: > >> On Sep 16, 2016, at 12:41, David Vrabel wrote: >> >> On 16/09/16 17:01, Trond Myklebust wrote: >>> On Sep 16, 2016, at 08:28, David Vrabel wrote: Write space becoming available may race with putting the task to sleep in xprt_wait

Re: [netfilter-core] [lkp] [netfilter] 68263ddb47: WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_seqadj.c:232 nf_ct_seq_offset+0x7a/0x9a

2016-09-16 Thread Florian Westphal
Gao Feng wrote: > > [ 23.465616] [ cut here ] > > [ 23.466477] WARNING: CPU: 0 PID: 1225 at > > net/netfilter/nf_conntrack_seqadj.c:232 > > nf_ct_seq_offset+0x7a/0x9a > > [ 23.468458] Missing nfct_seqadj_ext_add() setup call > > > > It should be that nf_ct_add_synpr

Re: [PATCHv1] sunrpc: fix write space race causing stalls

2016-09-16 Thread Trond Myklebust
> On Sep 16, 2016, at 12:41, David Vrabel wrote: > > On 16/09/16 17:01, Trond Myklebust wrote: >> >>> On Sep 16, 2016, at 08:28, David Vrabel wrote: >>> >>> Write space becoming available may race with putting the task to sleep >>> in xprt_wait_for_buffer_space(). The existing mechanism to a

Re: [PATCH][V2] net: r6040: add in missing white space in error message text

2016-09-16 Thread Florian Fainelli
On 09/16/2016 02:43 AM, Colin King wrote: > From: Colin Ian King > > A couple of dev_err messages span two lines and the literal > string is missing a white space between words. Add the white > space and join the two lines into one. > > Signed-off-by: Colin Ian King Acked-by: FLorian Fainelli

RE: [PATCH v4 00/16] Add Paravirtual RDMA Driver

2016-09-16 Thread Woodruff, Robert J
Jason wrote, >I should be clearer here. I am *strongly* opposed to anything that changes the >license of the existing 4 core libraries away from the >GPLv2 or OpenIB.org situation we have today. (that includes to other varients >of the BSD license) >I just checked and we appear to be completely

Re: [PATCHv1] sunrpc: fix write space race causing stalls

2016-09-16 Thread David Vrabel
On 16/09/16 17:01, Trond Myklebust wrote: > >> On Sep 16, 2016, at 08:28, David Vrabel wrote: >> >> Write space becoming available may race with putting the task to sleep >> in xprt_wait_for_buffer_space(). The existing mechanism to avoid the >> race does not work. >> >> This (edited) partial tr

Re: [PATCH v4 00/16] Add Paravirtual RDMA Driver

2016-09-16 Thread Jason Gunthorpe
On Wed, Sep 14, 2016 at 04:59:10PM -0600, Jason Gunthorpe wrote: > > package follows that licensing model for accepting any new code into > > that combined repo ? > > As with the kernel we'd discourage 're-licensing' existing files. > > However, since this is not a OFA project, I, personally, wo

Re: [PATCH] net: ipv6: Disable forwarding per interface via sysctl

2016-09-16 Thread Mike Manning
On 09/16/2016 04:46 PM, Hannes Frederic Sowa wrote: > On 16.09.2016 15:39, Eric Dumazet wrote: >> On Fri, 2016-09-16 at 13:47 +0100, Mike Manning wrote: >>> Disabling forwarding per interface via sysctl continues to allow >>> forwarding. This is contrary to the sysctl documentation stating that >>>

Re: [PATCHv1] sunrpc: fix write space race causing stalls

2016-09-16 Thread Trond Myklebust
> On Sep 16, 2016, at 08:28, David Vrabel wrote: > > Write space becoming available may race with putting the task to sleep > in xprt_wait_for_buffer_space(). The existing mechanism to avoid the > race does not work. > > This (edited) partial trace illustrates the problem: > > [1] rpc_task_

Re: [PATCH] net: ipv6: Disable forwarding per interface via sysctl

2016-09-16 Thread Hannes Frederic Sowa
On 16.09.2016 15:39, Eric Dumazet wrote: > On Fri, 2016-09-16 at 13:47 +0100, Mike Manning wrote: >> Disabling forwarding per interface via sysctl continues to allow >> forwarding. This is contrary to the sysctl documentation stating that >> the forwarding sysctl is per interface, whereas currently

Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

2016-09-16 Thread Nicolas Dichtel
Le 16/09/2016 à 15:18, Anton Aksola a écrit : [snip] > Nicolas, > This seems to be caused by netns_add calling unshare(CLONE_NEWNET). > If we initialize the socket for nsid after that it doesn't seem to work. > > Unfortunately I'm not an expert in these details. Should we separate the > socket and

[PATCH 0/2] cxgb4 FR_NSMR_TPTE_WR support

2016-09-16 Thread Steve Wise
This series enables a new work request to optimize small REG_MR operations. This is intended for 4.9. If everyone agrees, I suggest Doug take both the cxgb4 and iw_cxgb4 patches through his tree. Thanks, Steve. --- Steve Wise (2): cxgb4: advertise support for FR_NSMR_TPTE_WR iw_cxgb4: add

[PATCH 1/2] cxgb4: advertise support for FR_NSMR_TPTE_WR

2016-09-16 Thread Steve Wise
Query firmware for the FW_PARAMS_PARAM_DEV_RI_FR_NSMR_TPTE_WR parameter. If it exists and is 1, then advertise support for FR_NSMR_TPTE_WR to the ULDs. Signed-off-by: Steve Wise --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 7 +++

[PATCH 2/2] iw_cxgb4: add fast-path for small REG_MR operations

2016-09-16 Thread Steve Wise
When processing a REG_MR work request, if fw supports the FW_RI_NSMR_TPTE_WR work request, and if the page list for this registration is <= 2 pages, and the current state of the mr is INVALID, then use FW_RI_NSMR_TPTE_WR to pass down a fully populated TPTE for FW to write. This avoids FW having to

[lkp] [netfilter] 68263ddb47: WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_seqadj.c:232 nf_ct_seq_offset+0x7a/0x9a

2016-09-16 Thread kernel test robot
FYI, we noticed the following commit: https://github.com/0day-ci/linux fgao-ikuai8-com/netfilter-seqadj-Fix-some-possible-panics-of-seqadj-when-mem-is-exhausted/20160902-095727 commit 68263ddb4777cc996868498e3d56f616851966d2 ("netfilter: seqadj: Fix some possible panics of seqadj when mem is ex

[lkp] [net] 70a8118a03: BUG: workqueue leaked lock or atomic: kworker/0:1/0x00000000/28

2016-09-16 Thread kernel test robot
FYI, we noticed the following commit: https://github.com/0day-ci/linux Christophe-JAILLET/net-inet-diag-Fix-an-error-handling/20160912-140503 commit 70a8118a03243de2aba508d79cc1a042db094191 ("net: inet: diag: Fix an error handling") in testcase: boot on test machine: qemu-system-x86_64 -enabl

drr scheduler [mis]configuration question

2016-09-16 Thread Michal Soltys
Hi, I have hit some weird (probably missing some detail) issue with drr. Originally it was tested between two machines, then I quickly double checked between namespaces (same behaviour) - the configuration follows: # setup namespace ip netns add drrtest ip li add name left type veth peer name ri

Re: [PATCH] net: ipv6: Disable forwarding per interface via sysctl

2016-09-16 Thread Eric Dumazet
On Fri, 2016-09-16 at 13:47 +0100, Mike Manning wrote: > Disabling forwarding per interface via sysctl continues to allow > forwarding. This is contrary to the sysctl documentation stating that > the forwarding sysctl is per interface, whereas currently it is only > the sysctl for all interfaces th

[net-next:master 58/374] drivers/net/ethernet/amazon/ena/ena_netdev.c:3026:1-11: Use setup_timer function for function on line 3028.

2016-09-16 Thread Julia Lawall
Setup_timer could be used instead of the cvall to init_timer and the initializations of the function and data fields. julia tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 84ce3da1bfd6fd12fce3cd06691e405a36f72cde commit: 1738cd3ed342294360d6a74d4e588000

Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

2016-09-16 Thread Anton Aksola
On Fri, Sep 16, 2016 at 11:13:11AM +0200, Nicolas Dichtel wrote: > There is still some differences: > $ cat test.batch > netns add foo > netns set foo 1234 > netns list-id > > Before your patch: > $ ip -b test.batch > nsid 1234 (iproute2 netns name: foo) > > After your patch: > $ ip -b test.batch >

Re: [PATCH net] sctp: fix SSN comparision

2016-09-16 Thread Neil Horman
On Thu, Sep 15, 2016 at 03:02:38PM -0300, Marcelo Ricardo Leitner wrote: > This function actually operates on u32 yet its paramteres were declared > as u16, causing integer truncation upon calling. > > Note in patch context that ADDIP_SERIAL_SIGN_BIT is already 32 bits. > > Signed-off-by: Marcelo

[patch net-next v10 3/3] mlxsw: spectrum: Implement offload stats ndo and expose HW stats by default

2016-09-16 Thread Jiri Pirko
From: Nogah Frankel Change the default statistics ndo to return HW statistics (like the one returned by ethtool_ops). The HW stats are collected to a cache by delayed work every 1 sec. Implement the offload stat ndo. Add a function to get SW statistics, to be called from this function. Signed-of

[patch net-next v10 2/3] net: core: Add offload stats to if_stats_msg

2016-09-16 Thread Jiri Pirko
From: Nogah Frankel Add a nested attribute of offload stats to if_stats_msg named IFLA_STATS_LINK_OFFLOAD_XSTATS. Under it, add SW stats, meaning stats only per packets that went via slowpath to the cpu, named IFLA_OFFLOAD_XSTATS_CPU_HIT. Signed-off-by: Nogah Frankel Signed-off-by: Jiri Pirko

[patch net-next v10 0/3] return offloaded stats as default and expose original sw stats

2016-09-16 Thread Jiri Pirko
From: Jiri Pirko From: Jiri Pirko The problem we try to handle is about offloaded forwarded packets which are not seen by kernel. Let me try to draw it: port1 port2 (HW stats are counted here) \ / \/

[patch net-next v10 1/3] netdevice: Add offload statistics ndo

2016-09-16 Thread Jiri Pirko
From: Nogah Frankel Add a new ndo to return statistics for offloaded operation. Since there can be many different offloaded operation with many stats types, the ndo gets an attribute id by which it knows which stats are wanted. The ndo also gets a void pointer to be cast according to the attribut

pull-request: mac80211-next 2016-09-16

2016-09-16 Thread Johannes Berg
Hi Dave, And here's another set for net-next, it's been a month or so and we have a reasonably large number of patches (for a change, mostly because I cleaned up some WEP crypto thing and a few static checkers.) Let me know if there's any problem. Thanks, johannes The following changes since

[PATCH] net: ipv6: fallback to full lookup if table lookup is unsuitable

2016-09-16 Thread Vincent Bernat
Commit 8c14586fc320 ("net: ipv6: Use passed in table for nexthop lookups") introduced a regression: insertion of an IPv6 route in a table not containing the appropriate connected route for the gateway but which contained a non-connected route (like a default gateway) fails while it was previously w

[PATCH] net: ipv6: Disable forwarding per interface via sysctl

2016-09-16 Thread Mike Manning
Disabling forwarding per interface via sysctl continues to allow forwarding. This is contrary to the sysctl documentation stating that the forwarding sysctl is per interface, whereas currently it is only the sysctl for all interfaces that has an effect on forwarding. The solution is to drop any rec

pull-request: mac80211 2016-09-16

2016-09-16 Thread Johannes Berg
Hi Dave, Sorry - I know you only just pulled my tree for the previous fixes, but we found two more problems in the last few days; it'd be great to get those fixes in as well. Let me know if there's any problem. Thanks, johannes The following changes since commit ad5987b47e96a0fb6d13fea250e936

[PATCHv1] sunrpc: fix write space race causing stalls

2016-09-16 Thread David Vrabel
Write space becoming available may race with putting the task to sleep in xprt_wait_for_buffer_space(). The existing mechanism to avoid the race does not work. This (edited) partial trace illustrates the problem: [1] rpc_task_run_action: task:43546@5 ... action=call_transmit [2] xs_write_s

Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

2016-09-16 Thread Anton Aksola
On Fri, Sep 16, 2016 at 02:25:40PM +0300, Vadim Kochan wrote: > Anton, I just looked into tests after when I did post here. I am not > sure it will be trivial, > currently tests are running within separated network namespace by > default (which I did) via > 'unshare' tool, and now I see that it is

Re: [PATCH] net: ipv6: Failure to disable forwarding per interface via sysctl

2016-09-16 Thread Jiri Pirko
Fri, Sep 16, 2016 at 11:48:10AM CEST, mmann...@brocade.com wrote: >Disabling forwarding per interface via sysctl continues to allow >forwarding. This is contrary to the sysctl documentation stating that >the forwarding sysctl is per interface, whereas currently it is only >the sysctl for all interf

Re: [PATCH next] sctp: make use of WORD_TRUNC macro

2016-09-16 Thread 'Marcelo Ricardo Leitner'
On Fri, Sep 16, 2016 at 09:51:56AM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 15 September 2016 19:13 > > No functional change. Just to avoid the usage of '&~3'. > ... > > - max_data = (asoc->pathmtu - > > - sctp_sk(asoc->base.sk)->pf->af->net_header_len - > >

Re: [PATCH v2] xen-netback: fix error handling on netback_probe()

2016-09-16 Thread Wei Liu
On Thu, Sep 15, 2016 at 05:10:46PM +0200, Filipe Manco wrote: > In case of error during netback_probe() (e.g. an entry missing on the > xenstore) netback_remove() is called on the new device, which will set > the device backend state to XenbusStateClosed by calling > set_backend_state(). However, t

  1   2   >