On Thu, Sep 08, 2016 at 08:37:47AM -0700, Alexander Duyck wrote:
>
> A few minor things.
>
> First you somehow got a couple spaces in the line before gso_size.
> That is why the two lines above don't line up.
>
> Second it occurred to me that we could have a situation where tail is
> equal to se
Thu, Sep 08, 2016 at 06:32:02PM CEST, jasminder.k...@hpe.com wrote:
>>The issue of interfaces being arbitrarily changed or deleted
>> is not specific to bonding, and could affect any networking device (physical
>> or virtual). Thus, if a facility such as this is to be provided, i
In a PowerPc server with large cpu number(160), besides commit
a3a773726c9f ("net: Optimize snmp stat aggregation by walking all
the percpu data at once"), I watched several other snmp_fold_field
callsites which will cause high cache miss rate.
My simple test case, which read from the procfs items
This is to suppress the checkpatch.pl warning "Comparison to NULL
could be written". No functional changes here.
Signed-off-by: Jia He
---
net/ipv4/proc.c | 32
net/sctp/proc.c | 2 +-
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/net/ipv4/pro
This is to use the generic interface snmp_get_cpu_field{,64}_batch to
aggregate the data by going through all the items of each cpu sequentially.
Signed-off-by: Jia He
---
net/ipv6/proc.c | 32 +++-
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/net/i
The parameter items(always ICMP6_MIB_MAX) is useless for __snmp6_fill_statsdev.
Signed-off-by: Jia He
---
net/ipv6/addrconf.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index f418d2e..e170554 100644
--- a/net/ipv6/ad
This is to use the generic interface snmp_get_cpu_field{,64}_batch to
aggregate the data by going through all the items of each cpu sequentially.
Then snmp_seq_show and netstat_seq_show are split into 2 parts to avoid build
warning "the frame size" larger than 1024 on s390.
Signed-off-by: Jia He
This is to use the generic interface snmp_get_cpu_field{,64}_batch to
aggregate the data by going through all the items of each cpu sequentially.
Signed-off-by: Jia He
---
net/xfrm/xfrm_proc.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/net/xfrm/xfrm_proc.c b/n
This is to use the generic interface snmp_get_cpu_field{,64}_batch to
aggregate the data by going through all the items of each cpu sequentially.
Signed-off-by: Jia He
---
net/sctp/proc.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/sctp/proc.c b/net/sctp/proc.
This is to introduced the generic batch interfaces for snmp_get_cpu_field{,64}.
It exchanges the two for-loops for collecting the percpu statistics data.
This can aggregate the data by going through all the items of each cpu
sequentially.
Signed-off-by: Jia He
Suggested-by: Marcelo Ricardo Leitne
On Fri, Sep 09, 2016 at 07:36:52AM +0200, Jesper Dangaard Brouer wrote:
> > > Lets do bundling/bulking from the start!
> >
> > mlx4 already does bulking and this proposed mlx5 set of patches
> > does bulking as well.
> > See nothing wrong about it. RX side processes the packets and
> > when it'
On Thu, Sep 8, 2016 at 10:48 PM, Alexei Starovoitov
wrote:
>
> imo the deliberate small race in Eric's initial lock removal in mirred
> was a good design choice. I think he did this patch only to
> silence the complains with the code instead of arguing with words.
> imo the initial code is good as
Hi Andrew,
Thank you for review the code and valuable comments.
On Thu, Sep 08, 2016 at 03:14:15PM +0200, Andrew Lunn wrote:
> EXTERNAL EMAIL
>
>
> On Thu, Sep 08, 2016 at 02:47:21PM +0530, Raju Lakkaraju wrote:
> > From: Raju Lakkaraju
> >
> > Used Device Tree to configure the Edge-rate as pe
On Thu, Sep 8, 2016 at 8:49 AM, John Fastabend wrote:
> Agreed not sure why you would ever want to do a late binding and
> replace on a tc_mirred actions. But it is supported...
I will let Jamal teach you on this, /me is really tired of explaining
things to you John.
Hi Andrew,
Thank you for review the code and valuable comments.
On Thu, Sep 08, 2016 at 03:27:27PM +0200, Andrew Lunn wrote:
> EXTERNAL EMAIL
>
>
> On Thu, Sep 08, 2016 at 02:47:22PM +0530, Raju Lakkaraju wrote:
> > From: Raju Lakkaraju
> >
> > Used Device Tree to configure the MAC Interface a
On Tue, Sep 6, 2016 at 7:52 AM, Eric Dumazet wrote:
> On Thu, 2016-09-01 at 22:57 -0700, Cong Wang wrote:
>
>
>
> Missing changelog ?
I was too lazy to write a changelog for this RFC patch, surely
it will be added when removing RFC.
>
> Here I have no idea what you want to fix, since John alrea
On Thu, 25 Aug 2016 12:05:33 +0300 Shmulik Ladkani
wrote:
> The BUG occurs when GRO occurs on the ingress, and only if GRO merges
> skbs into the frag_list (OTOH when segments are only placed into frags[]
> of a single skb, skb_segment succeeds even if gso_size was altered).
>
> This is due to a
On Thu, Sep 08, 2016 at 10:24:32PM -0700, Cong Wang wrote:
> On Thu, Sep 8, 2016 at 8:35 AM, Eric Dumazet wrote:
> > From: Eric Dumazet
> >
> > As reported by Cong Wang, I was lazy when I did initial RCU conversion
> > of tc_mirred, as I thought I could avoid allocation/freeing of a
> > parameter
On Thu, 8 Sep 2016 20:22:04 -0700
Alexei Starovoitov wrote:
> On Thu, Sep 08, 2016 at 10:11:47AM +0200, Jesper Dangaard Brouer wrote:
> >
> > I'm sorry but I have a problem with this patch!
>
> is it because the variable is called 'xdp_doorbell'?
> Frankly I see nothing scary in this patch.
>
On Thu, Sep 8, 2016 at 9:15 AM, John Fastabend wrote:
>
> This should be rtnl_derefence(t->params) and drop the read_lock/unlock
> pair. This is always called with RTNL lock unless you have a path I'm
> not seeing.
You missed the previous discussion on V6, John.
BTW, you really should follow the
On Thu, Sep 8, 2016 at 8:51 AM, Eric Dumazet wrote:
> On Thu, 2016-09-08 at 08:47 -0700, John Fastabend wrote:
>
>> Works for me. FWIW I find this plenty straightforward and don't really
>> see the need to make the hash table itself rcu friendly.
>>
>> Acked-by: John Fastabend
>>
>
> Yes, it seem
On Thu, Sep 8, 2016 at 8:35 AM, Eric Dumazet wrote:
> From: Eric Dumazet
>
> As reported by Cong Wang, I was lazy when I did initial RCU conversion
> of tc_mirred, as I thought I could avoid allocation/freeing of a
> parameter block.
Quote from Eric Dumazet:
https://www.mail-archive.com/netdev@
On Fri, Sep 9, 2016 at 9:57 AM, David Miller wrote:
>
> > I'll see if I can send something out to pass in in_skb instead.
>
> The other option is to have a "struct foo_info" object on the callers
> stack that holds all of these values, then pass a pointer to the foo_info
> to inet_sk_diag_fill.
R
On Wed, Sep 7, 2016 at 9:23 AM, John Fastabend wrote:
>
> hmm I'm trying to see where the questionable part is in the current
> code? What is it exactly.
All you need is a google search in netdev:
https://www.mail-archive.com/netdev@vger.kernel.org/msg115480.html
Most of the arguments passed to the various diag_fill functions
are only a couple of pointer lookups away from in_skb. Instead
of passing all the arguments down the call chain, pass around
in_skb and have the fill functions get what they need from that.
This patch does not remove the "bool net_adm
Andy Gross writes:
>> > >> This doesn't compile for me:
>> > >>
>> > >
>> > > I thought I mentioned this in the mail, sorry for missing that.
>> >
>> > Maybe you did and I just forgot, I have a tendency to do that :)
>> >
>> > > There is a patch for this issue in linux-next already [1] which is
On Thu, Sep 08, 2016 at 09:21:59PM -0700, Bjorn Andersson wrote:
> On Thu 08 Sep 10:35 PDT 2016, Kalle Valo wrote:
>
> > Bjorn Andersson writes:
> >
> > > On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo wrote:
> > >> Bjorn Andersson writes:
> > >>
> > >>> The wcn36xx wifi driver follows the life cy
On Tue, 2016-09-06 at 16:28 +0800, Yangbo Lu wrote:
> The global utilities block controls power management, I/O device
> enabling, power-onreset(POR) configuration monitoring, alternate
> function selection for multiplexed signals,and clock control.
>
> This patch adds a driver to manage and acces
On Thu 08 Sep 10:35 PDT 2016, Kalle Valo wrote:
> Bjorn Andersson writes:
>
> > On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo wrote:
> >> Bjorn Andersson writes:
> >>
> >>> The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD
> >>> channel, as such it should be a SMD client. This p
On Thu, Sep 08, 2016 at 10:11:47AM +0200, Jesper Dangaard Brouer wrote:
>
> I'm sorry but I have a problem with this patch!
is it because the variable is called 'xdp_doorbell'?
Frankly I see nothing scary in this patch.
It extends existing code by adding a flag to ring doorbell or not.
The end of
On 9/8/16, 5:23 PM, David Miller wrote:
> From: Stephen Hemminger
> Date: Wed, 7 Sep 2016 13:57:36 -0700
>
>> This structure is defined but never used. Flagged with W=1
>>
>> Signed-off-by: Stephen Hemminger
> This comes from commit 10c9ead9f3c6bb24bddc9a96681f7d58e6623966
> ("rtnetlink: add new
On Thu, 2016-09-08 at 17:35 -0700, Jojy Varghese wrote:
> Thanks for the feedback guys. I appreciate it.
>
> I am working with 4.4.3 kernel. I will try to reproduce the issue
> with the kernel tree at
> https://git.kernel.org/cgit/linux/kernel/git/davem/net.git.
>
Good.
Please do not top post
On 9/7/16, 11:19 PM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> The problem we try to handle is about offloaded forwarded packets
> which are not seen by kernel. Let me try to draw it:
>
> port1 port2 (HW stats are counted here)
> \ /
>
We get a few warnings when building kernel with W=1:
drivers/net/ethernet/qlogic/qed/qed_l2.c:112:5: warning: no previous prototype
for 'qed_sp_vport_start' [-Wmissing-prototypes]
drivers/net/ethernet/qlogic/qed/qed_sriov.c:110:6: warning: no previous
prototype for 'qed_iov_is_valid_vfid' [-Wmiss
On Thu, 8 Sep 2016 12:50:43 -0400
Vivien Didelot wrote:
> If /sbin/bridge-stp is available on the system, bridge tries to execute
> it instead of the kernel implementation when starting/stopping STP.
>
> If anything goes wrong with /sbin/bridge-stp, bridge silently falls back
> to kernel STP, m
From: Lorenzo Colitti
Date: Fri, 9 Sep 2016 09:48:27 +0900
> On Fri, Sep 9, 2016 at 8:13 AM, David Miller wrote:
>>> This adds the capability for a process that has CAP_NET_ADMIN on
>>> a socket to see the socket mark in socket dumps.
>>
>> Applied, but the argument list of inet_sk_diag_fill is
On Tue, 06 Sep 2016 08:08:59 -0700
Jay Vosburgh wrote:
> Kaur, Jasminder wrote:
>
> >From: "Kaur, Jasminder"
> >
> >If a bond is in use such as with IP address configured, removing it
> >can result in application disruptions. If bond is used for cluster
> >communication or network file system
On Fri, Sep 9, 2016 at 8:13 AM, David Miller wrote:
>> This adds the capability for a process that has CAP_NET_ADMIN on
>> a socket to see the socket mark in socket dumps.
>
> Applied, but the argument list of inet_sk_diag_fill is starting to get out
> of control.
I think a lot of the parameters
From: Eric Dumazet
Date: Wed, 07 Sep 2016 21:52:56 -0700
> From: Eric Dumazet
>
> In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as
> ancillary data") Francesco added IP_TOS values specified as integer.
>
> However, kernel sends to userspace (at recvmsg() time) an IP_TOS val
Add BPF_SIZEOF() and BPF_FIELD_SIZEOF() macros to improve the code a bit
which otherwise often result in overly long bytes_to_bpf_size(sizeof())
and bytes_to_bpf_size(FIELD_SIZEOF()) lines. So place them into a macro
helper instead. Moreover, we currently have a BUILD_BUG_ON(BPF_FIELD_SIZEOF())
che
This work adds BPF_CALL_() macros and converts all the eBPF helper functions
to use them, in a similar fashion like we do with SYSCALL_DEFINE() macros
that are used today. Motivation for this is to hide all the register handling
and all necessary casts from the user, so that it is done automaticall
This series contains a couple of misc cleanups and improvements
for BPF helpers. For details please see individual patches. We
let this also sit for a few days with Fengguang's kbuild test
robot, and there were no issues seen (besides one false positive,
see last one for details).
Thanks!
Daniel
When fetching ifindex, we don't need to test dev for being NULL since
we're always guaranteed to have a valid dev for clsact programs. Thus,
avoid this test in fast path.
Signed-off-by: Daniel Borkmann
Acked-by: Alexei Starovoitov
---
net/core/filter.c | 37 +++--
Some minor misc cleanups, f.e. use sizeof(__u32) instead of hardcoding
and in __bpf_skb_max_len(), I missed that we always have skb->dev valid
anyway, so we can drop the unneeded test for dev; also few more other
misc bits addressed here.
Signed-off-by: Daniel Borkmann
Acked-by: Alexei Starovoito
From: Jojy Varghese
Date: Thu, 8 Sep 2016 17:35:08 -0700
> - "dst-ifdown" does not look correct since it will never release
> reference to loopback device.
The routes and packets in the namespace are purged and disappear when
the namespace goes down, and that's how all of the references to the
Thanks for the feedback guys. I appreciate it.
I am working with 4.4.3 kernel. I will try to reproduce the issue
with the kernel tree at
https://git.kernel.org/cgit/linux/kernel/git/davem/net.git.
In the meantime, the only data I have now is :
- "dst-ifdown" does not look correct since it will
From: Daniel Borkmann
Date: Thu, 8 Sep 2016 01:03:42 +0200
> LLVM can generate code that tests for direct packet access via
> skb->data/data_end in a way that currently gets rejected by the
> verifier, example:
...
> The reason why this gets rejected despite a proper test is that we
> currently
From: Nicolas Dichtel
Date: Thu, 8 Sep 2016 16:31:22 +0200
> Le 08/09/2016 à 13:02, Ilpo Järvinen a écrit :
> [snip]
>> Acked-By: Ilpo Järvinen
> Also nitpicking: the end of the email address is missing ;-)
I fixed this up when I applied the patch.
From: Eric Dumazet
Date: Wed, 07 Sep 2016 14:49:28 -0700
> From: Yaogong Wang
>
> Over the years, TCP BDP has increased by several orders of magnitude,
> and some people are considering to reach the 2 Gbytes limit.
>
> Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000
> MS
From: Stephen Hemminger
Date: Wed, 7 Sep 2016 14:07:32 -0700
> The netdevice type structure for macsec was being defined but never used.
> To set the network device type the macro SET_NETDEV_DEVTYPE must be called.
> Compile tested only, I don't use macsec.
>
> Signed-off-by: Stephen Hemminger
From: Stephen Hemminger
Date: Wed, 7 Sep 2016 13:57:36 -0700
> This structure is defined but never used. Flagged with W=1
>
> Signed-off-by: Stephen Hemminger
This comes from commit 10c9ead9f3c6bb24bddc9a96681f7d58e6623966
("rtnetlink: add new RTM_GETSTATS message to dump link stats")
Roopa,
From: Jakub Kicinski
Date: Wed, 7 Sep 2016 19:45:34 +0100
> First patch drops unnecessary version.h includes. Second one
> drops support for pre-release versions of FW ABI. Removing
> FW ABI 0.0 from supported set is particularly good since 0
> could just be uninitialized memory. Last but not
From: thomas.zeitlhofer+l...@ze-it.at
Date: Wed, 7 Sep 2016 20:40:38 +0200
> In case of inter address family tunneling (IPv6 over vti4 or IPv4 over
> vti6), the inbound policy checks in vti_rcv_cb() and vti6_rcv_cb() are
> using the wrong address family. As a result, all inbound inter address
> fa
From: Artem Germanov
Date: Wed, 7 Sep 2016 10:49:36 -0700
> Commit 76174004a0f19785a328f40388e87e982bbf69b9
> (tcp: do not slow start when cwnd equals ssthresh )
> introduced regression in TCP YeAH. Using 100ms delay 1% loss virtual
> ethernet link kernel 4.2 shows bandwidth ~500KB/s for single
On Thu, Sep 8, 2016 at 6:18 AM, Hadar Hen Zion
wrote:
> On Wed, Sep 7, 2016 at 7:27 PM, Cong Wang wrote:
>> Also, ->cleanup() should be called with RTNL, no need to
>> take read lock here.
>
> RTNL lock isn't taken when cleanup is called.
Interesting... Then we have some problem here:
1) On the
From: Eric Garver
Date: Wed, 7 Sep 2016 12:56:56 -0400
> This series adds 802.1ad support to openvswitch. It is a continuation of the
> work originally started by Thomas F Herbert - hence the large rev number.
...
Series applied, thanks.
From: Jojy Varghese
Date: Thu, 8 Sep 2016 16:33:38 -0700
> Sorry last patch was just the delta over my original patch. Here is
> the complete patch:
It looks like you are grasping at straws.
Please slow down and take the time to debug this properly.
All of the mechanisms exist to make these re
On Thu, 2016-09-08 at 16:33 -0700, Jojy Varghese wrote:
> Sorry last patch was just the delta over my original patch. Here is
> the complete patch:
>
> ---
> net/core/dst.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/net/core/dst.c b/net/core/dst.c
> index a16
On Thu, 2016-09-08 at 16:16 -0700, Jojy Varghese wrote:
> The dst's do disappear but the net device does not. A better solution
> is to only hold reference to dst's net device ONLY if it is not a
> loopback device. In the case of the loopback device, we want to do
> only a "put" on it and skip the
Sorry last patch was just the delta over my original patch. Here is
the complete patch:
---
net/core/dst.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/net/core/dst.c b/net/core/dst.c
index a1656e3..f63027e 100644
--- a/net/core/dst.c
+++ b/net/core/dst.c
@@ -433,8 +
The dst's do disappear but the net device does not. A better solution
is to only hold reference to dst's net device ONLY if it is not a
loopback device. In the case of the loopback device, we want to do
only a "put" on it and skip the "hold".
Updating the patch below:
---
net/core/dst.c | 7 +++-
From: Saeed Mahameed
Date: Wed, 7 Sep 2016 19:07:56 +0300
> The following series contains bug fixes for the mlx5e driver.
>
> from Gal,
> - Static code checker cleanup (casting overflow)
> - Fix global PFC counter statistics reading
> - Fix HW LRO when vlan stripping is off
>
From: Lorenzo Colitti
Date: Thu, 8 Sep 2016 00:42:25 +0900
> This adds the capability for a process that has CAP_NET_ADMIN on
> a socket to see the socket mark in socket dumps.
>
> Commit a52e95abf772 ("net: diag: allow socket bytecode filters to
> match socket marks") recently gave privileged
From: Eric Dumazet
Date: Wed, 07 Sep 2016 08:34:11 -0700
> From: Eric Dumazet
>
> When DATA and/or FIN are carried in a SYN/ACK message or SYN message,
> we append an skb in socket receive queue, but we forget to call
> sk_forced_mem_schedule().
>
> Effect is that the socket has a negative sk-
From: Zubair Lutfullah Kakakhel
Date: Thu, 8 Sep 2016 09:17:31 +0100
> Hi,
>
> On 09/08/2016 12:07 AM, David Miller wrote:
>> From: Zubair Lutfullah Kakakhel
>> Date: Mon, 5 Sep 2016 13:07:54 +0100
>>
>>> The MIPS based xilfpga platform uses this driver.
>>> Enable it for MIPS
>>>
>>> Signed-of
From: Eric Dumazet
If skb has a valid l4 hash, there is no point clearing hash and force
a further flow dissection when a tunnel encapsulation is added.
Signed-off-by: Eric Dumazet
---
net/ipv4/ip_tunnel_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ip_
On Thu, 2016-09-08 at 15:12 -0700, Jojy Varghese wrote:
> Hi Eric/Lance
>
> Thanks for taking time to look at the patch. The problem in dst.c's
> "dst_ifdown" is that it will never do an actual "dev_put" on the
> loopback net device. This results in the loopback net device to be
> alive even when
Hi Eric/Lance
Thanks for taking time to look at the patch. The problem in dst.c's
"dst_ifdown" is that it will never do an actual "dev_put" on the
loopback net device. This results in the loopback net device to be
alive even when the dst goes away.
Thanks
Jojy
On Thu, Sep 8, 2016 at 2:05 PM, Er
On Thu, 8 Sep 2016 14:56:34 +0200
Thomas Graf wrote:
> Signed-off-by: Thomas Graf
> ---
> ip/iptuntap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied
On Tue, 6 Sep 2016 14:42:52 +0800
Hangbin Liu wrote:
> Signed-off-by: Hangbin Liu
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+
Applied
On Thu, Sep 8, 2016 at 7:25 AM, Jean Delvare wrote:
> The mdio-xgene driver is only useful on X-Gene SoC.
>
> Signed-off-by: Jean Delvare
> Cc: Iyappan Subramanian
> Cc: David S. Miller
> ---
> drivers/net/phy/Kconfig |1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-4.8-rc5.orig/driver
On Mon, 5 Sep 2016 11:35:02 +0800
Hangbin Liu wrote:
> SCTP module was not load by default. But this should be OK since we will not
> load table if fdopen() failed, also opening the proc file won't load SCTP
> kernel module.
>
> Signed-off-by: Hangbin Liu
Applied thanks.
On 2016-09-08 04:03, Toshiaki Makita wrote:
> On 2016/09/08 3:22, Michal Soltys wrote:
> ...
>> 4.7.2
>> git describe on that commit suggests it's been available since 4.6.x
>>
>> What I did in details:
>>
>> ip li add name port1b type veth peer name port1e
>> ip li add br0 type bridge
>> ip li s
On Thu, 8 Sep 2016 11:30:08 -0700
Florian Fainelli wrote:
> On 09/08/2016 10:19 AM, D. Herrendoerfer wrote:
> >
> > On 08 Sep 2016, at 17:39, Stephen Hemminger
> > wrote:
> >
> >> On Thu, 8 Sep 2016 15:06:16 +0200
> >> "D. Herrendoerfer" wrote:
> >>
> >>> Hello,
> >>>
> >>> I'd like to s
On Thu, 2016-09-08 at 14:00 -0700, Eric Dumazet wrote:
> Latest real fix was :
> https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=751eb6b6042a596b0080967c1a529a9fe98dac1d
Another interesting fix is
https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=a5d0dc
On Thu, 2016-09-08 at 12:08 -0700, Jojy Varghese wrote:
> (Updating the patch for the case when a non-loopback dev could be
> unregistered)
>
> Currently during namespace cleanup, if ‘dst’ subsystem is holding
> a reference to the interface in the namespace, it does not get released.
> Current co
Colin King :
> From: Colin Ian King
>
> tdinfo->skb_dma is a 7 element array of dma_addr_t hence cannot be
> null, so the pull pointer check on tdinfo->skb_dma is redundant.
> Remove it.
>
> Signed-off-by: Colin Ian King
Acked-by: Francois Romieu
--
Ueimor
From: Tariq Toukan
Date: Thu, 8 Sep 2016 11:51:58 +0300
> From: Leon Romanovsky
>
> Radix tree lookup can be performed without locking.
>
> Fixes: 225c7b1feef1 ("IB/mlx4: Add a driver Mellanox ConnectX InfiniBand
> adapters")
> Suggested-by: Sagi Grimberg
> Signed-off-by: Leon Romanovsky
>
From: Tariq Toukan
Date: Thu, 8 Sep 2016 11:51:54 +0300
> From: Kamal Heib
>
> Use tabs instead of spaces before if statement, no functional change.
>
> Fixes: e7c1c2c46201 ("mlx4_en: Added self diagnostics test implementation")
> Signed-off-by: Kamal Heib
> Signed-off-by: Tariq Toukan
Cle
From: Tariq Toukan
Date: Thu, 8 Sep 2016 11:51:53 +0300
> Add likely/unlikely hints to improve branch predictions
> in the RX data-path.
>
> Signed-off-by: Tariq Toukan
This is absolutely not appropriate for 'net'. This is not a bug
fix, it is a feature/enhancement.
From: Steffen Klassert
Date: Thu, 8 Sep 2016 07:54:35 +0200
> 1) Constify the xfrm_replay structures. From Julia Lawall
>
> 2) Protect xfrm state hash tables with rcu, lookups
>can be done now without acquiring xfrm_state_lock.
>From Florian Westphal.
>
> 3) Protect xfrm policy hash tab
--
I need your assistance in making claim to the Bank deposit of a
deceased client of mine because you bear the same sur name . he died
on 12 March 2013. please reply ASAP so i can guard you through.
Sincerely,
David Anthony
> From: "Jojy Varghese"
> To: netdev@vger.kernel.org
> Cc: da...@davemloft.net
> Sent: Thursday, September 8, 2016 3:08:29 PM
> Subject: Re: [PATCH] net_namespace: fixed net_device reference leak
>
> (Updating the patch for the case when a non-loopback dev could be
> unregistered)
>
> Currently
On Thu, Sep 08, 2016 at 05:49:04PM +0800, Xin Long wrote:
> Now sctp uses the transport without holding it in sctp_hash_cmp,
> it can cause a use-after-free panic. As after it get transport from
> hashtable, another CPU may free it, then the members it accesses
> may be unavailable memory.
>
> Thi
On Fri, Sep 09, 2016 at 01:34:05AM +0800, Xin Long wrote:
> >> Data Chunks are only sent by sctp_primitive_SEND, in which sctp checks
> >> the asoc's state through statetable before calling sctp_outq_tail. So
> >> there's no need to do it again in sctp_outq_tail.
> >>
> >> This patch is to remove i
(Updating the patch for the case when a non-loopback dev could be unregistered)
Currently during namespace cleanup, if ‘dst’ subsystem is holding
a reference to the interface in the namespace, it does not get released.
Current code first does a ’dev_hold’ on the same device followed by a
‘dev_put’
On Thu, Sep 08, 2016 at 10:22:43AM +0530, Harini Katakam wrote:
> >> + /* get GEM internal time */
> >> + sech = gem_readl(bp, TSH);
> >> + secl = gem_readl(bp, TSL);
> >
> > Does reading TSH latch the time? The TRM is silent about that, and
> > most other designs latch on reading the
On Thu, 2016-09-08 at 11:48 -0700, Rick Jones wrote:
> With small packets and the "default" ring size for this NIC/driver
> combination, is the BQL large enough that the ring fills before one hits
> the BQL?
It depends on how TX completion (NAPI handler) is implemented in the
driver.
Say how m
On 16/09/08, Richard Guy Briggs wrote:
> Reported-by: Paul Wouters
Oops, this above should read "nohats.ca".
> Signed-off-by: Richard Guy Briggs
> ---
> include/uapi/linux/xfrm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/xfrm.h b/include/uapi/
On 09/08/2016 11:16 AM, Tom Herbert wrote:
On Thu, Sep 8, 2016 at 10:19 AM, Jesper Dangaard Brouer
wrote:
On Thu, 8 Sep 2016 09:26:03 -0700
Tom Herbert wrote:
Shouldn't qdisc bulk size be based on the BQL limit? What is the
simple algorithm to apply to in-flight packets?
Maybe the algorithm
On 09/08/2016 10:19 AM, D. Herrendoerfer wrote:
>
> On 08 Sep 2016, at 17:39, Stephen Hemminger
> wrote:
>
>> On Thu, 8 Sep 2016 15:06:16 +0200
>> "D. Herrendoerfer" wrote:
>>
>>> Hello,
>>>
>>> I'd like to start a discussion if it makes sense to add an optional feature
>>>
>>> to the bridge M
On Thu, Sep 8, 2016 at 10:19 AM, Jesper Dangaard Brouer
wrote:
> On Thu, 8 Sep 2016 09:26:03 -0700
> Tom Herbert wrote:
>
>> On Wed, Sep 7, 2016 at 10:11 PM, Jesper Dangaard Brouer
>> wrote:
>> >
>> > On Wed, 7 Sep 2016 20:21:24 -0700 Tom Herbert wrote:
>> >
>> >> On Wed, Sep 7, 2016 at 7:58 PM
Reported-by: Paul Wouters
Signed-off-by: Richard Guy Briggs
---
include/uapi/linux/xfrm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/xfrm.h b/include/uapi/linux/xfrm.h
index 1433389..1fc62b2 100644
--- a/include/uapi/linux/xfrm.h
+++ b/include/uapi/lin
On 09/01/2016 01:02 PM, Stephen Warren wrote:
From: Stephen Warren
The Synopsys DWC EQoS is a configurable IP block which supports multiple
options for bus type, clocking and reset structure, and feature list.
Extend the DT binding to define a "compatible value" for the configuration
contained
Bjorn Andersson writes:
> On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo wrote:
>> Bjorn Andersson writes:
>>
>>> The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD
>>> channel, as such it should be a SMD client. This patch makes this
>>> transition, now that we have the necessary
>> Data Chunks are only sent by sctp_primitive_SEND, in which sctp checks
>> the asoc's state through statetable before calling sctp_outq_tail. So
>> there's no need to do it again in sctp_outq_tail.
>>
>> This patch is to remove it from sctp_outq_tail.
>>
>> Signed-off-by: Xin Long
> This doesn't
There is a reference to the virtual port in the event so you can actually
keep only one record MAC per port, I suppose the the impact would be
the same if you do this to a macvtap device on top of an ethernet device.
But granted - you could really load down the host.
Dirk
On 08 Sep 2016, at 17:15
On Thu, 8 Sep 2016 09:26:03 -0700
Tom Herbert wrote:
> On Wed, Sep 7, 2016 at 10:11 PM, Jesper Dangaard Brouer
> wrote:
> >
> > On Wed, 7 Sep 2016 20:21:24 -0700 Tom Herbert wrote:
> >
> >> On Wed, Sep 7, 2016 at 7:58 PM, John Fastabend
> >> wrote:
> >> > On 16-09-07 11:22 AM, Jesper Dang
On 08 Sep 2016, at 17:39, Stephen Hemminger wrote:
> On Thu, 8 Sep 2016 15:06:16 +0200
> "D. Herrendoerfer" wrote:
>
>> Hello,
>>
>> I'd like to start a discussion if it makes sense to add an optional feature
>>
>> to the bridge MAC address learning code to generate kernel uevents for
[SNIP
On Thu, Sep 8, 2016 at 5:12 AM, Jamal Hadi Salim wrote:
> From: Jamal Hadi Salim
>
> Example of what broke:
> ...add a gact action to drop
> sudo $TC actions add action drop index 10
> ...now retrieve it, looks good
> sudo $TC actions get action gact index 10
> ...retrieve it again and find it is
1 - 100 of 223 matches
Mail list logo
