On Mon, Aug 08, 2016 at 01:46:47PM -0700, Cong Wang wrote:
> It is harmless because all users pass 'a' to this macro.
>
> Fixes: 00175aec941e ("net/sched: Macro instead of CONFIG_NET_CLS_ACT ifdef")
> Cc: Amir Vadai
> Signed-off-by: Cong Wang
> ---
Acked-by: Amir Vadai
Thanks Cong.
On Mon, Aug 08, 2016 at 08:23:55PM -0700, Benjamin Poirier wrote:
> On 2016/08/08 09:26, Andreas Werner wrote:
> [...]
> > > > +
> > > > + if (cf->can_dlc > 0)
> > > > + data[0] = be32_to_cpup((__be32 *)(cf->data));
> > > > + if (cf->can_dlc > 3)
> > > > + da
On Mon, Aug 08, 2016 at 04:35:34PM +0200, Wolfgang Grandegger wrote:
> Am 08.08.2016 um 16:05 schrieb Andreas Werner:
> >On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote:
> >>Hello,
> >>
> >>Am 08.08.2016 um 13:39 schrieb Andreas Werner:
> >>>On Mon, Aug 08, 2016 at 11:27:25AM +0
On 2016/8/9 11:09, Jörn Engel wrote:
> Hello Tianhong!
>
> On Tue, Aug 09, 2016 at 10:18:41AM +0800, Ding Tianhong wrote:
>>
>> I don't understand your problem clearly, can you explain more about how the
>> 00503b6f702e break tun-interfaces
>> and we will try to fix it.
>
> Here is a trivial tes
Can we check slave_ops->ndo_set_mac_address?
1476 if ((slave_ops->ndo_set_mac_address) &&
(!bond->params.fail_over_mac ||
1477 BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP)) {
1478 /* Set slave to master's mac address. The
application already
1479 * set the master'
I've merged 'net' into 'net-next' and applied a bunch of pending stuff.
Fire at will...
From: Sudarsana Reddy Kalluru
Date: Mon, 8 Aug 2016 21:57:39 -0400
> The patch series contains the minor bug fixes for qed dcbx module.
> Please consider applying this to 'net' branch.
Series applied, thanks.
From: Lorenzo Colitti
Date: Tue, 9 Aug 2016 10:00:25 +0900
> Note that pretty much every sendmsg codepath allows other data to take
> precedence over sk_bound_dev_if:
>
> - udpv6_sendmsg: if sin6_scope_id specified on a scoped address
> - rawv6_sendmsg: if sin6_scope_id specified on a scoped add
From: Gao Feng
The PPTP is encapsulated by GRE header with that GRE_VERSION bits
must contain one. But current GRE RPS needs the GRE_VERSION must be
zero. So RPS does not work for PPTP traffic.
In my test environment, there are four MIPS cores, and all traffic
are passed through by PPTP. As a re
On 2016/08/08 09:26, Andreas Werner wrote:
[...]
> > > +
> > > + if (cf->can_dlc > 0)
> > > + data[0] = be32_to_cpup((__be32 *)(cf->data));
> > > + if (cf->can_dlc > 3)
> > > + data[1] = be32_to_cpup((__be32 *)(cf->data + 4));
> > > +
> > > + writel(id, &cf_buf->can_id);
> > > + wri
Hello Tianhong!
On Tue, Aug 09, 2016 at 10:18:41AM +0800, Ding Tianhong wrote:
>
> I don't understand your problem clearly, can you explain more about how the
> 00503b6f702e break tun-interfaces
> and we will try to fix it.
Here is a trivial testcase:
openvpn --mktun --dev tun0
echo +tun0 > /sy
Endian-ness conversion is not needed for priority-to-TC field as the
field is already being read/written by the driver in big-endian way.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 3 +--
1 file changed, 1 insertion(+), 2 d
The patch series contains the minor bug fixes for qed dcbx module.
Please consider applying this to 'net' branch.
Sudarsana Reddy Kalluru (4):
qed: Remove the endian-ness conversion for pri_to_tc value.
qed: Use ieee mfw-mask to get ethtype in ieee-dcbx mode.
qed: Add dcbx app support for IE
Ethtype value is being read incorrectly in ieee-dcbx mode. Use the
correct mfw mask value.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 88 --
drivers/net/ethernet/qlogic/qed/qed_hsi.h | 8 +++
2
App count is not updated while adding new app entry to the dcbx app table.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed
MFW now supports the Selection field for IEEE mode. Add driver changes to
use the newer MFW masks to read/write the port-id value.
Signed-off-by: Sudarsana Reddy Kalluru
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 124 -
include/linux/
On 2016/8/9 5:48, Jörn Engel wrote:
> Up until 00503b6f702e (part of 3.14-rc1), the bonding driver could be
> used to enslave tun-interfaces. 00503b6f702e broke that behaviour,
> afaics as an unintended side-effect.
>
Hi Jorn:
I don't understand your problem clearly, can you explain more about
Oh, I think I really get you this time.
Please see my inline comment.
If they are right, I could send the v6 patch.
Best Regards
Feng
On Tue, Aug 9, 2016 at 9:06 AM, Philip Prindeville
wrote:
> Inline...
>
>
>
> On 08/08/2016 06:37 PM, f...@48lvckh6395k16k5.yundunddos.com wrote:
>>
>> From
Inline...
On 08/08/2016 06:37 PM, f...@48lvckh6395k16k5.yundunddos.com wrote:
From: Gao Feng
The PPTP is encapsulated by GRE header with that GRE_VERSION bits
must contain one. But current GRE RPS needs the GRE_VERSION must be
zero. So RPS does not work for PPTP traffic.
In my test environme
On Tue, Aug 9, 2016 at 6:35 AM, David Miller wrote:
> We should always give sk_bound_dev_if the highest priority.
>
> Also, we should amend, not delete, the check against the scope
> ID in the sockaddr. As explained by YOSHIFUJI Hideaki.
Sure, I can do that.
Note that pretty much every sendmsg
Ok, I have sent the v5 patch with two updates:
1. One is make fixed_header of gre_full_header as uname struct;
2. Use one macro instead of the key literal master htonl(0x);
The v5 link is
https://www.mail-archive.com/netdev@vger.kernel.org/msg122261.html.
But I don't know what's advantage wit
On Tue, Aug 9, 2016 at 1:27 AM, David Ahern wrote:
> Your description states:
> "ping_v6_sendmsg never sets flowi6_oif, so it is not possible to
> ping an IPv6 address on a different interface."
>
> That code snippet above contradicts that -- flowi6_oif is set in
> ping_v6_sendmsg.
Ah, yes, than
From: Gao Feng
The PPTP is encapsulated by GRE header with that GRE_VERSION bits
must contain one. But current GRE RPS needs the GRE_VERSION must be
zero. So RPS does not work for PPTP traffic.
In my test environment, there are four MIPS cores, and all traffic
are passed through by PPTP. As a re
On Mon, Aug 8, 2016 at 5:00 PM, Sargun Dhillon wrote:
> On Mon, Aug 08, 2016 at 04:44:02PM -0700, Kees Cook wrote:
>> On Thu, Aug 4, 2016 at 12:11 AM, Sargun Dhillon wrote:
>> > I distributed this patchset to linux-security-mod...@vger.kernel.org
>> > earlier,
>> > but based on the fact that the
On Mon, Aug 08, 2016 at 04:44:02PM -0700, Kees Cook wrote:
> On Thu, Aug 4, 2016 at 12:11 AM, Sargun Dhillon wrote:
> > I distributed this patchset to linux-security-mod...@vger.kernel.org
> > earlier,
> > but based on the fact that the archive is down, and this is a fairly
> > broad-sweeping pro
On Thu, Aug 4, 2016 at 12:11 AM, Sargun Dhillon wrote:
> I distributed this patchset to linux-security-mod...@vger.kernel.org earlier,
> but based on the fact that the archive is down, and this is a fairly
> broad-sweeping proposal, I figured I'd grow the audience a little bit. Sorry
> if you rece
Before this patch:
# ./tc/tc actions add action drop index 11
RTNETLINK answers: File exists
We have an error talking to the kernel
Command "(null)" is unknown, try "tc actions help".
After this patch:
# ./tc/tc actions add action drop index 11
RTNETLINK answers: File exists
We have an er
From: rapier
Date: Mon, 8 Aug 2016 18:02:29 -0400
> As such, would it be feasible to define these instruments as 64bit
> instead of 32bit? If so, a cursory look at the code seems to indicate
> that this would only require a change in the header files.
It would break every application looking at
I think there will still be build failures even with v6 due to symbol
clashes.
For example, kernel/audit_tree.c defines HASH_SIZE as an enumeration
value, and that (indirectly) includes networking headers.
There are others all over the tree.
I would therefore ask that you first fix the namespac
The instruments for data_segs_in, data_segs_out, segs_in, and segs_out
(along with the corresponding tcpi_ variables) are currently defined as
unsigned 32 bit ints. While this is in line with RFC4898 I'm thinking
that for some flows this value might be too small.
For example, a 1GB sustained f
From: Lance Richardson
Date: Mon, 8 Aug 2016 18:22:45 -0400
> @@ -392,6 +393,17 @@ static int vti_tunnel_init(struct net_device *dev)
> return ip_tunnel_init(dev);
> }
>
> +static void vti_tunnel_uninit(struct net_device *dev)
> +{
> + struct ip_tunnel *tunnel = netdev_priv(dev);
>
When executing the script included below, the netns delete operation
hangs with the following message (repeated at 10 second intervals):
kernel:unregister_netdevice: waiting for lo to become free. Usage count = 1
This occurs because a reference to the lo interface in the "secure" netns
is still
Dmitry Torokhov writes:
> On Mon, Aug 8, 2016 at 2:08 PM, Eric W. Biederman
> wrote:
>> Dmitry Torokhov writes:
>>
>>> If net namespace is attached to a user namespace let's make container's
>>> root owner of sysctls affecting said network namespace instead of global
>>> root.
>>>
>>> This als
On Thu, Aug 4, 2016 at 8:22 PM, Dmitry Torokhov
wrote:
> There are certain parameters that belong to net namespace and that are
> exported in /proc. They should be controllable by the container's owner,
> but are currently owned by global root and thus not available.
>
> Let's change proc code to
On Mon, Aug 8, 2016 at 2:08 PM, Eric W. Biederman wrote:
> Dmitry Torokhov writes:
>
>> If net namespace is attached to a user namespace let's make container's
>> root owner of sysctls affecting said network namespace instead of global
>> root.
>>
>> This also allows us to clean up net_ctl_permis
Up until 00503b6f702e (part of 3.14-rc1), the bonding driver could be
used to enslave tun-interfaces. 00503b6f702e broke that behaviour,
afaics as an unintended side-effect.
For the purpose of bond-over-tun in balance-rr mode, simply ignoring the
error from dev_set_mac_address() is good enough.
From: Lorenzo Colitti
Date: Mon, 8 Aug 2016 16:42:07 +0900
> ping_v6_sendmsg never sets flowi6_oif, so it is not possible to
> ping an IPv6 address on a different interface. Instead, it sets
> flowi6_iif, which is incorrect but harmless. Also, it returns an
> error if a passed-in scope ID doesn'
From: Xin Long
Date: Sun, 7 Aug 2016 14:15:13 +0800
> Commit 52253db924d1 ("sctp: also point GSO head_skb to the sk when
> it's available") used event->chunk->head_skb to get the head_skb in
> sctp_ulpevent_set_owner().
>
> But at that moment, the event->chunk was NULL, as it cloned the skb
> i
I won't have any more time for this until I return from vacation at the
end of the month but after a little bit of thought I think I have fixed
all of the bugs (except arguably the return value).
I have further tweaked these and made the limits per user. Because it
occured to me that if the limi
Dmitry Torokhov writes:
> If net namespace is attached to a user namespace let's make container's
> root owner of sysctls affecting said network namespace instead of global
> root.
>
> This also allows us to clean up net_ctl_permissions() because we do not
> need to fudge permissions anymore for
Redirected by Davem.
Is there a mailing list or a maintainer for regressions? There used to
be, but I've been out of the loop for a while.
On Mon, Aug 08, 2016 at 02:15:30PM -0700, Jörn Engel wrote:
> This has been reported (and ignored) before:
> http://lkml.iu.edu/hypermail/linux/kernel/1407.2
From: Pravin B Shelar
Date: Fri, 5 Aug 2016 17:45:37 -0700
> vxlan driver has bypass for local vxlan traffic, but that
> depends on information about all VNIs on local system in
> vxlan driver. This is not available in case of LWT.
> Therefore following patch disable encap bypass for LWT
> vxlan
From: Pravin B Shelar
Date: Fri, 5 Aug 2016 17:45:36 -0700
> LWT user can specify destination as well as source ip address
> for given tunnel endpoint. But vxlan is ignoring given source
> ip address. Following patch uses both ip address to route the
> tunnel packet. This consistent with other L
On Mon, Aug 08, 2016 at 02:25:00PM +0300, Denys Fedoryshchenko wrote:
> On 2016-08-01 23:59, Guillaume Nault wrote:
> > Do you still have the vmlinux file with debug symbols that generated
> > this panic?
> Sorry for delay, i didn't had same image on all servers and probably i found
> cause of pani
On Monday, August 8, 2016 3:49:22 PM CEST David Laight wrote:
> From: Arnd Bergmann
> > Sent: 08 August 2016 16:13
> >
> > On Monday, August 8, 2016 2:49:11 PM CEST David Laight wrote:
> > >
> > > > If qe_muram_alloc will return any error, Then IS_ERR_VALUE will always
> > > > return 0. it'll not
As pointed out by Jamal, an action could be shared by
multiple filters, so we can't use list to chain them
any more after we get rid of the original tc_action.
Instead, we could just save pointers to these actions
in tcf_exts, since they are refcount'ed, so convert
the list to a flex array.
The ug
It is harmless because all users pass 'a' to this macro.
Fixes: 00175aec941e ("net/sched: Macro instead of CONFIG_NET_CLS_ACT ifdef")
Cc: Amir Vadai
Signed-off-by: Cong Wang
---
include/net/act_api.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/act_api.h b/inc
struct tcf_exts belongs to filters, should not be visible
to plain tc actions.
Cc: Ido Schimmel
Signed-off-by: Cong Wang
---
include/net/act_api.h | 16
include/net/pkt_cls.h | 20
2 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/include/net
This list_del() for tc action is not needed actually,
because we only use this list to chain bulk operations,
therefore should not be carried for latter operations.
Fixes: ec0595cc4495 ("net_sched: get rid of struct tcf_common")
Cc: Jamal Hadi Salim
Signed-off-by: Cong Wang
---
net/sched/act_ap
This patchset fixes several regressions caused by the previous
code refactor. Thanks to Jamal for catching them!
Note, patch 3/5 and 4/5 are not strictly necessary, I just
want to carry them together.
Cong Wang (5):
net_sched: remove the leftover cleanup_a()
net_sched: remove an unnecessary l
After refactoring tc_action into tcf_common, we no
longer need to cleanup temporary "actions" in list,
they are permanently stored in the hashtable.
Fixes: a85a970af265 ("net_sched: move tc_action into tcf_common")
Reported-by: Jamal Hadi Salim
Cc: Jamal Hadi Salim
Signed-off-by: Cong Wang
---
Hi Roger,
Am Mittwoch, 6. Juli 2016, 18:51:29 schrieb Roger Chen:
> Add constants and callback functions for the dwmac on rk3368 socs.
> As can be seen, the base structure is the same, only registers and
> the bits in them moved slightly.
>
> Signed-off-by: Roger Chen
> ---
> .../devicetree/bin
When PCI error is detected, in some architectures (like PowerPC) a slot
reset is performed - the driver's error handlers are in charge of "disable"
device before the reset, and re-enable it after a successful slot reset.
There are two cases though that another path is taken on the code: if the
slo
From: Daniel Borkmann
Date: Fri, 5 Aug 2016 00:11:10 +0200
> The set contains three fixes with regards to CHECKSUM_COMPLETE
> and BPF helper functions. For details please see individual
> patches.
>
> Thanks!
>
> v1 -> v2:
> - Fixed make htmldocs issue reported by kbuild bot.
> - Rest as i
From: Paul Gortmaker
Date: Thu, 4 Aug 2016 16:07:58 -0400
> The call site for this function appears as:
>
> #ifdef DEBUG
> data->msg_enable = DEBUG;
> dump_eth_one(dev);
> #endif
>
> ...leading to the following warning for !DEBUG builds:
>
> drivers/net/ethernet/tundra/tsi1
On Mon, Aug 08, 2016 at 10:01:15AM +0200, Jesper Dangaard Brouer wrote:
>
> On Sun, 7 Aug 2016 19:15:27 -0700 Alexei Starovoitov
> wrote:
>
> > On Fri, Aug 05, 2016 at 09:15:33AM +0200, Eric Dumazet wrote:
> > > On Thu, 2016-08-04 at 18:19 +0200, Jesper Dangaard Brouer wrote:
> > >
> > > > I
Oliver Neukum writes:
> But why fix similar issues at two different places? And what about
> PCI or other cards that show the same problem?
I guess some sort of common helper would be nice to avoid open coding
this fix everywhere. But you would still have to modify every driver
where it is appl
On Mon, Aug 08, 2016 at 11:27:32AM +0200, Daniel Borkmann wrote:
> On 08/08/2016 05:52 AM, Alexei Starovoitov wrote:
> >On Sun, Aug 07, 2016 at 08:08:19PM -0700, Sargun Dhillon wrote:
> >>Thanks for your feedback Alexei,
> >>I really appreciate it.
> >>
> >>On Sun, Aug 07, 2016 at 05:52:36PM -0700,
From: Jia He
Date: Mon, 8 Aug 2016 18:22:21 +0800
> In PowerPC server with large number cpus, the loop index in smt=1 could be
> reduced to 1/8 compared with smt=8.
> Thus cache misses can be reduced.
You can't do this, if cpus go down we still want to report the statistics
they collected whil
On 7/25/16 10:39 AM, Lennert Buytenhek wrote:
> Hi!
>
> I am seeing pretty horrible TCP transmit performance (anywhere between
> 1 and 10 Mb/s, on a 10 Gb/s interface) when traffic is sent out over a
> route that involves MPLS labeling, and this seems to be due to an
> interaction between MPLS and
On Tue, Aug 2, 2016 at 10:30 AM, Cong Wang wrote:
> This list_del() for tc action is not needed actually,
> because we only use this list to chain bulk operations,
> therefore should not be carried for latter operations.
>
> Cc: Jamal Hadi Salim
> Signed-off-by: Cong Wang
David, please drop thi
Thu, Aug 04, 2016 at 04:36:22PM CEST, ido...@mellanox.com wrote:
>We correctly execute mlxsw_sp_port_dcb_fini() when port is removed, but
>I missed its rollback in the error path of port creation, so add it.
>
>Fixes: f00817df2b42 ("mlxsw: spectrum: Introduce support for Data Center
>Bridging (DCB
Thu, Aug 04, 2016 at 04:36:21PM CEST, ido...@mellanox.com wrote:
>The PFCC register is used to configure both PAUSE and PFC frames.
>Therefore, when PFC frames are disabled we must make sure we don't
>mistakenly also disable PAUSE frames (which might be enabled).
>
>Fix this by packing the PFCC reg
Update to iproute2 utility to support new features in Linux 4.7.
New features are support of JSON output for bridge command, and configuring
macsec.
Plus the usual array of documentation, support of kernel flags and minor fixes.
Source:
http://www.kernel.org/pub/linux/utils/net/iproute2/iproute
Thu, Aug 04, 2016 at 04:36:20PM CEST, ido...@mellanox.com wrote:
>When ieee_setpfc() gets called, PAUSE frames are not necessarily
>disabled on the port.
>
>Check if PAUSE frames are disabled or enabled and configure the port's
>headroom buffer accordingly.
>
>Fixes: d81a6bdb87ce ("mlxsw: spectrum:
On 8/8/16 10:24 AM, Lorenzo Colitti wrote:
> On Tue, Aug 9, 2016 at 12:27 AM, David Ahern wrote:
>>> - if (!fl6.flowi6_oif && ipv6_addr_is_multicast(&fl6.daddr))
>>> - fl6.flowi6_oif = np->mcast_oif;
>>> - else if (!fl6.flowi6_oif)
>>> - fl6.flowi6_oif = np->ucast_o
On Tue, Aug 9, 2016 at 12:27 AM, David Ahern wrote:
> > - if (!fl6.flowi6_oif && ipv6_addr_is_multicast(&fl6.daddr))
> > - fl6.flowi6_oif = np->mcast_oif;
> > - else if (!fl6.flowi6_oif)
> > - fl6.flowi6_oif = np->ucast_oif;
> > -
>
> That code removal is contrary t
Hi,
2016-08-08 23:45 GMT+09:00 Lorenzo Colitti :
> On Mon, Aug 8, 2016 at 11:26 PM, Hannes Frederic Sowa
> wrote:
>>> - if (sk->sk_bound_dev_if &&
>>> - sk->sk_bound_dev_if != u->sin6_scope_id) {
>>> - return -EINVAL;
>>> - }
>>
>> Hmm,
Mon, Aug 08, 2016 at 05:56:54PM CEST, step...@networkplumber.org wrote:
>On Mon, 8 Aug 2016 09:19:21 +0200
>Jiri Pirko wrote:
>
>> Sat, Jul 23, 2016 at 06:46:59PM CEST, step...@networkplumber.org wrote:
>> >On Fri, 22 Jul 2016 18:34:29 +0200
>> >Jiri Pirko wrote:
>> >
>> >> From: Jiri Pirko
>>
From: Gerard Garcia
Add tap functions that can be used by the vsock transports to
deliver packets to vsockmon virtual network devices.
Signed-off-by: Gerard Garcia
---
include/net/af_vsock.h | 13 +
include/uapi/linux/if_arp.h | 1 +
net/vmw_vsock/Makefile | 2 +-
net/vmw
From: Gerard Garcia
This patch applies over the mst vhost git repository:
http://git.kernel.org/cgit/linux/kernel/git/mst/vhost.git
This was already been sent as a RFC where several issues where fixed.
This is the summary of changes from the first RFC:
v2:
* Do not clone skb, instead take owne
From: Gerard Garcia
Add hooks to the virtio transport host driver to deliver a copy of
the received and sent messages to all vsockmon virtual network devices.
Signed-off-by: Gerard Garcia
---
drivers/vhost/vsock.c | 72 +++
1 file changed, 72 ins
From: Gerard Garcia
Add vsockmon virtual network device that receives packets from the vsock
transports and exposes them to user space.
Based on the nlmon device.
Signed-off-by: Gerard Garcia
---
drivers/net/Kconfig | 8 ++
drivers/net/Makefile | 1 +
drivers/net/vsockm
On Fri, 5 Aug 2016 17:45:37 -0700, Pravin B Shelar wrote:
> vxlan driver has bypass for local vxlan traffic, but that
> depends on information about all VNIs on local system in
> vxlan driver. This is not available in case of LWT.
> Therefore following patch disable encap bypass for LWT
> vxlan tr
On Fri, 5 Aug 2016 17:45:36 -0700, Pravin B Shelar wrote:
> LWT user can specify destination as well as source ip address
> for given tunnel endpoint. But vxlan is ignoring given source
> ip address. Following patch uses both ip address to route the
> tunnel packet. This consistent with other LWT
On Mon, 8 Aug 2016 09:19:21 +0200
Jiri Pirko wrote:
> Sat, Jul 23, 2016 at 06:46:59PM CEST, step...@networkplumber.org wrote:
> >On Fri, 22 Jul 2016 18:34:29 +0200
> >Jiri Pirko wrote:
> >
> >> From: Jiri Pirko
> >>
> >> In order to not confuse reader, write help messages into stderr.
> >>
On Sun, 7 Aug 2016 13:19:01 +0200
Phil Sutter wrote:
> The function returns zero on success.
>
> Reported-by: Mark Bloch
> Fixes: 69f5aff63c770b ("tc: use action_a2n() everywhere")
> Signed-off-by: Phil Sutter
Applied
From: Arnd Bergmann
> Sent: 08 August 2016 16:13
>
> On Monday, August 8, 2016 2:49:11 PM CEST David Laight wrote:
> >
> > > If qe_muram_alloc will return any error, Then IS_ERR_VALUE will always
> > > return 0. it'll not call ucc_fast_free for any failure. Inside 'if code'
> > > will be a dead co
On Sun, 7 Aug 2016 12:37:03 -0700
Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> The non-json output prints 'None' for such vlans.
> And this can garble json output.
>
> Fixes: d82a49ce85f0 ("bridge: add json support for bridge vlan show")
> Signed-off-by: Roopa Prabhu
Applied
IS_ERR_VALUE() assumes that parameter is an unsigned long.
It can not be used to check if 'unsigned int' is passed insted.
Which tends to reflect an error.
In 64bit architectures sizeof (int) == 4 && sizeof (long) == 8.
IS_ERR_VALUE(x) is ((x) >= (unsigned long)-4095).
IS_ERR_VALUE() of 'unsigned i
On Mon, 8 Aug 2016 17:17:17 +0200, Simon Horman wrote:
> +bool skb_mac_header_present(struct sk_buff *skb)
> +{
> + return skb->dev->type == ARPHRD_ETHER ||
> + (skb->dev->type == ARPHRD_NONE &&
> + skb->protocol == htons(ETH_P_TEB));
> +}
> +EXPORT_SYMBOL(skb_mac_heade
On 8/8/16 1:42 AM, Lorenzo Colitti wrote:
> ping_v6_sendmsg never sets flowi6_oif, so it is not possible to
> ping an IPv6 address on a different interface. Instead, it sets
> flowi6_iif, which is incorrect but harmless. Also, it returns an
> error if a passed-in scope ID doesn't match sk_bound_dev
On Fri, Aug 05, 2016 at 04:46:43AM -0700, Ben Greear wrote:
>
> It would not be fun to have to revert to the old way of hashing
> stations in mac80211...
>
> I'll be happy to test the patches when you have them ready.
Thanks for the offer. Unfortunately it'll be a few days before
I'm ready becau
On Sun, Jul 31, 2016 at 12:07:10AM -0700, Roopa Prabhu wrote:
> On 7/27/16, 12:02 AM, zhuyj wrote:
> > On ubuntu16.04 server 64 bit
> > The attached script is run, the following will appear.
> >
> > Error: either "to" is duplicate, or "encap" is a garbage.
>
> This maybe just because the iproute2
On Wed, Jul 20, 2016 at 11:06:37AM -0700, pravin shelar wrote:
> On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman
> wrote:
> > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote:
> >> On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman
> >> wrote:
> >> > [CC Jiri Benc for portion regarding GRE]
No, I was referring to anonymous structures, which is a feature of C11.
Please see the link I sent.
On 08/08/2016 03:13 AM, Feng Gao wrote:
Hi Philip,
Do you mean like the following?
struct gre_full_hdr {
struct {
__be16 flags;
__be16 protocol;
On Monday, August 8, 2016 2:49:11 PM CEST David Laight wrote:
>
> > If qe_muram_alloc will return any error, Then IS_ERR_VALUE will always
> > return 0. it'll not call ucc_fast_free for any failure. Inside 'if code'
> > will be a dead code on 64bit. Even qe_muram_addr will return wrong
> > virtual
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
Behalf Of Arvind Yadav
> IS_ERR_VALUE() assumes that parameter is an unsigned long.
> It can not be used to check if 'unsigned int' is passed insted.
> Which tends to reflect an error.
> In 64bit architectures sizeof (int)
On Mon, Aug 8, 2016 at 11:26 PM, Hannes Frederic Sowa
wrote:
>> - if (sk->sk_bound_dev_if &&
>> - sk->sk_bound_dev_if != u->sin6_scope_id) {
>> - return -EINVAL;
>> - }
>
> Hmm, sk->sk_bound_dev_if always has highest prio for the selectio
Am 08.08.2016 um 16:05 schrieb Andreas Werner:
On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote:
Hello,
Am 08.08.2016 um 13:39 schrieb Andreas Werner:
On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote:
Hello Andreas,
a first quick review
Am 26.07.201
On 08.08.2016 09:42, Lorenzo Colitti wrote:
> ping_v6_sendmsg never sets flowi6_oif, so it is not possible to
> ping an IPv6 address on a different interface. Instead, it sets
> flowi6_iif, which is incorrect but harmless. Also, it returns an
> error if a passed-in scope ID doesn't match sk_bound_d
IS_ERR_VALUE() assumes that parameter is an unsigned long.
It can not be used to check if 'unsigned int' is passed insted.
Which tends to reflect an error.
In 64bit architectures sizeof (int) == 4 && sizeof (long) == 8.
IS_ERR_VALUE(x) is ((x) >= (unsigned long)-4095).
IS_ERR_VALUE() of 'unsigned i
On Mon, Aug 08, 2016 at 03:06:33PM +0200, Kurt Van Dijck wrote:
>
> --- Original message ---
> > Date: Mon, 8 Aug 2016 14:28:39 +0200
> > From: Wolfgang Grandegger
> >
> [...]
> > >>>+
> > >>>+if (!(cf->can_id & CAN_RTR_FLAG)) {
> > >>>+writel(data[0], &cf_buf->data
On Mon, Aug 08, 2016 at 02:28:39PM +0200, Wolfgang Grandegger wrote:
> Hello,
>
> Am 08.08.2016 um 13:39 schrieb Andreas Werner:
> >On Mon, Aug 08, 2016 at 11:27:25AM +0200, Wolfgang Grandegger wrote:
> >>Hello Andreas,
> >>
> >>a first quick review
> >>
> >>Am 26.07.2016 um 11:16 schrieb Andr
On Mon, 2016-08-08 at 14:44 +0200, Bjørn Mork wrote:
> Oliver Neukum writes:
> > I don't see how it would be specific for a subsystem. If the patch
> > is correct, it belongs into the networking core.
>
> The bug is in the firmware implementation of the "read unique vendor
> assigned mac address
crosemi PHYsBcc:
Subject: [PATCH v1 1/1] net: phy: Add edge-rate, mac-if, read, write func to
Reply-To: Nagaraju Lakkaraju
Hello,
As part of 2nd patch, Add Edge rate control, MAC Interface, Read and write
driver functions add for Microsemi PHYs.
Please review and send your comments.
Thanks
On 08/08/2016 05:13 AM, Amitoj Kaur Chawla wrote:
> The variable `err` is not used anywhere and just returns the
> predefined value `0` at the end of the function. Hence, remove the
> variable and return 0 explicitly.
Makes sense to me. Thanks!
Anna
>
> Signed-off-by: Amitoj Kaur Chawla
> ---
On Sun, Aug 07, 2016 at 02:15:13PM +0800, Xin Long wrote:
> Commit 52253db924d1 ("sctp: also point GSO head_skb to the sk when
> it's available") used event->chunk->head_skb to get the head_skb in
> sctp_ulpevent_set_owner().
>
> But at that moment, the event->chunk was NULL, as it cloned the skb
--- Original message ---
> Date: Mon, 8 Aug 2016 14:28:39 +0200
> From: Wolfgang Grandegger
>
[...]
> >>>+
> >>>+ if (!(cf->can_id & CAN_RTR_FLAG)) {
> >>>+ writel(data[0], &cf_buf->data[0]);
> >>>+ writel(data[1], &cf_buf->data[1]);
> >>
> >>Why do you not check cf->can_dlc h
Hi Michal,
> On 8.8.2016 09:15, Kedareswara rao Appana wrote:
> > Device-tree binding documentation for xilinx gmiitorgmii converter.
> >
> > Signed-off-by: Kedareswara rao Appana
> > ---
> > Changes for v4:
> > --> Modified compatible as suggested by Rob.
> > --> Removed underscores from the con
1 - 100 of 131 matches
Mail list logo
