>>
>>> On Wednesday 27 July 2016 07:50 AM, Peter Chen wrote:
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Peter Chen
---
drivers/net/ethernet/ti/davinci_emac.c | 1 +
1 file changed,
On Sat, Jul 30, 2016 at 7:34 AM, Iyappan Subramanian
wrote:
> When 10GbE SFP+ module is not plugged in or cable is not connected,
> the link status register does not report the proper state due
> to floating signal. This patch checks the module present status via an
> GPIO to determine whether to
If tx timeout event occur, kernel will call rtl8139_tx_timeout_task() to reset
hardware. But in this function, driver does not stop tx and rx function before
reset hardware, that will cause system hang.
In this patch, add stop tx and rx function before reset hardware.
Signed-off-by: Chunhao Lin
On Sun, 31 Jul 2016 21:42:22 -0700, Alexei Starovoitov said:
> and at least 2 other such patches for other files...
> Is there a single warning where -Woverride-init was useful?
> May be worth disabling this warning for the whole build?
There's a few other cases that *aren't* the "define the arra
On Mon, Aug 01, 2016 at 12:33:30AM -0400, Valdis Kletnieks wrote:
> Building with W=1 generates some 350 lines of warnings of the form:
>
> kernel/bpf/core.c: In function '__bpf_prog_run':
> kernel/bpf/core.c:476:33: warning: initialized field overwritten
> [-Woverride-init]
>[BPF_ALU | BPF_A
Building with W=1 generates some 350 lines of warnings of the form:
kernel/bpf/core.c: In function '__bpf_prog_run':
kernel/bpf/core.c:476:33: warning: initialized field overwritten
[-Woverride-init]
[BPF_ALU | BPF_ADD | BPF_X] = &&ALU_ADD_X,
^~
kernel/bpf/core
On Sun, Jul 31 2016, 09:45 PM, David Miller wrote:
> From: "Levy, Amir (Jer)"
> Date: Sun, 31 Jul 2016 10:15:52 +
>
> > The network stack thinks it is Ethernet, it might not accept Runt
> > frames, so the driver pads the frame in receive.
>
> The network stack doesn't care about this at all.
From: Heinrich Schuchardt
Date: Sun, 31 Jul 2016 11:30:58 +0200
> phy_data has to be set to zero to avoid undefined
> behavior.
In your opinion.
phy_data is only used in conditions where it has been initialized
in this function.
Therefore, please read the function carefully instead of just hav
From: Heinrich Schuchardt
Date: Sun, 31 Jul 2016 11:39:28 +0200
> i is defined as int but output as %u several times.
> Change the definition to unsigned.
>
> Signed-off-by: Heinrich Schuchardt
I hate changes like this.
The canonical way to loop over a value is to use a signed integer,
named
From: Alexander Stein
Date: Fri, 29 Jul 2016 12:12:08 +0200
> There are KSZ8721 PHYs with phy_id 0x00221619. In order to detect them
> as PHY_ID_KSZ8001 compatible while staying different to PHY_ID_KSZ9021
> ignore the last two bits when matching PHY_ID
>
> Signed-off-by: Alexander Stein
Appli
From: Valdis Kletnieks
Date: Sun, 31 Jul 2016 23:27:33 -0400
> Building with W=1 generates some 350 lines of warnings of the form:
>
> kernel/bpf/core.c: In function '__bpf_prog_run':
> kernel/bpf/core.c:476:33: warning: initialized field overwritten
> [-Woverride-init]
>[BPF_ALU | BPF_ADD
From: Chunhao Lin
Date: Fri, 29 Jul 2016 16:37:53 +0800
> v2:
> use "struct device *d = &tp->pci_dev->dev" instead of "struct pci_dev *pdev =
> tp->pci_dev"
>
> v1:
> This series of patches fix 3 runtime pm related issues that are listed below.
Series applied, thanks.
From: zhuyj
Date: Mon, 1 Aug 2016 10:57:20 +0800
> Sorry.
> An inline function will be inserted into the calling function. Why
> "Assigning NULL to parmeter dcb has no effect outside of the
> inlined function." ?
It doesn't do anything to "dcb" in the calling function, that's not
how inlining wo
Building with W=1 generates some 350 lines of warnings of the form:
kernel/bpf/core.c: In function '__bpf_prog_run':
kernel/bpf/core.c:476:33: warning: initialized field overwritten
[-Woverride-init]
[BPF_ALU | BPF_ADD | BPF_X] = &&ALU_ADD_X,
^~
kernel/bpf/core
Sorry.
An inline function will be inserted into the calling function. Why
"Assigning NULL to parmeter dcb has no effect outside of the
inlined function." ?
On Sun, Jul 31, 2016 at 6:07 PM, Heinrich Schuchardt wrote:
> Assigning NULL to parmeter dcb has no effect outside of the
> inlined function.
>> diff --git a/drivers/net/ethernet/aurora/nb8800.c
>> b/drivers/net/ethernet/aurora/nb8800.c
>> index 0d4ea92..d15d96b 100644
>> --- a/drivers/net/ethernet/aurora/nb8800.c
>> +++ b/drivers/net/ethernet/aurora/nb8800.c
>> @@ -1006,6 +1006,7 @@ static int nb8800_stop(struct net_device *dev)
>>
>>
This patch simplifies how we update fsc and calculate vt from it - while
keeping the expected functionality identical with how hfsc behaves
curently. It also fixes a certain issue introduced with
a very old patch.
The idea is, that instead of correcting cl_vt before fsc curve update
(rtsc_min) and
The part of the code using it is commented out, so the needless use
of this variable can be commented out as well.
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
in
- first patch:
This patch syncs virtual times with fair service curve and fixes a very old
subtle bug.
The detailed explanation is in the commit message. Additionally
I've made an illustration to help understand the issue better:
http://imgur.com/a/N8uMC
See the example at the bottom of the com
On Thu, Jul 28, 2016 at 12:33:58PM +0200, Guillaume Nault wrote:
> >
> > After staring more I think the patch should be fine as a fix
> > since implementing sync with ppp_[re|un]register_channel and
> > ppp_ioctl might need a way more work.
> >
>
> [Sorry for arriving so late in the game, I was
Salil Kapur :
> I was looking at v3.12. Can we submit patches for stable versions?
It has already been fixed in 3.12.8 as 56399d8b44beae5b80e1eda0350ab6af72baf4d0
("netpoll: Fix missing TXQ unlock and and OOPS.") by davem.
3.12.8 dates back to 2014/01. The current 3.12.x version is 3.12.62.
--
On Fri, 29 Jul 2016 22:27:19 +
Phil Sutter wrote:
> This header does not exist in this form upstream yet, as it contains
> struct sctp_info which is required for SCTP support in 'ss' and hasn't
> been exported yet.
>
> Signed-off-by: Phil Sutter
Holding off on this until header is correctl
On Fri, 29 Jul 2016 18:59:38 +0200
Phil Sutter wrote:
> This is required to correctly interpret INET_DIAG_INFO messages exported
> by sctp_diag module.
>
> Signed-off-by: Phil Sutter
You need to add sctp.h to include/linux/Kbuild to get it exported correctly
fxp2001640...@gmail.com wrote:
> From: Xiaoping Fan
>
> In some case, bridged packet will come back again for routing. When bridge
> netfilter is enabled, a null snat rule is assigned to bridged packet if no
> matching in nat chain. Then nat rule matching is skipped when packet comes
> back for
fxp2001640...@gmail.com wrote:
> From: Xiaoping Fan
>
> In some situations, packet goes through Linux twice, one for bridging,
> another for routing. If snat is created in bridging process, that means
Hmm, but SNAT happens in POSTROUTING.
Where can we enter routing path after bridge went thoug
From: "Levy, Amir (Jer)"
Date: Sun, 31 Jul 2016 10:15:52 +
> The network stack thinks it is Ethernet, it might not accept Runt
> frames, so the driver pads the frame in receive.
The network stack doesn't care about this at all. It's wasted effort
on your part.
On Wed, 2016-07-27 at 07:24 +, Yuval Mintz wrote:
> >
> > Current DP_ macros generate a lot of code.
> > Using functions with vsprintf extension %pV helps reduce that size.
> >
> > drivers/net/ethernet/qlogic/qed/Makefile | 2 +-
> > drivers/net/ethernet/qlogic/qed/qed_util.c | 82
> > ++
Thanks for finding.
A much better fix would be,
- if (lbk->vf_id > MAX_LMAC)
+ if (lbk->vf_id >= nic->num_vf_en)
return -1;
where 'num_vf_en' reflects the exact number of physical interfaces or
LMACs on the system.
Thanks,
Sunil.
>
> I'll look into this next week. One early question: Does the above mean
> we are printing the primary path's timer value for every assoc? If so,
> shouldn't we do that for just the EP or the primary path's assoc even?
>
Nope, we can't say "the primary path's assoc".
Every assoc has their own pr
>> >>num_possible_cpu == 64
>> >>num_online_cpu == 2 == sysconf(_SC_NPROCESSORS_CONF)
> ...
>> >> To fix it, I could either
>> >> 1). declare values array based on num_possible_cpu in test_map.c,
>> >>long values[64];
>> >> or 2) in kernel, only copying 8*2 = 16 byte from kernel to user
On 07/31/2016 05:30 AM, Heinrich Schuchardt wrote:
If sta == NULL, the changed line will not be reached.
So no need to check if stat == NULL here.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I agree.
> Do not write random bytes from the kernel stack when calling qed_wr.
>
> Signed-off-by: Heinrich Schuchardt
Thanks.
Acked-by: Yuval Mintz
We are using mac as source address in a memcpy.
In the lines below we can assume mac is not NULL.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwi
On Sat, Jul 30 2016, 12:03 AM, Stephen Hemminger wrote:
> On Thu, 28 Jul 2016 11:15:17 +0300
> Amir Levy wrote:
>
> > +int nhi_send_message(struct tbt_nhi_ctxt *nhi_ctxt, enum pdf_value
> pdf,
> > +u32 msg_len, const u8 *msg, bool ignore_icm_resp) {
>
> Why not make msg a void *
Heinrich Schuchardt writes:
> We are using mac as source address in a memcpy.
> In the lines below we can assume mac is not NULL.
>
> Signed-off-by: Heinrich Schuchardt
Please try to make the commit titles unique, for example you can use
function names or something else. Adding "(2)" is not the
On Thu, Jul 28 2016, 02:35 PM, Lukas Wunner wrote:
> On Thu, Jul 28, 2016 at 11:15:18AM +0300, Amir Levy wrote:
> > + nhi_ctxt->net_devices[
> > + port_num].medium_sts =
>
> Looks like a carriage return slipped in here.
Will be fixed.
>
For pdata == null the code leaves with an error.
There is no need to check the condition again.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/dsa/b53/b53_mmap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mma
Do not write random bytes from the kernel stack when
calling qed_wr.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/qlogic/qed/qed_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c
b/drivers/net/ethernet/qlogic/qed/q
On Thu, Jul 28, 2016 at 08:53:12PM +0800, Fengguang Wu wrote:
On Thu, Jul 28, 2016 at 01:18:27PM +0200, Jiri Kosina wrote:
On Thu, 28 Jul 2016, kbuild test robot wrote:
[auto build test ERROR on v4.7-rc7]
[also build test ERROR on next-20160728]
[cannot apply to net/master net-next/master ipse
All assignments to components of priv should only
occur after the check if prif is NULL.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/wan/fsl_ucc_hdlc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
ind
We are using mac as source address in a memcpy.
In the lines below we can assume mac is not NULL.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwi
for_each_property_of_node is only executed if the
property prop is not NULL.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
b/drivers/net/wir
If sta == NULL, the changed line will not be reached.
So no need to check if stat == NULL here.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c
b/dr
Variable length is not used after the deleted line.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/qlogic/qlge/qlge_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
index fd5d1c9..f
On Sat, Jul 30 2016, 12:48 AM, Greg KH wrote:
> On Fri, Jul 29, 2016 at 02:02:24PM -0700, Stephen Hemminger wrote:
> > On Thu, 28 Jul 2016 11:15:17 +0300
> > Amir Levy wrote:
> >
> > > +static LIST_HEAD(controllers_list); static
> > > +DECLARE_RWSEM(controllers_list_rwsem);
> >
> > Why use a semap
On Sat, Jul 30 2016, 12:07 AM, Stephen Hemminger wrote:
> On Thu, 28 Jul 2016 11:15:19 +0300
> Amir Levy wrote:
>
> > + /* pad short packets */
> > + if (unlikely(skb->len < ETH_ZLEN)) {
> > + int pad_len = ETH_ZLEN - skb->len;
> > +
> > + /
Assigning NULL to parmeter dcb has no effect outside of the
inlined function.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h
b/drivers/net/ethernet/qlogic/q
Hello.
On 7/31/2016 10:42 AM, Heinrich Schuchardt wrote:
For pdata == null the code leaves with an error.
There is need to check the condition again.
No need, you mean?
Signed-off-by: Heinrich Schuchardt
[...]
MBR, Sergei
(!A || (A && B)) is equivalent to (!A || B)
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/neterion/s2io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/neterion/s2io.c
b/drivers/net/ethernet/neterion/s2io.c
index 2874dff..eaa37c0 100644
-
Hello.
On 7/31/2016 5:49 AM, Levin, Alexander wrote:
Off by one in nic_config_loopback would access an invalid arrat variable when
Array?
vf id == MAX_LMAC.
Signed-off-by: Sasha Levin
[...]
MBR, Sergei
i is defined as int but output as %u several times.
Change the definition to unsigned.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
b/drive
phy_data has to be set to zero to avoid undefined
behavior.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/intel/e1000/e1000_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c
b/drivers/net/ethernet/intel/e1000/e1000
i is defined as unsigned.
So print it with %u.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/cisco/enic/enic_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c
b/drivers/net/ethernet/cisco/enic/enic_main.c
ind
add and val are read with
sscanf(kern_buf, "%x:%x", &addr, &val);
and used as arguments for bna_reg_offset_check and writel
so they have to be unsigned.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
addr and len are read with
sscanf(kern_buf, "%x:%x", &addr, &len);
and used as arguments for
bna_reg_offset_check.
So they have to be unsigned.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
If dev_get_platdata has failed pd is null.
Do not dereference a null pointer.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
b/drivers/net/ethern
i has been defined as unsigned int.
So use %u for output.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
index
If platform_get_resource fails, mem2 is null.
Do not dereference null.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/ethernet/8390/ax88796.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/8390/ax88796.c
b/drivers/net/ethernet/8390/ax88796.c
index
For pdata == null the code leaves with an error.
There is need to check the condition again.
Signed-off-by: Heinrich Schuchardt
---
drivers/net/dsa/b53/b53_mmap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c
%u is the wrong format specifier for int.
size_t cannot be converted to int without possible
loss of information.
So leave the result as size_t and use %zu as format specifier.
cf. Documentation/printk-formats.txt
Signed-off-by: Heinrich Schuchardt
---
drivers/net/caif/caif_spi.c | 4 ++--
1 f
On 7/27/16, 12:02 AM, zhuyj wrote:
> On ubuntu16.04 server 64 bit
> The attached script is run, the following will appear.
>
> Error: either "to" is duplicate, or "encap" is a garbage.
This maybe just because the iproute2 version on ubuntu does not
support the route encap attributes yet.
[snip]
61 matches
Mail list logo
