Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

2016-07-03 Thread Wei Hu (Xavier)
On 2016/7/2 20:58, Leon Romanovsky wrote: On Sat, Jul 02, 2016 at 05:39:02PM +0800, Lijun Ou wrote: This v11 28 files changed, 10626 insertions(+), 1 deletion(-) First version 27 files changed, 11670 insertions(+), 11 deletions(-) 1K LOC less, we are moving in right direction. Thanks

[patch net-next 11/14] mlxsw: spectrum: Introduce support for router interfaces

2016-07-03 Thread Jiri Pirko
From: Ido Schimmel Up until now we only supported bridged interfaces. Packets ingressing through the switch ports were either classified to FIDs (in the case of the VLAN-aware bridge) or vFIDs (in the case of VLAN-unaware bridges). The packets were then forwarded according to the FDB. Routing was

[patch net-next 03/14] mlxsw: reg: Add Router Algorithmic LPM Structure Tree Register definition

2016-07-03 Thread Jiri Pirko
From: Jiri Pirko Serves to build LPM tree structure. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 77 +++ 1 file changed, 77 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/drivers/net/

[patch net-next 10/14] mlxsw: spectrum: Edit RIF properties based on netdev events

2016-07-03 Thread Jiri Pirko
From: Ido Schimmel We are just about to introduce router interfaces (RIFs), but before that we need to be able update the device with the correct RIF attributes whenever they change for the netdev the RIF is backing. Two such attributes are MTU and MAC. The MAC is used both to set the source MAC

[patch net-next 14/14] mlxsw: spectrum: Enable L3 interfaces on top of bridge devices

2016-07-03 Thread Jiri Pirko
From: Ido Schimmel As with the previously introduced L3 interfaces, listen to 'inetaddr' notifications sent for bridges devices configured on top of the port netdevs and create / destroy router interfaces (RIFs) accordingly. This also includes VLAN devices configured on top of the VLAN-aware brid

[patch net-next 09/14] mlxsw: spectrum: Add couple of lower device helper functions

2016-07-03 Thread Jiri Pirko
From: Jiri Pirko Add functions that iterate over lower devices and find port device. As a dependency add netdev_for_each_all_lower_dev and netdev_for_each_all_lower_dev_rcu macro with netdev_all_lower_get_next and netdev_all_lower_get_next_rcu shelpers. Also, add functions to return mlxsw struct

[patch net-next 05/14] mlxsw: spectrum_router: Implement LPM trees management

2016-07-03 Thread Jiri Pirko
From: Jiri Pirko Introduce basic LPM tree management allowing to share the trees in between tables if the used prefixes in the tables are the same. Build the tree structure according to the used prefixes. Although it is not optimal for many use cases, this initial implementation does only simple

[patch net-next 12/14] mlxsw: spectrum: Unsplit the vFID range

2016-07-03 Thread Jiri Pirko
From: Ido Schimmel Previous commit deprecated the vFIDs used to get traffic to the CPU ('port_vfids'). Thus, we now use the vFIDs as god intended and the artificial split is no longer needed. Rename functions and variables to reflect that. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko

[patch net-next 07/14] mlxsw: reg: Add Router Algorithmic LPM Unicast Entry Register definition

2016-07-03 Thread Jiri Pirko
From: Jiri Pirko Serves for adding, updating and removing fib entries. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 264 ++ 1 file changed, 264 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/re

[patch net-next 02/14] mlxsw: reg: Add Router Algorithmic LPM Tree Allocation Register definition

2016-07-03 Thread Jiri Pirko
From: Jiri Pirko Register serves for allocation and deallocation of LPM search tree. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 54 ++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/drivers/ne

[patch net-next 08/14] mlxsw: spectrum_router: Implement fib4 add/del switchdev obj ops

2016-07-03 Thread Jiri Pirko
From: Jiri Pirko Implement ipv4 FIB entries addition and removal. Initially, we support local and broadcast routes using "ip2me" trap action. Also, unicast routes without nexthop are supported using "local" action. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/m

[patch net-next 06/14] mlxsw: spectrum_router: Add virtual router management

2016-07-03 Thread Jiri Pirko
From: Jiri Pirko Virtual router is a construct used inside HW. In this implementation we map kernel tables to virtual routers one to one. Introduce management logic to create virtual routers when needed and destroy in case they are no longer in use. According to that, call into LPM tree managemen

[patch net-next 13/14] mlxsw: spectrum: Configure FIDs based on bridge events

2016-07-03 Thread Jiri Pirko
From: Ido Schimmel Before introducing support for L3 interfaces on top of the VLAN-aware bridge we need to add some missing infrastructure. Such an interface can either be the bridge device itself or a VLAN device on top of it. In the first case the router interface (RIF) is associated with FID

[patch net-next 04/14] mlxsw: reg: Add Router Algorithmic LPM Tree Binding Register definition

2016-07-03 Thread Jiri Pirko
From: Jiri Pirko This register is used to bind virtual router and protocol to an allocated LPM tree. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 45 +++ 1 file changed, 45 insertions(+) diff --git a/drivers/n

[patch net-next 01/14] mlxsw: spectrum_router: Implement private fib

2016-07-03 Thread Jiri Pirko
From: Jiri Pirko Shadow FIB is needed in order to hold additional information for FIB entries and keep track of used prefixes. That is needed for the LPM tree construction to be introduced later on in this set. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mella

[patch net-next 00/14] mlxsw: Implement basic FIB offload and router interfaces

2016-07-03 Thread Jiri Pirko
From: Jiri Pirko Introduce LPM trees management including virtual router management for HW. Implement basic FIB offloading using switchdev FIB objects. For now only support local routes and direct routes (next-hop support will be introduced in a follow-up patchset). Introduce router interfaces i

Re: [PATCH] netfilter: nf_conntrack_sip: CSeq 0 is a valid CSeq

2016-07-03 Thread Christophe Leroy
Le 04/07/2016 à 07:48, Liping Zhang a écrit : 2016-07-01 17:48 GMT+08:00 Christophe Leroy : Do not drop packet when CSeq is 0 as 0 is also a valid value for CSeq. --- a/net/netfilter/nf_conntrack_sip.c +++ b/net/netfilter/nf_conntrack_sip.c @@ -1368,6 +1368,7 @@ static int process_sip_respons

[PATCH net-next] tun: fix build warnings

2016-07-03 Thread Jason Wang
Stephen Rothwell reports a build warnings(powerpc ppc64_defconfig) drivers/net/tun.c: In function 'tun_do_read.part.5': /home/sfr/next/next/drivers/net/tun.c:1491:6: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] int err; This is because tun_ring_recv() may r

Re: [PATCH] netfilter: nf_conntrack_sip: CSeq 0 is a valid CSeq

2016-07-03 Thread Liping Zhang
2016-07-01 17:48 GMT+08:00 Christophe Leroy : > Do not drop packet when CSeq is 0 as 0 is also a valid value for CSeq. > > --- a/net/netfilter/nf_conntrack_sip.c > +++ b/net/netfilter/nf_conntrack_sip.c > @@ -1368,6 +1368,7 @@ static int process_sip_response(struct sk_buff *skb, > unsigned int pro

[PATCH] fsl/fman: fix error handling

2016-07-03 Thread Christophe JAILLET
This is likely that checking 'fman->fifo_offset' instead of 'fman->cam_offset' is expected here. Signed-off-by: Christophe JAILLET --- The type of 'fifo_offset' may also need to be changed. --- drivers/net/ethernet/freescale/fman/fman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

Re: linux-next: build warning after merge of the net-next tree

2016-07-03 Thread Jason Wang
On 2016年07月04日 11:15, Stephen Rothwell wrote: Hi all, After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning: drivers/net/tun.c: In function 'tun_do_read.part.5': /home/sfr/next/next/drivers/net/tun.c:1491:6: warning: 'err' may be used unini

Re^2: [PATCH] usbnet: add reset_resume quirk to prevent resume failure

2016-07-03 Thread Vivek Kumar Bhagat
Hello David, Class driver .reset_resume() function will be called only when USB host driver has set below flag, otherwise it will follow normal resume (without reset). if (udev->quirks & USB_QUIRK_RESET_RESUME) <-- usb_resume_device() udev->reset_resume = 1; I shall remove

PROBLEM: MTU of ipsec tunnel drops continuously until traffic stops

2016-07-03 Thread Matt Bennett
*Resending as plain text so the mailing list accepts it.. Sorry Steffen and Herbert* ​Hi, During long run testing of an ipsec tunnel over a PPP link it was found that occasionally traffic would stop flowing over the tunnel. Eventually the traffic would start again, however using the command "i

linux-next: build warning after merge of the net-next tree

2016-07-03 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning: drivers/net/tun.c: In function 'tun_do_read.part.5': /home/sfr/next/next/drivers/net/tun.c:1491:6: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]

linux-next: manual merge of the net-next tree with the net tree

2016-07-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlx5/core/en_main.c between commit: 29429f3300a3 ("net/mlx5e: Timeout if SQ doesn't flush during close") from the net tree and commit: 507f0c817f7a ("net/mlx5e: Add TXQ set max rate su

linux-next: manual merge of the net-next tree with the net tree

2016-07-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlx5/core/en.h between commit: 6cd392a082de ("net/mlx5e: Handle RQ flush in error cases") from the net tree and commit: cb3c7fd4f839 ("net/mlx5e: Support adaptive RX coalescing") from

Re: [PATCH net-next 00/10] NCSI Support

2016-07-03 Thread Gavin Shan
On Mon, Jul 04, 2016 at 08:49:31AM +1000, Benjamin Herrenschmidt wrote: >On Mon, 2016-07-04 at 01:03 +0300, Or Gerlitz wrote: >> FWIW, talking to a colleague, he made a comment that some of the text >> above is wrong: >> >> AENs are sent from NIC to BMC. Not from Host to BMC. > >Just a typo in the

Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

2016-07-03 Thread Julian Calaby
Hi All, On Sat, Jul 2, 2016 at 5:39 AM, Javier Martinez Canillas wrote: > The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added > interface") attempted to fix an issue when a new AP interface is added. > > But the patch didn't check the return value of the functions doing the >

Re: [PATCH net-next 00/10] NCSI Support

2016-07-03 Thread Benjamin Herrenschmidt
On Mon, 2016-07-04 at 01:03 +0300, Or Gerlitz wrote: > FWIW, talking to a colleague, he made a comment that some of the text > above is wrong: > > AENs are sent from NIC to BMC. Not from Host to BMC. Just a typo in the commit message thankfully ;-) > The traffic between a BMC and a NIC is over R

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

2016-07-03 Thread Lino Sanfilippo
Hi, some remarks below. > +/* Fill up receive queue's RFD with preallocated receive buffers */ > +static void emac_mac_rx_descs_refill(struct emac_adapter *adpt, > + struct emac_rx_queue *rx_q) > +{ > + struct emac_buffer *curr_rxbuf; > + struct emac_buffer

Re: [PATCH net-next V2 02/10] liquidio: Macro replacements

2016-07-03 Thread Joe Perches
On Sun, 2016-07-03 at 13:56 -0700, Raghu Vatsavayi wrote: > This patch has minor replacements of ACCESS_ONCE macros with > WRITE_ONCE and replacement of BUG_ON with polite version WARN_ON. And makes some functions static. > diff --git a/drivers/net/ethernet/cavium/liquidio/cn66xx_device.c > b/dri

Re: [PATCH net-next 00/10] NCSI Support

2016-07-03 Thread Or Gerlitz
On Sun, Jul 3, 2016 at 8:32 AM, Gavin Shan wrote: > This series rebases on David's linux-net git repo ("master" branch). It's > to support NCSI stack on net/farady/ftgmac100.c > > The following figure gives an example about how NCSI is deployed: The NCSI is > specified by DSP0222, which can be dow

[PATCH net-next V2 05/10] liquidio: iq/oq limits

2016-07-03 Thread Raghu Vatsavayi
This patch removes the dependency of number of iq/oq's on number of cpus. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 6 +- 1 file changed, 1 insertion(+), 5

[PATCH net-next V2 02/10] liquidio: Macro replacements

2016-07-03 Thread Raghu Vatsavayi
This patch has minor replacements of ACCESS_ONCE macros with WRITE_ONCE and replacement of BUG_ON with polite version WARN_ON. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- .../net/ethernet/cavium/liquidio/cn66xx_d

[PATCH net-next V2 01/10] liquidio: Vxlan support

2016-07-03 Thread Raghu Vatsavayi
This patch adds support for Vxaln offloads in liquidio driver. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 29 +++ drivers/net/ethernet/cavium/liquidio/lio_ma

[PATCH net-next V2 10/10] liquidio: Response header changes

2016-07-03 Thread Raghu Vatsavayi
This patch changes response header to be able to communicate with new firmware interface. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/liquidio_common.h | 18 --

[PATCH net-next V2 04/10] liquidio: softcommand delay

2016-07-03 Thread Raghu Vatsavayi
This patch updates the delay constant for softcommands in accrodance with new requirements. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +- drivers/net/

[PATCH net-next V2 08/10] liquidio: Droq validation

2016-07-03 Thread Raghu Vatsavayi
This patch removes redudant droq num validation. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 12 1 file changed, 12 deletions(-) diff --git a/dri

[PATCH net-next V2 09/10] liquidio: Remove redundant code

2016-07-03 Thread Raghu Vatsavayi
This patch removes redundant file includes and conditions. Provides some meaningful comments and code alignment. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- .../net/ethernet/cavium/liquidio/cn66xx_device.c | 2

[PATCH net-next V2 03/10] liquidio: IQ synchronization

2016-07-03 Thread Raghu Vatsavayi
This patch tries to protect against bh preemption with sc_buf_pool. It also modifies the syncronization primitives during input queue processing. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- .../net/ethernet/caviu

[PATCH net-next V2 07/10] liquidio: MTU limits

2016-07-03 Thread Raghu Vatsavayi
This patch limits the MTU between 68 bytes and 16000 bytes. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 2 +- drivers/net/ethernet/cavium/liquidio/lio_main.

[PATCH net-next V2 06/10] liquidio: free resources during shutdown

2016-07-03 Thread Raghu Vatsavayi
This patch fixes the issue of proper freeing of queue memory resources during free device. It also has fix for correct pcie error reporting. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi --- drivers/net/ethernet/cavium

[PATCH net-next V2 00/10] liquidio updates and bug fixes

2016-07-03 Thread Raghu Vatsavayi
Dave, Following V2 patchset contains updates and bug fixes for liquidio driver. This patchset also has changes that you suggested in vxlan code. Please apply the patches in following order as some of the patches depend on earlier patches in the series. Raghu Vatsavayi (10): liquidio: Vxlan supp

[PATCH net,stable] cdc_ncm: workaround for EM7455 "silent" data interface

2016-07-03 Thread Bjørn Mork
Several Lenovo users have reported problems with their Sierra Wireless EM7455 modem. The driver has loaded successfully and the MBIM management channel has appeared to work, including establishing a connection to the mobile network. But no frames have been received over the data interface. The pro

Re: [PATCHv3 wl-drv-next 1/2] add basic register-field manipulation macros

2016-07-03 Thread Hannes Frederic Sowa
On 01.07.2016 23:26, Jakub Kicinski wrote: > C bitfields are problematic and best avoided. Developers > interacting with hardware registers find themselves searching > for easy-to-use alternatives. Common approach is to define > structures or sets of macros containing mask and shift pair. > Opera

Re: [PATCH] RDS: fix rds_tcp_init() error path

2016-07-03 Thread Santosh Shilimkar
On 7/3/2016 1:54 AM, Vegard Nossum wrote: If register_pernet_subsys() fails, we shouldn't try to call unregister_pernet_subsys(). Fixes: 467fa15356 ("RDS-TCP: Support multiple RDS-TCP listen endpoints, one per netns.") Cc: sta...@vger.kernel.org Cc: Sowmini Varadhan Cc: David S. Miller Signed

[PATCH 1/2] net: ethernet: bcmgenet: use phydev from struct net_device

2016-07-03 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phy in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/br

[PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings

2016-07-03 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 28 +-- 1 files changed, 2 insertions(+), 26 deleti

Re: [PATCH] RDS: fix rds_tcp_init() error path

2016-07-03 Thread Sowmini Varadhan
> If register_pernet_subsys() fails, we shouldn't try to call > unregister_pernet_subsys(). Acked-by: Sowmini Varadhan

Re: [PATCH 1/4] net: ethernet: ti: davinci_cpdma: split descs num between all channels

2016-07-03 Thread Ivan Khoronzhuk
On 01.07.16 23:35, David Miller wrote: From: Ivan Khoronzhuk Date: Thu, 30 Jun 2016 22:04:35 +0300 @@ -720,7 +763,7 @@ unlock_ret: } EXPORT_SYMBOL_GPL(cpdma_chan_submit); -bool cpdma_check_free_tx_desc(struct cpdma_chan *chan) +inline bool cpdma_check_free_desc(struct cpdma_chan *chan)

[PATCH] RDS: fix rds_tcp_init() error path

2016-07-03 Thread Vegard Nossum
If register_pernet_subsys() fails, we shouldn't try to call unregister_pernet_subsys(). Fixes: 467fa15356 ("RDS-TCP: Support multiple RDS-TCP listen endpoints, one per netns.") Cc: sta...@vger.kernel.org Cc: Sowmini Varadhan Cc: David S. Miller Signed-off-by: Vegard Nossum --- net/rds/tcp.c |