Re: [PATCH] net:ppp: replace too strict capability restriction on opening /dev/ppp

2016-06-19 Thread Richard Weinberger
Am 20.06.2016 um 07:02 schrieb Andi Kleen: > Shanker Wang writes: > >> This patch removes the check for CAP_NET_ADMIN in the initial namespace >> when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user >> namespace the net namespace was created so that /dev/ppp cat get opened >> in

Re: rcu locking issue in mpls output code?

2016-06-19 Thread Lennert Buytenhek
On Sun, Jun 19, 2016 at 08:19:20PM -0600, David Ahern wrote: > > diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunnel.c > > index fb31aa8..802956b 100644 > > --- a/net/mpls/mpls_iptunnel.c > > +++ b/net/mpls/mpls_iptunnel.c > > @@ -105,12 +105,15 @@ static int mpls_output(struct net *net

[PATCH 6/6] wcn36xx: Fix up wcn36xx_smd_update_scan_params()

2016-06-19 Thread Bjorn Andersson
Fix up the wcn36xx_smd_update_scan_params() to work with non-ancient versions of the firmware and support actually specifying the list of channels. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/hal.h | 4 ++-- drivers/net/wireless/ath/wcn36xx/smd.c | 15 +-- dr

[PATCH 2/6] wcn36xx: Change indication list lock to spinlock

2016-06-19 Thread Bjorn Andersson
From: Bjorn Andersson In preparation for handling incoming messages from IRQ context, change the indication list lock to a spinlock Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/smd.c | 12 ++-- drivers/net/wireless/ath/wcn36xx/

Re: Micrel Phy KSZ8031 clock select setting in dts

2016-06-19 Thread Sascha Hauer
On Sun, Jun 19, 2016 at 09:29:41PM +0200, Oliver Graute wrote: > On 17/06/16, Sergei Shtylyov wrote: > > On 06/17/2016 04:04 PM, Oliver Graute wrote: > > > > >I try to enable a Micrel KSZ8031 in my imx6ul board device tree. But i'am > > >struggeling with the setting for KSZPHY_RMII_REF_CLK_SEL BIT

[PATCH 3/6] wcn36xx: Split mmio space into explicit regions

2016-06-19 Thread Bjorn Andersson
Split the wcnss mmio space into explicit regions for ccu and dxe and acquire these from the node referenced by the qcom,mmio phandle. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/dxe.c | 26 --- drivers/net/wireless/ath/wcn36xx/dxe.h | 6 ++-- drivers/

[PATCH 5/6] wcn36xx: Transition driver to SMD client

2016-06-19 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson --- This patch depends on the devicetree binding approved by Rob H

[PATCH 4/6] wcn36xx: Correct DXE chip version differentiation

2016-06-19 Thread Bjorn Andersson
The CCU block in WCNSS is configured for appropriate routing of interrupts from the DXE to the application cpu, this is not dependant on the iris version (wcn3660 vs wcn3680), but rather if the SoC has a riva or pronto built in. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx

[PATCH 1/6] wcn36xx: Fold indication payload into message header

2016-06-19 Thread Bjorn Andersson
From: Bjorn Andersson Merge the two allocation instead of separately allocating room for the indication payload. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/smd.c | 15 ++- drivers/net/wireless/ath/wcn36xx/smd.h | 2 +- 2 fil

RE: [RFC PATCH] net: macb: Add gmii2rgmii converter support

2016-06-19 Thread Appana Durga Kedareswara Rao
Hi Florian, Thanks for the quick response... > > On June 19, 2016 10:27:17 PM MST, Kedareswara rao Appana > wrote: > >This patch adds support for gmii2rgmii converter in the macb driver. > > > >The GMII to RGMII IP core provides the > >Reduced Gigabit Media Independent Interface > >(RGM

Re: [RFC PATCH] net: macb: Add gmii2rgmii converter support

2016-06-19 Thread Joe Perches
On Mon, 2016-06-20 at 10:57 +0530, Kedareswara rao Appana wrote: > This patch adds support for gmii2rgmii converter > in the macb driver. [] > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c [] > @@ -376,6 +389,20 @@ static int macb_mii_probe(struct net_dev

Re: [PATCH v10 08/22] IB/hns: Add icm support

2016-06-19 Thread Leon Romanovsky
On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/17 17:58, Leon Romanovsky wrote: > >On Thu, Jun 16, 2016 at 10:35:16PM +0800, Lijun Ou wrote: > >>This patch mainly added icm support for RoCE. It initializes icm > >>which managers the relative memory blocks for RoC

[RFC PATCH] net: macb: Add gmii2rgmii converter support

2016-06-19 Thread Kedareswara rao Appana
This patch adds support for gmii2rgmii converter in the macb driver. The GMII to RGMII IP core provides the Reduced Gigabit Media Independent Interface (RGMII) between Ethernet physical media devices And the Gigabit Ethernet controller. This core can switch dynamically between the Three different

Re: [RFC PATCH] net: macb: Add gmii2rgmii converter support

2016-06-19 Thread Florian Fainelli
On June 19, 2016 10:27:17 PM MST, Kedareswara rao Appana wrote: >This patch adds support for gmii2rgmii converter >in the macb driver. > >The GMII to RGMII IP core provides the >Reduced Gigabit Media Independent Interface >(RGMII) between Ethernet physical media devices >And the Gigabit Ethernet

RE: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-19 Thread Rosen, Rami
Hi all, A very limited review below. + + /* get capabilities of particular feature */ + ENA_ADMIN_GET_FEATURE = 8, Instead /* get capabilities SHOULD BE: /* set capabilities . + + /* get capabilities of particular feature */ + ENA_ADMIN_SET_FEATURE = 9, + .. +int

Re: [PATCH] net:ppp: replace too strict capability restriction on opening /dev/ppp

2016-06-19 Thread Andi Kleen
Shanker Wang writes: > This patch removes the check for CAP_NET_ADMIN in the initial namespace > when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user > namespace the net namespace was created so that /dev/ppp cat get opened > in a unprivileged container. Seems dangerous. From a

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

2016-06-19 Thread David Ahern
On 6/17/16 6:21 PM, Stephen Hemminger wrote: I want to have the least user complaints possible. Since the main reason people build new iproute2 utilities is to work with features of newer kernels. It makes sense to keep the requirements the same. Not sure if kernel still builds with gcc-3.2, ha

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-19 Thread Roopa Prabhu
On Fri, Jun 17, 2016 at 10:12 AM, Florian Fainelli wrote: > On 06/17/2016 08:42 AM, Jiri Pirko wrote: >> Fri, Jun 17, 2016 at 05:35:53PM CEST, d...@cumulusnetworks.com wrote: >>> On 6/17/16 8:54 AM, Jamal Hadi Salim wrote: On 16-06-17 10:05 AM, Jiri Pirko wrote: > Fri, Jun 17, 2016 at 03:

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

2016-06-19 Thread David Miller
From: Tom Herbert Date: Fri, 17 Jun 2016 20:52:55 -0700 > For instance, TFO was put in the Linux several years ago, but it > still hasn't been enabled in Android and only fairly recently > enabled in iOS. "Android decided to get locked into a really old kernel for 6+ years" is not really a good

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-19 Thread Roopa Prabhu
On Fri, Jun 17, 2016 at 7:54 AM, Jamal Hadi Salim wrote: > On 16-06-17 10:05 AM, Jiri Pirko wrote: >> >> Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: >>> >>> On 6/17/16 2:24 AM, Jiri Pirko wrote: > >> >> That is problematic. Existing apps depend on rtnetlink stat

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-19 Thread Roopa Prabhu
On Fri, Jun 17, 2016 at 7:05 AM, Jiri Pirko wrote: > Fri, Jun 17, 2016 at 03:48:35PM CEST, d...@cumulusnetworks.com wrote: >>On 6/17/16 2:24 AM, Jiri Pirko wrote: >>> >>>The problem we try to handle is different, it's about offloaded >>>forwarded packets which are not seen by kernel. Let me try to

Re: rcu locking issue in mpls output code?

2016-06-19 Thread David Ahern
On 6/19/16 6:45 PM, Lennert Buytenhek wrote: diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunnel.c index fb31aa8..802956b 100644 --- a/net/mpls/mpls_iptunnel.c +++ b/net/mpls/mpls_iptunnel.c @@ -105,12 +105,15 @@ static int mpls_output(struct net *net, struct sock *sk, struct sk_buff

linux-next: manual merge of the net-next tree with the net tree

2016-06-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/rds/tcp_listen.c between commit: 3bb549ae4c51 ("RDS: TCP: rds_tcp_accept_one() should transition socket from RESETTING to UP") from the net tree and commit: 0cb43965d42a ("RDS: split out connection specific st

linux-next: manual merge of the net-next tree with the net tree

2016-06-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/rds/tcp_connect.c between commit: 5c3da57d70f1 ("net: rds: fix coding style issues") from the net tree and commit: 0cb43965d42a ("RDS: split out connection specific state from rds_connection to rds_conn_path")

linux-next: manual merge of the net-next tree with the net tree

2016-06-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/qlogic/qed/qed_hsi.h between commit: b639f197210d ("qed: Add missing port-mode") from the net tree and commit: 351a4dedb34c ("qed: Utilize FW 8.10.3.0") from the net-next tree. I fixed it up

rcu locking issue in mpls output code?

2016-06-19 Thread Lennert Buytenhek
Hi! While trying to chase down a memory corruption issue that only occurs when originating large amounts of MPLS tagged IP traffic, I came across something in the MPLS output code for which I'm not entirely sure that it's correct. Specifically, there is the code path dst_output() -> lwtunnel_outp

Re: [PATCH 1/2] net: ethernet: bcmsysport: use phydev from struct net_device

2016-06-19 Thread David Miller
From: Philippe Reynes Date: Sun, 19 Jun 2016 20:39:08 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct

Re: [PATCH 2/2] net: ethernet: bcmsysport: use phy_ethtool_{get|set}_link_ksettings

2016-06-19 Thread David Miller
From: Philippe Reynes Date: Sun, 19 Jun 2016 20:39:09 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 2/2] net: ethernet: bcmsysport: use phy_ethtool_{get|set}_link_ksettings

2016-06-19 Thread Florian Fainelli
Le 19/06/2016 11:39, Philippe Reynes a écrit : > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 1/2] net: ethernet: bcmsysport: use phydev from struct net_device

2016-06-19 Thread Florian Fainelli
Le 19/06/2016 11:39, Philippe Reynes a écrit : > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct net_device. >

[PATCH 2/2] net: ethernet: bgmac: use phy_ethtool_{get|set}_link_ksettings

2016-06-19 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/broadcom/bgmac.c | 20 ++-- 1 files changed, 2 insertions(+), 18 deletions(-) diff

[PATCH 1/2] net: ethernet: bgmac: use phydev from struct net_device

2016-06-19 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- drivers/net/ethernet

Re: [PATCH net-next 0/8] tou: Transports over UDP - part I

2016-06-19 Thread Hajime Tazaki
On Fri, 17 Jun 2016 20:52:55 -0700, Tom Herbert wrote: > > > We also now have to debug against every single userland TCP > > implementation someone can come up with, the barrier to entry is > > insanely low with TOU. Maybe this sounds great to you, but to me > > it is quite terrifying > > > No,

Re: Micrel Phy KSZ8031 clock select setting in dts

2016-06-19 Thread Oliver Graute
On 17/06/16, Sergei Shtylyov wrote: > On 06/17/2016 04:04 PM, Oliver Graute wrote: > > >I try to enable a Micrel KSZ8031 in my imx6ul board device tree. But i'am > >struggeling with the setting for KSZPHY_RMII_REF_CLK_SEL BIT(7). In my > >revision of this Micrel KSZ8031 Phy the Bit(7) has to be tr

[PATCH 2/2] net: ethernet: bcmsysport: use phy_ethtool_{get|set}_link_ksettings

2016-06-19 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/broadcom/bcmsysport.c | 22 ++ 1 files changed, 2 insertions(+), 20 deletions(-

[PATCH 1/2] net: ethernet: bcmsysport: use phydev from struct net_device

2016-06-19 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- drivers/net/ethernet

Re: [PATCH net-next 2/2] net sched actions: skbedit add support for mod-ing skb pkt_type

2016-06-19 Thread Daniel Borkmann
On 06/18/2016 05:12 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Extremely useful for setting packet type to host so i dont have to modify the dst mac address using pedit (which requires that i know the mac address) Example usage: tc filter add dev eth0 parent : protocol ip pref 9 u3

Re: [net-next,v3] openvswitch: Add packet len info to upcall.

2016-06-19 Thread pravin shelar
On Fri, Jun 17, 2016 at 12:52 PM, William Tu wrote: > The commit f2a4d086ed4c ("openvswitch: Add packet truncation support.") > introduces packet truncation before sending to userspace upcall receiver. > This patch passes up the skb->len before truncation so that the upcall > receiver knows the or

Re: [PATCH net-next 1/2] net: simplify and make pkt_type_ok() available for other users

2016-06-19 Thread Daniel Borkmann
Hi Jamal, On 06/18/2016 05:12 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Suggested-by: Daniel Borkmann Signed-off-by: Jamal Hadi Salim --- include/linux/skbuff.h | 11 +++ net/netfilter/nft_meta.c | 9 + 2 files changed, 12 insertions(+), 8 deletions(-) diff -

Re: [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings

2016-06-19 Thread David Miller
From: Philippe Reynes Date: Sat, 18 Jun 2016 23:16:55 +0200 > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Applied.

Re: [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device

2016-06-19 Thread David Miller
From: Philippe Reynes Date: Sat, 18 Jun 2016 23:16:54 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

2016-06-19 Thread Naveen N. Rao
On 2016/06/17 10:00AM, Thadeu Lima de Souza Cascardo wrote: > On Fri, Jun 17, 2016 at 10:53:21PM +1000, Michael Ellerman wrote: > > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > > > diff --git a/arch/powerpc/net/bpf_jit_comp64.c > > > b/arch/powerpc/net/bpf_jit_comp64.c > > > new fi

Re: [PATCH net 0/5] qed*: Fixes series

2016-06-19 Thread David Miller
From: Yuval Mintz Date: Sun, 19 Jun 2016 15:18:10 +0300 > This series contains several small fixes to driver behavior > [4th patch is the only one containing a 'fatal' fix, but the error > is only theoretical for qede; if would require another protocol > driver yet unsubmitted to reach it]. Seri

Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-06-19 Thread Naveen N. Rao
On 2016/06/17 10:53PM, Michael Ellerman wrote: > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > > diff --git a/arch/powerpc/net/bpf_jit_comp64.c > > b/arch/powerpc/net/bpf_jit_comp64.c > > new file mode 100644 > > index 000..954ff53 > > --- /dev/null > > +++ b/arch/powerpc/net/bp

[PATCH V2 RFC 1/2] brcmfmac: delete interface directly in code that sent fw request

2016-06-19 Thread Rafał Miłecki
So far when receiving event about in-firmware-interface removal our event worker was notifying listener and afterwards it was removing Linux interface. First of all it was resulting in slightly unexpected order. The listener (del_virtual_intf callback) was (usually) returning with success before w

[PATCH V2 RFC 2/2] brcmfmac: support removing AP interfaces with "interface_remove"

2016-06-19 Thread Rafał Miłecki
New firmwares (e.g. 10.10.69.36 for BCM4366) support "interface_remove" for removing interfaces. Try to use this method on cfg80211 request. In case of older firmwares (e.g. 7.35.177.56 for BCM43602 as I tested) this will just result in firmware rejecting command and this won't change any behavior.

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-19 Thread Takashi Sakamoto
(remove C.C. to lkml. This is not so major feature.) On Jun 19 2916 07:45, Henrik Austad wrote: snip 802.1Q gives you low latency through the network, but more importantly, no dropped frames. gPTP gives you a central reference to time. When such a long message is required, it means that we do

Re: [PATCH 12/15] net: davinci_mdio: document missed "ti,am4372-mdio" compat string

2016-06-19 Thread Rob Herring
On Wed, Jun 15, 2016 at 02:56:00PM +0300, Grygorii Strashko wrote: > Document missed "ti,am4372-mdio" compat string used for TI am437x SoC > (am4372.dtsi). > > Signed-off-by: Grygorii Strashko > --- > Documentation/devicetree/bindings/net/davinci-mdio.txt | 3 ++- > 1 file changed, 2 insertions(

Re: [PATCH net-next 12/18] IB/mlx5: Add kernel offload flow-tag

2016-06-19 Thread Saeed Mahameed
On Sat, Jun 18, 2016 at 2:34 AM, Eric Dumazet wrote: > On Fri, Jun 17, 2016 at 3:31 PM, Saeed Mahameed > wrote: >> >> Today there are some bad usages and abuse to skb->protocol where some >> device drivers set skb->protocol = 0xff to skip the kernel TCP/IP >> processing for the same diagnosti

Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver

2016-06-19 Thread Rob Herring
On Tue, Jun 14, 2016 at 05:22:35PM -0500, Timur Tabi wrote: > Add supports for ethernet controller HW on Qualcomm Technologies, Inc. SoC. > This driver supports the following features: > 1) Checksum offload. > 2) Interrupt coalescing support. > 3) SGMII phy. > 4) phylib interface for external phy >

[PATCH net 3/5] qed*: Don't reset statistics on inner reload

2016-06-19 Thread Yuval Mintz
Several user APIs can cause driver to perform an inner-reload. Currently, doing this would cause the HW/FW statistics of the adapter to reset, which isn't the expected behavior [statistics should only reset on explicit unloads]. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_

[PATCH net 4/5] qed: Fix returning unlimited SPQ entries

2016-06-19 Thread Yuval Mintz
Driver has 2 sets of entries for handling ramrod configurations toward firmware - a regular pre-allocated set of entires and a possible 'unlimited' list of additional pending entries. In most scenarios the 'unlimited' list would not be used, but when it does the handling of the ramrod completion d

[PATCH net 5/5] qed: Add missing port-mode

2016-06-19 Thread Yuval Mintz
The 'MODULE_FIBER' value replaced several other FIBER values in newer management firmware images, so existing code would fail to properly reflect its mode. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 1 + drivers/net/ethernet/qlogic/qed/qed_main.c | 1 + 2 files c

[PATCH net 2/5] qed: Prevent VF from Tx-switching 'promisc'

2016-06-19 Thread Yuval Mintz
Internal loopback in driver is based on two things - first is the willingness of transmitter to use it [in case of VFs, this can be forced based on VEPA/VEB] and secondly on another vport classification configuration which should match the packet's destination. Current code allows non-linux VFs to

[PATCH net 1/5] qed: Correct default vlan behavior

2016-06-19 Thread Yuval Mintz
When no vlan filter is configured, firmware has a configurable default on whether to pass only untagged packets or all packets regardless of their tagging. Driver currently doesn't set this field in the necessary ramrod, causing the default to always be 'receive all'. Signed-off-by: Yuval Mintz -

[PATCH net 0/5] qed*: Fixes series

2016-06-19 Thread Yuval Mintz
This series contains several small fixes to driver behavior [4th patch is the only one containing a 'fatal' fix, but the error is only theoretical for qede; if would require another protocol driver yet unsubmitted to reach it]. Dave, Please consider applying this to `net'. Thanks, Yuval Yuval M

Re: [PATCH 1/2] net: ethernet: nb8800: use phydev from struct net_device

2016-06-19 Thread Måns Rullgård
Philippe Reynes writes: > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one contained in struct net_device. > > Signed-off-by: Phili

Re: [PATCH 2/2] net: ethernet: nb8800: use phy_ethtool_{get|set}_link_ksettings

2016-06-19 Thread Måns Rullgård
Philippe Reynes writes: > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes Acked-by: Mans Rullgard > --- > drivers/net/ethernet/aurora/nb8800.c | 24 ++

Re: [patch net-next v4 0/4] return offloaded stats as default and expose original sw stats

2016-06-19 Thread Jiri Pirko
Sat, Jun 18, 2016 at 03:58:56PM CEST, j...@mojatatu.com wrote: >On 16-06-18 04:00 AM, Jiri Pirko wrote: >>Fri, Jun 17, 2016 at 07:12:22PM CEST, f.faine...@gmail.com wrote: > Yep. And I believe that for offloaded forwarding, this tools should see hw counters, as they show what is going on in

Re: [PATCH] net:ppp: replace too strict capability restriction on opening /dev/ppp

2016-06-19 Thread Richard Weinberger
Am 19.06.2016 um 12:36 schrieb Shanker Wang: > >> 在 2016年6月19日,12:13,Richard Weinberger 写道: >> >> Am 19.06.2016 um 07:21 schrieb Shanker Wang: >>> This patch removes the check for CAP_NET_ADMIN in the initial namespace >>> when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user >>>

Re: [PATCH] net:ppp: replace too strict capability restriction on opening /dev/ppp

2016-06-19 Thread Shanker Wang
> 在 2016年6月19日,12:13,Richard Weinberger 写道: > > Am 19.06.2016 um 07:21 schrieb Shanker Wang: >> This patch removes the check for CAP_NET_ADMIN in the initial namespace >> when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user >> namespace the net namespace was created so that /dev

Re: [PATCH] net:ppp: replace too strict capability restriction on opening /dev/ppp

2016-06-19 Thread Richard Weinberger
Am 19.06.2016 um 07:21 schrieb Shanker Wang: > This patch removes the check for CAP_NET_ADMIN in the initial namespace > when opening /dev/open. Instead, CAP_NET_ADMIN is checked in the user > namespace the net namespace was created so that /dev/ppp cat get opened > in a unprivileged container. >

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-19 Thread Richard Cochran
On Sun, Jun 19, 2016 at 12:45:50AM +0200, Henrik Austad wrote: > edit: this turned out to be a somewhat lengthy answer. I have tried to > shorten it down somewhere. it is getting late and I'm getting increasingly > incoherent (Richard probably knows what I'm talking about ;) so I'll stop > for n

Re: PATCH 1/1] AX.25: Close socket connection on session completion

2016-06-19 Thread Thomas Osterried
> > socket. Symptom occurs in kernels >= 4.2.0 [..] > What changed in 4.2.x that broke this? 3.x'er kernel had also this problem; but there it happens rarely. vy 73, - Thomas dl9sau