Re: [Bridge] [PATCH net-next v2] bridge: Synchronize unicast filtering with FDB

2016-06-11 Thread Toshiaki Makita
On 16/06/12 (日) 1:17, Nikolay Aleksandrov via Bridge wrote: On 06/11/2016 07:35 AM, David Miller wrote: From: Toshiaki Makita Date: Mon, 6 Jun 2016 21:20:13 +0900 Patrick Schaaf reported that flooding due to a missing fdb entry of the address of macvlan on the bridge device caused high CPU c

RE: [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely

2016-06-11 Thread Fugang Duan
From: Stefan Wahren Sent: Thursday, June 09, 2016 4:43 AM > To: David Miller ; Fugang Duan > > Cc: Fabio Estevam ; Lucas Stach > ; and...@lunn.ch; holgerschu...@gmail.com; Troy > Kisky ; linux-arm-ker...@lists.infradead.org; > netdev@vger.kernel.org; Stefan Wahren > Subject: [PATCH net-next RFT

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-11 Thread Takashi Sakamoto
On Jun 12 2016 12:38, Takashi Sakamoto wrote: > In your patcset, there's no actual codes about how to handle any > interrupt contexts (software / hardware), how to handle packet payload, > and so on. Especially, for recent sound subsystem, the timing of > generating interrupts and which context doe

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-11 Thread Takashi Sakamoto
Hi, I'm one of maintainers for ALSA firewire stack, which handles IEC 61883-1/6 and vendor-unique packets on IEEE 1394 bus for consumer recording equipments. (I'm not in MAINTAINERS because I'm a shy boy.) IEC 61883-6 describes that one packet can multiplex several types of data in its data chann

Re: [net:master 4/8] net/ipv4/ipconfig.c:130:15: warning: 'ic_addrservaddr' defined but not used

2016-06-11 Thread David Miller
From: kbuild test robot Date: Sat, 11 Jun 2016 15:22:48 +0800 >>> net/ipv4/ipconfig.c:130:15: warning: 'ic_addrservaddr' defined but not used >>> [-Wunused-variable] > static __be32 ic_addrservaddr = NONE; /* IP Address of the IP > addresses'server */ Should be fixed by: =

Re: [PATCH net] ipv6: fix endianness error in icmpv6_err

2016-06-11 Thread Lorenzo Colitti
On Sun, Jun 12, 2016 at 3:32 AM, Hannes Frederic Sowa wrote: > IPv6 ping socket error handler doesn't correctly convert the new 32 bit > mtu to host endianness before using. > ... > if (!(type & ICMPV6_INFOMSG_MASK)) > if (icmp6->icmp6_type == ICMPV6_ECHO_REQUEST) > -

Re: [PATCHi next] veth: advertise peer link relationship for both devices

2016-06-11 Thread David Miller
From: Lance Richardson Date: Sat, 11 Jun 2016 22:04:13 -0400 (EDT) > I'll confess to not being super-happy with it myself, which is why I've > been sitting on this patch for some time now. A hard NAK will help justify > a "will not fix" to the reporter of this issue. Since userspace can learn ev

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-11 Thread David Miller
From: Vidya Sagar Ravipati Date: Sat, 11 Jun 2016 16:22:38 -0700 > As part of ethtool application, application is requesting the drivers > to provide the supported eeprom size to allocate memory buffer for > getting complete dump. And the right way to do that is the driver requests the eeprom i

Re: [PATCHi next] veth: advertise peer link relationship for both devices

2016-06-11 Thread Lance Richardson
- Original Message - > From: "David Miller" > To: lrich...@redhat.com > Cc: netdev@vger.kernel.org, "nicolas dichtel" > Sent: Saturday, June 11, 2016 6:43:40 PM > Subject: Re: [PATCHi next] veth: advertise peer link relationship for both > devices > > From: Lance Richardson > Date: Fri

Re: [PATCH net v2] ipv6: fix checksum annotation in udp6_csum_init

2016-06-11 Thread Cong Wang
On Sat, Jun 11, 2016 at 12:15 PM, Hannes Frederic Sowa wrote: > Cc: Tom Herbert > Fixes: 4068579e1e098fa ("net: Implmement RFC 6936 (zero RX csums for > UDP/IPv6") > Signed-off-by: Hannes Frederic Sowa > --- > net/ipv6/ip6_checksum.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(

Re: [PATCH net] fib_rules: don't break ECN with TOS rules

2016-06-11 Thread Hannes Frederic Sowa
On Sun, Jun 12, 2016, at 02:36, Hannes Frederic Sowa wrote: > On Sun, Jun 12, 2016, at 02:09, Julian Anastasov wrote: > > > > Hello, > > > > On Sat, 11 Jun 2016, Hannes Frederic Sowa wrote: > > > > > Users of ToS rules could accidentally break ECN, this patch tries to > > > fix this in a way

Re: [PATCH net] fib_rules: don't break ECN with TOS rules

2016-06-11 Thread Hannes Frederic Sowa
Hi Julian, On Sun, Jun 12, 2016, at 02:09, Julian Anastasov wrote: > > Hello, > > On Sat, 11 Jun 2016, Hannes Frederic Sowa wrote: > > > Users of ToS rules could accidentally break ECN, this patch tries to > > fix this in a way so we don't break shell scripts depending on the old > > beha

Re: [PATCH v2 -next] sched: remove NET_XMIT_POLICED

2016-06-11 Thread Cong Wang
On Sat, Jun 11, 2016 at 3:54 PM, David Miller wrote: > From: Florian Westphal > Date: Sat, 11 Jun 2016 12:46:04 +0200 > >> sch_atm returns this when TC_ACT_SHOT classification occurs. >> >> But all other schedulers that use tc_classify >> (htb, hfsc, drr, fq_codel ...) return NET_XMIT_SUCCESS | _

Re: [PATCH net] fib_rules: don't break ECN with TOS rules

2016-06-11 Thread Julian Anastasov
Hello, On Sat, 11 Jun 2016, Hannes Frederic Sowa wrote: > Users of ToS rules could accidentally break ECN, this patch tries to > fix this in a way so we don't break shell scripts depending on the old > behavior while still being transparent to ECN. This quietly fixes ECN > behavior for o

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-11 Thread Vidya Sagar Ravipati
On Sat, Jun 11, 2016 at 3:51 PM, David Miller wrote: > From: vi...@cumulusnetworks.com > Date: Mon, 6 Jun 2016 22:55:26 -0700 > >> From: Vidya Sagar Ravipati >> >> This patch provides macro definitions for maximum possible >> memory map size of QSFP+/QSFP28 EEPROMs as per SFF-8436/SFF-8636 >> >>

[very-RFC 6/8] Add TSN event-tracing

2016-06-11 Thread Henrik Austad
From: Henrik Austad This needs refactoring and should be updated to use TRACE_CLASS, but for now it provides a fair debug-window into TSN. Cc: "David S. Miller" Cc: Steven Rostedt (maintainer:TRACING) Cc: Ingo Molnar (maintainer:TRACING) Signed-off-by: Henrik Austad --- include/trace/events

[very-RFC 3/8] Adding TSN-driver to Intel I210 controller

2016-06-11 Thread Henrik Austad
This adds support for loading the igb.ko module with tsn capabilities. This requires a 2-step approach. First enabling TSN in .config, then load the module with use_tsn=1. Once enabled and loaded, the controller will be placed in "Qav-mode" which is when the credit-based shaper is available, 3 of

[very-RFC 2/8] TSN: Add the standard formerly known as AVB to the kernel

2016-06-11 Thread Henrik Austad
TSN provides a mechanism to create reliable, jitter-free, low latency guaranteed bandwidth links over a local network. It does this by reserving a path through the network. Support for TSN must be found in both the NIC as well as in the network itself. This adds required hooks into netdev_ops so t

[very-RFC 0/8] TSN driver for the kernel

2016-06-11 Thread Henrik Austad
Hi all (series based on v4.7-rc2, now with the correct netdev) This is a *very* early RFC for a TSN-driver in the kernel. It has been floating around in my repo for a while and I would appreciate some feedback on the overall design to avoid doing some major blunders. TSN: Time Sensitive Networkin

[very-RFC 4/8] Add TSN header for the driver

2016-06-11 Thread Henrik Austad
From: Henrik Austad This defines the general TSN headers for network packets, the shim-interface and the central 'tsn_list' structure. Cc: "David S. Miller" Signed-off-by: Henrik Austad --- include/linux/tsn.h | 806 1 file changed, 806 ins

[very-RFC 7/8] AVB ALSA - Add ALSA shim for TSN

2016-06-11 Thread Henrik Austad
From: Henrik Austad This exposes a *very* rudimentary and simplistic ALSA driver that hooks into TSN to create a device for userspace. It currently only supports 44.1/48kHz sampling, 2ch, S16_LE Userspace is supposed to reserve bandwidth, find StreamID etc. To use as a Talker: mkdir /config/t

[very-RFC 5/8] Add TSN machinery to drive the traffic from a shim over the network

2016-06-11 Thread Henrik Austad
From: Henrik Austad In short summary: * tsn_core.c is the main driver of tsn, all new links go through here and all data to/form the shims are handled here core also manages the shim-interface. * tsn_configfs.c is the API to userspace. TSN is driven from userspace and a link is created, c

[very-RFC 1/8] TSN: add documentation

2016-06-11 Thread Henrik Austad
From: Henrik Austad Describe the overall design behind the TSN standard, the TSN-driver, requirements to userspace and new functionality introduced. Cc: "David S. Miller" Signed-off-by: Henrik Austad --- Documentation/TSN/tsn.txt | 147 ++ 1 file ch

[very-RFC 8/8] MAINTAINERS: add TSN/AVB-entries

2016-06-11 Thread Henrik Austad
From: Henrik Austad Not sure how relevant this is other than making a point about maintaining it. Signed-off-by: Henrik Austad --- MAINTAINERS | 14 ++ 1 file changed, 14 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ed42cb6..ef5d926 100644 --- a/MAINTAINERS +++ b/MAI

Re: [PATCH v2 -next] sched: remove NET_XMIT_POLICED

2016-06-11 Thread Florian Westphal
David Miller wrote: > From: Florian Westphal > Date: Sat, 11 Jun 2016 12:46:04 +0200 > > > sch_atm returns this when TC_ACT_SHOT classification occurs. > > > > But all other schedulers that use tc_classify > > (htb, hfsc, drr, fq_codel ...) return NET_XMIT_SUCCESS | __BYPASS > > in this case so

Re: [very-RFC 4/8] Add TSN header for the driver

2016-06-11 Thread Henrik Austad
Clearing up netdev-typo -H On Sun, Jun 12, 2016 at 12:22:17AM +0200, Henrik Austad wrote: > From: Henrik Austad > > This defines the general TSN headers for network packets, the > shim-interface and the central 'tsn_list' structure. > > Cc: "David S. Miller" > Signed-off-by: Henrik Austad > -

Re: [very-RFC 2/8] TSN: Add the standard formerly known as AVB to the kernel

2016-06-11 Thread David Miller
Not as a reply, fresh new patch postings. :-/

Re: [very-RFC 5/8] Add TSN machinery to drive the traffic from a shim over the network

2016-06-11 Thread Henrik Austad
clearing up netdev-typo -H On Sun, Jun 12, 2016 at 12:22:18AM +0200, Henrik Austad wrote: > From: Henrik Austad > > In short summary: > > * tsn_core.c is the main driver of tsn, all new links go through > here and all data to/form the shims are handled here > core also manages the shim-inte

Re: [PATCH v2 -next] sched: remove NET_XMIT_POLICED

2016-06-11 Thread David Miller
From: Florian Westphal Date: Sat, 11 Jun 2016 12:46:04 +0200 > sch_atm returns this when TC_ACT_SHOT classification occurs. > > But all other schedulers that use tc_classify > (htb, hfsc, drr, fq_codel ...) return NET_XMIT_SUCCESS | __BYPASS > in this case so just do that in atm. Yes, but it's

Re: [very-RFC 3/8] Adding TSN-driver to Intel I210 controller

2016-06-11 Thread Henrik Austad
clearing up netdev-typo -H On Sun, Jun 12, 2016 at 12:22:16AM +0200, Henrik Austad wrote: > This adds support for loading the igb.ko module with tsn > capabilities. This requires a 2-step approach. First enabling TSN in > .config, then load the module with use_tsn=1. > > Once enabled and loaded,

Re: [very-RFC 2/8] TSN: Add the standard formerly known as AVB to the kernel

2016-06-11 Thread Henrik Austad
clearing up netdev-typo On Sun, Jun 12, 2016 at 12:22:15AM +0200, Henrik Austad wrote: > TSN provides a mechanism to create reliable, jitter-free, low latency > guaranteed bandwidth links over a local network. It does this by > reserving a path through the network. Support for TSN must be found in

Re: [very-RFC 1/8] TSN: add documentation

2016-06-11 Thread Henrik Austad
On Sun, Jun 12, 2016 at 12:22:14AM +0200, Henrik Austad wrote: > From: Henrik Austad Clearing up the netdev-typo > > Describe the overall design behind the TSN standard, the TSN-driver, > requirements to userspace and new functionality introduced. > > Cc: "David S. Miller" > Signed-off-by: He

Re: [very-RFC 1/8] TSN: add documentation

2016-06-11 Thread Henrik Austad
On Sat, Jun 11, 2016 at 03:49:42PM -0700, David Miller wrote: > From: Henrik Austad > Date: Sun, 12 Jun 2016 00:47:28 +0200 > > > What would be the best approach? Resend series to netdev@vger? I don't want > > to spam too many lists either. > > Resend to all the lists. ok, I'll do that then.

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

2016-06-11 Thread David Miller
From: vi...@cumulusnetworks.com Date: Mon, 6 Jun 2016 22:55:26 -0700 > From: Vidya Sagar Ravipati > > This patch provides macro definitions for maximum possible > memory map size of QSFP+/QSFP28 EEPROMs as per SFF-8436/SFF-8636 > > According to SFF-8436/SFF-8636 specs, the common memory map fo

Re: [very-RFC 1/8] TSN: add documentation

2016-06-11 Thread David Miller
From: Henrik Austad Date: Sun, 12 Jun 2016 00:47:28 +0200 > What would be the best approach? Resend series to netdev@vger? I don't want > to spam too many lists either. Resend to all the lists.

Re: [PATCH net-next v2] bridge: Synchronize unicast filtering with FDB

2016-06-11 Thread David Miller
From: Nikolay Aleksandrov Date: Sat, 11 Jun 2016 18:17:53 +0200 > Oops, I almost missed the v2, sorry about that. So, technically it > looks correct, but I only fear the scalability impact of the > change. If there're a large number of vlans adding a macvlan (or any > device that syncs uc addr) m

Re: [very-RFC 0/8] TSN driver for the kernel

2016-06-11 Thread Henrik Austad
On Sun, Jun 12, 2016 at 12:22:13AM +0200, Henrik Austad wrote: > Hi all Sorry.. I somehow managed to mess up the address to netdev, so if you feel like replying to this, use this as it has the correct netdev-address. again, sorry > (series based on v4.7-rc2) > > This is a *very* early RFC for

Re: [PATCH] libertas_tf: Remove create_workqueue

2016-06-11 Thread Tejun Heo
On Wed, Jun 08, 2016 at 01:38:53AM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitem (viz > &priv->cmd_work per priv, which maps to lbtf_cmd_work) is involved in > actual command processing and ma

Re: [very-RFC 1/8] TSN: add documentation

2016-06-11 Thread Henrik Austad
On Sat, Jun 11, 2016 at 03:35:10PM -0700, David Miller wrote: > > Networking patches not CC:'d to netdev@vger.kernel.org are unlikely to > be reviewed by networking developers at all. Oh no! I messed up git send-email and wrote linux-netdev@vger instead of netdev@vger. What would be the best ap

Re: [PATCHi next] veth: advertise peer link relationship for both devices

2016-06-11 Thread David Miller
From: Lance Richardson Date: Fri, 10 Jun 2016 12:32:19 -0400 > Currently, when creating a veth pair, notfications to user > space only include link peer for one end of the veth pair: ># ip monitor link & ># ip link add dev vm1 type veth peer name vm2 >30: vm2@NONE: mtu 1500 qdisc noo

Re: [PATCH net-next] ipv6: use TOS marks from sockets for routing decision

2016-06-11 Thread David Miller
From: Hannes Frederic Sowa Date: Sat, 11 Jun 2016 20:08:19 +0200 > In IPv6 the ToS values are part of the flowlabel in flowi6 and get > extracted during fib rule lookup, but we forgot to correctly initialize > the flowlabel before the routing lookup. > > Reported-by: > Signed-off-by: Hannes Fre

[PATCH net] fib_rules: don't break ECN with TOS rules

2016-06-11 Thread Hannes Frederic Sowa
Users of ToS rules could accidentally break ECN, this patch tries to fix this in a way so we don't break shell scripts depending on the old behavior while still being transparent to ECN. This quietly fixes ECN behavior for old setups. For IPv6 we have no check if we check for ECN bits, in IPv4 we

RE: [PATCH net-next,v2] tools: hv: Add a script to help bonding synthetic and VF NICs

2016-06-11 Thread Haiyang Zhang
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, June 10, 2016 9:14 PM > To: Haiyang Zhang > Cc: netdev@vger.kernel.org; KY Srinivasan ; > o...@aepfle.de; vkuzn...@redhat.com; linux-ker...@vger.kernel.org; > driverdev-de...@linuxdriverproject.org > S

[PATCH net v2] ipv6: fix checksum annotation in udp6_csum_init

2016-06-11 Thread Hannes Frederic Sowa
Cc: Tom Herbert Fixes: 4068579e1e098fa ("net: Implmement RFC 6936 (zero RX csums for UDP/IPv6") Signed-off-by: Hannes Frederic Sowa --- net/ipv6/ip6_checksum.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c index b2025

Re: [PATCH net] ipv6: fix checksum annotation in udp6_csum_init

2016-06-11 Thread Hannes Frederic Sowa
On Sat, Jun 11, 2016, at 20:56, Hannes Frederic Sowa wrote: > Cc: Tom Herbert > Fixes: 4068579e1e098fa ("net: Implmement RFC 6936 (zero RX csums for > UDP/IPv6") > Signed-off-by: Hannes Frederic Sowa Sorry for the noise, I will send a better patch in a minute.

[PATCH net] ipv6: fix checksum annotation in udp6_csum_init

2016-06-11 Thread Hannes Frederic Sowa
Cc: Tom Herbert Fixes: 4068579e1e098fa ("net: Implmement RFC 6936 (zero RX csums for UDP/IPv6") Signed-off-by: Hannes Frederic Sowa --- include/net/ip6_checksum.h | 2 +- net/ipv6/ip6_checksum.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/ip6_checksum.h

[PATCH net] ipv6: tcp: fix endianness annotation in tcp_v6_send_response

2016-06-11 Thread Hannes Frederic Sowa
Cc: Florent Fourcot Fixes: 1d13a96c74fc ("ipv6: tcp: fix flowlabel value in ACK messages send from TIME_WAIT") Signed-off-by: Hannes Frederic Sowa --- net/ipv6/tcp_ipv6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index f36c

[PATCH net] ipv6: fix endianness error in icmpv6_err

2016-06-11 Thread Hannes Frederic Sowa
IPv6 ping socket error handler doesn't correctly convert the new 32 bit mtu to host endianness before using. Cc: Lorenzo Colitti Fixes: 6d0bfe22611602f ("net: ipv6: Add IPv6 support to the ping socket.") Signed-off-by: Hannes Frederic Sowa --- net/ipv6/icmp.c | 2 +- 1 file changed, 1 insertion

[PATCH net-next] ipv6: use TOS marks from sockets for routing decision

2016-06-11 Thread Hannes Frederic Sowa
In IPv6 the ToS values are part of the flowlabel in flowi6 and get extracted during fib rule lookup, but we forgot to correctly initialize the flowlabel before the routing lookup. Reported-by: Signed-off-by: Hannes Frederic Sowa --- net/ipv6/icmp.c | 4 +++- net/ipv6/ping.c | 4 +++- ne

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-11 Thread David Miller
From: Andrew Lunn Date: Sat, 11 Jun 2016 17:39:21 +0200 > What is still open is do we want to accept it at all? Do we accept the > concept of putting the same MAC address on multiple interfaces at > hotplug time? Do we trust BIOS vendors to not keep changing DSDT > property name, since it is not

Re: pull-request: mac80211-next 2016-06-09

2016-06-11 Thread David Miller
From: Johannes Berg Date: Sat, 11 Jun 2016 09:58:23 +0200 > On Fri, 2016-06-10 at 23:16 -0700, David Miller wrote: > >> > Can I ask you to pull net into net-next, preferably before merging >> > this? > >> Looks good, pulled, thanks! > > Thanks! I see you also had pulled net in for other reason

Re: [tipc-discussion] [PATCH] tipc: fix potential null pointer dereference in the nla_data function

2016-06-11 Thread David Miller
From: Erik Hugne Date: Sat, 11 Jun 2016 09:46:32 +0200 > On Jun 11, 2016 08:24, "David Miller" wrote: >> >> From: Baozeng Ding >> Date: Fri, 10 Jun 2016 10:26:59 +0800 >> >> > Before calling the nla_data function, make sure the argument is not > null. >> > Fix potential null pointer dereference

Re: [PATCH net-next v2] bridge: Synchronize unicast filtering with FDB

2016-06-11 Thread Nikolay Aleksandrov
On 06/11/2016 07:35 AM, David Miller wrote: > From: Toshiaki Makita > Date: Mon, 6 Jun 2016 21:20:13 +0900 > >> Patrick Schaaf reported that flooding due to a missing fdb entry of >> the address of macvlan on the bridge device caused high CPU >> consumption of an openvpn process behind a tap bri

Re: [PATCH] phy: marvell: fix LED configuration via marvell,reg-init

2016-06-11 Thread Andrew Lunn
On Sat, Jun 11, 2016 at 05:21:26PM +0200, Clemens Gruber wrote: > Configuring the PHY LED registers for the Marvell 88E1510 and others is > not possible, because regardless of the values in marvell,reg-init, it > is later overridden in m88e1121_config_aneg with a non-standard default. > > This pat

Re: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

2016-06-11 Thread Andrew Lunn
On Fri, Jun 10, 2016 at 10:51:56PM -0700, David Miller wrote: > From: Mario Limonciello > Date: Tue, 7 Jun 2016 13:22:37 -0500 > > > The RTL8153-AD supports a persistent system specific MAC address. > > This means a device plugged into two different systems with host side > > support will show d

[PATCH] phy: marvell: fix LED configuration via marvell,reg-init

2016-06-11 Thread Clemens Gruber
Configuring the PHY LED registers for the Marvell 88E1510 and others is not possible, because regardless of the values in marvell,reg-init, it is later overridden in m88e1121_config_aneg with a non-standard default. This patch moves that default configuration to .config_init to allow setting the L

[PATCH v2 -next] sched: remove NET_XMIT_POLICED

2016-06-11 Thread Florian Westphal
sch_atm returns this when TC_ACT_SHOT classification occurs. But all other schedulers that use tc_classify (htb, hfsc, drr, fq_codel ...) return NET_XMIT_SUCCESS | __BYPASS in this case so just do that in atm. BATMAN uses it as an intermediate return value to signal forwarding vs. buffering, but

Re: [PATCH 1/3] bridge: netfilter: checkpatch whitespace fixes

2016-06-11 Thread Tobin Harding
On Thu, Jun 09, 2016 at 11:00:18AM -0700, Joe Perches wrote: > On Wed, 2016-06-08 at 19:38 +0200, Pablo Neira Ayuso wrote: > > On Wed, Jun 08, 2016 at 07:31:21PM +0200, Pablo Neira Ayuso wrote: > > looks easier to readable than original Tobin's, so I'll wait for you > > to resubmit. > > Well, mayb

Re: [PATCH] net: ethernet: ti: cpsw: use destroy ctlr to destroy channels

2016-06-11 Thread Ivan Khoronzhuk
On 11.06.16 12:24, Ivan Khoronzhuk wrote: On 11.06.16 04:17, David Miller wrote: From: Ivan Khoronzhuk Date: Sat, 11 Jun 2016 01:11:54 +0300 Based on master master... of what? master of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git but it's applicable on linux-next

Re: [PATCH v2 1/2] net: ethernet: ti: cpsw: remove rx_descs property

2016-06-11 Thread Ivan Khoronzhuk
On 11.06.16 08:50, David Miller wrote: From: Ivan Khoronzhuk Date: Tue, 7 Jun 2016 16:59:35 +0300 if (!cpsw_common_res_usage_state(priv)) { + int buf_num; struct cpsw_priv *priv_sl0 = cpsw_get_slave_priv(priv, 0); Please always order local variable d

Re: [PATCH] net: ethernet: ti: cpsw: use destroy ctlr to destroy channels

2016-06-11 Thread Ivan Khoronzhuk
On 11.06.16 04:17, David Miller wrote: From: Ivan Khoronzhuk Date: Sat, 11 Jun 2016 01:11:54 +0300 Based on master master... of what? master of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git but it's applicable on linux-next master also. -- Regards, Ivan Khoronzhuk

Re: [PATCH next] sched: remove NET_XMIT_POLICED

2016-06-11 Thread Florian Westphal
David Miller wrote: > I have to revert this, the sch_atm.c change is wrong. > > NET_XMIT_POLICED is the default value of 'ret' which can be used > if we branch to 'drop'. So now GCC says that 'ret' might be used > uninitialized. Hmpf, seems I need to update gcc :-| > So it is actually used, an

Re: [PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround

2016-06-11 Thread Shawn Guo
On Fri, Jun 03, 2016 at 06:31:19PM +0200, Lucas Stach wrote: > The i.MX6 Q/DL has an erratum (ERR006687) that prevents the FEC from > waking the CPUs when they are in wait(unclocked) state. As the hardware > workaround isn't applicable to all boards, disable the deeper idle state > when the workaro

[mac80211-next:master] e69f73bfecb0178ae6bd20eb778211739cd71fab BUILD DONE

2016-06-11 Thread kbuild test robot
https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master e69f73bfecb0178ae6bd20eb778211739cd71fab Merge branch 'remove-qdisc-throttle' drivers/net/virtio_net.c:841:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Error ids grouped by kconfigs: recent_err

Re: pull-request: mac80211-next 2016-06-09

2016-06-11 Thread Johannes Berg
On Fri, 2016-06-10 at 23:16 -0700, David Miller wrote: > > Can I ask you to pull net into net-next, preferably before merging > > this? > Looks good, pulled, thanks! Thanks! I see you also had pulled net in for other reasons, so I'll include the hwsim namespace patch in the next pull request :)

[net:master 4/8] net/ipv4/ipconfig.c:130:15: warning: 'ic_addrservaddr' defined but not used

2016-06-11 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: 92ca8241533009e4e05a9f3999a75389678af094 commit: 0b392be9a86560dae3af2e7528f226ff465ab549 [4/8] net: ipconfig: avoid warning by making ic_addrservaddr static config: frv-defconfig (attached as .config) compiler: f

Re: [PATCH next] sched: remove NET_XMIT_POLICED

2016-06-11 Thread David Miller
From: David Miller Date: Fri, 10 Jun 2016 23:31:37 -0700 (PDT) > From: Florian Westphal > Date: Fri, 10 Jun 2016 14:21:29 +0200 > >> ... its not returned anywhere. >> >> BATMAN uses it as an intermediate return value to signal >> forwarding vs. buffering, but it will not return POLICED to >> c