W5500 has different bit position for MAC filter in Socket n mode
register from W5100 and W5200.
Signed-off-by: Akinobu Mita
Cc: Mike Sinkovsky
Cc: David S. Miller
---
* No changes from v1
drivers/net/ethernet/wiznet/w5100.c | 17 +
1 file changed, 13 insertions(+), 4 deletions
This adds support to specify the MAC address by 'mac-address' or
'local-mac-address' properties in the device tree. These are common
properties for the Ethernet controller.
Signed-off-by: Akinobu Mita
Cc: Mike Sinkovsky
Cc: David S. Miller
---
* No changes from v1
drivers/net/ethernet/wiznet
This increases TX timeout period from one second to 5 seconds which is
the default value if the driver doesn't explicitly set
net_device->watchdog_timeo.
The one second timeout is too short for W5100 with SPI interface mode
which doesn't support burst READ/WRITE processing in the SPI transfer.
If
This patch series is the collection of relatively small changes for
w5100 driver which includes a cleanup with no functional change,
two fixes, and adding a functionality.
* Changes from v1
- Remove the watchdong_timeo assignment to set default tx timeout,
suggested by David Miller.
Akinobu Mit
The is_w5200() function is not used anymore by the commit which adds
the W5500 support.
Signed-off-by: Akinobu Mita
Cc: Mike Sinkovsky
Cc: David S. Miller
---
* No changes from v1
drivers/net/ethernet/wiznet/w5100.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/
HI Andrew,
On Fri, May 13, 2016 at 11:13 PM, Andrew Lunn wrote:
> Hi Harini
>
> Is this backward compatible? Will devices using the old binding still
> work?
It isn't right now.
I will have to assign the bus read/write functions conditionally in order to
do that - I'll see if I can make it clean
Florian Weber reported:
> Under full load (unshare() in loop -> OOM conditions) we can
> get kernel panic:
>
> BUG: unable to handle kernel NULL pointer dereference at 0008
> IP: [] nfqnl_nf_hook_drop+0x35/0x70
> [..]
> task: 88012dfa3840 ti: 88012dffc000 task.ti: 88012dffc
On May 13, 2016, at 4:12 PM, Guy Harris wrote:
> drivers/net/ethernet/freescale/gianfar*.c
>
> reports HWTSTAMP_FILTER_ALL even if the device doesn't have
> FSL_GIANFAR_DEV_HAS_TIMER set so that it claims that devices without a timer
> can do hardware timestamping,
Nope - I checked, and
On Fri, 2016-05-13 at 16:53 -0700, Iyappan Subramanian wrote:
> This patch fixes the race condition on updating the statistics
> counters by moving the counters to the ring structure.
>
...
> @@ -1127,12 +1127,31 @@ static struct rtnl_link_stats64
> *xgene_enet_get_stats64(
> {
> struct
Hi David,
Vivien Didelot writes:
> Now that the bridge code defers the switchdev port state setting, there
> is no need to defer the port STP state change within the mv88e6xxx code.
> Thus get rid of the driver's bridge work code.
>
> This also fixes a race condition where the DSA layer assumes
From: Iyappan Subramanian
Date: Fri, 13 May 2016 16:52:56 -0700
> This patch set addresses the following bug fixes that were found during
> testing.
>
> 1. IPv4 forward test crash
> - drivers: net: xgene: fix IPv4 forward crash
>
> 2. Sharing of irqs
> - drivers: net: xgene: fix sh
From: Jeff Kirsher
Date: Fri, 13 May 2016 16:43:41 -0700
> This series contains updates to e1000e, igb and igbvf.
Pulled, thanks Jeff.
Florian Westphal writes:
> Eric W. Biederman wrote:
>> Florian could you test and verify this patch fixes your issues?
>
> Yes, this seems to work.
>
> Pablo, I'm fine with this patch going into -nf/stable but I do not think
> making the pointers per netns is a desireable option in the long term
Hi,
I hope this is the right group even though it concerns mainly
development but I have not found a better one.
I would like to route locally-generated traffic:
- to a TCP port "A" of host "H" via the interface "A",
- to a TCP port "B" of host "H" via the interface "B".
Interface "B" is sometim
Now that the bridge code defers the switchdev port state setting, there
is no need to defer the port STP state change within the mv88e6xxx code.
Thus get rid of the driver's bridge work code.
This also fixes a race condition where the DSA layer assumes that the
bridge code already set the unbridge
This patch fixes the race condition on updating the statistics
counters by moving the counters to the ring structure.
Signed-off-by: Iyappan Subramanian
Tested-by: Toan Le
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 19 ++-
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h |
This patch set addresses the following bug fixes that were found during testing.
1. IPv4 forward test crash
- drivers: net: xgene: fix IPv4 forward crash
2. Sharing of irqs
- drivers: net: xgene: fix sharing of irqs
3. Ununiform latency across queues
- drivers: net: xgene: fix
This patch addresses ununiform latency across queues by adding
more queues to match with, upto number of CPU cores.
Also, number of interrupts are increased and the channel numbers
are reordered.
Signed-off-by: Iyappan Subramanian
Tested-by: Toan Le
---
drivers/net/ethernet/apm/xgene/xgene_ene
This patch fixes the crash observed during IPv4 forward test by
setting the drop field in the dbptr.
Signed-off-by: Iyappan Subramanian
Tested-by: Toan Le
---
drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 11 ++-
drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 2 ++
2 files chang
Since hardware doesn't allow sharing of interrupts,
this patch fixes the same by removing IRQF_SHARED flag.
Signed-off-by: Iyappan Subramanian
Tested-by: Toan Le
---
drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/
This patch fixes SG_RX_DV_GATE_REG_0_ADDR register offset
and ring state field lengths.
Signed-off-by: Iyappan Subramanian
Tested-by: Toan Le
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 6 +++---
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.h | 2 +-
2 files changed, 4 insertions
From: Jacob Keller
To prevent signed bitshift issues, and improve code readability, use the
BIT() macro. Also make use of GENMASK or the unsigned postfix where this
is more appropriate than BIT()
Signed-off-by: Jacob Keller
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/igbvf/defi
From: Denys Vlasenko
"incvalue" variable holds a result of "er32(TIMINCA) &
E1000_TIMINCA_INCVALUE_MASK" and used in "do_div(temp, incvalue)"
as a divisor.
Thus, "u64 incvalue" declaration is probably a mistake.
Even though it seems to be a harmless one, let's fix it.
Signed-off-by: Denys Vlase
From: Denys Vlasenko
If two consecutive reads of the counter are the same, it is also
not an overflow. "systimel_1 < systimel_2" should be
"systimel_1 <= systimel_2".
Before the patch, we could perform an *erroneous* correction:
Let's say that systimel_1 == systimel_2 == 0x.
"systimel_
From: Steve Shih
This patch fixes the issues for disabling auto-negotiation and forcing
speed and duplex settings for the non-copper media.
For non-copper media, e1000_get_settings should return ETH_TP_MDI_INVALID for
eth_tp_mdix_ctrl instead of ETH_TP_MDI_AUTO so subsequent e1000_set_settings
c
From: Jacob Keller
Signed-off-by: Jacob Keller
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/drivers/net/ethernet/intel/igb/igb_main.c
index 0191c5f..cab
From: Jacob Keller
For bitshifts, we should make use of the BIT macro when possible, and
ensure that other bitshifts are marked as unsigned. This helps prevent
signed bitshift errors, and ensures similar style.
Make use of GENMASK and the unsigned postfix where BIT() isn't
appropriate.
Signed-o
From: Jacob Keller
The variable rdlen is set but never used, and thus setting it is dead
code. Remove it.
Signed-off-by: Jacob Keller
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/igbvf/netdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/et
From: Denys Vlasenko
SYSTIMH:SYSTIML registers are incremented by 24-bit value TIMINCA[23..0]
er32(SYSTIML) are probably moderately expensive (they are pci bus reads).
Can we avoid one of them? Yes, we can.
If the SYSTIML value we see is smaller than 0xff00, the overflow
into SYSTIMH would
From: Nathan Sullivan
Table 7-62 on page 338 of the i210 datasheet lists TX and RX latencies
for the various speeds the chip supports. To give better PTP timestamp
accuracy, adjust the timestamps by the amounts Intel gives based on
current link speed.
Signed-off-by: Nathan Sullivan
Tested-by:
From: Alexander Duyck
This patch adds support for partial GSO segmentation in the case of
tunnels. Specifically with this change the driver an perform segmentation
as long as the frame either has IPv6 inner headers, or we are allowed to
mangle the IP IDs on the inner header. This is needed beca
From: Jacob Keller
The e1000e_config_hwtstamp function was incorrectly resetting the SYSTIM
registers every time the ioctl was being run. If you happened to be
running ptp4l and lost the PTP connect (removing cable, or blocking the
UDP traffic for example), then ptp4l will eventually perform a re
From: Jacob Keller
The E1000_ICH_NVM_SIG_MASK value is shifted, out to the 31st bit, which
is the signed bit for signed constants. Mark these values as unsigned to
prevent compiler warnings and issues on platforms which a different
signed bit implementation.
Signed-off-by: Jacob Keller
Signed-o
On Fri, May 13, 2016 at 11:56:12PM +0300, Sergei Shtylyov wrote:
> On 05/13/2016 11:44 PM, Andrew Lunn wrote:
>
> >>>Another issue is that on some boards we have one reset line tied to
> >>>multiple PHYs.How do we prevent multiple resets being taking place when
> >>>each of
> >>>the PHYs are regi
From: Jacob Keller
This prevents signed bitshift issues when the shift would overwrite the
signed bit, and prevents making this mistake in the future when copying
and modifying code.
Use GENMASK or the unsigned postfix for cases which aren't suitable for
BIT() macro.
Signed-off-by: Jacob Keller
This series contains updates to e1000e, igb and igbvf.
Steve Shih fixes an issue for disabling auto-negotiation and forcing
speed and duplex settings for non-copper media.
Brian Walsh cleanups some inconsistency in the use of return variables
names to avoid confusion.
Jake cleans up the drivers
From: Brian Walsh
Fixed the file to use a consistent ret_val for return value checking.
Signed-off-by: Brian Walsh
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/e1000e/netdev.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
libpcap offers the ability to request hardware time stamping for packets and to
inquire which forms of hardware time stamping, if any, are supported for an
interface.
The Linux implementation currently implements the inquiry by doing a
ETHTOOL_GET_TS_INFO SIOETHTOOL ioctl and looking at the so_
This function declares the 'err' local variable for no good reason, get rid
of it.
Signed-off-by: Sergei Shtylyov
---
drivers/net/phy/lxt.c |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
Index: net-next/drivers/net/phy/lxt.c
==
Both these functions declare the 'err' local variables for no good reason,
get rid of them.
Signed-off-by: Sergei Shtylyov
---
drivers/net/phy/lxt.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
Index: net-next/drivers/net/phy/lxt.c
=
Hello.
[Resending with the correct subject. Sorry about that :-/]
Here's the set of 2 patches against DaveM's 'net-next.git' repo. We save
several LoCs on the unneeded local variables
[1/2] lxt: simplify lxt97[01]_config_intr()
[2/2] lxt: simplify lxt970_config_init()
MBR, Sergei
Hello.
Here's the set of 2 patches against DaveM's 'net-next.git' repo. We save
several LoCs on the unneeded local variables
[1/2] lxt: simplify lxt97[01]_config_intr()
[2/2] lxt: simplify lxt970_config_init()
MBR, Sergei
On 13 May 2016 at 17:19, Bjorn Andersson wrote:
> On Fri 13 May 14:01 PDT 2016, Arnd Bergmann wrote:
>
>> On Tuesday 10 May 2016 11:39:34 Bjorn Andersson wrote:
> [..]
>> > I assume we could have the QRTR go through Andy and arm-soc, with
>> > David's approval and this fix squashed in. But we're r
On Fri 13 May 14:01 PDT 2016, Arnd Bergmann wrote:
> On Tuesday 10 May 2016 11:39:34 Bjorn Andersson wrote:
[..]
> > I assume we could have the QRTR go through Andy and arm-soc, with
> > David's approval and this fix squashed in. But we're running rather late
> > in this cycle, perhaps we should j
On 05/09/2016 11:04 PM, Lijun Ou wrote:
> +static void hns_roce_v1_cq_clean(struct hns_roce_cq *hr_cq, u32 qpn,
> + struct hns_roce_srq *srq)
> +{
> + spin_lock_irq(&hr_cq->lock);
> + hns_roce_v1_clean_cq(hr_cq, qpn, srq);
> + spin_unlock_irq(&hr_cq->lock);
On 05/09/2016 11:04 PM, Lijun Ou wrote:
> +int __hns_roce_cmd(struct hns_roce_dev *hr_dev, u64 in_param, u64 *out_param,
> +unsigned long in_modifier, u8 op_modifier, u16 op,
> +unsigned long timeout);
> +
> +/* Invoke a command with no output parameter */
> +static
Hello.
On 05/13/2016 10:06 AM, Uwe Kleine-König wrote:
[...]
Index: net-next/drivers/of/of_mdio.c
===
--- net-next.orig/drivers/of/of_mdio.c
+++ net-next/drivers/of/of_mdio.c
@@ -44,6 +44,7 @@ static int of_get_phy_id(struct device
On Fri, 15 Apr 2016 09:51:42 +0200
Jiri Pirko wrote:
> From: Jiri Pirko
>
> Jiri Pirko (11):
> devlink: fix "devlink port" help message
> list: add list_for_each_entry_reverse macro
> list: add list_add_tail helper
> devlink: introduce pr_out_port_handle helper
> devlink: introduce he
On Fri, 6 May 2016 15:28:25 +0100
Edward Cree wrote:
> Since we can only configure unicast, we probably want to be able to
> display unicast, rather than multicast.
>
> Fixes: 906ac5437ab8 ("geneve: add support for IPv6 link partners")
> Signed-off-by: Edward Cree
> ---
> I'm assuming this is w
On 05/09/2016 11:04 PM, Lijun Ou wrote:
> --- a/drivers/infiniband/hw/hns/hns_roce_device.h
> +++ b/drivers/infiniband/hw/hns/hns_roce_device.h
> @@ -29,10 +31,93 @@
> #define HNS_ROCE_AEQE_VEC_NUM1
> #define HNS_ROCE_AEQE_OF_VEC_NUM 1
>
> +#define ADDR_SHI
Eric W. Biederman wrote:
> Florian could you test and verify this patch fixes your issues?
Yes, this seems to work.
Pablo, I'm fine with this patch going into -nf/stable but I do not think
making the pointers per netns is a desireable option in the long term.
> Unlike the other possibilities th
Hello.
On 05/13/2016 07:06 AM, Andrew Lunn wrote:
+ gpiod = fwnode_get_named_gpiod(&child->fwnode, "reset-gpios");
+ /* Deassert the reset signal */
+ if (!IS_ERR(gpiod))
+ gpiod_direction_output(gpiod, 0);
This is wrong I think. You must only ignore -ENODEV, a
On 05/09/2016 11:04 PM, Lijun Ou wrote:
> The HiSilicon Network Substem is a long term evolution IP which is
> supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network
> Sybsystem) also has a hardware support of performing RDMA with
> RoCEE.
> The driver for HiSilicon RoCEE(RoCE Engine) is
Eric W. Biederman wrote:
> Florian Westphal writes:
>
> > Eric W. Biederman wrote:
> >> > AFAICS no other callers do something similar, but yes,
> >> > we'd need this all over the place if there are others.
> >> >
> >> > Maybe we need a saner fix, e.g. by adding bounds check to net_generic(),
>
On Tuesday 10 May 2016 11:39:34 Bjorn Andersson wrote:
> On Mon 09 May 18:29 PDT 2016, Stephen Rothwell wrote:
>
> > Hi all,
> >
> > After merging the net-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > net/qrtr/smd.c:106:14: error: initialization from inc
Hi Marcel,
> so I am not big fan of the conditional locking in case of parent is set or
> not. Do you have a test case that reproduces the mentioned race. It would
> love to have that in tools/l2cap-tester or similar.
So far I could only reproduce the bug by repeatedly performing RFCOMM
connec
Use setup_timer() and instead of init_timer(), being the preferred way
of setting up a timer.
Also, quoting the mod_timer() function comment:
-> mod_timer() is a more efficient way to update the expire field of an
active timer (if the timer is inactive it will be activated).
Use setup_timer()
Use setup_timer() and instead of init_timer(), being the preferred way
of setting up a timer.
Also, quoting the mod_timer() function comment:
-> mod_timer() is a more efficient way to update the expire field of an
active timer (if the timer is inactive it will be activated).
Use setup_timer()
Use setup_timer() and instead of init_timer(), being the preferred way
of setting up a timer.
Also, quoting the mod_timer() function comment:
-> mod_timer() is a more efficient way to update the expire field of an
active timer (if the timer is inactive it will be activated).
Use setup_timer()
On 05/13/2016 11:44 PM, Andrew Lunn wrote:
Another issue is that on some boards we have one reset line tied to
multiple PHYs.How do we prevent multiple resets being taking place when each of
the PHYs are registered?
My patch just doesn't address this case -- it's about the
individual resets
Florian could you test and verify this patch fixes your issues?
Unlike the other possibilities that have been discussed this also
addresses the nf_queue path as well as the nf_queue_hook_drop path.
And frankly that is the best argument I have for fixing it this way
because potentially nf_queue c
> >Another issue is that on some boards we have one reset line tied to
> >multiple PHYs.How do we prevent multiple resets being taking place when each
> >of
> >the PHYs are registered?
>
>My patch just doesn't address this case -- it's about the
> individual resets only.
This actually needs
On 05/13/2016 03:40 PM, Jeff Kirsher wrote:
> On Fri, 2016-05-13 at 12:50 -0400, Doug Ledford wrote:
>> On 05/01/2016 08:07 AM, Julia Lawall wrote:
>>> The i40e_client_ops structure is never modified, so declare it as
>> const.
>>>
>>> Done with the help of Coccinelle.
>>>
>>> Signed-off-by: Ju
Florian Westphal writes:
> Eric W. Biederman wrote:
>> > AFAICS no other callers do something similar, but yes,
>> > we'd need this all over the place if there are others.
>> >
>> > Maybe we need a saner fix, e.g. by adding bounds check to net_generic(),
>> > and making sure that net_generic() r
majord...@vger.kernel.org
Eric W. Biederman wrote:
> > AFAICS no other callers do something similar, but yes,
> > we'd need this all over the place if there are others.
> >
> > Maybe we need a saner fix, e.g. by adding bounds check to net_generic(),
> > and making sure that net_generic() returns non-NULL only if the per
>
Hi Stephen,
can you please comment on this or are you going to apply this?
On Mon, May 09, 2016 at 03:52:02PM +, Eli Cohen wrote:
> Hi Stephen,
>
> ibstat is usually used with MLNX_OFED distributions and I don't think it is a
> part of libibverbs.
> Moreover, in a previous patch I sent
> h
Florian Westphal writes:
> Eric W. Biederman wrote:
>> > On Wed, May 11, 2016 at 05:41:13PM +0200, Florian Westphal wrote:
>> >> diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c
>> >> index 5baa8e2..9722819 100644
>> >> --- a/net/netfilter/nf_queue.c
>> >> +++ b/net/netfilter/nf_
On Fri, 13 May 2016, Jeff Kirsher wrote:
> On Fri, 2016-05-13 at 12:50 -0400, Doug Ledford wrote:
> > On 05/01/2016 08:07 AM, Julia Lawall wrote:
> > > The i40e_client_ops structure is never modified, so declare it as
> > const.
> > >
> > > Done with the help of Coccinelle.
> > >
> > > Signed-
On Fri, 2016-05-13 at 12:50 -0400, Doug Ledford wrote:
> On 05/01/2016 08:07 AM, Julia Lawall wrote:
> > The i40e_client_ops structure is never modified, so declare it as
> const.
> >
> > Done with the help of Coccinelle.
> >
> > Signed-off-by: Julia Lawall
>
> Thanks, applied.
I already have
Hello.
On 05/13/2016 12:07 PM, Roger Quadros wrote:
[...]
+}
+EXPORT_SYMBOL(mdio_device_reset);
+
/**
* mdio_probe - probe an MDIO device
* @dev: device to probe
@@ -117,9 +126,16 @@ static int mdio_probe(struct device *dev
struct mdio_driver *mdiodrv = to_mdio_driver(drv);
One cpu can be processing packets which includes using the cached route
entries in the vrf device's private data and on another cpu the device
gets deleted which releases the routes and sets the pointers in net_vrf
to NULL. This results in datapath dereferencing a NULL pointer.
Fix by protecting a
Hello.
On 05/13/2016 12:35 AM, Sergei Shtylyov wrote:
[we already talked about this patch in #armlinux, I'm now just
forwarding my comments on the list. Background was that I sent an easier
and less complete patch with the same idea. See
http://patchwork.ozlabs.org/patch/621418/]
[added Linus
Hello.
On 05/13/2016 09:26 AM, Uwe Kleine-König wrote:
The framework only asserts (for now) that the reset gpio is not active.
Signed-off-by: Uwe Kleine-König
---
Documentation/devicetree/bindings/net/phy.txt | 3 +++
drivers/net/phy/phy_device.c | 8
2 files changed,
On 5/12/16, 11:03 PM, Jiri Pirko wrote:
> Thu, May 12, 2016 at 11:10:08PM CEST, ro...@cumulusnetworks.com wrote:
>> On 5/12/16, 4:48 AM, Jiri Pirko wrote:
>>> From: Nogah Frankel
>>>
>>> Till now we had a ndo statistics function that returned SW statistics.
>>> We want to change the "basic" statis
On 05/13/2016 11:21 AM, David Miller wrote:
From: Ben Greear
Date: Fri, 13 May 2016 09:57:19 -0700
How do you feel about a new socket-option to allow a socket to
request the old veth behaviour?
I depend upon the opinions of the experts who work upstream on and
maintain these components, sinc
From: Ben Greear
Date: Fri, 13 May 2016 09:57:19 -0700
> How do you feel about a new socket-option to allow a socket to
> request the old veth behaviour?
I depend upon the opinions of the experts who work upstream on and
maintain these components, since it is an area I am not so familiar
with.
On 16-05-12 05:08 PM, Sridhar Samudrala wrote:
> On devices that support TC U32 offloads, this flag enables a filter to be
> added only to HW. skip-sw and skip-hw are mutually exclusive flags. By
> default without any flags, the filter is added to both HW and SW, but no
> error checks are done in c
Hi Harini
Is this backward compatible? Will devices using the old binding still
work?
/* Disable RX and TX (XXX: Should we halt the transmission
* more gracefully?)
*/
- macb_writel(bp, NCR, 0);
+ ctrl = macb_readl(bp, NCR);
+ ctrl &= ~(MACB_BIT(RE) | MACB_BIT(TE));
+ macb_writel
On 16-05-12 05:08 PM, Sridhar Samudrala wrote:
> Signed-off-by: Sridhar Samudrala
> ---
Acked-by: John Fastabend
> + mdio {
> + compatible = "cdns,macb-mdio";
> + reg = <0x0 0xff0b 0x0 0x1000>;
> + clocks = <&clk125>, <&clk125>, <&clk125>;
> + clock-names = "pclk", "hclk", "tx_clk";
> + ethernet_phyC: ethernet-phy@C {
> +
On Fri, May 13, 2016 at 10:19 AM, Paolo Abeni wrote:
> The difference is small, in the noise range:
>
> [with this patch applied]
> super_netperf 100 -H 192.168.122.1 -t UDP_STREAM -l 60 -- -m 1
> 9.00
>
> [adding the test into __local_bh_enable_ip(), too]
> super_netperf 100 -H 192.168.122.1 -t
On Fri, 2016-05-13 at 16:54 +0200, Jiri Pirko wrote:
> From: Nogah Frankel
>
> Since hardware stats are now returned by default, add a way to
> query only software stats.
> They are saved in IFLA_SW_STATS64.
> (This option is valid only if the driver return HW stats in the
> default ndo stats)
>
On Fri, 2016-05-13 at 10:03 -0700, Eric Dumazet wrote:
> On Fri, May 13, 2016 at 9:50 AM, Paolo Abeni wrote:
>
> >> Indeed, and the patch looks quite simple now ;)
> >>
> >> diff --git a/kernel/softirq.c b/kernel/softirq.c
> >> index
> >> 17caf4b63342d7839528f367b283a386413b0362..23c364485d03618
On Fri, 2016-05-13 at 16:54 +0200, Jiri Pirko wrote:
> From: Nogah Frankel
]
> +bool dev_have_sw_stats(struct net_device *dev)
> +{
> + return (dev->netdev_ops->ndo_get_sw_stats64 != NULL);
> +}
> +EXPORT_SYMBOL(dev_have_sw_stats);
> +
2 things : const, and return is not a function.
bool dev
Split the HAVE_BPF_JIT into two for distinguishing cBPF and eBPF JITs.
Current cBPF ones:
# git grep -n HAVE_CBPF_JIT arch/
arch/arm/Kconfig:44:select HAVE_CBPF_JIT
arch/mips/Kconfig:18: select HAVE_CBPF_JIT if !CPU_MICROMIPS
arch/powerpc/Kconfig:129: select HAVE_CBPF_JIT
ar
This patch adds recently added constant blinding helpers into the
s390 eBPF JIT. In the bpf_int_jit_compile() path, requirements are
to utilize bpf_jit_blind_constants()/bpf_jit_prog_release_other()
pair for rewriting the program into a blinded one, and to map the
BPF_REG_AX register to a CPU regis
Move the bpf_jit_enable declaration to the filter.h file where
most other core code is declared, also since we're going to add
a second knob there.
Signed-off-by: Daniel Borkmann
Acked-by: Alexei Starovoitov
---
include/linux/filter.h| 2 ++
include/linux/netdevice.h | 1 -
2 files changed,
This patch adds recently added constant blinding helpers into the
arm64 eBPF JIT. In the bpf_int_jit_compile() path, requirements are
to utilize bpf_jit_blind_constants()/bpf_jit_prog_release_other()
pair for rewriting the program into a blinded one, and to map the
BPF_REG_AX register to a CPU regi
This set implements constant blinding for BPF, first couple of
patches are some preparatory cleanups, followed by the blinding.
Please see individual patches for details.
Thanks a lot!
Daniel Borkmann (10):
bpf: minor cleanups in ebpf code
bpf: move bpf_jit_enable declaration
bpf: split HAV
Besides others, remove redundant comments where the code is self
documenting enough, and properly indent various bpf_verifier_ops
and bpf_prog_type_list declarations. Moreover, remove two exports
that actually have no module user.
Signed-off-by: Daniel Borkmann
Acked-by: Alexei Starovoitov
---
Move the functionality to patch instructions out of the verifier
code and into the core as the new bpf_patch_insn_single() helper
will be needed later on for blinding as well. No changes in
functionality.
Signed-off-by: Daniel Borkmann
Acked-by: Alexei Starovoitov
---
include/linux/filter.h |
Since the blinding is strictly only called from inside eBPF JITs,
we need to change signatures for bpf_int_jit_compile() and
bpf_prog_select_runtime() first in order to prepare that the
eBPF program we're dealing with can change underneath. Hence,
for call sites, we need to return the latest prog.
This patch adds recently added constant blinding helpers into the
x86 eBPF JIT. In the bpf_int_jit_compile() path, requirements are
to utilize bpf_jit_blind_constants()/bpf_jit_prog_release_other()
pair for rewriting the program into a blinded one, and to map the
BPF_REG_AX register to a CPU regist
There is never such a situation, where bpf_int_jit_compile() is
called with either prog as NULL or len as 0, so the tests are
unnecessary and confusing as people would just copy them. s390
doesn't have them, so no change is needed there.
Signed-off-by: Daniel Borkmann
Acked-by: Alexei Starovoitov
This work adds a generic facility for use from eBPF JIT compilers
that allows for further hardening of JIT generated images through
blinding constants. In response to the original work on BPF JIT
spraying published by Keegan McAllister [1], most BPF JITs were
changed to make images read-only and st
On Fri, May 13, 2016 at 9:50 AM, Paolo Abeni wrote:
>> Indeed, and the patch looks quite simple now ;)
>>
>> diff --git a/kernel/softirq.c b/kernel/softirq.c
>> index
>> 17caf4b63342d7839528f367b283a386413b0362..23c364485d03618773c385d943c0ef39f5931d09
>> 100644
>> --- a/kernel/softirq.c
>> +++
Mr Miller:
How do you feel about a new socket-option to allow a socket to
request the old veth behaviour?
Thanks,
Ben
On 04/30/2016 10:30 PM, Willy Tarreau wrote:
On Sat, Apr 30, 2016 at 03:43:51PM -0700, Ben Greear wrote:
On 04/30/2016 03:01 PM, Vijay Pandurangan wrote:
Consider:
- App A
On 05/01/2016 08:07 AM, Julia Lawall wrote:
> The i40e_client_ops structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
Thanks, applied.
--
Doug Ledford
GPG KeyID: 0E572FDD
signature.asc
Description: Open
1 - 100 of 185 matches
Mail list logo
