> From: David Miller [mailto:da...@davemloft.net]
> Sent: Sunday, May 8, 2016 1:41
> To: Dexuan Cui
> Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com; cav...@redhat.com;
Hi,
On Sat, 7 May 2016 20:25:40 -0600 David Ahern wrote:
> > - On which circumstances we end up entering
> > l3mdev_ip_rcv/l3mdev_ip6_rcv where skb->dev is the master?
> > If I got it right, we enter 'ip_rcv_finish' on a slave device,
> > the callback is invoked and eventually sets
On Fri, 2016-05-06 at 18:19 -0700, Eric Dumazet wrote:
> From: Eric Dumazet
>
> When using ifb+netem on ingress on SIT/IPIP/GRE traffic,
> GRO packets are not properly processed.
>
> Segmentation should not be forced, since ifb is already adding
> quite a performance hit.
>
> Signed-off-by: Eri
On Fri, May 06, 2016 at 10:43:25AM -0500, Eli Cohen wrote:
> Add two NLA's that allow configuration of Infiniband node or port GUIDs
> by referencing the IPoIB net device set over then physical function. The
> format to be used is as follows:
>
> ip link set dev ib0 vf 0 node_guid 00:02:c9:03:00:2
Applications such as OSPF and BFD need the original ingress device not
the VRF device; the latter can be derived from the former. To that end
add the skb_iif to inet_skb_parm and set it in ipv4 code after clearing
the skb control buffer similar to IPv6. From there the pktinfo can just
pull it from
Currently the VRF driver uses the rx_handler to switch the skb device
to the VRF device. Switching the dev prior to the ip / ipv6 layer
means the VRF driver has to duplicate IP/IPv6 processing which adds
overhead and makes features such as retaining the ingress device index
more complicated than ne
Applications such as OSPF and BFD need the original ingress device not
the VRF device; the latter can be derived from the former. To that end
move the packet intercept from an rx handler that is invoked by
__netif_receive_skb_core to the ipv4 and ipv6 receive processing.
IPv6 already saves the skb
On 5/7/16 12:32 PM, Shmulik Ladkani wrote:
Hi David,
On Sat, 7 May 2016 08:50:49 -0600 David Ahern wrote:
+static inline
+struct sk_buff *l3mdev_l3_rcv(struct sk_buff *skb, u16 proto)
+{
+ struct net_device *master = NULL;
+
+ if (netif_is_l3_slave(skb->dev))
+ master
On Sun, 2016-05-08 at 00:56 +0200, Philippe Reynes wrote:
> On 07/05/16 13:59, Ben Hutchings wrote:
> >
> > On Sat, 2016-05-07 at 01:18 +0200, Philippe Reynes wrote:
> > >
> > > The callback {get|set}_link_ksettings are often defined
> > > in a very close way. There are mainly two differences in
First patch preps for the second. The second is required for several use
cases such as ping on an interface and BFD that need to send packets on
a specific interface, including ones enslaved to a VRF device.
v2
- fixed brackets on both patches per comment from DaveM
David Ahern (2):
net: l3mdev
Allow udp and raw sockets to send by oif that is an enslaved interface
versus the l3mdev/VRF device. For example, this allows BFD to use ifindex
from IP_PKTINFO on a receive to send a response without the need to
convert to the VRF index. It also allows ping and ping6 to work when
specifying an ens
Move l3mdev_rt6_dst_by_oif and l3mdev_get_saddr to l3mdev.c. Collapse
l3mdev_get_rt6_dst into l3mdev_rt6_dst_by_oif since it is the only
user and keep the l3mdev_get_rt6_dst name for consistency with other
hooks.
A follow-on patch adds more code to these functions making them long
for inlined func
On 07/05/16 13:59, Ben Hutchings wrote:
On Sat, 2016-05-07 at 01:18 +0200, Philippe Reynes wrote:
The callback {get|set}_link_ksettings are often defined
in a very close way. There are mainly two differences in
those callback:
- the name of the netdev private structure
- the name of the struct p
All the chip_reset() methods repeat the code writing to the ARSTR register
and delaying for 1 ms, so that we can reuse sh_eth_chip_reset() twice.
Signed-off-by: Sergei Shtylyov
---
drivers/net/ethernet/renesas/sh_eth.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
Index:
sh_eth_chip_reset_giga() doesn't really need to use direct iowrite32() when
writing to the ARSTR register, it can use sh_eth_tsu_write() as all other
chip_reset() methods.
Signed-off-by: Sergei Shtylyov
---
drivers/net/ethernet/renesas/sh_eth.c |5 +++--
1 file changed, 3 insertions(+), 2
Hello.
Here's a set of 2 patches against DaveM's 'net-next.git' repo. We can save
on the repetitive chip reset code...
[1/2] sh_eth: call sh_eth_tsu_write() from sh_eth_chip_reset_giga()
[2/2] sh_eth: reuse sh_eth_chip_reset()
MBR, Sergei
Hi Andrew,
Andrew Lunn writes:
> On Fri, May 06, 2016 at 05:57:17PM -0400, Vivien Didelot wrote:
>> The 6131 switch models have a Core Tag Type register. Add a
>> MV88E6XXX_FLAG_CORE_TAG_TYPE flag and set the VLAN Ethertype to 0x8100
>> in the shared setup code if it is present.
>
> Do you have
Hi Andrew,
Andrew Lunn writes:
>> @@ -378,6 +385,7 @@ enum mv88e6xxx_cap {
>> #define MV88E6XXX_FLAG_EEPROM BIT(MV88E6XXX_CAP_EEPROM)
>> #define MV88E6XXX_FLAG_PPU BIT(MV88E6XXX_CAP_PPU)
>> #define MV88E6XXX_FLAG_SMI_PHY BIT(MV88E6XXX_CAP_SMI_PHY)
>> +#defi
Now that mdiobus_scan() doesn't return NULL on failure anymore, this driver
no longer needs to check for it...
Signed-off-by: Sergei Shtylyov
---
The patch is against DaveM's 'net-next.git' repo.
drivers/net/ethernet/marvell/pxa168_eth.c |2 --
1 file changed, 2 deletions(-)
Index: net-n
On Sat, May 7, 2016 at 8:39 PM, Sergei Shtylyov
wrote:
> On 05/07/2016 02:17 PM, Geert Uytterhoeven wrote:
>
>> When reopening the network device on ra7795/salvator-x, e.g. after a
>> DHCP timeout:
>>
>> IP-Config: Reopening network devices...
>> genirq: Flags mismatch irq 139.
From: Dan Carpenter
Date: Thu, 5 May 2016 16:20:20 +0300
> The error handling is broken here. netxen_rom_fast_read() returns zero
> on success and -EIO on error. It never returns -1.
>
> Signed-off-by: Dan Carpenter
Applied.
From: Dan Carpenter
Date: Thu, 5 May 2016 16:19:44 +0300
> My static checker complains that we are using "autoneg" without
> initializing it. The problem is the ->phy_read() condition is reversed
> so we only set this on error instead of success.
>
> Signed-off-by: Dan Carpenter
Applied.
From: Dan Carpenter
Date: Thu, 5 May 2016 16:18:46 +0300
> My static checker complained that "v" can be used unintialized if
> netxen_rom_fast_read() returns -EIO. That function never actually
> returns -1.
>
> Signed-off-by: Dan Carpenter
Applied.
From: Hariprasad Shenai
Date: Thu, 5 May 2016 11:05:39 +0530
> When cxgb4 is enabled with CONFIG_CHELSIO_T4_DCB set, VI enable command
> gets called with DCB enabled. But when we have a back to back setup with
> DCB enabled on one side and non-DCB on the Peer side. Firmware doesn't
> send any DC
From: Paul Durrant
Date: Thu, 5 May 2016 12:19:28 +0100
> +struct xenvif_hash_cache {
> + rwlock_t lock;
You really don't want to lock on every SKB hash computation like
this, turn this into a spin lock for locking the write side and
use RCU locking for lookup and usage.
THanks.
Hi,
On Sat, 7 May 2016 08:53:44 -0600 David Ahern wrote:
> >> @@ -1193,7 +1193,12 @@ void ipv4_pktinfo_prepare(const struct sock *sk,
> >> struct sk_buff *skb)
> >> ipv6_sk_rxinfo(sk);
> >>
> >>if (prepare && skb_rtable(skb)) {
> >> - pktinfo->ipi_ifindex = inet_ii
From: David Ahern
Date: Wed, 4 May 2016 21:54:09 -0700
> + if (dev && netif_is_l3_master(dev) &&
> + dev->l3mdev_ops->l3mdev_get_saddr) {
> + rc = dev->l3mdev_ops->l3mdev_get_saddr(dev, fl4);
> + }
Please do not use braces for single s
On 4/21/2016 10:59 PM, Fugang Duan wrote:
> From: Troy Kisky Sent: Friday, April 22,
> 2016 10:01 AM
>> To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan
>> ; lzn...@gmail.com
>> Cc: Fabio Estevam ; l.st...@pengutronix.de;
>> and...@lunn.ch; trem...@gmail.com; g...@uclinux.org; linux-a
Hi Dave,
Here are a few more Bluetooth patches for the 4.7 kernel:
- NULL pointer fix in hci_intel driver
- New Intel Bluetooth controller id in btusb driver
- Added device tree binding documentation for Marvel's bt-sd8xxx
- Platform specific wakeup interrupt support for btmrvl driver
Please
Hello.
On 05/07/2016 02:17 PM, Geert Uytterhoeven wrote:
When reopening the network device on ra7795/salvator-x, e.g. after a
DHCP timeout:
IP-Config: Reopening network devices...
genirq: Flags mismatch irq 139. (eth0:ch24:emac) vs. (
Unwrapped line this time?
Hello.
On 05/07/2016 02:17 PM, Geert Uytterhoeven wrote:
When reopening the network device on ra7795/salvator-x, e.g. after a
DHCP timeout:
IP-Config: Reopening network devices...
genirq: Flags mismatch irq 139. (eth0:ch24:emac) vs.
(eth0:ch24:emac)
ravb e6800
Hi David,
On Sat, 7 May 2016 08:50:49 -0600 David Ahern wrote:
> >> +static inline
> >> +struct sk_buff *l3mdev_l3_rcv(struct sk_buff *skb, u16 proto)
> >> +{
> >> + struct net_device *master = NULL;
> >> +
> >> + if (netif_is_l3_slave(skb->dev))
> >> + master = netdev_master_upper_dev
The MACsec standard mentions a key identifier for each key, but
doesn't specify anything about it, so I arbitrarily chose 64 bits.
IEEE 802.1X-2010 specifies MKA (MACsec Key Agreement), and defines the
key identifier to be 128 bits (96 bits "member identifier" + 32 bits
"key number").
Signed-off-
From: Ben Hutchings
Date: Sat, 07 May 2016 13:04:46 +0100
> On Fri, 2016-05-06 at 16:12 -0700, Shrikrishna Khare wrote:
> [...]
>> +static int
>> +vmxnet3_set_coalesce(struct net_device *netdev, struct ethtool_coalesce *ec)
>> +{
> [...]
>> +switch (ec->rx_coalesce_usecs) {
>> +case VMXNE
From: Dexuan Cui
Date: Sat, 7 May 2016 10:49:25 +
> I should be able to make 'send', 'recv' here to pointers and use vmalloc()
> to allocate the memory for them. I will do this.
That's still unswappable kernel memory.
People can open N sockets, where N is something on the order of the FD
l
On 5/7/16 2:41 AM, Shmulik Ladkani wrote:
Hi David,
On Fri, 6 May 2016 18:49:41 -0700 David Ahern wrote:
Applications such as OSPF and BFD need the original ingress device not
the VRF device;
Would you consider this true for any IP_PKTINFO users in VRF setups?
yes. I was just giving speci
On 5/7/16 2:30 AM, Shmulik Ladkani wrote:
Hi David,
On Fri, 6 May 2016 18:49:40 -0700 David Ahern wrote:
+static bool ipv6_ndisc_frame(const struct sk_buff *skb)
+{
+ const struct ipv6hdr *ipv6h = (struct ipv6hdr *)skb->data;
+ size_t hlen = sizeof(*ipv6h);
+ bool rc = false
From: Jamal Hadi Salim
This is what used to happen before:
tc filter add dev tap1 parent : protocol 0xfefe prio 10 \
u32 match u32 0 0 flowid 1:16 \
action ife decode allow mark ok
tc -s filter ls dev tap1 parent :
filter protocol [65278] pref 10 u32
filter protocol [65278] pr
From: Jamal Hadi Salim
This action allows for a sending side to encapsulate arbitrary metadata
which is decapsulated by the receiving end.
The sender runs in encoding mode and the receiver in decode mode.
Both sender and receiver must specify the same ethertype.
At some point we hope to have a re
From: Jamal Hadi Salim
Signed-off-by: Jamal Hadi Salim
---
include/uapi/linux/tc_act/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/tc_act/Kbuild b/include/uapi/linux/tc_act/Kbuild
index 242cf0c..e3969bd 100644
--- a/include/uapi/linux/tc_act/Kbuild
+++ b/include/
On 16-04-25 08:28 AM, Jamal Hadi Salim wrote:
On 16-04-22 01:00 PM, Stephen Hemminger wrote:
On Thu, 21 Apr 2016 17:40:14 -0400
All header files for iproute2 (in include/linux) should come from
santized kernel
headers. I do not see the file tc_ife.h in include/uapi/linux in
current net-next
On 16-05-06 06:55 PM, Eric Dumazet wrote:
From: Eric Dumazet
TC_ACT_STOLEN is used when ingress traffic is mirred/redirected
to say ifb.
Packet is not dropped, but consumed.
Only TC_ACT_SHOT is a clear indication something went wrong.
Signed-off-by: Eric Dumazet
Acked-by: Jamal Hadi Salim
On Fri, 2016-05-06 at 16:12 -0700, Shrikrishna Khare wrote:
[...]
> +static int
> +vmxnet3_set_coalesce(struct net_device *netdev, struct ethtool_coalesce *ec)
> +{
[...]
> + switch (ec->rx_coalesce_usecs) {
> + case VMXNET3_COALESCE_DEFAULT:
> + case VMXNET3_COALESCE_DISABLED:
> +
On Sat, 2016-05-07 at 01:18 +0200, Philippe Reynes wrote:
> The callback {get|set}_link_ksettings are often defined
> in a very close way. There are mainly two differences in
> those callback:
> - the name of the netdev private structure
> - the name of the struct phydev in the private structure
>
When reopening the network device on ra7795/salvator-x, e.g. after a
DHCP timeout:
IP-Config: Reopening network devices...
genirq: Flags mismatch irq 139. (eth0:ch24:emac) vs.
(eth0:ch24:emac)
ravb e680.ethernet eth0: cannot request IRQ eth0:ch24:emac
IP-Conf
When reopening the network device on ra7795/salvator-x, e.g. after a
DHCP timeout:
IP-Config: Reopening network devices...
genirq: Flags mismatch irq 139. (eth0:ch24:emac) vs. (
ravb e680.ethernet eth0: cannot request IRQ eth0:ch24:emac
IP-Config: Failed to op
Hi Dave,
When reopening the network device on ra7795/salvator-x, e.g. after a
DHCP timeout:
IP-Config: Reopening network devices...
genirq: Flags mismatch irq 139. (eth0:ch24:emac) vs. (
ravb e680.ethernet eth0: cannot request IRQ eth0:ch24:emac
IP-Co
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Saturday, May 7, 2016 1:04
> To: Dexuan Cui
> Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; jasow...@redhat.com; cav...@redhat.co
On 06/05/16 10:42, Jesper Dangaard Brouer wrote:
> Hi Felix,
>
> This is an important fix for OpenWRT, please read!
>
> OpenWRT changed the default fq_codel sch->limit from 10240 to 1024,
> without also adjusting q->flows_cnt. Eric explains below that you must
> also adjust the buckets (q->flows
The MAC address of the physical interface is only copied to the VLAN
when it is first created, resulting in an inconsistency after MAC
address changes of only newly created VLANs having an up-to-date MAC.
The VLANs should continue inheriting the MAC address of the physical
interface until the VLAN
On 05/06/2016 08:48 PM, Alexander Duyck wrote:
> On Fri, May 6, 2016 at 12:36 PM, Mike Manning wrote:
>> On 05/06/2016 06:02 PM, Alexander Duyck wrote:
>>> On Fri, May 6, 2016 at 6:26 AM, Mike Manning wrote:
The MAC address of the physical interface is only copied to the VLAN
when it is
2016-05-05 14:13 GMT+03:00 Edward Cree :
> On 05/05/16 08:40, Ilya Matveychikov wrote:
> > Is there any docs except the kernel sources itself to refer to?
> davem has some docs up at http://vger.kernel.org/~davem/skb.html and
> http://vger.kernel.org/~davem/skb_data.html
> In particular note the f
Joe Stringer wrote:
> > If so, probably I can append this as comment to this function so we
> > don't forget. If we ever have .exit callbacks (I don't expect so), we
> > would need to wait for worker completion.
>
> Sounds reasonable to me.
>
> I see there's a bunch of other unregister locations
Hi David,
On Fri, 6 May 2016 18:49:41 -0700 David Ahern wrote:
> Applications such as OSPF and BFD need the original ingress device not
> the VRF device;
Would you consider this true for any IP_PKTINFO users in VRF setups?
> @@ -1193,7 +1193,12 @@ void ipv4_pktinfo_prepare(const struct sock *s
Murali Karicheri :
[...]
> I am trying to integrate the rtl8168 PCIe card to have Ethernet functional
> on my Keystone EVM.
Which (EVM) one ?
> I purchased the rtl8111c Gib card from Amazon. The Card is detected
> by the RC and I can see it is enumerated and show up when doing lspci command.
Wh
Hi David,
On Fri, 6 May 2016 18:49:40 -0700 David Ahern wrote:
> +static bool ipv6_ndisc_frame(const struct sk_buff *skb)
> +{
> + const struct ipv6hdr *ipv6h = (struct ipv6hdr *)skb->data;
> + size_t hlen = sizeof(*ipv6h);
> + bool rc = false;
> +
> + if (ipv6h->nexthdr == NEXTH
Hi,
On 07-05-16 07:30, Chen-Yu Tsai wrote:
Hi,
On Tue, Apr 12, 2016 at 9:38 AM, Chen-Yu Tsai wrote:
On Tue, Apr 12, 2016 at 3:23 AM, Florian Fainelli wrote:
On 04/04/16 09:22, Chen-Yu Tsai wrote:
The Allwinner H3 SoC incorporates an Ethernet PHY. This is enabled and
configured through a me
Hi,
On Fri, 06 May 2016 05:58:21 -0700 Eric Dumazet wrote:
> From: Eric Dumazet
>
> If GSO packet is segmented and its segments are properly queued,
> we call consume_skb() instead of kfree_skb() to be drop monitor
> friendly.
>
> Fixes: 3e4f8b7873709 ("macvtap: Perform GSO on forwarding path.
58 matches
Mail list logo
