[PATCH] rtlwifi:rtl_lps_enter: fix double check cnt_after_linked

2016-05-01 Thread Wang YanQing
We have checked cnt_after_linked in below code: " /*sleep after linked 10s, to let DHCP and 4-way handshake ok enough!! */ if (mac->cnt_after_linked < 5) return; " So the second check isn't necessary. This patch delete second check code. Signed-off-by: Wang YanQing --- drivers/net/wirel

Re: [PATCH] i40e: constify i40e_client_ops structure

2016-05-01 Thread Leon Romanovsky
On Sun, May 01, 2016 at 02:07:23PM +0200, Julia Lawall wrote: > The i40e_client_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Thanks Julia, Reviewed-by: Leon Romanovsky signature.asc Description: Digital sig

[PATCH] rtlwifi:rtl_watchdog_wq_callback: fix calling rtl_lps_enter|rtl_lps_leave in opposite condition

2016-05-01 Thread Wang YanQing
Commit a269913c52ad37952a4d9953bb6d748f7299c304 ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter() to use work queue") make a mistake, change the meaning of num_tx|rx_inperiod comparison test. Commit fd09ff958777cf583d7541f180991c0fc50bd2f7 ("rtlwifi: Remove extra workqueue for enter/leave powe

Re: Q: How to disable vlan strip in Intel igb driver ?

2016-05-01 Thread Ran Shalit
On Sun, May 1, 2016 at 11:51 PM, Peter Palúch wrote: > Hi Ran, > > >> Alex, >> I don't see rx-vlan-offload option in my ethtool. strange, maybe it is >> not available in all ethtool versions ? > > > According to my manpage for ethtool v4.5, the relevant -K option is > "rxvlan". > >> Hi Peter, >> Y

[GIT] Networking

2016-05-01 Thread David Miller
1) MODULE_FIRMWARE firmware string not correct for iwlwifi 8000 chips, from Sara Sharon. 2) Fix SKB size checks in batman-adv stack on receive, from Sven Eckelmann. 3) Leak fix on mac80211 interface add error paths, from Johannes Berg. 4) Cannot invoke napi_disable() with BH disabled in m

Re: [PATCH net] gre: do not pull header in ICMP error processing

2016-05-01 Thread David Miller
From: Jiri Benc Date: Fri, 29 Apr 2016 23:31:32 +0200 > iptunnel_pull_header expects that IP header was already pulled; with this > expectation, it pulls the tunnel header. This is not true in gre_err. > Furthermore, ipv4_update_pmtu and ipv4_redirect expect that skb->data points > to the IP head

Re: [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-05-01

2016-05-01 Thread David Miller
From: Jeff Kirsher Date: Sun, 1 May 2016 17:06:06 -0700 > This series contains updates to i40e and i40evf. Looks good, pulled, thanks Jeff.

Re: [net-next PATCH v2 5/9] mlx4: Add support for UDP tunnel segmentation with outer checksum offload

2016-05-01 Thread Alexander Duyck
On Sun, May 1, 2016 at 1:35 PM, Or Gerlitz wrote: > On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: >> This patch assumes that the mlx4 hardware will ignore existing IPv4/v6 >> header fields for length and checksum as well as the length and checksum >> fields for outer UDP headers. > > Hi

Re: [net-next PATCH v2 1/9] net: Disable segmentation if checksumming is not supported

2016-05-01 Thread Alexander Duyck
On Sun, May 1, 2016 at 1:30 PM, Or Gerlitz wrote: > On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: >> In the case of the mlx4 and mlx5 driver they do not support IPv6 checksum >> offload for tunnels. > > Alex, > > To clarify, when you say "not support IPv6 checksum for tunnels", you > re

Re: [PATCH] net: Implement net_dbg_ratelimited() for CONFIG_DYNAMIC_DEBUG case

2016-05-01 Thread David Miller
From: Tim Bingham Date: Fri, 29 Apr 2016 13:30:23 -0400 > Prior to commit d92cff89a0c8 ("net_dbg_ratelimited: turn into no-op > when !DEBUG") the implementation of net_dbg_ratelimited() was buggy > for both the DEBUG and CONFIG_DYNAMIC_DEBUG cases. > > The bug was that net_ratelimit() was being

Re: [PATCH] sctp: signal sk_data_ready earlier on data chunks reception

2016-05-01 Thread David Miller
From: Marcelo Ricardo Leitner Date: Fri, 29 Apr 2016 14:17:08 -0300 > Dave Miller pointed out that fb586f25300f ("sctp: delay calls to > sk_data_ready() as much as possible") may insert latency specially if > the receiving application is running on another CPU and that it would be > better if we

Re: [PATCH net v2 1/1] tipc: only process unicast on intended node

2016-05-01 Thread David Miller
From: Jon Maloy Date: Fri, 29 Apr 2016 10:40:24 -0400 > From: Hamish Martin > > We have observed complete lock up of broadcast-link transmission due to > unacknowledged packets never being removed from the 'transmq' queue. This > is traced to nodes having their ack field set beyond the sequence

Re: [PATCH net] cxgb3: fix out of bounds read

2016-05-01 Thread David Miller
From: Michal Schmidt Date: Fri, 29 Apr 2016 11:06:50 +0200 > An out of bounds read of 2 bytes was discovered in cxgb3 with KASAN. > > t3_config_rss() expects both arrays it gets as parameters to have > terminators. setup_rss(), the caller, forgets to add a terminator to > one of the arrays. Than

Re: [PATCH] net/smscx5xx: use the device tree for mac address

2016-05-01 Thread David Miller
From: Lubomir Rintel Date: Fri, 29 Apr 2016 09:05:59 +0200 > From: Arnd Bergmann > > This takes the MAC address for smsc75xx/smsc95xx USB network devices > from a the device tree. This is required to get a usable persistent > address on the popular beagleboard, whose hardware designers > accide

Re: [PATCH V2] mdio_bus: Fix MDIO bus scanning in __mdiobus_register()

2016-05-01 Thread David Miller
From: Marek Vasut Date: Mon, 2 May 2016 02:47:31 +0200 > Since commit b74766a0a0fe ("phylib: don't return NULL > from get_phy_device()") in linux-next, phy_get_device() will return > ERR_PTR(-ENODEV) instead of NULL if the PHY device ID is all ones. > > This causes problem with stmmac driver an

Re: [PATCH] mdio_bus: Fix MDIO bus scanning in __mdiobus_register()

2016-05-01 Thread Marek Vasut
On 05/02/2016 01:49 AM, David Miller wrote: > > Please respin this with the checkpatch errors fixed. Done and sent. > I don't have any opinion about the conditional parenthesis, so > don't worry about that. > OK Thanks! -- Best regards, Marek Vasut

[PATCH V2] mdio_bus: Fix MDIO bus scanning in __mdiobus_register()

2016-05-01 Thread Marek Vasut
Since commit b74766a0a0fe ("phylib: don't return NULL from get_phy_device()") in linux-next, phy_get_device() will return ERR_PTR(-ENODEV) instead of NULL if the PHY device ID is all ones. This causes problem with stmmac driver and likely some other drivers which call mdiobus_register(). I trigger

[net-next 15/15] i40e/i40evf: Add support for GSO partial with UDP_TUNNEL_CSUM and GRE_CSUM

2016-05-01 Thread Jeff Kirsher
From: Alexander Duyck This patch makes it so that i40e and i40evf can use GSO_PARTIAL to support segmentation for frames with checksums enabled in outer headers. As a result we can now send data over these types of tunnels at over 20Gb/s versus the 12Gb/s that was previously possible on my syste

[net-next 08/15] i40e: Use consistent type for vf_id

2016-05-01 Thread Jeff Kirsher
From: Jesse Brandeburg The driver was all over the place using signed or unsigned types for vf_id, when it should always be signed. This fixes warnings of type unsafe comparisons from gcc with W=2. Change-Id: I2cb681f83d0f68ca124d2e4131e4ac0d9f8a6b22 Signed-off-by: Jesse Brandeburg Tested-by:

[net-next 09/15] i40e: Drop extra copy of function

2016-05-01 Thread Jeff Kirsher
From: Jesse Brandeburg i40e_release_rx_desc was in two files, but was only used and needed in txrx.c. Get rid of the extra copy. Change-Id: I86e18239aa03531fc198b6c052847475084a9200 Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet

[net-next 11/15] i40e/i40evf : Bump driver version from 1.5.5 to 1.5.10

2016-05-01 Thread Jeff Kirsher
From: Harshitha Ramamurthy Signed-off-by: Harshitha Ramamurthy Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-05-01

2016-05-01 Thread Jeff Kirsher
This series contains updates to i40e and i40evf. The theme of this series is code reduction, with several code cleanups in this series. Starting with Neerav's removal of the code that implemented the HMC AQ APIs and calls, since they are now obsolete and not supported by firmware. Anjali changes

[net-next 07/15] i40e: PTP - avoid aggregate return warnings

2016-05-01 Thread Jeff Kirsher
From: Jesse Brandeburg Aggregate return warnings are when struct types are returned and must be copied to the lvalue with a struct copy by the compiler. This fixes warnings of type aggregate-return from gcc with W=2. Change-Id: I896b1bf514544bf0faeb458869d79914b9f1b168 Signed-off-by: Jesse Bran

[net-next 13/15] i40e: make use of BIT() macro to prevent left shift of signed values

2016-05-01 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 53 +++ 1 file changed, 25 insertions(+), 28 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq_c

[net-next 04/15] i40e: Remove HMC AQ API implementation

2016-05-01 Thread Jeff Kirsher
From: Neerav Parikh Remove the code that implements the HMC AQ APIs and call these APIs. This is done because these are obsolete APIs and are not supported by firmware. Change-ID: I5d771d8f37c3e16e7b0a972ff9b27e75aa2d05d4 Signed-off-by: Neerav Parikh Tested-by: Andrew Bowers Signed-off-by: Jef

[net-next 06/15] i40e: Fix uninitialized variable

2016-05-01 Thread Jeff Kirsher
From: Catherine Sullivan We have an uninitialized variable warning for valid_len for one case in validate_vf_mesg. To fix this, just initialize it to 0 at the top of the function and remove all of the now redundant assignments to 0 in the individual cases. Change-Id: Iacbd97f4c521ed8d662eef803a5

[net-next 03/15] i40e: Prevent falling to promiscuous if the VF is not trusted

2016-05-01 Thread Jeff Kirsher
From: Anjali Singhai Jain With this change a non trusted VF can never fall to promiscuous mode when there is no room for a MAC/VLAN filter. Change-Id: I8a155aa25c0bcdc6093414920c9ade4ee0bd20e8 Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers

[net-next 10/15] i40e: Update device ids for X722

2016-05-01 Thread Jeff Kirsher
From: Catherine Sullivan Add a device ID for X722. Change-Id: I574f2345ab341de98a6a1c212d0603af853e48b0 Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[net-next 12/15] i40e/i40evf: fix I40E_MASK signed shift overflow warnings

2016-05-01 Thread Jeff Kirsher
From: Jacob Keller GCC 6 has a new warning which will display when you attempt to left shift a signed value beyond the storage size of the type. I40E_MASK generates a mask value for 32bit registers. Properly typecast the mask value and place the values in parenthesis to prevent macro expansion is

[net-next 14/15] i40evf: make use of BIT() macro to avoid signed left shift

2016-05-01 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/i40evf/i40e_adminq_cmd.h| 44 +++--- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/intel/i40evf/i40e_adminq

[net-next 01/15] i40e: Change the default for VFs to be not privileged

2016-05-01 Thread Jeff Kirsher
From: Anjali Singhai Jain Make sure a VF is not trusted/privileged until its explicitly set for trust through the new NDO op interface. Change-Id: I476385c290d2b4901d8fceb29de43546accdc499 Signed-off-by: Anjali Singhai Jain Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net

[net-next 05/15] i40evf: RSS Hash Option parameters

2016-05-01 Thread Jeff Kirsher
From: Carolyn Wyborny This patch syncs the VF code for the changes made to the PF for the RSS hash tuple settings. Since the VF still cannot change the RSS hash settings, change the code to make this clear to the user. Previously, the default settings were returned in this function. However, th

[net-next 02/15] i40e: Limit the number of MAC and VLAN addresses that can be added for VFs

2016-05-01 Thread Jeff Kirsher
From: Anjali Singhai Jain If the VF is privileged/trusted it can do as it may please including but not limited to hogging resources and playing unfair. But if the VF is not privileged/trusted it still can add some number (8) of MAC and VLAN addresses. Other restrictions with respect to Port VLAN

Re: [PATCH net-next] net: dsa: mv88e6xxx: replace ds with ps where possible

2016-05-01 Thread David Miller
From: Vivien Didelot Date: Thu, 28 Apr 2016 21:24:06 -0400 > From: Andrew Lunn > > The dsa_switch structure ds is actually needed in very few places, > mostly during setup of the switch. The private structure ps is however > needed nearly everywhere. Pass ps, not ds internally. > > [vd: rebase

Re: [PATCH] mdio_bus: Fix MDIO bus scanning in __mdiobus_register()

2016-05-01 Thread David Miller
Please respin this with the checkpatch errors fixed. I don't have any opinion about the conditional parenthesis, so don't worry about that.

[PATCH net-next] fq_codel: add batch ability to fq_codel_drop()

2016-05-01 Thread Eric Dumazet
From: Eric Dumazet In presence of inelastic flows and stress, we can call fq_codel_drop() for every packet entering fq_codel qdisc. fq_codel_drop() is quite expensive, as it does a linear scan of 4 KB of memory to find a fat flow. Once found, it drops the oldest packet of this flow. Instead of

Re: [PATCH net-next 0/3] qed/qede: ethtool selftests support.

2016-05-01 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Thu, 28 Apr 2016 20:20:51 -0400 > This series adds the driver support for following selftests: > 1. Register test > 2. Memory test > 3. Clock test > 4. Interrupt test > 5. Internal loopback test > Patch (1) adds the qed driver infrastructure for selftests. Patc

Re: [PATCH net-next 1/1] tipc: set 'active' state correctly for first established link

2016-05-01 Thread David Miller
From: Jon Maloy Date: Thu, 28 Apr 2016 20:16:08 -0400 > When we are displaying statistics for the first link established between > two peers, it will always be presented as STANDBY although it in reality > is ACTIVE. > > This happens because we forget to set the 'active' flag in the link > insta

Re: [PATCH net-next] ila: ipv6/ila: fix nlsize calculation for lwtunnel

2016-05-01 Thread David Miller
From: Tom Herbert Date: Thu, 28 Apr 2016 17:12:29 -0700 > @@ -144,8 +144,12 @@ nla_put_failure: > > static int ila_encap_nlsize(struct lwtunnel_state *lwtstate) > { > - /* No encapsulation overhead */ > - return 0; > + return > + /* ILA_ATTR_LOCATOR */ > +

Re: [PATCH v3 net] soreuseport: Fix TCP listener hash collision

2016-05-01 Thread David Miller
From: Craig Gallek Date: Thu, 28 Apr 2016 19:24:32 -0400 > From: Craig Gallek > > I forgot to include a check for listener port equality when deciding > if two sockets should belong to the same reuseport group. This was > not caught previously because it's only necessary when two listening > s

Re: [PATCH net-next] of: of_mdio: Check if MDIO bus controller is available

2016-05-01 Thread David Miller
From: Florian Fainelli Date: Thu, 28 Apr 2016 14:55:10 -0700 > Add a check whether the 'struct device_node' pointer passed to > of_mdiobus_register() is an available (aka enabled) node in the Device > Tree. > > Rationale for doing this are cases where an Ethernet MAC provides a MDIO > bus contro

Re: [PATCH] net: l2tp: fix reversed udp6 checksum flags

2016-05-01 Thread David Miller
From: Wang Shanker Date: Fri, 29 Apr 2016 01:29:43 +0800 > This patch fixes a bug which causes the behavior of whether to ignore > udp6 checksum of udp6 encapsulated l2tp tunnel contrary to what > userspace program requests. > > When the flag `L2TP_ATTR_UDP_ZERO_CSUM6_RX` is set by userspace, it

[PATCH net 2/2] RDS: TCP: Synchrnozize accept() and connect() paths on t_conn_lock.

2016-05-01 Thread Sowmini Varadhan
An arbitration scheme for duelling SYNs is implemented as part of commit 241b271952eb ("RDS-TCP: Reset tcp callbacks if re-using an outgoing socket in rds_tcp_accept_one()") which ensures that both nodes involved will arrive at the same arbitration decision. However, this needs to be synchronized w

[PATCH net 0/2] RDS: TCP: sychronization during connection startup

2016-05-01 Thread Sowmini Varadhan
This patch series ensures that the passive (accept) side of the TCP connection used for RDS-TCP is correctly synchronized with any concurrent active (connect) attempts for a given pair of peers. Patch 1 in the series makes sure that the t_sock in struct rds_tcp_connection is only reset after any

Re: [PATCH v1 net] net/mlx4: Avoid wrong virtual mappings

2016-05-01 Thread David Miller
From: Sinan Kaya Date: Sun, 1 May 2016 16:12:13 -0400 > I just wanted to make sure that this patch is moving in the right > direction. You never need to wonder about this. If the patch is in an active state in the patchwork queue, which this one is, there is absolutely nothing you need to do no

[PATCH net 1/2] RDS:TCP: Synchronize rds_tcp_accept_one with rds_send_xmit when resetting t_sock

2016-05-01 Thread Sowmini Varadhan
There is a race condition between rds_send_xmit -> rds_tcp_xmit and the code that deals with resolution of duelling syns added by commit 241b271952eb ("RDS-TCP: Reset tcp callbacks if re-using an outgoing socket in rds_tcp_accept_one()"). Specifically, we may end up derefencing a null pointer in r

Re: [PATCH] drivers: net: xgene: constify xgene_cle_ops structure

2016-05-01 Thread Iyappan Subramanian
On Sun, May 1, 2016 at 5:36 AM, Julia Lawall wrote: > The xgene_cle_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > drivers/net/ethernet/apm/xgene/xgene_enet_cle.c |2 +- > drivers/net/ethernet/apm/xgen

[net-next PATCH v2 2/5] stmmac: dwmac-socfpga: add PM ops and resume function

2016-05-01 Thread Joachim Eastwood
Implement the needed PM callbacks in the driver instead of relying on the init/exit hooks in stmmac_platform. This gives the driver more flexibility in how the code is organized. Eventually the init/exit callbacks will be deprecated in favor of the standard PM callbacks and driver remove function.

[net-next PATCH v2 5/5] stmmac: dwmac-socfpga: kill init() and rename setup() to set_phy_mode()

2016-05-01 Thread Joachim Eastwood
Remove old init callback which now contains only a call to socfpga_dwmac_setup(). Also rename socfpga_dwmac_setup() to indicate what the function really does. Signed-off-by: Joachim Eastwood Tested-by: Marek Vasut --- drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 17 +++-- 1

[net-next PATCH v2 3/5] stmmac: dwmac-socfpga: keep a copy of stmmac_rst in driver priv data

2016-05-01 Thread Joachim Eastwood
The dwmac-socfpga driver needs to control the reset usually managed by the core driver to set the PHY mode. Take a copy of the reset handle from core priv data so it can be used by the driver later. This also allow us to move reset handling into socfpga_dwmac_setup() where the code that needs it i

[net-next PATCH v2 1/5] stmmac: let remove/resume/suspend functions take device pointer

2016-05-01 Thread Joachim Eastwood
Change stmmac_remove/resume/suspend to take a device pointer so they can be used directly by drivers that doesn't need to perform anything device specific. This lets us remove the PCI pm functions and later simplifiy the platform drivers. Signed-off-by: Joachim Eastwood Tested-by: Marek Vasut -

[net-next PATCH v2 0/5] stmmac: dwmac-socfpga refactor+cleanup

2016-05-01 Thread Joachim Eastwood
This patch aims to remove the init/exit callbacks from the dwmac- socfpga driver and instead use standard PM callbacks. Doing this will also allow us to cleanup the driver. Eventually the init/exit callbacks will be deprecated and removed from all drivers dwmac-* except for dwmac-generic. Drivers

[net-next PATCH v2 4/5] stmmac: dwmac-socfpga: call phy_resume() only in resume callback

2016-05-01 Thread Joachim Eastwood
Calling phy_resume() should only be need during driver resume to workaround a hardware errata. Signed-off-by: Joachim Eastwood Tested-by: Marek Vasut --- .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c| 50 -- 1 file changed, 19 insertions(+), 31 deletions(-) diff --git

Re: Q: How to disable vlan strip in Intel igb driver ?

2016-05-01 Thread Peter Palúch
Hi Ran, Alex, I don't see rx-vlan-offload option in my ethtool. strange, maybe it is not available in all ethtool versions ? According to my manpage for ethtool v4.5, the relevant -K option is "rxvlan". Hi Peter, Yes, I'm using AF_PACKET (I can't validate it now for 100%, but I quite sure

Re: [net-next PATCH v2 5/9] mlx4: Add support for UDP tunnel segmentation with outer checksum offload

2016-05-01 Thread Or Gerlitz
On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: > This patch assumes that the mlx4 hardware will ignore existing IPv4/v6 > header fields for length and checksum as well as the length and checksum > fields for outer UDP headers. Hi Alex, I see now the above text appearing in bunch of simi

Re: [net-next PATCH v2 1/9] net: Disable segmentation if checksumming is not supported

2016-05-01 Thread Or Gerlitz
On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: > In the case of the mlx4 and mlx5 driver they do not support IPv6 checksum > offload for tunnels. Alex, To clarify, when you say "not support IPv6 checksum for tunnels", you refer to the offloading of the outer or inner checksum? Still (m

Re: [PATCH] pxa168_eth: fix mdiobus_scan() error check

2016-05-01 Thread Sergei Shtylyov
On 05/01/2016 11:25 PM, Sergei Shtylyov wrote: Since mdiobus_scan() returns either an error code or NULL on error, the driver should check for both, not only for NULL, otherwise a crash is imminent... Reported-by: Arnd Bergmann Signed-off-by: Sergei Shtylyov --- The patch is against DaveM'

Re: [net-next PATCH v2 5/9] mlx4: Add support for UDP tunnel segmentation with outer checksum offload

2016-05-01 Thread Saeed Mahameed
On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: > This patch assumes that the mlx4 hardware will ignore existing IPv4/v6 > header fields for length and checksum as well as the length and checksum > fields for outer UDP headers. > > Signed-off-by: Alexander Duyck > --- > drivers/net/ether

Re: [PATCH] pxa168_eth: fix mdiobus_scan() error check

2016-05-01 Thread Sergei Shtylyov
Hello. On 05/01/2016 07:05 PM, Florian Fainelli wrote: Since mdiobus_scan() returns either an error code or NULL on error, the driver should check for both, not only for NULL, otherwise a crash is imminent... Reported-by: Arnd Bergmann Signed-off-by: Sergei Shtylyov --- The patch is again

Re: [net-next PATCH v2 6/9] mlx4: Add support for inner IPv6 checksum offloads and TSO

2016-05-01 Thread Saeed Mahameed
On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: > >From what I can tell the ConnectX-3 will support an inner IPv6 checksum and > segmentation offload, however it cannot support outer IPv6 headers. This > assumption is based on the fact that I could see the checksum being > offloaded for i

[PATCH] rtlwifi: rtl818x: constify rtl_intf_ops structures

2016-05-01 Thread Julia Lawall
The rtl_intf_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/wireless/realtek/rtlwifi/pci.c |2 +- drivers/net/wireless/realtek/rtlwifi/pci.h |2 +- drivers/net/wireless/realtek/rtlwifi/usb.c

Re: [PATCH v1 net] net/mlx4: Avoid wrong virtual mappings

2016-05-01 Thread Sinan Kaya
On 5/1/2016 4:07 PM, David Miller wrote: > From: Sinan Kaya > Date: Sun, 1 May 2016 11:43:54 -0400 > >> Can we get this queued for 4.7? Mellanox with arm64 has been broken over 1.5 >> years. > > Can you not quote an entire huge patch just to say something like > this? > > I'm waiting for the p

Re: [net-next PATCH v2 8/9] mlx5e: Fix IPv6 tunnel checksum offload

2016-05-01 Thread Saeed Mahameed
On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: > The mlx5 driver exposes support for TSO6 but not IPv6 csum for hardware > encapsulated tunnels. This leads to issues as it triggers warnings in > skb_checksum_help as it ends up being called as we report supporting the > segmentation but n

Re: [net-next PATCH v2 7/9] mlx5e: Add support for UDP tunnel segmentation with outer checksum offload

2016-05-01 Thread Saeed Mahameed
On Sat, Apr 30, 2016 at 1:43 AM, Alexander Duyck wrote: > This patch assumes that the mlx5 hardware will ignore existing IPv4/v6 > header fields for length and checksum as well as the length and checksum > fields for outer UDP headers. > > Signed-off-by: Alexander Duyck Reviewed-by: Saeed Mahame

Re: [PATCH v1 net] net/mlx4: Avoid wrong virtual mappings

2016-05-01 Thread David Miller
From: Sinan Kaya Date: Sun, 1 May 2016 11:43:54 -0400 > Can we get this queued for 4.7? Mellanox with arm64 has been broken over 1.5 > years. Can you not quote an entire huge patch just to say something like this? I'm waiting for the people involved all to give feedback. If it's been broken f

[PATCH net 1/4] net/mlx5: Unmap only the relevant IO memory mapping

2016-05-01 Thread Saeed Mahameed
From: Gal Pressman When freeing UAR the driver tries to unmap uar->map and uar->bf_map which are mutually exclusive thus always unmapping a NULL pointer. Make sure we only call iounmap() once, for the actual mapping. Fixes: 0ba422410bbf ('net/mlx5: Fix global UAR mapping') Signed-off-by: Gal Pre

[PATCH net 3/4] net/mlx5e: Implement a mlx5e workqueue

2016-05-01 Thread Saeed Mahameed
From: Matthew Finlay Implement a mlx5e workqueue to handle all mlx5e specific tasks. Move all tasks currently using the system workqueue to the new workqueue. This is in preparation for vxlan using the mlx5e workqueue in order to schedule port add/remove operations. Signed-off-by: Matthew Finla

[PATCH net 2/4] net/mlx5: Kconfig: Fix MLX5_EN/VXLAN build issue

2016-05-01 Thread Saeed Mahameed
From: Matthew Finlay When MLX5_EN=y MLX5_CORE=y and VXLAN=m there is a linker error for vxlan_get_rx_port() due to the fact that VXLAN is a module. Change Kconfig to select VXLAN when MLX5_CORE=y. When MLX5_CORE=m there is no dependency on the value of VXLAN. Fixes: b3f63c3d5e2c ('net/mlx5e: Add

[PATCH net 4/4] net/mlx5e: Use workqueue for vxlan ops

2016-05-01 Thread Saeed Mahameed
From: Matthew Finlay The vxlan add/delete port NDOs are called under rcu lock. The current mlx5e implementation can potentially block in these calls, which is not allowed. Move to using the mlx5e workqueue to handle these NDOs. Fixes: b3f63c3d5e2c ('net/mlx5e: Add netdev support for VXLAN tunne

[PATCH net 0/4] Mellanox 100G mlx5 fixes for 4.6-rc

2016-05-01 Thread Saeed Mahameed
Hi Dave, This small series provides some bug fixes for mlx5 driver. A small bug fix for iounmap of a null pointer, which dumps a warning on some archs. One patch to fix the VXLAN/MLX5_EN dependency issue reported by Arnd. Two patches to fix the scheduling while atomic issue for ndo_add/del_vx

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-05-01 Thread Jiri Pirko
Thu, Apr 28, 2016 at 05:54:19PM CEST, da...@davemloft.net wrote: >From: Nicolas Dichtel >Date: Thu, 28 Apr 2016 13:59:34 +0200 > >> Le 27/04/2016 18:55, David Miller a écrit : >>> From: Jiri Pirko >> [snip] The difference is that it this tries to allow userspace crap to mirror setting u

Re: Cannot use NFS with linux-next 20160429

2016-05-01 Thread Chuck Lever
Hi Fabio- > On Apr 29, 2016, at 7:18 PM, Fabio Estevam wrote: > > Hi, > > NFS is not working on a imx6q-sabresd board running linux-next 20160429: > > [ 15.753317] #0: wm8962-audio > [ 15.759437] Root-NFS: no NFS server address At a glance, that looks like the NFSROOT mount options are

Re: Q: How to disable vlan strip in Intel igb driver ?

2016-05-01 Thread Ran Shalit
>> Ran > > You should be able to turn off the offload by setting > "rx-vlan-offload" to "off" via "ethtool -K". > > - Alex Alex, I don't see rx-vlan-offload option in my ethtool. strange, maybe it is not available in all ethtool versions ? On Sun, May 1, 2016 at 9:22 PM, Peter Palúch wrote: >

Re: Q: How to disable vlan strip in Intel igb driver ?

2016-05-01 Thread Peter Palúch
Ran, How are you accessing the VLAN tag information - and how do you know that the VLAN tag is not being passed through? Are you using AF_PACKET socket in your application? Best regards, Peter On 01.05.2016 15:13, Ran Shalit wrote: Hello, I am using intel igb driver in Linux. The driver

Re: Q: How to disable vlan strip in Intel igb driver ?

2016-05-01 Thread Alexander Duyck
On Sun, May 1, 2016 at 6:13 AM, Ran Shalit wrote: > Hello, > > > I am using intel igb driver in Linux. > > The driver strip the packet from vlan inofmation. But we need this > information in the packet. > > We tried to change build flag, or see if there is any feature with > ethtool that can disab

Re: [PATCH] pxa168_eth: fix mdiobus_scan() error check

2016-05-01 Thread Florian Fainelli
Le 30/04/2016 13:35, Sergei Shtylyov a écrit : > Since mdiobus_scan() returns either an error code or NULL on error, the > driver should check for both, not only for NULL, otherwise a crash is > imminent... > > Reported-by: Arnd Bergmann > Signed-off-by: Sergei Shtylyov > > --- > The patch is

Re: [PATCH] macb: fix mdiobus_scan() error check

2016-05-01 Thread Florian Fainelli
Le 30/04/2016 15:47, Sergei Shtylyov a écrit : > Now mdiobus_scan() returns ERR_PTR(-ENODEV) instead of NULL if the PHY > device ID was read as all ones. As this was not an error before, this > value should be filtered out now in this driver. > > Fixes: b74766a0a0fe ("phylib: don't return NULL f

Re: [PATCH v1 net] net/mlx4: Avoid wrong virtual mappings

2016-05-01 Thread Sinan Kaya
On 4/27/2016 3:07 AM, Haggai Abramovsky wrote: > The dma_alloc_coherent() function returns a virtual address which can > be used for coherent access to the underlying memory. On some > architectures, like arm64, undefined behavior results if this memory is > also accessed via virtual mappings that

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-05-01 Thread Jiri Pirko
Fri, Apr 29, 2016 at 10:48:17AM CEST, nicolas.dich...@6wind.com wrote: >Le 28/04/2016 17:54, David Miller a écrit : >[snip] >> You can say whatever you want, but the facilities you are adding to >> this driver enables proprietary userland SDK components. >> >> And this is precisely what we are try

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

2016-05-01 Thread Jiri Pirko
Thu, Apr 28, 2016 at 01:59:34PM CEST, nicolas.dich...@6wind.com wrote: >Le 27/04/2016 18:55, David Miller a écrit : >> From: Jiri Pirko >[snip] >>> The difference is that it this tries to allow userspace crap to mirror >>> setting user does for bridge/ovs. Basically this looks to me like an >>> at

[PATCH net-next v2] ravb: Remove rx buffer ALIGN

2016-05-01 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi Aligning the reception data size is not required. Signed-off-by: Kazuya Mizuguchi Signed-off-by: Yoshihiro Kaneko Tested-by: Simon Horman --- This patch is based on the master branch of David Miller's next networking tree. v2 [Yoshihiro Kaneko] * As suggested by Serge

[PATCH 4/4] net: ethernet: fec_mpc52xx: move to new ethtool api {get|set}_link_ksettings

2016-05-01 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move the fec_mpc52xx driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/freescale/fec_mpc52xx.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/n

[PATCH 2/4] net: ethernet: ucc: move to new ethtool api {get|set}_link_ksettings

2016-05-01 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move the ucc driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/freescale/ucc_geth_ethtool.c | 17 +++-- 1 files changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/net

[PATCH 1/4] net: ethernet: gianfar: move to new ethtool api {get|set}_link_ksettings

2016-05-01 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move the gianfar driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 25 +++--- 1 files changed, 8 insertions(+), 17 deletions(-) diff --git a/dri

[PATCH 3/4] net: ethernet: fs-enet: move to new ethtool api {get|set}_link_ksettings

2016-05-01 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move the fs-enet driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- .../net/ethernet/freescale/fs_enet/fs_enet-main.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers

Re: [PATCH net-next] ravb: Remove rx buffer ALIGN

2016-05-01 Thread Yoshihiro Kaneko
Hi Simon-san, Thank you for testing this patch! Thanks, kaneko 2016-04-29 8:34 GMT+09:00 Simon Horman : > Hi Sergei, Hi Kaneko-san, > > On Tue, Apr 26, 2016 at 10:14:41PM +0300, Sergei Shtylyov wrote: >> Hello. >> >> On 04/24/2016 07:16 PM, Yoshihiro Kaneko wrote: >> >> >From: Kazuya Mizuguchi

Re: [PATCH net-next] ravb: Remove rx buffer ALIGN

2016-05-01 Thread Yoshihiro Kaneko
Hi Sergei, Sorry for the late reply. 2016-04-27 4:14 GMT+09:00 Sergei Shtylyov : > Hello. > > On 04/24/2016 07:16 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> Aligning the reception data size is not required. > > >OK, the gen 2/3 manuals indeed don't require this. I assume t

[Question] Should `CAP_NET_ADMIN` be needed when opening `/dev/ppp`?

2016-05-01 Thread Wang Shanker
Hi, all. I’ve recently met some problems when trying to create a pppoe network link inside a unprivileged container. There is a uid namespace which maps root inside to a normal user outside. There is also a separate

Q: How to disable vlan strip in Intel igb driver ?

2016-05-01 Thread Ran Shalit
Hello, I am using intel igb driver in Linux. The driver strip the packet from vlan inofmation. But we need this information in the packet. We tried to change build flag, or see if there is any feature with ethtool that can disable this feature, but nothing helps. Is there any way to achive th

[PATCH] VSOCK: constify vsock_transport structure

2016-05-01 Thread Julia Lawall
The vsock_transport structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- net/vmw_vsock/vmci_transport.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_t

[PATCH] drivers: net: xgene: constify xgene_cle_ops structure

2016-05-01 Thread Julia Lawall
The xgene_cle_ops structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c |2 +- drivers/net/ethernet/apm/xgene/xgene_enet_cle.h |2 +- drivers/net/ethernet/apm/xgene/xgene_

[PATCH] i40e: constify i40e_client_ops structure

2016-05-01 Thread Julia Lawall
The i40e_client_ops structure is never modified, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/infiniband/hw/i40iw/i40iw_main.c |2 +- drivers/net/ethernet/intel/i40e/i40e_client.h |2 +- 2 files changed, 2 insertions(+), 2 delet

Re: [PATCH net-next 10/12] net/mlx5e: Create aRFS flow tables

2016-05-01 Thread Saeed Mahameed
On Sun, May 1, 2016 at 5:18 AM, Alexei Starovoitov wrote: > On Fri, Apr 29, 2016 at 01:36:40AM +0300, Saeed Mahameed wrote: >> From: Maor Gottlieb >> mlx5_core-$(CONFIG_MLX5_CORE_EN_DCB) += en_dcbnl.o >> +mlx5_core-$(CONFIG_RFS_ACCEL) += en_arfs.o > > this line breaks the build when RFS is on