[PATCH (net.git)] stmmac: fix adjust link call in case of a switch is attached

2016-04-04 Thread Giuseppe Cavallaro
While initializing the phy, the stmmac driver sets the PHY_IGNORE_INTERRUPT so the PAL won't call the adjust hook that is needed, on some platforms, e.g. STi, to invoke the glue. The patch allows the PAL to poll the stmmac_adjust_link just one time in case of a switch is attached, setting later th

Re: am335x: no multicast reception over VLAN

2016-04-04 Thread Yegor Yefremov
Grygorii, Mugunthan, On Tue, Apr 5, 2016 at 8:11 AM, Mugunthan V N wrote: > On Friday 01 April 2016 05:39 PM, Grygorii Strashko wrote: >> On 03/31/2016 10:52 AM, Yegor Yefremov wrote: >>> On Thu, Mar 31, 2016 at 8:37 AM, Mugunthan V N wrote: On Thursday 31 March 2016 01:17 AM, Peter Korsgaa

Re: am335x: no multicast reception over VLAN

2016-04-04 Thread Mugunthan V N
On Friday 01 April 2016 05:39 PM, Grygorii Strashko wrote: > On 03/31/2016 10:52 AM, Yegor Yefremov wrote: >> On Thu, Mar 31, 2016 at 8:37 AM, Mugunthan V N wrote: >>> On Thursday 31 March 2016 01:17 AM, Peter Korsgaard wrote: > "Mugunthan" == Mugunthan V N writes: Hi,

Re: [RFC PATCH 4/5] mlx4: add support for fast rx drop bpf program

2016-04-04 Thread Jesper Dangaard Brouer
On Mon, 4 Apr 2016 11:27:27 -0700 Alexei Starovoitov wrote: > On Sat, Apr 02, 2016 at 11:11:52PM -0700, Brenden Blanco wrote: > > On Sat, Apr 02, 2016 at 10:23:31AM +0200, Jesper Dangaard Brouer wrote: > > [...] > > > > > > I think you need to DMA sync RX-page before you can safely access > >

RE: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-04-04 Thread Amitkumar Karwar
Hi Eric, Thanks for the comments. > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Tuesday, March 29, 2016 6:29 PM > To: Wei-Ning Huang > Cc: Kalle Valo; Linux Wireless; LKML; Amitkumar Karwar; Nishant > Sarmukadam; Sameer Nanda; netdev@vger.kernel.org; Sonny Rao; Douglas > Anderson >

Re: [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm

2016-04-04 Thread Toshiaki Makita
On 2016/04/05 12:32, Xin Long wrote: > There are some repetitive codes in stp_state_store, we can remove > them by calling store_bridge_parm. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 24 +++- > 1 file changed, 7 insertions(+), 17 deletions(-) > > diff -

[PATCH net-next 4/8] bpf: support bpf_get_stackid() and bpf_perf_event_output() in tracepoint programs

2016-04-04 Thread Alexei Starovoitov
needs two wrapper functions to fetch 'struct pt_regs *' to convert tracepoint bpf context into kprobe bpf context to reuse existing helper functions Signed-off-by: Alexei Starovoitov --- include/linux/bpf.h | 1 + kernel/bpf/stackmap.c| 2 +- kernel/trace/bpf_trace.c | 42

[PATCH net-next 1/8] perf: optimize perf_fetch_caller_regs

2016-04-04 Thread Alexei Starovoitov
avoid memset in perf_fetch_caller_regs, since it's the critical path of all tracepoints. It's called from perf_sw_event_sched, perf_event_task_sched_in and all of perf_trace_##call with this_cpu_ptr(&__perf_regs[..]) which are zero initialized by perpcu_alloc and subsequent call to perf_arch_fet

[PATCH net-next 2/8] perf, bpf: allow bpf programs attach to tracepoints

2016-04-04 Thread Alexei Starovoitov
introduce BPF_PROG_TYPE_TRACEPOINT program type and allow it to be attached to tracepoints. The tracepoint will copy the arguments in the per-cpu buffer and pass it to the bpf program as its first argument. The layout of the fields can be discovered by doing 'cat /sys/kernel/debug/tracing/events/sc

[PATCH net-next 7/8] samples/bpf: tracepoint example

2016-04-04 Thread Alexei Starovoitov
modify offwaketime to work with sched/sched_switch tracepoint instead of kprobe into finish_task_switch Signed-off-by: Alexei Starovoitov --- samples/bpf/offwaketime_kern.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/samples/bpf/offwaketime_ker

[PATCH net-next 8/8] samples/bpf: add tracepoint vs kprobe performance tests

2016-04-04 Thread Alexei Starovoitov
the first microbenchmark does fd=open("/proc/self/comm"); for() { write(fd, "test"); } and on 4 cpus in parallel: writes per sec base (no tracepoints, no kprobes) 930k with kprobe at __set_task_comm() 420k with tracepoint at task:task_rename

[PATCH net-next 5/8] bpf: sanitize bpf tracepoint access

2016-04-04 Thread Alexei Starovoitov
during bpf program loading remember the last byte of ctx access and at the time of attaching the program to tracepoint check that the program doesn't access bytes beyond defined in tracepoint fields This also disallows access to __dynamic_array fields, but can be relaxed in the future. Signed-off

[PATCH net-next 0/8] allow bpf attach to tracepoints

2016-04-04 Thread Alexei Starovoitov
Hi Steven, Peter, last time we discussed bpf+tracepoints it was a year ago [1] and the reason we didn't proceed with that approach was that bpf would make arguments arg1, arg2 to trace_xx(arg1, arg2) call to be exposed to bpf program and that was considered unnecessary extension of abi. Back then

[PATCH net-next 3/8] bpf: register BPF_PROG_TYPE_TRACEPOINT program type

2016-04-04 Thread Alexei Starovoitov
register tracepoint bpf program type and let it call the same set of helper functions as BPF_PROG_TYPE_KPROBE Signed-off-by: Alexei Starovoitov --- kernel/trace/bpf_trace.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/kernel/t

[PATCH net-next 6/8] samples/bpf: add tracepoint support to bpf loader

2016-04-04 Thread Alexei Starovoitov
Recognize "tracepoint/" section name prefix and attach the program to that tracepoint. Signed-off-by: Alexei Starovoitov --- samples/bpf/bpf_load.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c inde

[net-next:master 58/68] net/ipv4/udp.c:1693:9: sparse: incompatible types in comparison expression (different address spaces)

2016-04-04 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 15f41e2ba13a6726632e44b1180e805a61e470ad commit: ca065d0cf80fa547724440a8bf37f1e674d917c0 [58/68] udp: no longer use SLAB_DESTROY_BY_RCU reproduce: # apt-get install sparse git checkout ca065

Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864

2016-04-04 Thread Herbert Xu
On Mon, Apr 04, 2016 at 09:26:55PM -0700, Alexander Duyck wrote: > > The problem is right now we are mangling the IP ID for outer headers > on tunnels. We end up totally ignoring the delta between the values > so if you have two flows that get interleaved over the same tunnel GRO > will currently

[net-next:master 57/68] DockBook: include/net/sock.h:442: warning: No description found for parameter 'sk_rcu'

2016-04-04 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 15f41e2ba13a6726632e44b1180e805a61e470ad commit: a4298e4522d687a79af8f8fbb7eca68399ab2d81 [57/68] net: add SOCK_RCU_FREE socket flag reproduce: make htmldocs All warnings (new ones prefixed by >>): incl

Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864

2016-04-04 Thread Alexander Duyck
On Mon, Apr 4, 2016 at 8:44 PM, Herbert Xu wrote: > On Mon, Apr 04, 2016 at 09:31:21AM -0700, Alexander Duyck wrote: >> RFC 6864 states that the IPv4 ID field MUST NOT be used for purposes other >> than fragmentation and reassembly. Currently we are looking at this field >> as a way of identifyin

[PATCHv2 net-next] cxgb4/cxgb4vf: Deprecate module parameter dflt_msg_enable

2016-04-04 Thread Hariprasad Shenai
Message level can be set through ethtool, so deprecate module parameter which is used to set the same. Signed-off-by: Hariprasad Shenai --- V2: Fix grammar in module param description, based on review comment by Sergei Shtylyov drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 ++-

[PATCH net-next 6/7] sctp: merge the seq_start/next/exits in remaddrs and assocs

2016-04-04 Thread Xin Long
In sctp proc, these three functions in remaddrs and assocs are the same. we should merge them into one. Signed-off-by: Xin Long --- net/sctp/proc.c | 45 + 1 file changed, 9 insertions(+), 36 deletions(-) diff --git a/net/sctp/proc.c b/net/sctp/proc.c

[PATCH net-next 5/7] sctp: reuse the some transport traversal functions in proc

2016-04-04 Thread Xin Long
There are some transport traversal functions for sctp_diag, we can also use it for sctp_proc. cause they have the similar situation to traversal transport. Signed-off-by: Xin Long --- net/sctp/proc.c | 80 + 1 file changed, 18 insertions(+)

[PATCH net-next 7/7] sctp: fix some rhashtable functions using in sctp proc/diag

2016-04-04 Thread Xin Long
When rhashtable_walk_init return err, no release function should be called, and when rhashtable_walk_start return err, we should only invoke rhashtable_walk_exit to release the source. But now when sctp_transport_walk_start return err, we just call rhashtable_walk_stop/exit, and never care about i

[PATCH net-next 4/7] sctp: add the sctp_diag.c file

2016-04-04 Thread Xin Long
This one will implement all the interface of inet_diag, inet_diag_handler. which includes sctp_diag_dump, sctp_diag_dump_one and sctp_diag_get_info. It will work as a modules, and register inet_diag_handler when loading. Signed-off-by: Xin Long --- include/uapi/linux/inet_diag.h | 2 + net/sc

[PATCH net-next 3/7] sctp: export some functions for sctp_diag in inet_diag

2016-04-04 Thread Xin Long
inet_diag_msg_common_fill is used to fill the diag msg common info, we need to use it in sctp_diag as well, so export it. We also add inet_diag_get_handler() to access inet_diag_table in sctp diag. Signed-off-by: Xin Long --- net/ipv4/inet_diag.c | 9 - 1 file changed, 8 insertions(+),

[PATCH net-next 2/7] sctp: export some apis or variables for sctp_diag

2016-04-04 Thread Xin Long
For some main variables in sctp.ko, we couldn't export it to other modules, so we have to define some api to access them. It will include sctp transport and endpoint's traversal. Signed-off-by: Xin Long --- include/net/sctp/sctp.h | 13 + net/sctp/socket.c | 124 +

[PATCH net-next 1/7] sctp: add sctp_info dump api for sctp_diag

2016-04-04 Thread Xin Long
sctp_diag will dump some important details of sctp's assoc or ep, we use sctp_info to describe them, sctp_get_sctp_info to get them, and export it to sctp_diag.ko. Signed-off-by: Xin Long --- include/linux/sctp.h| 65 + include/net/sctp/sctp.h | 3 ++ ne

[PATCH net-next 0/7] sctp: support sctp_diag in kernel

2016-04-04 Thread Xin Long
This patchset will add sctp_diag module to implement diag interface on sctp in kernel. For a listening sctp endpoint, we will just dump it's ep info. For a sctp connection, we will the assoc info and it's ep info. The ss dump will looks like: [iproute2]# ./misc/ss --sctp -n -l State Recv-Q

Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864

2016-04-04 Thread Herbert Xu
On Mon, Apr 04, 2016 at 09:31:21AM -0700, Alexander Duyck wrote: > RFC 6864 states that the IPv4 ID field MUST NOT be used for purposes other > than fragmentation and reassembly. Currently we are looking at this field > as a way of identifying what frames can be aggregated and which cannot for >

[PATCHv2 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br

2016-04-04 Thread Xin Long
Now when we change the attributes of bridge or br_port by netlink, a relevant netlink notification will be sent, but if we change them by ioctl or sysfs, no notification will be sent. We should ensure that whenever those attributes change internally or from sysfs/ioctl, that a netlink notification

[PATCHv2 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if

2016-04-04 Thread Xin Long
Now when we change the attributes of bridge or br_port by netlink, a relevant netlink notification will be sent, but if we change them by ioctl or sysfs, no notification will be sent. We should ensure that whenever those attributes change internally or from sysfs/ioctl, that a netlink notification

[PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm

2016-04-04 Thread Xin Long
There are some repetitive codes in stp_state_store, we can remove them by calling store_bridge_parm. Signed-off-by: Xin Long --- net/bridge/br_sysfs_br.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_b

[PATCHv2 net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl

2016-04-04 Thread Xin Long
Now when we change the attributes of bridge or br_port by netlink, a relevant netlink notification will be sent, but if we change them by ioctl or sysfs, no notification will be sent. We should ensure that whenever those attributes change internally or from sysfs/ioctl, that a netlink notification

[PATCHv2 net-next 2/6] bridge: simplify the forward_delay_store by calling store_bridge_parm

2016-04-04 Thread Xin Long
There are some repetitive codes in forward_delay_store, we can remove them by calling store_bridge_parm. Signed-off-by: Xin Long --- net/bridge/br_sysfs_br.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br

[PATCHv2 net-next 1/6] bridge: simplify the flush_store by calling store_bridge_parm

2016-04-04 Thread Xin Long
There are some repetitive codes in flush_store, we can remove them by calling store_bridge_parm, also, it would send rtnl notification after we add it in store_bridge_parm in the following patches. Signed-off-by: Xin Long --- net/bridge/br_sysfs_br.c | 14 +++--- 1 file changed, 7 insert

[PATCHv2 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl

2016-04-04 Thread Xin Long
This patchset is used to support sending rntl info to user in some places, and ensure that whenever those attributes change internally or from sysfs, that a netlink notification is sent out to listeners. It also make some adjustment in bridge sysfs so that we can implement this easily. I've done

Re: [RFC PATCH 4/5] mlx4: add support for fast rx drop bpf program

2016-04-04 Thread Eric Dumazet
On Mon, 2016-04-04 at 19:20 -0700, Brenden Blanco wrote: > On Sat, Apr 02, 2016 at 11:15:38PM -0700, Brenden Blanco wrote: > > On Fri, Apr 01, 2016 at 07:08:31PM -0700, Eric Dumazet wrote: > [...] > > > 2) priv->stats.rx_dropped is shared by all the RX queues -> false > > > sharing. > > > > > >

Re: [RFC PATCH 4/5] mlx4: add support for fast rx drop bpf program

2016-04-04 Thread Brenden Blanco
On Sat, Apr 02, 2016 at 11:15:38PM -0700, Brenden Blanco wrote: > On Fri, Apr 01, 2016 at 07:08:31PM -0700, Eric Dumazet wrote: [...] > > 2) priv->stats.rx_dropped is shared by all the RX queues -> false > > sharing. > > > >This is probably the right time to add a rx_dropped field in struct >

Re: [RFC PATCH 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-04 Thread Alexei Starovoitov
On Tue, Apr 05, 2016 at 12:04:39AM +0200, Thomas Graf wrote: > On 04/04/16 at 01:00pm, Alexei Starovoitov wrote: > > Exactly. That the most important part of this rfc. > > Right now redirect to different queue, batching, prefetch and tons of > > other code are mising. We have to plan the whole proj

Re: [net-next v2 00/14][pull request] 10GbE Intel Wired LAN Driver Updates 2016-04-04

2016-04-04 Thread Jeff Kirsher
On Mon, 2016-04-04 at 22:02 -0400, David Miller wrote: > From: Jeff Kirsher > Date: Mon, 04 Apr 2016 18:45:54 -0700 > > > > > On Mon, 2016-04-04 at 21:35 -0400, David Miller wrote: > > > > > > From: Jeff Kirsher > > > Date: Mon,  4 Apr 2016 17:58:51 -0700 > > > > > > > > > > > > > > > This

Re: [PATCH v2 net-next 00/11] net: various udp/tcp changes

2016-04-04 Thread David Miller
From: Eric Dumazet Date: Fri, 1 Apr 2016 08:52:11 -0700 > First round of patches for linux-4.7 Nice series, applied. I honestly think we can elide socket memory accounting for (non-data-bearing) SYNACKs if that's showing up in the perf profiles for SYN attacks.

Re: [net-next v2 00/14][pull request] 10GbE Intel Wired LAN Driver Updates 2016-04-04

2016-04-04 Thread Jeff Kirsher
On Mon, 2016-04-04 at 21:35 -0400, David Miller wrote: > From: Jeff Kirsher > Date: Mon,  4 Apr 2016 17:58:51 -0700 > > > > > This series contains updates to ixgbe and ixgbevf. > Pulled, thanks Jeff. Dave, I f*'d up and forgot to push v2 to my kernel.org tree before you pulled.  I have updated

Re: [net-next v2 00/14][pull request] 10GbE Intel Wired LAN Driver Updates 2016-04-04

2016-04-04 Thread David Miller
From: Jeff Kirsher Date: Mon, 04 Apr 2016 18:45:54 -0700 > On Mon, 2016-04-04 at 21:35 -0400, David Miller wrote: >> From: Jeff Kirsher >> Date: Mon,  4 Apr 2016 17:58:51 -0700 >> >> > >> > This series contains updates to ixgbe and ixgbevf. >> Pulled, thanks Jeff. > > Dave, I f*'d up and forg

Re: [net-next v2 00/14][pull request] 10GbE Intel Wired LAN Driver Updates 2016-04-04

2016-04-04 Thread David Miller
From: Jeff Kirsher Date: Mon, 4 Apr 2016 17:58:51 -0700 > This series contains updates to ixgbe and ixgbevf. Pulled, thanks Jeff.

Re: [PATCH net-next v2 0/6] net: dsa: mv88e6131: HW bridging support for 6185

2016-04-04 Thread David Miller
From: Andrew Lunn Date: Mon, 4 Apr 2016 04:13:13 +0200 > On Thu, Mar 31, 2016 at 04:53:40PM -0400, Vivien Didelot wrote: >> All packets passing through a switch of the 6185 family are currently all >> directed to the CPU port. This means that port bridging is software driven. >> >> To enable har

Re: [net-next 08/14] ixgbe: Add support for generic Tx checksums

2016-04-04 Thread Jeff Kirsher
On Mon, 2016-04-04 at 21:27 -0400, David Miller wrote: > From: "Samudrala, Sridhar" > Date: Mon, 04 Apr 2016 15:32:37 -0700 > > > > > On 4/4/2016 3:14 PM, Jeff Kirsher wrote: > > > > > > @@ -9190,41 +9148,37 @@ skip_sriov: > > > #endif > > >   netdev->features = NETIF_F_SG | > > > -

Re: [PATCH net-next 3/3] net: bcmgenet: fix dmadesc_set()

2016-04-04 Thread Florian Fainelli
2016-04-04 18:11 GMT-07:00 Petri Gynther : > Hi Florian, > > On Mon, Apr 4, 2016 at 5:58 PM, Florian Fainelli wrote: >> >> 2016-04-04 17:10 GMT-07:00 Petri Gynther : >> > dmadesc_set() is used for setting the Tx buffer DMA address, length, >> > and status bits on a Tx ring descriptor when a frame

Re: [net-next 08/14] ixgbe: Add support for generic Tx checksums

2016-04-04 Thread David Miller
From: "Samudrala, Sridhar" Date: Mon, 04 Apr 2016 15:32:37 -0700 > On 4/4/2016 3:14 PM, Jeff Kirsher wrote: >> @@ -9190,41 +9148,37 @@ skip_sriov: >> #endif >> netdev->features = NETIF_F_SG | >> - NETIF_F_IP_CSUM | >> - NETIF_F_IPV6_CSUM | >> -

Re: [RFC PATCH 4/5] mlx4: add support for fast rx drop bpf program

2016-04-04 Thread Alexei Starovoitov
On Mon, Apr 04, 2016 at 11:01:57PM +0200, Daniel Borkmann wrote: > On 04/04/2016 08:46 PM, Alexei Starovoitov wrote: > >On Mon, Apr 04, 2016 at 11:57:52AM +0200, Daniel Borkmann wrote: > >>On 04/04/2016 09:35 AM, Johannes Berg wrote: > >>>On Sat, 2016-04-02 at 23:38 -0700, Brenden Blanco wrote: > >

Re: [PATCH net-next 3/3] net: bcmgenet: fix dmadesc_set()

2016-04-04 Thread Petri Gynther
Hi Florian, On Mon, Apr 4, 2016 at 5:58 PM, Florian Fainelli wrote: > > 2016-04-04 17:10 GMT-07:00 Petri Gynther : > > dmadesc_set() is used for setting the Tx buffer DMA address, length, > > and status bits on a Tx ring descriptor when a frame is being Tx'ed. > > > > Always set the Tx buffer DMA

Re: [PATCH net-next 2/3] net: bcmgenet: cleanup for bcmgenet_xmit_frag()

2016-04-04 Thread Florian Fainelli
2016-04-04 17:10 GMT-07:00 Petri Gynther : > Add frag_size = skb_frag_size(frag) and use it when needed. > > Signed-off-by: Petri Gynther Acked-by: Florian Fainelli -- Florian

[net-next v2 02/14] ixgbevf: use bit operations for setting and checking resets

2016-04-04 Thread Jeff Kirsher
From: Emil Tantilov Move the reset flags to adapter->state in order to make use of bit operations. This is an alternative patch to the one previously submitted by John Greene. Suggested-by: Alexander Duyck Reported-by: Scott Otto Reported-by: John Greene Signed-off-by: Emil Tantilov Tested-

[net-next v2 11/14] ixgbe: add a callback to set the maximum transmit bitrate

2016-04-04 Thread Jeff Kirsher
From: Rostislav Pehlivanov This commit adds a callback which allows to adjust the maximum transmit bitrate the card can output. This makes it possible to get a smooth traffic instead of the default burst-y behaviour when trying to output e.g. a video stream. Much of the logic needed to get a cor

[net-next v2 10/14] ixgbe: Fix flow control for Xeon D KR backplane

2016-04-04 Thread Jeff Kirsher
From: Mark Rustad Xeon D KR backplane is different from other backplanes, in that we can't use auto-negotiation to determine the mode. Instead, use whatever the user configured. Signed-off-by: Mark Rustad Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgb

[net-next v2 14/14] ixgbe: Add support for toggling VLAN filtering flag via ethtool

2016-04-04 Thread Jeff Kirsher
From: Alexander Duyck This change makes it so that we can use the ethtool rx-vlan-filter flag to toggle Rx VLAN filtering on and off. This is basically just an extension of the existing VLAN promisc work in that it just adds support for the additional ethtool flag. Signed-off-by: Alexander Duyc

Re: [PATCH net-next 1/3] net: bcmgenet: cleanup for bcmgenet_xmit()

2016-04-04 Thread Florian Fainelli
2016-04-04 17:09 GMT-07:00 Petri Gynther : > 1. Readability: Move nr_frags assignment a few lines down in order >to bundle index -> ring -> txq calculations together. > 2. Readability: Add parentheses around nr_frags + 1. > 3. Minor fix: Stop the Tx queue and throw the error message only if >

[net-next v2 05/14] ixgbe: Avoid adding VLAN 0 twice to VLVF and VFTA

2016-04-04 Thread Jeff Kirsher
From: Alexander Duyck We were adding VLAN 0 twice each time we restored the VLAN configuration. Instead of doing it twice we can just start working through the active VLANs from ID 1 on and skip the double write. Signed-off-by: Alexander Duyck Tested-by: Phil Schmitt Signed-off-by: Jeff Kirshe

[net-next v2 03/14] ixgbe: Extend trust to allow guest to set unicast address

2016-04-04 Thread Jeff Kirsher
From: chas williams <3ch...@gmail.com> When running certain routing protocols like VRRP, VF guests need the ability to set the unicast address of the interface. Extend the new ndo trust feature to let the hypervisor trust a guest to set/update its own unicast address. Signed-off-by: Chas William

[net-next v2 07/14] ixgbe: use eth_platform_get_mac_address()

2016-04-04 Thread Jeff Kirsher
From: Sowmini Varadhan This commit converts commit c762dff24c06 ("ixgbe: Look up MAC address in Open Firmware or IDPROM") to use eth_platform_get_mac_address() added by commit c7f5d105495a ("net: Add eth_platform_get_mac_address() helper.") Signed-off-by: Sowmini Varadhan Tested-by: Phil Schmit

[net-next v2 04/14] ixgbe: Do not allow PF to add VLVF entry unless it actually needs it

2016-04-04 Thread Jeff Kirsher
From: Alexander Duyck While doing the work on igb I realized there were a few cases where we were still adding VLANs to the VLVF entries for the PF when they were not needed. This patch cleans that up so that the only time we add a PF entry to the VLVF is either for VLAN 0 or if the PF has reque

[net-next v2 06/14] ixgbe: Make all unchanging ops structures const

2016-04-04 Thread Jeff Kirsher
From: Mark Rustad The source for the ops structure contents are const, so make them so. Copy them in place with structure assignments instead of memcpys. Make the mbx_ops accessed by reference instead of making a copy of the source structure. Update copyright date on the touched files. Reported-

[net-next v2 01/14] ixgbe: on recv increment rx.ring->stats.yields

2016-04-04 Thread Jeff Kirsher
From: Pavel Tikhomirov It seem to be non intentionally changed to Tx in commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address multiple issues") Lock is taken from ixgbe_low_latency_recv, and there under this lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment Tx

[net-next v2 13/14] ixgbe: Extend cls_u32 offload to support UDP headers

2016-04-04 Thread Jeff Kirsher
From: Amritha Nambiar Added support to match on UDP fields in the transport layer. Extended core logic to support multiple headers. Verified with the following filters : handle 1: u32 divisor 1 u32 ht 800: order 1 link 1: \ offset at 0 mask 0f00 shift 6 plus 0 eat match

[net-next v2 08/14] ixgbe: Add support for generic Tx checksums

2016-04-04 Thread Jeff Kirsher
From: Alexander Duyck This patch adds support for generic Tx checksums to the ixgbe driver. It turns out this is actually pretty easy after going over the datasheet as we were doing a number of steps we didn't need to. In order to perform a Tx checksum for an L4 header we need to fill in the fo

[net-next v2 12/14] ixgbe: Place SWFW semaphore in known valid state at probe

2016-04-04 Thread Jeff Kirsher
From: Don Skidmore It is possible on some HW that a system reset could occur when we are holding the SWFW semaphore lock. So next time the driver was loaded we would see it incorrectly as locked. This patch will recover from that state by: Attempting to acquire the semaphore and then regardless

[net-next v2 09/14] ixgbevf: Add support for generic Tx checksums

2016-04-04 Thread Jeff Kirsher
From: Alexander Duyck This patch adds support for generic Tx checksums to the ixgbevf driver. It turns out this is actually pretty easy after going over the datasheet as we were doing a number of steps we didn't need to. In order to perform a Tx checksum for an L4 header we need to fill in the

[net-next v2 00/14][pull request] 10GbE Intel Wired LAN Driver Updates 2016-04-04

2016-04-04 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf. Pavel Tikhomirov fixes a typo where we were incrementing transmit stats instead of receive stats on the receive side. Emil updates the ixgbevf driver to use bit operations for setting and checking the adapter state. Chas Williams adds the new ND

Re: [PATCH net-next 3/3] net: bcmgenet: fix dmadesc_set()

2016-04-04 Thread Florian Fainelli
2016-04-04 17:10 GMT-07:00 Petri Gynther : > dmadesc_set() is used for setting the Tx buffer DMA address, length, > and status bits on a Tx ring descriptor when a frame is being Tx'ed. > > Always set the Tx buffer DMA address first, before updating the length > and status bits, i.e. giving the Tx d

[RFC PATCH 1/6] ppp: simplify usage of ppp_create_interface()

2016-04-04 Thread Guillaume Nault
Set file->private_data inside ppp_create_interface() to avoid the need for returning the new ppp structure to the caller. Also, make the unit parameter read/write so that caller can still retrieve the PPP unit number assigned to the interface. Avoiding setting ->private_data in the caller will all

[RFC PATCH 3/6] ppp: don't lock ppp_mutex while handling PPPIOCDETACH

2016-04-04 Thread Guillaume Nault
Once set, file->private_data remains constant. So it's safe to access it without holding ppp_mutex. The PPP unit fields accessed while handling PPPIOCDETACH (pf->kind and ppp->owner) are also constant and have been set before file->private_data got assigned. So these too can be read without holding

[RFC PATCH 4/6] ppp: invert lock ordering between ppp_mutex and rtnl_lock

2016-04-04 Thread Guillaume Nault
Since ppp_create_interface() is the only place[1] holding both ppp_mutex and rtnl_lock(), we can reverse lock ordering to allow taking ppp_mutex when rtnl_lock is already held. This will be necessary for creating PPP interfaces from an rtnetlink callback. [1]: There may actually be exceptions. Whe

[RFC PATCH 6/6] ppp: add rtnetlink device creation support

2016-04-04 Thread Guillaume Nault
Define PPP device handlers for use with rtnetlink. The only PPP specific attribute is IFLA_PPP_DEV_FD. It is mandatory and contains the file descriptor of the associated /dev/ppp instance (the file descriptor which would have been used for ioctl(PPPIOCNEWUNIT) in the ioctl-based API). The PPP devic

[RFC PATCH 2/6] ppp: don't hold ppp_mutex before calling ppp_unattached_ioctl()

2016-04-04 Thread Guillaume Nault
Let ppp_unattached_ioctl() lock ppp_mutex only when needed. For PPPIOCATTACH and PPPIOCATTCHAN, we just need to lock ppp_mutex before all_ppp_mutex/all_channels_lock (to keep lock ordering) and to take care of the -ENOTTY error code when file->private_data is not NULL. For PPPIOCNEWUNIT, ppp_mutex

[RFC PATCH 5/6] ppp: define reusable device creation functions

2016-04-04 Thread Guillaume Nault
Move PPP device initialisation and registration out of ppp_create_interface(). This prepares code for device registration with rtnetlink. Signed-off-by: Guillaume Nault --- drivers/net/ppp/ppp_generic.c | 185 -- 1 file changed, 106 insertions(+), 79 delet

[RFC PATCH 0/6] ppp: add rtnetlink support

2016-04-04 Thread Guillaume Nault
PPP devices lack the ability to be customised at creation time. In particular they can't be created in a given netns or with a particular name. Moving or renaming the device after creation is possible, but creates undesirable transient effects on servers where PPP devices are constantly created and

Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864

2016-04-04 Thread subashab
On 2016-04-04 10:31, Alexander Duyck wrote: RFC 6864 states that the IPv4 ID field MUST NOT be used for purposes other than fragmentation and reassembly. Currently we are looking at this field as a way of identifying what frames can be aggregated and which cannot for GRO. While this is valid

[PATCH net-next 1/3] net: bcmgenet: cleanup for bcmgenet_xmit()

2016-04-04 Thread Petri Gynther
1. Readability: Move nr_frags assignment a few lines down in order to bundle index -> ring -> txq calculations together. 2. Readability: Add parentheses around nr_frags + 1. 3. Minor fix: Stop the Tx queue and throw the error message only if the Tx queue hasn't already been stopped. Signed-o

[PATCH net-next 2/3] net: bcmgenet: cleanup for bcmgenet_xmit_frag()

2016-04-04 Thread Petri Gynther
Add frag_size = skb_frag_size(frag) and use it when needed. Signed-off-by: Petri Gynther --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broad

[PATCH net-next 3/3] net: bcmgenet: fix dmadesc_set()

2016-04-04 Thread Petri Gynther
dmadesc_set() is used for setting the Tx buffer DMA address, length, and status bits on a Tx ring descriptor when a frame is being Tx'ed. Always set the Tx buffer DMA address first, before updating the length and status bits, i.e. giving the Tx descriptor to the hardware. Signed-off-by: Petri Gyn

Re: [Intel-wired-lan] [PATCH-RFC] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg off for fiber

2016-04-04 Thread Daniel Walker
On 04/03/2016 07:23 AM, Ruinskiy, Dima wrote: I have a couple of comments (sorry for not getting to it a bit sooner). For fiber media, e1000_get_settings should return ETH_TP_MDI_INVALID for eth_tp_mdix_ctrl instead of ETH_TP_MDI_AUTO so subsequent e1000_set_settings call would not fail with -E

Re: [net-next 08/14] ixgbe: Add support for generic Tx checksums

2016-04-04 Thread Jeff Kirsher
On Mon, 2016-04-04 at 15:54 -0700, Alexander Duyck wrote: > On Mon, Apr 4, 2016 at 3:32 PM, Samudrala, Sridhar > wrote: > > On 4/4/2016 3:14 PM, Jeff Kirsher wrote: > >> > >> From: Alexander Duyck > >> > >> This patch adds support for generic Tx checksums to the ixgbe > driver.  It > >> turns out

Re: [net-next 08/14] ixgbe: Add support for generic Tx checksums

2016-04-04 Thread Alexander Duyck
On Mon, Apr 4, 2016 at 3:32 PM, Samudrala, Sridhar wrote: > On 4/4/2016 3:14 PM, Jeff Kirsher wrote: >> >> From: Alexander Duyck >> >> This patch adds support for generic Tx checksums to the ixgbe driver. It >> turns out this is actually pretty easy after going over the datasheet as >> we >> wer

Re: [net-next 08/14] ixgbe: Add support for generic Tx checksums

2016-04-04 Thread Samudrala, Sridhar
On 4/4/2016 3:14 PM, Jeff Kirsher wrote: From: Alexander Duyck This patch adds support for generic Tx checksums to the ixgbe driver. It turns out this is actually pretty easy after going over the datasheet as we were doing a number of steps we didn't need to. In order to perform a Tx checksum

Re: [PATCH net-next 0/4] udp: support SO_PEEK_OFFSET

2016-04-04 Thread Willem de Bruijn
On Mon, Apr 4, 2016 at 5:49 PM, David Miller wrote: > From: Willem de Bruijn > Date: Sun, 3 Apr 2016 19:29:49 -0400 > >> From: Willem de Bruijn >> >> Support peeking at a non-zero offset for UDP sockets. Match the >> existing behavior on Unix datagram sockets. >> >> 1/4 makes the sk_peek_offset

[net-next 05/14] ixgbe: Avoid adding VLAN 0 twice to VLVF and VFTA

2016-04-04 Thread Jeff Kirsher
From: Alexander Duyck We were adding VLAN 0 twice each time we restored the VLAN configuration. Instead of doing it twice we can just start working through the active VLANs from ID 1 on and skip the double write. Signed-off-by: Alexander Duyck Tested-by: Phil Schmitt Signed-off-by: Jeff Kirshe

[net-next 00/14][pull request] 10GbE Intel Wired LAN Driver Updates 2016-04-04

2016-04-04 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf. Pavel Tikhomirov fixes a typo where we were incrementing transmit stats instead of receive stats on the receive side. Emil updates the ixgbevf driver to use bit operations for setting and checking the adapter state. Chas Williams adds the new ND

[net-next 02/14] ixgbevf: use bit operations for setting and checking resets

2016-04-04 Thread Jeff Kirsher
From: Emil Tantilov Move the reset flags to adapter->state in order to make use of bit operations. This is an alternative patch to the one previously submitted by John Greene. Suggested-by: Alexander Duyck Reported-by: Scott Otto Reported-by: John Greene Signed-off-by: Emil Tantilov Tested-

[net-next 03/14] ixgbe: Extend trust to allow guest to set unicast address

2016-04-04 Thread Jeff Kirsher
From: chas williams <3ch...@gmail.com> When running certain routing protocols like VRRP, VF guests need the ability to set the unicast address of the interface. Extend the new ndo trust feature to let the hypervisor trust a guest to set/update its own unicast address. Signed-off-by: Chas William

[net-next 11/14] ixgbe: add a callback to set the maximum transmit bitrate

2016-04-04 Thread Jeff Kirsher
From: Rostislav Pehlivanov This commit adds a callback which allows to adjust the maximum transmit bitrate the card can output. This makes it possible to get a smooth traffic instead of the default burst-y behaviour when trying to output e.g. a video stream. Much of the logic needed to get a cor

[net-next 09/14] ixgbevf: Add support for generic Tx checksums

2016-04-04 Thread Jeff Kirsher
From: Alexander Duyck This patch adds support for generic Tx checksums to the ixgbevf driver. It turns out this is actually pretty easy after going over the datasheet as we were doing a number of steps we didn't need to. In order to perform a Tx checksum for an L4 header we need to fill in the

[net-next 07/14] ixgbe: use eth_platform_get_mac_address()

2016-04-04 Thread Jeff Kirsher
From: Sowmini Varadhan This commit converts commit c762dff24c06 ("ixgbe: Look up MAC address in Open Firmware or IDPROM") to use eth_platform_get_mac_address() added by commit c7f5d105495a ("net: Add eth_platform_get_mac_address() helper.") Signed-off-by: Sowmini Varadhan Tested-by: Phil Schmit

[net-next 14/14] ixgbe: Add support for toggling VLAN filtering flag via ethtool

2016-04-04 Thread Jeff Kirsher
From: Alexander Duyck This change makes it so that we can use the ethtool rx-vlan-filter flag to toggle Rx VLAN filtering on and off. This is basically just an extension of the existing VLAN promisc work in that it just adds support for the additional ethtool flag. Signed-off-by: Alexander Duyc

[net-next 06/14] ixgbe: Make all unchanging ops structures const

2016-04-04 Thread Jeff Kirsher
From: Mark Rustad The source for the ops structure contents are const, so make them so. Copy them in place with structure assignments instead of memcpys. Make the mbx_ops accessed by reference instead of making a copy of the source structure. Update copyright date on the touched files. Reported-

[net-next 12/14] ixgbe: Place SWFW semaphore in known valid state at probe

2016-04-04 Thread Jeff Kirsher
From: Don Skidmore It is possible on some HW that a system reset could occur when we are holding the SWFW semaphore lock. So next time the driver was loaded we would see it incorrectly as locked. This patch will recover from that state by: Attempting to acquire the semaphore and then regardless

[net-next 04/14] ixgbe: Do not allow PF to add VLVF entry unless it actually needs it

2016-04-04 Thread Jeff Kirsher
From: Alexander Duyck While doing the work on igb I realized there were a few cases where we were still adding VLANs to the VLVF entries for the PF when they were not needed. This patch cleans that up so that the only time we add a PF entry to the VLVF is either for VLAN 0 or if the PF has reque

[net-next 13/14] ixgbe: Extend cls_u32 offload to support UDP headers

2016-04-04 Thread Jeff Kirsher
From: Amritha Nambiar Added support to match on UDP fields in the transport layer. Extended core logic to support multiple headers. Verified with the following filters : handle 1: u32 divisor 1 u32 ht 800: order 1 link 1: \ offset at 0 mask 0f00 shift 6 plus 0 eat match

[net-next 10/14] ixgbe: Fix flow control for Xeon D KR backplane

2016-04-04 Thread Jeff Kirsher
From: Mark Rustad Xeon D KR backplane is different from other backplanes, in that we can't use auto-negotiation to determine the mode. Instead, use whatever the user configured. Signed-off-by: Mark Rustad Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgb

[net-next 01/14] ixgbe: on recv increment rx.ring->stats.yields

2016-04-04 Thread Jeff Kirsher
From: Pavel Tikhomirov It seem to be non intentionally changed to Tx in commit adc810900a70 ("ixgbe: Refactor busy poll socket code to address multiple issues") Lock is taken from ixgbe_low_latency_recv, and there under this lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment Tx

[net-next 08/14] ixgbe: Add support for generic Tx checksums

2016-04-04 Thread Jeff Kirsher
From: Alexander Duyck This patch adds support for generic Tx checksums to the ixgbe driver. It turns out this is actually pretty easy after going over the datasheet as we were doing a number of steps we didn't need to. In order to perform a Tx checksum for an L4 header we need to fill in the fo

Re: [RFC PATCH 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-04 Thread Thomas Graf
On 04/03/16 at 12:02am, Brenden Blanco wrote: > On Sat, Apr 02, 2016 at 12:39:45PM -0400, Tom Herbert wrote: > > Is there a hard restriction that this could only work with physical devices? > I suppose not, but there wouldn't be much use case as compared to tc > ingress, no? Since I was imagining t

  1   2   >