Hello,
I added the author of 13a56b449325 to Cc.
On Wed, Mar 23, 2016 at 12:44:40AM +0300, Sergei Shtylyov wrote:
> The driver of course "knows" that the chip's reset signal is active low,
> so it drives the GPIO to 0 to reset the PHY and to 1 otherwise; however
> all this will only work iff th
On Wed, 2016-03-23 at 09:35 +0800, Haishuang Yan wrote:
> vlan drivers lack proper propagation of gso_min_segs from lower device.
>
> Signed-off-by: Haishuang Yan
> ---
The plan was to get rid of gso_min_segs, as nothing uses it.
Otherwise I would have included this in my recent patches...
For
vlan drivers lack proper propagation of gso_min_segs from lower device.
Signed-off-by: Haishuang Yan
---
drivers/net/ipvlan/ipvlan_main.c | 2 ++
drivers/net/macvlan.c| 1 +
net/8021q/vlan.c | 1 +
net/8021q/vlan_dev.c | 1 +
4 files changed, 5 insertions(
Dropped skb's should be documented by an appropriate return value.
Use the correct NET_RX_DROP and NET_RX_SUCCESS values for that reason.
Signed-off-by: Haishuang Yan
---
net/ipv4/ip_gre.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre
A crash is observed when a decrypted packet is processed in receive
path. get_rps_cpus() tries to dereference the skb->dev fields but it
appears that the device is freed from the poison pattern.
[] get_rps_cpu+0x94/0x2f0
[] netif_rx_internal+0x140/0x1cc
[] netif_rx+0x74/0x94
[] xfrm_input+0x754/0x
On Tue, 2016-03-22 at 13:13 -0700, Cong Wang wrote:
> On Tue, Mar 22, 2016 at 11:03 AM, Wei Wang wrote:
> > Thanks Martin and Cong.
> >
> > I guess then we are going with the following fix in ip6_sk_update_pmtu():
> > 1. call ip6_upate_pmtu() as it is
> > 2. do a dst_check()
> > 3. re-lookup() if
This patch corrects an oversight in which we were allowing the encap_level
value to pass from the outer headers to the inner headers. As a result we
were incorrectly identifying UDP or GRE tunnels as also making use of ipip
or sit when the second header actually represented a tunnel encapsulated i
devm_ioremap_resource() returns ERR_PTR() value on error, it never
returns NULL, fix it and propagate the returned error upwards.
Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623 ethernet")
Signed-off-by: Vladimir Zapolskiy
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++--
On Tue, Mar 22, 2016 at 3:09 PM, Tom Herbert wrote:
> On Tue, Mar 22, 2016 at 2:45 PM, Alexander Duyck
> wrote:
>> On Tue, Mar 22, 2016 at 2:10 PM, Tom Herbert wrote:
>>> On Tue, Mar 22, 2016 at 1:20 PM, Alexander Duyck
>>> wrote:
On Tue, Mar 22, 2016 at 12:19 PM, Tom Herbert wrote:
>
'struct timeval' uses a 32-bit seconds field which will overflow in
year 2038 and beyond. This patch is part of a larger effort to remove
all instances of 'struct timeval' from the kernel and replace them
with 64-bit timekeeping variables.
The correctness of the code isn't affected by this patch -
On Tue, Mar 22, 2016 at 2:45 PM, Alexander Duyck
wrote:
> On Tue, Mar 22, 2016 at 2:10 PM, Tom Herbert wrote:
>> On Tue, Mar 22, 2016 at 1:20 PM, Alexander Duyck
>> wrote:
>>> On Tue, Mar 22, 2016 at 12:19 PM, Tom Herbert wrote:
In skb_segment the check of whether or not to perform the che
On Tue, Mar 22, 2016 at 2:10 PM, Tom Herbert wrote:
> On Tue, Mar 22, 2016 at 1:20 PM, Alexander Duyck
> wrote:
>> On Tue, Mar 22, 2016 at 12:19 PM, Tom Herbert wrote:
>>> In skb_segment the check of whether or not to perform the checksum on
>>> host was changed to not consider rather remote che
The driver of course "knows" that the chip's reset signal is active low,
so it drives the GPIO to 0 to reset the PHY and to 1 otherwise; however
all this will only work iff the GPIO is specified as active-high in the
device tree! I think both the driver and the device trees (if there are
any -
On Tue, Mar 22, 2016 at 12:40 PM, Edward Cree wrote:
> On 22/03/16 17:47, Alexander Duyck wrote:
>> On Tue, Mar 22, 2016 at 10:00 AM, Edward Cree wrote:
>>> On 18/03/16 23:25, Alexander Duyck wrote:
This patch adds support for something I am referring to as GSO partial.
The basic idea i
On 03/22/2016 11:07 PM, David Miller wrote:
On 03/22/2016 10:27 PM, Sergei Shtylyov wrote:
The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and
1, as
a result the PHY isn't really put back into reset state in
macb_remove().
Moreover, the driver assumes that something else has s
On Tue, Mar 22, 2016 at 2:02 PM, David Ahern wrote:
> On 3/22/16 2:45 PM, Cong Wang wrote:
>>
>> @@ -1426,7 +1426,7 @@ int fib_table_lookup(struct fib_table *tb, const
>> struct flowi4 *flp,
>> nh->nh_flags & RTNH_F_LINKDOWN &&
>> !(fib_fla
On Tue, Mar 22, 2016 at 1:20 PM, Alexander Duyck
wrote:
> On Tue, Mar 22, 2016 at 12:19 PM, Tom Herbert wrote:
>> In skb_segment the check of whether or not to perform the checksum on
>> host was changed to not consider rather remote checksum offload is
>> in use. In the case that can_checksum_pr
On 03/22/2016 11:07 PM, David Miller wrote:
The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and
1, as
a result the PHY isn't really put back into reset state in
macb_remove().
Moreover, the driver assumes that something else has set the GPIO
direction
to output, so if it has not
On 3/22/16 2:45 PM, Cong Wang wrote:
@@ -1426,7 +1426,7 @@ int fib_table_lookup(struct fib_table *tb, const
struct flowi4 *flp,
nh->nh_flags & RTNH_F_LINKDOWN &&
!(fib_flags & FIB_LOOKUP_IGNORE_LINKSTATE))
On Tue, Mar 22, 2016 at 11:29 AM, David Ahern wrote:
> On 3/22/16 9:31 AM, Lance Richardson wrote:
>>
>> Field fl4.flowi4_flags is not initialized in fib_compute_spec_dst()
>> before calling fib_lookup(), which means fib_table_lookup() is
>> using non-deterministic data at this line:
>>
>>
On Tue, Mar 22, 2016 at 12:19 PM, Tom Herbert wrote:
> In skb_segment the check of whether or not to perform the checksum on
> host was changed to not consider rather remote checksum offload is
> in use. In the case that can_checksum_protocol fails the checksum
> is computed regardless. __skb_udp_
From: Claudio Imbrenda
Date: Tue, 22 Mar 2016 17:05:50 +0100
> This patchset applies on net-next.
>
> I think I found a problem with the patch submitted by Laura Abbott
> ( https://lkml.org/lkml/2016/2/4/711 ): we might miss wakeups.
> Since the condition is not checked between the prepare_to_wa
From: Jesse Gross
Date: Tue, 22 Mar 2016 13:11:21 -0700
> Features that have been designed this way in the past are usually
> pretty fragile. Not only would you have to track changes in the
> routing table but you could have bridges, tc, vlan devices, etc. all
> of which might change the path of
On Tue, 2016-03-22 at 13:00 -0600, David Ahern wrote:
> On 3/22/16 12:56 PM, Lance Richardson wrote:
> >
> > Fixes: 58189ca7b2741 ("net: Fix vti use case with oif in dst lookups")
> DaveM: this should go into stable releases back to v4.3.
>
The 'Fixes' tag tells this already ;)
$ git describe
On Tue, Mar 22, 2016 at 11:03 AM, Wei Wang wrote:
> Thanks Martin and Cong.
>
> I guess then we are going with the following fix in ip6_sk_update_pmtu():
> 1. call ip6_upate_pmtu() as it is
> 2. do a dst_check()
> 3. re-lookup() if it is invalid
> 4. and then do a ip6_dst_store()/dst_set
Exactly,
On Tue, Mar 22, 2016 at 12:40 PM, Edward Cree wrote:
> On 22/03/16 17:47, Alexander Duyck wrote:
>> On Tue, Mar 22, 2016 at 10:00 AM, Edward Cree wrote:
>>> On 18/03/16 23:25, Alexander Duyck wrote:
This patch adds support for something I am referring to as GSO partial.
The basic idea i
From: Sergei Shtylyov
Date: Tue, 22 Mar 2016 22:34:05 +0300
> On 03/22/2016 10:27 PM, Sergei Shtylyov wrote:
>
>> The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and
>> 1, as
>> a result the PHY isn't really put back into reset state in
>> macb_remove().
>> Moreover, the driver
From: Lance Richardson
Date: Tue, 22 Mar 2016 14:58:59 -0400 (EDT)
> Apologies, that should have been [PATCH v2 net].
No worries.
Applied and queued up for -stable, thanks.
From:
Date: Mon, 21 Mar 2016 23:08:11 +0200
> From: Igal Liberman
>
> Errata A-007273 (For FMan V3 devices only):
> FMan soft reset is not finished properly if one
> of the Ethernet MAC clocks is disabled
>
> Workaround:
> Re-enable all disabled MAC clocks through the DCFG_CCSR_DEVDISR2
> regi
From: Yoshihiro Kaneko
Date: Wed, 23 Mar 2016 00:22:00 +0900
> From: Kazuya Mizuguchi
>
> This patch supports the following interrupts.
>
> - One interrupt for multiple (timestamp, error, gPTP)
> - One interrupt for emac
> - Four interrupts for dma queue (best effort rx/tx, network control rx/
From: Paolo Abeni
Date: Tue, 22 Mar 2016 09:19:38 +0100
> Currently, ingress ipv4 broadcast datagrams are dropped since,
> in udp_v4_early_demux(), ip_check_mc_rcu() is invoked even on
> bcast packets.
>
> This patch addresses the issue, invoking ip_check_mc_rcu()
> only for mcast packets.
>
>
From: Yisen Zhuang
Date: Tue, 22 Mar 2016 16:06:21 +0800
> This series includes some bug fixes and updates for hns driver.
>
>>from Daode, one fix about mss.
>
>>from Kejian, one fix about ping6 issue, one fix about mac address setting,
> two fix for RSS setting, two fix about mtu setting.
>
>
ping^2
On Tue, Mar 08 2016, Rasmus Villemoes wrote:
> ping
>
> On Tue, Feb 09 2016, Rasmus Villemoes wrote:
>
>> We need to use post-decrement to ensure that irq_dispose_mapping is
>> also called on priv->rxq[0]->irq_no; moreover, if one of the above for
>> loops failed already at i==0 (so we r
On 22/03/16 17:47, Alexander Duyck wrote:
> On Tue, Mar 22, 2016 at 10:00 AM, Edward Cree wrote:
>> On 18/03/16 23:25, Alexander Duyck wrote:
>>> This patch adds support for something I am referring to as GSO partial.
>>> The basic idea is that we can support a broader range of devices for
>>> seg
Hello Sebastian,
On Tue, Mar 22, 2016 at 03:34:23PM +0100, Sebastian Frias wrote:
> I think we are in a deadlock :-)
> I'm going to reply inline below, but I will also send a different email
> to Daniel with a small recap.
> I think he should share the intent of the "reset" mechanism he
> introduc
On 03/22/2016 10:27 PM, Sergei Shtylyov wrote:
The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and 1, as
a result the PHY isn't really put back into reset state in macb_remove().
Moreover, the driver assumes that something else has set the GPIO direction
to output, so if it ha
The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and 1, as
a result the PHY isn't really put back into reset state in macb_remove().
Moreover, the driver assumes that something else has set the GPIO direction
to output, so if it has not, the PHY wouldn't be taken out of reset in
m
In skb_segment the check of whether or not to perform the checksum on
host was changed to not consider rather remote checksum offload is
in use. In the case that can_checksum_protocol fails the checksum
is computed regardless. __skb_udp_tunnel_segment was modified in a
related patch to add NETIF_F_
On 3/22/16 12:56 PM, Lance Richardson wrote:
Field fl4.flowi4_flags is not initialized in fib_compute_spec_dst()
before calling fib_lookup(), which means fib_table_lookup() is
using non-deterministic data at this line:
if (!(flp->flowi4_flags & FLOWI_FLAG_SKIP_NH_OIF)) {
Fix by initiali
Apologies, that should have been [PATCH v2 net].
- Original Message -
> From: "Lance Richardson"
> To: netdev@vger.kernel.org
> Cc: d...@cumulusnetworks.com
> Sent: Tuesday, March 22, 2016 2:56:57 PM
> Subject: [PATCH net] ipv4: initialize flowi4_flags before calling fib_lookup()
>
> Fie
Field fl4.flowi4_flags is not initialized in fib_compute_spec_dst()
before calling fib_lookup(), which means fib_table_lookup() is
using non-deterministic data at this line:
if (!(flp->flowi4_flags & FLOWI_FLAG_SKIP_NH_OIF)) {
Fix by initializing the entire fl4 structure, which will preve
> drivers/infiniband/Kconfig |1 +
> drivers/infiniband/hw/Makefile |1 +
> drivers/infiniband/hw/hisilicon/hns/Kconfig| 10 +
To fit in with the other drivers drop the hisilicon level
of the directory hierarchy.
Haven't had time to lo
- Original Message -
> From: "David Ahern"
> To: "Lance Richardson" , netdev@vger.kernel.org
> Sent: Tuesday, March 22, 2016 2:29:02 PM
> Subject: Re: [PATCH net] ipv4: initialize flowi4_flags before calling
> fib_lookup()
>
> On 3/22/16 9:31 AM, Lance Richardson wrote:
> > Field fl4.flo
Signed-off-by: Phil Sutter
---
ip/ipaddress.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 7aab8e781eae8..90d7b1096c3aa 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -862,7 +862,8 @@ int print_lin
This adds two helper functions which map a given data field to a color,
so color_fprintf() statements don't have to be duplicated with only a
different color value depending on that data field's value. In order for
this to work in a generic way, COLOR_CLEAR has been added to serve as a
fallback def
Apart from making the code a bit more compact and efficient, this also
prevents a potential buffer overflow if the passed buffer is really too
small: Although correctly decrementing the size parameter passed to
snprintf, it could become negative which would then wrap since snprintf
uses (unsigned)
There is only a single user who needs it to be reentrant (not really,
but it's safer like this), add rt_addr_n2a_r() for it to use.
Signed-off-by: Phil Sutter
---
include/utils.h | 3 ++-
ip/ip6tunnel.c| 2 +-
ip/iplink_bond.c | 5 +
ip/ipmroute.c | 7 ++-
This simple macro eases calling rt_addr_n2a() with data from an rt_attr
pointer.
Signed-off-by: Phil Sutter
---
include/utils.h | 2 ++
ip/iplink_bond.c | 4 +---
ip/ipmroute.c | 8 ++--
ip/ipprefix.c | 14 +++---
ip/iproute.c | 20 +++--
There are only three users which require it to be reentrant, the rest is
fine without. Instead, provide a reentrant format_host_r() for users
which need it.
Signed-off-by: Phil Sutter
---
bridge/fdb.c | 4 +---
include/utils.h | 3 ++-
ip/ip6tunnel.c| 2 +-
ip/ipaddress
The following series is a result of reviewing color output support and
some formatting helpers usually used with struct rtattr fields.
Phil Sutter (7):
color: introduce color helpers and COLOR_CLEAR
ipaddress: colorize peer, broadcast and anycast addresses as well
make format_host non-reentr
On 3/22/16 9:31 AM, Lance Richardson wrote:
Field fl4.flowi4_flags is not initialized in fib_compute_spec_dst()
before calling fib_lookup(), which means fib_table_lookup() is
using non-deterministic data at this line:
if (!(flp->flowi4_flags & FLOWI_FLAG_SKIP_NH_OIF)) {
Fix by initializ
This simple macro eases calling format_host() with data from an rt_attr
pointer.
Signed-off-by: Phil Sutter
---
include/utils.h | 2 ++
ip/ipaddress.c| 20
ip/ipaddrlabel.c | 5 ++---
ip/ipneigh.c | 4 +---
ip/iproute.c | 33 ++
On Tue, Mar 22, 2016 at 10:39 AM, Martin KaFai Lau wrote:
> On Tue, Mar 22, 2016 at 09:53:35AM -0700, Cong Wang wrote:
>> On Mon, Mar 21, 2016 at 11:02 PM, Martin KaFai Lau wrote:
>> > In term of difference, AFAICT, the current patch is an optimization in the
>> > sense that the update_pmtu() cod
On Tue, Mar 22, 2016 at 11:03:29AM -0700, Wei Wang wrote:
> But one thing here, we will have to generate the same flowi6 in both
> ip6_sk_update_pmtu() as well as ip6_update_pmtu(). Is this considered
> as a not clean enough fix?
If they share common codes to build flowi6, can the common codes
be f
Thanks Martin and Cong.
I guess then we are going with the following fix in ip6_sk_update_pmtu():
1. call ip6_upate_pmtu() as it is
2. do a dst_check()
3. re-lookup() if it is invalid
4. and then do a ip6_dst_store()/dst_set
But one thing here, we will have to generate the same flowi6 in both
ip6
On Tue, Mar 22, 2016 at 10:00 AM, Edward Cree wrote:
> On 18/03/16 23:25, Alexander Duyck wrote:
>> This patch adds support for something I am referring to as GSO partial.
>> The basic idea is that we can support a broader range of devices for
>> segmentation if we use fixed outer headers and have
On Tue, Mar 22, 2016 at 09:53:35AM -0700, Cong Wang wrote:
> On Mon, Mar 21, 2016 at 11:02 PM, Martin KaFai Lau wrote:
> > In term of difference, AFAICT, the current patch is an optimization in the
> > sense that the update_pmtu() code path does not have to do a dst_check to
> > discover its sk->s
On Tue, 2016-03-22 at 12:23 +0530, Ashwini Singh wrote:
> Signed-off-by: Ashwini Singh
It might be better to break this into a few different patches.
o Remove trailing whitespace
o Fix vertical line / brace location
o Multi-line statement parenthesis alignment
o Space to tab conversions
o Whites
Hi Robin,
On 03/19/2016 07:53 PM, Robin H. Johnson wrote:
[...]
Playing around with IPv6 tokens, I ran into a problem:
Once you have a token set on an interface, it's impossible to remove it!
# ip token set :: dev eth0
RTNETLINK answers: Invalid argument
I'll have a look into a fix, I think t
On 18/03/16 23:25, Alexander Duyck wrote:
> This patch adds support for something I am referring to as GSO partial.
> The basic idea is that we can support a broader range of devices for
> segmentation if we use fixed outer headers and have the hardware only
> really deal with segmenting the inner
On Sun, Mar 13, 2016 at 8:18 AM, Geliang Tang wrote:
> Use KMEM_CACHE() instead of kmem_cache_create() to simplify the code.
>
> Signed-off-by: Geliang Tang
> ---
> net/ceph/messenger.c | 10 ++
> net/ceph/osd_client.c | 5 +
> 2 files changed, 3 insertions(+), 12 deletions(-)
>
>
On Mon, Mar 21, 2016 at 11:02 PM, Martin KaFai Lau wrote:
> I think Cong Wang is suggesting, in ip6_sk_update_pmtu():
> 1. call ip6_upate_pmtu() as it is
> 2. do a dst_check()
> 3. re-lookup() if it is invalid
> 4. and then do a ip6_dst_store()/dst_set
>
> The above is exactly what inet6_csk_updat
On Mon, Mar 21, 2016 at 10:02 PM, Giuseppe CAVALLARO
wrote:
> On 3/21/2016 11:45 AM, Alexandre Torgue wrote:
>>
>> Hi,
>>
>> 2016-03-18 17:00 GMT+01:00 Chen-Yu Tsai :
>>>
>>> Hi,
>>>
>>> On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE
>>> wrote:
Signed-off-by: Alexandre TORGUE
Hi guys,
I will fix typo issues (s/vesrion/version and ethernet @).
Concerning compatible string. For sure "snps,dwmac-3.50a" string is
not used inside glue driver.
I perfere to keep it for information but if you really want that I
remove it I will not block ;)
2016-03-21 16:36 GMT+01:00 Joachim
This reverts commit 5988818008257ca42010d6b43a3e0e48afec9898 ("vsock: Fix
blocking ops call in prepare_to_wait")
The commit reverted with this patch caused us to potentially miss wakeups.
Since the condition is not checked between the prepare_to_wait and the
schedule(), if a wakeup happens after t
When a thread is prepared for waiting by calling prepare_to_wait, sleeping
is not allowed until either the wait has taken place or finish_wait has
been called. The existing code in af_vsock imposed unnecessary no-sleep
assumptions to a broad list of backend functions.
This patch shrinks the influe
This patchset applies on net-next.
I think I found a problem with the patch submitted by Laura Abbott
( https://lkml.org/lkml/2016/2/4/711 ): we might miss wakeups.
Since the condition is not checked between the prepare_to_wait and the
schedule(), if a wakeup happens after the condition is checked
This patch was generated by the following semantic patch (a trimmed down
version of what is shipped with Linux sources):
@@
type T;
T[] E;
@@
(
- (sizeof(E)/sizeof(*E))
+ ARRAY_SIZE(E)
|
- (sizeof(E)/sizeof(E[...]))
+ ARRAY_SIZE(E)
|
- (sizeof(E)/sizeof(T))
+ ARRAY_SIZE(E)
)
The only manual adjus
On Tue, 2016-03-22 at 11:13 -0400, Alan Stern wrote:
> > Indeed. In that case the point is moot. But it is correct to ask
> > the core whether the device is autosuspended at that point rather
> > than keep a private flag if you can.
>
> That's why we have pm_runtime_status_suspended().
I guess we
Field fl4.flowi4_flags is not initialized in fib_compute_spec_dst()
before calling fib_lookup(), which means fib_table_lookup() is
using non-deterministic data at this line:
if (!(flp->flowi4_flags & FLOWI_FLAG_SKIP_NH_OIF)) {
Fix by initializing fl4.flowi4_flags to zero.
Signed-off-by:
On Tue, Mar 22, 2016 at 08:21:28AM -0700, Eric Dumazet wrote:
> On Tue, 2016-03-22 at 23:08 +0800, Baozeng Ding wrote:
> > Hi all,
> >
> > The following program triggers an out-of-bounds bug in
> > sctp_getsockopt. The kernel version is 4.5 (on Mar 16
> > commit 09fd671ccb2475436bd5f597f751ca4a7d1
On Tue, 2016-03-22 at 08:21 -0700, Eric Dumazet wrote:
> On Tue, 2016-03-22 at 23:08 +0800, Baozeng Ding wrote:
> > Hi all,
> >
> > The following program triggers an out-of-bounds bug in
> > sctp_getsockopt. The kernel version is 4.5 (on Mar 16
> > commit 09fd671ccb2475436bd5f597f751ca4a7d177aea).
From: Kazuya Mizuguchi
This patch supports the following interrupts.
- One interrupt for multiple (timestamp, error, gPTP)
- One interrupt for emac
- Four interrupts for dma queue (best effort rx/tx, network control rx/tx)
This patch improve efficiency of the interrupt handler by adding the
int
On Tue, 2016-03-22 at 23:08 +0800, Baozeng Ding wrote:
> Hi all,
>
> The following program triggers an out-of-bounds bug in
> sctp_getsockopt. The kernel version is 4.5 (on Mar 16
> commit 09fd671ccb2475436bd5f597f751ca4a7d177aea).
>
>
On Tue, 22 Mar 2016, Oliver Neukum wrote:
> On Tue, 2016-03-22 at 10:21 -0400, Alan Stern wrote:
> > I don't see any point in resuming the device just in order to collect
> > operating statistics. If it was already suspended then it wasn't
> > operating, so there will be no statistics to collec
Hi all,
The following program triggers an out-of-bounds bug in
sctp_getsockopt. The kernel version is 4.5 (on Mar 16
commit 09fd671ccb2475436bd5f597f751ca4a7d177aea).
==
BUG: KASAN: stack-out-of-bounds in string+0x1ef/0x200 at addr
Hi,
On 03/21/2016 09:41 PM, Uwe Kleine-König wrote:
>>My patch basically gets rid of all this code. The thing that worries me
>> is that the driver assumes that the reset singal is active low, despite what
>> the GPIO specifier in the device tree has for the GPIO polarity. In fact, it
>> will
This should be made generic and part of a common tc-actions man page.
Though leave it here for now to not confuse readers of the example which
uses it.
Signed-off-by: Phil Sutter
---
man/man8/tc-vlan.8 | 56 +-
1 file changed, 55 insertions(+),
Cc: Alexei Starovoitov
Signed-off-by: Phil Sutter
---
doc/tc-filters.tex | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/doc/tc-filters.tex b/doc/tc-filters.tex
index 59127d6672ed7..54cc0c9920ce2 100644
--- a/doc/tc-filters.tex
+++ b/doc/tc-filters.te
Signed-off-by: Phil Sutter
---
man/man8/tc-skbedit.8 | 12
1 file changed, 12 insertions(+)
diff --git a/man/man8/tc-skbedit.8 b/man/man8/tc-skbedit.8
index b585a4d4253ba..e6902960eee27 100644
--- a/man/man8/tc-skbedit.8
+++ b/man/man8/tc-skbedit.8
@@ -17,6 +17,18 @@ The
action all
Signed-off-by: Phil Sutter
---
man/man8/tc-mirred.8 | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/man/man8/tc-mirred.8 b/man/man8/tc-mirred.8
index 52d98bc416563..bba96e0e5d8c0 100644
--- a/man/man8/tc-mirred.8
+++ b/man/man8/tc-mirred.8
@@ -21,11
The following patch series aims at addressing feedback provided by Jamal
and Alexei. Thanks a lot for your input!
Changes since v1:
- Rebased onto current master.
- Dropped some leftover TODO note from tc-skbedit.8
Phil Sutter (8):
doc/tc-filters.tex: Drop overly subjective paragraphs
tc: con
As Jamal suggested, BRANCH is the wrong name, as these keywords go
beyond simple branch control - e.g. loops are possible, too. Therefore
rename the non-terminal to CONTROL instead which should be more
appropriate.
Signed-off-by: Phil Sutter
---
man/man8/tc-connmark.8 | 6 +++---
man/man8/tc-ped
Signed-off-by: Phil Sutter
---
tc/m_vlan.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tc/m_vlan.c b/tc/m_vlan.c
index 8d97963f351bc..3233d207375bf 100644
--- a/tc/m_vlan.c
+++ b/tc/m_vlan.c
@@ -22,9 +22,10 @@
static void explain(void)
{
fprintf(stderr, "Usage:
As Jamal pointed out, there are two different approaches to bandwidth
measurement. Try to make this clear by separating them in synopsis and
also documenting the way to fine-tune avrate.
Signed-off-by: Phil Sutter
---
man/man8/tc-police.8 | 29 +
1 file changed, 25 in
Signed-off-by: Phil Sutter
---
man/man8/tc-csum.8 | 15 +++
1 file changed, 15 insertions(+)
diff --git a/man/man8/tc-csum.8 b/man/man8/tc-csum.8
index 9d00aae346af0..3a64c82f09ba8 100644
--- a/man/man8/tc-csum.8
+++ b/man/man8/tc-csum.8
@@ -49,6 +49,21 @@ UDPLite header
.TP
.B SWE
Hi Sergei,
On 03/21/2016 09:15 PM, Sergei Shtylyov wrote:
>
>Do you have the PHY that requires the GPIO reset workaround?
Unfortunately (or luckily :-) ) I don't have the faulty PHY, sorry.
Best regards,
Sebastian
Hi Daniel,
Would you mind commenting on this thread?
Uwe and I are in a sort of deadlock because we each have a different
understanding of the intention of your commit 13a56b449325.
Basically the questions are:
- What is the intention of 13a56b449325?
- Did you mean for "reset" to be mandatory fo
Hi Uwe,
I think we are in a deadlock :-)
I'm going to reply inline below, but I will also send a different email
to Daniel with a small recap.
I think he should share the intent of the "reset" mechanism he
introduced, in particular if it is mandatory.
On 03/21/2016 09:12 PM, Uwe Kleine-König wro
On Tue, 2016-03-22 at 10:21 -0400, Alan Stern wrote:
> I don't see any point in resuming the device just in order to collect
> operating statistics. If it was already suspended then it wasn't
> operating, so there will be no statistics to collect.
Indeed. In that case the point is moot. But it
On Tue, 22 Mar 2016, Oliver Neukum wrote:
> On Mon, 2016-03-21 at 15:30 -0400, Alan Stern wrote:
> > On Mon, 21 Mar 2016, Oliver Neukum wrote:
> >
>
> > > We have an autosuspend timeout because we think that IO, if it will
> > > come at all, is likeliest to come soon. If, however, the IO is
> >
From: Igal Liberman
Errata A-007273 (For FMan V3 devices only):
FMan soft reset is not finished properly if one
of the Ethernet MAC clocks is disabled
Workaround:
Re-enable all disabled MAC clocks through the DCFG_CCSR_DEVDISR2
register prior to issuing an FMAN soft reset.
Re-disable the MAC clo
The retain value was wrong for u16 and u8 types.
Signed-off-by: Phil Sutter
---
tc/m_pedit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tc/m_pedit.c b/tc/m_pedit.c
index 30a6f3673e896..8ccec8bc4a99f 100644
--- a/tc/m_pedit.c
+++ b/tc/m_pedit.c
@@ -339,12 +339,12 @@ p
This is not a full test, since kernel functionality is not actually
tested. It only compares that the kernel returned values when listing
the action are what one expects them to be.
Since this test succeeded on both a little-endian and a big-endian
system, it shows that any endianness issues have
The following series was created after testing pedit on a big-endian
system. It starts with a minor patch fixing coding style in tc/p_ip.c,
then the actual big-endian fixup, a fix for raw op discovered when
writing the pedit test for testsuite and finally a testsuite addon to
verify pedit functiona
This was tricky to get right:
- The 'stride' value used for 8 and 16 bit values must behave inverse to
the value's intra word offset to work correctly with big-endian data
act_pedit is editing.
- The 'm' array's values are in host byte order, so they have to be
converted as well (and the orde
Break overlong function definitions and remove one extraneous
whitespace.
Signed-off-by: Phil Sutter
---
tc/p_ip.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tc/p_ip.c b/tc/p_ip.c
index 53dfb2693d47e..535151e5d7668 100644
--- a/tc/p_ip.c
+++ b/tc/p_ip.c
@@ -24,7
This patch adds related DTS binding document for HiSilicon RoCE driver.
Signed-off-by: Lijun Ou
Signed-off-by: Wei Hu(Xavier)
---
.../bindings/infiniband/hisilicon-hns-roce.txt | 107 +
1 file changed, 107 insertions(+)
create mode 100644
Documentation/devicetree/bindi
The HiSilicon Network Substem is a long term evolution IP which is
supposed to be used in HiSilicon ICT SoC. RoCE is a feature of hns.
The driver for HiSilicon RoCE engine is a platform driver.
The driver will support mulitple versions of hns. Currently only "v1"
for hip06 SoC is supported.
Change
It added reset function for RoCE driver. RoCE is a feature of hns.
In hip06 SoC, in RoCE reset process, it's needed to configure dsaf
channel reset, port and sl map info. Reset function of RoCE is
located in dsaf module, we only call it in RoCE driver when needed.
Signed-off-by: Lijun Ou
Signed-o
1 - 100 of 125 matches
Mail list logo
