Re: [PATCH V2 net 0/6] net: hns: hns driver updates

2016-03-14 Thread Daode Huang
hi Dave, Thanks for your reply, I am so sorry to interrupt your work. Yes, the patch set should be reviewed by all the other developers. I should not only ask you to review the patch. I will resend all these patch after 4.6-rc-1 is released. Thanks. Daode. . On 2016/3/15 10:45, David Miller w

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread roopa
On 3/14/16, 8:11 AM, Elad Raz wrote: > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Roopa Prabhu >> Sent: Sunday, March 13, 2016 3:56 AM >> To: netdev@vger.kernel.org >> Cc: j...@mojatatu.com; da...@davemloft.net >> Subjec

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread roopa
On 3/14/16, 8:00 AM, Nicolas Dichtel wrote: > Le 13/03/2016 02:56, Roopa Prabhu a écrit : >> From: Roopa Prabhu >> >> This patch adds a new RTM_GETSTATS message to query link stats via netlink >> from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK >> returns a lot more than just s

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread roopa
On 3/14/16, 12:04 PM, Jiri Pirko wrote: > Mon, Mar 14, 2016 at 07:45:23PM CET, ro...@cumulusnetworks.com wrote: >> On 3/14/16, 7:51 AM, Jiri Pirko wrote: >>> Sun, Mar 13, 2016 at 02:56:25AM CET, ro...@cumulusnetworks.com wrote: From: Roopa Prabhu This patch adds a new RTM_GETSTATS m

Re: [target-pending 00/12] cxgb4 patch series for cxgbit.ko

2016-03-14 Thread Nicholas A. Bellinger
Hi Varun & Co, On Sun, 2016-03-13 at 19:49 +0530, Varun Prakash wrote: > Hi Nicholas, > >I am posting cxgb4 patch series as >suggested by you in following email thread > >http://www.spinics.net/lists/target-devel/msg12437.html > >This series consists of patches from >initial

RE: [PATCH 1/2] arm64: insn: remove BUG_ON from codegen

2016-03-14 Thread 平松雅巳 / HIRAMATU,MASAMI
> >During code generation, we used to BUG_ON unknown/unsupported encoding >or invalid parameters. > >Instead, now we report these as errors and simply return the >instruction AARCH64_BREAK_FAULT. Users of these codegen helpers should >check for and handle this failure condition as appropriate. > >O

Re: [PATCH V2 net 0/4] net: hns: bugs fix about hns driver

2016-03-14 Thread Yankejian (Hackim Yim)
On 2016/3/12 0:56, David Miller wrote: > This does not work. > > I will not allow two sets of people sending me patches in parallel to the > same driver at the same time. > > Have one person manage the maintainence of this driver and consolidate the > patch submissions to me. > > Thanks. > > . >

Re: [PATCH V4 0/3] basic busy polling support for vhost_net

2016-03-14 Thread Jason Wang
On 03/10/2016 02:48 PM, Michael Rapoport wrote: > Hi Greg, > >> > Greg Kurz wrote on 03/09/2016 09:26:45 PM: >>> > > On Fri, 4 Mar 2016 06:24:50 -0500 >>> > > Jason Wang wrote: >> > >>> > > This series tries to add basic busy polling for vhost net. The idea is >>> > > simple: at the end of tx

Re: [PATCH net-next] openvswitch: allow output of MPLS packets on tunnel vports

2016-03-14 Thread Simon Horman
On Tue, Mar 15, 2016 at 11:52:42AM +0900, Simon Horman wrote: > From: Simon Horman Sorry, I mixed up my own email address somehow. I will repost.

[PATCH net-next repost] openvswitch: allow output of MPLS packets on tunnel vports

2016-03-14 Thread Simon Horman
Currently output of MPLS packets on tunnel vports is not allowed by Open vSwitch. This is because historically encapsulation was done in such a way that the inner_protocol field of the skb needed to hold the inner protocol for both MPLS and tunnel encapsulation in order for GSO segmentation to be p

[PATCH net-next] openvswitch: allow output of MPLS packets on tunnel vports

2016-03-14 Thread Simon Horman
From: Simon Horman Currently output of MPLS packets on tunnel vports is not allowed by Open vSwitch. This is because historically encapsulation was done in such a way that the inner_protocol field of the skb needed to hold the inner protocol for both MPLS and tunnel encapsulation in order for GSO

Re: [PATCH V2 net 0/6] net: hns: hns driver updates

2016-03-14 Thread David Miller
From: Daode Huang Date: Tue, 15 Mar 2016 09:56:02 +0800 > Could you please help me to review this patch set? I am not reviewing anything until you guys sort out your submission scheme, and resend these fresh using that central maintainer. I am also not the only person in the world who is suppos

Re: [PATCH 00/18] Netfilter/IPVS/OVS updates for net-next

2016-03-14 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 15 Mar 2016 02:27:44 +0100 > The following patchset contains Netfilter/IPVS fixes and OVS NAT > support, more specifically this batch is composed of: ... > You can pull these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git

[net-next iproute2 v2 2/2] man: update netconf manual for new attributes

2016-03-14 Thread Zhang Shengju
Update this manual to add attributes proxy_neigh and ignore_routes_with_linkdown. Signed-off-by: Zhang Shengju --- man/man8/ip-netconf.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-netconf.8 b/man/man8/ip-netconf.8 index 2718258..7fe3e5f 100644 --- a/man/man8/

[net-next iproute2 v2 0/2]netconf: add support for ignore route attribute

2016-03-14 Thread Zhang Shengju
This patch series add support for ignore route attribute. v1->v2: - update manual - use rta_getattr_* instead of RTA_DATA - fix code styles Zhang Shengju (2): netconf: add support for ignore route attribute man: update netconf manual for new attributes ip/ipnetconf.c| 25 +++

[net-next iproute2 v2 1/2] netconf: add support for ignore route attribute

2016-03-14 Thread Zhang Shengju
Add support for ignore route attribute, and refine the code to use rta_getattr_* function to get attribute value. Signed-off-by: Zhang Shengju --- ip/ipnetconf.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/ip/ipnetconf.c b/ip/ipnetconf.c index e

Re: [PATCH V2 net 0/6] net: hns: hns driver updates

2016-03-14 Thread Daode Huang
Hi Dave, Could you please help me to review this patch set? I am so sorry to send the patches in parallel to you, which increases you workload, So next time we will pay more attention to it, and learn more about kernel patch submitting. Thanks. MBR, Daode On 2016/3/11 17:10, Daode Huang wro

[PATCH 01/18] netfilter: ipset: Fix set:list type crash when flush/dump set in parallel

2016-03-14 Thread Pablo Neira Ayuso
From: Jozsef Kadlecsik Flushing/listing entries was not RCU safe, so parallel flush/dump could lead to kernel crash. Bug reported by Deniz Eren. Fixes netfilter bugzilla id #1050. Signed-off-by: Jozsef Kadlecsik --- net/netfilter/ipset/ip_set_core.c | 3 ++ net/netfilter/ipset/ip_set_lis

[PATCH 05/18] ipvs: allow rescheduling after RST

2016-03-14 Thread Pablo Neira Ayuso
From: Julian Anastasov "RFC 5961, 4.2. Mitigation" describes a mechanism to request client to confirm with RST the restart of TCP connection before resending its SYN. As result, IPVS can see SYNs for existing connection in CLOSE state. Add check to allow rescheduling in this state. Signed-off-by

[PATCH 12/18] openvswitch: Add commentary to conntrack.c

2016-03-14 Thread Pablo Neira Ayuso
From: Jarno Rajahalme This makes the code easier to understand and the following patches more focused. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer Signed-off-by: Pablo Neira Ayuso --- net/openvswitch/conntrack.c | 21 - 1 file changed, 20 insertions(+), 1 deleti

[PATCH 07/18] netfilter: ipset: Check IPSET_ATTR_ETHER netlink attribute length

2016-03-14 Thread Pablo Neira Ayuso
From: Jozsef Kadlecsik Julia Lawall pointed out that IPSET_ATTR_ETHER netlink attribute length was not checked explicitly, just for the maximum possible size. Malicious netlink clients could send shorter attribute and thus resulting a kernel read after the buffer. The patch adds the explicit len

[PATCH 11/18] netfilter: Allow calling into nat helper without skb_dst.

2016-03-14 Thread Pablo Neira Ayuso
From: Jarno Rajahalme NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by:

[PATCH 02/18] netfilter: nfnetlink_acct: validate NFACCT_FILTER parameters

2016-03-14 Thread Pablo Neira Ayuso
From: Phil Turnbull nfacct_filter_alloc doesn't validate the NFACCT_FILTER_MASK and NFACCT_FILTER_VALUE parameters which can trigger a NULL pointer dereference. CAP_NET_ADMIN is required to trigger the bug. Signed-off-by: Phil Turnbull Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nfnetl

[PATCH 09/18] netfilter: x_tables: check for size overflow

2016-03-14 Thread Pablo Neira Ayuso
From: Florian Westphal Ben Hawkes says: integer overflow in xt_alloc_table_info, which on 32-bit systems can lead to small structure allocation and a copy_from_user based heap corruption. Reported-by: Ben Hawkes Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netf

[PATCH 03/18] ipvs: handle ip_vs_fill_iph_skb_off failure

2016-03-14 Thread Pablo Neira Ayuso
From: Arnd Bergmann ip_vs_fill_iph_skb_off() may not find an IP header, and gcc has determined that ip_vs_sip_fill_param() then incorrectly accesses the protocol fields: net/netfilter/ipvs/ip_vs_pe_sip.c: In function 'ip_vs_sip_fill_param': net/netfilter/ipvs/ip_vs_pe_sip.c:76:5: error: 'iph.pro

[PATCH 08/18] netfilter: nft_compat: check match/targetinfo attr size

2016-03-14 Thread Pablo Neira Ayuso
From: Florian Westphal We copy according to ->target|matchsize, so check that the netlink attribute (which can include padding and might be larger) contains enough data. Reported-by: Julia Lawall Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_compat.c

[PATCH 06/18] ipvs: correct initial offset of Call-ID header search in SIP persistence engine

2016-03-14 Thread Pablo Neira Ayuso
From: Marco Angaroni The IPVS SIP persistence engine is not able to parse the SIP header "Call-ID" when such header is inserted in the first positions of the SIP message. When IPVS is configured with "--pe sip" option, like for example: ipvsadm -A -u 1.2.3.4:5060 -s rr --pe sip -p 120 -o some pa

[PATCH 16/18] openvswitch: Delay conntrack helper call for new connections.

2016-03-14 Thread Pablo Neira Ayuso
From: Jarno Rajahalme There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Sig

[PATCH 00/18] Netfilter/IPVS/OVS updates for net-next

2016-03-14 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter/IPVS fixes and OVS NAT support, more specifically this batch is composed of: 1) Fix a crash in ipset when performing a parallel flush/dump with set:list type, from Jozsef Kadlecsik. 2) Make sure NFACCT_FILTER_* netlink attributes are in plac

[PATCH 04/18] ipvs: drop first packet to redirect conntrack

2016-03-14 Thread Pablo Neira Ayuso
From: Julian Anastasov Jiri Bohac is reporting for a problem where the attempt to reschedule existing connection to another real server needs proper redirect for the conntrack used by the IPVS connection. For example, when IPVS connection is created to NAT-ed real server we alter the reply direct

[PATCH 14/18] openvswitch: Find existing conntrack entry after upcall.

2016-03-14 Thread Pablo Neira Ayuso
From: Jarno Rajahalme Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace u

[PATCH 10/18] netfilter: Remove IP_CT_NEW_REPLY definition.

2016-03-14 Thread Pablo Neira Ayuso
From: Jarno Rajahalme Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/nf_conntrack_common.

[PATCH 17/18] openvswitch: Interface with NAT.

2016-03-14 Thread Pablo Neira Ayuso
From: Jarno Rajahalme Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attrib

[PATCH 15/18] openvswitch: Handle NF_REPEAT in conntrack action.

2016-03-14 Thread Pablo Neira Ayuso
From: Jarno Rajahalme Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer Signed-off-by: Pablo Neira Ayuso --- net/openvswitch/conntrack.c | 10 --

[PATCH 18/18] netfilter: nf_conntrack: consolidate lock/unlock into unlock_wait

2016-03-14 Thread Pablo Neira Ayuso
From: Nicholas Mc Guire The spin_lock()/spin_unlock() is synchronizing on the nf_conntrack_locks_all_lock which is equivalent to spin_unlock_wait() but the later should be more efficient. Signed-off-by: Nicholas Mc Guire Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_conntrack_core.c |

[PATCH 13/18] openvswitch: Update the CT state key only after nf_conntrack_in().

2016-03-14 Thread Pablo Neira Ayuso
From: Jarno Rajahalme Only a successful nf_conntrack_in() call can effect a connection state change, so it suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer Signed-off-by:

Re: [PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-03-14 Thread Rick Jones
On 03/14/2016 02:15 PM, Eric Dumazet wrote: On Thu, 2016-03-03 at 19:06 +0100, Bendik Rønning Opstad wrote: Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing the latency for applications sending time-dependent data. Latency-sensitive applications or services, such as online

[PATCH] netdev: Move octeon/octeon_mgmt driver to cavium directory.

2016-03-14 Thread David Daney
From: David Daney No code changes. Since OCTEON is a Cavium product, move the driver to the vendor directory to unclutter things a bit. Signed-off-by: David Daney --- drivers/net/ethernet/Kconfig | 1 - drivers/net/ethernet/Makefile | 1 -

Re: [PATCHv3 (net.git) 2/2] stmmac: fix MDIO settings

2016-03-14 Thread Andreas Färber
: Giuseppe Cavallaro > Reviewed-by: Andreas Färber > Tested-by: Frank Schäfer > Cc: Gabriel Fernandez > Cc: Dinh Nguyen > Cc: David S. Miller > Cc: Phil Reid > --- > > V2: use is_pseudo_fixed_link > V3: parse device-tree driver parameters to allocate PHY resources co

Re: [PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-03-14 Thread Bill Fink
On Mon, 14 Mar 2016, Yuchung Cheng wrote: > On Thu, Mar 3, 2016 at 10:06 AM, Bendik Rønning Opstad > wrote: > > > > Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing > > the latency for applications sending time-dependent data. ... > > diff --git a/Documentation/networking/ip

Re: [PATCH][net-next] ipv6: replace write lock with read lock in addrconf_permanent_addr

2016-03-14 Thread Li RongQing
On Tue, Mar 15, 2016 at 12:25 AM, David Miller wrote: > > We need it for the modifications made by fixup_permanent_addr(). fixup_permanent_addr should be protected by ifp->lock, not by idev->lock write lock, since ifp is modified, -Roy

[PATCH 1/3] phy: mdio-cavium: Add missing MODULE_* annotations.

2016-03-14 Thread David Daney
From: David Daney When the code was factored out of mdio-octeon.c, the MODULE_DESCRIPTION, MODULE_AUTHOR and MODULE_LICENSE annotations were inadvertently omitted. Restore them so that we don't get kernel taint warnings upon module loading. Signed-off-by: David Daney --- drivers/net/phy/mdio-

[PATCH 0/3] net/phy: Fixes for Cavium Thunder MDIO code.

2016-03-14 Thread David Daney
From: David Daney Previous patch set: commit 5fc7cf179449 ("net: thunderx: Cleanup PHY probing code.") commit 1eefee901fca ("phy: mdio-octeon: Refactor into two files/modules") commit 379d7ac7ca31 ("phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.") Had several problems. We try

[PATCH 3/3] net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.

2016-03-14 Thread David Daney
From: David Daney It is possible, although unlikely, that probing will find the phy_device for the first LMAC of a thunder BGX device, but then need to fail with -EPROBE_DEFER on a subsequent LMAC. In this case, we need to call put_device() on each of the phy_devices that were obtained, but will

[PATCH 2/3] net: cavium: For Kconfig THUNDER_NIC_BGX, select MDIO_THUNDER.

2016-03-14 Thread David Daney
From: David Daney Previously we selected MDIO_OCTEON, which after creating the Thunder specific MDIO bus driver is much less useful. Signed-off-by: David Daney --- drivers/net/ethernet/cavium/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/caviu

Re: [PATCH] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection

2016-03-14 Thread Antonio Quartulli
On Mon, Mar 14, 2016 at 03:25:02PM -0400, David Miller wrote: > From: SF Markus Elfring > Date: Fri, 11 Mar 2016 13:40:56 +0100 > > > From: Markus Elfring > > Date: Fri, 11 Mar 2016 13:10:20 +0100 > > > > The variables "tt_local_entry" and "tt_global_entry" were eventually > > checked again des

Re: [PATCH] netfilter: nf_conntrack: consolidate lock/unlock into unlock_wait

2016-03-14 Thread Pablo Neira Ayuso
On Mon, Mar 14, 2016 at 12:39:02PM +0100, Nicholas Mc Guire wrote: > The spin_lock()/spin_unlock() is synchronizing on the > nf_conntrack_locks_all_lock which is equivalent to > spin_unlock_wait() but the later should be more efficient. Applied, thanks.

linux-next: manual merge of the net-next tree with Linus' tree

2016-03-14 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got conflicts in: arch/arm/boot/dts/armada-xp-db.dts arch/arm/boot/dts/armada-xp-gp.dts arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts between commit: d7d5a43c0d16 ("ARM: mvebu: fix overlap of Crypto SRAM with PCIe memory window")

Re: [PATCH nf-next v10 0/8] openvswitch: NAT support

2016-03-14 Thread Pablo Neira Ayuso
On Thu, Mar 10, 2016 at 10:54:15AM -0800, Jarno Rajahalme wrote: > This series adds NAT support to openvswitch kernel module. A few > changes are needed to the netfilter code to facilitate this (patches > 1-2/8). Patches 3-7 make the openvswitch kernel module ready for the > patch 8 that adds the

Re: [PATCH net] net: diag: add a scheduling point in inet_diag_dump_icsk()

2016-03-14 Thread David Miller
From: Eric Dumazet Date: Mon, 14 Mar 2016 15:40:00 -0700 > From: Eric Dumazet > > On loaded TCP servers, looking at millions of sockets can hold > cpu for many seconds, if the lookup condition is very narrow. > > (eg : ss dst 1.2.3.4 ) > > Better add a cond_resched() to allow other processes

Re: [PATCH] smc91x: avoid self-comparison warning

2016-03-14 Thread David Miller
From: Arnd Bergmann Date: Mon, 14 Mar 2016 23:45:12 +0100 > The smc91x driver defines a macro that compares its argument to > itself, apparently to get a true result while using its argument > to avoid a warning about unused local variables. > > Unfortunately, this triggers a warning with gcc-6,

Re: [PATCH] Driver: Vmxnet3: Fix regression caused by cec0556

2016-03-14 Thread Shrikrishna Khare
On Mon, 14 Mar 2016, David Miller wrote: > From: Shrikrishna Khare > Date: Fri, 11 Mar 2016 13:29:44 -0800 > > > don't pass uninitialized flags to spin_unlock_irqrestore. > > > > Reported-by: Tetsuo Handa > > Signed-off-by: Shrikrishna Khare > > Signed-off-by: Guolin Yang > > Sorry, I not

[ANNOUNCE] iproute2 4.5

2016-03-14 Thread Stephen Hemminger
Update to iproute2 utility to support new features in Linux 4.5. The usual array small documentation changes and bug fixes. Areas of large changes were BPF and more integration of management of bridges. Source: http://www.kernel.org/pub/linux/utils/net/iproute2/iproute2-4.5.0.tar.gz Repository

[PATCH] smc91x: avoid self-comparison warning

2016-03-14 Thread Arnd Bergmann
The smc91x driver defines a macro that compares its argument to itself, apparently to get a true result while using its argument to avoid a warning about unused local variables. Unfortunately, this triggers a warning with gcc-6, as the comparison is obviously useless: drivers/net/ethernet/smsc/sm

Re: [PATCH net]: ipv6: drop frames with attached skb->sk in forwarding

2016-03-14 Thread Eric Dumazet
On Mon, 2016-03-14 at 15:32 -0700, Francesco Ruggeri wrote: > Should 9ef2e965e554 ["ipv6: drop frames with attached skb->sk in forwarding"] > be considered for stable? > It did address a crash in ip6_skb_dst_mtu that I was seeing in 3.18, where > an incoming packet found an inet_timewait_sock in tc

[PATCH net] net: diag: add a scheduling point in inet_diag_dump_icsk()

2016-03-14 Thread Eric Dumazet
From: Eric Dumazet On loaded TCP servers, looking at millions of sockets can hold cpu for many seconds, if the lookup condition is very narrow. (eg : ss dst 1.2.3.4 ) Better add a cond_resched() to allow other processes to access the cpu. Signed-off-by: Eric Dumazet --- net/ipv4/inet_diag.c

Re: [PATCH net]: ipv6: drop frames with attached skb->sk in forwarding

2016-03-14 Thread Francesco Ruggeri
Should 9ef2e965e554 ["ipv6: drop frames with attached skb->sk in forwarding"] be considered for stable? It did address a crash in ip6_skb_dst_mtu that I was seeing in 3.18, where an incoming packet found an inet_timewait_sock in tcp_v6_early_demux but was later ip6_forward'ed (the local address th

Re: [PATCH v6 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-03-14 Thread Yuchung Cheng
On Sun, Mar 13, 2016 at 4:18 PM, Bendik Rønning Opstad wrote: > On 03/10/2016 01:20 AM, Yuchung Cheng wrote: >> I read the paper. I think the underlying idea is neat. but the >> implementation is little heavy-weight that requires changes on fast >> path (tcp_write_xmit) and space in skb control bl

Re: [PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-03-14 Thread Yuchung Cheng
On Thu, Mar 3, 2016 at 10:06 AM, Bendik Rønning Opstad wrote: > > Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing > the latency for applications sending time-dependent data. > > Latency-sensitive applications or services, such as online games, > remote control systems, and V

Re: [PATCH net-next 06/13] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

2016-03-14 Thread Jesper Dangaard Brouer
On Fri, 11 Mar 2016 15:39:47 +0200 Saeed Mahameed wrote: > From: Tariq Toukan > > Introduce the feature of multi-packet WQE (RX Work Queue Element) > referred to as (MPWQE or Striding RQ), in which WQEs are larger > and serve multiple packets each. > > Every WQE consists of many strides of th

Re: [PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-03-14 Thread Eric Dumazet
On Thu, 2016-03-03 at 19:06 +0100, Bendik Rønning Opstad wrote: > Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing > the latency for applications sending time-dependent data. > > Latency-sensitive applications or services, such as online games, > remote control systems, and V

Re: [PATCH 5/5] net: macb: Fix simple typo.

2016-03-14 Thread Michal Simek
On 13.3.2016 20:10, Moritz Fischer wrote: > Signed-off-by: Moritz Fischer > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c > index a0c01e5..681e5bf 100

Re: [PATCH 4/5] net: macb: Use ether_addr_copy over memcpy

2016-03-14 Thread Michal Simek
On 13.3.2016 20:10, Moritz Fischer wrote: > Checkpatch suggests using ether_addr_copy over memcpy > to copy the mac address. > > Signed-off-by: Moritz Fischer > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/etherne

Re: [PATCH 1/5] net: macb: Fix coding style error message

2016-03-14 Thread Michal Simek
On 13.3.2016 20:10, Moritz Fischer wrote: > checkpatch.pl gave the following error: > > ERROR: space required before the open parenthesis '(' > + for(; p < end; p++, offset += 4) > > Signed-off-by: Moritz Fischer > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 file changed, 1 insert

[PATCH] ipv6: Fix the pmtu path for connected UDP socket

2016-03-14 Thread Wei Wang
From: Wei Wang When ICMPV6_PKT_TOOBIG message is received by a connected UDP socket, the new mtu value is not properly updated in the dst_entry associated with the socket. This leads to the issue that the mtu value returned by getsockopt(sockfd, IPPROTO_IPV6, IPV6_MTU, ...) is wrong. The fix is t

Re: [PATCH 2/5] net: macb: Fix coding style warnings

2016-03-14 Thread Michal Simek
On 13.3.2016 20:10, Moritz Fischer wrote: > This commit takes care of the coding style warnings > that are mostly due to a different comment style and > lines over 80 chars, as well as a dangling else. > > Signed-off-by: Moritz Fischer > --- > drivers/net/ethernet/cadence/macb.c | 101 > +++

Re: [PATCH RFC v2 00/32] Make DSA switches linux devices.

2016-03-14 Thread Andrew Lunn
On Mon, Mar 14, 2016 at 12:36:18PM -0700, Florian Fainelli wrote: > On 12/03/16 09:08, Andrew Lunn wrote: > >> [snip] > >> > >>> > >>> The third switch is as you would expect, dsa,member = <0 2>; > >> > >> I like that representation. > >> > > > > ... > > > >> So does that mean you agree we do not

Re: [PATCH 3/5] net: macb: Address checkpatch 'check' suggestions

2016-03-14 Thread Michal Simek
On 13.3.2016 20:10, Moritz Fischer wrote: > This commit deals with a bunch of checkpatch suggestions > that without changing behavior make checkpatch happier. > > Signed-off-by: Moritz Fischer > --- > drivers/net/ethernet/cadence/macb.c | 46 > +++-- > 1 file cha

Re: [PATCH v7 net-next] ravb: Add dma queue interrupt support

2016-03-14 Thread Sergei Shtylyov
Hello. On 03/13/2016 09:11 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (timestamp, error, gPTP) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) This patch im

Re: [PATCH net-next 08/13] net/mlx5e: Add fragmented memory support for RX multi packet WQE

2016-03-14 Thread Eric Dumazet
On Mon, 2016-03-14 at 21:16 +0200, achiad shochat wrote: > I really do not see why the new scheme is more DOSable than the common > scheme of pre-allocating SKB using napi_alloc_skb(). Because sizeof(skb_shared_info) is big enough that if you allocate 128 bytes, you end up using 512 bytes or even

Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code.

2016-03-14 Thread David Daney
On 03/14/2016 12:27 PM, David Miller wrote: From: David Daney Date: Fri, 11 Mar 2016 09:53:08 -0800 Changes from v1: - In 1/3 Add back check for non-OF objects in bgx_init_of_phy(). It is probably not necessary, but better safe than sorry... The firmware on many Cavium Thunder systems

Re: [PATCH net-next 08/13] net/mlx5e: Add fragmented memory support for RX multi packet WQE

2016-03-14 Thread Eric Dumazet
On Mon, 2016-03-14 at 21:16 +0200, achiad shochat wrote: > Eric, am I missing something here or the new scheme was not clear to > you previously? I simply do not want to see drivers using 1) SKB_TRUESIZE() or 2) skb->truesize = some_expression Drivers should not assume they know bette

Re: [PATCH net-next 08/13] net/mlx5e: Add fragmented memory support for RX multi packet WQE

2016-03-14 Thread Eric Dumazet
On Mon, 2016-03-14 at 20:16 +0200, Saeed Mahameed wrote: > we can do special accounting for ooo like issues in the stack (maybe > count page references and sum up page sizes as you suggest), device > drivers shouldn't have special handling/accounting to protect against > such cases. The existing

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread Jiri Pirko
Mon, Mar 14, 2016 at 08:56:40PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 14 Mar 2016 20:04:35 +0100 > >> I believe that using *any* structs to send over netlink is a mistake. >> Netlink is capable to transfer everything using attrs. Easy to compose, >> easy to parse. easy to e

Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code.

2016-03-14 Thread David Miller
From: David Daney Date: Mon, 14 Mar 2016 13:12:53 -0700 > At this point, I think the best path forward is for me to rebase > against net-next and send you a small fixup set to what was merged. > > What do you think? That is in fact the one and only option.

[PATCH net v2] ppp: ensure file->private_data can't be overridden

2016-03-14 Thread Guillaume Nault
Locking ppp_mutex must be done before dereferencing file->private_data, otherwise it could be modified before ppp_unattached_ioctl() takes the lock. This could lead ppp_unattached_ioctl() to override ->private_data, thus leaking reference to the ppp_file previously pointed to. v2: lock all ppp_ioc

Re: [PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-03-14 Thread Laura Abbott
On 03/14/2016 12:24 PM, David Miller wrote: From: Claudio Imbrenda Date: Fri, 11 Mar 2016 13:39:23 +0100 I think I found a problem with the patch submitted by Laura Abbott ( https://lkml.org/lkml/2016/2/4/711 ): we might miss wakeups. Since the condition is not checked between the prepare_to_w

Re: [PATCH net-next 0/3] net: dsa: finer bridging control

2016-03-14 Thread David Miller
From: Vivien Didelot Date: Sun, 13 Mar 2016 16:21:31 -0400 > This patchset renames the bridging routines of the DSA layer, make the > unbridging routine return void, and rework the DSA netdev notifier handler, > similar to what the Mellanox Spectrum driver does. > > Changes RFC -> v1: > - drop

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-14 Thread David Miller
From: Jiri Pirko Date: Mon, 14 Mar 2016 20:04:35 +0100 > I believe that using *any* structs to send over netlink is a mistake. > Netlink is capable to transfer everything using attrs. Easy to compose, > easy to parse. easy to extend. Couple of more bytes in the message? So what? > For newly intro

[PATCH v2] netfilter: fix race condition in ipset save, swap and delete

2016-03-14 Thread Vishwanath Pai
I have updated the patch according to comments by Jozsef. Renamed ref_kernel to ref_netlink, renamed _put/_get functions and updated the description in commit log. Thanks, Vishwanath -- netfilter: fix race condition in ipset save, swap and delete This fix adds a new reference counter (ref_netli

Re: [PATCH 2/2] mISDN: Support DR6 indication in mISDNipac driver

2016-03-14 Thread David Miller
From: "Maciej S. Szmigiero" Date: Sun, 13 Mar 2016 00:19:07 +0100 > According to figure 39 in PEB3086 data sheet, version 1.4 this indication > replaces DR when layer 1 transition source state is F6. > > This fixes mISDN layer 1 getting stuck in F6 state in TE mode on > Dialogic Diva 2.02 card (

Re: [PATCH 1/2] mISDN: Order IPAC register defines

2016-03-14 Thread David Miller
From: "Maciej S. Szmigiero" Date: Sun, 13 Mar 2016 00:18:06 +0100 > It looks like IPAC/ISAC chips register defines weren't in any particular > order. > > Order them by their number to make it easier to spot holes. > > Signed-off-by: Maciej S. Szmigiero Applied.

Re: [PATCH] sh_eth: kill useless initializers

2016-03-14 Thread David Miller
From: Sergei Shtylyov Date: Sun, 13 Mar 2016 01:29:45 +0300 > Some of the local variable intializers in the driver turned out to be > pointless, kill 'em. > > Signed-off-by: Sergei Shtylyov Applied, thanks Sergei.

Re: [PATCH net v2 0/4] Few mvneta fixes

2016-03-14 Thread David Miller
From: Gregory CLEMENT Date: Sat, 12 Mar 2016 18:44:16 +0100 > In this second version I split the last patch in two parts as > requested. > > For the record the initial cover letter was: > "here is a patch set of few fixes. Without the first one, a kernel > configured with debug features ended to

Re: [PATCH -next] bridge: fix potential use-after-free when hook returns QUEUE or STOLEN verdict

2016-03-14 Thread David Miller
From: Florian Westphal Date: Sat, 12 Mar 2016 11:14:42 +0100 > Zefir Kurtisi reported kernel panic with an openwrt specific patch. > However, it turns out that mainline has a similar bug waiting to happen. > > Once NF_HOOK() returns the skb is in undefined state and must not be > used. Moreove

[PATCH V3 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Sowmini Varadhan
For LLC based protocols like lldp, stp etc., the ethernet header is an 802.3 header with a h_proto that is not 0x800, 0x86dd, or even 0x806. In this world, the skb_network_header() points at the DSAP/SSAP/.. and is not likely to be NET_IP_ALIGNed in ixgbe_atr(). With LLC, drivers are not likely

Re: pull request: bluetooth-next 2016-03-12

2016-03-14 Thread David Miller
From: Johan Hedberg Date: Sat, 12 Mar 2016 08:39:34 +0200 > Here's the last bluetooth-next pull request for the 4.6 kernel. > > - New USB ID for AR3012 in btusb > - New BCM2E55 ACPI ID > - Buffer overflow fix for the Add Advertising command > - Support for a new Bluetooth LE limited privacy

Re: [PATCH net-next 0/5] DSA cleanup and fixes

2016-03-14 Thread David Miller
From: Andrew Lunn Date: Sat, 12 Mar 2016 00:01:35 +0100 > The RFC patchset for re-architecturing DSA probing contains a few > standalone patches, either clean up or fixes. This pulls them out for > submission. Series applied, thanks Andrew.

Re: [PATCH RFC v2 00/32] Make DSA switches linux devices.

2016-03-14 Thread Florian Fainelli
On 12/03/16 09:08, Andrew Lunn wrote: >> [snip] >> >>> >>> The third switch is as you would expect, dsa,member = <0 2>; >> >> I like that representation. >> > > ... > >> So does that mean you agree we do not need the DSA platform device >> anymore :)? > > It looks like it can be done witho

Re: [PATCH v2 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Sowmini Varadhan
On (03/14/16 12:20), Alexander Duyck wrote: > I figure it is better to just drop it since we don't need to be trying > to parse ARP packets anyway. Ok, let me send out v3.

Re: [PATCH v2 0/3] of_mdio: use IS_ERR_OR_NULL() and PTR_ERR_OR_ZERO()

2016-03-14 Thread David Miller
From: Sergei Shtylyov Date: Sun, 13 Mar 2016 00:32:13 +0300 >Here's the set of 3 patches against DaveM's 'net-next.git' > repo. They deal with some error checks in the device tree MDIO > code... Series applied, thanks.

Re: [PATCH] Driver: Vmxnet3: Fix regression caused by cec0556

2016-03-14 Thread David Miller
From: Shrikrishna Khare Date: Fri, 11 Mar 2016 13:29:44 -0800 > don't pass uninitialized flags to spin_unlock_irqrestore. > > Reported-by: Tetsuo Handa > Signed-off-by: Shrikrishna Khare > Signed-off-by: Guolin Yang Sorry, I noticed Arnd's version of this fix first and therefore applied his

Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code.

2016-03-14 Thread David Miller
From: David Daney Date: Fri, 11 Mar 2016 09:53:08 -0800 > Changes from v1: > > - In 1/3 Add back check for non-OF objects in bgx_init_of_phy(). It >is probably not necessary, but better safe than sorry... > > The firmware on many Cavium Thunder systems configures the MDIO bus > hardware t

Re: [PATCH] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection

2016-03-14 Thread David Miller
From: SF Markus Elfring Date: Fri, 11 Mar 2016 13:40:56 +0100 > From: Markus Elfring > Date: Fri, 11 Mar 2016 13:10:20 +0100 > > The variables "tt_local_entry" and "tt_global_entry" were eventually > checked again despite of a corresponding null pointer test before. > > * Avoid this double che

Re: [PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-03-14 Thread David Miller
From: Claudio Imbrenda Date: Fri, 11 Mar 2016 13:39:23 +0100 > I think I found a problem with the patch submitted by Laura Abbott > ( https://lkml.org/lkml/2016/2/4/711 ): we might miss wakeups. > Since the condition is not checked between the prepare_to_wait and the > schedule(), if a wakeup hap

Re: [PATCH] net: mvneta: Add missing hotplug notifier transition

2016-03-14 Thread David Miller
From: Anna-Maria Gleixner Date: Fri, 11 Mar 2016 10:10:23 +0100 > The mvneta_percpu_notifier() hotplug callback lacks handling of the > CPU_DOWN_FAILED case. That means, if CPU_DOWN_PREPARE failes, the > driver is not well configured on the CPU. > > Add handling for CPU_DOWN_FAILED[_FROZEN] hotp

Re: pull request (net): ipsec 2016-03-10

2016-03-14 Thread David Miller
Patches 4 and 5 were given some feedback, please fix those issues up and respin this pull request. Thank you!

Re: [PATCH v2 net-next] ixgbe: Avoid unaligned access in ixgbe_atr() for LLC packets

2016-03-14 Thread Alexander Duyck
On Mon, Mar 14, 2016 at 10:59 AM, Sowmini Varadhan wrote: > On (03/14/16 10:55), Alexander Duyck wrote: >> >> One other thing I forgot to mention is that we don't support ARP so >> that check could be dropped. The ATR code only supports IPv4 or IPv6 >> with TCP. > > I did notice that, but I left

Re: [PATCH] SOCK_SEQPACKET socketpair must get SIGPIPE in AF_UNIX if one end is closed

2016-03-14 Thread David Miller
From: Alexander Potapenko Date: Wed, 9 Mar 2016 15:10:23 +0100 > According to IEEE Std 1003.1, 2013, sending data to a SOCK_SEQPACKET > socketpair with MSG_NOSIGNAL flag set must result in a SIGPIPE if the > socket is no longer connected. > > Signed-off-by: Alexander Potapenko Please format y

Re: [PATCH net-next 08/13] net/mlx5e: Add fragmented memory support for RX multi packet WQE

2016-03-14 Thread achiad shochat
On 14 March 2016 at 20:16, Saeed Mahameed wrote: > On Fri, Mar 11, 2016 at 9:58 PM, Eric Dumazet wrote: > >>> I totally agree with this, we should have reported skb->truesize += >>> (consumed strides)*(stride size). >>> but again this is not as critical as you think, in the worst case >>> skb->t

  1   2   3   >