Add macro IN_DEV_DROP_GRATUITOUS_ARP to facilitate getting
drop_gratuitous_arp value.
Signed-off-by: Zhang Shengju
---
include/linux/inetdevice.h | 3 +++
net/ipv4/arp.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/linux/inetdevice.h b/include/linux/i
On 03/07/2016 09:32 AM, Ramesh Shanmugasundaram wrote:
> + /* Ensure channel starts in FD mode */
> + if (!(priv->can.ctrlmode & CAN_CTRLMODE_FD)) {
> + netdev_err(ndev, "enable can fd mode for channel %d\n", ch);
> + goto fail_mode;
> + }
What's the
On 7 March 2016 at 19:28, Dave Taht wrote:
> On Mon, Mar 7, 2016 at 9:14 AM, Avery Pennarun wrote:
>> On Mon, Mar 7, 2016 at 11:54 AM, Dave Taht wrote:
[...]
>>> the underlying code needs to be striving successfully for per-station
>>> airtime fairness for this to work at all, and the driver/car
Hi Dinh,
On 3/8/2016 12:22 AM, Dinh Nguyen wrote:
[snip]
I'm seeing the same issue on the SoCFPGA platform:
libphy: PHY stmmac-0: not found
eth0: Could not attach to PHY
stmmac_open: Cannot attach to PHY (error: -19)
If I just revert:
"stmmac: Fix 'eth0: No PHY found' regression"
On Tue, 2016-03-08 at 11:52 +0800, Lisheng wrote:
> From: Qianqian Xie
>
> The variable head in hns_nic_tx_fini_pro has read a value,
> but the value is not used. The patch will solve it.
>
> Signed-off-by: Qianqian Xie
> ---
> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 +---
> 1 file c
On 8 March 2016 at 00:06, Dave Taht wrote:
> Dear Michal:
>
> Going through this patchset... (while watching it compile)
>
>
> + if (!local->hw.txq_cparams.target)
> + local->hw.txq_cparams.target = MS2TIME(5);
>
> MS2TIME(20) for now and/or add something saner to this than !*b
> -Original Message-
> From: kbuild test robot [mailto:fengguang...@intel.com]
> Sent: Tuesday, March 08, 2016 6:45 AM
> To: Manish Chopra
> Cc: kbuild-...@01.org; netdev ; Yuval Mintz
>
> Subject: [net-next:master 1058/1060] qede_main.c:undefined reference to
> `tcp_gro_complete'
>
> tr
Hi,
On Monday 07 March 2016 08:17:36, Moritz Fischer wrote:
> this series deals with most of the checkpatch warnings
> generated for macb. There are two BUG_ON()'s that I didn't touch, yet,
> that were suggested by checkpatch, that I can address in a follow up
> commit if needed.
I think addressi
On Mon, Mar 07, 2016 at 04:28:26PM -0800, Cong Wang wrote:
> On Mon, Mar 7, 2016 at 4:26 PM, Cong Wang wrote:
> > On Fri, Mar 4, 2016 at 2:59 AM, Michal Kubecek wrote:
> >> static void ipv6_route_seq_setup_walk(struct ipv6_route_iter *iter)
> >> {
> >> +#ifdef CONFIG_NET_NS
> >> + struct
It was observed that calling bpf_get_stackid() from a kprobe inside
slub or from spin_unlock causes similar deadlock as with hashmap,
therefore convert stackmap to use pre-allocated memory.
The call_rcu is no longer feasible mechanism, since delayed freeing
causes bpf_get_stackid() to fail unpredi
Suggested-by: Daniel Borkmann
Signed-off-by: Alexei Starovoitov
---
kernel/bpf/arraymap.c | 2 +-
kernel/bpf/stackmap.c | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c
index bd3bdf2486a7..76d5a794e426 100644
--- a/kernel/bpf/ar
If kprobe is placed on spin_unlock then calling kmalloc/kfree from
bpf programs is not safe, since the following dead lock is possible:
kfree->spin_lock(kmem_cache_node->lock)...spin_unlock->kprobe->
bpf_prog->map_update->kmalloc->spin_lock(of the same kmem_cache_node->lock)
and deadlocks.
The fol
extend test coveraged to include pre-allocated and run-time alloc maps
Signed-off-by: Alexei Starovoitov
---
samples/bpf/test_maps.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/samples/bpf/test_maps.c b/samples/bpf/test_maps.c
index 7bd9edd02d9b..47bf0858f9e4 10
if kprobe is placed within update or delete hash map helpers
that hold bucket spin lock and triggered bpf program is trying to
grab the spinlock for the same bucket on the same cpu, it will
deadlock.
Fix it by extending existing recursion prevention mechanism.
Note, map_lookup and other tracing he
Introduce simple percpu_freelist to keep single list of elements
spread across per-cpu singly linked lists.
/* push element into the list */
void pcpu_freelist_push(struct pcpu_freelist *, struct pcpu_freelist_node *);
/* pop element from the list */
struct pcpu_freelist_node *pcpu_freelist_pop(s
note old loader is compatible with new kernel.
map_flags are optional
Signed-off-by: Alexei Starovoitov
---
samples/bpf/bpf_helpers.h | 1 +
samples/bpf/bpf_load.c | 3 ++-
samples/bpf/fds_example.c | 2 +-
samples/bpf/libbpf.c| 5 +++--
samples/bpf/libbpf.h| 2 +-
map creation is typically the first one to fail when rlimits are
too low, not enough memory, etc
Make this failure scenario more verbose
Signed-off-by: Alexei Starovoitov
---
samples/bpf/bpf_load.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/samples/bpf/bpf_load.c b/s
move ksym search from offwaketime into library to be reused
in other tests
Signed-off-by: Alexei Starovoitov
---
samples/bpf/bpf_load.c | 62 ++
samples/bpf/bpf_load.h | 6
samples/bpf/offwaketime_user.c | 67 +
v1->v2:
. fix few issues spotted by Daniel
. converted stackmap into pre-allocation as well
. added a workaround for lockdep false positive
. added pcpu_freelist_populate to be used by hashmap and stackmap
this path set switches bpf hash map to use pre-allocation by default
and introduces BPF_F_NO
Hi David,
On Mon, 07 Mar 2016 11:08:25 + David Howells wrote:
>
> Stephen Rothwell wrote:
>
> > Today's linux-next merge of the crypto tree got a conflict in:
> >
> > net/rxrpc/rxkad.c
> >
> > between commit:
> >
> > 0d12f8a4027d ("rxrpc: Keep the skb private record of the Rx header
When DYNAMIC_DEBUG enabled, pr_debug() depends on KBUILD_MODNAME which
also depends on the modules name in Makefile.
Refer to the information in "scripts/Makefile.lib":
# $(modname_flags) #defines KBUILD_MODNAME as the name of the module it will
# end up in (or would, if it gets compiled in)
#
On Fri, Mar 4, 2016 at 2:12 PM, Mahesh Bandewar wrote:
>
> Unfortunately we don't have a way to switch to ns after L3 processing.
I am totally aware of this, this is exactly why I said this might not be easy.
The question is how hard it is to implement one? My gut feeling is we only
need to chan
Hi,
This series fixes some issues and some changes in the queue and interrupt
configuration for cxgb4vf driver. We need to enable interrupts before we
register our network device, so that we don't loose link up interrupts.
Allocate rx queues based on interrupt type. Set number of tx/rx queues in
p
The Queue Set Configuration code was always reserving room for a
Forwarded interrupt Queue even in the cases where we weren't using it.
Figure out how many Ports and Queue Sets we can support. This depends on
knowing our Virtual Function Resources and may be called a second time
if we fall back fro
Signed-off-by: Hariprasad Shenai
---
.../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c|8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
index 5a3b883..1cc8a7a
Signed-off-by: Hariprasad Shenai
---
.../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c|5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
index 17a3153..5a3b883 10
This avoids a race condition where a system that has network devices set up
to be automatically configured and we get the first Port Link Status
message from the firmware on the Asynchronous Firmware Event Queue before
we've enabled interrupts. If that happens, we end up losing the interrupt
and ne
> Hmm, if it was 4.1.X like in original reporter case, I might have thought
> something like commit 0a1f59620068 ("ipv6: Initialize rt6_info properly
> in ip6_blackhole_route()") ... any chance on reproducing this on a latest
> kernel?
>
Unfortunately, I haven't encountered a similar crash on newe
From: Marcelo Ricardo Leitner
Date: Mon, 7 Mar 2016 20:27:11 -0300
> Hi,
>
> Em 07-03-2016 20:17, kbuild test robot escreveu:
>> Hi Marcelo,
>>
>> [auto build test WARNING on net/master]
>>
>> url:
>> https://github.com/0day-ci/linux/commits/Marcelo-Ricardo-Leitner/sctp-fix-copying-more-bytes-th
From: David Howells
Date: Mon, 07 Mar 2016 22:45:14 +
> David Miller wrote:
>
>> I know you put a lot of time and effort into this, but I want to strongly
>> recommend against a garbage collected hash table for anything whatsoever.
>>
>> Especially if the given objects are in some way crea
From: Qianqian Xie
There is some inappropriate application of values in hns driver,
such as cycle index, returned value, format string, useless citation.
This patch set will solve it.
Qianqian Xie (4):
net: hns: fix a bug for cycle index
net: hns: bug fix for format string
net: hns: bug f
From: Qianqian Xie
The cycle index should be varied while the variable j is a fixed value.
The patch will fix this bug.
Signed-off-by: Qianqian Xie
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/ne
From: Qianqian Xie
There is not a format string in function snprinf().
This patch will fix it.
Signed-off-by: Qianqian Xie
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_gm
From: Qianqian Xie
The variable head in hns_nic_tx_fini_pro has read a value,
but the value is not used. The patch will solve it.
Signed-off-by: Qianqian Xie
---
drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/eth
From: Qianqian Xie
The return values in the first two functions mdiobus_write()
are ignored. The patch will fix it.
Signed-off-by: Qianqian Xie
---
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisi
From: Qianqian Xie
As the user manual describs, XGE_DFX_CTRL_CFG.xge_dfx_ctrl_cfg should be
configed as zero if we want xge statistic reg to be read only. But the
older hisilicon arm64 process gets the other meanings. So it seems that
we need to identify the process and then config it rightly.
S
From: David Decotigny
This is required for recent version of ethtool.h .
This covers kernel.h up to:
commit b5d3755a22e0cc4c369c0985aef0c52c2477c1e7
Author: Nicolas Dichtel
Date: Fri Mar 4 11:52:16 2016 +0100
uapi: define DIV_ROUND_UP for userland
Signed-off-by: David Decotign
From: David Decotigny
The 'regs' pointer is owned by do_gregs(), but updated internally inside
dump_regs() without propagating it back to do_gregs(): later free(regs)
in do_gregs() reclaims the wrong area. This commit moves the realloc()
inside do_gregs().
Signed-off-by: David Decotigny
---
e
From: Maciej Żenczykowski
Addresses the following warnings:
marvell.c:426:2: error: dereferencing type-punned pointer will break
strict-aliasing rules [-Werror=strict-aliasing]
marvell.c:427:2: error: dereferencing type-punned pointer will break
strict-aliasing rules [-Werror=strict-aliasin
From: Maciej Żenczykowski
This fixes:
test-common.c: In function 'test_realloc':
test-common.c:109:8: error: 'block' may be used uninitialized in this
function [-Werror=maybe-uninitialized]
block = realloc(block, sizeof(*block) + size);
^
Signed-off-by: Maciej Żenczykowski
S
From: David Decotigny
This cover changes up to:
commit 14e2037902d65213842b4e40305ff54a64abbcb6
Author: Nicolas Dichtel
Date: Fri Mar 4 11:52:19 2016 +0100
ethtool.h: define INT_MAX for userland
Signed-off-by: David Decotigny
---
ethtool-copy.h | 478 +
From: David Decotigny
More info with kernel SHA1: 8d3f2806f8fbd9b22 "Merge branch
'ethtool-ksettings'".
Signed-off-by: David Decotigny
---
ethtool.c | 682 +++--
internal.h | 67 ++
test-cmdline.c | 12 +
3 files changed, 602
From: Maciej Żenczykowski
This fixes:
test-features.c:21:1: error: missing braces around initializer
[-Werror=missing-braces]
cmd_gssetinfo = { { ETHTOOL_GSSET_INFO, 0, 1ULL << ETH_SS_FEATURES }, 34 };
^
Signed-off-by: Maciej Żenczykowski
Signed-off-by: David Decotigny
---
test-feat
From: David Decotigny
Tested:
On qemu e1000:
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 9
too much data from stdin
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length 11
not enough data from stdin
$ dd if=/dev/zero bs=2 count=5 | /mnt/ethtool -E eth0 length
From: David Decotigny
Signed-off-by: David Decotigny
---
ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 761252f..f9336e3 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -4615,6 +4615,9 @@ opt_found:
/* Open control socket. */
From: David Decotigny
This addresses:
ethtool.c:1116:8: warning: ignoring return value of ‘fread’, declared with
attribute warn_unused_result [-Wunused-result]
Signed-off-by: David Decotigny
---
ethtool.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ethtool.c b/e
From: David Decotigny
This adds support for the new ETHTOOL_xLINKSETTINGS ioctls. This also
fixes a few compilation warnings as well as a heap corruption bug.
History:
v4
review Ben Hutchings:
using AF_UNIX instead of INET6 in the absence of v4 sockets
use stdbool.h
do_se
From: Maciej Żenczykowski
On ppc64, this fixes:
In file included from ethtool-copy.h:22:0,
from internal.h:32,
from ethtool.c:29:
.../include/linux/types.h:32:25: error: conflicting types for '__be64'
typedef __u64 __bitwise __be64;
Now when we change the attributes of bridge or br_port by netlink,
a relevant netlink notification will be sent, but if we change them
by ioctl or sysfs, no notification will be sent.
we should ensure that whenever those attributes change internally or from
sysfs/ioctl, that a netlink notification
On Mon, Mar 7, 2016 at 7:21 AM, Eric Dumazet wrote:
> What is the problem of being not able to allocate memory at this point ?
>
Now I think about it again, this patch cannot work, because of:
__sctp_connect()
sctp_assoc_set_id(asoc, GFP_KERNEL)
thanks, Eric
> If really it bothers you (alth
'ip tunnel add' uses the wrong interface name in its error output.
For example, if the requested interface already exists:
--
[jwm@boost:pts/8 ~> sudo ip tunnel add sit1 mode sit remote 10.10.10.11 local
10.10.10.10
add tunnel "sit0" failed: No buffer space available
--
ip/tunnel.c:tnl_add_ioctl
v2:
Rework based on recent fix by Eric:
commit a9d99ce28ed3 ("tcp: fix tcpi_segs_in after connection establishment")
v1:
Per RFC4898, they count segments sent/received
containing a positive length data segment (that includes
retransmission segments carrying data). Unlike
tcpi_segs_out/in, tcpi_da
On Mon, Mar 7, 2016 at 4:07 PM, Tom Herbert wrote:
>
> As I said previously, if alignment really is a factor then we can
> check up front if a buffer crosses a page boundary and call the slow
> path function (original code). I'm seeing a 1 nsec hit to add this
> check.
It shouldn't be a factor, a
On (03/07/16 14:11), Tom Herbert wrote:
>
> Message assembly is performed on the TCP socket. This is logically
> equivalent of an application that performs a peek on the socket to find
> out how much memory is needed for a receive buffer. The receive socket
> buffer also provides the maximum messa
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: d66ab51442211158b677c2f12310c314d9587f74
commit: 55482edc25f0606851de42e73618f813f310d009 [1058/1060] qede: Add
slowpath/fastpath support and enable hardware GRO
config: x86_64-randconfig-s0-03080757 (attach
On Mon, Mar 7, 2016 at 4:49 PM, Alexander Duyck
wrote:
> On Mon, Mar 7, 2016 at 4:07 PM, Tom Herbert wrote:
>> On Mon, Mar 7, 2016 at 3:52 PM, Alexander Duyck
>> wrote:
>>> On Mon, Mar 7, 2016 at 9:33 AM, Tom Herbert wrote:
On Mon, Mar 7, 2016 at 5:56 AM, David Laight
wrote:
> F
On Mon, Mar 7, 2016 at 4:07 PM, Tom Herbert wrote:
> On Mon, Mar 7, 2016 at 3:52 PM, Alexander Duyck
> wrote:
>> On Mon, Mar 7, 2016 at 9:33 AM, Tom Herbert wrote:
>>> On Mon, Mar 7, 2016 at 5:56 AM, David Laight
>>> wrote:
From: Alexander Duyck
...
> Actually probably the easie
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
net/tipc/subscr.c
between commit:
4de13d7ed6ff ("tipc: fix nullptr crash during subscription cancel")
from the net tree and commit:
7c13c6224123 ("tipc: introduce tipc_subscrb_subscribe() routine")
(and following o
On Mon, Mar 7, 2016 at 4:26 PM, Cong Wang wrote:
> On Fri, Mar 4, 2016 at 2:59 AM, Michal Kubecek wrote:
>> static void ipv6_route_seq_setup_walk(struct ipv6_route_iter *iter)
>> {
>> +#ifdef CONFIG_NET_NS
>> + struct net *net = iter->p.net;
>> +#else
>> + struct net *net = &init_ne
On Fri, Mar 4, 2016 at 2:59 AM, Michal Kubecek wrote:
> static void ipv6_route_seq_setup_walk(struct ipv6_route_iter *iter)
> {
> +#ifdef CONFIG_NET_NS
> + struct net *net = iter->p.net;
> +#else
> + struct net *net = &init_net;
> +#endif
> +
You should pass the struct net pointer t
Use the more common logging mechanisms.
Convert to wiphy_info as these wl1251_notice uses were actually
emitted at KERN_INFO.
Signed-off-by: Joe Perches
---
drivers/net/wireless/ti/wl1251/main.c | 4 ++--
drivers/net/wireless/ti/wl1251/sdio.c | 2 +-
drivers/net/wireless/ti/wl1251/wl1251.h
Use the more common logging mechanisms.
Miscellanea:
o Coalesce formats
o Realign arguments
o Reflow to fit 80 columns
o Add #define pr_fmt when pr_ is used
Signed-off-by: Joe Perches
---
drivers/net/wireless/ti/wl1251/acx.c| 6 ++---
drivers/net/wireless/ti/wl1251/boot.c | 18 +++--
These logging messages are always emitted at KERN_DEBUG.
Add a DEBUG_ALWAYS enum to the debug type enum and convert the
macro and uses from wl1251_info( to wl1251_debug(DEBUG_ALWAYS,
Miscellanea:
o Remove the now unused wl1251_info macro
Signed-off-by: Joe Perches
---
drivers/net/wireless/ti/
Use the more common logging mechanism.
Miscellanea:
o Coalesce formats
o Realign arguments
o Reflow to fit 80 columns
Signed-off-by: Joe Perches
---
drivers/net/wireless/ti/wl1251/acx.c| 91 -
drivers/net/wireless/ti/wl1251/cmd.c| 10 ++--
drivers/net/wi
Use the more common logging mechanism passing wl->dev where
appropriate. Remove the macros. Add argument struct wl1271 *wl to
some functions to make these logging mechanisms work.
Miscellanea:
o Coalesce formats, add required trailing \n to formats
Some formats already had previously incorrec
Using the normal kernel logging mechanisms makes this code
a bit more like other wireless drivers.
Joe Perches (5):
ti: Convert wl1271_ logging macros to dev_ or pr_
ti: wl1251: Convert wl1251_error to wiphy_err/pr_err
ti: wl1251: Convert wl1251_warning to wiphy_warn
ti: wl1251: Convert wl
On Mon, Mar 7, 2016 at 3:52 PM, Alexander Duyck
wrote:
> On Mon, Mar 7, 2016 at 9:33 AM, Tom Herbert wrote:
>> On Mon, Mar 7, 2016 at 5:56 AM, David Laight wrote:
>>> From: Alexander Duyck
>>> ...
Actually probably the easiest way to go on x86 is to just replace the
use of len with (l
US$23,200,000.00 Million Transaction, for further detail's contact me via my
personal e-
mail: ms_teresa_...@outlook.com
Cc'ing netdev
On Sun, Mar 6, 2016 at 7:10 AM, Andreas Messer wrote:
> Hi there,
>
> i have updated two of my machines in the last weeks to linux 4.4.1 and linux
> 4.4.3. It seems that since then i get unexpected TCPv6 connection resets when
> connecting to these machines remotely. The issue occur
On Mon, Mar 7, 2016 at 9:33 AM, Tom Herbert wrote:
> On Mon, Mar 7, 2016 at 5:56 AM, David Laight wrote:
>> From: Alexander Duyck
>> ...
>>> Actually probably the easiest way to go on x86 is to just replace the
>>> use of len with (len >> 6) and use decl or incl instead of addl or
>>> subl, and
On Mon, Mar 7, 2016 at 3:06 PM, Alex Duyck wrote:
> On Mon, Mar 7, 2016 at 11:09 AM, David Miller wrote:
>> From: Or Gerlitz
>> Date: Mon, 7 Mar 2016 20:05:20 +0200
>>
>>> On Mon, Mar 7, 2016 at 7:22 PM, Alexander Duyck wrote:
This change enforces the IP ID verification on outer headers.
On 03/07/2016 11:15 PM, subas...@codeaurora.org wrote:
On , Daniel Borkmann wrote:
Hi Andrew,
thanks for the report!
( Making the trace a bit more readable ... )
[41358.475254]BUG:unable to handle kernel NULL pointer dereference at (null)
[41358.475333]IP:[]rtnetlink_put_metrics+0x50/0x180
[.
Hi,
Em 07-03-2016 20:17, kbuild test robot escreveu:
Hi Marcelo,
[auto build test WARNING on net/master]
url:
https://github.com/0day-ci/linux/commits/Marcelo-Ricardo-Leitner/sctp-fix-copying-more-bytes-than-expected-in-sctp_add_bind_addr/20160308-052009
coccinelle warnings: (new ones pr
There is no need to change the 802.1Q port mode for the same value.
Thus avoid such message:
[ 401.954836] dsa dsa@0 lan0: 802.1Q Mode: Disabled (was Disabled)
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6xxx.c | 21 +
1 file changed, 13 insertions(+), 8 dele
Apply a few non-functional changes on the port state setter:
* add a dynamic debug message with state names to track changes
* explicit states checking instead of assuming their numeric values
* lock mutex only once when changing several port states
* use bitmap macros to declare and acces
The port register 0x07 contains more options than just the default VID,
even though they are not used yet. So prefer a read then write operation
over a direct write.
This also allows to keep track of the change through dynamic debug.
Signed-off-by: Vivien Didelot
---
drivers/net/dsa/mv88e6xxx.c
On Mon, Mar 7, 2016 at 11:15 AM, Andreas Färber wrote:
> Am 07.03.2016 um 16:52 schrieb Giuseppe CAVALLARO:
>> On 3/7/2016 4:46 PM, Andreas Färber wrote:
>>> Am 07.03.2016 um 16:09 schrieb Giuseppe CAVALLARO:
On 3/7/2016 3:27 PM, Andreas Färber wrote:
> Indeed, reverting Gabriel's commit
Hi Marcelo,
[auto build test WARNING on net/master]
url:
https://github.com/0day-ci/linux/commits/Marcelo-Ricardo-Leitner/sctp-fix-copying-more-bytes-than-expected-in-sctp_add_bind_addr/20160308-052009
coccinelle warnings: (new ones prefixed by >>)
>> net/sctp/bind_addr.c:458:42-48: ERROR:
net/sctp/bind_addr.c:458:42-48: ERROR: application of sizeof to pointer
sizeof when applied to a pointer typed expression gives the size of
the pointer
Generated by: scripts/coccinelle/misc/noderef.cocci
CC: Marcelo Ricardo Leitner
Signed-off-by: Fengguang Wu
---
bind_addr.c |2 +-
1 f
On 03/03/2016 05:32 PM, Murali Karicheri wrote:
> On 02/29/2016 05:29 PM, Andrew Lunn wrote:
>> On Mon, Feb 29, 2016 at 04:43:16PM -0500, Murali Karicheri wrote:
>>
>> Hi Murali
>>
>> Please can you get your email client to wrap lines at ~ 75 characters.
> Hi Andrew,
>
> Thanks for responding. I h
Dear Michal:
Going through this patchset... (while watching it compile)
+ if (!local->hw.txq_cparams.target)
+ local->hw.txq_cparams.target = MS2TIME(5);
MS2TIME(20) for now and/or add something saner to this than !*backlog
target will not be a constant in the long run.
+
On Mon, Mar 7, 2016 at 11:09 AM, David Miller wrote:
> From: Or Gerlitz
> Date: Mon, 7 Mar 2016 20:05:20 +0200
>
>> On Mon, Mar 7, 2016 at 7:22 PM, Alexander Duyck wrote:
>>> This change enforces the IP ID verification on outer headers. As a result
>>> if the DF flag is not set on the outer hea
David Miller wrote:
> I know you put a lot of time and effort into this, but I want to strongly
> recommend against a garbage collected hash table for anything whatsoever.
>
> Especially if the given objects are in some way created/destroyed/etc. by
> operations triggerable remotely.
>
> This c
Iff dma_map_single() fails, 'rxdesc' should point to the last filled RX
descriptor, so that it can be marked as the last one, however the driver
would have already advanced it by that time. In order to fix that, only
fill an RX descriptor once all the data for it is ready.
Signed-off-by: Se
In a low memory situation, if netdev_alloc_skb() fails on a first RX ring
loop iteration in sh_eth_ring_format(), 'rxdesc' is still NULL. Avoid
kernel oops by adding the 'rxdesc' check after the loop.
Reported-by: Wolfram Sang
Signed-off-by: Sergei Shtylyov
---
drivers/net/ethernet/renesas/s
Hello.
Here's a set of 2 patches against DaveM's 'net.git' repo fixing two bugs
in sh_eth_.ring_format()...
[1/2] sh_eth: fix NULL pointer dereference in sh_eth_ring_format()
[2/2] sh_eth: advance 'rxdesc' later in sh_eth_ring_format()
MBR, Sergei
On , Daniel Borkmann wrote:
Hi Andrew,
thanks for the report!
( Making the trace a bit more readable ... )
[41358.475254]BUG:unable to handle kernel NULL pointer dereference at
(null)
[41358.475333]IP:[]rtnetlink_put_metrics+0x50/0x180
[...]
CallTrace:
[41358.476522][]?__nla_reserve+0x23/0xe
Message assembly is performed on the TCP socket. This is logically
equivalent of an application that performs a peek on the socket to find
out how much memory is needed for a receive buffer. The receive socket
buffer also provides the maximum message size which is checked.
The receive algorithm is
Implement kcm_splice_read. This is supported only for seqpacket.
Add kcm_seqpacket_ops and set splice read to kcm_splice_read.
Signed-off-by: Tom Herbert
---
net/kcm/kcmsock.c | 98 +--
1 file changed, 96 insertions(+), 2 deletions(-)
diff --g
Implement kcm_sendpage. Set in sendpage to kcm_sendpage in both
dgram and seqpacket ops.
Signed-off-by: Tom Herbert
---
net/kcm/kcmsock.c | 147 +-
1 file changed, 145 insertions(+), 2 deletions(-)
diff --git a/net/kcm/kcmsock.c b/net/kcm/kcms
Add walking of fragments in __skb_splice_bits.
Signed-off-by: Tom Herbert
---
net/core/skbuff.c | 39 ---
1 file changed, 16 insertions(+), 23 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 7af7ec6..0df9f6a 100644
--- a/net/core/skbuff.
This patch adds receive timeout for message assembly on the attached TCP
sockets. The timeout is set when a new messages is started and the whole
message has not been received by TCP (not in the receive queue). If the
completely message is subsequently received the timer is cancelled, if the
timer
This patch adds various counters for KCM. These include counters for
messages and bytes received or sent, as well as counters for number of
attached/unattached TCP sockets and other error or edge events.
The statistics are exposed via a proc interface. /proc/net/kcm provides
statistics per KCM soc
Add kcm.txt to desribe KCM and interfaces.
Signed-off-by: Tom Herbert
---
Documentation/networking/kcm.txt | 285 +++
1 file changed, 285 insertions(+)
create mode 100644 Documentation/networking/kcm.txt
diff --git a/Documentation/networking/kcm.txt b/Docume
This module implements the Kernel Connection Multiplexor.
Kernel Connection Multiplexor (KCM) is a facility that provides a
message based interface over TCP for generic application protocols.
With KCM an application can efficiently send and receive application
protocol messages over TCP using data
Create a common kernel function to get the number of bytes available
on a TCP socket. This is based on code in INQ getsockopt and we now call
the function for that getsockopt.
Signed-off-by: Tom Herbert
---
include/net/tcp.h | 24
net/ipv4/tcp.c| 15 +--
This patch allows setting MSG_EOR in each individual msghdr passed
in sendmmsg. This allows a sendmmsg to send multiple messages when
using SOCK_SEQPACKET.
Signed-off-by: Tom Herbert
---
net/socket.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/net/socket.c b/ne
Add a new msg flag called MSG_BATCH. This flag is used in sendmsg to
indicate that more messages will follow (i.e. a batch of messages is
being sent). This is similar to MSG_MORE except that the following
messages are not merged into one packet, they are sent individually.
sendmmsg is updated so th
This is a convenience function that returns the next entry in an RCU
list or NULL if at the end of the list.
Signed-off-by: Tom Herbert
---
include/linux/rculist.h | 21 +
1 file changed, 21 insertions(+)
diff --git a/include/linux/rculist.h b/include/linux/rculist.h
index 1
Export it for cases where we want to create sockets by hand.
Signed-off-by: Tom Herbert
---
include/linux/net.h | 1 +
net/socket.c| 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/net.h b/include/linux/net.h
index 0b4ac7d..49175e4 100644
--- a/include/
1 - 100 of 285 matches
Mail list logo
