Re: [PATCH v2 net] bonding: don't use stale speed and duplex information

2016-02-28 Thread zhuyj
On 02/29/2016 01:39 PM, Jay Vosburgh wrote: zhuyj wrote: On 02/25/2016 09:33 PM, Jay Vosburgh wrote: zhuyj wrote: [...] I delved into the source code and Emil's tests. I think that the problem that this patch expects to fix occurs very unusually. Do you agree with me? If so, maybe the fol

linux-next: manual merge of the target-merge tree with the net-next tree

2016-02-28 Thread Stephen Rothwell
Hi Nicholas, Today's linux-next merge of the target-merge tree got a conflict in: drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h between commit: ba9cee6aa67d ("cxgb4/iw_cxgb4: TOS support") from the net-next tree and commit: c973e2a3ff1b ("cxgb4: add definitions for iSCSI target ULD") f

Re: [PATCH] asm-generic: remove old nonatomic-io wrapper files

2016-02-28 Thread Vinod Koul
On Fri, Feb 26, 2016 at 03:29:05PM +0100, Arnd Bergmann wrote: > The two header files got moved to include/linux, and most > users were already converted, this changes the remaining drivers > and removes the files. > > Signed-off-by: Arnd Bergmann > --- > drivers/dma/idma64.h

Re: [PATCH v2 net] bonding: don't use stale speed and duplex information

2016-02-28 Thread Jay Vosburgh
zhuyj wrote: >On 02/25/2016 09:33 PM, Jay Vosburgh wrote: >> zhuyj wrote: >> [...] >>> I delved into the source code and Emil's tests. I think that the problem >>> that this patch expects to fix occurs very unusually. >>> >>> Do you agree with me? >>> >>> If so, maybe the following patch can red

Re: [PATCH V3 3/3] vhost_net: basic polling support

2016-02-28 Thread Jason Wang
On 02/29/2016 05:56 AM, Christian Borntraeger wrote: > On 02/26/2016 09:42 AM, Jason Wang wrote: >> > This patch tries to poll for new added tx buffer or socket receive >> > queue for a while at the end of tx/rx processing. The maximum time >> > spent on polling were specified through a new kind

Re: [PATCH V3 3/3] vhost_net: basic polling support

2016-02-28 Thread Jason Wang
On 02/28/2016 10:09 PM, Michael S. Tsirkin wrote: > On Fri, Feb 26, 2016 at 04:42:44PM +0800, Jason Wang wrote: >> > This patch tries to poll for new added tx buffer or socket receive >> > queue for a while at the end of tx/rx processing. The maximum time >> > spent on polling were specified thro

[PATCH net-next RFC 1/1] net namespace: dynamically configure new net namespace inherit net config

2016-02-28 Thread yanjun.zhu
From: Zhu Yanjun Sometimes the system engineer and application expect a new net namespace to inherit config from the base net config. Sometimes the current net config is expected by the system engineer and application. So it is necessary that the system engineer and application can choose a new n

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-28 Thread Mike Galbraith
On Sun, 2016-02-28 at 18:01 +0100, Francois Romieu wrote: > Mike Galbraith : > [...] > > Hrm, relatively new + tasklet woes rings a bell. Ah, that.. > > > > > > What's worse is that at the point where this code was written it was > > already well known that tasklets are a steaming pile of crap

Re: [PATCH] 3c59x: Ensure to apply the expires time

2016-02-28 Thread David Miller
From: Stafford Horne Date: Sun, 28 Feb 2016 16:49:29 +0900 > In commit 5b6490def9168af6a ("3c59x: Use setup_timer()") Amitoj > removed add_timer which sets up the epires timer. In this patch > the behavior is restore but it uses mod_timer which is a bit more > compact. > > Signed-off-by: Staffo

Re: [PATCH net-next V1 09/10] net/mlx5: Fix global UAR mapping

2016-02-28 Thread David Miller
From: Saeed Mahameed Date: Sun, 28 Feb 2016 17:09:10 +0200 > We use ARCH_HAS_IOREMAP_WC to know if the current arch supports WC > (Write combining) IO memory mapping, if it is not supported > "uar->bf_map" will be NULL, thus we will use NC (Non Cached) mapping > "uar->map". This description suck

Re: [PATCH v2 2/3] net: ipv4: tcp_probe: Replace timespec with timespec64

2016-02-28 Thread YOSHIFUJI Hideaki
Deepa Dinamani wrote: > TCP probe log timestamps use struct timespec which is > not y2038 safe. Even though timespec might be good enough here > as it is used to represent delta time, the plan is to get rid > of all uses of timespec in the kernel. > Replace with struct timespec64 which is y2038 s

[PATCH v19 04/10] bpf: Mark __bpf_prog_run() stack frame as non-standard

2016-02-28 Thread Josh Poimboeuf
objtool reports the following false positive warnings: kernel/bpf/core.o: warning: objtool: __bpf_prog_run()+0x5c: sibling call from callable instruction with changed frame pointer kernel/bpf/core.o: warning: objtool: __bpf_prog_run()+0x60: function has unreachable instruction kernel/bpf/c

Re: [PATCH v2 1/3] net: ipv4: Convert IP network timestamps to be y2038 safe

2016-02-28 Thread YOSHIFUJI Hideaki
Deepa Dinamani wrote: > ICMP timestamp messages and IP source route options require > timestamps to be in milliseconds modulo 24 hours from > midnight UT format. > > Add inet_current_timestamp() function to support this. The function > returns the required timestamp in network byte order. > > T

Re: [PATCH net] be2net: don't {en,dis}able filters on BE3 when transparent tagging is enabled

2016-02-28 Thread Sathya Perla
On Fri, Feb 26, 2016 at 6:43 PM, Ivan Vecera wrote: > Should the MULTICAST bit be masked in any be_cmd_rx_filter() call on BE3's > VFs if the trans. tagging is enabled? Not on any be_cmd_rx_filter() call, but on the first call in be_open()->be_if_enable_filters() where the basic filtering flags a

Re: [PATCH RFC v2 18/32] dsa: mv88e6xxx: Prepare for turning this into a library module

2016-02-28 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > Export all the functions so that we can later turn the module into a > library module. As I mentioned in the first RFC [1], wouldn't that be preferable to avoid adding modules and factorize everything into a single one? The common code would have a single probe

linux-next: manual merge of the net-next tree with the wireless-drivers tree

2016-02-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/wireless/intel/iwlwifi/mvm/fw.c between commit: 905e36ae172c ("iwlwifi: mvm: Fix paging memory leak") from the wireless-drivers tree and commit: 43413a975d06 ("iwlwifi: mvm: support rss queues configura

Re: [PATCH v4 net-next] net: Implement fast csum_partial for x86_64

2016-02-28 Thread Maciej W. Rozycki
On Sun, 28 Feb 2016, Alexander Duyck wrote: > I actually found the root cause. The problem is in add32_with_carry3. > > > +static inline unsigned int add32_with_carry3(unsigned int a, unsigned int > > b, > > +unsigned int c) > > +{ > > + asm("ad

Re: [PATCH v4 net-next] net: Implement fast csum_partial for x86_64

2016-02-28 Thread Alexander Duyck
On Sun, Feb 28, 2016 at 11:15 AM, Tom Herbert wrote: > On Sun, Feb 28, 2016 at 10:56 AM, Alexander Duyck > wrote: >> On Sat, Feb 27, 2016 at 12:30 AM, Alexander Duyck >> wrote: +{ + asm("lea 40f(, %[slen], 4), %%r11\n\t" + "clc\n\t" + "jmpq *%%r11\n\

[PATCH RFC 1/2] rhashtable: accept GFP flags in rhashtable_walk_init

2016-02-28 Thread Bob Copeland
In certain cases, the 802.11 mesh pathtable code wants to iterate over all of the entries in the forwarding table from the receive path, which is inside an RCU read-side critical section. Enable walks inside atomic sections by allowing GFP_ATOMIC allocations for the walker state. Change all exist

[PATCH RFC 2/2] mac80211: mesh: convert path table to rhashtable

2016-02-28 Thread Bob Copeland
In the time since the mesh path table was implemented as an RCU-traversable, dynamically growing hash table, a generic RCU hashtable implementation was added to the kernel. Switch the mesh path table over to rhashtable to remove some code and also gain some features like automatic shrinking. Cc:

Re: [net-next][PATCH v2 01/13] RDS: Drop stale iWARP RDMA transport

2016-02-28 Thread santosh.shilim...@oracle.com
On 2/28/16 11:51 AM, Or Gerlitz wrote: On Sun, Feb 28, 2016 at 4:19 AM, Santosh Shilimkar wrote: RDS iWarp support code has become stale and non testable. As indicated earlier, am dropping the support for it. If new iWarp user(s) shows up in future, we can adapat the RDS IB transprt for the sp

Letter of Intent

2016-02-28 Thread James Bayor
I am James Bayor, I work with The United Bank for Africa. I emailed you earlier without any response. I have a sensitive and private offer from the top executive to seek your partnership in re-profiling some offshore investment funds. Please contact me on my private email: james.bay...@gmail.com

Re: [PATCH V3 3/3] vhost_net: basic polling support

2016-02-28 Thread Christian Borntraeger
On 02/26/2016 09:42 AM, Jason Wang wrote: > This patch tries to poll for new added tx buffer or socket receive > queue for a while at the end of tx/rx processing. The maximum time > spent on polling were specified through a new kind of vring ioctl. > > Signed-off-by: Jason Wang > --- > drivers/v

Re: [PATCH v4 net-next] net: Implement fast csum_partial for x86_64

2016-02-28 Thread George Spelvin
I was just noticing that these two: > +static inline unsigned long add64_with_carry(unsigned long a, unsigned long > b) > +{ > + asm("addq %2,%0\n\t" > + "adcq $0,%0" > + : "=r" (a) > + : "0" (a), "rm" (b)); > + return a; > +} > + > +static inline unsigne

Re: [PATCH v4 net-next] net: Implement fast csum_partial for x86_64

2016-02-28 Thread Eric Dumazet
On ven., 2016-02-26 at 12:03 -0800, Tom Herbert wrote: > + > + /* > + * Length is greater than 64. Sum to eight byte alignment before > + * proceeding with main loop. > + */ > + aligned = !!((unsigned long)buff & 0x1); > + if (aligned) { > + unsigned int align

Re: [net-next][PATCH v2 01/13] RDS: Drop stale iWARP RDMA transport

2016-02-28 Thread Or Gerlitz
On Sun, Feb 28, 2016 at 4:19 AM, Santosh Shilimkar wrote: > RDS iWarp support code has become stale and non testable. As > indicated earlier, am dropping the support for it. > > If new iWarp user(s) shows up in future, we can adapat the RDS IB > transprt for the special RDMA READ sink case. iWarp

[PATCH] of_mdio: fix kernel-doc for of_phy_connect()

2016-02-28 Thread Sergei Shtylyov
The 'flags' parameter of the of_phy_connect() function wasn't described in the kernel-doc comment... Signed-off-by: Sergei Shtylyov --- The patch is against DaveM's 'net.git' repo. drivers/of/of_mdio.c |1 + 1 file changed, 1 insertion(+) Index: net/drivers/of/of_mdio.c =

Re: [PATCH] socket.7: Document some BPF-related socket options

2016-02-28 Thread Michael Kerrisk (man-pages)
Hello Craig, Thanks for putting this together. I have a few comments. Would you please amend your patch and resend? (And include Alexei in a "Reviewed-by" tag.) On 02/25/2016 09:27 PM, Craig Gallek wrote: > From: Craig Gallek > > Document the behavior and the first kernel version for each of th

Re: [PATCH v4 net-next] net: Implement fast csum_partial for x86_64

2016-02-28 Thread Tom Herbert
On Sun, Feb 28, 2016 at 10:56 AM, Alexander Duyck wrote: > On Sat, Feb 27, 2016 at 12:30 AM, Alexander Duyck > wrote: >>> +{ >>> + asm("lea 40f(, %[slen], 4), %%r11\n\t" >>> + "clc\n\t" >>> + "jmpq *%%r11\n\t" >>> + "adcq 7*8(%[src]),%[res]\n\t" >>> +

Re: [PATCH v4 net-next] net: Implement fast csum_partial for x86_64

2016-02-28 Thread Alexander Duyck
On Sat, Feb 27, 2016 at 12:30 AM, Alexander Duyck wrote: >> +{ >> + asm("lea 40f(, %[slen], 4), %%r11\n\t" >> + "clc\n\t" >> + "jmpq *%%r11\n\t" >> + "adcq 7*8(%[src]),%[res]\n\t" >> + "adcq 6*8(%[src]),%[res]\n\t" >> + "adcq 5*8(%[src]),%[re

[PATCH] of_mdio: kill useless variable in of_mdiobus_register()

2016-02-28 Thread Sergei Shtylyov
of_mdiobus_register() declares the 'paddr' variable to hold the result of the of_get_property() but only uses it once after that while the function can be called directly from the *if* statement. Remove that variable and switch to calling of_find_property() instead since we don't care about the

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-02-28 Thread Francois Romieu
Mike Galbraith : [...] > Hrm, relatively new + tasklet woes rings a bell. Ah, that.. > > > What's worse is that at the point where this code was written it was > already well known that tasklets are a steaming pile of crap and > should die. > > > Source thereof https://lwn.net/Articles/588457

[PATCH RFC v2 00/32] Make DSA switches linux devices.

2016-02-28 Thread Andrew Lunn
This is the second RFC for rearchitecturing how DSA devices are probed. This patchset allows switches to be linux devices, probed by the ususal mechanism for whatever bus they hang off. They then register with the DSA core. DSA has been limited to devices which hang off an MDIO bus, or with a bit

[PATCH RFC v2 21/32] net: mdio: Add mdiodev_{read|write} helpers

2016-02-28 Thread Andrew Lunn
An mdio driver will want to perform reads/writes on its device. Provide an abstraction over the mdiobus functions, which require more knowledge of bus addresses. Signed-off-by: Andrew Lunn --- drivers/net/phy/mdio_device.c | 68 +++ include/linux/mdio.h

[PATCH RFC v2 09/32] driver: component: Add support for empty match table

2016-02-28 Thread Andrew Lunn
Before calling component_master_add_with_match(), matches should be added using component_match_add() to the opaque match. How many matches are added typically depends on the contents of the device tree. It is not inconceivable that the number is zero, for example the components are optional. This

[PATCH RFC v2 05/32] net: dsa: Have the switch driver allocate there own private memory

2016-02-28 Thread Andrew Lunn
Now the switch devices have a dev pointer, make use if it for allocating the drivers private data structures using a devm_kzalloc(). Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- v2: Added missing assignment of priv to ds->priv. --- drivers/net/dsa/bcm_sf2.c | 9 +++-- driver

[PATCH RFC v2 01/32] net: dsa: Move platform data allocation for OF

2016-02-28 Thread Andrew Lunn
From: Florian Fainelli Do not have dsa_of_probe() allocate and assign struct dsa_platform_data, but instead do this outside of this function such that we can control exactly the storage of that data structure. This is a preliminary change to allow multiple callers of dsa_of_probe() not to clobbe

[PATCH RFC v2 28/32] Documentation: DSA: Describe how probe of DSA and switches work.

2016-02-28 Thread Andrew Lunn
With the introduction of switches as linux devices and the use of the component framework, probing has become more complex. Add some documentation. Signed-off-by: Andrew Lunn --- Documentation/networking/dsa/dsa.txt | 48 1 file changed, 48 insertions(+) dif

[PATCH RFC v2 08/32] net: dsa: dsa.c: Refactor to increase symmetry

2016-02-28 Thread Andrew Lunn
Create a dsa_switch_finish() which does the opposite of dsa_switch_setup(). Create a dsa_finish_dst() which does the opposite of dsa_setup_dst(). Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 44 +--- 1 file changed, 29 insertions(+), 15 deletions(-) dif

[PATCH RFC v2 26/32] net: dsa: Only setup platform switches, not device switches

2016-02-28 Thread Andrew Lunn
Switches which are linux devices will register themselves with DSA. Such switches already have a dsa_switch in the dsa_switch_tree, and don't need to be probed using the old mechanism. Similarly, it is the responsibility of the switch driver to free its resources when it unregisters. Signed-off-b

[PATCH RFC v2 31/32] dsa: dsa: Fix freeing of fixed-phys from user ports.

2016-02-28 Thread Andrew Lunn
All ports types can have a fixed PHY associated with it. Remove the check which limits removal to only CPU and DSA ports. Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index 73f962d81d40..e969a43f7a21 100644 --- a

[PATCH RFC v2 30/32] dsa: Destroy fixed link phys after the phy has been disconnected

2016-02-28 Thread Andrew Lunn
The phy is disconnected from the slave in dsa_slave_destroy(). Don't destroy fixed link phys until after this, since there can be fixed linked phys connected to ports. Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) d

[PATCH RFC v2 23/32] net: dsa: bcm_sf2: make it a real platform driver

2016-02-28 Thread Andrew Lunn
From: Florian Fainelli The Broadcom Starfighter 2 switch driver should be a proper platform driver, now that the DSA code has been updated to allow that, register a switch device, feed it with the proper configuration data coming from Device Tree and register our switch device with DSA. The bulk

[PATCH RFC v2 04/32] net: dsa: Pass the dsa device to the switch drivers

2016-02-28 Thread Andrew Lunn
By passing a device structure to the switch devices, it allows them to use devm_* methods for resource management. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 2 +- drivers/net/dsa/mv88e6060.c | 2 +- drivers/net/dsa/mv88e6123.c | 2 +- drivers/net/ds

[PATCH RFC v2 29/32] dsa: slave: Don't reference NULL pointer during phy_disconnect

2016-02-28 Thread Andrew Lunn
When the phy is disconnected, the parent pointer to the netdev it was attached to is set to NULL. The code then tries to suspend the phy, but dsa_slave_fixed_link_update needs the parent pointer to determine which switch the phy is connected to. So it dereferenced a NULL pointer. Check for this con

[PATCH RFC v2 02/32] dsa: Rename mv88e6123_61_65 to mv88e6123 to be consistent

2016-02-28 Thread Andrew Lunn
All the drivers support multiple chips, but mv88e6123_61_65 is the only one that reflects this in its naming. Change it to be consistent with the other drivers. Signed-off-by: Andrew Lunn --- drivers/net/dsa/Kconfig | 2 +- drivers/net/dsa/Makefile | 4 +- drivers/net/dsa/

[PATCH RFC v2 25/32] net: dsa: Setup the switches after all have been probed

2016-02-28 Thread Andrew Lunn
Some switches register themselves with DSA, which others are probed by DSA itself. Move the setup call to after all switches have been successfully probed. Similarly, finish each before releasing them. Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 27 --- 1 file changed,

[PATCH RFC v2 19/32] dsa: mv88e6xxx: Add macro for registering the drivers

2016-02-28 Thread Andrew Lunn
The macro cuts down on boilerplate. The switch driver needs to both register itself as an MDIO driver and register itself as a switch driver. This second registration is needed to retain backwards compatibility with the old binding. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.h | 23

[PATCH RFC v2 14/32] net: dsa: Add register/unregister functions for switch drivers

2016-02-28 Thread Andrew Lunn
A switch device driver registers with DSA as part of the component slave bind and unregisters on component slave unbind. Signed-off-by: Andrew Lunn --- include/net/dsa.h | 3 +++ net/dsa/dsa.c | 53 + 2 files changed, 56 insertions(+) dif

[PATCH RFC v2 15/32] net: dsa: Rename DSA probe function.

2016-02-28 Thread Andrew Lunn
Rename the function called from the DSA to perform a probe for the switch. This makes the normal _probe() name available for a standard Linux device driver probe function. Signed-off-by: Andrew Lunn --- drivers/net/dsa/bcm_sf2.c | 4 ++-- drivers/net/dsa/mv88e6060.c | 4 ++-- drivers/net/dsa/m

[PATCH RFC v2 20/32] dsa: Add mdio device support to Marvell switches

2016-02-28 Thread Andrew Lunn
Allow Marvell switches to be mdio devices, which probe and then register with the DSA framework, as component slaves. At the same time, make them separate modules, and make mv88e6xxx a library module. Signed-off-by: Andrew Lunn --- v2: s/Copywrite/Copyright --- .../devicetree/bindings/net/dsa/m

[PATCH RFC v2 27/32] net: dsa: If a switch fails to probe, defer probing

2016-02-28 Thread Andrew Lunn
Switches are either listed in device tree or platform_data. They should exist. If the probe fails, defer the probe, which is the likely cause of failure, not broken device tree or platform data. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- net/dsa/dsa.c | 2 +- 1 file changed, 1 in

[PATCH RFC v2 16/32] dsa: mv88e6xxx: Use bus in mv88e6xxx_lookup_name()

2016-02-28 Thread Andrew Lunn
mv88e6xxx_lookup_name() returns the model name of a switch at a given address on an MII bus. Using mii_bus to identify the bus rather than the host device is more logical, so change the parameter. Signed-off-by: Andrew Lunn --- v2: Check bus is valid before dereferencing it. --- drivers/net/dsa/

[PATCH RFC v2 13/32] net: dsa: Make dsa,mii-bus optional

2016-02-28 Thread Andrew Lunn
When all the switches are devices and register to the DSA framework, having a dsa,mii-bus property is not required. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- Documentation/devicetree/bindings/net/dsa/dsa.txt | 3 +- net/dsa/dsa.c | 36 +++

[PATCH RFC v2 22/32] net: dsa: Better integrate the drivers with mdio device

2016-02-28 Thread Andrew Lunn
Don't unpack the mdiodev into its bus and address value. Rather keep it is a core data structure for addressing. This does however mean when the driver is instantiated the old way, we have to create a dummy mdiodev structure. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6060.c | 27 ++

[PATCH RFC v2 32/32] phy: fixed: Fix removal of phys.

2016-02-28 Thread Andrew Lunn
The fixed phys delete function simply removed the fixed phy from the internal linked list and freed the memory. It however did not unregister the associated phy device. This meant it was still possible to find the phy device on the mdio bus. Make fixed_phy_del() an internal function and add a fixe

[PATCH RFC v2 06/32] net: dsa: Remove allocation of driver private memory

2016-02-28 Thread Andrew Lunn
The drivers now allocate their own memory for private usage. Remove the allocation from the core code. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- include/net/dsa.h | 1 - net/dsa/dsa.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/net/dsa.h b/i

[PATCH RFC v2 12/32] net: dsa: Add slave component matches based on a phandle to the slave.

2016-02-28 Thread Andrew Lunn
Switch devices are component slaves. Such devices have a "switch" property in the DSA device tree which is a phandle to the switch device. Add a component match on the device node. Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(

[PATCH RFC v2 17/32] dsa: mv88e6xxx: Add shared code for binding/unbinding a switch driver.

2016-02-28 Thread Andrew Lunn
Switch drivers are component slaves. When they are bound to a master component, the bind function is called and resources can be reserved. Add the shared code. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 77 ++--- drivers/net/dsa/mv88e6xxx

[PATCH RFC v2 07/32] net: dsa: Keep the mii bus and address in the private structure

2016-02-28 Thread Andrew Lunn
Rather than looking up the mii bus and address every time, do it once and setup, and keep it in the private structure. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- v2: Add check for valid mii_bus. --- drivers/net/dsa/mv88e6060.c | 27 +-- drivers/net/dsa/mv8

[PATCH RFC v2 24/32] net: dsa: Add some debug prints for error cases

2016-02-28 Thread Andrew Lunn
Due to the complexity it can be hard to know why DSA fails to probe. Add some debug prints for the common error cases. Signed-off-by: Andrew Lunn Acked-by: Florian Fainelli --- net/dsa/dsa.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/net/dsa/dsa.c b/net/d

[PATCH RFC v2 18/32] dsa: mv88e6xxx: Prepare for turning this into a library module

2016-02-28 Thread Andrew Lunn
Export all the functions so that we can later turn the module into a library module. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 46 + 1 file changed, 46 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6x

[PATCH RFC v2 11/32] net: dsa: Keep a reference to the switch device for component matching

2016-02-28 Thread Andrew Lunn
The switch devices are component slaves. Such devices have a "switch" property in the DSA device tree which is a phandle to the switch device. When the slaves bind they register to DSA. So the DSA can match the switch to the correct switch instance in the device tree, keep a reference to the device

[PATCH RFC v2 03/32] dsa: Make setup and finish more symmetrical

2016-02-28 Thread Andrew Lunn
Rename and reposition dsa_switch_destroy() to dsa_switch_finish_one() to make it clear it is the opposite of dsa_switch_setup_one(). Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 90 +-- 1 file changed, 45 insertions(+), 45 deletions(-) d

[PATCH RFC v2 10/32] net: dsa: Add basic support for component master support

2016-02-28 Thread Andrew Lunn
Start using the component framework. The DSA device will be the master, and the switch drivers will be slaves. Add basic component master support to the DSA framework. Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 54 -- 1 file changed, 40 ins

Re: [PATCH] net/9p: convert to new CQ API

2016-02-28 Thread Christoph Hellwig
On Sun, Feb 28, 2016 at 01:03:47PM +0200, Sagi Grimberg wrote: > >> Trivial conversion to the new RDMA CQ API. > > Looks nice and simple :) > > But I think that the fact that CQ processing is now > done in soft-IRQ (which is an improvement!) needs to > be documented. Yeah, I meant to do that, but

[PATCH/RFC v6 net-next] ravb: Add dma queue interrupt support

2016-02-28 Thread Yoshihiro Kaneko
From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (timestamp, error, gPTP) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) This patch improve efficiency of the interrupt handler by adding the int

[PATCH net-next V1 04/10] net/mlx5e: Move common case counters within sq_stats struct

2016-02-28 Thread Saeed Mahameed
From: Tariq Toukan For data cache locality considerations, we moved the nop and csum_offload_inner within sq_stats struct as they are more commonly accessed in xmit path. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 10 ++--

[PATCH net-next V1 09/10] net/mlx5: Fix global UAR mapping

2016-02-28 Thread Saeed Mahameed
From: Moshe Lazer Remove the global WC mapping of the total UARs since UAR mapping should be decided per UAR (e.g we want different mappings for EQs, CQs vs QPs). We use ARCH_HAS_IOREMAP_WC to know if the current arch supports WC (Write combining) IO memory mapping, if it is not supported "uar->

[PATCH net-next V1 06/10] net/mlx5e: Don't try to modify CQ moderation if it is not supported

2016-02-28 Thread Saeed Mahameed
From: Gal Pressman If CQ moderation is not supported by the device, print a warning on netdevice load, and return error when trying to modify/query cq moderation via ethtool. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality') Signed-off-by: Gal Pressm

[PATCH net-next V1 10/10] net/mlx5: Avoid double mapping of io mapped memory

2016-02-28 Thread Saeed Mahameed
From: Moshe Lazer Device page may be mapped to non-cached(NC) or to write combining(WC). The code before this fix tries to map it both to WC and NC contrary to what stated in Intel's software developer manual. Fixes: 88a85f99e51f ('TX latency optimization to save DMA reads') Signed-off-by: Moshe

[PATCH net-next V1 07/10] net/mlx5e: Don't modify CQ before it was created

2016-02-28 Thread Saeed Mahameed
From: Gal Pressman Calling mlx5e_set_coalesce while the interface is down will result in modifying CQs that don't exist. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality') Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- .../net/ether

[PATCH net-next V1 08/10] net/mlx5: Make command timeout way shorter

2016-02-28 Thread Saeed Mahameed
From: Or Gerlitz The command timeout is terribly long, whole two hours. Make it 60s so if things do go wrong, the user gets feedback in relatively short time, so they can take corrective actions and/or investigate using tools and such. Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-

[PATCH net-next V1 02/10] net/mlx5e: Placement changed for carrier state updates

2016-02-28 Thread Saeed Mahameed
From: Tariq Toukan More proper to declare carrier state UP only after the channels are ready for traffic. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH net-next V1 00/10] mlx5 driver updates

2016-02-28 Thread Saeed Mahameed
Hi Dave, This series includes some bug fixes and updates for the mlx5 core and ethernet driver. >From Gal, two fixes that protects the update CQ moderation flows when it is not allowed. >From Moshe, two fixes for the core and ethernet driver in non-cached(NC) and write combining(WC) buffers ma

[PATCH net-next V1 01/10] net/mlx5e: Replace async events spinlock with synchronize_irq()

2016-02-28 Thread Saeed Mahameed
From: Tariq Toukan We only need to flush the irq handler to make sure it does not queue a work into the global work queue after we start to flush it. So using synchronize_irq() is more appropriate than a spin lock. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethe

[PATCH net-next V1 05/10] net/mlx5e: Set drop RQ's necessary parameters only

2016-02-28 Thread Saeed Mahameed
From: Tariq Toukan By its role, there is no need to set all the other parameters for the drop RQ. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH net-next V1 03/10] net/mlx5e: Changed naming convention of tx queues in ethtool stats

2016-02-28 Thread Saeed Mahameed
From: Tariq Toukan Instead of the pair (channel, tc), we now use a single number that goes over all tx queues of a TC, for all TCs. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 15 --- 1 files changed, 8 inser

Re: [PATCH/RFC v5 net-next] ravb: Add dma queue interrupt support

2016-02-28 Thread Yoshihiro Kaneko
2016-02-22 4:05 GMT+09:00 Sergei Shtylyov : > On 02/14/2016 10:39 PM, Yoshihiro Kaneko wrote: > >> From: Kazuya Mizuguchi >> >> This patch supports the following interrupts. >> >> - One interrupt for multiple (error, gPTP) >> - One interrupt for emac >> - Four interrupts for dma queue (best effort

Re: [net-next PATCH v2 2/8] net: rework setup_tc ndo op to consume general tc operand

2016-02-28 Thread Alaa Hleihel
Hi John, On 2/16/2016 08:00, John Fastabend wrote: > @@ -140,9 +141,11 @@ static int mqprio_init(struct Qdisc *sch, struct nlattr > *opt) >* supplied and verified mapping >*/ > if (qopt->hw) { > + struct tc_to_netdev tc = {.type = TC_SETUP_MQPRIO, > +

Re: [PATCH V3 3/3] vhost_net: basic polling support

2016-02-28 Thread Michael S. Tsirkin
On Fri, Feb 26, 2016 at 04:42:44PM +0800, Jason Wang wrote: > This patch tries to poll for new added tx buffer or socket receive > queue for a while at the end of tx/rx processing. The maximum time > spent on polling were specified through a new kind of vring ioctl. > > Signed-off-by: Jason Wang

Re: [PATCH] net/mlx5e: make VXLAN support conditional

2016-02-28 Thread Saeed Mahameed
On Fri, Feb 26, 2016 at 11:13 PM, Arnd Bergmann wrote: > VXLAN can be disabled at compile-time or it can be a loadable > module while mlx5 is built-in, which leads to a link error: > > drivers/net/built-in.o: In function `mlx5e_create_netdev': > ntb_netdev.c:(.text+0x106de4): undefined reference t

Re: [PATCH] net/9p: convert to new CQ API

2016-02-28 Thread Sagi Grimberg
Trivial conversion to the new RDMA CQ API. Looks nice and simple :) But I think that the fact that CQ processing is now done in soft-IRQ (which is an improvement!) needs to be documented. Other than that, looks great Reviewed-by: Sagi Grimberg P.S. I was also confused in the past about 9p

[PATCH net-next 2/4] qed: Add support for HW attentions

2016-02-28 Thread Yuval Mintz
HW is capable of generating attentnions for a multitude of reasons, but current driver is enabling attention generation only for management firmware [required for link notifications]. This patch enables almost all of the possible reasons for HW attentions, logging the HW block generating the atten

[PATCH net-next 4/4] qed: Print additional HW attention info

2016-02-28 Thread Yuval Mintz
This patch utilizes the attention infrastructure to log additional information that relates only to specific HW blocks. For some of those HW blocks, it also stops automatically disabling the attention generation as the attention is considered benign and thus should only be logged; No fear of it flo

[PATCH net-next 3/4] qed: Print HW attention reasons

2016-02-28 Thread Yuval Mintz
Each HW block contains common information about attention reasons, raising a bit for each one of the different sub-reasons that caused it to raise an attention. This patch extends the infrastructure by allowing logging of the various reasons causing the HW blocks to generate an attention. Signed-

[PATCH net-next 1/4] qed: Semantic refactoring of interrupt code

2016-02-28 Thread Yuval Mintz
Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 6 +- drivers/net/ethernet/qlogic/qed/qed_int.c | 155 - drivers/net/ethernet/qlogic/qed/qed_int.h | 6 +- drivers/net/ethernet/qlogic/qed/qed_main.c | 15 +-- include/linux/qed/qed_if.h

[PATCH net-next 0/4] qed: Attention support patch series

2016-02-28 Thread Yuval Mintz
Until now we've only enabled attention generation for the sake of management firmware indications [required for link notifications]. This series enables [almost] all the attention sources of the HW, currently for the sake of logging information relating to issues experienced by HW. In future, infr

Re: [net-next][PATCH v2 11/13] RDS: IB: add Fastreg MR (FRMR) detection support

2016-02-28 Thread santosh.shilim...@oracle.com
On 2/28/16 1:08 AM, Christoph Hellwig wrote: On Sat, Feb 27, 2016 at 06:19:48PM -0800, Santosh Shilimkar wrote: Discovere Fast Memmory Registration support using IB device IB_DEVICE_MEM_MGT_EXTENSIONS. Certain HCA might support just FRMR or FMR or both FMR and FRWR. In case both mr type are sup

Re: [net-next][PATCH v2 01/13] RDS: Drop stale iWARP RDMA transport

2016-02-28 Thread santosh.shilim...@oracle.com
On 2/28/16 1:05 AM, Christoph Hellwig wrote: On Sat, Feb 27, 2016 at 06:19:38PM -0800, Santosh Shilimkar wrote: RDS iWarp support code has become stale and non testable. As indicated earlier, am dropping the support for it. If new iWarp user(s) shows up in future, we can adapat the RDS IB tra

Re: [PATCH V3 0/3] basic busy polling support for vhost_net

2016-02-28 Thread Michael S. Tsirkin
On Fri, Feb 26, 2016 at 11:45:02AM -0500, David Miller wrote: > From: Jason Wang > Date: Fri, 26 Feb 2016 16:42:41 +0800 > > > This series tries to add basic busy polling for vhost net. The idea is > > simple: at the end of tx/rx processing, busy polling for new tx added > > descriptor and rx rec

Re: [PATCH] asm-generic: remove old nonatomic-io wrapper files

2016-02-28 Thread Christoph Hellwig
Thanks Arnd, this looks good to me: Reviewed-by: Christoph Hellwig

Re: [net-next][PATCH v2 11/13] RDS: IB: add Fastreg MR (FRMR) detection support

2016-02-28 Thread Christoph Hellwig
On Sat, Feb 27, 2016 at 06:19:48PM -0800, Santosh Shilimkar wrote: > Discovere Fast Memmory Registration support using IB device > IB_DEVICE_MEM_MGT_EXTENSIONS. Certain HCA might support just FRMR > or FMR or both FMR and FRWR. In case both mr type are supported, > default FMR is used. > > Default

Re: [net-next][PATCH v2 01/13] RDS: Drop stale iWARP RDMA transport

2016-02-28 Thread Christoph Hellwig
On Sat, Feb 27, 2016 at 06:19:38PM -0800, Santosh Shilimkar wrote: > RDS iWarp support code has become stale and non testable. As > indicated earlier, am dropping the support for it. > > If new iWarp user(s) shows up in future, we can adapat the RDS IB > transprt for the special RDMA READ sink cas

Re: [PATCH 3/3] 3c59x: Use setup_timer()

2016-02-28 Thread Amitoj Kaur Chawla
On Sun, Feb 28, 2016 at 1:23 PM, Stafford Horne wrote: > > > On Sun, 28 Feb 2016, Amitoj Kaur Chawla wrote: > >> On Sun, Feb 28, 2016 at 12:18 AM, Stafford Horne wrote: >> > >> > >> > On Thu, 25 Feb 2016, David Miller wrote: >> > >> >> From: Amitoj Kaur Chawla >> >> Date: Wed, 24 Feb 2016 19:28: