pull-request: can-next 2016-02-26

2016-02-25 Thread Marc Kleine-Budde
Hello David, this is a pull request of 3 patch for net-next/master. There are two patches by Simon Horman, in which the device tree support for the rcar_can driver is improved. One patch by me fixes the bad coding style of the ems_usb driver which was introduced recently. regards, Marc --- The

[PATCH net-next 5/5] vxlan: implement GPE in L3 mode

2016-02-25 Thread Jiri Benc
Implement L3 mode for VXLAN-GPE (i.e. IPv4/IPv6 payload directly after the VXLAN header). The GPE header parsing has to be moved before iptunnel_pull_header, as we need to know the protocol. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 127 +++-

[PATCH net-next 2/5] vxlan: move L2 mode initialization to a separate function

2016-02-25 Thread Jiri Benc
This will allow to initialize vxlan in L3 mode based on the passed rtnl attributes. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index c7844bae339d..49fcca8d8a8

[PATCH net-next 4/5] vxlan: fix too large pskb_may_pull with remote checksum

2016-02-25 Thread Jiri Benc
The vxlan header is pulled at this point, don't include it again in the calculation. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 029e0e5b0b2b..81a7c1a829b9 100644 --- a/

[PATCH net-next 1/5] vxlan: implement GPE in L2 mode

2016-02-25 Thread Jiri Benc
Implement VXLAN-GPE. Only L2 mode (i.e. encapsulated Ethernet frame) is supported by this patch. L3 mode will be added by subsequent patches. Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 68 ++-- include/net/vxlan.h | 62 ++

[PATCH net-next 0/5] vxlan: implement Generic Protocol Extension (GPE)

2016-02-25 Thread Jiri Benc
VXLAN-GPE can operate in two modes: with encapsulated Ethernet header (L2 mode) or with L3 header (e.g. IP header) directly following VXLAN-GPE header (L3 mode). Add support for both modes. The L2 mode is simple, as it's basically the same as plain VXLAN, only with added bits in the header. The L3

[PATCH net-next 3/5] vxlan: move fdb code to common location in vxlan_xmit

2016-02-25 Thread Jiri Benc
Handle VXLAN_F_COLLECT_METADATA before VXLAN_F_PROXY. The latter does not make sense with the former, as it needs populated fdb which does not happen in metadata mode. After this cleanup, the fdb code in vxlan_xmit is moved to a common location and can be later skipped for L3 mode vxlan tunnels.

[PATCH] can: gs_usb: fixed disconnect bug by removing erroneous use of kfree()

2016-02-25 Thread Marc Kleine-Budde
From: Maximilain Schneider gs_destroy_candev() erroneously calls kfree() on a struct gs_can *, which is allocated through alloc_candev() and should instead be freed using free_candev() alone. The inappropriate use of kfree() causes the kernel to hang when gs_destroy_candev() is called. Only the

pull-request: can 2016-02-26

2016-02-25 Thread Marc Kleine-Budde
Hello David, this is a pull request of one patch for net. The patch by Maximilain Schneider fixes a kfree() problem during disconnect in the gs_usb driver. regrds, Marc --- The following changes since commit 4c0b6eaf373a5323f03a3a20c42fc435715b073d: net: thunderx: Fix for Qset error due to C

Re: [PATCH] uapi glibc compat: fix cases where glibc net/if.h is included before linux/if.h

2016-02-25 Thread Mikko Rapeli
(Adding libc-alpha list, review of https://lkml.org/lkml/2016/2/7/89 ) On Wed, Feb 17, 2016 at 10:46:20AM -0500, David Miller wrote: > From: Mikko Rapeli > Date: Sun, 7 Feb 2016 16:03:21 +0200 > > > @@ -68,6 +72,8 @@ > > * @IFF_ECHO: echo sent packets. Volatile. > > */ > > enum net_device_

Re: [PATCH net] ipv4: only create late gso-skb if skb is already set up with CHECKSUM_PARTIAL

2016-02-25 Thread Hannes Frederic Sowa
On 26.02.2016 01:45, Wakko Warner wrote: Now there's another one: [ 777.315931] [ cut here ] [ 777.316099] WARNING: CPU: 0 PID: 1404 at /usr/src/linux/dist/4.4-nobklcd/net/ipv4/af_inet.c:155 inet_sock_destruct+0x1cb/0x1f0() [ 777.316189] Modules linked in: nfsv3 af_pa

Re: [net-next PATCH v2 3/3] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread John Fastabend
On 16-02-25 11:02 PM, Samudrala, Sridhar wrote: > On 2/25/2016 3:20 PM, John Fastabend wrote: >> In the initial implementation the only way to stop a rule from being >> inserted into the hardware table was via the device feature flag. >> However this doesn't work well when working on an end host sy

Re: header conflict introduced by change to netfilter_ipv4/ip_tables.h

2016-02-25 Thread Mikko Rapeli
On Thu, Feb 25, 2016 at 10:08:56PM +0100, Thomas Graf wrote: > On 01/06/16 at 09:20am, Stephen Hemminger wrote: > > This commit breaks compilation of iproute2 with net-next. > > > > commit 1ffad83dffd675cd742286ae82dca7d746cb0da8 > > Author: Mikko Rapeli > > Date: Thu Oct 15 07:56:30 2015 +0200

Re: header conflict introduced by change to netfilter_ipv4/ip_tables.h

2016-02-25 Thread Mikko Rapeli
On Thu, Feb 25, 2016 at 09:53:32PM +0100, Daniel Borkmann wrote: > On 02/04/2016 08:13 AM, Josh Boyer wrote: > >On Thu, Jan 7, 2016 at 2:15 PM, Mikko Rapeli wrote: > >>On Thu, Jan 07, 2016 at 10:30:40AM -0800, Stephen Hemminger wrote: > >>>On Thu, 7 Jan 2016 07:29:50 + > >>>Mikko Rapeli wrote

Re: [net-next PATCH v2 3/3] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread Samudrala, Sridhar
On 2/25/2016 3:20 PM, John Fastabend wrote: In the initial implementation the only way to stop a rule from being inserted into the hardware table was via the device feature flag. However this doesn't work well when working on an end host system where packets are expect to hit both the hardware an

Re: [PATCH] ipv4: do not cache local route when using SO_BINDTODEVICE

2016-02-25 Thread Kouya Shimura
Thanks for reviewing. David Miller writes: > From: Kouya Shimura > Date: Tue, 23 Feb 2016 14:27:32 +0900 > >> After v3.6, output routes are cached, however, the 'rt_iif' field of >> struct rtable can not be shared by various traffics using SO_BINDTODEVICE. >> It causes that traffic can not reach

Re: [PATCH 1/4] kernel: time: Add current_nw_timestamp() for network timestamps

2016-02-25 Thread YOSHIFUJI Hideaki/吉藤英明
Hi, Deepa Dinamani wrote: >>> include/linux/ip.h | 2 ++ >>> include/linux/time64.h | 3 +++ >>> kernel/time/time.c | 26 ++ >>> 3 files changed, 31 insertions(+) >>> >> Since net/ipv4/* are the only users, it is enough to put >> it in under net/ipv4/. > > time.

Re: [PATCH net-next RFC] rtnetlink: add new RTM_GETSTATS to dump link stats

2016-02-25 Thread roopa
On 2/25/16, 8:26 AM, David Miller wrote: > From: roopa > Date: Wed, 24 Feb 2016 21:25:50 -0800 > >> I did go back and forth on the attribute vs mask. >> cosmetic but, i guess i did not feel good about having to redefine every >> attribute again >> for the bitmap filter ...and i anticipate the lis

[net-next PATCH] IPv6: Use a 16 bit length field when computing a IPv6 UDP checksum

2016-02-25 Thread Alexander Duyck
This change makes it so that we only use a 16 bit length field instead of a 32 bit length field when computing a UDP checksum for IPv6. This fixes an issue found with UDP tunnels over IPv6 where the total size exceeded 65536 for a frame that was to be segmented. As a result the checksum being com

Re: [PATCH net-next] net: Facility to report route quality of connected sockets

2016-02-25 Thread David Miller
From: Tom Herbert Date: Wed, 24 Feb 2016 10:02:52 -0800 > This patch add the SO_CNX_ADVICE socket option (setsockopt only). The > purpose is to allow an application to give feedback to the kernel about > the quality of the network path for a connected socket. The value > argument indicates the ty

Re: [PATCH net-next v7] net: ipv6: Make address flushing on ifdown optional

2016-02-25 Thread David Miller
From: David Ahern Date: Wed, 24 Feb 2016 09:25:37 -0800 > Currently, all ipv6 addresses are flushed when the interface is configured > down, including global, static addresses: ... > Add a new sysctl to make this behavior optional. The new setting defaults to > flush all addresses to maintain ba

[PATCH iproute2 v2] iplink: Support VF Trust

2016-02-25 Thread Hiroshi Shimamoto
From: Hiroshi Shimamoto Add IFLA_VF_TRUST message to trust the VF. PF can accept some privileged operation from the trusted VF. For example, ixgbe PF doesn't allow to enable VF promiscuous mode until the VF is trusted because it may hurt performance. To trust VF. # ip link set dev eth0 vf 1 tru

Re: [PATCH v2 net] bonding: don't use stale speed and duplex information

2016-02-25 Thread zhuyj
On 02/25/2016 09:33 PM, Jay Vosburgh wrote: zhuyj wrote: [...] I delved into the source code and Emil's tests. I think that the problem that this patch expects to fix occurs very unusually. Do you agree with me? If so, maybe the following patch can reduce the performance loss. Please comment

Re: [PATCH] appletalk: Pass IP-over-DDP packets through when 'ipddp0' interface is not present

2016-02-25 Thread Adam Seering
On Thu, 2016-02-25 at 14:33 -0500, David Miller wrote: > From: Adam Seering > Date: Tue, 23 Feb 2016 09:19:13 -0500 > > > Let userspace programs transmit and receive raw IP-over-DDP packets > > with a kernel where "ipddp" was compiled as a module but is not > loaded > > (so no "ipddp0" network in

Re: [PATCH net] ipv4: only create late gso-skb if skb is already set up with CHECKSUM_PARTIAL

2016-02-25 Thread Wakko Warner
Wakko Warner wrote: > Hannes Frederic Sowa wrote: > > Otherwise we break the contract with GSO to only pass CHECKSUM_PARTIAL > > skbs down. This can easily happen with UDP+IPv4 sockets with the first > > MSG_MORE write smaller than the MTU, second write is a sendfile. > > > > Returning -EOPNOTSUPP

Re: linux-next: manual merge of the net-next tree with the net tree

2016-02-25 Thread Daniel Borkmann
On 02/26/2016 01:13 AM, Stephen Rothwell wrote: [...] I fixed it up (see below) and can carry the fix as necessary (no action is required). Looks good to me, thanks Stephen! Best, Daniel

linux-next: manual merge of the net-next tree with the net tree

2016-02-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/uapi/linux/bpf.h between commit: 2da897e51d7f ("bpf: fix csum setting for bpf_set_tunnel_key") from the net tree and commit: d5a3b1f69186 ("bpf: introduce BPF_MAP_TYPE_STACK_TRACE") from the net-next tree.

Re: [PATCH net] ipv4: only create late gso-skb if skb is already set up with CHECKSUM_PARTIAL

2016-02-25 Thread Wakko Warner
Hannes Frederic Sowa wrote: > Otherwise we break the contract with GSO to only pass CHECKSUM_PARTIAL > skbs down. This can easily happen with UDP+IPv4 sockets with the first > MSG_MORE write smaller than the MTU, second write is a sendfile. > > Returning -EOPNOTSUPP lets the callers fall back into

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-25 Thread Daniel Borkmann
On 02/25/2016 11:40 PM, Jamal Hadi Salim wrote: On 16-02-25 04:34 PM, Daniel Borkmann wrote: On 02/25/2016 01:23 PM, Jamal Hadi Salim wrote: On 16-02-24 12:48 PM, Daniel Borkmann wrote: On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: [...] Drivers do set the hash. My use case is slightly dif

Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails

2016-02-25 Thread Kuba Kicinski
On 25 February 2016 18:24:27 GMT-05:00, Colin King wrote: >From: Colin Ian King > >If the allocation of ivp fails the error handling attempts to >free an uninitialized dma_buf; this data structure just contains >garbage on the stack, so the freeing will cause issues when the >urb, buf and dma fi

[PATCH net-next 2/4] lan78xx: remove unnecessary code

2016-02-25 Thread Woojung.Huh
It is not required after commit cd772de358d6 ("phy: keep pause flags in phy driver features") Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 4ec25e8..d1

[PATCH net-next 0/4] lan78xx: driver update

2016-02-25 Thread Woojung.Huh
This patch series add new ethtool functions of set_pauseparam & get_pauseparam and MAINTAINERS entry. Woojung Huh (4): lan78xx: replace devid to chipid & chiprev lan78xx: remove unnecessary code lan78xx: add ethtool set & get pause functions MAINTAINERS: Add LAN78XX entry MAINTAINERS

[PATCH net-next 3/4] lan78xx: add ethtool set & get pause functions

2016-02-25 Thread Woojung.Huh
Add ethtool operations of set_pauseram and get_pauseparm. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 80 +-- 1 file changed, 77 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index d100

[PATCH net-next 1/4] lan78xx: replace devid to chipid & chiprev

2016-02-25 Thread Woojung.Huh
Replace devid to chipid & chiprev for easy access. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 20 +++- drivers/net/usb/lan78xx.h | 1 + 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 1c2

[PATCH net-next 4/4] MAINTAINERS: Add LAN78XX entry

2016-02-25 Thread Woojung.Huh
Add maintainers for Microchip LAN78XX. unglinuxdri...@microchip.com is alias email which goes to current developers work for Microchip Network related products. Signed-off-by: Woojung Huh --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2

Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails

2016-02-25 Thread Julian Calaby
Hi, On Fri, Feb 26, 2016 at 10:24 AM, Colin King wrote: > From: Colin Ian King > > If the allocation of ivp fails the error handling attempts to > free an uninitialized dma_buf; this data structure just contains > garbage on the stack, so the freeing will cause issues when the > urb, buf and dma

Re: [net-next PATCH v2 0/3] tc software only flag

2016-02-25 Thread John Fastabend
On 16-02-25 03:19 PM, John Fastabend wrote: > This adds a software only flag to tc but incorporates a bunch of comments > from the original attempt at this. In case its not entirely obvious I dropped the hardware only case for now because I'm investigating Jiri's comment. But just having the softw

[PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails

2016-02-25 Thread Colin King
From: Colin Ian King If the allocation of ivp fails the error handling attempts to free an uninitialized dma_buf; this data structure just contains garbage on the stack, so the freeing will cause issues when the urb, buf and dma fields are free'd. Fix this by not free'ing the dma_buf if the ivp a

[net-next PATCH v2 3/3] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread John Fastabend
In the initial implementation the only way to stop a rule from being inserted into the hardware table was via the device feature flag. However this doesn't work well when working on an end host system where packets are expect to hit both the hardware and software datapaths. For example we can imag

[net-next PATCH v2 2/3] net: cls_u32: move TC offload feature bit into cls_u32 offload logic

2016-02-25 Thread John Fastabend
In the original series drivers would get offload requests for cls_u32 rules even if the feature bit is disabled. This meant the driver had to do a boiler plate check on the feature bit before adding/deleting the rule. This patch lifts the check into the core code and removes it from the driver spe

[net-next PATCH v2 1/3] net: sched: consolidate offload decision in cls_u32

2016-02-25 Thread John Fastabend
The offload decision was originally very basic and tied to if the dev implemented the appropriate ndo op hook. The next step is to allow the user to more flexibly define if any paticular rule should be offloaded or not. In order to have this logic in one function lift the current check into a helpe

[net-next PATCH v2 0/3] tc software only flag

2016-02-25 Thread John Fastabend
This adds a software only flag to tc but incorporates a bunch of comments from the original attempt at this. First instead of having the offload decision logic be embedded in cls_u32 I lifted into cls_pkt.h so it can be used anywhere. In order to do this I put the flag defines in pkt_cls.h as wel

Re: [PATCH][V2] mt7601u: do not free dma_buf when ivp allocation fails

2016-02-25 Thread Julian Calaby
Hi Colin, On Fri, Feb 26, 2016 at 10:09 AM, Colin King wrote: > From: Colin Ian King > > If the allocation of ivp fails the error handling attempts to > free an uninitialized dma_buf; this data structure just contains > garbage on the stack, so the freeing will cause issues when the > urb, buf a

[PATCH][V2] mt7601u: do not free dma_buf when ivp allocation fails

2016-02-25 Thread Colin King
From: Colin Ian King If the allocation of ivp fails the error handling attempts to free an uninitialized dma_buf; this data structure just contains garbage on the stack, so the freeing will cause issues when the urb, buf and dma fields are free'd. Fix this by not free'ing the dma_buf if the ivp a

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread John Fastabend
On 16-02-25 03:05 PM, Jamal Hadi Salim wrote: > On 16-02-25 04:56 PM, John Fastabend wrote: >> On 16-02-25 04:56 AM, Jamal Hadi Salim wrote: > >> >> decoding that is not a problem. The ixgbe driver code already applied >> can decode that without much trouble. The thing I want to avoid is >> requir

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread Jamal Hadi Salim
On 16-02-25 04:56 PM, John Fastabend wrote: On 16-02-25 04:56 AM, Jamal Hadi Salim wrote: decoding that is not a problem. The ixgbe driver code already applied can decode that without much trouble. The thing I want to avoid is requiring my driver to do the inverse translation because although

[PATCH v18 4/9] bpf: Mark __bpf_prog_run() stack frame as non-standard

2016-02-25 Thread Josh Poimboeuf
objtool reports the following false positive warnings: objtool: kernel/bpf/core.o: __bpf_prog_run()+0x5c: sibling call from callable instruction with changed frame pointer objtool: kernel/bpf/core.o: __bpf_prog_run()+0x60: function has unreachable instruction objtool: kernel/bpf/core.o: __

Re: [patch net-next v2 0/9] Introduce devlink interface and first drivers to use it

2016-02-25 Thread Jiri Pirko
Thu, Feb 25, 2016 at 10:53:30PM CET, han...@stressinduktion.org wrote: >On 25.02.2016 22:12, Jiri Pirko wrote: >>Thu, Feb 25, 2016 at 09:44:43PM CET, han...@stressinduktion.org wrote: >>>On 25.02.2016 21:12, David Miller wrote: From: Jiri Pirko Date: Tue, 23 Feb 2016 16:51:25 +0100 >>

[Patch net-next v3 1/4] net_sched: introduce qdisc_replace() helper

2016-02-25 Thread Cong Wang
Remove nearly duplicated code and prepare for the following patch. Cc: Jamal Hadi Salim Acked-by: Jamal Hadi Salim Signed-off-by: Cong Wang --- include/net/sch_generic.h | 17 + net/sched/sch_cbq.c | 7 +-- net/sched/sch_drr.c | 6 +- net/sched/sch_dsmark.

[Patch net-next v3 2/4] net_sched: update hierarchical backlog too

2016-02-25 Thread Cong Wang
When the bottom qdisc decides to, for example, drop some packet, it calls qdisc_tree_decrease_qlen() to update the queue length for all its ancestors, we need to update the backlog too to keep the stats on root qdisc accurate. Cc: Jamal Hadi Salim Acked-by: Jamal Hadi Salim Signed-off-by: Cong W

[Patch net-next v3 3/4] sch_htb: update backlog as well

2016-02-25 Thread Cong Wang
We saw qlen!=0 but backlog==0 on our production machine: qdisc htb 1: dev eth0 root refcnt 2 r2q 10 default 1 direct_packets_stat 0 ver 3.17 Sent 172680457356 bytes 222469449 pkt (dropped 0, overlimits 123575834 requeues 0) backlog 0b 72p requeues 0 The problem is we only count qlen for HTB q

[Patch net-next v3 0/4] net_sched: update backlog for hierarchical qdisc's

2016-02-25 Thread Cong Wang
For hierarchical qdisc like HTB, we currently only update its qlen but leave its backlog as zero: qdisc htb 1: dev eth0 root refcnt 2 r2q 10 default 1 direct_packets_stat 0 ver 3.17 Sent 172680457356 bytes 222469449 pkt (dropped 0, overlimits 123575834 requeues 0) backlog 0b 72p re

[Patch net-next v3 4/4] sch_dsmark: update backlog as well

2016-02-25 Thread Cong Wang
Similarly, we need to update backlog too when we update qlen. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/sch_dsmark.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/sched/sch_dsmark.c b/net/sched/sch_dsmark.c index cfddb1c..d0dff0c 100644 --- a/net/sched/sch_dsmark.

Re: [net-next PATCH v2 1/5] introduce IFE action

2016-02-25 Thread Jamal Hadi Salim
On 16-02-25 04:46 PM, Daniel Borkmann wrote: On 02/25/2016 01:20 PM, Jamal Hadi Salim wrote: Let me think about it. Likely it will be subsequent patches - I just want to get this set out first. Yes, I mean one of the key motivation was "[...] to horizontally scale packet processing at scope

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-25 Thread Jamal Hadi Salim
On 16-02-25 04:34 PM, Daniel Borkmann wrote: On 02/25/2016 01:23 PM, Jamal Hadi Salim wrote: On 16-02-24 12:48 PM, Daniel Borkmann wrote: On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: [...] Drivers do set the hash. My use case is slightly different. I have a NIC which has an embedded cavium

Re: [PATCH net-next 0/6] qed*: Driver updates

2016-02-25 Thread David Miller
From: Yuval Mintz Date: Wed, 24 Feb 2016 16:52:44 +0200 > Usually I try to provide a sensible description of the patch set even if > it lacks a general 'motif', but this simply contains several small, > unrelated and self-explenatory tweaks and additions. Series applied, however I really wo

[PATCH] mt7601u: do not free dma_buf when ivp allocation fails

2016-02-25 Thread Colin King
From: Colin Ian King If the allocation of ivp fails the error handling attempts to free an uninitialized dma_buf; this data structure just contains garbage on the stack, so the freeing will cause issues when the urb, buf and dma fields are cleaned. Fix this by handling the ivp check and Signed-o

Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-02-25 Thread Sergei Shtylyov
On 02/21/2016 10:16 PM, Sergei Shtylyov wrote: [...] From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (descriptor, error, management) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) This pat

Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic

2016-02-25 Thread David Miller
From: f6bvp Date: Wed, 24 Feb 2016 17:53:11 +0100 > @@ -863,6 +863,11 @@ int rose_route_frame(struct sk_buff *skb, ax25_cb > *ax25) First of all this patch was corrupted by your email client. > int res = 0; > char buf[11]; > > + if (ax25 == NULL) { > + print

Re: [net-next PATCH v2 1/5] introduce IFE action

2016-02-25 Thread John Fastabend
On 16-02-25 01:46 PM, Daniel Borkmann wrote: > On 02/25/2016 01:20 PM, Jamal Hadi Salim wrote: >> On 16-02-24 12:37 PM, Daniel Borkmann wrote: >>> On 02/23/2016 01:49 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim >>> [...] +static const struct nla_policy ife_policy[TCA_IFE_MAX + 1]

Re: [PATCH net-next] tipc: fix null deref crash in compat config path

2016-02-25 Thread David Miller
From: Florian Westphal Date: Wed, 24 Feb 2016 17:20:17 +0100 > msg.dst_sk needs to be set up with a valid socket because some callbacks > later derive the netns from it. > > Fixes: 263ea09084d172d ("Revert "genl: Add genlmsg_new_unicast() for unicast > message allocation") > Reported-by: Jon Ma

Re: [PATCH net-next 1/1] tipc: fix crash during node removal

2016-02-25 Thread David Miller
From: Jon Maloy Date: Wed, 24 Feb 2016 11:10:48 -0500 > When the TIPC module is unloaded, we have identified a race condition > that allows a node reference counter to go to zero and the node instance > being freed before the node timer is finished with accessing it. This > leads to occasional cr

Re: [PATCH net-next 1/1] tipc: eliminate risk of finding to-be-deleted node instance

2016-02-25 Thread David Miller
From: Jon Maloy Date: Wed, 24 Feb 2016 11:00:19 -0500 > Although we have never seen it happen, we have identified the > following problematic scenario when nodes are stopped and deleted: > > CPU0:CPU1: > > tipc_node_xxx() //ref == 1

Re: [net-next v2 00/15][pull request] 1GbE Intel Wired LAN Driver Updates 2016-02-24

2016-02-25 Thread Jeff Kirsher
On Thu, 2016-02-25 at 09:45 +0200, Or Gerlitz wrote: > On Thu, Feb 25, 2016 at 4:14 AM, Jeff Kirsher > wrote: > > v2: Dropped patches 6-10 in the original series.  Patch 6-7 added > support > > for character device for AVB and based on community feedback, > we do not > > want to do this. 

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread John Fastabend
On 16-02-25 04:56 AM, Jamal Hadi Salim wrote: > On 16-02-24 11:04 PM, John Fastabend wrote: >> On 16-02-24 05:31 AM, Jamal Hadi Salim wrote: > >> I think this is absolutely necessary not only for performance of >> reporting the rules back to software but if we don't do it generically >> the driver

Re: [patch net-next v2 0/9] Introduce devlink interface and first drivers to use it

2016-02-25 Thread Hannes Frederic Sowa
On 25.02.2016 22:12, Jiri Pirko wrote: Thu, Feb 25, 2016 at 09:44:43PM CET, han...@stressinduktion.org wrote: On 25.02.2016 21:12, David Miller wrote: From: Jiri Pirko Date: Tue, 23 Feb 2016 16:51:25 +0100 There a is need for some userspace API that would allow to expose things that are not

Re: [PATCH 3/3] 3c59x: Use setup_timer()

2016-02-25 Thread David Miller
From: Amitoj Kaur Chawla Date: Wed, 24 Feb 2016 19:28:19 +0530 > Convert a call to init_timer and accompanying intializations of > the timer's data and function fields to a call to setup_timer. > > The Coccinelle semantic patch that fixes this problem is > as follows: > > // > @@ > expression

Re: [PATCH] netxen: Use kobj_to_dev()

2016-02-25 Thread David Miller
From: Amitoj Kaur Chawla Date: Wed, 24 Feb 2016 20:09:38 +0530 > Introduce the use of kobj_to_dev() helper function instead of open > coding it with container_of() > > The Coccinelle semantic patch used to make this change is as follows: > > // > @@ > expression a; > symbol kobj; > @@ > - conta

Re: [PATCH 1/3] net: tulip: Use setup_timer()

2016-02-25 Thread David Miller
From: Amitoj Kaur Chawla Date: Wed, 24 Feb 2016 19:27:49 +0530 > Convert a call to init_timer and accompanying intializations of > the timer's data and function fields to a call to setup_timer. > > The Coccinelle semantic patch that fixes this problem is > as follows: > > // > @@ > expression

Re: [PATCH 2/3] forcedeth: Use setup_timer()

2016-02-25 Thread David Miller
From: Amitoj Kaur Chawla Date: Wed, 24 Feb 2016 19:28:01 +0530 > Convert a call to init_timer and accompanying intializations of > the timer's data and function fields to a call to setup_timer. > > The Coccinelle semantic patch that fixes this problem is > as follows: > > // > @@ > expression

Re: [patch net-next v2 0/9] Introduce devlink interface and first drivers to use it

2016-02-25 Thread Andy Gospodarek
On Thu, Feb 25, 2016 at 03:12:47PM -0500, David Miller wrote: > From: Jiri Pirko > Date: Tue, 23 Feb 2016 16:51:25 +0100 > > > There a is need for some userspace API that would allow to expose things > > that are not directly related to any device class like net_device of > > ib_device, but rathe

Re: [net-next PATCH v2 1/5] introduce IFE action

2016-02-25 Thread Daniel Borkmann
On 02/25/2016 01:20 PM, Jamal Hadi Salim wrote: On 16-02-24 12:37 PM, Daniel Borkmann wrote: On 02/23/2016 01:49 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim [...] +static const struct nla_policy ife_policy[TCA_IFE_MAX + 1] = { +[TCA_IFE_PARMS] = {.len = sizeof(struct tc_ife)}, +

[PATCH net-next] hv_netvsc: add ethtool support for set and get of settings

2016-02-25 Thread Simon Xiao
This patch allows the user to set and retrieve speed and duplex of the hv_netvsc device via ethtool. Example: $ ethtool eth0 Settings for eth0: ... Speed: Unknown! Duplex: Unknown! (255) ... $ ethtool -s eth0 speed 1000 duplex full $ ethtool eth0 Settings for eth0: ... Speed: 1000Mb/s

Re: [net-next PATCH 0/5] net_sched: Add support for IFE action

2016-02-25 Thread Daniel Borkmann
On 02/25/2016 01:23 PM, Jamal Hadi Salim wrote: On 16-02-24 12:48 PM, Daniel Borkmann wrote: On 02/24/2016 01:49 PM, Jamal Hadi Salim wrote: [...] Drivers do set the hash. My use case is slightly different. I have a NIC which has an embedded cavium processor. This thing strips off the TLV and

Re: [PATCH net 3/7] net/mlx5e: Fix soft lockup when HW Timestamping is enabled

2016-02-25 Thread David Miller
From: Saeed Mahameed Date: Wed, 24 Feb 2016 13:18:49 +0200 > From: Eran Ben Elisha > > Readers/Writers lock for SW timecounter was acquired without disabling > interrupts on local CPU. > > The problematic scenario: > * HW timestamping is enabled > * Timestamp overflow periodic service task is

Re: [PATCH] net: thunderx: Fix for Qset error due to CQ full

2016-02-25 Thread David Miller
From: sunil.kovv...@gmail.com Date: Wed, 24 Feb 2016 16:40:50 +0530 > From: Sunil Goutham > > On Thunderx pass 1.x and pass2 due to a HW errata default CQ > DROP_LEVEL of 0x80 is not sufficient to avoid CQ_WR_FULL Qset > error when packets are being received at >20Mpps resulting in > complete st

Re: [v2, 0/3] Add PTP support for ls1021a platform

2016-02-25 Thread David Miller
From: Yangbo Lu Date: Wed, 24 Feb 2016 17:26:53 +0800 > This patchset is to enable ptp support for ls1021a platform. The endianness > issue in gianfar driver and gianfar ptp driver must be fixed, and a 1588 > timer node must be added into dts. > > Changes for v2: > - Modified commit messag

Re: [PATCHv3] net: fix bridge multicast packet checksum validation

2016-02-25 Thread David Miller
From: Linus Lüssing Date: Wed, 24 Feb 2016 04:21:42 +0100 > We need to update the skb->csum after pulling the skb, otherwise > an unnecessary checksum (re)computation can ocure for IGMP/MLD packets > in the bridge code. Additionally this fixes the following splats for > network devices / bridge p

Re: [PATCH net v4] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

2016-02-25 Thread David Miller
From: Chunhao Lin Date: Wed, 24 Feb 2016 14:18:42 +0800 > There will be a log spam when there is no cable plugged. Please refer to > following links. https://bugzilla.kernel.org/show_bug.cgi?id=104351 > https://bugzilla.kernel.org/show_bug.cgi?id=107421 > > This issue is caused by runtime power

Re: [PATCH net] Propagate MAC address changes to VLANs

2016-02-25 Thread David Miller
From: Mike Manning Date: Tue, 23 Feb 2016 20:56:31 + > --- a/net/8021q/vlan.c > +++ b/net/8021q/vlan.c > @@ -293,15 +293,15 @@ static void vlan_sync_address(struct net > > /* vlan address was different from the old address and is equal to > * the new address */ > -if (!ether_a

Re: [PATCH 1/2] net: qca_spi: Don't clear IFF_BROADCAST

2016-02-25 Thread David Miller
From: Stefan Wahren Date: Tue, 23 Feb 2016 19:23:23 + > Currently qcaspi_netdev_setup accidentally clears IFF_BROADCAST. > So fix this by keeping the flags from ether_setup. > > Reported-by: Michael Heimpold > Signed-off-by: Stefan Wahren > Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet

Re: header conflict introduced by change to netfilter_ipv4/ip_tables.h

2016-02-25 Thread Thomas Graf
On 01/06/16 at 09:20am, Stephen Hemminger wrote: > This commit breaks compilation of iproute2 with net-next. > > commit 1ffad83dffd675cd742286ae82dca7d746cb0da8 > Author: Mikko Rapeli > Date: Thu Oct 15 07:56:30 2015 +0200 > > netfilter: fix include files for compilation > > Add m

Re: [PATCH 2/2] net: qca_spi: clear IFF_TX_SKB_SHARING

2016-02-25 Thread David Miller
From: Stefan Wahren Date: Tue, 23 Feb 2016 19:23:24 + > ether_setup sets IFF_TX_SKB_SHARING but this is not supported by > qca_spi as it modifies the skb on xmit. > > Signed-off-by: Stefan Wahren > Fixes: 291ab06ecf67 (net: qualcomm: new Ethernet over SPI driver for QCA7000) Applied and qu

Re: [patch net-next v2 0/9] Introduce devlink interface and first drivers to use it

2016-02-25 Thread Jiri Pirko
Thu, Feb 25, 2016 at 09:44:43PM CET, han...@stressinduktion.org wrote: >On 25.02.2016 21:12, David Miller wrote: >>From: Jiri Pirko >>Date: Tue, 23 Feb 2016 16:51:25 +0100 >> >>>There a is need for some userspace API that would allow to expose things >>>that are not directly related to any device

Re: [PATCH 1/1] phy: marvell: Fix 88E1510 initialization

2016-02-25 Thread David Miller
From: Clemens Gruber Date: Tue, 23 Feb 2016 20:16:58 +0100 > A bug was introduced in the merge commit b633353115e3 ("Merge > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net") > The generic marvell_config_init (and therefore marvell_of_reg_init) is > not called anymore for the Marvell 88E1

Re: [PATCH] socket.7: Document some BPF-related socket options

2016-02-25 Thread Alexei Starovoitov
On Thu, Feb 25, 2016 at 03:27:45PM -0500, Craig Gallek wrote: > From: Craig Gallek > > Document the behavior and the first kernel version for each of the > following socket options: > SO_ATTACH_FILTER > SO_ATTACH_BPF > SO_ATTACH_REUSEPORT_CBPF > SO_ATTACH_REUSEPORT_EBPF > SO_DETACH_FILTER > SO_DE

Re: header conflict introduced by change to netfilter_ipv4/ip_tables.h

2016-02-25 Thread Daniel Borkmann
On 02/04/2016 08:13 AM, Josh Boyer wrote: On Thu, Jan 7, 2016 at 2:15 PM, Mikko Rapeli wrote: On Thu, Jan 07, 2016 at 10:30:40AM -0800, Stephen Hemminger wrote: On Thu, 7 Jan 2016 07:29:50 + Mikko Rapeli wrote: On Wed, Jan 06, 2016 at 09:20:07AM -0800, Stephen Hemminger wrote: This comm

Re: Sending short raw packets using sendmsg() broke

2016-02-25 Thread Willem de Bruijn
> Commit 9c7077622dd9174 added a check, ll_header_truncated(), which requires > that a packet transmitted using sendmsg() with PF_PACKET, SOCK_RAW must be > longer than dev->hard_header_len. > > https://github.com/torvalds/linux/commit/9c7077622dd9174 > https://github.com/torvalds/linux/blob/master

Re: [patch net-next v2 0/9] Introduce devlink interface and first drivers to use it

2016-02-25 Thread Hannes Frederic Sowa
On 25.02.2016 21:12, David Miller wrote: From: Jiri Pirko Date: Tue, 23 Feb 2016 16:51:25 +0100 There a is need for some userspace API that would allow to expose things that are not directly related to any device class like net_device of ib_device, but rather chip-wide/switch-ASIC-wide stuff.

Re: [PATCH RFC 3/3] net: convert tc_u32 to use the intermediate representation

2016-02-25 Thread John Fastabend
On 16-02-25 09:37 AM, Pablo Neira Ayuso wrote: > This patch moves the u32 parser from the ixgbe that John has made to the > core u32. This parser has been adapted to build the intermediate > representation. > > To store the parsing information, this patch introduces a parse table > object, one per

Re: [PATCH net] net: vrf: Remove direct access to skb->data

2016-02-25 Thread David Miller
From: David Ahern Date: Tue, 23 Feb 2016 10:10:26 -0800 > Nik pointed that the VRF driver should be using skb_header_pointer > instead of accessing skb->data and bits beyond directly which can > be garbage. > > Cc: Nikolay Aleksandrov > Signed-off-by: David Ahern > --- > Dave: This should go i

[PATCH] socket.7: Document some BPF-related socket options

2016-02-25 Thread Craig Gallek
From: Craig Gallek Document the behavior and the first kernel version for each of the following socket options: SO_ATTACH_FILTER SO_ATTACH_BPF SO_ATTACH_REUSEPORT_CBPF SO_ATTACH_REUSEPORT_EBPF SO_DETACH_FILTER SO_DETACH_BPF Signed-off-by: Craig Gallek --- man7/socket.7 | 104 ++

Re: Sending short raw packets using sendmsg() broke

2016-02-25 Thread David Miller
From: Heikki Hannikainen Date: Thu, 25 Feb 2016 21:36:07 +0200 (EET) > Commit 9c7077622dd9174 added a check, ll_header_truncated(), which > requires that a packet transmitted using sendmsg() with PF_PACKET, > SOCK_RAW must be longer than dev->hard_header_len. Fixed by: commit 880621c2605b82eb5a

Re: [PATCH net 1/5] ppp: lock ppp structure before modifying mru in ppp_ioctl()

2016-02-25 Thread David Miller
From: Guillaume Nault Date: Thu, 25 Feb 2016 20:16:55 +0100 > Understood. Just to be sure, does patch #2 falls under lack of > demonstration? Or should I repost it separately? Please repost it if you feel this way, with the race and corruption possibility explained in detail in the commit log me

Re: [PATCH net-next 0/5] vxlan: consolidate rx handling

2016-02-25 Thread David Miller
From: Jiri Benc Date: Tue, 23 Feb 2016 18:02:54 +0100 > Currently, vxlan_rcv is just called at the end of vxlan_udp_encap_recv, > continuing the rx processing where vxlan_udp_encap_recv left it. There's no > clear border between those two functions. This patchset moves > vxlan_udp_encap_recv and

Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default

2016-02-25 Thread David Miller
From: Tom Herbert Date: Tue, 23 Feb 2016 08:47:30 -0800 > Right, GRO should probably not coalesce packets with non-zero IP > identifiers due to the loss of information. If they are monotonically increasing, which is the only case worth caring about, it absolutely should. Because that can be don

Re: [patch net-next v2 0/9] Introduce devlink interface and first drivers to use it

2016-02-25 Thread David Miller
From: Jiri Pirko Date: Tue, 23 Feb 2016 16:51:25 +0100 > There a is need for some userspace API that would allow to expose things > that are not directly related to any device class like net_device of > ib_device, but rather chip-wide/switch-ASIC-wide stuff. > > Use cases: > 1) get/set of port t

Re: [PATCH] can: ems_usb: Fix possible tx overflow

2016-02-25 Thread David Miller
From: Marc Kleine-Budde Date: Mon, 22 Feb 2016 13:18:38 +0100 > David, I can send a patch to clean up the coding style. Do you want it > for net or via net-next? net-next is fine.

Sending short raw packets using sendmsg() broke

2016-02-25 Thread Heikki Hannikainen
Hi, Commit 9c7077622dd9174 added a check, ll_header_truncated(), which requires that a packet transmitted using sendmsg() with PF_PACKET, SOCK_RAW must be longer than dev->hard_header_len. https://github.com/torvalds/linux/commit/9c7077622dd9174 https://github.com/torvalds/linux/blob/master/

Re: [PATCH] appletalk: Pass IP-over-DDP packets through when 'ipddp0' interface is not present

2016-02-25 Thread David Miller
From: Adam Seering Date: Tue, 23 Feb 2016 09:19:13 -0500 > Let userspace programs transmit and receive raw IP-over-DDP packets > with a kernel where "ipddp" was compiled as a module but is not loaded > (so no "ipddp0" network interface is exposed). This makes the "module > is not loaded" behavio

  1   2   >