Re: [PATCH net-next v1 2/2] tipc: fix link priority propagation

2016-02-05 Thread David Miller
From: Richard Alpe Date: Mon, 1 Feb 2016 08:19:57 +0100 > Currently link priority changes isn't handled for active links. In > this patch we resolve this by changing our priority if the peer passes > a valid priority in a state message. > > Reviewed-by: Jon Maloy > Signed-off-by: Richard Alpe

Re: [PATCH net-next v1 1/2] tipc: fix link attribute propagation bug

2016-02-05 Thread David Miller
From: Richard Alpe Date: Mon, 1 Feb 2016 08:19:56 +0100 > Changing certain link attributes (link tolerance and link priority) > from the TIPC management tool is supposed to automatically take > effect at both endpoints of the affected link. > > Currently the media address is not instantiated for

Re: [PATCH net 0/4] net: phy: bcm7xxx 40nm PHY fixes

2016-02-05 Thread David Miller
From: Florian Fainelli Date: Fri, 5 Feb 2016 17:25:50 -0800 > On 03/02/16 13:13, Florian Fainelli wrote: >> Hi David, >> >> Here is a collection of fixes for the 40nm Ethernet PHY supported >> by the 7xxx PHY driver, please also queue these fixes for stable. >> >> Let me know if you think patch

Re: [net-next 00/20][pull request] 40GbE Intel Wired LAN Driver Updates 2016-02-03

2016-02-05 Thread David Miller
From: Jeff Kirsher Date: Thu, 4 Feb 2016 03:48:51 -0800 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff.

Re: [PATCH net v4] r8169: Add bios support.

2016-02-05 Thread David Miller
From: Corcodel Marian Date: Sat, 6 Feb 2016 08:31:26 +0200 > @@ -8262,8 +8262,9 @@ static int rtl_init_one(struct pci_dev *pdev, const > struct pci_device_id *ent) > rtl_hw_reset(tp); > > rtl_ack_events(tp, 0x); > - > +#ifndef CONFIG_BIOS_SUPPORT > pci_set_master(pdev);

[PATCH net v4] r8169: Add bios support.

2016-02-05 Thread Corcodel Marian
This patch help do not compile functions relative to setting latency, setting bus master wich have provided on bios.Davem says "The chip can be used on systems without a BIOS and that should still work." Signed-off-by: Corcodel Marian --- drivers/Kconfig | 4 dr

[PATCH net v4] r8169: Completition on Enable bios support.

2016-02-05 Thread Corcodel Marian
Signed-off-by: Corcodel Marian --- drivers/net/ethernet/realtek/r8169.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 2e83059..1d119a6 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/eth

Re: [PATCH net-next 7/7] soreuseport: BPF selection functional test for TCP

2016-02-05 Thread Alexei Starovoitov
On Thu, Feb 04, 2016 at 10:35:18AM -0500, Craig Gallek wrote: > From: Craig Gallek > > Unfortunately the existing test relied on packet payload in order to > map incoming packets to sockets. In order to get this to work with TCP, > TCP_FASTOPEN needed to be used. > > Since the fast open path is

[PATCH net-next 2/2] tcp/dccp: better use of ephemeral ports in bind()

2016-02-05 Thread Eric Dumazet
Implement strategy used in __inet_hash_connect() in opposite way : Try to find a candidate using odd ports, then fallback to even ports. We no longer disable BH for whole traversal, but one bucket at a time. We also use cond_resched() to yield cpu to other tasks if needed. I removed one indentat

[PATCH net-next 1/2] tcp/dccp: better use of ephemeral ports in connect()

2016-02-05 Thread Eric Dumazet
In commit 07f4c90062f8 ("tcp/dccp: try to not exhaust ip_local_port_range in connect()"), I added a very simple heuristic, so that we got better chances to use even ports, and allow bind() users to have more available slots. It gave nice results, but with more than 200,000 TCP sessions on a typica

[PATCH net-next 0/2] tcp/dccp: better use of ephemeral ports

2016-02-05 Thread Eric Dumazet
Big servers have bloated bind table, making very hard to succeed ephemeral port allocations, without special containers/namespace tricks. This patch series extends the strategy added in commit 07f4c90062f8 ("tcp/dccp: try to not exhaust ip_local_port_range in connect()"). Since ports used by con

[PATCH] dscc4: Undefined signed int shift

2016-02-05 Thread Michael McConville
My analysis in the below mail applies, although the second part is unnecessary because i isn't used in arithmetic operations here: https://marc.info/?l=openbsd-tech&m=145377854103866&w=2 Thanks for your time. Signed-off-by: Michael McConville --- drivers/net/wan/dscc4.c | 2 +- 1 file changed,

[PATCH nf-next v7 4/7] openvswitch: Find existing conntrack entry after upcall.

2016-02-05 Thread Jarno Rajahalme
Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace upcall. ovs_ct_find_exis

[PATCH nf-next v7 3/7] openvswitch: Update the CT state key only after nf_conntrack_in().

2016-02-05 Thread Jarno Rajahalme
Only a successful nf_conntrack_in() call can effect a connection state change, so if suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 9 ++--- 1 file changed

[PATCH nf-next v7 7/7] openvswitch: Interface with NAT.

2016-02-05 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new (non-committed

[PATCH nf-next v7 5/7] openvswitch: Handle NF_REPEAT in conntrack action.

2016-02-05 Thread Jarno Rajahalme
Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/con

[PATCH nf-next v7 0/7] openvswitch: NAT support.

2016-02-05 Thread Jarno Rajahalme
This series adds NAT support to openvswitch kernel module. A few changes are needed to the netfilter code to facilitate this (patches 1-2/7). Patches 3-6 make the openvswitch kernel module ready for the patch 7 that adds the NAT support by calling into netfilter NAT code from the openvswitch conn

[PATCH nf-next v7 6/7] openvswitch: Delay conntrack helper call for new connections.

2016-02-05 Thread Jarno Rajahalme
There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno Rajaha

[PATCH nf-next v7 2/7] netfilter: Allow calling into nat helper without skb_dst.

2016-02-05 Thread Jarno Rajahalme
NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar Signed-of

[PATCH nf-next v7 1/7] netfilter: Remove IP_CT_NEW_REPLY definition.

2016-02-05 Thread Jarno Rajahalme
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +--- net/openvswitch/conntrack.c

Re: [PATCH net 0/4] net: phy: bcm7xxx 40nm PHY fixes

2016-02-05 Thread Florian Fainelli
On 03/02/16 13:13, Florian Fainelli wrote: > Hi David, > > Here is a collection of fixes for the 40nm Ethernet PHY supported > by the 7xxx PHY driver, please also queue these fixes for stable. > > Let me know if you think patch 4 is too much of a cleanup to be taken > as a fix. David, if you hav

Re: [PATCH net-next V2 7/8] net: fec: don't transfer ownership until descriptor write is complete

2016-02-05 Thread Joshua Clayton
On Fri, 5 Feb 2016 14:52:49 -0700 Troy Kisky wrote: > If you don't own it, you shouldn't write to it. > > Signed-off-by: Troy Kisky > --- > drivers/net/ethernet/freescale/fec_main.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/f

[PATCH 17/30] rapidio/rionet: add locking into add/remove device

2016-02-05 Thread Alexandre Bounine
Add spinlock protection when handling list of connected peers and ability to handle new peer device addition after the RIONET device was open. Before his update RIONET was sending JOIN requests only when it have been opened, peer devices added later have been missing from this process. Signed-off

[net-next PATCH 08/10] udp: Clean up the use of flags in UDP segmentation offload

2016-02-05 Thread Alexander Duyck
This patch goes though and cleans up the logic related to several of the control flags used in UDP segmentation. Specifically the use of dont_encap isn't really needed as we can just check the skb for CHECKSUM_PARTIAL and if it isn't set then we don't need to update the internal headers. As such

[net-next PATCH 09/10] udp: Use uh->len instead of skb->len to compute checksum in segmentation

2016-02-05 Thread Alexander Duyck
The segmentation code was having to do a bunch of work to pull the skb->len and strip the udp header offset before the value could be used to adjust the checksum. Instead of doing all this work we can just use the value that goes into uh->len since that is the correct value with the correct byte o

[net-next PATCH 10/10] net: Allow tunnels to use inner checksum offloads with outer checksums needed

2016-02-05 Thread Alexander Duyck
This patch enables us to use inner checksum offloads if provided by hardware with outer checksums computed by software. It basically reduces encap_hdr_csum to an advisory flag for now, but based on the fact that SCTP may be getting segmentation support before long I thought we may want to keep it

[PATCH 02/30] rapidio/rionet: add capability to change MTU

2016-02-05 Thread Alexandre Bounine
From: Aurelien Jacquiot Replace default Ethernet-specific routine by the custom one to allow setting of larger MTU supported by RapidIO messaging (max RIO packet size is 4096 bytes). Signed-off-by: Aurelien Jacquiot Signed-off-by: Alexandre Bounine Cc: Matt Porter Cc: Andre van Herk Cc: linu

[PATCH 11/30] rapidio/rionet: add shutdown event handling

2016-02-05 Thread Alexandre Bounine
Add shutdown notification handler which terminates active connections with remote RapidIO nodes. This prevents remote nodes from sending packets to the powered off node and eliminates hardware error events on remote nodes. Signed-off-by: Alexandre Bounine Cc: Matt Porter Cc: Aurelien Jacquiot C

[PATCH 01/30] rapidio/rionet: fix deadlock on SMP

2016-02-05 Thread Alexandre Bounine
From: Aurelien Jacquiot Fix deadlocking during concurrent receive and transmit operations on SMP platforms caused by the use of incorrect lock: on transmit 'tx_lock' spinlock should be used instead of 'lock' which is used for receive operation. This fix is applicable to kernel versions starting

[PATCH 18/30] rapidio/rionet: add mport removal handling

2016-02-05 Thread Alexandre Bounine
Add handling of a local mport device removal. RIONET driver registers itself as class interface that supports only removal notification, 'add_device' callback is not provided because RIONET network device can be initialized only after enumeration is completed and the existing method (using remote

[net-next PATCH 06/10] gre: Use GSO flags to determine csum need instead of GRE flags

2016-02-05 Thread Alexander Duyck
This patch updates the gre checksum path to follow something much closer to the UDP checksum path. By doing this we can avoid needing to do as much header inspection and can just make use of the fields we were already reading in the sk_buff structure. Signed-off-by: Alexander Duyck --- net/ipv4

[net-next PATCH 07/10] gre: Use inner_proto to obtain inner header protocol

2016-02-05 Thread Alexander Duyck
Instead of parsing headers to determine the inner protocol we can just pull the value from inner_proto. Signed-off-by: Alexander Duyck --- net/ipv4/gre_offload.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/ipv4/gre_offload.c b/net/ipv4/gre_offload.c index c15

[net-next PATCH 05/10] net: Move skb_has_shared_frag check out of GRE code and into segmentation

2016-02-05 Thread Alexander Duyck
The call skb_has_shared_frag is used in the GRE path and skb_checksum_help to verify that no frags can be modified by an external entity. This check really doesn't belong in the GRE path but in the skb_segment function itself. This way any protocol that might be segmented will be performing this

[net-next PATCH 02/10] net: Move GSO csum into SKB_GSO_CB

2016-02-05 Thread Alexander Duyck
This patch moves the checksum maintained by GSO out of skb->csum and into the GSO context block in order to allow for us to work on outer checksums while maintaining the inner checksum offsets in the case of the inner checksum being offloaded, while the outer checksums will be computed. While upda

[net-next PATCH 04/10] net: Store checksum result for offloaded GSO checksums

2016-02-05 Thread Alexander Duyck
This patch makes it so that we can offload the checksums for a packet up to a certain point and then begin computing the checksums via software. Setting this up is fairly straight forward as all we need to do is reset the values stored in csum and csum_start for the GSO context block. One complica

[net-next PATCH 03/10] net: Update remote checksum segmentation to support use of GSO checksum

2016-02-05 Thread Alexander Duyck
This patch addresses two main issues. First in the case of remote checksum offload we were avoiding dealing with scatter-gather issues. As a result it would be possible to assemble a series of frames that used frags instead of being linearized as they should have if remote checksum offload was en

[net-next PATCH 01/10] net: Drop unecessary enc_features variable from tunnel segmentation functions

2016-02-05 Thread Alexander Duyck
The enc_features variable isn't necessary since features isn't used anywhere after we create enc_features so instead just use a destructive AND on features itself and save ourselves the variable declaration. Signed-off-by: Alexander Duyck --- net/ipv4/gre_offload.c |6 +++--- net/ipv4/udp_of

[net-next PATCH 00/10] Add GSO support for outer checksum w/ inner checksum offloads

2016-02-05 Thread Alexander Duyck
This patch series updates the existing segmentation offload code for tunnels to make better use of existing and updated GSO checksum computation. This is done primarily through two mechanisms. First we maintain a separate checksum in the GSO context block of the sk_buff. This allows us to mainta

Re: [net-next PATCH 01/10] net: Drop unecessary enc_features variable from tunnel segmentation functions

2016-02-05 Thread Alexander Duyck
Please ignore this patch. I am re-sending series with cover page. Sorry for the noise. - Alex

[net-next PATCH 01/10] net: Drop unecessary enc_features variable from tunnel segmentation functions

2016-02-05 Thread Alexander Duyck
The enc_features variable isn't necessary since features isn't used anywhere after we create enc_features so instead just use a destructive AND on features itself and save ourselves the variable declaration. Signed-off-by: Alexander Duyck --- net/ipv4/gre_offload.c |6 +++--- net/ipv4/udp_of

[PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

2016-02-05 Thread Andrew F. Davis
The TI TLK10x Ethernet PHYs are similar in the interrupt relevant registers and so are compatible with the DP83848x devices already supported. Add these and re-order code to support additional PHYs. Signed-off-by: Andrew F. Davis --- drivers/net/phy/dp83848.c | 89 ---

Re: [net-next] igb: assume MSI-X interrupts during initialization

2016-02-05 Thread Stefan Assmann
On 02/05/2016 10:24 PM, Laine Stump wrote: Stefan, I have an AMD 990FX system with an Intel 82576 card that could not successfully boot with any kernel starting somewhere prior to 4.2, but does boot properly in 4.4+. After a lot of time bisecting, I found that this patch, when applied to kernel

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Eric Dumazet
On Fri, 2016-02-05 at 21:44 +, Rainer Weikusat wrote: > The present unix_stream_read_generic contains various code sequences of > the form > > err = -EDISASTER; > if () > goto out; > > This has the unfortunate side effect of possibly causing the error code > to bleed through to the fina

[PATCH] af_unix: Don't use continue to re-execute unix_stream_read_generic loop

2016-02-05 Thread Rainer Weikusat
The unix_stream_read_generic function tries to use a continue statement to restart the receive loop after waiting for a message. This may not work as intended as the caller might use a recvmsg call to peek at control messages without specifying a message buffer. If this was the case, the continue w

Re: [PATCH v2 net-next 0/4] batch calls to fib_flush and arp_ifdown

2016-02-05 Thread Salam Noureddine
Forgot to mention the rtnl_lock hold time gain with these changes. I got the following benchmark results on one of our switches. Without this patch, deleting 1k interfaces with 100k routes in the fib held the rtnl_lock for 13 seconds. With the patch, rtnl_lock hold time went down to 5 seconds. The

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-02-05 Thread David Miller
From: Robert Jarzmik Date: Fri, 05 Feb 2016 22:44:56 +0100 > Apart from Alberto who answered he cannot test it by lack of hardware, the > others didn't answer. > > So how can I move forward ? Would you want me to amend the KConfig to add a > "&& > !ARCH_PXA" on the "depend" line ? Please just

[PATCH] af_unix: Don't set err in unix_stream_read_generic unless there was an error

2016-02-05 Thread Rainer Weikusat
The present unix_stream_read_generic contains various code sequences of the form err = -EDISASTER; if () goto out; This has the unfortunate side effect of possibly causing the error code to bleed through to the final out: return copied ? : err; and then to be wrongly returned if

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Rainer Weikusat
Rainer Weikusat writes: > Joseph Salisbury writes: >> On 02/05/2016 02:59 PM, Rainer Weikusat wrote: > > [recvmsg w/o iovecs returning ENOTSUP for CMSG requests] [...] > There are more problems wrt handling control-message only reads in this > code. [...] > it will return without an error but

[PATCH net-next V2 0/8] net: fec: cleanup/fixes

2016-02-05 Thread Troy Kisky
V2 is a rebase on top of johannes endian-safe patch and is only the 1st eight patches. The testing for this series was done on a nitrogen6x. The base commit was commit b45efa30a626e915192a6c548cd8642379cd47cc Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net Testing showed no chan

[PATCH net-next V2 5/8] net: fec: add variable reg_desc_active to speed things up

2016-02-05 Thread Troy Kisky
There is no need for complex macros every time we need to activate a queue. Also, no need to call skb_get_queue_mapping when we already know which queue it is using. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 7 + drivers/net/ethernet/freescale/fec_main.c | 44

[PATCH net-next V2 3/8] net: fec: fix fec_enet_get_free_txdesc_num

2016-02-05 Thread Troy Kisky
When first initialized, cur_tx points to the 1st entry in the queue, and dirty_tx points to the last. At this point, fec_enet_get_free_txdesc_num will return tx_ring_size -2. If tx_ring_size -2 entries are now queued, then fec_enet_get_free_txdesc_num should return 0, but it returns tx_ring_size in

[PATCH net-next V2 8/8] net: fec: improve error handling

2016-02-05 Thread Troy Kisky
Unmap initial buffer on error. Don't free skb until it has been unmapped. Move cbd_bufaddr assignment closer to the mapping function. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/ne

[PATCH net-next V2 4/8] net: fec: add struct bufdesc_prop

2016-02-05 Thread Troy Kisky
This reduces code and gains speed. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 29 ++- drivers/net/ethernet/freescale/fec_main.c | 288 -- 2 files changed, 132 insertions(+), 185 deletions(-) diff --git a/drivers/net/ethernet/freescale/

[PATCH net-next V2 7/8] net: fec: don't transfer ownership until descriptor write is complete

2016-02-05 Thread Troy Kisky
If you don't own it, you shouldn't write to it. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index

[PATCH net-next V2 6/8] net: fec: don't disable FEC_ENET_TS_TIMER interrupt

2016-02-05 Thread Troy Kisky
Only the interrupt routine processes this condition. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 1 + drivers/net/ethernet/freescale/fec_main.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/

[PATCH net-next V2 2/8] net: fec: fix rx error counts

2016-02-05 Thread Troy Kisky
On an overrun, the other flags are not valid, so don't check them. Also, don't pass bad frames up the stack. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 36 +-- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/drivers/net/

[PATCH net-next V2 1/8] net: fec: stop the "rcv is not +last, " error messages

2016-02-05 Thread Troy Kisky
Setting the FTRL register will stop the fec from trying to use multiple receive buffers. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 1 + drivers/net/ethernet/freescale/fec_main.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/f

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Rainer Weikusat
The present unix_stream_read_generic contains various code sequences of the form err = -EDISASTER; if () goto out; This has the unfortunate side effect of possibly causing the error code to bleed through to the final out: return copied ? : err; and then to be wrongly returned if

Re: [PATCH] net: smc911x: convert pxa dma to dmaengine

2016-02-05 Thread Robert Jarzmik
Robert Jarzmik writes: > David Miller writes: > >> From: Robert Jarzmik >> Date: Mon, 30 Nov 2015 22:40:28 +0100 >> >>> Convert the dma transfers to be dmaengine based, now pxa has a dmaengine >>> slave driver. This makes this driver a bit more PXA agnostic. >>> >>> The driver was only compile

Re: gigaset: memory leak in gigaset_initcshw

2016-02-05 Thread Dmitry Vyukov
On Fri, Feb 5, 2016 at 7:36 PM, Paul Bolle wrote: > On vr, 2016-02-05 at 17:06 +0100, Paul Bolle wrote: >> If that would happen, then cs can be reused while the previous >> > cs->hw.ser is not freed yet. Just a guess. >> >> I'll have to ponder on that a bit, sorry. > > This is from the hit-the-cod

Re: [net-next] igb: assume MSI-X interrupts during initialization

2016-02-05 Thread Laine Stump
Stefan, I have an AMD 990FX system with an Intel 82576 card that could not successfully boot with any kernel starting somewhere prior to 4.2, but does boot properly in 4.4+. After a lot of time bisecting, I found that this patch, when applied to kernel 4.3.0, solves the problem (applying to 4

Re: Reply: [net] bonding: use return instead of goto

2016-02-05 Thread Jarod Wilson
On Fri, Feb 05, 2016 at 09:42:24AM +0800, 张胜举 wrote: > > On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > > > Replace 'goto' with 'return' to remove unnecessary check at label: > > > err_undo_flags. > > > > I think you're going to have to explain how you came to the conclusion > >

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Rainer Weikusat
Joseph Salisbury writes: > On 02/05/2016 02:59 PM, Rainer Weikusat wrote: [recvmsg w/o iovecs returning ENOTSUP for CMSG requests] >> Funny little problem :-). The code using the interruptible lock cleared >> err as side effect hence the >> >> out: >> return copied ? : err; >> >> at the end

Re: [PATCH v2 2/4] lib: update single-char callers of strtobool

2016-02-05 Thread Kees Cook
On Fri, Feb 5, 2016 at 2:46 AM, David Laight wrote: > From: Kees Cook >> Sent: 04 February 2016 21:01 >> Some callers of strtobool were passing a pointer to unterminated strings. >> In preparation of adding multi-character processing to kstrtobool, update >> the callers to not pass single-characte

[PATCH v3 4/4] param: convert some "on"/"off" users to strtobool

2016-02-05 Thread Kees Cook
This changes several users of manual "on"/"off" parsing to use strtobool. Some side-effects: - these uses will now parse y/n/1/0 meaningfully too - the early_param uses will now bubble up parse errors Signed-off-by: Kees Cook Acked-by: Heiko Carstens Acked-by: Michael Ellerman Cc: x...@kernel.

[PATCH v3 3/4] lib: add "on"/"off" support to kstrtobool

2016-02-05 Thread Kees Cook
Add support for "on" and "off" when converting to boolean. Signed-off-by: Kees Cook --- v3: - add dropped descripion change, andy.shevchenko --- lib/kstrtox.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/lib/kstrtox.c b/lib/kstrtox.c index e8ba4a013e8

[PATCH v3 2/4] lib: update single-char callers of strtobool

2016-02-05 Thread Kees Cook
Some callers of strtobool were passing a pointer to unterminated strings. In preparation of adding multi-character processing to kstrtobool, update the callers to not pass single-character pointers, and switch to using the new kstrtobool_from_user helper where possible. Signed-off-by: Kees Cook C

[PATCH v3 0/4] lib: add "on" and "off" to strtobool

2016-02-05 Thread Kees Cook
This consolidates logic for handling "on"/"off" parsing for bools into the strtobool function, by way of moving it into kstrtobool (with helpers), and updating various callers. v3: - removed unused "base" argument - fixed missing description change - retained inverted __setup return values - remov

[PATCH v3 1/4] lib: move strtobool to kstrtobool

2016-02-05 Thread Kees Cook
Create the kstrtobool_from_user helper and moves strtobool logic into the new kstrtobool (matching all the other kstrto* functions). Provides an inline wrapper for existing strtobool callers. Signed-off-by: Kees Cook --- v3: - drop needless "base" argument, rasmus --- include/linux/kernel.h | 2

Re: [PATCH v2 1/4] lib: move strtobool to kstrtobool

2016-02-05 Thread Kees Cook
On Thu, Feb 4, 2016 at 3:55 PM, Rasmus Villemoes wrote: > On Thu, Feb 04 2016, Kees Cook wrote: > >> Create the kstrtobool_from_user helper and moves strtobool logic into >> the new kstrtobool (matching all the other kstrto* functions). Provides >> an inline wrapper for existing strtobool callers

[PATCH net-next 8/8] Documentation/networking: add checksum-offloads.txt to explain LCO

2016-02-05 Thread Edward Cree
Signed-off-by: Edward Cree --- Documentation/networking/00-INDEX | 2 + Documentation/networking/checksum-offloads.txt | 119 + include/linux/skbuff.h | 2 + 3 files changed, 123 insertions(+) create mode 100644 Documentation/netwo

[PATCH net-next 7/8] net: ip_tunnel: remove 'csum_help' argument to iptunnel_handle_offloads

2016-02-05 Thread Edward Cree
All users now pass false, so we can remove it, and remove the code that was conditional upon it. Signed-off-by: Edward Cree --- drivers/net/vxlan.c | 4 ++-- include/net/ip_tunnels.h| 3 +-- include/net/udp_tunnel.h| 3 +-- net/ipv4/fou.c | 4 ++-

[PATCH net-next 4/8] net: vxlan: enable local checksum offload

2016-02-05 Thread Edward Cree
Signed-off-by: Edward Cree --- drivers/net/vxlan.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 6543918..7299e5f 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1706,10 +1706,8 @@ static int

[PATCH net-next 6/8] net: gre: Implement LCO for GRE over IPv4

2016-02-05 Thread Edward Cree
Signed-off-by: Edward Cree --- net/ipv4/ip_gre.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 7c51c4e..9b31532 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -440,6 +440,17 @@ drop: return 0;

[PATCH net-next 5/8] fou: enable LCO in FOU and GUE

2016-02-05 Thread Edward Cree
Signed-off-by: Edward Cree --- net/ipv4/fou.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index 976f0dc..dac1874 100644 --- a/net/ipv4/fou.c +++ b/net/ipv4/fou.c @@ -774,7 +774,6 @@ static void fou_build_udp(struct sk_buff *sk

[PATCH net-next 3/8] net: enable LCO for udp_tunnel_handle_offloads() users

2016-02-05 Thread Edward Cree
The only protocol affected at present is Geneve. Signed-off-by: Edward Cree --- include/net/udp_tunnel.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h index cca2ad3..734c156 100644 --- a/include/net/udp_tunnel.h +++ b/in

[PATCH net-next 2/8] net: udp: always set up for CHECKSUM_PARTIAL offload

2016-02-05 Thread Edward Cree
If the dst device doesn't support it, it'll get fixed up later anyway by validate_xmit_skb(). Also, this allows us to take advantage of LCO to avoid summing the payload multiple times. Signed-off-by: Edward Cree --- net/ipv4/udp.c | 14 +- net/ipv6/ip6_checksum.c | 13 +--

[PATCH net-next 1/8] net: local checksum offload for encapsulation

2016-02-05 Thread Edward Cree
The arithmetic properties of the ones-complement checksum mean that a correctly checksummed inner packet, including its checksum, has a ones complement sum depending only on whatever value was used to initialise the checksum field before checksumming (in the case of TCP and UDP, this is the one

[PATCH v4 net-next 0/8] Local Checksum Offload

2016-02-05 Thread Edward Cree
Tested with VxLAN, GRE and FOU-IPIP tunnels. Not tested with GENEVE, because iproute2 doesn't support enabling checksums on GENEVE tunnels. Also tested VxLAN with IPv6 (as both inner and outer protocol). Changes from v3: * Fixed inverted checksum values introduced in v3. * Don't mangle zero ch

[PATCH 0/2] ethtool: {SG}RXFH indirection deficiency

2016-02-05 Thread Jacob Keller
This patch set adds a new ethtool operation .reset_rxfh_indir which is used by the core ethtool stack to properly indicate to a driver that the default RSS indirection table has been requested. Current behavior for notifying the default settings is indistinguishable from an explicit request. There

[PATCH 1/2] ethtool: support notifying drivers when user requests default rxfh table

2016-02-05 Thread Jacob Keller
Currently, userspace ethtool supports requesting the default indirection table by passing 0 as the indir_size. However, ops->set_rxfh does not distinguish between user requesting default via indir_size=0 and user requesting explicitly settings which are equivalent of the default. This causes probl

[PATCH 2/2] fm10k: correctly report error when changing number of channels

2016-02-05 Thread Jacob Keller
Previously, the fm10k driver would incorrectly allow changing the number of combined channels when this would have altered user configured RSS indirection table. With the new ethtool operation .reset_rxfh_indir, we are now able to correctly handle the changes to number of channels. This requires se

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Joseph Salisbury
On 02/05/2016 02:59 PM, Rainer Weikusat wrote: > Joseph Salisbury writes: >> Hi Rainer, >> >> A kernel bug report was opened against Ubuntu [0]. After a kernel >> bisect, it was found that reverting the following commit resolved this bug: >> >> commit 3822b5c2fc62e3de8a0f33806ff279fb7df92432 >> A

Re: [V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Rainer Weikusat
Joseph Salisbury writes: > Hi Rainer, > > A kernel bug report was opened against Ubuntu [0]. After a kernel > bisect, it was found that reverting the following commit resolved this bug: > > commit 3822b5c2fc62e3de8a0f33806ff279fb7df92432 > Author: Rainer Weikusat > Date: Wed Dec 16 20:09:25 20

[PATCH net-next 0/2] mpls: packet stats and ttl propagation config

2016-02-05 Thread Robert Shearman
This patch series implements new bits of mpls functionality: keeping statistics on packets as they pass through the box and allowing ttl propagation to be configured. Robert Shearman (2): mpls: packet stats mpls: allow TTL propagation to/from IP packets to be configured Documentation/network

[PATCH net-next 1/2] mpls: packet stats

2016-02-05 Thread Robert Shearman
Having MPLS packet stats is useful for observing network operation and for diagnosing network problems. In the absence of anything better, use RFCs for MIBs defining MPLS stats for guidance on the semantics of the stats to expose. RFC3813 details two per-interface packet stats that should be provid

[PATCH net-next 2/2] mpls: allow TTL propagation to/from IP packets to be configured

2016-02-05 Thread Robert Shearman
It is sometimes desirable to present an MPLS transport network as a single hop to traffic transiting it because it prevents confusion when diagnosing failures. An example of where confusion can be generated is when addresses used in the provider network overlap with addresses in the overlay network

[PATCH net] net: dsa: mv88e6xxx: do not leave reserved VLANs

2016-02-05 Thread Vivien Didelot
BRIDGE_VLAN_FILTERING automatically adds a newly bridged port to the VLAN with the bridge's default_pvid. The mv88e6xxx driver currently reserves VLANs 4000+ for unbridged ports isolation. When a port joins a bridge, it leaves its reserved VLAN. When a port leaves a bridge, it joins again its rese

[PATCH net] net: dsa: mv88e6xxx: fix software VLAN deletion

2016-02-05 Thread Vivien Didelot
The current bridge code calls switchdev_port_obj_del on a VLAN port even if the corresponding switchdev_port_obj_add call returned -EOPNOTSUPP. If the DSA driver doesn't return -EOPNOTSUPP for a software port VLAN in its port_vlan_del function, the VLAN is not deleted. Unbridging the port also gen

Re: Keystone 2 boards boot failure

2016-02-05 Thread Murali Karicheri
On 02/03/2016 03:13 PM, santosh shilimkar wrote: > On 2/3/2016 10:47 AM, Murali Karicheri wrote: >> On 02/03/2016 12:08 PM, santosh shilimkar wrote: >>> On 2/3/2016 8:35 AM, Arnd Bergmann wrote: > > [..] > It would be nice to give this a go once the network driver problem is solved. >>>

[V4.4-rc6 Regression] af_unix: Revert 'lock_interruptible' in stream receive code

2016-02-05 Thread Joseph Salisbury
Hi Rainer, A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: commit 3822b5c2fc62e3de8a0f33806ff279fb7df92432 Author: Rainer Weikusat Date: Wed Dec 16 20:09:25 2015 + af_unix: Revert 'lock_inte

[RFC 2/2] nl80211: add nl attribute to set ht_caps mcs rxmask override

2016-02-05 Thread Cedric DEBARGE
This adds the NL80211_ATTR_WIPHY_HTCAP_RXMASK attribute to NL80211_CMD_SET_WIPHY in order for the user to specify the ht_caps mcs rxmask. Signed-off-by: Cedric Debarge --- include/uapi/linux/nl80211.h | 5 + net/wireless/nl80211.c | 18 ++ net/wireless/rdev-ops.h

Re: [PATCH] flowi: add concept of "not_oif"

2016-02-05 Thread Jason A. Donenfeld
On Thu, Feb 4, 2016 at 4:44 AM, Eric Dumazet wrote: > On Wed, 2016-02-03 at 22:02 +0100, Jason A. Donenfeld wrote: > >> >> > I don't know about the particular problems with >> > tunnels but the scripts can use the route metric to order >> > the routes in a table. >> >> This unfortunately d

Re: gigaset: memory leak in gigaset_initcshw

2016-02-05 Thread Paul Bolle
On vr, 2016-02-05 at 17:06 +0100, Paul Bolle wrote: > If that would happen, then cs can be reused while the previous > > cs->hw.ser is not freed yet. Just a guess. > > I'll have to ponder on that a bit, sorry. This is from the hit-the-code-until-it-confesses department: --- a/drivers/isdn/gigaset

[RFC 1/2] cfg80211: add support for ht_caps mcs rxmask override

2016-02-05 Thread Cedric DEBARGE
Allows the ht_caps mcs rxmask to be defined on the fly. In this implementation, the given rxmask is applied to every band available. This is only applicable for radio cards without internal rc. Signed-off-by: Cedric Debarge --- include/net/cfg80211.h | 7 +++ net/mac80211/cfg.c | 48 +++

[RFC 0/2] mac80211: add support for ht_caps mcs rxmask override

2016-02-05 Thread Cedric DEBARGE
This patchset allows the ht_caps mcs rxmask to be defined on the fly. It applies the given rxmask to all available bands. This is actually limited to radio cards without internal rc. Cedric DEBARGE (2): cfg80211: add support for ht_caps mcs rxmask override nl80211: add nl attribute to set ht_

Re: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

2016-02-05 Thread Alexei Starovoitov
On Fri, Feb 05, 2016 at 11:01:22AM +0100, Hannes Frederic Sowa wrote: > > Okay. I see it more as changing mode of operation of hardware and thus has > not really anything to do with networking. If you say you change ethernet to > infiniband it has something to do with networking, sure. But I am fi

Re: Keystone 2 boards boot failure

2016-02-05 Thread Grygorii Strashko
hi Arnd, On 02/05/2016 06:18 PM, Arnd Bergmann wrote: > On Thursday 04 February 2016 18:25:08 Grygorii Strashko wrote: >>> >>> I have another version for testing below. That removes the logic that >>> splits and reassembles the 64-bit values, but leaves the other changes >>> in place. Can you try

Re: [PATCH net-next 2/2] sfc: implement IPv6 NFC (and IPV4_USER_FLOW)

2016-02-05 Thread Ben Hutchings
On Fri, 2016-02-05 at 11:16 +, Edward Cree wrote: > Signed-off-by: Edward Cree Reviewed-by: Ben Hutchings > --- >  drivers/net/ethernet/sfc/ethtool.c | 184 > + >  1 file changed, 184 insertions(+) > > diff --git a/drivers/net/ethernet/sfc/ethtool.c > b

Re: [PATCH net-next 1/2] ethtool: add IPv6 to the NFC API

2016-02-05 Thread Ben Hutchings
On Fri, 2016-02-05 at 11:16 +, Edward Cree wrote: > Signed-off-by: Edward Cree Reviewed-by: Ben Hutchings > --- >  include/uapi/linux/ethtool.h | 70 > >  1 file changed, 64 insertions(+), 6 deletions(-) > > diff --git a/include/uapi/linux/ethto

  1   2   >