[PATCH for-next 3/3] cxgb4/iw_cxgb4: TOS support

2016-02-04 Thread Hariprasad Shenai
This series provides support for iWARP applications to specify a TOS value and have that map to a VLAN Priority for iw_cxgb4 iWARP connections. In iw_cxgb4, when allocating an L2T entry, pass the skb_priority based on the tos value in the cm_id. Also pass the correct tos value during connection se

[PATCH for-next 0/3] Add TOS support and some cleanup

2016-02-04 Thread Hariprasad Shenai
Hi, This series adds TOS support for iWARP and also does some cleanup to make code more readable. Patch series is created against infiniband tree and includes patches on iw_cxgb4 and cxgb4 driver. We have included all the maintainers of respective drivers. Kindly review the change and let us kno

[PATCH for-next 2/3] iw_cxgb4: remove false error log entry

2016-02-04 Thread Hariprasad Shenai
Don't log errors if a listening endpoint is going away when procesing a PASS_ACCEPT_REQ message. This can happen. Change the error printk to a PDBG() debug log entry Signed-off-by: Steve Wise Signed-off-by: Hariprasad Shenai --- drivers/infiniband/hw/cxgb4/cm.c | 3 +-- 1 file changed, 1 inse

[PATCH for-next 1/3] iw_cxgb4: make queue allocation code more readable

2016-02-04 Thread Hariprasad Shenai
Rename local mm* variables to more meaningful names Signed-off-by: Steve Wise Signed-off-by: Hariprasad Shenai --- drivers/infiniband/hw/cxgb4/qp.c | 81 +--- 1 file changed, 42 insertions(+), 39 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/d

Re: [PATCH net-next 7/7] soreuseport: BPF selection functional test for TCP

2016-02-04 Thread Eric Dumazet
On Thu, 2016-02-04 at 10:35 -0500, Craig Gallek wrote: > From: Craig Gallek > > Unfortunately the existing test relied on packet payload in order to > map incoming packets to sockets. In order to get this to work with TCP, > TCP_FASTOPEN needed to be used. > > Since the fast open path is slight

Re: [PATCH net-next 6/7] soreuseport: fast reuseport TCP socket selection

2016-02-04 Thread Eric Dumazet
On Thu, 2016-02-04 at 10:35 -0500, Craig Gallek wrote: > From: Craig Gallek > > This change extends the fast SO_REUSEPORT socket lookup implemented > for UDP to TCP. Listener sockets with SO_REUSEPORT and the same > receive address are additionally added to an array for faster > random access.

Re: [PATCH net-next 4/7] inet: refactor inet[6]_lookup functions to take skb

2016-02-04 Thread Eric Dumazet
On Thu, 2016-02-04 at 10:35 -0500, Craig Gallek wrote: > From: Craig Gallek > > This is a preliminary step to allow fast socket lookup of SO_REUSEPORT > groups. Doing so with a BPF filter will require access to the > skb in question. This change plumbs the skb (and offset to payload > data) thr

Re: [PATCH net-next 5/7] soreuseport: Prep for fast reuseport TCP socket selection

2016-02-04 Thread Eric Dumazet
On Thu, 2016-02-04 at 10:35 -0500, Craig Gallek wrote: > From: Craig Gallek > > Both of the lines in this patch probably should have been included > in the initial implementation of this code for generic socket > support, but weren't technically necessary since only UDP sockets > were supported.

Re: [PATCH net-next 3/7] tcp: __tcp_hdrlen() helper

2016-02-04 Thread Eric Dumazet
On Thu, 2016-02-04 at 10:35 -0500, Craig Gallek wrote: > From: Craig Gallek > > tcp_hdrlen is wasteful if you already have a pointer to struct tcphdr. > This splits the size calculation into a helper function that can be > used if a struct tcphdr is already available. > > Signed-off-by: Craig Ga

Re: [PATCH net-next 2/7] inet: create IPv6-equivalent inet_hash function

2016-02-04 Thread Eric Dumazet
On Thu, 2016-02-04 at 10:35 -0500, Craig Gallek wrote: > From: Craig Gallek > > In order to support fast lookups for TCP sockets with SO_REUSEPORT, > the function that adds sockets to the listening hash set needs > to be able to check receive address equality. Since this equality > check is diff

Re: [PATCH net-next 1/7] sock: struct proto hash function may error

2016-02-04 Thread Eric Dumazet
On Thu, 2016-02-04 at 10:35 -0500, Craig Gallek wrote: > From: Craig Gallek > > In order to support fast reuseport lookups in TCP, the hash function > defined in struct proto must be capable of returning an error code. > This patch changes the function signature of all related hash functions > to

Re: [PATCH] af_packet: Raw socket destruction warning fix

2016-02-04 Thread Vaneet Narang
Hi, >> >> Issue is coming for 3.10.58. > Sorry for late reply, we were trying to reproduce the issue but its not that frequent. >What driver are you using (is that in-tree)? we are facing issue with wireless driver. Is it possible that wireless driver can cause any issue because rmem accountin

Re: bonding reports interface up with 0 Mbps

2016-02-04 Thread zhuyj
On 02/05/2016 08:43 AM, Tantilov, Emil S wrote: -Original Message- From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] Sent: Thursday, February 04, 2016 4:37 PM To: Tantilov, Emil S Cc: netdev@vger.kernel.org; go...@cumulusnetworks.com; zhuyj; j...@mellanox.com Subject: Re: bonding rep

Re: bonding reports interface up with 0 Mbps

2016-02-04 Thread zhuyj
On 02/05/2016 08:37 AM, Jay Vosburgh wrote: Jay Vosburgh wrote: [...] Thinking about the trace again... Emil: what happens in the trace before this? Is there ever a call to the ixgbe_get_settings? Does a NETDEV_UP or NETDEV_CHANGE event ever hit the bond_netdev_event function?

feature - ip link set primary ?

2016-02-04 Thread James Feeney
Should there be an ip link set primary command in the iproute2 package, to set the Primary Slave on a "bond" type link? It seems that the alternative now is to use the sysfs, with echo -n > /sys/devices/virtual/net//bonding/primary which, in systemd Service Unit Files, requires "/usr/bin/

RE: [net] igbvf: remove "link is Up" message when registering mcast address

2016-02-04 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [netdev-ow...@vger.kernel.org] on behalf > of Jon Maxwell [jmaxwel...@gmail.com] > Sent: Sunday, January 24, 2016 3:22 PM > To: Kirsher, Jeffrey T > Cc: da...@davemloft.net; jmaxw...@redhat.com; vinsc...@redhat.com; > intel-wired-...@lists.osuosl.org; netdev@v

Re: [PATCH v2 4/4] param: convert some "on"/"off" users to strtobool

2016-02-04 Thread Kees Cook
On Thu, Feb 4, 2016 at 4:11 PM, Kees Cook wrote: > On Thu, Feb 4, 2016 at 3:04 PM, Andy Shevchenko > wrote: >> On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: >>> This changes several users of manual "on"/"off" parsing to use strtobool. >>> (Which means they will now parse y/n/1/0 meaningfully

Reply: [PATCH iproute2] ip-link: remove warning message

2016-02-04 Thread 张胜举
> On Thu, 21 Jan 2016 02:23:49 + > Zhang Shengju wrote: > > > the warning was: > > iproute.c:301:12: warning: 'val' may be used uninitialized in this > > function [-Wmaybe-uninitialized] > >features &= ~RTAX_FEATURE_ECN; > > ^ > > iproute.c:575:10: note: 'val' was declared her

Re: [PATCH net-next 2/2] sfc: implement IPv6 NFC (and IPV4_USER_FLOW)

2016-02-04 Thread Ben Hutchings
On Tue, 2016-02-02 at 18:49 +, Edward Cree wrote: > Signed-off-by: Edward Cree > --- >  drivers/net/ethernet/sfc/ethtool.c | 176 > + >  1 file changed, 176 insertions(+) > > diff --git a/drivers/net/ethernet/sfc/ethtool.c > b/drivers/net/ethernet/sfc/etht

Reply: [net] bonding: use return instead of goto

2016-02-04 Thread 张胜举
> On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > > Replace 'goto' with 'return' to remove unnecessary check at label: > > err_undo_flags. > > I think you're going to have to explain how you came to the conclusion that > the check isn't necessary. > > -- > Jarod Wilson > ja...@re

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Linus Torvalds
On Thu, Feb 4, 2016 at 5:27 PM, Linus Torvalds wrote: > sum = csum_partial_lt8(*(unsigned long *)buff, len, sum); > return rotate_by8_if_odd(sum, align); Actually, that last word-sized access to "buff" might be past the end of the buffer. The code does the right thing if "len" is

Re: [PATCH net-next 1/2] ethtool: add IPv6 to the NFC API

2016-02-04 Thread Ben Hutchings
On Tue, 2016-02-02 at 18:49 +, Edward Cree wrote: > Signed-off-by: Edward Cree > --- >  include/uapi/linux/ethtool.h | 70 > >  1 file changed, 64 insertions(+), 6 deletions(-) > > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/etht

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Linus Torvalds
On Thu, Feb 4, 2016 at 2:09 PM, Linus Torvalds wrote: > > The "+" should be "-", of course - the point is to shift up the value > by 8 bits for odd cases, and we need to load starting one byte early > for that. The idea is that we use the byte shifter in the load unit to > do some work for us. Ok

Re: [PATCH iproute2] geneve: add support for lwt tunnel creation and dst port selection

2016-02-04 Thread Stephen Hemminger
On Thu, 28 Jan 2016 14:48:55 +0100 Paolo Abeni wrote: > This change add the ability to create lwt/flow based/externally > controlled geneve device and to select the udp destination port used > by a full geneve tunnel. > > Signed-off-by: Paolo Abeni Applied

Re: [RESEND PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis)

2016-02-04 Thread Stephen Hemminger
On Wed, 3 Feb 2016 08:25:00 + Nicolas Dichtel wrote: > Commit 8f80d450c3cb ("tc: fix compilation with old gcc (< 4.6)") was reverted > to ease the merge of the net-next branch. > > Here is the new version. > > Signed-off-by: Nicolas Dichtel > Signed-off-by: Daniel Borkmann Applied

Re: [PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid'

2016-02-04 Thread Stephen Hemminger
On Tue, 2 Feb 2016 16:53:40 -0800 Roopa Prabhu wrote: > From: Roopa Prabhu > > 'ip monitor all' is broken on older kernels. > This patch fixes 'ip monitor all' to match > 'all' and not 'all-nsid'. > > It moves parsing arg 'all-nsid' to after parsing > 'all'. > > Before: > $ip monitor all > N

RE: bonding reports interface up with 0 Mbps

2016-02-04 Thread Tantilov, Emil S
>-Original Message- >From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] >Sent: Thursday, February 04, 2016 4:37 PM >To: Tantilov, Emil S >Cc: netdev@vger.kernel.org; go...@cumulusnetworks.com; zhuyj; >j...@mellanox.com >Subject: Re: bonding reports interface up with 0 Mbps > >Jay Vosbur

Re: bonding reports interface up with 0 Mbps

2016-02-04 Thread Jay Vosburgh
Jay Vosburgh wrote: [...] > Thinking about the trace again... Emil: what happens in the >trace before this? Is there ever a call to the ixgbe_get_settings? >Does a NETDEV_UP or NETDEV_CHANGE event ever hit the bond_netdev_event >function? Emil kindly sent me the trace offline, and

Re: [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH commands

2016-02-04 Thread David Miller
From: "Keller, Jacob E" Date: Thu, 4 Feb 2016 23:09:56 + > So you're suggesting instead, to error when the second operation > (change number of queues) would fail the current settings? Yes. This is absolutely required.

Re: [PATCH next] ipvlan: inherit MTU from master device

2016-02-04 Thread David Miller
From: Mahesh Bandewar Date: Wed, 27 Jan 2016 23:33:28 -0800 > From: Mahesh Bandewar > > When we create IPvlan slave; we use ether_setup() and that > sets up default MTU to 1500 while the master device may have > lower / different MTU. Any subsequent changes to the masters' > MTU are reflected i

Re: [PATCH v2 4/4] param: convert some "on"/"off" users to strtobool

2016-02-04 Thread Kees Cook
On Thu, Feb 4, 2016 at 3:04 PM, Andy Shevchenko wrote: > On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: >> This changes several users of manual "on"/"off" parsing to use strtobool. >> (Which means they will now parse y/n/1/0 meaningfully too.) >> > > I like this change, but can you carefully c

Re: [PATCH v2 1/4] lib: move strtobool to kstrtobool

2016-02-04 Thread Rasmus Villemoes
On Thu, Feb 04 2016, Kees Cook wrote: > Create the kstrtobool_from_user helper and moves strtobool logic into > the new kstrtobool (matching all the other kstrto* functions). Provides > an inline wrapper for existing strtobool callers. > > Signed-off-by: Kees Cook > --- > include/linux/kernel.h

[PATCH v2 net-next 1/4] net: add event_list to struct net and provide utility functions

2016-02-04 Thread Salam Noureddine
Signed-off-by: Salam Noureddine --- include/net/net_namespace.h | 22 ++ net/core/net_namespace.c| 1 + 2 files changed, 23 insertions(+) diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index 4089abc..6dbc0b2 100644 --- a/include/net/net_namespace

[PATCH v2 net-next 0/4] batch calls to fib_flush and arp_ifdown

2016-02-04 Thread Salam Noureddine
Added changes suggested by Julian Anastasov in version 2. fib_flush walks the whole fib in a net_namespace and is called for each net_device being closed or unregistered. This can be very expensive when dealing with 100k or more routes in the fib and removal of a lot of interfaces. These four patc

[PATCH v2 net-next 3/4] net: core: introduce neigh_ifdown_all for all down interfaces

2016-02-04 Thread Salam Noureddine
This cleans up neighbour entries for all interfaces in the down state, avoiding walking the whole neighbour table for each interface being brought down. Signed-off-by: Salam Noureddine --- include/net/arp.h | 1 + include/net/neighbour.h | 1 + net/core/neighbour.c| 38 ++

[PATCH v2 net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-04 Thread Salam Noureddine
This can be used to optimize bringing down and unregsitering net_devices by running certain cleanup operations only on the net namespace instead of on each net_device. Signed-off-by: Salam Noureddine --- include/linux/netdevice.h | 2 ++ net/core/dev.c| 48 ++

[PATCH v2 net-next 4/4] net: fib: avoid calling fib_flush for each device when doing batch close and unregister

2016-02-04 Thread Salam Noureddine
Call fib_flush at the end when closing or unregistering multiple devices. This can save walking the fib many times and greatly reduce rtnl_lock hold time when unregistering many devices with a fib having hundreds of thousands of routes. Signed-off-by: Salam Noureddine --- include/net/netns/ipv4.

Re: [net-next PATCH 0/7] tc offload for cls_u32 on ixgbe

2016-02-04 Thread Pablo Neira Ayuso
On Thu, Feb 04, 2016 at 10:16:56AM +0100, Jiri Pirko wrote: > Wed, Feb 03, 2016 at 10:27:32AM CET, john.fastab...@gmail.com wrote: > > > >Also by adding get_parse_graph and set_parse_graph attributes as > >in my previous flow_api work we can build programmable devices > >and programmatically learn

Re: [PATCH v2 1/4] lib: move strtobool to kstrtobool

2016-02-04 Thread Andy Shevchenko
On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: > Create the kstrtobool_from_user helper and moves strtobool logic into > the new kstrtobool (matching all the other kstrto* functions). Provides > an inline wrapper for existing strtobool callers. > > Signed-off-by: Kees Cook Reviewed-by: Andy S

Re: [PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool

2016-02-04 Thread Kees Cook
On Thu, Feb 4, 2016 at 3:00 PM, Andy Shevchenko wrote: > On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: >> Add support for "on" and "off" when converting to boolean. >> >> Signed-off-by: Kees Cook >> --- >> lib/kstrtox.c | 14 ++ >> 1 file changed, 14 insertions(+) >> >> diff --g

Re: [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH commands

2016-02-04 Thread Keller, Jacob E
On Thu, 2016-02-04 at 17:53 -0500, David Miller wrote: > From: Jacob Keller > Date: Tue,  2 Feb 2016 15:22:06 -0800 > > > Ethtool supports a few operations for modifying and controlling > > a device's RSS table. Sometimes, changes in other features of the > > device > > may require (or desire) ch

Re: [PATCH v2 4/4] param: convert some "on"/"off" users to strtobool

2016-02-04 Thread Andy Shevchenko
On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: > This changes several users of manual "on"/"off" parsing to use strtobool. > (Which means they will now parse y/n/1/0 meaningfully too.) > I like this change, but can you carefully check the acceptance of the returned value? Briefly I saw 1 or 0

Re: [PATCH v2 2/4] lib: update single-char callers of strtobool

2016-02-04 Thread Kees Cook
On Thu, Feb 4, 2016 at 2:59 PM, Andy Shevchenko wrote: > On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: >> Some callers of strtobool were passing a pointer to unterminated strings. >> In preparation of adding multi-character processing to kstrtobool, update >> the callers to not pass single-ch

Re: [PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool

2016-02-04 Thread Andy Shevchenko
On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: > Add support for "on" and "off" when converting to boolean. > > Signed-off-by: Kees Cook > --- > lib/kstrtox.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/lib/kstrtox.c b/lib/kstrtox.c > index e18f088704d7..09e83a19a

Re: [PATCH v2 2/4] lib: update single-char callers of strtobool

2016-02-04 Thread Andy Shevchenko
On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: > Some callers of strtobool were passing a pointer to unterminated strings. > In preparation of adding multi-character processing to kstrtobool, update > the callers to not pass single-character pointers, and switch to using the > new kstrtobool_fr

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Linus Torvalds
On Thu, Feb 4, 2016 at 2:43 PM, Tom Herbert wrote: > > The reason I did this in assembly is precisely about the your point of > having to close the carry chains with adcq $0. I do have a first > implementation in C which using switch() to handle alignment, excess > length less than 8 bytes, and th

Re: [PATCH 1/2] ethtool: add dynamic flag to ETHTOOL_{GS}RXFH commands

2016-02-04 Thread David Miller
From: Jacob Keller Date: Tue, 2 Feb 2016 15:22:06 -0800 > Ethtool supports a few operations for modifying and controlling > a device's RSS table. Sometimes, changes in other features of the device > may require (or desire) changes to the RSS table. Currently there is no > method to indicate to t

Re: [PATCH v2 1/4] lib: move strtobool to kstrtobool

2016-02-04 Thread Kees Cook
On Thu, Feb 4, 2016 at 2:43 PM, Andy Shevchenko wrote: > On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook wrote: >> Create the kstrtobool_from_user helper and moves strtobool logic into >> the new kstrtobool (matching all the other kstrto* functions). Provides >> an inline wrapper for existing strtoboo

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Tom Herbert
On Thu, Feb 4, 2016 at 1:46 PM, Linus Torvalds wrote: > I missed the original email (I don't have net-devel in my mailbox), > but based on Ingo's quoting have a more fundamental question: > > Why wasn't that done with C code instead of asm with odd numerical targets? > The reason I did this in ass

[PATCH V2 net-next] hv_netvsc: cleanup netdev feature flags for netvsc

2016-02-04 Thread Simon Xiao
1. Adding NETIF_F_TSO6 feature flag; 2. Adding NETIF_F_HW_CSUM. NETIF_F_IPV6_CSUM and NETIF_F_IP_CSUM are being deprecated; 3. Cleanup the coding style of flag assignment by using macro. Signed-off-by: Simon Xiao Reviewed-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Linus Torvalds
On Thu, Feb 4, 2016 at 1:46 PM, Linus Torvalds wrote: > > static const unsigned long mask[9] = { > 0x, > 0xff00, > 0x, > 0xff00, > 0x, >

Re: [RFC RESEND] iwlwifi: pcie: transmit queue auto-sizing

2016-02-04 Thread Dave Taht
I am not on linux-wireless nor netdev presently, but... On Thu, Feb 4, 2016 at 12:16 PM, Emmanuel Grumbach wrote: > As many (all?) WiFi devices, Intel WiFi devices have > transmit queues which have 256 transmit descriptors > each and each descriptor corresponds to an MPDU. > This means that when

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Linus Torvalds
I missed the original email (I don't have net-devel in my mailbox), but based on Ingo's quoting have a more fundamental question: Why wasn't that done with C code instead of asm with odd numerical targets? It seems likely that the real issue is avoiding the short loops (that will cause branch pre

Re: [RFC v2] iwlwifi: pcie: transmit queue auto-sizing

2016-02-04 Thread Ben Greear
On 02/04/2016 12:56 PM, Grumbach, Emmanuel wrote: On 02/04/2016 10:46 PM, Ben Greear wrote: On 02/04/2016 12:16 PM, Emmanuel Grumbach wrote: As many (all?) WiFi devices, Intel WiFi devices have transmit queues which have 256 transmit descriptors each and each descriptor corresponds to an MPDU

[PATCH v3 net 4/7] net: mvneta: Remove unused code

2016-02-04 Thread Gregory CLEMENT
Since the commit 2dcf75e2793c ("net: mvneta: Associate RX queues with each CPU") all the percpu irq are used and disabled at initialization, so there is no point to disable them first. Signed-off-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/mvneta.c | 8 1 file changed, 8 deleti

[PATCH v3 net 2/7] net: mvneta: Fix the CPU choice in mvneta_percpu_elect

2016-02-04 Thread Gregory CLEMENT
When passing to the management of multiple RX queue, the mvneta_percpu_elect function was broken. The use of the modulo can lead to elect the wrong cpu. For example with rxq_def=2, if the CPU 2 goes offline and then online, we ended with the third RX queue activated in the same time on CPU 0 and CP

[PATCH v3 net 1/7] net: mvneta: Fix for_each_present_cpu usage

2016-02-04 Thread Gregory CLEMENT
This patch convert the for_each_present in on_each_cpu, instead of applying on the present cpus it will be applied only on the online cpus. This fix a bug reported on http://thread.gmane.org/gmane.linux.ports.arm.kernel/468173. Using the macro on_each_cpu (instead of a for_each_* loop) also ensure

[PATCH v3 net 0/7] mvneta fixes for SMP

2016-02-04 Thread Gregory CLEMENT
Hi, Following this bug report: http://thread.gmane.org/gmane.linux.ports.arm.kernel/468173 and the suggestions from Russell King, I reviewed all the code involving multi-CPU. It ended with this series of patches which should improve the stability of the driver. During my test I found another bug

[PATCH v3 net 3/7] net: mvneta: Use on_each_cpu when possible

2016-02-04 Thread Gregory CLEMENT
Instead of using a for_each_* loop in which we just call the smp_call_function_single macro, it is more simple to directly use the on_each_cpu macro. Moreover, this macro ensures that the calls will be done all at once. Suggested-by: Russell King Signed-off-by: Gregory CLEMENT --- drivers/net/e

[PATCH v3 net 5/7] net: mvneta: Modify the queue related fields from each cpu

2016-02-04 Thread Gregory CLEMENT
In the MVNETA_INTR_* registers, the queues related fields are per cpu, according to the datasheet (comment in [] are added by me): "In a multi-CPU system, bits of RX[or TX] queues for which the access by the reading[or writing] CPU is disabled are read as 0, and cannot be cleared[or written]." Tha

[PATCH v3 net 6/7] net: mvneta: The mvneta_percpu_elect function should be atomic

2016-02-04 Thread Gregory CLEMENT
Electing a CPU must be done in an atomic way: it should be done after or before the removal/insertion of a CPU and this function is not reentrant. During the loop of mvneta_percpu_elect we associates the queues to the CPUs, if there is a topology change during this loop, then the mapping between t

[PATCH v3 net 7/7] net: mvneta: Fix race condition during stopping

2016-02-04 Thread Gregory CLEMENT
When stopping the port, the CPU notifier are still there whereas the mvneta_stop_dev function calls mvneta_percpu_disable() on each CPUs. It was possible to have a new CPU coming at this point which could be racy. This patch adds a flag preventing executing the code notifier for a new CPU when the

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Alexander Duyck
On Thu, Feb 4, 2016 at 12:59 PM, Tom Herbert wrote: > On Thu, Feb 4, 2016 at 9:09 AM, David Laight wrote: >> From: Tom Herbert >> ... >>> > If nothing else reducing the size of this main loop may be desirable. >>> > I know the newer x86 is supposed to have a loop buffer so that it can >>> > basic

[PATCH v2 0/4] lib: add "on" and "off" to strtobool

2016-02-04 Thread Kees Cook
This consolidates logic for handling "on"/"off" parsing for bools into the strtobool function, by way of moving it into kstrtobool (with helpers), and updating various callers. arch/powerpc/kernel/rtasd.c|9 --- arch/powerpc/platforms/pseries/hotplug-cpu.c | 10 a

[PATCH v2 4/4] param: convert some "on"/"off" users to strtobool

2016-02-04 Thread Kees Cook
This changes several users of manual "on"/"off" parsing to use strtobool. (Which means they will now parse y/n/1/0 meaningfully too.) Signed-off-by: Kees Cook Acked-by: Heiko Carstens Acked-by: Michael Ellerman Cc: x...@kernel.org Cc: linuxppc-...@lists.ozlabs.org Cc: linux-s...@vger.kernel.org

[PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool

2016-02-04 Thread Kees Cook
Add support for "on" and "off" when converting to boolean. Signed-off-by: Kees Cook --- lib/kstrtox.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/lib/kstrtox.c b/lib/kstrtox.c index e18f088704d7..09e83a19a96d 100644 --- a/lib/kstrtox.c +++ b/lib/kstrtox.c @@ -347,6 +347,2

[PATCH v2 2/4] lib: update single-char callers of strtobool

2016-02-04 Thread Kees Cook
Some callers of strtobool were passing a pointer to unterminated strings. In preparation of adding multi-character processing to kstrtobool, update the callers to not pass single-character pointers, and switch to using the new kstrtobool_from_user helper where possible. Signed-off-by: Kees Cook C

[PATCH v2 1/4] lib: move strtobool to kstrtobool

2016-02-04 Thread Kees Cook
Create the kstrtobool_from_user helper and moves strtobool logic into the new kstrtobool (matching all the other kstrto* functions). Provides an inline wrapper for existing strtobool callers. Signed-off-by: Kees Cook --- include/linux/kernel.h | 3 +++ include/linux/string.h | 6 +- lib/ks

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Tom Herbert
On Thu, Feb 4, 2016 at 9:09 AM, David Laight wrote: > From: Tom Herbert > ... >> > If nothing else reducing the size of this main loop may be desirable. >> > I know the newer x86 is supposed to have a loop buffer so that it can >> > basically loop on already decoded instructions. Normally it is o

Re: [PATCH] net: ethernet: davicom: fix devicetree irq resource

2016-02-04 Thread Sergei Shtylyov
On 02/04/2016 11:42 PM, Robert Jarzmik wrote: Your patch summary prefixes are too verbose, it was enough to say only "dm9000: ". Or "davicom: dm9000: ". Missing the driver name itself doesn't look very consistent. :-) Well, I don't agree here. The subsystem should be fully specified

Re: [RFC v2] iwlwifi: pcie: transmit queue auto-sizing

2016-02-04 Thread Grumbach, Emmanuel
On 02/04/2016 10:46 PM, Ben Greear wrote: > On 02/04/2016 12:16 PM, Emmanuel Grumbach wrote: >> As many (all?) WiFi devices, Intel WiFi devices have >> transmit queues which have 256 transmit descriptors >> each and each descriptor corresponds to an MPDU. >> This means that when it is full, the q

Re: [RFC v2] iwlwifi: pcie: transmit queue auto-sizing

2016-02-04 Thread Ben Greear
On 02/04/2016 12:16 PM, Emmanuel Grumbach wrote: As many (all?) WiFi devices, Intel WiFi devices have transmit queues which have 256 transmit descriptors each and each descriptor corresponds to an MPDU. This means that when it is full, the queue contains 256 * ~1500 bytes to be transmitted (if we

Re: [PATCH] net: ethernet: davicom: fix devicetree irq resource

2016-02-04 Thread Robert Jarzmik
Sergei Shtylyov writes: > Hello. > >Your patch summary prefixes are too verbose, it was enough to say only > "dm9000: ". Well, I don't agree here. The subsystem should be fully specified, at least this is something I require in pxa, something that is also required in sound/*, etc ... If David

Re: bonding reports interface up with 0 Mbps

2016-02-04 Thread Jay Vosburgh
Tantilov, Emil S wrote: >We are seeing an occasional issue where the bonding driver may report >interface up with 0 Mbps: >bond0: link status definitely up for interface eth0, 0 Mbps full duplex > >So far in all the failed traces I have collected this happens on >NETDEV_CHANGELOWERSTATE event:

Re: Disabling XPS for 4.4.0-1+ixgbe+OpenStack VM over a VLAN means 65% increase in netperf TCP_STREAM

2016-02-04 Thread Rick Jones
On 02/04/2016 12:13 PM, Tom Herbert wrote: On Thu, Feb 4, 2016 at 11:57 AM, Rick Jones wrote: On 02/04/2016 11:38 AM, Tom Herbert wrote: XPS has OOO avoidance for TCP, that should not be a problem. What/how much should I read into: With XPSTCPOFOQueue: 78206 Without XPS TCPOFOQueue: 96

Re: bonding reports interface up with 0 Mbps

2016-02-04 Thread Jay Vosburgh
Tantilov, Emil S wrote: [...] >Sure, I'll give this a try, but I'm not sure this check applies in this case >as you can see from the trace link is up and carrier is on. From code inspection, I see another possible race, although I'm not sure if it's relevant for this case. During enslave

[RFC v2] iwlwifi: pcie: transmit queue auto-sizing

2016-02-04 Thread Emmanuel Grumbach
As many (all?) WiFi devices, Intel WiFi devices have transmit queues which have 256 transmit descriptors each and each descriptor corresponds to an MPDU. This means that when it is full, the queue contains 256 * ~1500 bytes to be transmitted (if we don't have A-MSDUs). The purpose of those queues i

[RFC RESEND] iwlwifi: pcie: transmit queue auto-sizing

2016-02-04 Thread Emmanuel Grumbach
As many (all?) WiFi devices, Intel WiFi devices have transmit queues which have 256 transmit descriptors each and each descriptor corresponds to an MPDU. This means that when it is full, the queue contains 256 * ~1500 bytes to be transmitted (if we don't have A-MSDUs). The purpose of those queues i

[RFC] iwlwifi: pcie: transmit queue auto-sizing

2016-02-04 Thread Emmanuel Grumbach
As many (all?) WiFi devices, Intel WiFi devices have transmit queues which have 256 transmit descriptors each and each descriptor corresponds to an MPDU. This means that when it is full, the queue contains 256 * ~1500 bytes to be transmitted (if we don't have A-MSDUs). The purpose of those queues i

Re: Disabling XPS for 4.4.0-1+ixgbe+OpenStack VM over a VLAN means 65% increase in netperf TCP_STREAM

2016-02-04 Thread Tom Herbert
On Thu, Feb 4, 2016 at 11:57 AM, Rick Jones wrote: > On 02/04/2016 11:38 AM, Tom Herbert wrote: >> >> On Thu, Feb 4, 2016 at 11:13 AM, Rick Jones wrote: >>> >>> The Intel folks suggested something about the process scheduler moving >>> the >>> sender around and ultimately causing some packet re-o

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Alexander Duyck
On Thu, Feb 4, 2016 at 11:44 AM, Tom Herbert wrote: > On Thu, Feb 4, 2016 at 11:22 AM, Alexander Duyck > wrote: >> On Wed, Feb 3, 2016 at 11:18 AM, Tom Herbert wrote: >>> Implement assembly routine for csum_partial for 64 bit x86. This >>> primarily speeds up checksum calculation for smaller len

Re: Disabling XPS for 4.4.0-1+ixgbe+OpenStack VM over a VLAN means 65% increase in netperf TCP_STREAM

2016-02-04 Thread Rick Jones
On 02/04/2016 11:38 AM, Tom Herbert wrote: On Thu, Feb 4, 2016 at 11:13 AM, Rick Jones wrote: The Intel folks suggested something about the process scheduler moving the sender around and ultimately causing some packet re-ordering. That could I suppose explain the TCP_STREAM difference, but not

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Tom Herbert
On Thu, Feb 4, 2016 at 11:22 AM, Alexander Duyck wrote: > On Wed, Feb 3, 2016 at 11:18 AM, Tom Herbert wrote: >> Implement assembly routine for csum_partial for 64 bit x86. This >> primarily speeds up checksum calculation for smaller lengths such as >> those that are present when doing skb_postpu

Re: Disabling XPS for 4.4.0-1+ixgbe+OpenStack VM over a VLAN means 65% increase in netperf TCP_STREAM

2016-02-04 Thread Tom Herbert
On Thu, Feb 4, 2016 at 11:13 AM, Rick Jones wrote: > Folks - > > I was doing some performance work with OpenStack Liberty on systems with 2x > E5-2650L v3 @ 1.80GHz processors and 560FLR (Intel 82599ES) NICs onto which > I'd placed a 4.4.0-1 kernel. I was actually interested in the effect of > re

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Tom Herbert
On Thu, Feb 4, 2016 at 11:22 AM, Alexander Duyck wrote: > On Wed, Feb 3, 2016 at 11:18 AM, Tom Herbert wrote: >> Implement assembly routine for csum_partial for 64 bit x86. This >> primarily speeds up checksum calculation for smaller lengths such as >> those that are present when doing skb_postpu

Re: [net] bonding: use return instead of goto

2016-02-04 Thread Jarod Wilson
On Wed, Feb 03, 2016 at 06:15:22AM +, Zhang Shengju wrote: > Replace 'goto' with 'return' to remove unnecessary check at label: > err_undo_flags. I think you're going to have to explain how you came to the conclusion that the check isn't necessary. -- Jarod Wilson ja...@redhat.com

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Tom Herbert
On Thu, Feb 4, 2016 at 2:56 AM, Ingo Molnar wrote: > > * Ingo Molnar wrote: > >> s/!CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS >> >> > + >> > + /* Check length */ >> > +10:cmpl$8, %esi >> > + jg 30f >> > + jl 20f >> > + >> > + /* Exactly 8 bytes length */ >> > + addl

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Alexander Duyck
On Wed, Feb 3, 2016 at 11:18 AM, Tom Herbert wrote: > Implement assembly routine for csum_partial for 64 bit x86. This > primarily speeds up checksum calculation for smaller lengths such as > those that are present when doing skb_postpull_rcsum when getting > CHECKSUM_COMPLETE from device or after

Disabling XPS for 4.4.0-1+ixgbe+OpenStack VM over a VLAN means 65% increase in netperf TCP_STREAM

2016-02-04 Thread Rick Jones
Folks - I was doing some performance work with OpenStack Liberty on systems with 2x E5-2650L v3 @ 1.80GHz processors and 560FLR (Intel 82599ES) NICs onto which I'd placed a 4.4.0-1 kernel. I was actually interested in the effect of removing the linux bridge from all the plumbing OpenStack cr

RE: [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it

2016-02-04 Thread Rosen, Rami
Hi, >Btw, if you add this tool into iproute2 (which would be preferred), >then >probably dl should be ok (and easier retrievable in that relation). +1. This tool, which uses netlink messages, seems a natural candidate for iproute2. And also apart from "ip", we have also another short command i

Re: [PATCH 1/3] lib: fix callers of strtobool to use char array

2016-02-04 Thread Kees Cook
On Mon, Feb 1, 2016 at 5:17 AM, Andy Shevchenko wrote: > On Thu, Jan 28, 2016 at 4:17 PM, Kees Cook wrote: >> Some callers of strtobool were passing a pointer to unterminated strings. >> This fixes the issue and consolidates some logic in cifs. > > My comments below. > > First of all I don't thin

[PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-02-04 Thread Laura Abbott
We receoved a bug report from someone using vmware: WARNING: CPU: 3 PID: 660 at kernel/sched/core.c:7389 __might_sleep+0x7d/0x90() do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait+0x2d/0x90 Modules linked in: vmw_vsock_vmci_transport vsock snd_seq_midi snd_seq_midi_ev

[PATCH net-next] r8169:fix system hange problem.

2016-02-04 Thread Chunhao Lin
There are typos in setting RTL8168H hardware parameters. If system install another version driver that may cuase system hang. Signed-off-by: Chunhao Lin --- drivers/net/ethernet/realtek/r8169.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/etherne

Re: Keystone 2 boards boot failure

2016-02-04 Thread Grygorii Strashko
On 02/04/2016 03:07 PM, Arnd Bergmann wrote: > On Thursday 04 February 2016 14:19:54 Grygorii Strashko wrote: >> On 02/03/2016 10:40 PM, Arnd Bergmann wrote: >>> On Wednesday 03 February 2016 18:31:00 Grygorii Strashko wrote: On 02/03/2016 06:20 PM, Arnd Bergmann wrote: > On Wednesday 03 F

Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

2016-02-04 Thread Rick Jones
On 02/04/2016 04:47 AM, Michael S. Tsirkin wrote: On Wed, Feb 03, 2016 at 03:49:04PM -0800, Rick Jones wrote: And even for not-quite-virtual devices - such as a VC/FlexNIC in an HPE blade server there can be just about any speed set. I think we went down a path of patching some things to addres

Re: [PATCH] net: ethernet: davicom: fix devicetree irq resource

2016-02-04 Thread Sergei Shtylyov
Hello. Your patch summary prefixes are too verbose, it was enough to say only "dm9000: ". On 02/04/2016 12:40 AM, Robert Jarzmik wrote: The dm9000 driver doesn't work in at least one device-tree configuration, spitting an error message on irq resource : [1.062495] dm9000 800.ether

RE: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread David Laight
From: Tom Herbert ... > > If nothing else reducing the size of this main loop may be desirable. > > I know the newer x86 is supposed to have a loop buffer so that it can > > basically loop on already decoded instructions. Normally it is only > > something like 64 or 128 bytes in size though. You

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Tom Herbert
On Thu, Feb 4, 2016 at 8:51 AM, Alexander Duyck wrote: > On Thu, Feb 4, 2016 at 3:08 AM, David Laight wrote: >> From: Tom Herbert >>> Sent: 03 February 2016 19:19 >> ... >>> + /* Main loop */ >>> +50: adcq0*8(%rdi),%rax >>> + adcq1*8(%rdi),%rax >>> + adcq2*8(%rdi),%rax >>

Re: [PATCH v3 net-next] net: Implement fast csum_partial for x86_64

2016-02-04 Thread Alexander Duyck
On Thu, Feb 4, 2016 at 3:08 AM, David Laight wrote: > From: Tom Herbert >> Sent: 03 February 2016 19:19 > ... >> + /* Main loop */ >> +50: adcq0*8(%rdi),%rax >> + adcq1*8(%rdi),%rax >> + adcq2*8(%rdi),%rax >> + adcq3*8(%rdi),%rax >> + adcq4*8(%rdi),%rax >>

[PATCH net-next] bonding: 3ad: allow to set ad_actor settings while the bond is up

2016-02-04 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov No need to require the bond down while changing these settings, the change will be reflected immediately and the 3ad mode will sort itself out. For faster convergence set port->ntt to true in order to generate new LACPDUs immediately. CC: Jay Vosburgh CC: Veaceslav Fal

  1   2   >