Re: [PATCH v1] ethtool: properly indent man sub-options

2016-01-28 Thread Jeff Kirsher
On Thu, Jan 7, 2016 at 5:50 PM, Jesse Brandeburg wrote: > The ethtool.8 file was full of lots of incorrectly indented > bits. This fixes the arguments to options to be indented in > a visually appealing way. > > Before: >-K --features --offload > Changes the offload paramete

Re: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-28 Thread zhuyj
Thanks a lot. Maybe this patch is to miimon and notifier. Maybe it is not appropriate to arp monitor. So the following patch will avoid arp monitor. Thanks a lot. Zhu Yanjun + /* Because of link flap from the slave interface, it is possilbe that +* the notifiler is NETDEV_UP whi

Re: [PATCHv2 net 0/2] Part 2 of v4.5-rc1 phylib regression

2016-01-28 Thread David Miller
From: Andrew Lunn Date: Thu, 28 Jan 2016 02:30:28 +0100 > White list PHY compatible values which indicate PHYs. Issue a warning > when one is encountered. > > Update the documentation to make it clear what is expected in the > compatible string. > > v2: > Fix Grammar, reword changelog, add Tes

Re: [PATCH 0/3] lan78xx: update and fixes

2016-01-28 Thread David Miller
From: Date: Wed, 27 Jan 2016 22:57:51 + > Woojung Huh (3): > lan78xx: change to use updated phy-ignore-interrupts > lan78xx: Add to handle mux control per chip id > lan78xx: throttle TX path at slower than SuperSpeed USB Series applied, thanks.

Re: [PATCH net] tcp: beware of alignments in tcp_get_info()

2016-01-28 Thread David Miller
From: Eric Dumazet Date: Wed, 27 Jan 2016 10:52:43 -0800 > From: Eric Dumazet > > With some combinations of user provided flags in netlink command, > it is possible to call tcp_get_info() with a buffer that is not 8-bytes > aligned. > > It does matter on some arches, so we need to use put_unal

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Linus Torvalds
On Thu, Jan 28, 2016 at 5:54 PM, Larry Finger wrote: > > I have been running an RTL8821AE since kernel 3.18 without hitting this > problem using a TRENDnet AC1750 dual-band AP. The UniFi may be doing > something that the driver is not expecting. I've had issues with unifi ap's before, but to be h

Re: [PATCH net 2/2] net/mlx5e: Use a private copy of netdev ops

2016-01-28 Thread David Miller
From: Or Gerlitz Date: Wed, 27 Jan 2016 17:02:25 +0200 > From: Saeed Mahameed > > Currently our netdevice ops is a static global variable which > is referenced by all mlx5e netdevice instances. This can be > problematic when different driver instances do not share same > HW capabilities (e.g SR

[PATCH V3] netfilter: h323: avoid potential attack

2016-01-28 Thread Zhouyi Zhou
I think hackers chould build a malicious h323 packet to overflow the pointer p which will panic during the memcpy(addr, p, len) For example, he may fabricate a very large taddr->ipAddress.ip; As suggested by Eric, this module is protected by a lock (nf_h323_lock) so adding a variable h323_buffer_va

Re: [PATCH 3/3] param: convert some "on"/"off" users to strtobool

2016-01-28 Thread Michael Ellerman
On Thu, 2016-01-28 at 06:17 -0800, Kees Cook wrote: > This changes several users of manual "on"/"off" parsing to use strtobool. You should probably point out that it's a slight behaviour change for some users. ie. parameters that previously *only* worked with "on"/"off", can now also take 0/1/y/n

Re: [PATCH net] net: dsa: mv88e6xxx: fix port VLAN maps

2016-01-28 Thread Andrew Lunn
On Thu, Jan 28, 2016 at 04:54:37PM -0500, Vivien Didelot wrote: > Currently the port based VLAN maps should be configured to allow every > port to egress frames on all other ports, except themselves. > > The debugfs interface shows that they are misconfigured. For instance, a > 7-port switch has t

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Larry Finger
On 01/28/2016 05:01 PM, Linus Torvalds wrote: On Thu, Jan 28, 2016 at 2:12 PM, Johannes Berg wrote: Your best workaround may just be to ignore VHT for now - clearly it's broken so using "just" HT (which is likely not that much of a penalty anyway since you're apparently not using 80 MHz) will

[PATCH net] netlink: not trim skb for mmaped socket when dump

2016-01-28 Thread Ken-ichirou MATSUZAWA
We should not trim skb for mmaped socket since its buf size is fixed and userspace will read as frame which data equals head. mmaped socket will not call recvmsg, means max_recvmsg_len is 0, skb_reserve was not called before commit: db65a3aaf29e. Fixes: db65a3aaf29e (netlink: Trim skb to alloc siz

[PATCH] vxlan: fix a out of bounds access in __vxlan_find_mac

2016-01-28 Thread roy . qing . li
From: Li RongQing The size of all_zeros_mac is 6 byte, but eth_hash() will access the 8 byte, and KASan reported the below bug: [ 8596.479031] BUG: KASan: out of bounds access in __vxlan_find_mac+0x24/0x100 at addr 841514c0 [ 8596.487647] Read of size 8 by task ip/52820 [ 8596.490818] A

[PATCH 3.19.y-ckt 182/210] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-01-28 Thread Kamal Mostafa
3.19.8-ckt14 -stable review patch. If anyone has any objections, please let me know. ---8< From: Vijay Pandurangan [ Upstream commit ce8c839b74e3017996fad4e1b7ba2e2625ede82f ] Packets that arrive from real hardware devices have ip_s

[PATCH net] bonding: Fix ARP monitor validation

2016-01-28 Thread Jay Vosburgh
The current logic in bond_arp_rcv will accept an incoming ARP for validation if (a) the receiving slave is either "active" (here meaning the slave is functioning, not that it is the currently active slave) or, (b) the currently active slave recently sent an ARP probe. This can fai

Re: [RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-28 Thread Marcelo Ricardo Leitner
On Fri, Jan 29, 2016 at 12:36:05AM +0100, Michael Tuexen wrote: > > > On 28 Jan 2016, at 22:03, Marcelo Ricardo Leitner > > wrote: > > > > On Thu, Jan 28, 2016 at 06:54:06PM +0100, Michael Tuexen wrote: > >>> On 28 Jan 2016, at 14:51, David Laight wrote: > >>> > >>> From: Marcelo Ricardo Leit

[3.19.y-ckt stable] Patch "=?UTF-8?q?veth:=20don=E2=80=99t=20modify=20ip=5Fsummed;=20doing?= =?UTF-8?q?=20so=20treats=20packets=20with=20bad=20checksums=20as=20good.?=" has been added to the 3.19.y-ck

2016-01-28 Thread Kamal Mostafa
This is a note to let you know that I have just added a patch titled =?UTF-8?q?veth:=20don=E2=80=99t=20modify=20ip=5Fsummed;=20doing?= =?UTF-8?q?=20so=20treats=20packets=20with=20bad=20checksums=20as=20good.?= to the linux-3.19.y-queue branch of the 3.19.y-ckt extended stable tree which can

Re: [patch net] switchdev: Require RTNL mutex to be held when sending FDB notifications

2016-01-28 Thread David Miller
From: Jiri Pirko Date: Wed, 27 Jan 2016 15:16:43 +0100 > From: Ido Schimmel > > When switchdev drivers process FDB notifications from the underlying > device they resolve the netdev to which the entry points to and notify > the bridge using the switchdev notifier. > > However, since the RTNL m

Re: [PATCH net-next 00/40] net: fec: cleanup/fixes

2016-01-28 Thread David Miller
From: Laci Tele Date: Thu, 28 Jan 2016 23:57:10 +0100 > If he divides it, then it will be even more. Do not top-post.

Re: [PATCH v3 1/4] ipv4: add option to drop unicast encapsulated in L2 multicast

2016-01-28 Thread David Miller
From: Johannes Berg Date: Thu, 28 Jan 2016 13:33:33 +0100 > Is there anything I should do about these patches? > > I see you marked them as "deferred" in patchwork, but I don't really > know how you're using that state. I use it in two situations, the first is the most often used case but doesn

Re: [PATCH 0/9] network driver fixes

2016-01-28 Thread David Miller
From: Arnd Bergmann Date: Wed, 27 Jan 2016 15:04:50 +0100 > These are all fixes for relatively harmless bugs that showed up > in my randconfig testing, so they should not be needed for v4.5 > but get merged into net-next. > > I've managed to address all 'uninitialized variable' warnings that > I

Re: [PATCHv2 net] xen-netfront: request Tx response events more often

2016-01-28 Thread David Miller
From: David Vrabel Date: Tue, 26 Jan 2016 17:12:44 + > From: Malcolm Crossley > > Trying to batch Tx response events results in poor performance because > this delays freeing the transmitted skbs. > > Instead use the standard RING_FINAL_CHECK_FOR_RESPONSES() macro to be > notified once the

Re: [PATCH] net: mv643xx_eth: fix packet corruption with TSO and tiny unaligned packets.

2016-01-28 Thread David Miller
From: Nicolas Schichan Date: Tue, 26 Jan 2016 16:12:35 +0100 > The code in txq_put_data() would use txq->tx_curr_desc to index the > tso_hdrs/tso_hdrs_dma buffers, for less than 8 bytes unaligned > fragments, which is already moved to the next descriptor at the > beginning of the function. > > I

Re: [PATCH net] of: of_mdio: Ensure mdio device is a PHY

2016-01-28 Thread David Miller
From: Andrew Lunn Date: Tue, 26 Jan 2016 15:12:30 +0100 > of_phy_find_device() is used to find the phy device associated with a > device node. It is expected the node is for a PHY device, but in fact > it could of been probed as a generic MDIO device. Ensure the device is > a PHY before returning

Re: pull-request: mac80211 2016-01-26

2016-01-28 Thread David Miller
From: Johannes Berg Date: Tue, 26 Jan 2016 12:00:33 +0100 > After split up the patches from the previous pull request that was > lost in the process, here's a new one with fixes for the current > cycle (I'll follow up with a -next one later.) > > I've also scripted my pull-request sending proces

Re: [PATCH 13/22] net: Fix dependencies for !HAS_IOMEM archs

2016-01-28 Thread David Miller
From: Richard Weinberger Date: Mon, 25 Jan 2016 23:24:12 +0100 > Not every arch has io memory. > So, unbreak the build by fixing the dependencies. > > Signed-off-by: Richard Weinberger Applied.

Re: [PATCH net] tcp: fix tcp_mark_head_lost to check skb len before fragmenting

2016-01-28 Thread David Miller
From: Yuchung Cheng Date: Mon, 25 Jan 2016 14:01:53 -0800 > From: Neal Cardwell > > This commit fixes a corner case in tcp_mark_head_lost() which was > causing the WARN_ON(len > skb->len) in tcp_fragment() to fire. > > tcp_mark_head_lost() was assuming that if a packet has > tcp_skb_pcount(skb

Re: [PATCH net 0/3] fix the transport dead race check by using atomic_add_unless on refcnt

2016-01-28 Thread David Miller
From: Xin Long Date: Fri, 22 Jan 2016 01:49:06 +0800 > Xin Long (3): > sctp: fix the transport dead race check by using atomic_add_unless on > refcnt > sctp: hold transport before we access t->asoc in sctp proc > sctp: remove the dead field of sctp_transport Applied, thanks.

Re: [PATCH net] inet: frag: Always orphan skbs inside ip_defrag()

2016-01-28 Thread David Miller
From: Joe Stringer Date: Fri, 22 Jan 2016 15:49:12 -0800 > Later parts of the stack (including fragmentation) expect that there is > never a socket attached to frag in a frag_list, however this invariant > was not enforced on all defrag paths. This could lead to the > BUG_ON(skb->sk) during ip_do

Re: [patch net 00/11] mlxsw: driver fixes

2016-01-28 Thread David Miller
From: Jiri Pirko Date: Wed, 27 Jan 2016 15:20:15 +0100 > From: Jiri Pirko > > Couple of various mlxsw driver fixes. Series applied, thanks Jiri.

Re: [RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-28 Thread Michael Tuexen
> On 28 Jan 2016, at 22:03, Marcelo Ricardo Leitner > wrote: > > On Thu, Jan 28, 2016 at 06:54:06PM +0100, Michael Tuexen wrote: >>> On 28 Jan 2016, at 14:51, David Laight wrote: >>> >>> From: Marcelo Ricardo Leitner Sent: 27 January 2016 17:07 This patchset is merely a RFC for the

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Linus Torvalds
On Thu, Jan 28, 2016 at 2:12 PM, Johannes Berg wrote: > > Your best workaround may just be to ignore VHT for now - clearly it's > broken so using "just" HT (which is likely not that much of a penalty > anyway since you're apparently not using 80 MHz) will be much better. > > Go into > > _rtl_init_

Re: [PATCH net-next 00/40] net: fec: cleanup/fixes

2016-01-28 Thread David Miller
This is way too many patches to submit at once. Divide this into more digestable pieces. Also the net-next tree is not open.

Re: [PATCH net-next v6 19/19] net: mlx4: use new ETHTOOL_G/SSETTINGS API

2016-01-28 Thread David Miller
From: Eugenia Emantayev Date: Thu, 28 Jan 2016 10:21:53 +0200 > Acked-by: Eugenia Emantayev Please don't quote an entire HUGE patch just to give your ACK. Only quote, at most, the commit message itself. I know it's easy to be lazy, and I also realize that most email clients are terrible and m

Re: [PATCH net-next 08/40] net: fec: move cbd_bufaddr assignment closer to the mapping function

2016-01-28 Thread Johannes Berg
On Thu, 2016-01-28 at 23:02 +0100, Arnd Bergmann wrote: > On Thursday 28 January 2016 14:25:32 Troy Kisky wrote: > > Signed-off-by: Troy Kisky > > --- > >  drivers/net/ethernet/freescale/fec_main.c | 4 ++-- > >  1 file changed, 2 insertions(+), 2 deletions(-) > > [note: missing changelog?] > > >

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Johannes Berg
On Thu, 2016-01-28 at 14:04 -0800, Linus Torvalds wrote: >  > Well, it "makes a difference" in the sense that the warning goes > away. > But it doesn't make things work. In fact, it might be making things > worse. Heh, ok. > Because with that patch, the wireless still authenticates and > associat

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Linus Torvalds
On Thu, Jan 28, 2016 at 1:44 PM, Linus Torvalds wrote: > > I will try Johannes' suggestion on that machine to see if it makes a > difference Well, it "makes a difference" in the sense that the warning goes away. But it doesn't make things work. In fact, it might be making things worse. Because w

Re: [PATCH net-next 08/40] net: fec: move cbd_bufaddr assignment closer to the mapping function

2016-01-28 Thread Arnd Bergmann
On Thursday 28 January 2016 14:25:32 Troy Kisky wrote: > Signed-off-by: Troy Kisky > --- > drivers/net/ethernet/freescale/fec_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) [note: missing changelog?] > diff --git a/drivers/net/ethernet/freescale/fec_main.c > b/drivers/net/e

[PATCH net] net: dsa: mv88e6xxx: fix port VLAN maps

2016-01-28 Thread Vivien Didelot
Currently the port based VLAN maps should be configured to allow every port to egress frames on all other ports, except themselves. The debugfs interface shows that they are misconfigured. For instance, a 7-port switch has the following content in the related register 0x06: GLOBAL GLOBAL2

[PATCH v2] hostap: avoid uninitialized variable use in hfa384x_get_rid

2016-01-28 Thread Arnd Bergmann
The driver reads a value from hfa384x_from_bap(), which may fail, and then assigns the value to a local variable. gcc detects that in in the failure case, the 'rlen' variable now contains uninitialized data: In file included from ../drivers/net/wireless/intersil/hostap/hostap_pci.c:220:0: drivers

Re: [PATCH] hostap: avoid uninitialized variable use in hfa384x_get_rid

2016-01-28 Thread Arnd Bergmann
On Wednesday 27 January 2016 19:26:13 Russell King - ARM Linux wrote: > On Wed, Jan 27, 2016 at 02:45:26PM +0100, Arnd Bergmann wrote: > So, why give the compiler a hard time as you're doing, why make the code > harder to read. What's wrong with: > > spin_lock_bh(&local->baplock); > >

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Linus Torvalds
Adding the RTL people to the cc, and leaving the whole thing quoted at the bottom.. I will try Johannes' suggestion on that machine to see if it makes a difference, but somebody who knows the rtlwifi rate control code should take a double- or triple-look at this. Please? Some googling shows that

[net PATCH] fib_trie: Fix shift by 32 in fib_table_lookup

2016-01-28 Thread Alexander Duyck
The fib_table_lookup function had a shift by 32 that triggered a UBSAN warning. This was due to the fact that I had placed the shift first and then followed it with the check for the suffix length to ignore the undefined behavior. If we reorder this so that we verify the suffix is less than 32 be

[PATCH net-next 15/40] net: fec: set cbd_sc without relying on previous value

2016-01-28 Thread Troy Kisky
Relying on the wrap bit to stay valid once initialized when the controller also writes to this byte seems undesirable since we can easily know what the value should be. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 31 ++- 1 file changed, 1

[PATCH net-next 11/40] net: fec: pass txq to fec_enet_tx_queue instead of queue_id

2016-01-28 Thread Troy Kisky
queue_id is the qid member of struct bufdesc_prop. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c

[PATCH net-next 26/40] net: fec: set cbd_esc only once

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 380c8e2..cf53e21 100644 --- a/drivers/net/ethernet/frees

[PATCH net-next 14/40] net: fec: don't clear all rx queue bits when just one is being checked

2016-01-28 Thread Troy Kisky
FEC_ENET_RXF is 3 separate bits, we only check one queue at a time. So, when the last queue is being checked, it is bad to remove the interrupt on the 1st queue. Also, since this is now done in the napi routine and not the interrupt, it is not needed. Signed-off-by: Troy Kisky --- drivers/net/e

[PATCH net-next 23/40] net: fec: don't set cbd_bufaddr unless no mapping error

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index da2e3c530..29c5781 100644 --- a/drivers/net/etherne

[PATCH net-next 21/40] net: fec: print more debug info in fec_timeout

2016-01-28 Thread Troy Kisky
Print the current interrupt flags and mask and the interrupt state during the last interrupt in fec_timeout. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 1 + drivers/net/ethernet/freescale/fec_main.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/n

[PATCH net-next 27/40] net: fec: enable interrupt on very last descriptor only

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index cf53e21..7258051 100644 --- a/drivers/net/ethernet/freescale/f

[PATCH net-next 07/40] net: fec: don't transfer ownership until descriptor write is complete

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index e8f35fb..b87f80d 100644 --- a/drivers/net/etherne

[PATCH net-next 12/40] net: fec: reduce interrupts

2016-01-28 Thread Troy Kisky
By clearing the NAPI interrupts in the NAPI routine and not in the interrupt handler, we can reduce the number of interrupts. We also don't need any status variables as the registers are still valid. Also, notice that if budget pkts are received, the next call to fec_enet_rx_napi will now continue

[PATCH net-next 08/40] net: fec: move cbd_bufaddr assignment closer to the mapping function

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index b87f80d..15a93f90 100644 --- a/drivers/net/ethernet/freescal

[PATCH net-next 03/40] net: fec: fix fec_enet_get_free_txdesc_num

2016-01-28 Thread Troy Kisky
When first initialized, cur_tx points to the 1st entry in the queue, and dirty_tx points to the last. At this point, fec_enet_get_free_txdesc_num will return tx_ring_size -2. If tx_ring_size -2 entries are now queued, then fec_enet_get_free_txdesc_num should return 0, but it returns tx_ring_size in

[PATCH net-next 09/40] net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 15a93f90..3ed79fd 100644 --- a/drivers/net/ethernet/freescal

[PATCH net-next 19/40] net: fec: dump all tx queues in fec_dump

2016-01-28 Thread Troy Kisky
Dump all tx queues, not just queue 0. Also, disable fec interrupts first. The interrupts will be reenabled in fec_restart. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 36 +-- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a

[PATCH net-next 10/40] net: fec: pass rxq to fec_enet_rx_queue instead of queue_id

2016-01-28 Thread Troy Kisky
The queue_id is the qid member of struct bufdesc_prop. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c

[PATCH net-next 32/40] net: fec: fix err_release in fec_enet_txq_submit_tso

2016-01-28 Thread Troy Kisky
Unmap descriptors upon error. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index ee6

[PATCH net-next 33/40] net: fec: shrink the window for 'tx int lost'

2016-01-28 Thread Troy Kisky
Perform skb_tx_timestamp before transferring ownership This shrinks the window for 'tx int lost' If the packet is transmitted and napi clears the tx interrupt before the txq->bd.cur assignment, then the tx interrupt is effectively lost. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freesca

[PATCH net-next 39/40] ARM: dts: imx6qdl-nitrogen6x: add phy interrupt to eliminate polling

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi index caeed56..1d42331 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.

[PATCH net-next 28/40] net: fec: unmap initial buffer on error

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 7258051..e141f6f 100644 --- a/drivers/net/ethernet/freesc

[PATCH net-next 36/40] net: fec: use mac set by bootloader before fuses

2016-01-28 Thread Troy Kisky
If a bootloader initializes the mac, prefer that to device tree or fuses. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 33 +-- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/dri

[PATCH net-next 37/40] net: fec: add events device file

2016-01-28 Thread Troy Kisky
This is for debug purposes. If a receive interrupt is lost, writing to this file can recover the FEC. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 52 +++ 1 file changed, 52 insertions(+) diff --git a/drivers/net/ethernet/freescale/fec_ma

[PATCH net-next 35/40] net: fec: rename dirty_tx to pending_tx

2016-01-28 Thread Troy Kisky
dirty_tx always pointed to the last entry that was trasmitted. pending_tx always points to the next entry to be transmitted. This should be a little more efficient. This will allow 1 more entry in the queue to be used. That is, ring_size -1 entries instead of ring_size -2. This also allows the re

[PATCH net-next 38/40] net: fec: recover from lost rxf_0 interrupt

2016-01-28 Thread Troy Kisky
The following is true of linux-3.14. I have not been able to verify on mainline, because I cannot get the cpuidle driver to work. If gpio6 workaround is not used for interrupts, then it is possible for the entire receive queue to become full without an interrupt. If that happens, and the last rxf_

[PATCH net-next 34/40] net: fec: update dirty_tx even if no skb

2016-01-28 Thread Troy Kisky
If dirty_tx isn't updated, then dma_unmap_single will be called twice. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/f

[PATCH net-next 16/40] net: fec: eliminate calls to fec_enet_get_prevdesc

2016-01-28 Thread Troy Kisky
This shrinks the code a little. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 34 --- 1 file changed, 9 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c inde

[PATCH net-next 29/40] net: fec: don't free skb when returning busy

2016-01-28 Thread Troy Kisky
>From Documentation/networking/driver.txt If you return NETDEV_TX_BUSY from the ndo_start_xmit method, you must not keep any reference to that SKB and you must not attempt to free it up. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 2 -- 1 file changed, 2 deletions(

[PATCH net-next 30/40] net: fec: move last_bdp assignment for symmetry

2016-01-28 Thread Troy Kisky
This way both if clauses assign last_bdp instead of only one clause overriding the default. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/etherne

[PATCH net-next 22/40] net: fec: call dma_unmap_single on mapped tx buffers at restart

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index bc084ad9..da2e3c530 100644 --- a/drivers/ne

[PATCH net-next 25/40] net: fec: don't free skb until it has been unmapped

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 98b9be2..380c8e2 100644 --- a/drivers/net/ethernet/freescale/fec

[PATCH net-next 17/40] net: fec: move restart test for efficiency

2016-01-28 Thread Troy Kisky
This saves 1 comparison. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 1a838cc..fcbbf0d 100644 -

[PATCH net-next 40/40] ARM: dts: imx6qdl-nitrogen6_max: add phy interrupt to eliminate polling

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi index a35d54f..771f650 100644 --- a/arch/arm/boot/dts/imx6qdl-nitrog

[PATCH net-next 18/40] net: fec: clear cbd_sc after transmission to help with debugging

2016-01-28 Thread Troy Kisky
When the tx queue is dumped, it is easier to see that this entry is idle. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index fcbbf

[PATCH net-next 24/40] net: fec: return NETDEV_TX_BUSY, when not enough space in ring

2016-01-28 Thread Troy Kisky
Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 29c5781..98b9be2 100644 --- a/drivers/net/ethernet/freesca

[PATCH net-next 20/40] net: fec: detect tx int lost

2016-01-28 Thread Troy Kisky
If a tx int is lost, no need to reset the fec. Just mark the event and call napi_schedule. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 36 ++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fe

[PATCH net-next 31/40] net: fec: don't transfer ownership until entire tso is queued

2016-01-28 Thread Troy Kisky
Otherwise, we cannot undo our work if an error condition arises later. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/

[PATCH net-next 02/40] net: fec: fix rx error counts

2016-01-28 Thread Troy Kisky
On an overrun, the other flags are not valid, so don't check them. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 36 +-- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/ne

[PATCH net-next 05/40] net: fec: add variable reg_desc_active to speed things up

2016-01-28 Thread Troy Kisky
There is no need for complex macros every time we need to activate a queue. Also, no need to call skb_get_queue_mapping when we already know which queue it is using. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 7 + drivers/net/ethernet/freescale/fec_main.c | 44

[PATCH net-next 13/40] net: fec: split off napi routine with 3 queues

2016-01-28 Thread Troy Kisky
If we only have 1 tx/rx queue, we need not check the other queues. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec_main.c | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net

[PATCH net-next 06/40] net: fec: don't disable FEC_ENET_TS_TIMER interrupt

2016-01-28 Thread Troy Kisky
Only the interrupt routine processes this condition. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 1 + drivers/net/ethernet/freescale/fec_main.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec.h b/drivers/net/

[PATCH net-next 04/40] net: fec: add struct bufdesc_prop

2016-01-28 Thread Troy Kisky
This reduces code and gains speed. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 29 ++- drivers/net/ethernet/freescale/fec_main.c | 288 -- 2 files changed, 132 insertions(+), 185 deletions(-) diff --git a/drivers/net/ethernet/freescale/

[PATCH net-next 00/40] net: fec: cleanup/fixes

2016-01-28 Thread Troy Kisky
The testing for this series was done on a nitrogen6x. The base commit was commit 7a26019fdecdb45ff784ae4e3b7e0cc9045100ca Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net Testing used imx_v6_v7_defconfig + CONFIG_MICREL_PHY. The processor was running at 996Mhz. The last 2 patches

[PATCH net-next 01/40] net: fec: stop the "rcv is not +last, " error messages

2016-01-28 Thread Troy Kisky
Setting the FTRL register will stop the fec from trying to use multiple receive buffers. Signed-off-by: Troy Kisky --- drivers/net/ethernet/freescale/fec.h | 1 + drivers/net/ethernet/freescale/fec_main.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/ethernet/freescale/f

Re: [PATCH] net: mv643xx_eth: fix packet corruption with TSO and tiny unaligned packets.

2016-01-28 Thread Philipp Kirchhofer
Am 26.01.2016 um 16:12 schrieb Nicolas Schichan: The code in txq_put_data() would use txq->tx_curr_desc to index the tso_hdrs/tso_hdrs_dma buffers, for less than 8 bytes unaligned fragments, which is already moved to the next descriptor at the beginning of the function. If that fragment was the

Re: [RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-28 Thread Marcelo Ricardo Leitner
On Thu, Jan 28, 2016 at 06:54:06PM +0100, Michael Tuexen wrote: > > On 28 Jan 2016, at 14:51, David Laight wrote: > > > > From: Marcelo Ricardo Leitner > >> Sent: 27 January 2016 17:07 > >> This patchset is merely a RFC for the moment. There are some > >> controversial points that I'd like to dis

Re: [RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-28 Thread 'Marcelo Ricardo Leitner'
On Thu, Jan 28, 2016 at 05:30:24PM +, David Laight wrote: > From: 'Marcelo Ricardo Leitner' > > Sent: 28 January 2016 15:53 > > On Thu, Jan 28, 2016 at 01:51:02PM +, David Laight wrote: > > > From: Marcelo Ricardo Leitner > > > > Sent: 27 January 2016 17:07 > > > > This patchset is merely a

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Johannes Berg
On Thu, 2016-01-28 at 11:01 -0800, Linus Torvalds wrote: >  > I used to have the basic original UniFi UAP. I've replaced them with > the newer "AC Lite" version: > > https://www.ubnt.com/unifi/unifi-ap-ac-lite/ > > so it's a fairly big jump from a 2.4GHz-only network to a dual-band > one. >

Re: WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-28 Thread Linus Torvalds
On Thu, Jan 28, 2016 at 4:13 AM, Johannes Berg wrote: > On Wed, 2016-01-27 at 21:34 -0800, Linus Torvalds wrote: > >> .. except now I upgraded the nearest access point, and now wireless >> on that machine no longer works. > > Can you describe the upgrade a bit more, just for background? I used to

Re: KASAN splal in minstrel_ht_update_stats()

2016-01-28 Thread Felix Fietkau
On 2016-01-15 06:23, Konstantin Khlebnikov wrote: > Jan 10 17:56:25 hamm kernel: [184374.378842] > == > Jan 10 17:56:25 hamm kernel: [184374.379001] BUG: KASAN: > slab-out-of-bounds in minstrel_ht_update_stats.isra.7+0x6e1/0x9e0 [...]

Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-01-28 Thread Sergei Shtylyov
On 01/28/2016 06:50 PM, Sergei Shtylyov wrote: From: Kazuya Mizuguchi Kaneko-san, with the amount of the review changes, it might make sense for you to assume the authorship of this patch, only noting it's based on Mizuguchi-san's work. In principle, when you change the original patch, yo

Re: [RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-28 Thread Michael Tuexen
> On 28 Jan 2016, at 14:51, David Laight wrote: > > From: Marcelo Ricardo Leitner >> Sent: 27 January 2016 17:07 >> This patchset is merely a RFC for the moment. There are some >> controversial points that I'd like to discuss before actually proposing >> the patches. > > You also need to look at

Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-01-28 Thread Sergei Shtylyov
On 01/24/2016 06:52 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (descriptor, error, management) Looking at the code again, ravb_multi_interrupot() only handles error and gPTP interrupt now. - One interr

RE: [RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-28 Thread David Laight
From: 'Marcelo Ricardo Leitner' > Sent: 28 January 2016 15:53 > On Thu, Jan 28, 2016 at 01:51:02PM +, David Laight wrote: > > From: Marcelo Ricardo Leitner > > > Sent: 27 January 2016 17:07 > > > This patchset is merely a RFC for the moment. There are some > > > controversial points that I'd li

Re: [PATCH/RFC v4 net-next] ravb: Add dma queue interrupt support

2016-01-28 Thread Sergei Shtylyov
On 01/24/2016 06:52 PM, Yoshihiro Kaneko wrote: From: Kazuya Mizuguchi This patch supports the following interrupts. - One interrupt for multiple (descriptor, error, management) - One interrupt for emac - Four interrupts for dma queue (best effort rx/tx, network control rx/tx) This patch imp

Re: [PATCH v1] ethtool: properly indent man sub-options

2016-01-28 Thread Jesse Brandeburg
On Thu, 7 Jan 2016 17:50:43 -0800 Jesse Brandeburg wrote: > The ethtool.8 file was full of lots of incorrectly indented > bits. This fixes the arguments to options to be indented in > a visually appealing way. Hey Ben (ethtool maintainer), I never saw a response to this patch, do I need to rese

Re: UBSAN: Undefined behaviour in net/ipv4/fib_trie.c:1397:22 and UBSAN: Undefined behaviour in ./arch/x86/include/asm/atomic.h:156:2

2016-01-28 Thread Alexander Duyck
On Tue, Jan 26, 2016 at 1:36 PM, Eric Dumazet wrote: > On Tue, 2016-01-26 at 20:45 +0100, Toralf Förster wrote: >> at a 32 nbit KVM image of a Gentoo Linux runniogn v4.5-rc1 - attached is >> /var/log/messages >> > > Jan 26 20:40:04 n22kvm-clone kernel: > =

Re: [PATCH net-next 1/8] net: local checksum offload for encapsulation

2016-01-28 Thread Tom Herbert
On Thu, Jan 28, 2016 at 1:00 AM, Alexander Duyck wrote: > On Wed, Jan 27, 2016 at 11:04 PM, Zang MingJie wrote: >> I have also noticed that for gso, all gso segs will have exactly same outer >> udp checksum, this is also because inner checksum cancellation. >> >> Can we also optimize that outer u

Re: [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

2016-01-28 Thread Paolo Abeni
On Thu, 2016-01-28 at 07:59 -0700, David Ahern wrote: > On 1/27/16 6:45 AM, Paolo Abeni wrote: > > The current implementation of ip6_dst_lookup_tail() basically > > ignore the egress ifindex match: if the saddr is set, > > ip6_route_output() purposefully ignores flowi6_oif, due > > to the commit d4

Re: Bypass at packet-page level (Was: Optimizing instruction-cache, more packets at each stage)

2016-01-28 Thread Jesper Dangaard Brouer
On Thu, 28 Jan 2016 08:37:07 -0800 Tom Herbert wrote: > On Thu, Jan 28, 2016 at 4:45 AM, Eric Dumazet wrote: > > On Thu, 2016-01-28 at 10:25 +0100, Jesper Dangaard Brouer wrote: > > > >> Yes, that is exactly what I'm contemplating :-) That is idea "(1)". > >> > >> A natural extension to this

  1   2   >