Re: [PATCH net v2] skbuff: Fix skb checksum flag on skb pull

2016-01-04 Thread Eric Dumazet
On Mon, 2016-01-04 at 23:08 -0500, David Miller wrote: > From: Eric Dumazet > Date: Wed, 30 Dec 2015 13:05:45 -0500 > > > On Thu, 2015-09-24 at 14:09 -0700, David Miller wrote: > >> From: Pravin B Shelar > >> Date: Tue, 22 Sep 2015 12:57:53 -0700 > >> > >> > VXLAN device can receive skb with ch

Re: [PATCH] af_unix: Fix splice-bind deadlock

2016-01-04 Thread David Miller
From: Rainer Weikusat Date: Sun, 03 Jan 2016 18:56:38 + > On 2015/11/06, Dmitry Vyukov reported a deadlock involving the splice > system call and AF_UNIX sockets, > > http://lists.openwall.net/netdev/2015/11/06/24 > > The situation was analyzed as > > (a while ago) A: socketpair() > B: sp

Re: [PATCH net v2] skbuff: Fix skb checksum flag on skb pull

2016-01-04 Thread David Miller
From: Eric Dumazet Date: Wed, 30 Dec 2015 13:05:45 -0500 > On Thu, 2015-09-24 at 14:09 -0700, David Miller wrote: >> From: Pravin B Shelar >> Date: Tue, 22 Sep 2015 12:57:53 -0700 >> >> > VXLAN device can receive skb with checksum partial. But the checksum >> > offset could be in outer header w

Re: [PATCH net] net: Propagate lookup failure in l3mdev_get_saddr to caller

2016-01-04 Thread David Miller
From: David Ahern Date: Mon, 4 Jan 2016 09:09:27 -0800 > Commands run in a vrf context are not failing as expected on a route lookup: > root@kenny:~# ip ro ls table vrf-red > unreachable default > > root@kenny:~# ping -I vrf-red -c1 -w1 10.100.1.254 > ping: Warning: source addre

Re: [PATCH v4 net-next 0/4] Faster SO_REUSEPORT

2016-01-04 Thread David Miller
From: Craig Gallek Date: Mon, 4 Jan 2016 17:41:44 -0500 > This series contains two optimizations for the SO_REUSEPORT feature: > Faster lookup when selecting a socket for an incoming packet and > the ability to select the socket from the group using a BPF program. > > This series only includes

Re: [PATCH net-next 1/3] nfp: free buffers before changing MTU

2016-01-04 Thread David Miller
From: Jakub Kicinski Date: Mon, 4 Jan 2016 16:03:13 + > For freeing DMA buffers we depend on nfp_net.fl_bufsz having the same > value as during allocation therefore in .ndo_change_mtu we must first > free the buffers and then change the setting. > > Signed-off-by: Jakub Kicinski > Reviewed

Re: [PATCH (net-next.git) 09/18] stmmac: optimize tx desc management

2016-01-04 Thread David Miller
From: Giuseppe Cavallaro Date: Mon, 4 Jan 2016 14:06:54 +0100 > @@ -334,12 +334,11 @@ struct stmmac_desc_ops { > > /* Invoked by the xmit function to prepare the tx descriptor */ > void (*prepare_tx_desc) (struct dma_desc *p, int is_fs, int len, > - int

Re: [PATCH (net-next.git) 04/18] stmmac: remove modulo in stmmac_xmit()

2016-01-04 Thread David Miller
From: Giuseppe Cavallaro Date: Mon, 4 Jan 2016 14:06:49 +0100 > @@ -2056,7 +2068,10 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, > struct net_device *dev) > priv->hw->desc->set_tx_owner(first); > wmb(); > > - priv->cur_tx++; > + if (++entry >= txsize) > +

Re: [PATCH (net-next.git) 02/18] stmmac: rework DMA bus setting and introduce new platform AXI structure

2016-01-04 Thread David Miller
From: Giuseppe Cavallaro Date: Mon, 4 Jan 2016 14:06:47 +0100 > @@ -81,7 +81,7 @@ static void stmmac_default_data(struct plat_stmmacenet_data > *plat) > plat->mdio_bus_data->phy_mask = 0; > > plat->dma_cfg->pbl = 32; > - plat->dma_cfg->burst_len = DMA_AXI_BLEN_256; > + /* T

Re: [PATCH (net-next.git) 01/18] stmmac: share reset function between dwmac100 and dwmac1000

2016-01-04 Thread David Miller
From: Giuseppe Cavallaro Date: Mon, 4 Jan 2016 14:06:46 +0100 > @@ -376,7 +376,8 @@ extern const struct stmmac_desc_ops ndesc_ops; > /* Specific DMA helpers */ > struct stmmac_dma_ops { > /* DMA core initialization */ > - int (*init) (void __iomem *ioaddr, int pbl, int fb, int mb, > +

Re: [PATCH RFC] vhost: basic device IOTLB support

2016-01-04 Thread Yang Zhang
On 2016/1/4 14:22, Jason Wang wrote: On 01/04/2016 09:39 AM, Yang Zhang wrote: On 2015/12/31 15:13, Jason Wang wrote: This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace(qemu) implementation of iommu for a secure DMA environment in

Re: [patch net-next 0/4] mlxsw: couple of fixes

2016-01-04 Thread David Miller
From: Jiri Pirko Date: Mon, 4 Jan 2016 10:42:22 +0100 > Couple of fixes from Ido. Series applied, thanks Jiri. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH net] r8152: add reset_resume function

2016-01-04 Thread David Miller
From: Hayes Wang Date: Mon, 4 Jan 2016 14:38:46 +0800 > When the reset_resume() is called, the flag of SELECTIVE_SUSPEND should be > cleared and reinitialize the device, whether the SELECTIVE_SUSPEND is set > or not. If reset_resume() is called, it means the power supply is cut or the > device is

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread David Miller
From: Tom Herbert Date: Sun, 3 Jan 2016 15:22:27 -0800 > Implement assembly routine for csum_partial for 64 bit x86. This > primarily speeds up checksum calculation for smaller lengths such as > those that are present when doing skb_postpull_rcsum when getting > CHECKSUM_COMPLETE from device or a

Re: [PATCH] chelsio: constify cphy_ops structures

2016-01-04 Thread David Miller
From: Julia Lawall Date: Sun, 3 Jan 2016 14:09:37 +0100 > The cphy_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied, thanks Julia. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [RFC PATCH net-next 00/24] Support MDIO devices

2016-01-04 Thread Andrew Lunn
> - what kind of API do we need to offer to Ethernet MAC driver? Would > attach/detach and maybe adjust_link be good enough? I was not going to offer it any! At least not at the MDIO layer. Maybe i have DSA too much in mind. But all we need for DSA is probe and remove. When the MDIO device is pro

Re: [PATCH] fsl/fman: allow modular build

2016-01-04 Thread David Miller
From: Arnd Bergmann Date: Fri, 01 Jan 2016 14:55:24 +0100 > ARM allmodconfig fails because of the addition of the FMAN driver: > > drivers/built-in.o: In function `dtsec_restart_autoneg': > binder.c:(.text+0x173328): undefined reference to `mdiobus_read' > binder.c:(.text+0x173348): undefined re

Re: [PATCH] ip_tunnel: make ip6tunnel_xmit definition conditional

2016-01-04 Thread David Miller
From: Arnd Bergmann Date: Fri, 01 Jan 2016 14:48:59 +0100 > From 433df301cf49624871346fa63f3fc65033caeda3 Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann > Date: Fri, 1 Jan 2016 13:18:48 +0100 > Subject: [PATCH] net: make ip6tunnel_xmit definition conditional > > Moving the caller of iptunnel_xm

Re: [GIT] [4.5] NFC update

2016-01-04 Thread David Miller
From: Samuel Ortiz Date: Thu, 31 Dec 2015 20:26:37 +0100 > This is the first NFC pull request for 4.5 and it brings: > > - A new driver for the STMicroelectronics ST95HF NFC chipset. > The ST95HF is an NFC digital transceiver with an embedded analog > front-end and as such relies on the Linu

Re: [PATCH] connector: bump skb->users before callback invocation

2016-01-04 Thread David Miller
From: Florian Westphal Date: Thu, 31 Dec 2015 14:26:33 +0100 > Dmitry reports memleak with syskaller program. > Problem is that connector bumps skb usecount but might not invoke callback. > > So move skb_get to where we invoke the callback. > > Reported-by: Dmitry Vyukov > Signed-off-by: Flori

[PATCH] staging: r8192U: Fix check pointer after usage problem

2016-01-04 Thread Larry Finger
In routine rtl8192_tx_isr(), pointer skb is dereferenced before it is checked for NULL. This patch has only been compile-tested, as I do not have the hardware. This problem was reported at https://bugzilla.kernel.org/show_bug.cgi?id=109951. Fixes: bugzilla.kernel.org: #109951 Reported-by: Yong Shi

[PATCH] netfilter: nf_conntrack: use safer way to lock all buckets

2016-01-04 Thread Sasha Levin
When we need to lock all buckets in the connection hashtable we'd attempt to lock 1024 spinlocks, which is way more preemption levels than supported by the kernel. Furthermore, this behavior was hidden by checking if lockdep is enabled, and if it was - use only 8 buckets(!). Fix this by using a gl

Re: [RFC PATCH net-next 00/24] Support MDIO devices

2016-01-04 Thread Florian Fainelli
Hi Andrew, On 04/01/16 09:36, Andrew Lunn wrote: > The discussions about changing the way DSA probes switches resulted in > the wish to have switches attached to an MDIO bus to be represented as > an MDIO device. However the current code only supports PHYs on MDIO > busses. This patchset remedies

Re: [RFC PATCH net-next 22/24] mdio: Abstract device_remove() and device_free()

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:37, Andrew Lunn wrote: > Make device_free and device_remove operations in the mdio device > structure, so the core code does not need to differentiate between > phy devices and generic mdio devices. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To un

Re: [RFC PATCH net-next 21/24] mdio: Add support for mdio drivers.

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Not all devices on an MDIO bus are PHYs. Meaning not all MDIO drivers > are PHY drivers. Add support for generic MDIO drivers. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubs

Re: [RFC PATCH net-next 20/24] mdio_bus: Add comment to mdiobus_scan() and __mdiobus_register()

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Make it clear that mdiobus_scan () will only find devices which have a > vendor/product ID in registers 2 and 3. These are typically PHY > devices. Other sort of MDIO devices, such as switches, are not > expected to be found during the scan. > > Similarly, _

Re: [RFC PATCH net-next 19/24] mdio_bus: Generalise of_mdiobus_link_phydev()

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > This function should work with any sort of MDIO device which can be > probed on the bus, not just PHY devices. So generalise it. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsu

Re: [RFC PATCH net-next 17/24] phy: Centralize setting driver module owner

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Rather than have each driver set the driver owner field, do it once in > the core code. This will also help with later changes, when the device > structure will move. Another thing that should have been taken care of long before, thanks! > > Signed-off-by:

Re: [RFC PATCH net-next 18/24] phy: Move phy specific bus match into phy_device

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Matching a driver to a device has both generic parts, and parts which > are specific to PHY devices. Move the PHY specific parts into > phy_device. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list:

Re: [RFC PATCH net-next 16/24] phy: Move PHY PM operations into phy_device

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > The MDIO PM operations are really PHY device PM operations. So move > them into phy_device. This will be needed when we support devices on > the mdio bus which are not PHYs. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To un

Re: [RFC PATCH net-next 15/24] dsa: Register netdev before phy

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > When the phy is connected, an info message is printed. If the netdev > it is attached to has not been registered yet, the name > 'uninitialised' in the output. By registering the netdev first, then > connecting they phy, we can avoid this. > > Signed-off-by:

Re: [RFC PATCH net-next 14/24] phy_device: Move phy attributes into phy_device

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > The mdio_bus exports three attributes. However these are all phy > attributes, not generic mdio attributes. So move the attributes into > the phy device code. It could help to mention why just in case you have to respin that patch series: - PHY ID is the un

Re: [RFC PATCH net-next 13/24] phy: Add API for {un{registering an mdio device to a bus.

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Rather than have drivers directly manipulate the mii_bus structure, > provide and API for registering and unregistering devices on an MDIO > bus, and performing lookups. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubs

Re: [RFC PATCH net-next 11/24] phy: Add an mdio_device structure

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Not all devices attached to an MDIO bus are phys. So add an > mdio_device structure to represent the generic parts of an mdio > device, and place this structure into the phy_device. This looks good to me, I am just wondering if it would make sense to introdu

linux-next: manual merge of the rdma tree with the net-next tree

2016-01-04 Thread Stephen Rothwell
Hi Doug, Today's linux-next merge of the rdma tree got conflicts in: drivers/net/ethernet/mellanox/mlx5/core/vport.c include/linux/mlx5/mlx5_ifc.h include/linux/mlx5/vport.h between commits: e1d7d349c69d ("net/mlx5: Update access functions to Query/Modify vport MAC address") e7546514

Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits

2016-01-04 Thread Jia-Ju Bai
On 01/05/2016 12:50 AM, Helmut Schaa wrote: On Mon, Jan 4, 2016 at 8:55 AM, Jia-Ju Bai wrote: The driver calls pci_set_mwi to enable memory-write-invalidate when it is initialized, but does not call pci_clear_mwi when it is removed. Many other drivers calls pci_clear_mwi when pci_set_mwi is cal

Re: [PATCH net-next 0/4] batch calls to fib_flush and arp_ifdown

2016-01-04 Thread Salam Noureddine
On Mon, Jan 4, 2016 at 4:35 PM, Eric W. Biederman wrote: > Two things would be very valuable with this patchset. > > Some numbers on how much your changes have improved the code in the case > you care about. I suspect the improvements are not subtle so this > should not be hard. > > Can you plea

Re: [PATCH net-next 0/4] batch calls to fib_flush and arp_ifdown

2016-01-04 Thread Eric W. Biederman
Salam Noureddine writes: > fib_flush walks the whole fib in a net_namespace and is called for > each net_device being closed or unregistered. This can be very expensive > when dealing with 100k or more routes in the fib and removal of a lot > of interfaces. These four patches deal with this issue

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Tom Herbert
On Mon, Jan 4, 2016 at 3:52 PM, Eric Dumazet wrote: > On Mon, 2016-01-04 at 15:34 -0800, Tom Herbert wrote: >> On Mon, Jan 4, 2016 at 2:36 PM, Eric Dumazet wrote: >> > On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: >> > \... >> >> +402: /* Length 2, align is 1, 3, or 5 */ >> >> + movb

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

2016-01-04 Thread Julian Calaby
Hi Markus, On Mon, Jan 4, 2016 at 11:33 PM, SF Markus Elfring wrote: >>> May I resend a consistent patch series for the source file >>> "drivers/net/wireless/rsi/rsi_91x_pkt.c" in the near future? >> >> If you were sending checkpatch.pl fixes that would be easier to deal with > > Does this feedba

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Eric Dumazet
On Mon, 2016-01-04 at 15:34 -0800, Tom Herbert wrote: > On Mon, Jan 4, 2016 at 2:36 PM, Eric Dumazet wrote: > > On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: > > \... > >> +402: /* Length 2, align is 1, 3, or 5 */ > >> + movb(%rdi), %al > >> + movb1(%rdi), %ah > > > > Looks

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Hannes Frederic Sowa
On 05.01.2016 00:34, Tom Herbert wrote: On Mon, Jan 4, 2016 at 2:36 PM, Eric Dumazet wrote: On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: \... +402: /* Length 2, align is 1, 3, or 5 */ + movb(%rdi), %al + movb1(%rdi), %ah Looks like a movw (%rdi),%ax Wouldn't that b

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Tom Herbert
On Mon, Jan 4, 2016 at 2:36 PM, Eric Dumazet wrote: > On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: > \... >> +402: /* Length 2, align is 1, 3, or 5 */ >> + movb(%rdi), %al >> + movb1(%rdi), %ah > > Looks like a movw (%rdi),%ax > Wouldn't that be an unaligned access? > > A

Re: [PATCH] af_unix: Fix splice-bind deadlock

2016-01-04 Thread Hannes Frederic Sowa
Hello, On Sun, Jan 3, 2016, at 19:03, Rainer Weikusat wrote: > Rainer Weikusat writes: > > > Hannes Frederic Sowa writes: > >> On 27.12.2015 21:13, Rainer Weikusat wrote: > >>> -static int unix_mknod(const char *sun_path, umode_t mode, struct path > >>> *res) > >>> +static int unix_mknod(struc

[PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-01-04 Thread Salam Noureddine
This can be used to optimize bringing down and unregsitering net_devices by running certain cleanup operations only on the net namespace instead of on each net_device. Signed-off-by: Salam Noureddine --- include/linux/netdevice.h | 2 ++ net/core/dev.c| 39 ++

[PATCH net-next 1/4] net: add event_list to struct net and provide utility functions

2016-01-04 Thread Salam Noureddine
Signed-off-by: Salam Noureddine --- include/net/net_namespace.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index 4089abc..4cf47de 100644 --- a/include/net/net_namespace.h +++ b/include/net/net_namespace.h

[PATCH net-next 4/4] net: fib: avoid calling fib_flush for each device when doing batch close and unregister

2016-01-04 Thread Salam Noureddine
Call fib_flush at the end when closing or unregistering multiple devices. This can save walking the fib many times and greatly reduce rtnl_lock hold time when unregistering many devices with a fib having hundreds of thousands of routes. Signed-off-by: Salam Noureddine --- include/net/netns/ipv4.

[PATCH net-next 3/4] net: core: introduce neigh_ifdown_all for all down interfaces

2016-01-04 Thread Salam Noureddine
This cleans up neighbour entries for all interfaces in the down state, avoiding walking the whole neighbour table for each interface being brought down. Signed-off-by: Salam Noureddine --- include/net/arp.h | 1 + include/net/neighbour.h | 1 + net/core/neighbour.c| 38 ++

[PATCH net-next 0/4] batch calls to fib_flush and arp_ifdown

2016-01-04 Thread Salam Noureddine
fib_flush walks the whole fib in a net_namespace and is called for each net_device being closed or unregistered. This can be very expensive when dealing with 100k or more routes in the fib and removal of a lot of interfaces. These four patches deal with this issue by calling fib_flush just once for

Re: [PATCH v4 net-next 1/4] soreuseport: define reuseport groups

2016-01-04 Thread Eric Dumazet
On Mon, 2016-01-04 at 17:41 -0500, Craig Gallek wrote: > From: Craig Gallek > Acked-by: Eric Dumazet -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 net-next 4/4] soreuseport: BPF selection functional test

2016-01-04 Thread Alexei Starovoitov
On Mon, Jan 04, 2016 at 05:41:48PM -0500, Craig Gallek wrote: > From: Craig Gallek > > This program will build classic and extended BPF programs and > validate the socket selection logic when used with > SO_ATTACH_REUSEPORT_CBPF and SO_ATTACH_REUSEPORT_EBPF. > > It also validates the re-programi

Re: [PATCH v4 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Alexei Starovoitov
On Mon, Jan 04, 2016 at 05:41:47PM -0500, Craig Gallek wrote: > From: Craig Gallek > > Expose socket options for setting a classic or extended BPF program > for use when selecting sockets in an SO_REUSEPORT group. These options > can be used on the first socket to belong to a group before bind o

Re: next-20160104 build: 3 failures 15 warnings (next-20160104)

2016-01-04 Thread Mark Brown
On Mon, Jan 04, 2016 at 11:07:41PM +0100, Arnd Bergmann wrote: > On Monday 04 January 2016 16:50:25 Mark Brown wrote: > > On Mon, Jan 04, 2016 at 12:12:20PM +, Build bot for Mark Brown wrote: > > and various other linker errors caused by the fact that the new fman > > driver uses PHYLIB but do

[PATCH v4 net-next 2/4] soreuseport: fast reuseport UDP socket selection

2016-01-04 Thread Craig Gallek
From: Craig Gallek Include a struct sock_reuseport instance when a UDP socket binds to a specific address for the first time with the reuseport flag set. When selecting a socket for an incoming UDP packet, use the information available in sock_reuseport if present. This required adding an additi

[PATCH v4 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Craig Gallek
From: Craig Gallek Expose socket options for setting a classic or extended BPF program for use when selecting sockets in an SO_REUSEPORT group. These options can be used on the first socket to belong to a group before bind or on any socket in the group after bind. This change includes refactori

[PATCH v4 net-next 0/4] Faster SO_REUSEPORT

2016-01-04 Thread Craig Gallek
From: Craig Gallek This series contains two optimizations for the SO_REUSEPORT feature: Faster lookup when selecting a socket for an incoming packet and the ability to select the socket from the group using a BPF program. This series only includes the UDP path. I plan to submit a follow-up incl

[PATCH v4 net-next 1/4] soreuseport: define reuseport groups

2016-01-04 Thread Craig Gallek
From: Craig Gallek struct sock_reuseport is an optional shared structure referenced by each socket belonging to a reuseport group. When a socket is bound to an address/port not yet in use and the reuseport flag has been set, the structure will be allocated and attached to the newly bound socket.

[PATCH v4 net-next 4/4] soreuseport: BPF selection functional test

2016-01-04 Thread Craig Gallek
From: Craig Gallek This program will build classic and extended BPF programs and validate the socket selection logic when used with SO_ATTACH_REUSEPORT_CBPF and SO_ATTACH_REUSEPORT_EBPF. It also validates the re-programing flow and several edge cases. Signed-off-by: Craig Gallek --- tools/tes

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Eric Dumazet
On Sun, 2016-01-03 at 15:22 -0800, Tom Herbert wrote: \... > +402: /* Length 2, align is 1, 3, or 5 */ > + movb(%rdi), %al > + movb1(%rdi), %ah Looks like a movw (%rdi),%ax Also you probably should send this patch to x86 maintainers. -- To unsubscribe from this list: send the l

Re: [PATCH v3 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Craig Gallek
On Mon, Jan 4, 2016 at 3:11 PM, Alexei Starovoitov wrote: > On Mon, Jan 04, 2016 at 11:26:37AM -0500, Craig Gallek wrote: >> From: Craig Gallek >> >> Expose socket options for setting a classic or extended BPF program >> for use when selecting sockets in an SO_REUSEPORT group. These options >> c

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2016-01-04 Thread David Miller
From: Xin Long Date: Wed, 30 Dec 2015 23:50:45 +0800 > for telecom center, the usual case is that a server is connected by thousands > of clients. but if the server with only one enpoint(udp style) use the same > sport and dport to communicate with every clients, and every assoc in server > will

Re: [PATCH net-next] udp: properly support MSG_PEEK with truncated buffers

2016-01-04 Thread David Miller
From: Eric Dumazet Date: Wed, 30 Dec 2015 08:51:12 -0500 > From: Eric Dumazet > > Backport of this upstream commit into stable kernels : > 89c22d8c3b27 ("net: Fix skb csum races when peeking") > exposed a bug in udp stack vs MSG_PEEK support, when user provides > a buffer smaller than skb paylo

Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

2016-01-04 Thread David Miller
From: Heinrich Schuchardt Date: Tue, 29 Dec 2015 23:22:02 +0100 > IOCTL SIOCRTMSG does nothing but return EINVAL. > > So comment it as unused. > > Signed-off-by: Heinrich Schuchardt Please enhance your commit log message to include the analysis you provided in your reply to Michael Kerrisk. -

Re: [PATCH] cxgb4: correctly handling failed allocation

2016-01-04 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 17:20:11 -0500 > Since t4_alloc_mem can be failed in memory pressure, > if not properly handled, NULL dereference could be happened. > > Signed-off-by: Insu Yun Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH net-next] net: Implement fast csum_partial for x86_64

2016-01-04 Thread Hannes Frederic Sowa
On 04.01.2016 00:22, Tom Herbert wrote: Implement assembly routine for csum_partial for 64 bit x86. This primarily speeds up checksum calculation for smaller lengths such as those that are present when doing skb_postpull_rcsum when getting CHECKSUM_COMPLETE from device or after CHECKSUM_UNNECESSA

Re: [PATCH] mISDN: correctly handling failed allocation in fsm

2016-01-04 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 16:41:33 -0500 > Since kzalloc can be failed in memory pressure, > NULL dereference can be happened. > > Signed-off-by: Insu Yun Similarly to your other mISDN patch you must propagate and handle errors properly. -- To unsubscribe from this list: send the l

Re: [PATCH] mISDN: correctly handling failed allocation

2016-01-04 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 16:38:46 -0500 > Since kzalloc can be failed in memory pressure, > NULL dereference might be happened. > > Signed-off-by: Insu Yun Sorry, this is not a correct fix. You need to propagate an error back to the callers, and they must act upon that error. --

Re: [PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args

2016-01-04 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 15:02:18 -0500 > Since qlcnic_alloc_mbx_args can be failed, > return value should be checked. > > Signed-off-by: Insu Yun Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kern

Re: next-20160104 build: 3 failures 15 warnings (next-20160104)

2016-01-04 Thread Arnd Bergmann
On Monday 04 January 2016 16:50:25 Mark Brown wrote: > On Mon, Jan 04, 2016 at 12:12:20PM +, Build bot for Mark Brown wrote: > > Today's linux-next fails to build an arm allmodconfig (and probably also > at least arm64 though other errors prevent that getting to linking > currently) due to: >

Re: [PATCH 2/4] net: phy: at803x: Allow specifying the RGMII RX clock delay via phy mode

2016-01-04 Thread Florian Fainelli
On 04/01/16 13:17, Martin Blumenstingl wrote: > On Sun, Dec 27, 2015 at 9:22 PM, Mason wrote: >> On 27/12/2015 04:28, Florian Fainelli wrote: >> >>> Le 25/12/2015 16:27, Martin Blumenstingl wrote: >>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index f566b6e..0b262a2

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

2016-01-04 Thread Saeed Mahameed
Sorry my mistake, please ignore my last email, just got your response on the matter, On Mon, Jan 4, 2016 at 11:57 PM, Saeed Mahameed wrote: > Hi Dave, > > Any chance you are giving this a shot ? > > On Tue, Dec 29, 2015 at 2:58 PM, Saeed Mahameed wrote: >> Hi Dave, >> >> This patch series intro

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

2016-01-04 Thread Saeed Mahameed
Hi Dave, Any chance you are giving this a shot ? On Tue, Dec 29, 2015 at 2:58 PM, Saeed Mahameed wrote: > Hi Dave, > > This patch series introduces the support for ConnectX-4 timestamping > and the PTP kernel interface. > > Changes from V2: > net/mlx5_core: Introduce access function to read inte

Re: [PATCH net-next 0/3] Fix some typos in setting hardware parameter

2016-01-04 Thread David Miller
From: Chunhao Lin Date: Tue, 29 Dec 2015 22:13:36 +0800 > The typos are in setting RTL8168DP, RTL8168EP and RTL8168H hardware > parameters. > This series of patch fix these typos. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messa

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

2016-01-04 Thread David Miller
From: Saeed Mahameed Date: Tue, 29 Dec 2015 14:58:28 +0200 > This patch series introduces the support for ConnectX-4 timestamping > and the PTP kernel interface. Richard, please review this series. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mes

Re: [PATCH net-next] l2tp: rely on ppp layer for skb scrubbing

2016-01-04 Thread David Miller
From: Guillaume Nault Date: Tue, 29 Dec 2015 13:06:59 +0100 > Since 79c441ae505c ("ppp: implement x-netns support"), the PPP layer > calls skb_scrub_packet() whenever the skb is received on the PPP > device. Manually resetting packet meta-data in the L2TP layer is thus > redundant. > > Signed-of

Re: [PATCH] unix: properly account for FDs passed over unix sockets

2016-01-04 Thread David Miller
From: Willy Tarreau Date: Mon, 28 Dec 2015 15:14:35 +0100 > It is possible for a process to allocate and accumulate far more FDs than > the process' limit by sending them over a unix socket then closing them > to keep the process' fd count low. > > This change addresses this problem by keeping t

Re: [PATCH 2/4] net: phy: at803x: Allow specifying the RGMII RX clock delay via phy mode

2016-01-04 Thread Martin Blumenstingl
On Sun, Dec 27, 2015 at 9:22 PM, Mason wrote: > On 27/12/2015 04:28, Florian Fainelli wrote: > >> Le 25/12/2015 16:27, Martin Blumenstingl wrote: >> >>> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c >>> index f566b6e..0b262a2 100644 >>> --- a/drivers/net/phy/at803x.c >>> +++ b/d

Re: [RFC PATCH net-next 08/24] phy: Centralise print about attached phy

2016-01-04 Thread Andrew Lunn
On Mon, Jan 04, 2016 at 12:15:50PM -0800, Florian Fainelli wrote: > On 04/01/16 09:36, Andrew Lunn wrote: > > Many Ethernet drivers contain the same netdev_info() print statement > > about the attached phy. Move it into the phy device code. > > > > Signed-off-by: Andrew Lunn > > --- > > [snip] >

Re: [PATCH 0/2] sh_eth: remove unused BE descriptor support

2016-01-04 Thread David Miller
From: Sergei Shtylyov Date: Mon, 28 Dec 2015 02:05:24 +0300 >Here's a set of 2 patches against DaveM's 'net-next.git' repo plus the > recently merged to 'net.git' repo fix for the 16-bit descriptor endianness. > We get rid of ~30 LoCs and ~300 bytes of code. Series applied, thanks Sergei. --

Re: [PATCH 6/6] tilepro: use to_delayed_work

2016-01-04 Thread David Miller
From: Geliang Tang Date: Fri, 1 Jan 2016 23:48:57 +0800 > Use to_delayed_work() instead of open-coding it. > > Signed-off-by: Geliang Tang Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [RFC PATCH net-next 12/24] of: phy: Only register a phy device for phys

2016-01-04 Thread Andrew Lunn
On Mon, Jan 04, 2016 at 12:01:04PM -0800, Florian Fainelli wrote: > On 04/01/16 09:36, Andrew Lunn wrote: > > We will soon support devices other than phys on the mdio bus. Look at > > a child's compatibility string to determine if it is a phy, before > > registering a phy device. > > > > Signed-of

Re: [PATCH net-next 0/7] bnxt_en: Support combined and rx/tx channels.

2016-01-04 Thread David Miller
From: Michael Chan Date: Sat, 2 Jan 2016 23:44:57 -0500 > The bnxt hardware uses a completion ring for rx and tx events. The driver > has to process the completion ring entries sequentially for the events. > The current code only supports an rx/tx ring pair for each completion ring. > This patch

Re: [RFC PATCH net-next 09/24] phy: mdio-octeon: Use devm_mdiobus_alloc_size()

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Rather than use devm_kzalloc(), use the mdio helper function. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.o

Re: [RFC PATCH net-next 10/24] mdio: Move allocation of interrupts into core

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Have mdio_alloc() create the array of interrupt numbers, and > initialize it to POLLING. This is what most MDIO drivers want, so > allowing code to be removed from the drivers. Yeah, this should have been done a long time ago, thanks! Reviewed-by: Florian F

Re: [RFC PATCH net-next 08/24] phy: Centralise print about attached phy

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Many Ethernet drivers contain the same netdev_info() print statement > about the attached phy. Move it into the phy device code. > > Signed-off-by: Andrew Lunn > --- [snip] > diff --git a/drivers/net/ethernet/adi/bfin_mac.c > b/drivers/net/ethernet/adi/b

Re: [PATCH v3 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2016-01-04 Thread Alexei Starovoitov
On Mon, Jan 04, 2016 at 11:26:37AM -0500, Craig Gallek wrote: > From: Craig Gallek > > Expose socket options for setting a classic or extended BPF program > for use when selecting sockets in an SO_REUSEPORT group. These options > can be used on the first socket to belong to a group before bind o

[PATCH V2 5/5] i40e/ethtool: support coalesce setting by queue

2016-01-04 Thread kan . liang
From: Kan Liang This patch implements set_per_queue_coalesce for i40e driver. For i40e driver, only rx and tx usecs have per queue value. Usually, the queues number is the same as vectors number. Queue has its own vector. Changing these two parameters by setting specific vector only impact the sp

[PATCH V2 4/5] i40e/ethtool: support coalesce getting by queue

2016-01-04 Thread kan . liang
From: Kan Liang This patch implements get_per_queue_coalesce for i40e driver. For i40e driver, only rx and tx usecs has per queue value. So only these two parameters are read from specific vectors. Usually, the queues number is the same as vectors number. Queue has its own vector. However, someti

[PATCH V2 1/5] net/ethtool: introduce a new ioctl for per queue setting

2016-01-04 Thread kan . liang
From: Kan Liang Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting. The following patches will enable some SUB_COMMANDs for per queue setting. Signed-off-by: Kan Liang --- Changes since V1: - Checking the sub-command number to determine whether the command requires CAP

[PATCH V2 2/5] net/ethtool: support get coalesce per queue

2016-01-04 Thread kan . liang
From: Kan Liang This patch implements sub command ETHTOOL_GCOALESCE for ioctl ETHTOOL_PERQUEUE. It introduces an interface get_per_queue_coalesce to get coalesce of each masked queue from device driver. Then the interrupt coalescing parameters will be copied back to user space one by one. Signed

[PATCH V2 3/5] net/ethtool: support set coalesce per queue

2016-01-04 Thread kan . liang
From: Kan Liang This patch implements sub command ETHTOOL_SCOALESCE for ioctl ETHTOOL_PERQUEUE. It introduces an interface set_per_queue_coalesce to set coalesce of each masked queue to device driver. The wanted coalesce information are stored in "data" for each masked queue, which can copy from

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread Tejun Heo
Hello, On Mon, Jan 04, 2016 at 12:59:15PM -0700, David Ahern wrote: > cgroups have very nice properties that I want to leverage such as > parent-child inheritance and easy tracking which subsystem instance a task > belongs. This provides a great kernel foundation for building easy to use > managem

Re: [RFC PATCH net-next 07/24] phy: phy_{read|write}_mmd_indirect: get addr from phydev

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > The address of the device can be determined from the phydev structure, > rather than passing it as a parameter. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: [RFC PATCH net-next 04/24] phy: Add phydev_err() and phydev_dbg() macros

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > In preparation for moving some of the phy_device structure members, > add macros for printing errors and debug information. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscri

Re: [RFC PATCH net-next 06/24] net: dnet: Use phy_find_first() helper

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Replace the open coded search for the first phy with a call to the > existing helper function. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [RFC PATCH net-next 03/24] phy: Use phy_read() instead of mdiobus_read()

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Since we have a phydev, make use of it and the phy_read() function. > This will help with later refactoring. > > Signed-off-by: Andrew Lunn > --- [snip] > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c > index 47cd306dbb3c..67a77956ae6f 10064

Re: [RFC PATCH net-next 02/24] mdio: Move mdiobus_read/write operatings into mdio.h

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > These are logically MDIO operations, not phy operations, so move them > into the mdio header. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [RFC PATCH net-next 01/24] phy: Consistently use addr for address on an MII bus

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > Within phy.h, an address on an MII bus has been called both addr and > phy_id. phy_id is particularly confusion, since it also means the ID > found in register 3, if the device on the bus is a phy. Consistently > use addr. > > Signed-off-by: Andrew Lunn Re

Re: [RFC PATCH net-next 12/24] of: phy: Only register a phy device for phys

2016-01-04 Thread Florian Fainelli
On 04/01/16 09:36, Andrew Lunn wrote: > We will soon support devices other than phys on the mdio bus. Look at > a child's compatibility string to determine if it is a phy, before > registering a phy device. > > Signed-off-by: Andrew Lunn > --- [snip] > + if (of_get_phy_id(child, &phy_id) !=

Re: [RFC PATCH net-next] net: Add l3mdev cgroup

2016-01-04 Thread David Ahern
On 1/4/16 12:23 PM, Tejun Heo wrote: I don't have an answer for that but cgroup isn't a place to put such stray configurations either. Please figure out where the configuration belongs first. What you're proposing really isn't a resource controller. There's no resource being distributed hierar

  1   2   3   >