This ixgbe_mbx_operations structure is never modified, so declare it as
const. The other structure of this type is already const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.c |2 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_m
This e1000_phy_operations structure is never modified, so declare it as
const. Other structures of this type are already const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/net/ethernet/intel/igb/e1000_82575.c |2 +-
drivers/net/ethernet/intel/igb/e1000_hw.h
In order to support dedicated or shared completion rings, the ring
indexing and mapping are re-structured as below:
1. bp->grp_info[] array index is 1:1 with bp->bnapi[] array index and
completion ring index.
2. rx rings 0 to n will be mapped to completion rings 0 to n.
3. If tx and rx rings sha
Currently, an rx and a tx ring are always paired with a completion ring.
We want to restructure it so that it is possible to have a dedicated
completion ring for tx or rx only.
The bnxt hardware uses a completion ring for rx and tx events. The driver
has to process the completion ring entries seq
Add logic to calculate how many shared or non shared rings can be
supported. Default is to use shared rings.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 96 +--
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +-
drivers/net/eth
By adding 3 separate functions to dump the different ring states.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 50 ---
1 file changed, 33 insertions(+), 17 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
b/drivers/n
The driver can support either all combined or all rx/tx rings. The
default is combined, but the user can now select rx/tx rings.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 57 ++-
1 file changed, 45 insertions(+), 12 deletions(-)
dif
The bnxt hardware uses a completion ring for rx and tx events. The driver
has to process the completion ring entries sequentially for the events.
The current code only supports an rx/tx ring pair for each completion ring.
This patch series add support for using a dedicated completion ring for
rx o
Modify ring memory allocation and MSIX setup to support shared or
non shared rings and do the proper mapping. Default is still to
use shared rings.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 42 +++
1 file changed, 32 insertions(+), 1
Each bnxt_napi structure may no longer be having both an rx ring and
a tx ring. Check for a valid ring before using it.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 ++-
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/driv
From: Bjørn Mork
Date: Sat, 02 Jan 2016 22:30:48 +0100
> SF Markus Elfring writes:
>
>> From: Markus Elfring
>> Date: Fri, 1 Jan 2016 17:35:03 +0100
>>
>> Omit explicit initialisation at the beginning for one local variable
>> that is redefined before its first use.
>
>
> This patch is unnec
On Sat, 2016-01-02 at 18:50 +0100, SF Markus Elfring wrote:
> A few update suggestions were taken into account
> from static source code analysis.
While static analysis can be useful, I don't think these
specific conversions are generally useful.
Perhaps it would be more useful to convert the str
On Sat, 2016-01-02 at 19:25 -0500, Aaron Conole wrote:
> When signaling that a GRO frame is ready to be processed, the network stack
> correctly checks length and aborts processing when a frame is less than 14
> bytes. However, such a condition is really indicative of a broken driver,
> and should
When signaling that a GRO frame is ready to be processed, the network stack
correctly checks length and aborts processing when a frame is less than 14
bytes. However, such a condition is really indicative of a broken driver,
and should be loudly signaled, rather than silently dropped as the case is
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give US
SF Markus Elfring writes:
> From: Markus Elfring
> Date: Fri, 1 Jan 2016 17:32:07 +0100
>
> Reduce the scope for the local variable "desc" to one branch
> of an if statement.
This patch is harmless. But is also pointless.
You could at least try to explain why this must be changed. I'm not
in
SF Markus Elfring writes:
> From: Markus Elfring
> Date: Fri, 1 Jan 2016 17:35:03 +0100
>
> Omit explicit initialisation at the beginning for one local variable
> that is redefined before its first use.
This patch is unnecessary. The variable initialisation is redundant.
See the difference? S
On 12/29/2015 06:29 PM, Craig Gallek wrote:
From: Craig Gallek
Expose socket options for setting a classic or extended BPF program
for use when selecting sockets in an SO_REUSEPORT group. These options
can be used on the first socket to belong to a group before bind or
on any socket in the gro
From: Markus Elfring
Date: Sat, 2 Jan 2016 19:22:36 +0100
Omit explicit initialisation at the beginning for four local variables
which are redefined before their first use.
Signed-off-by: Markus Elfring
---
drivers/net/wireless/rsi/rsi_91x_pkt.c | 8
1 file changed, 4 insertions(+), 4
On Sat, Jan 2, 2016 at 2:02 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 1 Jan 2016 21:16:01 +0100
>
> Rename a jump label according to the current Linux coding style convention.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/net/wireless/intel/iwlegacy/common.c | 4 ++--
From: Markus Elfring
Date: Sat, 2 Jan 2016 18:28:26 +0100
Omit explicit initialisation at the beginning for one local variable
that is redefined before its first use.
Signed-off-by: Markus Elfring
---
drivers/net/xen-netback/xenbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Markus Elfring
Date: Sat, 2 Jan 2016 18:23:16 +0100
Replace an explicit initialisation for one local variable at the beginning
by an assignment.
Signed-off-by: Markus Elfring
---
drivers/net/xen-netback/xenbus.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/driver
From: Markus Elfring
Date: Sat, 2 Jan 2016 18:01:57 +0100
Replace an explicit initialisation for one local variable at the beginning
by an assignment.
Signed-off-by: Markus Elfring
---
drivers/net/xen-netback/xenbus.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/d
From: Markus Elfring
Date: Sat, 2 Jan 2016 17:50:21 +0100
One goto statement referred to a source code position directly behind it.
Thus omit such an unnecessary jump.
Signed-off-by: Markus Elfring
---
drivers/net/xen-netback/xenbus.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
d
From: Markus Elfring
Date: Sat, 2 Jan 2016 17:32:40 +0100
Remove the assignment for a local variable because its value is not
changed compared to the one from a previous function call.
Signed-off-by: Markus Elfring
---
drivers/net/xen-netback/xenbus.c | 1 -
1 file changed, 1 deletion(-)
diff
Le 02/01/2016 07:11, Romain Perier a écrit :
>>> Signed-off-by: Romain Perier
>>
>> Please include a Fixes tag to help keep track of changes.
>
> Sure, sorry for my ignorance, but I did not know that we're supposed
> to add a Fixes tag in this situation.
It is a good practice and definitively he
From: Markus Elfring
Date: Sat, 2 Jan 2016 18:46:45 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (5):
Delete an unnecessary assignment in connect_rings()
Delete an unnecessary goto statement in connect_rings()
Replace a variable in
-rsi-Fine-tuning-for-two-function-implementations/20160102-224740
base:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
master
config: x86_64-randconfig-s2-01030012 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make
My linux box has a duty. It has to forward IP packets for a "private"
network which it doesn't belong to.
The network is "private" has the meaning that the hosts that belong to
the network have IP addresses that are unique only between them.
Say that the network is formed by 4 nodes: "a", "b", "c
Hello,
I have taken another look at the implementation of the function
"rsi_send_mgmt_pkt".
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/net/wireless/rsi/rsi_91x_pkt.c?id=e8c58e7a5a106c3d557fccd01cd4d1128f9bab38#n114
I find the following statement combination int
Hi all,
2016-01-02 6:51 GMT+01:00 Florian Fainelli :
> On December 29, 2015 6:05:35 AM PST, Romain Perier
> wrote:
>>Originally, most of the platforms using this driver did not define an
>>mdio subnode
>>in the devicetree. Commit e34d65 ("stmmac: create of compatible mdio
>>bus for stmmac driver
SF Markus Elfring :
> From: Markus Elfring
> Date: Sat, 2 Jan 2016 15:25:34 +0100
>
> Replace explicit initialisation for two local variables at the beginning
> by assignments.
It makes no sense for the 'adapter' variable.
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe
From: Markus Elfring
Date: Sat, 2 Jan 2016 15:25:34 +0100
Replace explicit initialisation for two local variables at the beginning
by assignments.
Signed-off-by: Markus Elfring
---
drivers/net/wireless/rsi/rsi_91x_pkt.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --g
From: Markus Elfring
Date: Sat, 2 Jan 2016 15:15:12 +0100
Omit explicit initialisation at the beginning for four local variables
which are redefined before their first use.
Signed-off-by: Markus Elfring
---
drivers/net/wireless/rsi/rsi_91x_pkt.c | 8
1 file changed, 4 insertions(+), 4
From: Markus Elfring
Date: Sat, 2 Jan 2016 14:54:30 +0100
Omit explicit initialisation at the beginning for five local variables
which are redefined before their first use.
Signed-off-by: Markus Elfring
---
drivers/net/wireless/rsi/rsi_91x_pkt.c | 10 +-
1 file changed, 5 insertions(+)
From: Markus Elfring
Date: Sat, 2 Jan 2016 15:36:25 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()
Delete unnecessary variable initialisations in rsi_send_data_pkt
-OF_MDIO-dependencies-to-MDIO_OCTEON/20160102-211011
config: x86_64-randconfig-s5-01022139 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
warning: (OCTEON_MGMT_ETHERNET && T
Ran into this on UML:
drivers/built-in.o: In function `octeon_mdiobus_probe':
drivers/net/phy/mdio-octeon.c:295: undefined reference to `devm_ioremap'
drivers/net/phy/mdio-octeon.c:320: undefined reference to `of_mdiobus_register'
collect2: error: ld returned 1 exit status
devm_ioremap() is defin
> I have never seen much evolution going on in this area.
I can get an other impression from a specific document for example.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle
> What the patch tries to do is avoid the extra 'if (err)'.
Yes. - I propo
On 02-01-16 10:08, SF Markus Elfring wrote:
>>> I assume that a software development taste can evolve, can't it?
>>
>> So far, you have gotten several down votes for this kind of change,
>
> I am curious when more contributors will share corresponding opinions.
Let's burn some cycles on this wh
>> I assume that a software development taste can evolve, can't it?
>
> So far, you have gotten several down votes for this kind of change,
I am curious when more contributors will share corresponding opinions.
> and no enthusiasm.
How many software designers and developers can become enthusia
On 01/01/2016 08:26 PM, SF Markus Elfring wrote:
From: Markus Elfring
Date: Fri, 1 Jan 2016 20:20:15 +0100
I think it has been said over and over, but please use driver name only
as prefix. I don't see value to prepend it with 'net-'.
Omit explicit initialisation at the beginning for one l
On Sat, 2 Jan 2016, SF Markus Elfring wrote:
> >> Move the jump label directly before the desired log statement
> >> so that the variable "err" will not be checked once more
> >> after it was determined that a function call failed.
> >> Use the identifier "report_failure" instead of the label "e
>> Move the jump label directly before the desired log statement
>> so that the variable "err" will not be checked once more
>> after it was determined that a function call failed.
>> Use the identifier "report_failure" instead of the label "err".
>
>Why?
I suggest to reconsider the places wi
On Sat, Jan 2, 2016 at 1:34 AM, Cong Wang wrote:
> llcp_sock_getname() checks llcp_sock->dev to make sure
> llcp_sock is already connected or bound, however, we could
> be in the middle of llcp_sock_bind() where llcp_sock->dev
> is bound and llcp_sock->service_name_len is set,
> but llcp_sock->ser
45 matches
Mail list logo
