RE: [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed

2015-12-29 Thread Tantilov, Emil S
>-Original Message- >From: zhuyj [mailto:zyjzyj2...@gmail.com] >Sent: Tuesday, December 29, 2015 6:49 PM >To: Tantilov, Emil S; Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, >Shannon; Wyborny, Carolyn; Skidmore, Donald C; Allan, Bruce W; Ronciak, >John; Williams, Mitch A; intel-wired-...@l

[PATCH net-next v3 04/10] be2net: move FW flash cmd code to be_cmds.c

2015-12-29 Thread Sathya Perla
From: Suresh Reddy All code relating to FW cmds is in be_cmds.[ch] excepting FW flash cmd related code. This patch moves these routines from be_main.c to be_cmds.c Signed-off-by: Suresh Reddy Signed-off-by: Sathya Perla --- drivers/net/ethernet/emulex/benet/be_cmds.c | 583 +++

[PATCH net-next v3 01/10] be2net: fix VF link state transition from disabled to auto

2015-12-29 Thread Sathya Perla
From: Suresh Reddy The VF link state setting transition from "disable" to "auto" does not work due to a bug in SET_LOGICAL_LINK_CONFIG_V1 cmd in FW. This issue could not be fixed in FW due to some backward compatibility issues it causes with some released drivers. The issue has been fixed by intr

[PATCH net-next v3 06/10] be2net: remove a line of code that has no effect

2015-12-29 Thread Sathya Perla
This patch removes a line of code that changes adapter->recommended_prio value followed by yet another assignment. Also, the variable is used to store the vlan priority value that is already shifted to the PCP bits position in the vlan tag format. Hence, the name of this variable is changed to reco

[PATCH net-next v3 03/10] be2net: cleanup FW flash image related macro defines

2015-12-29 Thread Sathya Perla
From: Suresh Reddy Many constant definitions relating to the FW-image layout (such as section offset values) were defined in decimal format rather than hexa-decimal. This makes this part of the code un-readable. Also some defines related to BE2 are labeld "g2" and defines related to BE3 are label

[PATCH net-next v3 09/10] be2net: support ethtool get-dump option

2015-12-29 Thread Sathya Perla
From: Venkat Duvvuru This patch adds support for ethtool's --get-dump option in be2net, to retrieve FW dump. In the past when this option was not yet available, this feature was supported via the --register-dump option as a workaround. This patch removes support for FW-dump via --register-dump op

[PATCH net-next v3 10/10] be2net: bump up the driver version to 11.0.0.0

2015-12-29 Thread Sathya Perla
From: Suresh Reddy Signed-off-by: Suresh Reddy Signed-off-by: Sathya Perla --- drivers/net/ethernet/emulex/benet/be.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h index 8b8212f..22bf7af 1006

[PATCH net-next v3 08/10] be2net: fix port-res desc query of GET_PROFILE_CONFIG FW cmd

2015-12-29 Thread Sathya Perla
From: Suresh Reddy Commit 72ef3a88fa8e ("be2net: set pci_func_num while issuing GET_PROFILE_CONFIG cmd") passed a specific pf_num while issuing a GET_PROFILE_CONFIG cmd as FW returns descriptors for all functions when pf_num is zero. But, when pf_num is set to a non-zero value, FW does not return

[PATCH net-next v3 02/10] be2net: avoid configuring VEPA mode on BE3

2015-12-29 Thread Sathya Perla
From: Suresh Reddy BE3 chip doesn't support VEPA mode. Signed-off-by: Suresh Reddy Signed-off-by: Sathya Perla --- drivers/net/ethernet/emulex/benet/be_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/bene

[PATCH net-next v3 05/10] be2net: log digital signature errors while flashing FW image

2015-12-29 Thread Sathya Perla
From: Suresh Reddy >From FW version 11.0 onwards, the FW supports a new "secure mode" feature (based on a jumper setting on the adapter.) In this mode, the FW image when flashed is authenticated with a digital signature. This patch logs appropriate error messages and return a status to ethtool wh

[PATCH net-next v3 00/10] be2net: patch set

2015-12-29 Thread Sathya Perla
Hi David, The following patch set contains some feature additions, code re-organization and cleanup and a few non-critical fixes. Pls consider applying this to the net-next tree. Thanks. v3 changes: add a default case to the switch statement in patch 5 to satisfy the compiler (-Wswitch). v2 change

[PATCH net-next v3 07/10] be2net: remove unused error variables

2015-12-29 Thread Sathya Perla
From: Venkat Duvvuru eeh_error, fw_timeout, hw_error variables in the be_adapter structure are not used anymore. An earlier patch that introduced adapter->err_flags to store this information missed removing these variables. Signed-off-by: Venkat Duvvuru Signed-off-by: Sathya Perla --- drivers

Re: [PATCH net-next v2 00/10] be2net: patch set

2015-12-29 Thread Sathya Perla
On Wed, Dec 30, 2015 at 2:20 AM, David Miller wrote: > > Please fix the problems reported by the kbuild test robot, they happened > when I tried to build this too. David, the test robot is complaining that all values of the enum are not being handled by the switch statement. There is a "return -E

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2015-12-29 Thread kbuild test robot
Hi Gilad, [auto build test WARNING on net/master] [also build test WARNING on v4.4-rc7 next-20151223] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Gilad-Avidov/net-emac-emac-gigabit-ethernet

RE: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics counters

2015-12-29 Thread Shaohui Xie
> Subject: [PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics counters > +static int marvell_probe(struct phy_device *phydev) { > + struct marvell_priv *priv; > + > + priv = devm_kzalloc(&phydev->dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; >

Re: 4.4-rc7 failure report

2015-12-29 Thread Alexei Starovoitov
On Tue, Dec 29, 2015 at 10:44:31PM -0500, Doug Ledford wrote: > On 12/29/2015 10:43 PM, Alexei Starovoitov wrote: > > On Mon, Dec 28, 2015 at 08:26:44PM -0500, Doug Ledford wrote: > >> On 12/28/2015 05:20 PM, Daniel Borkmann wrote: > >>> On 12/28/2015 10:53 PM, Doug Ledford wrote: > The 4.4-rc

Re: 4.4-rc7 failure report

2015-12-29 Thread Doug Ledford
On 12/29/2015 10:43 PM, Alexei Starovoitov wrote: > On Mon, Dec 28, 2015 at 08:26:44PM -0500, Doug Ledford wrote: >> On 12/28/2015 05:20 PM, Daniel Borkmann wrote: >>> On 12/28/2015 10:53 PM, Doug Ledford wrote: The 4.4-rc7 kernel is failing for me. In my case, all of my vlan interfaces

Re: 4.4-rc7 failure report

2015-12-29 Thread Alexei Starovoitov
On Mon, Dec 28, 2015 at 08:26:44PM -0500, Doug Ledford wrote: > On 12/28/2015 05:20 PM, Daniel Borkmann wrote: > > On 12/28/2015 10:53 PM, Doug Ledford wrote: > >> The 4.4-rc7 kernel is failing for me. In my case, all of my vlan > >> interfaces are failing to obtain a dhcp address using dhclient.

[net-next v2 0/8][pull request] 10GbE Intel Wired LAN Driver Updates 2015-12-29

2015-12-29 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf. William Dauchy provides a fix for ixgbevf that was implemented for ixgbe, commit 5d6002b7b822c7 ("ixgbe: Fix handling of NAPI budget when multiple queues are enabled per vector"). The issue was that the polling routine would increase the budget fo

[net-next v2 6/8] ixgbe: fix RSS limit for X550

2015-12-29 Thread Jeff Kirsher
From: Emil Tantilov X550 allows for up to 64 RSS queues, but the driver can have max of 63 (-1 MSIX vector for link). On systems with >= 64 CPUs the driver will set the redirection table for all 64 queues which will result in packets being dropped. Signed-off-by: Emil Tantilov Tested-by: Phil

[net-next v2 2/8] ixgbevf: minor cleanups for ixgbevf_set_itr()

2015-12-29 Thread Jeff Kirsher
From: Emil Tantilov adapter->rx_itr_setting is not a mask so check it with == instead of & do not default to 12K interrupts in ixgbevf_set_itr() There should be no functional effect from these changes. Signed-off-by: Emil Tantilov Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- driv

[net-next v2 4/8] ixgbe: report correct media type for KR, KX and KX4 interfaces

2015-12-29 Thread Jeff Kirsher
From: Veola Nazareth Ethtool reports backplane type interfaces as 1000/1baseT link modes. This has been corrected to report the media as KR, KX or KX4 based on the backplane interface present. Signed-off-by: Veola Nazareth Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- drivers/n

[net-next v2 3/8] ixgbe: add support for QSFP PHY types in ixgbe_get_settings()

2015-12-29 Thread Jeff Kirsher
From: Emil Tantilov Add missing QSFP PHY types to allow for more accurate reporting of port settings. Signed-off-by: Emil Tantilov Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 1 file changed, 4 insertions(+) diff --git a/

[net-next v2 5/8] ixgbe: Clean up redundancy in hw_enc_features

2015-12-29 Thread Jeff Kirsher
From: Mark Rustad Clean up minor redundancy in the setting of hw_enc_features that makes it appears that X550 uniquely has more encapsulation features than other devices. The driver only supports one more feature, so make it look that way. No longer set NETIF_F_SG since that is set by the registe

[net-next v2 8/8] ixgbe: Fix bugs in ixgbe_clear_vf_vlans()

2015-12-29 Thread Jeff Kirsher
From: Alexander Duyck When I had rewritten the code for ixgbe_clear_vf_vlans() it looks like I had transitioned back and forth between using word as an offset and using word as a register offset. As a result I honestly don't see how the code was working before other than the fact that resetting

[net-next v2 7/8] ixgbe: Correct X550EM_x revision check

2015-12-29 Thread Jeff Kirsher
From: Mark Rustad The X550EM_x revision check needs to check a value, not just a bit. Use a mask and check the value. Also remove the redundant check inside the ixgbe_enter_lplu_t_x550em, because it can only be called when both the mac type and revision check pass. Signed-off-by: Mark Rustad Te

[net-next v2 1/8] ixgbevf: Fix handling of NAPI budget when multiple queues are enabled per vector

2015-12-29 Thread Jeff Kirsher
From: William Dauchy This is the same patch as for ixgbe but applied differently according to busy polling. See commit 5d6002b7b822c74 ("ixgbe: Fix handling of NAPI budget when multiple queues are enabled per vector") Signed-off-by: William Dauchy Tested-by: Phil Schmitt Signed-off-by: Jeff K

Re: [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed

2015-12-29 Thread zhuyj
On 12/30/2015 03:17 AM, Rustad, Mark D wrote: Emil S wrote: */ - if (hw->mac.type == ixgbe_mac_X540) + if ((hw->mac.type == ixgbe_mac_X540) && + (netdev->flags & IFF_SLAVE)) if (link_speed == IXGBE_LINK_SPEED_UNKNOWN) return; If

Re: nf_unregister_net_hook: hook not found!

2015-12-29 Thread Eric W. Biederman
Pablo Neira Ayuso writes: > On Mon, Dec 28, 2015 at 09:05:03PM +0100, Sander Eikelenboom wrote: >> Hi, >> >> Running a 4.4.0-rc6 kernel i encountered the warning below. > > Cc'ing Eric Biederman. > > @Sander, could you provide a way to reproduce this? I am on vacation until the new year, but if

Re: [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed

2015-12-29 Thread zhuyj
On 12/30/2015 12:18 AM, Tantilov, Emil S wrote: -Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of zyjzyj2...@gmail.com Sent: Monday, December 28, 2015 6:32 PM To: Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2015-12-29 Thread kbuild test robot
Hi Gilad, [auto build test WARNING on net/master] [also build test WARNING on v4.4-rc7 next-20151223] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Gilad-Avidov/net-emac-emac-gigabit-ethernet

Re: [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform

2015-12-29 Thread David Miller
From: Heiko Stübner Date: Tue, 29 Dec 2015 23:27:55 +0100 > Hi Dave, > > Am Dienstag, 29. Dezember 2015, 15:53:14 schrieb David Miller: >> You have to submit this series properly, the same problem happend twice >> now. >> >> When you submit a series you should: >> >> 1) Make it clear which tre

Re: [PATCH] mwifiex: correctly handling kzalloc

2015-12-29 Thread Andy Shevchenko
On Tue, Dec 29, 2015 at 10:17 PM, Insu Yun wrote: Empty commit message? > Signed-off-by: Insu Yun > --- > drivers/net/wireless/mwifiex/sdio.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/net/wireless/mwifiex/sdio.c > b/drivers/net/wireless/mwifiex/sdio.c > ind

Re: nf_unregister_net_hook: hook not found!

2015-12-29 Thread Pablo Neira Ayuso
On Mon, Dec 28, 2015 at 09:05:03PM +0100, Sander Eikelenboom wrote: > Hi, > > Running a 4.4.0-rc6 kernel i encountered the warning below. Cc'ing Eric Biederman. @Sander, could you provide a way to reproduce this? Thanks. > [ 13.740472] ip_tables: (C) 2000-2006 Netfilter Core Team > [ 13.93

Re: [PATCH] ixgbe: correctly handling failed allocation

2015-12-29 Thread Alexander Duyck
On Tue, Dec 29, 2015 at 1:55 PM, Insu Yun wrote: > Since kzalloc can be failed in memory pressure, > NULL derefence could be happened. > > Signed-off-by: Insu Yun > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet

Re: [PATCH v2 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2015-12-29 Thread Alexei Starovoitov
On Tue, Dec 29, 2015 at 12:29:09PM -0500, Craig Gallek wrote: > From: Craig Gallek > > Expose socket options for setting a classic or extended BPF program > for use when selecting sockets in an SO_REUSEPORT group. These options > can be used on the first socket to belong to a group before bind o

Re: [PATCH v2 net-next 4/4] soreuseport: BPF selection functional test

2015-12-29 Thread Alexei Starovoitov
On Tue, Dec 29, 2015 at 12:29:10PM -0500, Craig Gallek wrote: > From: Craig Gallek > > This program will build classic and extended BPF programs and > validate the socket selection logic when used with > SO_ATTACH_REUSEPORT_CBPF and SO_ATTACH_REUSEPORT_EBPF. > > It also validates the re-programi

Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036

2015-12-29 Thread Heiko Stübner
Am Dienstag, 29. Dezember 2015, 14:59:59 schrieb Florian Fainelli: > On December 27, 2015 11:22:20 PM PST, Xing Zheng wrote: > >The RK3036's GRFs offset are different with RK3066/RK3188, and need to > >set > >mac TX/RX clock before probe emac. > > > >Signed-off-by: Xing Zheng > >--- > > > > >

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

2015-12-29 Thread Rob Herring
On Tue, Dec 29, 2015 at 11:03:57AM -0800, Bjorn Andersson wrote: > On Tue 29 Dec 10:34 PST 2015, Rob Herring wrote: > > > On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: > > > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. > > > Signed-off-by: Bjorn Andersson > >

Re: [RESEND PATCH v1 3/4] net: ethernet: arc: Add support emac for RK3036

2015-12-29 Thread Florian Fainelli
On December 27, 2015 11:22:20 PM PST, Xing Zheng wrote: >The RK3036's GRFs offset are different with RK3066/RK3188, and need to >set >mac TX/RX clock before probe emac. > >Signed-off-by: Xing Zheng >--- > }; > > static const struct of_device_id emac_rockchip_dt_ids[] = { >- { .compatible

Re: [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform

2015-12-29 Thread Florian Fainelli
On December 29, 2015 2:27:55 PM PST, "Heiko Stübner" wrote: >Hi Dave, > >Am Dienstag, 29. Dezember 2015, 15:53:14 schrieb David Miller: >> You have to submit this series properly, the same problem happend >twice >> now. >> >> When you submit a series you should: >> >> 1) Make it clear which tree

Re: [PATCH net-next 1/3] r8169:Fix typo in setting RTL8168EP and RTL8168H D3cold PFM mode

2015-12-29 Thread Francois Romieu
Chunhao Lin : > The register for setting D3code PFM mode is MISC_1, not DLLPR. > > Signed-off-by: Chunhao Lin Reviewed-by: Francois Romieu -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform

2015-12-29 Thread Heiko Stübner
Hi Dave, Am Dienstag, 29. Dezember 2015, 15:53:14 schrieb David Miller: > You have to submit this series properly, the same problem happend twice > now. > > When you submit a series you should: > > 1) Make it clear which tree you expect these changes to be applied >to. Here it is completely

[PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

2015-12-29 Thread Heinrich Schuchardt
IOCTL SIOCRTMSG does nothing but return EINVAL. So comment it as unused. Signed-off-by: Heinrich Schuchardt --- include/uapi/linux/sockios.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h index e888b1a..8e7890b 100

[PATCH] cxgb4: correctly handling failed allocation

2015-12-29 Thread Insu Yun
Since t4_alloc_mem can be failed in memory pressure, if not properly handled, NULL dereference could be happened. Signed-off-by: Insu Yun --- drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c b/dri

[PATCH] ixgbe: correctly handling failed allocation

2015-12-29 Thread Insu Yun
Since kzalloc can be failed in memory pressure, NULL derefence could be happened. Signed-off-by: Insu Yun --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgb

[PATCH] mISDN: correctly handling failed allocation in fsm

2015-12-29 Thread Insu Yun
Since kzalloc can be failed in memory pressure, NULL dereference can be happened. Signed-off-by: Insu Yun --- drivers/isdn/mISDN/fsm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/isdn/mISDN/fsm.c b/drivers/isdn/mISDN/fsm.c index 26477d4..3c3ffb0 100644 --- a/drivers/isdn/mISDN/

[PATCH] mISDN: correctly handling failed allocation

2015-12-29 Thread Insu Yun
Since kzalloc can be failed in memory pressure, NULL dereference might be happened. Signed-off-by: Insu Yun --- drivers/isdn/hardware/mISDN/hfcsusb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c index 114f3b

Re: [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform

2015-12-29 Thread David Miller
You have to submit this series properly, the same problem happend twice now. When you submit a series you should: 1) Make it clear which tree you expect these changes to be applied to. Here it is completely ambiguous, do you want it to go into my networking tree or some other subsystem tr

Re: [PATCH net-next v2 00/10] be2net: patch set

2015-12-29 Thread David Miller
Please fix the problems reported by the kbuild test robot, they happened when I tried to build this too. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/10] net: hns: use to_platform_device()

2015-12-29 Thread David Miller
From: Geliang Tang Date: Sun, 27 Dec 2015 21:15:44 +0800 > Use to_platform_device() instead of open-coding it. > > Signed-off-by: Geliang Tang Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/9] atm: solos-pci: use to_pci_dev()

2015-12-29 Thread David Miller
From: Geliang Tang Date: Sun, 27 Dec 2015 18:45:57 +0800 > Use to_pci_dev() instead of open-coding it. > > Signed-off-by: Geliang Tang Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: [PATCH] unix: properly account for FDs passed over unix sockets

2015-12-29 Thread Willy Tarreau
On Tue, Dec 29, 2015 at 03:48:45PM +0100, Hannes Frederic Sowa wrote: > On 28.12.2015 15:14, Willy Tarreau wrote: > >It is possible for a process to allocate and accumulate far more FDs than > >the process' limit by sending them over a unix socket then closing them > >to keep the process' fd count

Re: [PATCH 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

2015-12-29 Thread Rob Herring
On Tue, Dec 22, 2015 at 07:36:33PM -0500, David Rivshin (Allworx) wrote: > From: David Rivshin > > The phy-handle, phy_id, and fixed-link properties are mutually exclusive, > and only one need be specified. However if phy-handle was specified, an > error message would complain about the lack of p

Re: [PATCH net] openvswitch: Fix template leak in error cases.

2015-12-29 Thread David Miller
From: Joe Stringer Date: Wed, 23 Dec 2015 14:39:27 -0800 > Commit 5b48bb8506c5 ("openvswitch: Fix helper reference leak") fixed a > reference leak on helper objects, but inadvertently introduced a leak on > the ct template. > > Previously, ct_info.ct->general.use was initialized to 0 by > nf_ct_

[PATCH] mwifiex: correctly handling kzalloc

2015-12-29 Thread Insu Yun
Signed-off-by: Insu Yun --- drivers/net/wireless/mwifiex/sdio.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c index 78a8474..a8af72d 100644 --- a/drivers/net/wireless/mwifiex/sdio.c +++ b/drivers/net/wir

Re: [PATCH v2 0/3] bpf: hash: use per-bucket spinlock

2015-12-29 Thread David Miller
From: Ming Lei Date: Tue, 29 Dec 2015 22:40:24 +0800 > Hi, > > This patchset tries to optimize ebpf hash map, and follows > the idea: > > Both htab_map_update_elem() and htab_map_delete_elem() > can be called from eBPF program, and they may be in kernel > hot path, it is

Re: [PATCHv3 net-next 1/3] ethtool: Add phy statistics

2015-12-29 Thread David Miller
From: Andrew Lunn Date: Tue, 29 Dec 2015 20:51:22 +0100 > @@ -191,6 +191,23 @@ static int ethtool_set_features(struct net_device *dev, > void __user *useraddr) > return ret; > } > > +int phy_get_sset_count(struct phy_device *phydev) > +{ This needs to be static. -- To unsubscribe from

Re: [PATCH] mwifiex: correctly handling kzalloc

2015-12-29 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 14:55:25 -0500 > Since kzalloc can be failed in memory pressure, > it needs to be handled as above kzalloc. > > Signed-off-by: Insu Yun > --- > drivers/net/wireless/mwifiex/sdio.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2015-12-29 Thread David Miller
From: Rainer Weikusat Date: Tue, 29 Dec 2015 19:42:36 + > Jacob Siverskog writes: >> This should fix a NULL pointer dereference I encountered (dump >> below). Since __skb_unlink is called while walking, >> skb_queue_walk_safe should be used. > > The code in question is: ... > __skb_unlink

[PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args

2015-12-29 Thread Insu Yun
Since qlcnic_alloc_mbx_args can be failed, return value should be checked. Signed-off-by: Insu Yun --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/etherne

[PATCH] mwifiex: correctly handling kzalloc

2015-12-29 Thread Insu Yun
Since kzalloc can be failed in memory pressure, it needs to be handled as above kzalloc. Signed-off-by: Insu Yun --- drivers/net/wireless/mwifiex/sdio.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c index 78a8

[PATCHv3 net-next 0/3] Ethtool support for phy stats

2015-12-29 Thread Andrew Lunn
This patchset add ethtool support for reading statistics from the PHY. The Marvell and Micrel Phys are then extended to report receiver packet errors and idle errors. v2: Fix linking when phylib is not enabled. v3: Inline helpers into ethtool.c, so fixing when phylib is a module. Andrew Lun

[PATCHv3 net-next 1/3] ethtool: Add phy statistics

2015-12-29 Thread Andrew Lunn
Ethernet PHYs can maintain statistics, for example errors while idle and receive errors. Add an ethtool mechanism to retrieve these statistics, using the same model as MAC statistics. Signed-off-by: Andrew Lunn --- include/linux/phy.h | 6 include/uapi/linux/ethtool.h | 3 ++ net

[PATCHv3 net-next 3/3] phy: micrel: Add ethtool statistics counters

2015-12-29 Thread Andrew Lunn
The PHY counters receiver errors and errors while idle. Signed-off-by: Andrew Lunn --- drivers/net/phy/micrel.c | 96 1 file changed, 96 insertions(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index e13ad6cdcc22..1a6048a8c2

[PATCHv3 net-next 2/3] phy: marvell: Add ethtool statistics counters

2015-12-29 Thread Andrew Lunn
The PHY counters receiver errors and errors while idle. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 135 ++ 1 file changed, 135 insertions(+) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 0240552b50f3..50b5eac

Re: [PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args

2015-12-29 Thread David Miller
From: Insu Yun Date: Tue, 29 Dec 2015 14:29:47 -0500 > Signed-off-by: Insu Yun > --- > drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c > b/drivers/net/ethernet/qlogic/ql

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2015-12-29 Thread Rainer Weikusat
Jacob Siverskog writes: > This should fix a NULL pointer dereference I encountered (dump > below). Since __skb_unlink is called while walking, > skb_queue_walk_safe should be used. The code in question is: skb_queue_walk(queue, skb) { *last = skb; *peeked = skb->peeked; i

[PATCH] qlcnic: correctly handle qlcnic_alloc_mbx_args

2015-12-29 Thread Insu Yun
Signed-off-by: Insu Yun --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c index a5f422f..a9a2c33 100644 --- a/drivers/net/eth

Re: [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed

2015-12-29 Thread Rustad, Mark D
Emil S wrote: >> */ >> -if (hw->mac.type == ixgbe_mac_X540) >> +if ((hw->mac.type == ixgbe_mac_X540) && >> +(netdev->flags & IFF_SLAVE)) >> if (link_speed == IXGBE_LINK_SPEED_UNKNOWN) >> return; > > If you were to enter ixgbe_watchdog_link_is_up

[PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2015-12-29 Thread Jacob Siverskog
This should fix a NULL pointer dereference I encountered (dump below). Since __skb_unlink is called while walking, skb_queue_walk_safe should be used. I investigated the oops and it seems like skb->next was NULL. Oops: Unable to handle kernel NULL pointer dereference at virtual address 0004 p

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

2015-12-29 Thread Andy Gross
On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. > > Signed-off-by: Bjorn Andersson > --- > + > +- qcom,wcnss-mmio: > + Usage: required > + Value type: nit: encoded > + Definition: should specify

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

2015-12-29 Thread Bjorn Andersson
On Tue 29 Dec 10:34 PST 2015, Rob Herring wrote: > On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: > > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. > > Signed-off-by: Bjorn Andersson > > --- > > .../bindings/net/wireless/qcom,wcn36xx-wifi.txt| 76 > >

Re: [PATCH v2] net, socket, socket_wq: fix missing initialization of flags

2015-12-29 Thread Eric Dumazet
On Tue, 2015-12-29 at 13:29 +0100, Nicolai Stange wrote: > Fixes: ceb5d58b2170 ("net: fix sock_wake_async() rcu protection") > Sorry for any inconvenience this late-night induced brainfart might > have caused at your side... Not really, because I read the source code and saw the bug there ;) A

Re: [PATCH 4/4] dt: binding: Add Qualcomm wcn36xx WiFi binding

2015-12-29 Thread Rob Herring
On Sun, Dec 27, 2015 at 05:34:27PM -0800, Bjorn Andersson wrote: > Add binding representing the Qualcomm wcn3620/60/80 WiFi block. > Signed-off-by: Bjorn Andersson > --- > .../bindings/net/wireless/qcom,wcn36xx-wifi.txt| 76 > ++ > 1 file changed, 76 insertions(+) > crea

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-29 Thread Souptick Joarder
Brent, On Tue, Dec 22, 2015 at 2:42 PM, Kalle Valo wrote: > Souptick Joarder writes: > >> Hi Brent, >> >> On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor wrote: >>> On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder >>> wrote: Hi Brent, On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylo

Re: Q: bad routing table cache entries

2015-12-29 Thread Stas Sergeev
29.12.2015 18:38, Stas Sergeev пишет: > Likely the router's side is doing the right thing, but of Or maybe not? Here's the ifconfig of router: eth0 Link encap:Ethernet HWaddr 00:1e:8c:a7:b5:36 inet addr:192.168.0.220 Bcast:192.168.3.255 Mask:255.255.252.0 eth0:1Link encap:Et

[PATCH v2 net-next 2/4] soreuseport: fast reuseport UDP socket selection

2015-12-29 Thread Craig Gallek
From: Craig Gallek Include a struct sock_reuseport instance when a UDP socket binds to a specific address for the first time with the reuseport flag set. When selecting a socket for an incoming UDP packet, use the information available in sock_reuseport if present. This required adding an additi

[PATCH v2 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2015-12-29 Thread Craig Gallek
From: Craig Gallek Expose socket options for setting a classic or extended BPF program for use when selecting sockets in an SO_REUSEPORT group. These options can be used on the first socket to belong to a group before bind or on any socket in the group after bind. This change includes refactori

[PATCH v2 net-next 1/4] soreuseport: define reuseport groups

2015-12-29 Thread Craig Gallek
From: Craig Gallek struct sock_reuseport is an optional shared structure referenced by each socket belonging to a reuseport group. When a socket is bound to an address/port not yet in use and the reuseport flag has been set, the structure will be allocated and attached to the newly bound socket.

[PATCH v2 net-next 4/4] soreuseport: BPF selection functional test

2015-12-29 Thread Craig Gallek
From: Craig Gallek This program will build classic and extended BPF programs and validate the socket selection logic when used with SO_ATTACH_REUSEPORT_CBPF and SO_ATTACH_REUSEPORT_EBPF. It also validates the re-programing flow and several edge cases. Signed-off-by: Craig Gallek --- tools/tes

[PATCH v2 net-next 0/4] Faster SO_REUSEPORT

2015-12-29 Thread Craig Gallek
From: Craig Gallek This series contains two optimizations for the SO_REUSEPORT feature: Faster lookup when selecting a socket for an incoming packet and the ability to select the socket from the group using a BPF program. This series only includes the UDP path. I plan to submit a follow-up incl

Re: [PATCH net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

2015-12-29 Thread Craig Gallek
On Sat, Dec 26, 2015 at 2:05 PM, Craig Gallek wrote: > On Thu, Dec 24, 2015 at 11:36 AM, Alexei Starovoitov > wrote: >> On Tue, Dec 22, 2015 at 03:05:09PM -0500, Craig Gallek wrote: >>> + /* temporarily advance data past protocol header */ >>> + if (skb_headlen(skb) < hdr_len || !skb_pull

Re: [PATCH v2 3/3] bpf: hash: use per-bucket spinlock

2015-12-29 Thread Daniel Borkmann
On 12/29/2015 03:40 PM, Ming Lei wrote: Both htab_map_update_elem() and htab_map_delete_elem() can be called from eBPF program, and they may be in kernel hot path, so it isn't efficient to use a per-hashtable lock in this two helpers. The per-hashtable spinlock is used for protecting bucket's hl

RE: [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed

2015-12-29 Thread Tantilov, Emil S
>-Original Message- >From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On >Behalf Of zyjzyj2...@gmail.com >Sent: Monday, December 28, 2015 6:32 PM >To: Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, Shannon; Wyborny, >Carolyn; Skidmore, Donald C; Allan, Bruce W; Roncia

Re: Q: bad routing table cache entries

2015-12-29 Thread Stas Sergeev
29.12.2015 18:22, Sowmini Varadhan пишет: > Do you have admin control over the ubuntu router? > If yes, you might want to check the shared_media [#] setting > on that router for the interfaces with overlapping subnets. > (it is on by default, I would try turning it off). Ahha, good catch, thanks!

Re: Q: bad routing table cache entries

2015-12-29 Thread Sowmini Varadhan
Do you have admin control over the ubuntu router? If yes, you might want to check the shared_media [#] setting on that router for the interfaces with overlapping subnets. (it is on by default, I would try turning it off). AFAICT, the code does the right thing per rfc1812 when setting IPSKB_DORED

[PATCH v2 3/3] bpf: hash: use per-bucket spinlock

2015-12-29 Thread Ming Lei
Both htab_map_update_elem() and htab_map_delete_elem() can be called from eBPF program, and they may be in kernel hot path, so it isn't efficient to use a per-hashtable lock in this two helpers. The per-hashtable spinlock is used for protecting bucket's hlist, and per-bucket lock is just enough. T

Re: [PATCH] unix: properly account for FDs passed over unix sockets

2015-12-29 Thread Hannes Frederic Sowa
On 28.12.2015 15:14, Willy Tarreau wrote: It is possible for a process to allocate and accumulate far more FDs than the process' limit by sending them over a unix socket then closing them to keep the process' fd count low. This change addresses this problem by keeping track of the number of FDs

[PATCH v2 0/3] bpf: hash: use per-bucket spinlock

2015-12-29 Thread Ming Lei
Hi, This patchset tries to optimize ebpf hash map, and follows the idea: Both htab_map_update_elem() and htab_map_delete_elem() can be called from eBPF program, and they may be in kernel hot path, it isn't efficient to use a per-hashtable lock in this two helpers,

[PATCH v2 1/3] bpf: hash: use atomic count

2015-12-29 Thread Ming Lei
Preparing for removing global per-hashtable lock, so the counter need to be defined as aotmic_t first. Acked-by: Daniel Borkmann Signed-off-by: Ming Lei --- kernel/bpf/hashtab.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/ha

[PATCH v2 2/3] bpf: hash: move select_bucket() out of htab's spinlock

2015-12-29 Thread Ming Lei
The spinlock is just used for protecting the per-bucket hlist, so it isn't needed for selecting bucket. Acked-by: Daniel Borkmann Signed-off-by: Ming Lei --- kernel/bpf/hashtab.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.

Re: [PATCH] unix: properly account for FDs passed over unix sockets

2015-12-29 Thread Hannes Frederic Sowa
On 28.12.2015 15:14, Willy Tarreau wrote: @@ -1528,10 +1546,8 @@ static int unix_attach_fds(struct scm_cookie *scm, struct sk_buff *skb) if (!UNIXCB(skb).fp) return -ENOMEM; - if (unix_sock_count) { - for (i = scm->fp->count - 1; i >= 0; i--) -

[PATCH net-next 2/3] r8169:Fix typo in setting RTL8168H PHY PFM mode.

2015-12-29 Thread Chunhao Lin
The PHY PFM register is in PHY page 0x0a44 register 0x11, not 0x14. Signed-off-by: Chunhao Lin --- drivers/net/ethernet/realtek/r8169.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 0decc

[PATCH net-next 0/3] Fix some typos in setting hardware parameter

2015-12-29 Thread Chunhao Lin
The typos are in setting RTL8168DP, RTL8168EP and RTL8168H hardware parameters. This series of patch fix these typos. Chunhao Lin (3): r8169:Fix typo in setting RTL8168EP and RTL8168H D3cold PFM mode r8169:Fix typo in setting RTL8168H PHY PFM mode. r8169:Correct the way of setting RTL8168DP

[PATCH net-next 1/3] r8169:Fix typo in setting RTL8168EP and RTL8168H D3cold PFM mode

2015-12-29 Thread Chunhao Lin
The register for setting D3code PFM mode is MISC_1, not DLLPR. Signed-off-by: Chunhao Lin --- drivers/net/ethernet/realtek/r8169.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 58365bc

[PATCH net-next 3/3] r8169:Correct the way of setting RTL8168DP ephy

2015-12-29 Thread Chunhao Lin
The original way is wrong, it always writes ephy reg 0x03. Signed-off-by: Chunhao Lin --- drivers/net/ethernet/realtek/r8169.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index

[PATCH] stmmac: Don't exit mdio registration when mdio subnode is not found in the DTS

2015-12-29 Thread Romain Perier
Originally, most of the platforms using this driver did not define an mdio subnode in the devicetree. Commit e34d65 ("stmmac: create of compatible mdio bus for stmmac driver") introduced a backward compatibily issue by using of_mdiobus_register explicitly with an mdio subnode. This patch fixes th

Re: [PATCH] netconsole: Initialize after all core networking drivers

2015-12-29 Thread Hannes Frederic Sowa
On 29.12.2015 00:21, Cong Wang wrote: On Thu, Dec 24, 2015 at 2:25 AM, Hannes Frederic Sowa wrote: Hi, On 24.12.2015 00:03, Calvin Owens wrote: This patch addresses the issue cited in 7332a13b038be05c by making vxlan actually check if ipv6 is loaded, and reverts it to module_init() so that it

Re: [RFC PATCH net-next 3/3] macsec: introduce IEEE 802.1AE driver

2015-12-29 Thread Sabrina Dubroca
2015-12-29, 02:14:06 +0100, Florian Westphal wrote: > Sabrina Dubroca wrote: > > + if (h->short_length) > > + return len == h->short_length + 24; > > + else > > + return len >= 72; > [..] > > + return len == h->short_length

  1   2   >