Typically we return error pointers when we want to use those
pointers in the non-error case, but this function is just
returning error pointers or NULL for success. Change the style to
plain int to follow normal kernel coding styles.
Cc: Joachim Eastwood
Signed-off-by: Stephen Boyd
---
.../net/
On Wed, Dec 02, 2015 at 05:02:19PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/2/2015 3:54 PM, LABBE Corentin wrote:
>
> > The simple_strtol function is obsolete.
> > This patch replace it by kstrtoint.
> > This will simplify code, since some error case not handled by
> > simple_strtol are h
On Wed 2015-12-02 22:43:31, Chris Snook wrote:
> On Tue, Dec 1, 2015 at 12:35 PM David Miller wrote:
>
> > From: Michal Hocko
> > Date: Mon, 30 Nov 2015 14:21:29 +0100
> >
> > > On Sat 28-11-15 15:51:13, Pavel Machek wrote:
> > >>
> > >> atl1c driver is doing order-4 allocation with GFP_ATOMIC
>
On Thu, Dec 3, 2015 at 1:20 AM, John Fastabend wrote:
> On 15-12-02 12:07 PM, Jiri Pirko wrote:
>> From: Ido Schimmel
>>
>> switchdev drivers reflect the newly requested topology to hardware when
>> CHANGEUPPER is received, after software links were already formed.
>> However, the operation can f
On Wed, 2015-12-02 at 23:42 -0500, David Miller wrote:
> Please update the commit log message with the details you
> provided in a reply to this thread.
Sure, I sent a v2.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.k
From: Eric Dumazet
While testing the np->opt RCU conversion, I found that UDP/IPv6 was
using a mixture of xchg() and sk_dst_lock to protect concurrent changes
to sk->sk_dst_cache, leading to possible corruptions and crashes.
ip6_sk_dst_lookup_flow() uses sk_dst_check() anyway, so the simplest
wa
From: Eric Dumazet
This patch completes the work I did in commit 45f6fad84cc3
("ipv6: add complete rcu protection around np->opt"), as I missed
sctp part.
This simply makes sure np->opt is used with proper RCU locking
and accessors.
Signed-off-by: Eric Dumazet
---
net/sctp/ipv6.c | 13 +
On Wed, 2015-12-02 at 23:38 -0500, David Miller wrote:
> From: Eric Dumazet
> Date: Sun, 29 Nov 2015 19:37:57 -0800
>
> > From: Eric Dumazet
> >
> > This patch addresses multiple problems :
> >
> > UDP/RAW sendmsg() need to get a stable struct ipv6_txoptions
> > while socket is not locked : Ot
From: Konstantin Khlebnikov
Date: Tue, 01 Dec 2015 01:14:48 +0300
> Proxy entries could have null pointer to net-device.
>
> Signed-off-by: Konstantin Khlebnikov
> Fixes: 84920c1420e2 ("net: Allow ipv6 proxies and arp proxies be shown with
> iproute2")
Applied and queued up for -stable.
--
To
From: Jarod Wilson
Date: Mon, 30 Nov 2015 17:12:21 -0500
> Don't open-code it.
>
> CC: Solarflare linux maintainers
> CC: Shradha Shah
> CC: netdev@vger.kernel.org
> Signed-off-by: Jarod Wilson
Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the bo
From: Robert Jarzmik
Date: Mon, 30 Nov 2015 22:40:28 +0100
> Convert the dma transfers to be dmaengine based, now pxa has a dmaengine
> slave driver. This makes this driver a bit more PXA agnostic.
>
> The driver was only compile tested. The risk is quite small as no
> current PXA platform I'm a
From: ebied...@xmission.com (Eric W. Biederman)
Date: Mon, 30 Nov 2015 15:38:15 -0600
> + if (dev_net(br->dev) == &init_net)
Please respin this using net_eq() as Hannes pointed out.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to major
From: Eric Dumazet
Date: Mon, 30 Nov 2015 08:57:28 -0800
> From: Eric Dumazet
>
> If tcp_send_ack() can not allocate skb, we properly handle this
> and setup a timer to try later.
>
> Use __GFP_NOWARN to avoid polluting syslog in the case host is
> under memory pressure, so that pertinent mess
From: Eric Dumazet
Date: Mon, 30 Nov 2015 08:35:15 -0800
> From: Eric Dumazet
>
> While testing the np->opt RCU conversion, I found that UDP/IPv6 was
> using a mixture of xchg() and sk_dst_lock to protect concurrent changes
> to sk->sk_dst_cache, leading to possible corruptions and crashes.
>
From: Marcelo Ricardo Leitner
Date: Mon, 30 Nov 2015 12:17:06 -0200
> They don't need to be any bigger than that and with this we start a new
> bitfield for tracking association runtime stuff, like zero window
> situation.
>
> Signed-off-by: Marcelo Ricardo Leitner
Applied.
--
To unsubscribe f
From: Marcelo Ricardo Leitner
Date: Mon, 30 Nov 2015 14:32:54 -0200
> Dmitry Vyukov reported that the user could trigger a kernel warning by
> using a large len value for getsockopt SCTP_GET_LOCAL_ADDRS, as that
> value directly affects the value used as a kmalloc() parameter.
>
> This patch thu
From: Eric Dumazet
Date: Sun, 29 Nov 2015 19:37:57 -0800
> From: Eric Dumazet
>
> This patch addresses multiple problems :
>
> UDP/RAW sendmsg() need to get a stable struct ipv6_txoptions
> while socket is not locked : Other threads can change np->opt
> concurrently. Dmitry posted a syzkaller
From: Alexei Starovoitov
Date: Sun, 29 Nov 2015 16:59:35 -0800
> From: Alexei Starovoitov
>
> For large map->value_size the user space can trigger memory allocation
> warnings like:
...
> To avoid never succeeding kmalloc with order >= MAX_ORDER check that
> elem->value_size and computed elem
On 2015/12/2 1:25, Alexander Duyck wrote:
> On 11/30/2015 11:12 PM, Ding Tianhong wrote:
>> Hi Everyone:
>>
>> I found this problem when using the Testgine to send package to the 82599
>> ethernet:
>> 1.wait for the speed to 10G/bit, it's ok.
>> 2.then down the eth and then up, loop for several ti
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
I'm looking into a problem with the mediatomb package not starting up
correctly on recent Ubuntu releases, and I see that the problem is
that the service depends on a network up event generated by
network-manager to start. While it actually depends
On Wed, Dec 02, 2015 at 03:35:53PM -0800, John Fastabend wrote:
> [...]
> > BPF. Implementing protocol generic offloads are not just a HW concern
> > either, adding kernel GRO code for every possible protocol that comes
> > along doesn't scale well. This becomes especially obvious when we
> > consi
On Wed, 2015-12-02 at 16:45 -0500, David Miller wrote:
> From: Jeff Kirsher
> Date: Wed, 2 Dec 2015 04:30:53 -0800
>
> > This series contains updates to ixgbe and ixgbevf only.
>
> I've marked this "changed requested" pending resolution of the ipv6
> header parsing feedback Alexander gave.
v2
On 12/02/2015 03:56 AM, David Laight wrote:
From: Sowmini Varadhan
Sent: 01 December 2015 18:37
...
I was using esp-null merely to not have the crypto itself perturb
the numbers (i.e., just focus on the s/w overhead for now), but here
are the numbers for the stock linux kernel stack
Alexander Duyck wrote:
> This doesn't look right. How come this doesn't match the implementation you
> did for the ixgbevf driver? If I am not mistaken this approach had issues
> where it could spin forever didn't it?
Yes, this is the original version of the patch instead of the V4 of the pa
On Wed, Dec 2, 2015 at 3:35 PM, John Fastabend wrote:
> [...]
>
>>>
>>> I wonder why we need protocol generic offloads? I know there are
>>> currently a lot of overlay encapsulation protocols. Are there many more
>>> coming?
>>>
>> Yes, and assume that there are more coming with an unbounded limit
On 11/30/2015 01:01 PM, Paul Bolle wrote:
> On ma, 2015-11-30 at 00:23 +0100, Paul Bolle wrote:
>> Relevant part of dmesg attached at the end of this message. This
>> should give me (and Tilman too?) an entry to get to bottom of this.
>> Since this is relevant for anyone with just the ser-gigaset
[...]
>>
>> I wonder why we need protocol generic offloads? I know there are
>> currently a lot of overlay encapsulation protocols. Are there many more
>> coming?
>>
> Yes, and assume that there are more coming with an unbounded limit
> (for instance I just noticed today that there is a netdev1.1
From: Jiri Pirko
Date: Wed, 2 Dec 2015 23:53:53 +0100
> Dave, why this was marked "Changes Requested" in patchwork?
Because you gotta kill that BUG_ON() as per our discussion.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.o
From: Jiri Pirko
Date: Wed, 2 Dec 2015 23:35:31 +0100
> Why to continue to work if we know that we are making things wrong
> (incorrect structure initialization in this case) ? What am I missing?
The user might be able to continue to have connectivity and
report the problem.
BUG_ON() is really
On 15-12-02 12:07 PM, Jiri Pirko wrote:
> From: Ido Schimmel
>
> switchdev drivers reflect the newly requested topology to hardware when
> CHANGEUPPER is received, after software links were already formed.
> However, the operation can fail and user will not be notified, as the
> return value of t
3.13.11-ckt31 -stable review patch. If anyone has any objections, please let
me know.
--
From: Marek Vasut
commit 562b103a21974c2f9cd67514d110f918bb3e1796 upstream.
The sizeof() is invoked on an incorrect variable, likely due to some
copy-paste error, and this might result in
On Wed, Dec 2, 2015 at 10:12 AM, Jiri Benc wrote:
> This adds IPv6 support to ndo_fill_metadata_dst in vxlan together with
> restructuring to avoid duplicate code.
>
We need the ndo_fill_metadata_dst IPv6 support in net branch, since
OVS IPv6 tunnel support is there already. Is there reason you
On Tue, Dec 1, 2015 at 9:33 AM, Paolo Abeni wrote:
> Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference
> to the underlying tunnel device, but never released it when such
> device is deleted.
> Deleting the underlying device via the ip tool cause the kernel to
> hangup in the netde
Hi Marcin,
On mer., déc. 02 2015, Marcin Wojtas wrote:
>>>
2. Change condition in mvebu_mbus_get_dram_win_info to:
if (cs->base <= phyaddr && phyaddr <= (cs->base + cs->size -1))
>>>
>>> I think it would be the best solution.
>>
>> So I applied the following patch:
>> --- a/drivers/bu
Dave, why this was marked "Changes Requested" in patchwork?
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This is a note to let you know that I have just added a patch titled
can: Use correct type in sizeof() in nla_put()
to the linux-3.13.y-queue branch of the 3.13.y-ckt extended stable tree
which can be found at:
http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.13.y-queue
Thi
Wed, Dec 02, 2015 at 11:28:47PM CET, da...@davemloft.net wrote:
>From: Jiri Pirko
>Date: Wed, 2 Dec 2015 23:25:52 +0100
>
>> Again, there is no possible way to achieve this bugon, other than a
>> stack corruption. I don't think we should try to cope with a stack
>> corruption.
>
>Then remove the a
From: Jiri Pirko
Date: Wed, 2 Dec 2015 23:25:52 +0100
> Again, there is no possible way to achieve this bugon, other than a
> stack corruption. I don't think we should try to cope with a stack
> corruption.
Then remove the assertion.
--
To unsubscribe from this list: send the line "unsubscribe n
Wed, Dec 02, 2015 at 11:05:48PM CET, gerlitz...@gmail.com wrote:
>On Sun, Nov 29, 2015 at 12:49 PM, Jiri Pirko wrote:
>> Sun, Nov 29, 2015 at 10:04:07AM CET, gerlitz...@gmail.com wrote:
>>>[..]
+enum mlxsw_hwmon_attr_type {
+ MLXSW_HWMON_ATTR_TYPE_TEMP,
+ MLXSW_HWMON_ATT
On Wed, 2015-12-02 at 16:12 -0500, Sowmini Varadhan wrote:
> IPv6 would be an interesting academic exercise
Really, you made my day !
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ke
Hi Gregory,
2015-12-02 17:21 GMT+01:00 Gregory CLEMENT :
> Hi,
>
> On mer., déc. 02 2015, Gregory CLEMENT
> wrote:
>
>>>
>>> So far the issue may have been not noticed, because in every IO driver
>>> using mvebu_mbus_dram_info for configuring MBUS windows, there's
>>> following substraction:
>>
This patch implements an ILA tanslation table. This table can be
configured with identifier to locator mappings, and can be be queried
to resolve a mapping. Queries can be parameterized based on interface,
direction (incoming or outoing), and matching locator. The table is
implemented using rhasht
In the current implementation of ILA, LWT is used to perform
translation on both the input and output paths. This is functional,
however there is a big performance hit in the receive path. Early
demux occurs before the routing lookup (a hit actually obviates the
route lookup). Therefore the stack c
Add the rhashtable_replace_fast function. This replaces one object in
the table with another atomically. The hashes of the new and old objects
must be equal.
Signed-off-by: Tom Herbert
---
include/linux/rhashtable.h | 82 ++
1 file changed, 82 insertio
Create ila directory in preparation for supporting other hooks in the
kernel than LWT for doing ILA. This includes:
- Moving ila.c to ila/ila_lwt.c
- Splitting out some common functions into ila_common.c
Signed-off-by: Tom Herbert
---
net/ipv6/Makefile | 2 +-
net/ipv6/ila.c
The start callback allows the caller to set up a context for the
dump callbacks. Presumably, the context can then be destroyed in
the done callback.
Signed-off-by: Tom Herbert
---
include/linux/netlink.h | 2 ++
include/net/genetlink.h | 2 ++
net/netlink/af_netlink.c | 4
net/netlink/
Add two target ILAIN and ILAOUT which hook into the ILA module.
Signed-off-by: Tom Herbert
---
net/netfilter/Kconfig | 12
net/netfilter/Makefile | 1 +
net/netfilter/xt_ILA.c | 82 ++
3 files changed, 95 insertions(+)
create mode 10064
On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> Allow the selection of the transmission queue based on the CPU id.
Explain why.
>
> Signed-off-by: Madalin Bucur
> ---
> drivers/net/ethernet/freescale/dpaa/Kconfig | 10 ++
> drivers/net/ethernet/freescale/dpaa/dpaa_e
On (12/02/15 14:01), Tom Herbert wrote:
> No, please don't persist is this myopic "we'll get to IPv6 later"
> model! IPv6 is a real protocol, it has significant deployment of the
> Internet, and there are now whole data centers that are IPv6 only
> (e.g. FB), and there are plenty of use cases of IP
On Sun, Nov 29, 2015 at 12:49 PM, Jiri Pirko wrote:
> Sun, Nov 29, 2015 at 10:04:07AM CET, gerlitz...@gmail.com wrote:
>>[..]
>>> +enum mlxsw_hwmon_attr_type {
>>> + MLXSW_HWMON_ATTR_TYPE_TEMP,
>>> + MLXSW_HWMON_ATTR_TYPE_TEMP_MAX,
>>> +};
>>> +
>>> +static void mlxsw_hwmon_attr_add(st
On Wed, Dec 2, 2015 at 1:47 PM, Sowmini Varadhan
wrote:
> On (12/02/15 13:44), Tom Herbert wrote:
>> > IPv6 would be an interesting academic exercise, but it's going
>> > to be a while before we get RDS-TCP to go over IPv6.
>> >
>> Huh? Who said anything about RDS-TCP? I thought you were trying to
> Please add them and send a new pull request, I'll just skip over your
> existing one.
Ok, here we go, below a new pull request.
I've added the two commits I spoke about, fixing scanning and an
uninitialized cookie variable that lead to problems if the value
happened to be 0.
Let me know if th
On (12/02/15 13:44), Tom Herbert wrote:
> > IPv6 would be an interesting academic exercise, but it's going
> > to be a while before we get RDS-TCP to go over IPv6.
> >
> Huh? Who said anything about RDS-TCP? I thought you were trying to
> improve IPsec performance...
yes, and it would be nice to f
From: Jeff Kirsher
Date: Wed, 2 Dec 2015 04:30:53 -0800
> This series contains updates to ixgbe and ixgbevf only.
I've marked this "changed requested" pending resolution of the ipv6
header parsing feedback Alexander gave.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
t
On Wed, Dec 2, 2015 at 1:12 PM, Sowmini Varadhan
wrote:
> On (12/02/15 13:07), Tom Herbert wrote:
>> That's easy enough to add to flow dissector, but is SPI really
>> intended to be used an L4 entropy value? We would need to consider the
>
> yes. To quote https://en.wikipedia.org/wiki/Security_Par
On (12/02/15 13:07), Tom Herbert wrote:
> That's easy enough to add to flow dissector, but is SPI really
> intended to be used an L4 entropy value? We would need to consider the
yes. To quote https://en.wikipedia.org/wiki/Security_Parameter_Index
"This works like port numbers in TCP and UDP connec
Hi Michael,
Thanks a lot for your answer. We tested some vanilla mainline 4.3
kernels on an Electra reference board. Additionally we tested some
patched 4.3 kernels on our Nemo boards.
It would be really fantastic, if you could fix the problem.
Cheers,
Christian
On 02 December 2015 at 09:1
On Wed, 2015-12-02 at 15:48 -0500, David Miller wrote:
> From: Joe Perches 02 Dec 2015 02:12:29 -0800
> > On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote:
> >> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote:
> >> > Noticed-by: Sergei Shtylyov
> >> Don't you mean Reported-by? I am no
On Wed, Dec 2, 2015 at 12:50 PM, Sowmini Varadhan
wrote:
> On (12/02/15 12:41), David Laight wrote:
>> You are getting 0.7 Gbps with ass-ccm-a-128, scale the esp-null back to
>> that and it would use 7/18*71 = 27% of the cpu.
>> So 69% of the cpu in the a-128 case is probably caused by the
>> encr
From: Pavel Fedin
Date: Wed, 02 Dec 2015 14:30:37 +0300
> Hello again!
>
>> Subject: RE: [PATCH v2 4/5] net: thunderx: Switchon carrier only upon
>> interface link up
>>
>> Just a reminder, we have issue with this one too, which is not addressed
>> yet.
>
> I have examined the problem tho
On (12/02/15 12:41), David Laight wrote:
> You are getting 0.7 Gbps with ass-ccm-a-128, scale the esp-null back to
> that and it would use 7/18*71 = 27% of the cpu.
> So 69% of the cpu in the a-128 case is probably caused by the
> encryption itself.
> Even if the rest of the code cost nothing you'd
I'm not even looking at this patch series while it still causes
unresolved bugs.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Joe Perches
Date: Wed, 02 Dec 2015 02:12:29 -0800
> On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote:
>> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote:
>> > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string
>> > building")
>> > added defective output when I40E_FLAG_V
From: Johannes Berg
Date: Wed, 02 Dec 2015 10:46:50 +0100
>>
>> A small set of fixes for 4.4:
>> * remove NL80211_FEATURE_FULL_AP_CLIENT_STATE again, it
>> was broken and needs more work, we'll enable it for 4.5
>> * fix call_r
From: Will Deacon
Date: Wed, 2 Dec 2015 09:15:18 +
> On Tue, Dec 01, 2015 at 02:20:40PM -0800, Shi, Yang wrote:
>> On 11/30/2015 2:24 PM, Yang Shi wrote:
>> >aarch64 doesn't have native store immediate instruction, such operation
>> >has to be implemented by the below instruction sequence:
>>
From: Jeff Kirsher
Date: Wed, 2 Dec 2015 00:25:18 -0800
> This series contains updates to i40e and i40evf only.
Pulled, thanks Jeff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ker
From: Gregory CLEMENT
Date: Wed, 02 Dec 2015 09:16:06 +0100
> Hi David,
>
> On mer., déc. 02 2015, David Miller wrote:
>
>> From: Marcin Wojtas
>> Date: Mon, 30 Nov 2015 13:27:40 +0100
>>
>>> I'm sending v4 with corrected commit log of the last patch, in order
>>> to avoid possible conflict
On 12/02/2015 09:07 PM, Jiri Pirko wrote:
> From: Jiri Pirko
>
> Initialize netdev_lag_upper_info structure by TX type according to
> current bonding mode and pass it along via netdev_master_upper_dev_link.
>
> Signed-off-by: Jiri Pirko
> ---
> v1->v2:
> -added mode broadcast suggested by Nik
>
On 12/02/2015 09:07 PM, Jiri Pirko wrote:
> From: Ido Schimmel
>
> switchdev drivers reflect the newly requested topology to hardware when
> CHANGEUPPER is received, after software links were already formed.
> However, the operation can fail and user will not be notified, as the
> return value of
On 12/02/2015 09:07 PM, Jiri Pirko wrote:
> From: Ido Schimmel
>
> Since CHANGEUPPER can now fail, add support for it in the newly
> introduced netdev notifier error injection infrastructure.
>
> Signed-off-by: Ido Schimmel
> Signed-off-by: Jiri Pirko
> ---
> v1->v2:
> -new patch
> ---
> Docu
Commit 5405ff6e15f40f2f ("tipc: convert node lock to rwlock")
introduced a bug to the node reference counter handling. When a
message is successfully sent in the function tipc_node_xmit(),
we return directly after releasing the node lock, instead of
continuing and decrementing the node reference co
From: Ido Schimmel
Since CHANGEUPPER can now fail, add support for it in the newly
introduced netdev notifier error injection infrastructure.
Signed-off-by: Ido Schimmel
Signed-off-by: Jiri Pirko
---
v1->v2:
-new patch
---
Documentation/fault-injection/notifier-error-inject.txt | 1 +
lib/net
From: Jiri Pirko
Implement FDB offloading for lagged ports, including learning LAG FDB
entries, adding/removing static FDB entries and dumping existing LAG FDB
entries.
Signed-off-by: Jiri Pirko
---
.../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 182 +
1 file changed,
From: Jiri Pirko
During options set, there will be needed to hold rtnl_mutex in order to
safely call netdev notifiers.
Signed-off-by: Jiri Pirko
---
drivers/net/team/team.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/team/team.c b/drivers/net/tea
From: Jiri Pirko
Be correct and symmetric to enslave and set inactive flags during release.
That gives LAG offload drivers - lower state change listeners - possibility
to do proper cleanup.
Signed-off-by: Jiri Pirko
---
drivers/net/bonding/bond_main.c | 2 ++
1 file changed, 2 insertions(+)
d
From: Jiri Pirko
Similar to state notifications.
We allow caller to indicate if the notification should happen now or later,
depending on if he holds rtnl mutex or not. Introduce bond_slave_link_notify
function (similar to bond_slave_state_notify) which is later on called
with rtnl mutex and goe
From: Jiri Pirko
This struct will be shared by bonding and team to pass internal
information to notifier listeners.
Signed-off-by: Jiri Pirko
---
include/linux/netdevice.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
i
From: Jiri Pirko
When lower device like bonding slave, team/bridge port, etc changes its
state, it is useful for others to notice this change. Currently this is
implemented specificly for bonding as NETDEV_BONDING_INFO notifier. This
patch aims to replace this specific usage and make this more ge
From: Jiri Pirko
Lower layer (pci) has information if the packet is received via LAG port.
If that is the case, it fills up rx_info accordingly. However upper
layer does not care about lag_id/port_index for received packets so
convert it to local_port before passing it up. For that conversion, la
From: Jiri Pirko
Implement basic procedures for joining/leaving port to/from LAG. That
includes HW setup of collector, core LAG mapping setup.
Signed-off-by: Jiri Pirko
---
v1->v2:
- return NOTIFY_BAD in case join/leave fails as requested by Andy
- change BUG_ON to WARN_ON as suggested by Or an
From: Jiri Pirko
LAG-related records have specific format in SFD register.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/reg.h | 79 +++
1 file changed, 71 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h
b/d
From: Jiri Pirko
Add definitions of SLDR, SLCR2, SLCOR registers that are used to
configure LAG.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/reg.h | 293 ++
1 file changed, 293 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg
From: Jiri Pirko
Some code does not mind if a device is bond slave or team port and treats
them the same, as generic LAG ports.
Signed-off-by: Jiri Pirko
---
include/linux/netdevice.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
From: Jiri Pirko
Similar to other speeds, add 100G to bonding 802.3ad code.
Signed-off-by: Jiri Pirko
---
drivers/net/bonding/bond_3ad.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
index 940e2eb
From: Jiri Pirko
Initialize netdev_lag_upper_info structure by TX type according to
current team mode and pass it along via netdev_master_upper_dev_link.
Signed-off-by: Jiri Pirko
---
drivers/net/team/team.c | 23 ---
drivers/net/team/team_mode_activebacku
From: Jiri Pirko
LAG-related records have specific format in SFN register.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/reg.h | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h
b/drivers/net
From: Jiri Pirko
Some code does not mind if the master is bond or team and treats them
the same, as generic LAG.
Signed-off-by: Jiri Pirko
---
include/linux/netdevice.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index e7eca8f.
From: Jiri Pirko
Completion queue element for receive queue provides information if the
packet was received via LAG port. Extract this info and pass it along
to core.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/pci.c | 19 ---
drivers/net/ethernet/mellanox
From: Jiri Pirko
Enabling/disabling TX on a LAG port means enabling/disabling distribution
in our HW.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 81 +-
1 file changed, 79 insertions(+), 2 deletions(-)
diff --git a/drivers/net/etherne
From: Jiri Pirko
Eliminate netdev_master_upper_dev_link_private and pass priv directly as
a parameter of netdev_master_upper_dev_link.
Signed-off-by: Jiri Pirko
---
drivers/net/bonding/bond_main.c | 2 +-
drivers/net/team/team.c | 2 +-
drivers/net/vrf.c | 2 +-
includ
From: Jiri Pirko
Add just a stub for now. This allows to pass check in dev_ifsioc,
SIOCADDMULTI and SIOCDELMULTI cases. Teamd is using these to add LACP
slow MAC.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 5 +
1 file changed, 5 insertions(+)
diff --git
From: Jiri Pirko
Similar to other helpers, caller can use this to find out if device is
team port.
Signed-off-by: Jiri Pirko
---
include/linux/netdevice.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index cfb56e0..e7eca8f 10064
From: Jiri Pirko
Initialize netdev_lag_upper_info structure by TX type according to
current bonding mode and pass it along via netdev_master_upper_dev_link.
Signed-off-by: Jiri Pirko
---
v1->v2:
-added mode broadcast suggested by Nik
---
drivers/net/bonding/bond_main.c | 45 +++
From: Jiri Pirko
Let netdev notifier listeners know about link and slave state change.
Signed-off-by: Jiri Pirko
---
drivers/net/bonding/bond_main.c | 10 ++
include/net/bonding.h | 7 +++
2 files changed, 17 insertions(+)
diff --git a/drivers/net/bonding/bond_main.c b/
From: Jiri Pirko
This is shared info structure for bonding and team. Serves to pass down
info about link state and port activity to notification listeners.
Signed-off-by: Jiri Pirko
---
include/linux/netdevice.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/netdevice.h
From: Jiri Pirko
This patchset introduces needed infrastructure for link aggregation
offload - for both team and bonding. It also implements the offload
in mlxsw driver.
Particulary, this patchset introduces possibility for upper driver
(bond/team/bridge/..) to pass type-specific info down to no
From: Ido Schimmel
switchdev drivers reflect the newly requested topology to hardware when
CHANGEUPPER is received, after software links were already formed.
However, the operation can fail and user will not be notified, as the
return value of the notifier is not checked.
Add this check and roll
From: Jiri Pirko
Let netdev notifier listeners know about link-up and port-enable state
changes.
Signed-off-by: Jiri Pirko
---
drivers/net/team/team.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
ind
From: Jiri Pirko
Similar to other helpers, caller can use this to find out if device is
team master.
Signed-off-by: Jiri Pirko
---
drivers/net/team/team.c | 1 +
include/linux/netdevice.h | 8
2 files changed, 9 insertions(+)
diff --git a/drivers/net/team/team.c b/drivers/net/team/
From: Jiri Pirko
Sometimes the drivers and other code would find it handy to know some
internal information about upper device being changed. So allow upper-code
to pass information down to notifier listeners during linking.
Signed-off-by: Jiri Pirko
---
v1->v2:
- change "is upper info" to "upp
1 - 100 of 254 matches
Mail list logo
