Re: [PATCH net-next v5] mpls: support for dead routes

2015-11-27 Thread roopa
On 11/25/15, 8:18 AM, David Miller wrote: > From: Roopa Prabhu > Date: Tue, 24 Nov 2015 15:22:22 -0800 > >> v4 -v5 >> - if kmemdup fails, modify the original route in place. This is a >> corner case and only side effect is that in the remote case >> of kmemdup failure, the changes w

Re: [PATCH iproute2 -next 3/5] {f,m}_bpf: allow for user-defined object pinnings

2015-11-27 Thread David Ahern
On 11/27/15 6:41 PM, Daniel Borkmann wrote: On 11/28/2015 01:26 AM, David Ahern wrote: ... seems like an unrelated change. Nope, it's being reused from tc_bpf.c. ack. missed that earlier. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord.

[PATCH net-next 1/3] dts: hisi: enables the ethX for D02 board

2015-11-27 Thread yankejian
this patch enables the ethX for D02 board on hip05-d02.dts. otherwise it cannot find hns ethX by ifconfig -a. Signed-off-by: yankejian --- arch/arm64/boot/dts/hisilicon/hip05-d02.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hip05-d02.dts

[PATCH net-next 2/3] dts: hisi: fixes no syscon error when init mdio

2015-11-27 Thread yankejian
when linux start up, we get the log below: "Hi-HNS_MDIO 803c.mdio: no syscon hisilicon,peri-c-subctrl mdio_bus mdio@803c: mdio sys ctl reg has not maped " the source code about the subctrl is dealled with syscon, but dts doesn't. it cause such fault. so this patch adds the syscon in

[PATCH net-next 0/3] dts: hisi: fixes can't find eth for hip05-D02

2015-11-27 Thread yankejian
this patchset fixes the bug that eth can't initial successful. because the the dts files doesn't match the source code. yankejian (3): dts: hisi: enables the ethX for D02 board dts: hisi: fixes no syscon error when init mdio arm64: hip05-d02: Document devicetree bindings for Hisilicon D02 Bo

Re: [PATCH net] drivers: net: xgene: fix possible use after free

2015-11-27 Thread Iyappan Subramanian
On Wed, Nov 25, 2015 at 9:02 AM, Eric Dumazet wrote: > From: Eric Dumazet > > Once TX has been enabled on a NIC, it is illegal to access skb, > as this skb might have been freed by another cpu, from TX completion > handler. > > Signed-off-by: Eric Dumazet > Reported-by: Mark Rutland > Tested-by

[PATCH] drivers: net: xgene: fix Tx flow control

2015-11-27 Thread Iyappan Subramanian
Currently the Tx flow control is based on reading the hardware state, which is not accurate since it may not reflect the descriptors that are not yet reached the memory. To accurately control the Tx flow, changing it to be software based. Signed-off-by: Iyappan Subramanian Tested-by: Khuong Dinh

Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-27 Thread Aaron Conole
Eric Dumazet writes: > On Wed, 2015-11-25 at 22:17 -0500, Aaron Conole wrote: > >> Probably that would call for a different more primitive version of this >> API (sk_gfp_or_memalloc() as you suggest below). Then this could be >> written in terms of that >> >> static inline sk_gfp_or_memalloc(cons

Re: [PATCH iproute2 -next 3/5] {f,m}_bpf: allow for user-defined object pinnings

2015-11-27 Thread Daniel Borkmann
On 11/28/2015 01:26 AM, David Ahern wrote: ... seems like an unrelated change. Nope, it's being reused from tc_bpf.c. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

Re: gigaset: freeing an active object

2015-11-27 Thread Sasha Levin
On 11/27/2015 08:20 PM, Peter Hurley wrote: > It would really help if you included the syzkaller-generated applet with > the bug reports; state previously established by the applet can be > crucial in understanding why the call stack looks the way it does. > > Also, every generated applet that tri

Re: gigaset: freeing an active object

2015-11-27 Thread Peter Hurley
On 11/27/2015 07:28 PM, Paul Bolle wrote: > (A few quick notes follow. The hope here is basically that my display of > ignorance might trigger others to speak up while I'm still pondering on > this bug.) > > On vr, 2015-11-27 at 13:15 -0500, Sasha Levin wrote: >> On 11/27/2015 12:57 PM, Paul Bolle

Re: gigaset: freeing an active object

2015-11-27 Thread Paul Bolle
(A few quick notes follow. The hope here is basically that my display of ignorance might trigger others to speak up while I'm still pondering on this bug.) On vr, 2015-11-27 at 13:15 -0500, Sasha Levin wrote: > On 11/27/2015 12:57 PM, Paul Bolle wrote: > > On vr, 2015-11-27 at 10:19 -0500, Sasha L

Re: [PATCH iproute2 -next 3/5] {f,m}_bpf: allow for user-defined object pinnings

2015-11-27 Thread David Ahern
On 11/26/15 5:58 AM, Daniel Borkmann wrote: diff --git a/include/utils.h b/include/utils.h index 5902a98..e830be6 100644 --- a/include/utils.h +++ b/include/utils.h @@ -40,6 +40,10 @@ extern bool do_all; #define IPSEC_PROTO_ANY 255 #endif +#ifndef CONFDIR +#define CONFDIR

[iproute PATCH 0/5] warning-annoyance induced code-review

2015-11-27 Thread Phil Sutter
The primary goal was to get rid of the -Wunused-result warnings emitted during compiling. While adding the necessary checks, I found a few functions which could benefit from a bigger review (patches 1, 2 and 3). Patch 4 then adds the remaining missing checks, and patch 5 simplifies fgets() usage at

[iproute PATCH 2/5] ss: reduce max indentation level in init_service_resolver()

2015-11-27 Thread Phil Sutter
Exit early or continue on error instead of putting conditional into conditional to make reading the code a bit easier. Also, the call to memcpy() can be skipped by initialising prog with the desired prefix. Signed-off-by: Phil Sutter --- misc/ss.c | 53 ++

[iproute PATCH 5/5] get rid of unnecessary fgets() buffer size limitation

2015-11-27 Thread Phil Sutter
fgets() will read at most size-1 bytes into the buffer and add a terminating null-char at the end. Therefore it is not necessary to pass a reduced buffer size when calling it. This change was generated using the following semantic patch: @@ identifier buf, fp; @@ - fgets(buf, sizeof(buf) - 1, fp)

[iproute PATCH 3/5] ss: review is_ephemeral()

2015-11-27 Thread Phil Sutter
No need to keep static port boundaries global, they are not used directly. Keeping them local also allows to safely reduce their names to the minimum. Assign hardcoded fallback values also if fscanf() fails. Get rid of unnecessary braces around return parameter. Instead of more or less duplicating

[iproute PATCH 1/5] lnstat: review lnstat_update()

2015-11-27 Thread Phil Sutter
Instead of calling rewind() and fgets() before every call to scan_lines(), move them into scan_lines() itself. This should also fix compat mode, as before the second call to scan_lines() the first line was skipped unconditionally. Signed-off-by: Phil Sutter --- misc/lnstat_util.c | 18 +++--

[iproute PATCH 4/5] get rid of remaining -Wunused-result warnings

2015-11-27 Thread Phil Sutter
Although not fundamentally necessary to check return codes in these spots, preventing the warnings will put new ones into focus. Signed-off-by: Phil Sutter --- misc/ifstat.c | 6 -- misc/lnstat_util.c | 3 ++- misc/nstat.c | 6 -- misc/ss.c | 18 ++

[PATCH] vmxnet3: fix checks for dma mapping errors

2015-11-27 Thread Alexey Khoroshilov
vmxnet3_drv does check dma_addr with dma_mapping_error() after mapping dma memory. The patch adds the checks and tries to handle failures. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/vmxnet3/vmxnet3_drv.c | 71

[PATCH] ravb: add R8A7791 support

2015-11-27 Thread Sergei Shtylyov
Add support for yet another ARM member of the R-Car family, R-Car M2, also known as R8A7791. Signed-off-by: Sergei Shtylyov --- The patch is against DaveM's 'net-next.git' repo but I wouldn't mind if it's applied to 'net.git' instead. :-) Documentation/devicetree/bindings/net/renesas,ravb.txt

net: Use after free in dst_release on boot

2015-11-27 Thread Sasha Levin
Hi, I've observed the following use-after-free on boot with the latest -next. It seems to reproduce once in a while, doesn't seem to be deterministic. [ 112.353948] Sending DHCP requests . [ 115.375304] IP-Config: Got DHCP answer from 192.168.33.1, my address is 192.168.33.15 [ 117.056357]

[PATCH] wan/x25: Fix use-after-free in x25_asy_open_tty()

2015-11-27 Thread Peter Hurley
The N_X25 line discipline may access the previous line discipline's closed and already-freed private data on open [1]. The tty->disc_data field _never_ refers to valid data on entry to the line discipline's open() method. Rather, the ldisc is expected to initialize that field for its own use for t

[PATCH iproute] vxlan: Add support for remote checksum offload

2015-11-27 Thread Tom Herbert
This patch adds support to remote checksum checksum offload to VXLAN. This patch adds remcsumtx and remcsumrx to ip vxlan configuration to enable remote checksum offload for transmit and receive on the VXLAN tunnel. https://tools.ietf.org/html/draft-herbert-vxlan-rco-00 Example: ip link add name

Re: gigaset: freeing an active object

2015-11-27 Thread Sasha Levin
On 11/27/2015 12:57 PM, Paul Bolle wrote: > Hi Sascha, > > On vr, 2015-11-27 at 10:19 -0500, Sasha Levin wrote: >> Fuzzing with syzkaller on the latest -next kernel produced this error: > > (syzkaller is new to me. I'll have to do some web searches.) It's a new fancy syscall/ioctl fuzzer, https

Re: gigaset: freeing an active object

2015-11-27 Thread Paul Bolle
Hi Sascha, On vr, 2015-11-27 at 10:19 -0500, Sasha Levin wrote: > Fuzzing with syzkaller on the latest -next kernel produced this error: (syzkaller is new to me. I'll have to do some web searches.) > [ 413.536749] WARNING: CPU: 6 PID: 25400 at lib/debugobjects.c:263 > debug_print_object+0x1c4/0

RE

2015-11-27 Thread Mrs Hesham Fatemah
My name is Mrs Hesham Fatemah,i have an inheritance for you,contact me for more details. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC PATCH net] Revert "ipv6: ndisc: inherit metadata dst when creating ndisc requests"

2015-11-27 Thread Nicolas Dichtel
This reverts commit ab450605b35caa768ca33e86db9403229bf42be4. In IPv6, we cannot inherit the dst of the original dst. ndisc packets are IPv6 packets and may take another route than the original packet. This patch breaks the following scenario: a packet comes from eth0 and is forwarded through vxl

Re: [PATCH v3 net 6/6] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0

2015-11-27 Thread Gregory CLEMENT
Hi Marcin, On ven., nov. 27 2015, Marcin Wojtas wrote: > The Ethernet controller found in the Armada 38x SoC's family support > TCP/IP checksumming with frame sizes larger than 1600 bytes, however > only on port 0. > > This commit enables it by setting 'tx-csum-limit' to 9800B in > 'ethernet@7

[PATCH] iwlwifi: fix compare_const_fl.cocci warnings

2015-11-27 Thread Julia Lawall
Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- This looks a bit nicer around the other way, in my opinion. calib.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH] net: rds: don't pretend to use cpu notifiers

2015-11-27 Thread Sebastian Andrzej Siewior
It looks like an attempt to use CPU notifier here which was never completed. Nobody tried to wire it up completely since 2k9. So I unwind this code and get rid of everything not required. Oh look! 19 lines were removed while code still does the same thing. Signed-off-by: Sebastian Andrzej Siewior

[PATCH v3 net 4/6] net: mvneta: fix error path for building skb

2015-11-27 Thread Marcin Wojtas
In the actual RX processing, there is same error path for both descriptor ring refilling and building skb fails. This is not correct, because after successful refill, the ring is already updated with newly allocated buffer. Then, in case of build_skb() fail, hitherto code left the original buffer u

[PATCH v3 net 1/6] net: mvneta: add configuration for MBUS windows access protection

2015-11-27 Thread Marcin Wojtas
This commit adds missing configuration of MBUS windows access protection in mvneta_conf_mbus_windows function - a dedicated variable for that purpose remained there unused since v3.8 initial mvneta support. Because of that the register contents were inherited from the bootloader. Signed-off-by: Ma

[PATCH v3 net 6/6] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0

2015-11-27 Thread Marcin Wojtas
The Ethernet controller found in the Armada 38x SoC's family support TCP/IP checksumming with frame sizes larger than 1600 bytes, however only on port 0. This commit enables it by setting 'tx-csum-limit' to 9800B in 'ethernet@7' node. Signed-off-by: Marcin Wojtas --- arch/arm/boot/dts/armad

[PATCH v3 net 5/6] net: mvneta: enable setting custom TX IP checksum limit

2015-11-27 Thread Marcin Wojtas
Since Armada 38x SoC can support IP checksum for jumbo frames only on a single port, it means that this feature should be enabled per-port, rather than for the whole SoC. This patch enables setting custom TX IP checksum limit by adding new optional property to the mvneta device tree node. If not u

[PATCH v3 net 2/6] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG

2015-11-27 Thread Marcin Wojtas
MVNETA_RXQ_HW_BUF_ALLOC bit which controls enabling hardware buffer allocation was mistakenly set as BIT(1). This commit fixes the assignment. Signed-off-by: Marcin Wojtas Reviewed-by: Gregory CLEMENT Fixes: c5aff18204da ("net: mvneta: driver for Marvell Armada 370/XP network unit") --- driver

[PATCH v3 net 3/6] net: mvneta: fix bit assignment for RX packet irq enable

2015-11-27 Thread Marcin Wojtas
A value originally defined in the driver was inappropriate. Even though the ingress was somehow working, writing MVNETA_RXQ_INTR_ENABLE_ALL_MASK to MVNETA_INTR_ENABLE didn't make any effect, because the bits [31:16] are reserved and read-only. This commit updates MVNETA_RXQ_INTR_ENABLE_ALL_MASK to

[PATCH v2 net 0/6] Marvell Armada XP/370/38X Neta fixes

2015-11-27 Thread Marcin Wojtas
Hi, I updated the mvneta fixes patchset with minor corrections suggested by Thomas Petazzoni. I will be greatful for a feedback. Best regards, Marcin Wojtas Changes from v2: * Style fixes in patch updating mbus protection * Remove redundant stable notifications except for patch 4/6 Changes fro

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-27 Thread Michael Heimpold
Hi, Am 27.11.2015 um 14:39 schrieb Lothar Waßmann: When ENET_OUT is being used as reference clock for an external PHY, the clock must not be disabled while the PHY is active. Otherwise the PHY may lose its internal state and require a reset to become functional again. A symptom for this bug is

gigaset: freeing an active object

2015-11-27 Thread Sasha Levin
Hi, Fuzzing with syzkaller on the latest -next kernel produced this error: [ 413.536749] WARNING: CPU: 6 PID: 25400 at lib/debugobjects.c:263 debug_print_object+0x1c4/0x1e0() [ 413.538111] ODEBUG: free active (active state 0) object type: timer_list hint: delayed_work_timer_fn+0x0/0x90 [ 413

[PATCH] net: fec: fix enet_out clock handling

2015-11-27 Thread Lothar Waßmann
When ENET_OUT is being used as reference clock for an external PHY, the clock must not be disabled while the PHY is active. Otherwise the PHY may lose its internal state and require a reset to become functional again. A symptom for this bug is a network interface that constantly toggles between UP

[patch net-next v2 4/6] mlxsw: core: Implement temperature hwmon interface

2015-11-27 Thread Jiri Pirko
From: Jiri Pirko ASIC provides access to temperature sensors. Implement their exposure to userspace using hwmon. Signed-off-by: Jiri Pirko --- v1->v2: - fixed hwmon compile error when it is not set reported by l...@intel.com --- drivers/net/ethernet/mellanox/mlxsw/Kconfig | 8 + drivers

[patch net-next v2 3/6] mlxsw: reg: Add definition of temperature management registers

2015-11-27 Thread Jiri Pirko
From: Jiri Pirko Add definition of MTCAP and MTMP registers which provide access to temperature sensors. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 111 ++ 1 file changed, 111 insertions(+) diff --git a/drivers/net/ethernet/mellanox/m

Re: Problem with "swinging" ethernet link on i.MX28 based device

2015-11-27 Thread Michael Heimpold
Hi Lothar, Am 27.11.2015 um 12:09 schrieb Lothar Waßmann: Hi, we at I2SE have developed an i.MX28 based embedded device, called Duckbill. Regarding ethernet, it is very similar to the FSL mx28evk, i.e. we use the same phy (SMSC LAN8720), we use RMII mode, clock is provided by iMX (not via ext

[patch net-next v2 6/6] mlxsw: core: Implement fan control using hwmon

2015-11-27 Thread Jiri Pirko
From: Jiri Pirko ASIC provides access to fans. Implement their exposure to userspace using hwmon. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c | 121 ++- 1 file changed, 120 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/me

[patch net-next v2 5/6] mlxsw: reg: Add definition of fan management registers

2015-11-27 Thread Jiri Pirko
From: Jiri Pirko Add definition of MFCR, MFSC and MFSM which provide possibility to control and monitor fans. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 133 ++ 1 file changed, 133 insertions(+) diff --git a/drivers/net/ethernet/mella

[patch net-next v2 0/6] mlxsw: driver update

2015-11-27 Thread Jiri Pirko
From: Jiri Pirko This patchset carries support for port identification, monitoring of ASIC temperature and board fans. Ido Schimmel (2): mlxsw: reg: Add Management LED Control register definition mlxsw: spectrum: Add support for port identification Jiri Pirko (4): mlxsw: reg: Add definiti

[patch net-next v2 2/6] mlxsw: spectrum: Add support for port identification

2015-11-27 Thread Jiri Pirko
From: Ido Schimmel Allow a user to flash the port's LED in order to identify it. This is achieved by setting the Management LED Control Register (MLCR). Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 24 1 fi

[patch net-next v2 1/6] mlxsw: reg: Add Management LED Control register definition

2015-11-27 Thread Jiri Pirko
From: Ido Schimmel Add the MLCR register, which controls physical port identification LEDs. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 46 +++ 1 file changed, 46 insertions(+) diff --git a/drivers/net/ethe

Re: [patch net-next 4/6] mlxsw: core: Implement temperature hwmon interface

2015-11-27 Thread Jiri Pirko
Fri, Nov 27, 2015 at 12:55:37PM CET, l...@intel.com wrote: >Hi Jiri, > >[auto build test ERROR on: net-next/master] >[also build test ERROR on: v4.4-rc2 next-20151127] > >url: >https://github.com/0day-ci/linux/commits/Jiri-Pirko/mlxsw-driver-update/20151126-190702 >conf

Re: [patch net-next 4/6] mlxsw: core: Implement temperature hwmon interface

2015-11-27 Thread kbuild test robot
Hi Jiri, [auto build test ERROR on: net-next/master] [also build test ERROR on: v4.4-rc2 next-20151127] url: https://github.com/0day-ci/linux/commits/Jiri-Pirko/mlxsw-driver-update/20151126-190702 config: x86_64-randconfig-s2-11271831 (attached as .config) reproduce: # save the

Re: Problem with "swinging" ethernet link on i.MX28 based device

2015-11-27 Thread Lothar Waßmann
Hi, > we at I2SE have developed an i.MX28 based embedded device, called Duckbill. > Regarding ethernet, it is very similar to the FSL mx28evk, i.e. we use the > same > phy (SMSC LAN8720), we use RMII mode, clock is provided by iMX (not via > external crystal), we have a GPIO to reset the phy and

[PATCH net-next] hv_netvsc: rework link status change handling

2015-11-27 Thread Vitaly Kuznetsov
There are several issues in hv_netvsc driver with regards to link status change handling: - RNDIS_STATUS_NETWORK_CHANGE results in calling userspace helper doing '/etc/init.d/network restart' and this is inappropriate and broken for many reasons. - link_watch infrastructure only sends one notif

dynamically set number of queues for 82598 devices in -stable

2015-11-27 Thread William Dauchy
Hello Jeff, I faced the problem described in commit 7e3f5c8: ixgbe: fix bounds checking in ixgbe_setup_tc for 82598 This patch resolves an issue where users were not able to dynamically set number of queues for 82598 via ethtool -L I backported it for my v4.1.x build but I was wondering if this

Problem with "swinging" ethernet link on i.MX28 based device

2015-11-27 Thread Michael Heimpold
Hi, we at I2SE have developed an i.MX28 based embedded device, called Duckbill. Regarding ethernet, it is very similar to the FSL mx28evk, i.e. we use the same phy (SMSC LAN8720), we use RMII mode, clock is provided by iMX (not via external crystal), we have a GPIO to reset the phy and an interru

Re: [net-next 07/15] ixgbe: Fix handling of NAPI budget when multiple queues are enabled per vector

2015-11-27 Thread William Dauchy
Hello Jeff, There is also the equivalent patch for ixgbevf http://patchwork.ozlabs.org/patch/539065/ On Mon, Nov 23, 2015 at 8:36 PM, Jeff Kirsher wrote: > From: Alexander Duyck > > This patch corrects an issue in which the polling routine would increase > the budget for Rx to at least 1 per q

Re: 4.3+: Atheros ethernet fails after resume from s2ram, due to order 4 allocation

2015-11-27 Thread Michal Hocko
On Thu 26-11-15 17:34:13, Pavel Machek wrote: > Hi! > > ...and dmesg tells us what is going on: > > [ 6961.550240] NetworkManager: page allocation failure: order:4, > mode:0x2080020 This is GFP_ATOMIC|___GFP_RECLAIMABLE high order request. So something that the caller should tollerate to fail.