Re: [PATCH V3 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-11-25 Thread Salil Mehta
On 11/22/2015 9:19 AM, Yuval Mintz wrote: +void hns_rcbv2_int_ctrl_hw(struct hnae_queue *q, u32 flag, u32 mask) +{ + u32 int_mask_en = !!mask; + + if (flag & RCB_INT_FLAG_TX) + dsaf_write_dev(q, RCB_RING_INTMSK_TXWL_REG, int_mask_en); + + if (flag & RCB_INT_FLAG_R

Re: [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

2015-11-25 Thread Salil Mehta
On 11/22/2015 9:30 AM, Yuval Mintz wrote: static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb) { ... + /* Set default RSS key and indrection table*/ + const u32 rss_key[HNS_PPEV2_RSS_KEY_NUM] = { + 0x6d5a56da, 0x255b0ec2, + 0x4167253d, 0x43a38fb0, +

[PATCH (net.git) 5/5] stmmac: fix oversized frame reception

2015-11-25 Thread Giuseppe Cavallaro
The receive skb buffers can be preallocated when the link is opened according to mtu size. While testing on a network environment with not standard MTU (e.g. 3000), a panic occurred if an incoming packet had a length greater than rx skb buffer size. This is because the HW is programmed to copy, fro

[PATCH (net.git) 4/5] stmmac: fix PHY reset during resume

2015-11-25 Thread Giuseppe Cavallaro
When stmmac_mdio_reset, was called from stmmac_resume, it was not resetting the PHY due to which MAC was not getting reset properly and hence ethernet interface not was resumed properly. The issue was currently only reproducible on stih301-b2204. Signed-off-by: Pankaj Dev Signed-off-by: Giuseppe

[PATCH (net.git) 3/5] stmmac: dwmac-sti: fix st,tx-retime-src check

2015-11-25 Thread Giuseppe Cavallaro
In case of the st,tx-retime-src is missing from device-tree (it's an optional field) the driver will invoke the strcasecmp to check which clock has been selected and this is a bug; the else condition is needed. In the dwmac_setup, the "rs" variable, passed to the strcasecmp, was not initialized an

[PATCH (net.git) 0/5] Spare stmmac fixes

2015-11-25 Thread Giuseppe Cavallaro
These are some fixes for the stmmac d.d. tested on STi platforms. They are for some part of the PM, STi glue and rx path when test Jumbo. Giuseppe Cavallaro (5): stmmac: fix a filter problem after resuming. stmmac: fix csr clock divisor for 300MHz stmmac: dwmac-sti: fix st,tx-retime-src chec

[PATCH (net.git) 2/5] stmmac: fix csr clock divisor for 300MHz

2015-11-25 Thread Giuseppe Cavallaro
This patch is to fix the csr clock in case of 300MHz is provided. Reported-by: Kent Borg Signed-off-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_m

[PATCH (net.git) 1/5] stmmac: fix a filter problem after resuming.

2015-11-25 Thread Giuseppe Cavallaro
When resume the HW is re-configured but some settings can be lost. For example, the MAC Address_X High/Low Registers used for VLAN tagging.. So, while resuming, the set_filter callback needs to be invoked to re-program perfect and hash-table registers. Signed-off-by: Giuseppe Cavallaro --- drive

[PATCH V5 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support HNS Driver

2015-11-25 Thread Salil Mehta
This patch adds the support of "TSO (TCP Segment Offload)" feature provided by the Hip06 ethernet hardware to the HNS ethernet driver. Enabling this feature would help offload the TCP Segmentation process to the Hip06 ethernet hardware. This eventually would help in saving precious cpu cycles. Si

[PATCH V5 net-next 0/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-11-25 Thread Salil Mehta
This PATCH V5 address the review comments by Yuval Mintz . This rework of comments are basically related to: 1) styling of the code, 2) RSS default Key initiailization related code 3) redundant code removal PATCH V4: This addresses the review comment provided by Sergei Shtylyov. The changel

[PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-11-25 Thread Salil Mehta
This patchset adds support of Hisilicon Hip06 SoC to the existing HNS ethernet driver. The changes in the driver are mainly due to changes in the DMA descriptor provided by the Hip06 ethernet hardware. These changes need to co-exist with already present Hip05 DMA descriptor and its operating funct

[PATCH V5 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

2015-11-25 Thread Salil Mehta
This patch adds the support of "RSS (Receive Side Scaling)" feature provided by the Hip06 ethernet hardware to the HNS ethernet driver. This feature helps in distributing the different flows (mapped as hash by hardware using Toeplitz Hash) to different Queues asssociated with the processor cores.

[PATCH V5 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS

2015-11-25 Thread Salil Mehta
From: Salil This patch adds the support of ethtool TSO option to support Hip06 SoC to HNS Signed-off-by: Salil Mehta Signed-off-by: lisheng --- PATCH V5: - No change over the previous patch PATCH V4: This fixes the comments given by Sergei Shtylyov over the PATCH V3: Link: https://lkml.org/l

[PATCH V5 net-next 5/5] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist"

2015-11-25 Thread Salil Mehta
This patch adds the initializzation code to disable the hardware vlan support for VLAN Tag stripping by default for now. Proper support of "hardware VLAN assitance" feature would soon come in the next coming patches. Signed-off-by: Salil Mehta --- PATCH V5: - Minor merge/reject change resolved t

Re: [ovs-dev] [PATCH net-next v3 2/8] netfilter: Factor out nf_ct_get_info().

2015-11-25 Thread Simon Horman
On Wed, Nov 25, 2015 at 04:08:15PM -0800, Jarno Rajahalme wrote: > Define a new inline function to map conntrack status to enum > ip_conntrack_info. This removes the need to otherwise duplicate this > code in a later patch ("openvswitch: Find existing conntrack entry > after upcall."). > > Signed

[PATCH v2] net: Generalise wq_has_sleeper helper

2015-11-25 Thread Herbert Xu
On Wed, Nov 25, 2015 at 11:37:29AM -0500, David Miller wrote: > > > Would be easier to refer to the comment that now adorns > > waitqueue_active(). > > Yeah, that might be a good idea. Herbert can you adjust this? Sure, here is an updated patch. Note that this patch is based on net-next where t

Re: [ovs-dev] [PATCH net-next v3 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2015-11-25 Thread Simon Horman
On Wed, Nov 25, 2015 at 04:08:14PM -0800, Jarno Rajahalme wrote: > Remove the definition of IP_CT_NEW_REPLY from the kernel as it does > not make sense. This allows the definition of IP_CT_NUMBER to be > simplified as well. > > Signed-off-by: Jarno Rajahalme I hate to be the bearer of bad news

Re: Increasing skb->mark size

2015-11-25 Thread Luuk Paulussen
On 11/25/2015 09:56 AM, Matt Bennett wrote: > On Tue, 2015-11-24 at 21:36 +0100, Florian Westphal wrote: >> Matt Bennett wrote: >>> I'm emailing this list for feedback on the feasibility of increasing >>> skb->mark or adding a new field for marking. Perhaps this extension >>> could be done under

Re: [PATCH net-next v3 8/8] openvswitch: Interface with NAT.

2015-11-25 Thread kbuild test robot
Hi Jarno, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jarno-Rajahalme/openvswitch-NAT-support/20151126-081504 config: x86_64-randconfig-s0-11260956 (attached as .config) reproduce: # save the attached .config to linux build tree mak

Re: severe regression in alx ethernet driver

2015-11-25 Thread David Miller
From: Francois Romieu Date: Wed, 25 Nov 2015 23:47:08 +0100 > Jarod Wilson : > [...] >> They do at least have a signed-off-by in the patches attached to the bug, >> so I'm working on touching up the descriptions and formatting, regression >> testing them on my laptop that has an alx-driven E2200

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-11-25 Thread Alexander Duyck
On Wed, Nov 25, 2015 at 7:15 PM, Dong, Eddie wrote: >> On Wed, Nov 25, 2015 at 12:21 AM, Lan Tianyu wrote: >> > On 2015年11月25日 13:30, Alexander Duyck wrote: >> >> No, what I am getting at is that you can't go around and modify the >> >> configuration space for every possible device out there. Th

Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 22:17 -0500, Aaron Conole wrote: > Probably that would call for a different more primitive version of this > API (sk_gfp_or_memalloc() as you suggest below). Then this could be > written in terms of that > > static inline sk_gfp_or_memalloc(const struct sock *sk, gfp_t gfp_m

Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-25 Thread Aaron Conole
Eric Dumazet writes: > On Wed, 2015-11-25 at 14:32 -0800, Eric Dumazet wrote: >> On Wed, 2015-11-25 at 17:08 -0500, Aaron Conole wrote: >> >> > > diff --git a/include/net/sock.h b/include/net/sock.h >> > > index 7f89e4ba18d1..ead514332ae8 100644 >> > > --- a/include/net/sock.h >> > > +++ b/includ

RE: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-11-25 Thread Dong, Eddie
> On Wed, Nov 25, 2015 at 12:21 AM, Lan Tianyu wrote: > > On 2015年11月25日 13:30, Alexander Duyck wrote: > >> No, what I am getting at is that you can't go around and modify the > >> configuration space for every possible device out there. This > >> solution won't scale. > > > > > > PCI config spac

Re: [PATCH net-next v3 8/8] openvswitch: Interface with NAT.

2015-11-25 Thread kbuild test robot
Hi Jarno, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jarno-Rajahalme/openvswitch-NAT-support/20151126-081504 config: x86_64-randconfig-n0-11260924 (attached as .config) reproduce: # save the attached .config to linux build tree mak

Re: linux-next: manual merge of the net-next tree with the net tree

2015-11-25 Thread Daniel Borkmann
On 11/26/2015 01:01 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in: kernel/bpf/syscall.c between commit: c9da161c6517 ("bpf: fix clearing on persistent program array maps") from the net tree and commit: f99bf205dab0 ("bpf: add sh

[PATCH net-next v3 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2015-11-25 Thread Jarno Rajahalme
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +--- net/openvswitch/conntrack.c

[PATCH net-next v3 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().

2015-11-25 Thread Jarno Rajahalme
Only a successful nf_conntrack_in() call can effect a connection state change, so if suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 9 ++--- 1 file changed

[PATCH net-next v3 8/8] openvswitch: Interface with NAT.

2015-11-25 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new (non-committed

[PATCH net-next v3 3/8] netfilter: Allow calling into nat helper without skb_dst.

2015-11-25 Thread Jarno Rajahalme
NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar Signed-of

[PATCH net-next v3 5/8] openvswitch: Find existing conntrack entry after upcall.

2015-11-25 Thread Jarno Rajahalme
Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace upcall. ovs_ct_find_exis

[PATCH net-next v3 6/8] openvswitch: Handle NF_REPEAT in conntrack action.

2015-11-25 Thread Jarno Rajahalme
Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/con

[PATCH net-next v3 7/8] openvswitch: Delay conntrack helper call for new connections.

2015-11-25 Thread Jarno Rajahalme
There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno Rajaha

[PATCH net-next v3 0/8] openvswitch: NAT support.

2015-11-25 Thread Jarno Rajahalme
This series adds NAT support to openvswitch kernel module. A few changes are needed to the netfilter code to facilitate this (patches 1-3/8). Patches 4-7 make the openvswitch kernel module ready for the patch 8 that adds the NAT support by calling into netfilter NAT code from the openvswitch conn

[PATCH net-next v3 2/8] netfilter: Factor out nf_ct_get_info().

2015-11-25 Thread Jarno Rajahalme
Define a new inline function to map conntrack status to enum ip_conntrack_info. This removes the need to otherwise duplicate this code in a later patch ("openvswitch: Find existing conntrack entry after upcall."). Signed-off-by: Jarno Rajahalme --- include/net/netfilter/nf_conntrack.h | 15

linux-next: manual merge of the net-next tree with the net tree

2015-11-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: kernel/bpf/syscall.c between commit: c9da161c6517 ("bpf: fix clearing on persistent program array maps") from the net tree and commit: f99bf205dab0 ("bpf: add show_fdinfo handler for maps") from the net-next tree.

Re: [Resend PATCH] RDS: fix race condition when sending a message on unbound socket

2015-11-25 Thread santosh shilimkar
On 11/25/2015 4:52 AM, Quentin Casasnovas wrote: On Wed, Nov 25, 2015 at 12:21:45PM +, David Laight wrote: From: Santosh Shilimkar Sent: 24 November 2015 22:13 ... Sasha's found a NULL pointer dereference in the RDS connection code when sending a message to an apparently unbound socket.

Re: use-after-free in sock_wake_async

2015-11-25 Thread Hannes Frederic Sowa
On Wed, Nov 25, 2015, at 23:43, Eric Dumazet wrote: > On Wed, 2015-11-25 at 23:32 +0100, Hannes Frederic Sowa wrote: > > On Wed, Nov 25, 2015, at 23:09, Eric Dumazet wrote: > > > On Wed, 2015-11-25 at 20:57 +, Rainer Weikusat wrote: > > > > > > > I do agree that keeping the ->sk_data_ready out

Re: severe regression in alx ethernet driver

2015-11-25 Thread Francois Romieu
Jarod Wilson : [...] > They do at least have a signed-off-by in the patches attached to the bug, > so I'm working on touching up the descriptions and formatting, regression > testing them on my laptop that has an alx-driven E2200 in it (which isn't > affected by this bug), and then I can ship them

Fwd: bridge-utils: wrong sysfs path odds

2015-11-25 Thread Santiago Garcia Mantinan
(Message resent due to list rejection) Hi! > Ask Debian maintainer to send his patches, I don't go patch hunting. > > > While looking what other distros do I came across this patch: > https://pkgs.fedoraproject.org/cgit/bridge-utils.git/tree/bridge-utils-1.5-check-error-returns-from-write-to-sysf

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 23:32 +0100, Hannes Frederic Sowa wrote: > On Wed, Nov 25, 2015, at 23:09, Eric Dumazet wrote: > > On Wed, 2015-11-25 at 20:57 +, Rainer Weikusat wrote: > > > > > I do agree that keeping the ->sk_data_ready outside of the lock will > > > very likely have performance advan

Re: bridge-utils: wrong sysfs path odds

2015-11-25 Thread Richard Weinberger
Am 25.11.2015 um 23:38 schrieb Florian Fainelli: > On 25/11/15 01:21, Richard Weinberger wrote: >> Am 25.11.2015 um 01:37 schrieb Stephen Hemminger: >>> On Wed, 25 Nov 2015 01:24:47 +0100 >>> Richard Weinberger wrote: >>> Am 25.11.2015 um 01:15 schrieb Richard Weinberger: > Hi! >

Re: bridge-utils: wrong sysfs path odds

2015-11-25 Thread Florian Fainelli
On 25/11/15 01:21, Richard Weinberger wrote: > Am 25.11.2015 um 01:37 schrieb Stephen Hemminger: >> On Wed, 25 Nov 2015 01:24:47 +0100 >> Richard Weinberger wrote: >> >>> Am 25.11.2015 um 01:15 schrieb Richard Weinberger: Hi! Today I was hunting down an issue where "brctl stp br0 of

Re: bridge-utils: wrong sysfs path odds

2015-11-25 Thread Richard Weinberger
Hi! Am 25.11.2015 um 23:30 schrieb Santiago Garcia Mantinan: > Hi! > >> Ask Debian maintainer to send his patches, I don't go patch hunting. > > > While looking what other distros do I came across this patch: > > https://pkgs.fedoraproject.org/cgit/bridge-utils.git/tree/bridge-utils-1.

Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 14:32 -0800, Eric Dumazet wrote: > On Wed, 2015-11-25 at 17:08 -0500, Aaron Conole wrote: > > > > diff --git a/include/net/sock.h b/include/net/sock.h > > > index 7f89e4ba18d1..ead514332ae8 100644 > > > --- a/include/net/sock.h > > > +++ b/include/net/sock.h > > > @@ -776,7 +

Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 17:08 -0500, Aaron Conole wrote: > > diff --git a/include/net/sock.h b/include/net/sock.h > > index 7f89e4ba18d1..ead514332ae8 100644 > > --- a/include/net/sock.h > > +++ b/include/net/sock.h > > @@ -776,7 +776,7 @@ static inline int sk_memalloc_socks(void) > > > > static

Re: use-after-free in sock_wake_async

2015-11-25 Thread Hannes Frederic Sowa
On Wed, Nov 25, 2015, at 23:09, Eric Dumazet wrote: > On Wed, 2015-11-25 at 20:57 +, Rainer Weikusat wrote: > > > I do agree that keeping the ->sk_data_ready outside of the lock will > > very likely have performance advantages. That's just something I > > wouldn't have undertaken because I'd b

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 20:57 +, Rainer Weikusat wrote: > I do agree that keeping the ->sk_data_ready outside of the lock will > very likely have performance advantages. That's just something I > wouldn't have undertaken because I'd be reluctant to make a fairly > complicated change to a lot of

Re: [PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-25 Thread Aaron Conole
Eric Dumazet writes: > From: Eric Dumazet > > If tcp_send_ack() can not allocate skb, we properly handle this > and setup a timer to try later. > > Use __GFP_NOWARN to avoid polluting syslog in the case host is > under memory pressure, so that pertinent messages are not lost under > a flood of us

[PATCH 2/2] Minor improvement for smsc95xx netusb driver performance.

2015-11-25 Thread Ameen
Reduce number of memcpy's by 1-2 improve transmit performance by 2-4%. or reduce CPU usage on a comparable value. Signed-off-by: Ameen Ali --- drivers/net/usb/smsc95xx.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/usb/smsc95xx.c

[PATCH net-next] tcp: suppress too verbose messages in tcp_send_ack()

2015-11-25 Thread Eric Dumazet
From: Eric Dumazet If tcp_send_ack() can not allocate skb, we properly handle this and setup a timer to try later. Use __GFP_NOWARN to avoid polluting syslog in the case host is under memory pressure, so that pertinent messages are not lost under a flood of useless information. sk_gfp_atomic()

Re: use-after-free in sock_wake_async

2015-11-25 Thread Rainer Weikusat
Eric Dumazet writes: > On Wed, 2015-11-25 at 11:50 -0800, Eric Dumazet wrote: > >> > other->sk_data_ready(other); >> > + unix_state_unlock(other); > > > Also, problem with such construct is that we wakeup a thread that will > block on the lock we hold. > > Beauty of s

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 11:50 -0800, Eric Dumazet wrote: > > other->sk_data_ready(other); > > + unix_state_unlock(other); Also, problem with such construct is that we wakeup a thread that will block on the lock we hold. Beauty of sk_data_ready() is to call it once we

[PATCH net] ipv4: igmp: Allow removing groups from a removed interface

2015-11-25 Thread Andrew Lunn
When a multicast group is joined on a socket, a struct ip_mc_socklist is appended to the sockets mc_list containing information about the joined group. If the interface is hot unplugged, this entry becomes stale. Prior to 52ad353a5344f "(igmp: fix the problem when mc leave group") it was possible

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 19:38 +, Rainer Weikusat wrote: > Eric Dumazet writes: > > On Wed, 2015-11-25 at 18:24 +, Rainer Weikusat wrote: > >> Eric Dumazet writes: > >> > On Wed, 2015-11-25 at 17:30 +, Rainer Weikusat wrote: > >> > > >> >> In case this is wrong, it obviously implies that

Re: use-after-free in sock_wake_async

2015-11-25 Thread Rainer Weikusat
Eric Dumazet writes: > On Wed, 2015-11-25 at 18:24 +, Rainer Weikusat wrote: >> Eric Dumazet writes: >> > On Wed, 2015-11-25 at 17:30 +, Rainer Weikusat wrote: >> > >> >> In case this is wrong, it obviously implies that sk_sleep(sk) must not >> >> be used anywhere as it accesses the same

Re: WARNING in tcp_recvmsg

2015-11-25 Thread Eric Dumazet
On Wed, Nov 25, 2015 at 8:36 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers WARNING in tcp_recvmsg: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > #include > #include > #include > #include > > int f

Re: [net-next v2 04/15] i40e: remove BUG_ON from feature string building

2015-11-25 Thread Joe Perches
On Wed, 2015-11-25 at 10:35 -0800, Jeff Kirsher wrote: > On Wed, 2015-11-25 at 21:26 +0300, Sergei Shtylyov wrote: > > On 11/25/2015 09:21 PM, Jeff Kirsher wrote: > > > > > From: Shannon Nelson > > > > > > There's really no reason to kill the kernel thread just because of a > > > little info str

Re: [net-next v2 00/15][pull request] Intel Wired LAN Driver Updates 2015-11-25

2015-11-25 Thread David Miller
From: Jeff Kirsher Date: Wed, 25 Nov 2015 10:21:04 -0800 > This series contains updates to fm10k, i40e and i40evf. ... > v2: Dropped patch "i40e: Properly cast type for arithmetic" patch > based on feedback from the community > > The following are changes since commit > 9458ceab49179b7fd2d

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 18:24 +, Rainer Weikusat wrote: > Eric Dumazet writes: > > On Wed, 2015-11-25 at 17:30 +, Rainer Weikusat wrote: > > > >> In case this is wrong, it obviously implies that sk_sleep(sk) must not > >> be used anywhere as it accesses the same struck sock, hence, when that

Re: [PATCH net] isdn: Partially revert debug format string usage clean up

2015-11-25 Thread Kees Cook
On Tue, Nov 24, 2015 at 10:47 PM, Christoph Biedl wrote: > Commit 35a4a57 ("isdn: clean up debug format string usage") introduced > a safeguard to avoid accidential format string interpolation of data > when calling debugl1 or HiSax_putstatus. This did however not take into > account VHiSax_putsta

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

2015-11-25 Thread Florian Fainelli
On 21/11/15 23:53, Marcin Wojtas wrote: > > 4. Buffer manager (BM) support with two preparatory commits. As it is a > separate block, common for all network ports, a new driver is introduced, > which configures it and exposes API to the main network driver. It is > throughly described in binding d

Re: [PATCH 04/13] net: mvneta: enable suspend/resume support

2015-11-25 Thread Gregory CLEMENT
Hi Marcin, On dim., nov. 22 2015, Marcin Wojtas wrote: > This commit introduces suspend/resume routines used for both in 'standby' > and 'mem' modes. For the latter, in which registers' contents are lost, > following steps are performed: > * in suspend - update port statistics and, if interfac

Re: [net-next v2 04/15] i40e: remove BUG_ON from feature string building

2015-11-25 Thread Jeff Kirsher
On Wed, 2015-11-25 at 21:26 +0300, Sergei Shtylyov wrote: > On 11/25/2015 09:21 PM, Jeff Kirsher wrote: > > > From: Shannon Nelson > > > > There's really no reason to kill the kernel thread just because of > a > > little info string. This reworks the code to use snprintf's > limiting to > > assur

Re: [net-next v2 04/15] i40e: remove BUG_ON from feature string building

2015-11-25 Thread Sergei Shtylyov
Hello. On 11/25/2015 09:21 PM, Jeff Kirsher wrote: From: Shannon Nelson There's really no reason to kill the kernel thread just because of a little info string. This reworks the code to use snprintf's limiting to assure that the string is never too long, and WARN_ON to still put out a warning

Re: [PATCH 03/13] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG

2015-11-25 Thread Gregory CLEMENT
Hi Marcin, On dim., nov. 22 2015, Marcin Wojtas wrote: > MVNETA_RXQ_HW_BUF_ALLOC bit which controls enabling hardware buffer > allocation was mistakenly set as BIT(1). This commit fixes the > assignment. I confirm it from the datasheet I got: Reviewed-by: Gregory CLEMENT Thanks, Gregory

Re: use-after-free in sock_wake_async

2015-11-25 Thread Rainer Weikusat
Eric Dumazet writes: > On Wed, 2015-11-25 at 17:30 +, Rainer Weikusat wrote: > >> In case this is wrong, it obviously implies that sk_sleep(sk) must not >> be used anywhere as it accesses the same struck sock, hence, when that >> can "suddenly" disappear despite locks are used in the way indic

[net-next v2 07/15] i40e/i40evf: Add a stat to track how many times we have to do a force WB

2015-11-25 Thread Jeff Kirsher
From: Anjali Singhai Jain When in NAPI with interrupts disabled, the HW needs to be forced to do a write back on TX if the number of descriptors pending are less than a cache line. This stat helps keep track of how many times we get into this situation. Change-ID: I76c1bcc7ebccd6bffcc5aa33bfe05

[net-next v2 04/15] i40e: remove BUG_ON from feature string building

2015-11-25 Thread Jeff Kirsher
From: Shannon Nelson There's really no reason to kill the kernel thread just because of a little info string. This reworks the code to use snprintf's limiting to assure that the string is never too long, and WARN_ON to still put out a warning that we might want to look at the feature list length.

[net-next v2 06/15] i40e: Workaround fix for mss < 256 issue

2015-11-25 Thread Jeff Kirsher
From: Anjali Singhai Jain HW/NVM sets a limit of no less than 256 bytes for MSS. Stack can send as low as 76 bytes MSS. This patch lowers the HW limit to 64 bytes to avoid MDDs from firing and causing a reset when the MSS is lower than 256. Change-ID: I36b500a6bb227d283c3e321a7718e0672b11fab0 Si

[net-next v2 09/15] i40e/i40evf: Add comment to #endif

2015-11-25 Thread Jeff Kirsher
From: Helin Zhang Add a comment to the #endif to more easily match it with its #if. Change-ID: I47eb0a60a17dc6d2f01a930e45006d2dc82e044f Signed-off-by: Helin Zhang Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 2 +- drivers/net

[net-next v2 08/15] i40e: Move the saving of old link info from handle_link_event to link_event

2015-11-25 Thread Jeff Kirsher
From: Catherine Sullivan The watchdog only calls link_event not handle_link_event which means that we need to save the old information in link_event. Previously when polling we were comparing current data to the old data saved the last time we actually received a link event. This means that the

[net-next v2 15/15] i40e: Bump version to 1.4.2

2015-11-25 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: I2d1ce93b2ce74e4eef2394c932aef52cba99713f Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[net-next v2 11/15] i40evf: handle many MAC filters correctly

2015-11-25 Thread Jeff Kirsher
From: Mitch Williams When a lot (many hundreds) of MAC or VLAN filters are added at one time, we can overflow the Admin Queue buffer size with all the requests. Unfortunately, the driver would then calculate the message size incorrectly, causing it to be rejected by the PF. Furthermore, there was

[net-next v2 12/15] i40e: return the number of enabled queues for ETHTOOL_GRXRINGS

2015-11-25 Thread Jeff Kirsher
From: Helin Zhang This patch fixes a problem where using ethtool rxnfc command could let RX flow hash be set on disabled queues. This patch fixes the problem by returning the number of enabled queues before setting rxnfc. Change-ID: Idbac86b0b47ddacc8deee7cd257e41de01cbe5c0 Signed-off-by: Helin

[net-next v2 14/15] i40e: create a generic configure rss function

2015-11-25 Thread Jeff Kirsher
From: Helin Zhang This patch renames the old pf-specific function in order to clarify its scope. This patch also creates a more generic configure RSS function with the old name. This patch also creates a new more generic function to get RSS configuration, using the appropriate method. Change-ID

[net-next v2 10/15] i40e/i40evf: clean up error messages

2015-11-25 Thread Jeff Kirsher
From: Mitch Williams Clean up and enhance error messages related to VF MAC/VLAN filters. Indicate which VF is having issues, and if possible indicate the MAC address or VLAN involved. Also, when an error is returned from the PF driver, print useful information about what went wrong, for the most

[net-next v2 13/15] i40e: rework the functions to configure RSS with similar parameters

2015-11-25 Thread Jeff Kirsher
From: Helin Zhang Adjust the RSS configure functions so that there is a generic way to hook to ethtool hooks. Change-ID: If446e34fcfaf1bc3320d9d319829a095b5976e67 Signed-off-by: Helin Zhang Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e.h

[net-next v2 05/15] i40e: remove BUG_ON from FCoE setup

2015-11-25 Thread Jeff Kirsher
From: Shannon Nelson There's no need to kill the kernel thread here. If this condition was true, the probe() would have died long before we got here. In any case, we'll get the same result when this code tries to use the VSI pointer being checked. Prompted by a recent Linus diatribe. Change-ID:

[net-next v2 00/15][pull request] Intel Wired LAN Driver Updates 2015-11-25

2015-11-25 Thread Jeff Kirsher
This series contains updates to fm10k, i40e and i40evf. Alex Duyck fixes up fm10k to use napi_schedule_irqoff() instead of napi_schedule() since the function it is called from runs from hard interrupt context or with interrupts already disabled in netpoll. Shannon cleans up i40e and i40evf unused

[net-next v2 01/15] fm10k: use napi_schedule_irqoff()

2015-11-25 Thread Jeff Kirsher
From: Alexander Duyck The fm10k_msix_clean_rings function runs from hard interrupt context or with interrupts already disabled in netpoll. It can use napi_schedule_irqoff() instead of napi_schedule() Signed-off-by: Alexander Duyck Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- d

[net-next v2 03/15] i40e: Change BUG_ON to WARN_ON in service event complete

2015-11-25 Thread Jeff Kirsher
From: Shannon Nelson There's no need to kill the thread and eventually the kernel in this case. In fact, the remainder of the code won't hurt anything anyway, so just complain that we're here and move along. Prompted by a recent Linus diatribe. Change-ID: Iec020d8bcfedffc1cd2553cc6905fd915bb3e

[net-next v2 02/15] i40e/i40evf: remove unused tunnel parameter

2015-11-25 Thread Jeff Kirsher
From: Shannon Nelson Code was moved into a separate function some time ago. Change-ID: Icabbe71ce05cf5d716d3e1152cdd9cd41d11bcb5 Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 11 --- drivers/net/

Re: [PATCH 01/13] net: mvneta: add configuration for MBUS windows access protection

2015-11-25 Thread Gregory CLEMENT
Hi Marcin, On dim., nov. 22 2015, Marcin Wojtas wrote: > This commit adds missing configuration of MBUS windows access protection > in mvneta_conf_mbus_windows function - a dedicated variable for that > purpose remained there unused since v3.8 initial mvneta support. Because > of that the regi

Re: [RFCv2 bluetooth-next 2/3] ipv6: add ipv6_addr_prefix_cpy

2015-11-25 Thread Alexander Aring
On Wed, Nov 25, 2015 at 05:42:52PM +0100, Stefan Schmidt wrote: > Hello. > > On 17/11/15 23:33, Alexander Aring wrote: > >This patch adds a static inline function ipv6_addr_prefix_cpy which > >copies a ipv6 address prefix(argument pfx) into the ipv6 address prefix. > >The prefix len is given by pl

Re: [PATCH net-next] MAINTAINERS: PHY: Change maintainer to reviewer

2015-11-25 Thread Florian Fainelli
On 25/11/15 08:36, David Miller wrote: > From: Joe Perches > Date: Tue, 24 Nov 2015 17:04:11 -0800 > >> On Tue, 2015-11-24 at 15:29 -0800, Florian Fainelli wrote: >>> Now that there is a reviewer role, add myself as reviewer since the PHY >>> library code is maintained via the networking tree. >>

Re: [RFCv2 bluetooth-next 3/3] 6lowpan: iphc: add support for stateful compression

2015-11-25 Thread Alexander Aring
Hi, On Wed, Nov 25, 2015 at 06:12:25PM +0100, Stefan Schmidt wrote: > Helllo. > > On 17/11/15 23:33, Alexander Aring wrote: > >This patch introduce support for IPHC stateful address compression. It > >will offer three debugfs per interface entries, which are: > > > > - dci_table: destination con

Re: [RFCv2 bluetooth-next 1/3] 6lowpan: add debugfs support

2015-11-25 Thread Alexander Aring
Hi, On Wed, Nov 25, 2015 at 05:42:32PM +0100, Stefan Schmidt wrote: > Hello. > > On 17/11/15 23:33, Alexander Aring wrote: > >This patch will introduce a 6lowpan entry into the debugfs if enabled. > >Inside this 6lowpan directory we create a subdirectories of all 6lowpan > >interfaces to offer a

[PATCH] packet.7: Indicate CAP_NET_BIND_SERVICE capability is required for binding packet sockets

2015-11-25 Thread Stewart Brodie
Adds a note to packet.7 that the calling process must have the CAP_NET_BIND_SERVICE capability in order to call bind on packet sockets. The linux/capability.h header file comments for CAP_NET_BIND_SERVICE do not document this requirement either. I did take a brief look in the kernel source code

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 17:30 +, Rainer Weikusat wrote: > In case this is wrong, it obviously implies that sk_sleep(sk) must not > be used anywhere as it accesses the same struck sock, hence, when that > can "suddenly" disappear despite locks are used in the way indicated > above, there is now s

[PATCH v2 1/4] staging: rtl8712: Remove casts between void * and type *

2015-11-25 Thread Mauro Dreissig
This removes unnecessary explicit pointer casts in rtl871x_ioctl_rtl.c. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 45 ++--- 1 file changed, 15 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_rtl.c b

[PATCH v2 4/4] staging: rtl8712: Rename local variable

2015-11-25 Thread Mauro Dreissig
Renames all instances of struct oid_par_priv to oid in rtl871x_ioctl_rtl.c and rtl871x_ioctl_rtl.h, making the code cleaner. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 292 +--- drivers/staging/rtl8712/rtl871x_ioctl_rtl.h | 123 ---

[PATCH v2 3/4] staging: rtl8712: Make error handling check for failure

2015-11-25 Thread Mauro Dreissig
Make all error handling paths check for failure instead of success in rtl871x_ioctl_rtl.c, reducing indentation and avoiding else statements. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 239 +++- 1 file changed, 124 insertions(+), 115 d

[PATCH v2 2/4] staging: rtl8712: Rename local variable

2015-11-25 Thread Mauro Dreissig
Renames all instances of struct _adapter to adapter in rtl871x_ioctl_rtl.c, avoiding camel case. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 86 ++--- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/staging/rtl87

[PATCH v2 0/4] Cleanups for rtl871x_ioctl_rtl

2015-11-25 Thread Mauro Dreissig
This applies some janitorial work to rtl8712 driver. Mauro Dreissig (4): staging: rtl8712: Remove casts between void * and type * staging: rtl8712: Rename local variable staging: rtl8712: Make error handling check for failure staging: rtl8712: Rename local variable drivers/staging/rtl871

Re: use-after-free in sock_wake_async

2015-11-25 Thread Rainer Weikusat
Eric Dumazet writes: > On Wed, 2015-11-25 at 16:43 +, Rainer Weikusat wrote: >> Eric Dumazet writes: >> > On Tue, Nov 24, 2015 at 5:10 PM, Rainer Weikusat >> > wrote: >> >> [...] >> >> >> It's also easy to verify: Swap the unix_state_lock and >> >> other->sk_data_ready and see if the issue

Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver

2015-11-25 Thread Alexander Duyck
On Wed, Nov 25, 2015 at 8:39 AM, Michael S. Tsirkin wrote: > On Wed, Nov 25, 2015 at 08:24:38AM -0800, Alexander Duyck wrote: >> >> Also, assuming you just want to do ifdown/ifup for some reason, it's >> >> easy enough to do using a guest agent, in a completely generic way. >> >> >> > >> > Just if

TUN interfaces loopback

2015-11-25 Thread Radu Rendec
Disclaimer: I know this is a *development* list, but I feel the answer lies deep down in the ipv4 routing code, so it's more likely that I find help here. That being said, I have two TUN interfaces that are "cross-connected" in user space (i.e. whatever is read on the socket corresponding to eithe

Re: use-after-free in sock_wake_async

2015-11-25 Thread Eric Dumazet
On Wed, 2015-11-25 at 16:43 +, Rainer Weikusat wrote: > Eric Dumazet writes: > > On Tue, Nov 24, 2015 at 5:10 PM, Rainer Weikusat > > wrote: > > [...] > > >> It's also easy to verify: Swap the unix_state_lock and > >> other->sk_data_ready and see if the issue still occurs. Right now (this >

Re: [net-next 06/16] i40e: Properly cast type for arithmetic

2015-11-25 Thread Rustad, Mark D
Joe Perches wrote: > On Wed, 2015-11-25 at 02:46 -0800, Jeff Kirsher wrote: >> On Tue, 2015-11-24 at 16:43 -0800, Joe Perches wrote: >>> On Tue, 2015-11-24 at 16:04 -0800, Jeff Kirsher wrote: From: Helin Zhang Pointer of type void * shouldn't be used in arithmetic, which may

  1   2   >