[PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-11-14 Thread Dave Young
cfg80211 module prints a lot of messages like below. Actually printing once is acceptable but sometimes it will print again and again, it looks very annoying. It is better to change these detail messages to debugging only. cfg80211: World regulatory domain updated: cfg80211: DFS Master region: un

Re: [net] net: fix feature changes on devices without ndo_set_features

2015-11-14 Thread Dave Young
On 11/13/15 at 02:54pm, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > When __netdev_update_features() was updated to ensure some features are > disabled on new lower devices, an error was introduced for devices which > don't have the ndo_set_features() method set. Before we'll just s

Re: net-ipv6: Delete unnecessary checks before the function call "kfree_skb"

2015-11-14 Thread SF Markus Elfring
> While if the test is done in kfree_skb(), the branch predictor of the > cpu wont be able to predict things. > > By feeding too many NULL pointers to kfree_skb(), we slow down it. Would it make sense to annotate checks before such function calls as "UNLIKELY"? Regards, Markus -- To unsubscribe

Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-14 Thread John Fastabend
On 15-11-14 01:39 AM, Jiri Pirko wrote: > Thu, Nov 12, 2015 at 05:02:18PM CET, pjonn...@broadcom.com wrote: >> Packet forwarding to/from bond interfaces is done in software. >> >> This patch enables certain platforms to bridge traffic to/from >> bond interfaces in hardware. Notifications are sent

Hit regression with TCP_TW REUSE/RECYCLE

2015-11-14 Thread Ethan Zhao
Hi, When we tested network with following case, found there is regression with stable 4.1 kernel, connect() returns EADDRNOTAVAIL, while a pretty old kernel 3.8 doesn't. anybody knows about this issue and if it was fixed later ? (I am looking for devices and will do a test with the last stable

Re: [PATCH] net-ipv6: Delete unnecessary checks before the function call "kfree_skb"

2015-11-14 Thread Eric Dumazet
On Sat, 2015-11-14 at 20:05 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Nov 2015 19:55:00 +0100 > > The kfree_skb() function tests whether its argument is NULL and then > returns immediately. Thus the test around the calls is not needed. > > This issue was detected by

Re: [PATCH net] tcp: ensure proper barriers in lockless contexts

2015-11-14 Thread Herbert Xu
On Sat, Nov 14, 2015 at 07:21:41PM -0800, Eric Dumazet wrote: > > This patch makes sure sk_ack_backlog is written before sk_state is set > to TCP_LISTEN, otherwise one could see a '0' listener backlog. > > We had a spurious kernel log for a similar issue that was solved in > commit f985c65c908f6b2

Re: [PATCH net] tcp: ensure proper barriers in lockless contexts

2015-11-14 Thread Eric Dumazet
On Sun, 2015-11-15 at 09:20 +0800, Herbert Xu wrote: > Eric Dumazet wrote: > > From: Eric Dumazet > > > > Some functions access TCP sockets without holding a lock and > > might output non consistent data, depending on compiler and or > > architecture. > > > > tcp_diag_get_info(), tcp_get_info()

Re: [PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-14 Thread Andy Shevchenko
On Sun, Nov 15, 2015 at 12:05 AM, Ondrej Zary wrote: > Add support for IP1000A chips to dl2k driver. > IP1000A chip looks like a TC9020 with integrated PHY. > > This allows IP1000A chips to work reliably because the ipg driver is > buggy - it loses packets under load and then completely stops > tr

Re: [PATCH net] tcp: ensure proper barriers in lockless contexts

2015-11-14 Thread Herbert Xu
Eric Dumazet wrote: > From: Eric Dumazet > > Some functions access TCP sockets without holding a lock and > might output non consistent data, depending on compiler and or > architecture. > > tcp_diag_get_info(), tcp_get_info(), tcp_poll(), get_tcp4_sock() ... For the information gathering ones

Re: [PATCH] Bluetooth-cmtp: Delete an unnecessary check before the function call "kfree_skb"

2015-11-14 Thread Marcel Holtmann
Hi Markus, > The kfree_skb() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > net/bluetooth/cmtp/core.c | 3 +-- > 1 fil

Re: [PATCH] mac802154: Delete an unnecessary check before the function call "kfree_skb"

2015-11-14 Thread Marcel Holtmann
Hi Markus, > The kfree_skb() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > net/mac802154/rx.c | 3 +-- > 1 file chang

Working an extra job.

2015-11-14 Thread Mystery Shopper
-- To whom it may concern: I am writing to both Unemployed and employed, that if you are interest in working an extra job, non-stressful work online as our mystery shopper should not hesitate to contact me Via This E-mail ( shopfstest0...@gmail.com ) for further information. Sincerely yours

[PATCH 2/2] ipg: Remove ipg driver

2015-11-14 Thread Ondrej Zary
Now that IP1000A chips are supported by dl2k driver, the buggy ipg driver can be removed. The ipg driver loses packets under load and then completely stops transmitting data. Signed-off-by: Ondrej Zary --- MAINTAINERS |7 - drivers/net/ethernet/Kconfig |

[PATCH 1/2] dl2k: Add support for IP1000A-based cards

2015-11-14 Thread Ondrej Zary
Add support for IP1000A chips to dl2k driver. IP1000A chip looks like a TC9020 with integrated PHY. This allows IP1000A chips to work reliably because the ipg driver is buggy - it loses packets under load and then completely stops transmitting data. Tested with Asus NX1101 v2.0 at 10, 100 and 100

[PATCH] NFC-nci: Delete unnecessary checks before the function call "kfree_skb"

2015-11-14 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Nov 2015 22:42:48 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/nf

[PATCH] net-hsr: Delete unnecessary checks before the function call "kfree_skb"

2015-11-14 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Nov 2015 22:23:48 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/hs

[PATCH] Bluetooth-cmtp: Delete an unnecessary check before the function call "kfree_skb"

2015-11-14 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Nov 2015 22:00:27 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/blu

[PATCH] mac802154: Delete an unnecessary check before the function call "kfree_skb"

2015-11-14 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Nov 2015 20:22:41 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/mac

[PATCH] net-ipv6: Delete unnecessary checks before the function call "kfree_skb"

2015-11-14 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Nov 2015 19:55:00 +0100 The kfree_skb() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/ip

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

2015-11-14 Thread Ben Hutchings
On Thu, 2015-10-15 at 14:25 +0200, Sabrina Dubroca wrote: > Without this length argument, we can read past the end of the iovec > in > memcpy_toiovec because we have no way of knowing the total length of > the > iovec's buffers. > > This is needed for stable kernels where 89c22d8c3b27 ("net: Fix s

Re: [PATCH -stable] multiple backports requested

2015-11-14 Thread David Miller
From: "Charles (Chas) Williams" <3ch...@gmail.com> Date: Sat, 14 Nov 2015 06:34:15 -0500 > On Fri, 2015-11-13 at 16:10 -0500, David Miller wrote: >> From: "Charles (Chas) Williams" <3ch...@gmail.com> >> Date: Fri, 13 Nov 2015 15:13:11 -0500 >> >> > Dave, could you please add the following backpor

[PATCH] net: dsa: Delete an unnecessary check before the function call "put_device"

2015-11-14 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 14 Nov 2015 17:58:00 +0100 The put_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/ds

[PATCH] brcmfmac: constify brcmf_bus_ops structures

2015-11-14 Thread Julia Lawall
The brcmf_bus_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/wireless/brcm80211/brcmfmac/bus.h |2 +- drivers/net/wireless/brcm80211/brcmfmac/pcie.c |2 +- drivers/net/wireless/brcm80211/brcmfm

Re: [PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol calls by jump-label

2015-11-14 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:24PM -0500, Johannes Weiner wrote: > Move the jump-label from sock_update_memcg() and sock_release_memcg() > to the callsite, and so eliminate those function calls when socket > accounting is not enabled. I don't believe this patch's necessary, because these functions

Re: [PATCH 03/14] net: tcp_memcontrol: properly detect ancestor socket pressure

2015-11-14 Thread Johannes Weiner
On Sat, Nov 14, 2015 at 03:45:52PM +0300, Vladimir Davydov wrote: > On Thu, Nov 12, 2015 at 06:41:22PM -0500, Johannes Weiner wrote: > > When charging socket memory, the code currently checks only the local > > page counter for excess to determine whether the memcg is under socket > > pressure. But

[PATCH v2 net] raw: increment correct SNMP counters for ICMP messages

2015-11-14 Thread Ben Cartwright-Cox
Sending ICMP packets with raw sockets ends up in the SNMP counters logging the type as the first byte of the IPv4 header rather than the ICMP header. This is fixed by adding the IP Header Length to the casting into a icmphdr struct. Signed-off-by: Ben Cartwright-Cox Acked-by: Eric Dumazet --- n

Re: [PATCH 02/14] mm: vmscan: simplify memcg vs. global shrinker invocation

2015-11-14 Thread Johannes Weiner
On Sat, Nov 14, 2015 at 03:36:50PM +0300, Vladimir Davydov wrote: > On Thu, Nov 12, 2015 at 06:41:21PM -0500, Johannes Weiner wrote: > > @@ -2432,20 +2447,6 @@ static bool shrink_zone(struct zone *zone, struct > > scan_control *sc, > > } > > } while ((memcg = mem_cg

Re: [PATCH 10/14] mm: memcontrol: generalize the socket accounting jump label

2015-11-14 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:29PM -0500, Johannes Weiner wrote: > The unified hierarchy memory controller is going to use this jump > label as well to control the networking callbacks. Move it to the > memory controller code and give it a more generic name. > > Signed-off-by: Johannes Weiner Re

Re: [PATCH 11/14] mm: memcontrol: do not account memory+swap on unified hierarchy

2015-11-14 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:30PM -0500, Johannes Weiner wrote: > The unified hierarchy memory controller doesn't expose the memory+swap > counter to userspace, but its accounting is hardcoded in all charge > paths right now, including the per-cpu charge cache ("the stock"). > > To avoid adding y

Re: [PATCH net] ipvs: use skb_to_full_sk() helper

2015-11-14 Thread Simon Horman
[Attn Dave] [Cc Pablo] On Sat, Nov 14, 2015 at 01:37:46PM +0200, Julian Anastasov wrote: > > Hello, > > On Thu, 12 Nov 2015, Eric Dumazet wrote: > > > From: Eric Dumazet > > > > SYNACK packets might be attached to request sockets. > > > > Use skb_to_full_sk() helper to avoid illegal ac

Re: [PATCH 03/14] net: tcp_memcontrol: properly detect ancestor socket pressure

2015-11-14 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:22PM -0500, Johannes Weiner wrote: > When charging socket memory, the code currently checks only the local > page counter for excess to determine whether the memcg is under socket > pressure. But even if the local counter is fine, one of the ancestors > could have brea

Re: [PATCH 02/14] mm: vmscan: simplify memcg vs. global shrinker invocation

2015-11-14 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:21PM -0500, Johannes Weiner wrote: ... > diff --git a/mm/vmscan.c b/mm/vmscan.c > index a4507ec..e4f5b3c 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -411,6 +411,10 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid, > struct shrinker *shrinker; >

Re: [PATCH 01/14] mm: memcontrol: export root_mem_cgroup

2015-11-14 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:20PM -0500, Johannes Weiner wrote: > A later patch will need this symbol in files other than memcontrol.c, > so export it now and replace mem_cgroup_root_css at the same time. > > Signed-off-by: Johannes Weiner > Acked-by: Michal Hocko Reviewed-by: Vladimir Davydov

Re: [PATCH net] ipvs: use skb_to_full_sk() helper

2015-11-14 Thread Julian Anastasov
Hello, On Thu, 12 Nov 2015, Eric Dumazet wrote: > From: Eric Dumazet > > SYNACK packets might be attached to request sockets. > > Use skb_to_full_sk() helper to avoid illegal accesses to > inet_sk(skb->sk) > > Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets inste

Re: [PATCH -stable] multiple backports requested

2015-11-14 Thread Charles (Chas) Williams
On Fri, 2015-11-13 at 16:10 -0500, David Miller wrote: > From: "Charles (Chas) Williams" <3ch...@gmail.com> > Date: Fri, 13 Nov 2015 15:13:11 -0500 > > > Dave, could you please add the following backports? > > > > For the 3.14.y stable queue: > > I am no longer handling 3.14.y -stable submission

[PATCH 1/9] net: cavium: liquidio: constify pci_error_handlers structures

2015-11-14 Thread Julia Lawall
This pci_error_handlers structure is never modified, like all the other pci_error_handlers structures, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- There are no dependencies between these patches. drivers/net/ethernet/cavium/liquidio/lio_main.c |

[PATCH 0/9] constify pci_error_handlers structures

2015-11-14 Thread Julia Lawall
Constify never-modified pci_error_handlers structures. --- drivers/crypto/qat/qat_common/adf_aer.c |2 +- drivers/misc/genwqe/card_base.c |2 +- drivers/net/ethernet/cavium/liquidio/lio_main.c |2 +- drivers/net/ethernet/sfc/efx.c |2 +- d

[PATCH 5/9] sfc: constify pci_error_handlers structures

2015-11-14 Thread Julia Lawall
This pci_error_handlers structure is never modified, like all the other pci_error_handlers structures, so declare it as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- There are no dependencies between these patches. drivers/net/ethernet/sfc/efx.c |2 +- 1 file ch

[no subject]

2015-11-14 Thread ESTHER LABOSO
-- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Crash in skb_segment / KVM GSO GRE IPV6

2015-11-14 Thread Florian Lohoff
Hi, we experienced a reproducible crash on a KVM/qemu Host running Kernel 4.3.0 in skb_segment. (Setup is kvm guest, openvswitch 1.9 up to 2.something, host on 4.3.0). User in the guest kvm with virtio reportedly tried to set up an v4 GRE tunnel with IPv6 Addresses and as soon as he started a si

Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-14 Thread Jiri Pirko
Thu, Nov 12, 2015 at 05:02:18PM CET, pjonn...@broadcom.com wrote: >Packet forwarding to/from bond interfaces is done in software. > >This patch enables certain platforms to bridge traffic to/from >bond interfaces in hardware. Notifications are sent out when >the "active" slave set for a bond inte

Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-14 Thread Jiri Pirko
Thu, Nov 12, 2015 at 06:08:01PM CET, and...@lunn.ch wrote: >On Thu, Nov 12, 2015 at 04:02:18PM +, Premkumar Jonnala wrote: >> Packet forwarding to/from bond interfaces is done in software. >> >> This patch enables certain platforms to bridge traffic to/from >> bond interfaces in hardware. Not