Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-11-13 Thread Joe Stringer
On 13 November 2015 at 06:46, Or Gerlitz wrote: > On Fri, Nov 13, 2015 at 10:14 AM, Joe Stringer wrote: > >> I don't follow the logic. You observed one flow which matched on >> TTL=64, therefore all vxlan packets terminated at OVS have TTL=64? > >> If OVS received packets with different TTLs, the

Re: eth0: set_features() failed (-1); wanted 0x0000000000004000, left 0x0000000000004800

2015-11-13 Thread Arthur Marsh
Arthur Marsh wrote on 14/11/15 13:46: Hi, I'm not sure if this is an actual error or just an informational message but on this pc (with a single-core AMD Athlon(tm) 64 Processor 3200+) I've been getting the following: Nov 13 18:16:12 localhost kernel: [0.938025] via-rhine :00:12.0 eth

Test. Please ignore

2015-11-13 Thread team
Test message. Please ignore. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 2/2] arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS

2015-11-13 Thread Z Lim
Yang, I noticed another thing... On Fri, Nov 13, 2015 at 10:09 AM, Yang Shi wrote: > Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP > in prologue in order to get the correct stack backtrace. > > However, ARM64 JIT used FP (x29) as eBPF fp register, FP is subjected to > ch

[PATCH net] bpf, arm: start flushing icache range from header

2015-11-13 Thread Daniel Borkmann
During review I noticed that the icache range we're flushing should start at header already and not at ctx.image. Reason is that after 55309dd3d4cd ("net: bpf: arm: address randomize and write protect JIT code"), we also want to make sure to flush the random-sized trap in front of the start of the

Re: [PATCH net] ravb: Fix int mask value overwritten issue

2015-11-13 Thread Simon Horman
On Fri, Nov 13, 2015 at 11:45:28AM +0100, Geert Uytterhoeven wrote: > Hi Kaneko-san, > > On Fri, Nov 13, 2015 at 11:24 AM, Yoshihiro Kaneko > wrote: > > From: Masaru Nagai > > > > When RX/TX interrupt for Network Control queue and Best Effort queue > > is issued at the same time, the interrupt m

[PATCH net-next] Driver: Vmxnet3: Fix use of mfTableLen for big endian architectures

2015-11-13 Thread Shrikrishna Khare
Signed-off-by: Shrikrishna Khare Reported-by: Masao Uebayashi Signed-off-by: Bhavesh Davda --- drivers/net/vmxnet3/vmxnet3_drv.c | 7 --- drivers/net/vmxnet3/vmxnet3_int.h | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/n

Re: via-velocity skb_over_panic

2015-11-13 Thread Francois Romieu
Timo Teras : [...] > So it's possible that some bad packets make the NIC return unexpected > packet sizes, and the current code can panic on it. > > Any suggestions for better fix? if (vptr->flags & VELOCITY_FLAGS_VAL_PKT_LEN) { if (rd->rdesc0.RSR & RSR_RL) { Huh ? [...

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-13 Thread Laura Abbott
On 11/13/2015 02:51 AM, Nikolay Aleksandrov wrote: On 11/13/2015 11:29 AM, Jiri Pirko wrote: Fri, Nov 13, 2015 at 01:26:18AM CET, f.faine...@gmail.com wrote: On 04/11/15 18:56, David Miller wrote: Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack") ..

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

2015-11-13 Thread Jason Baron
On 11/13/2015 01:51 PM, Rainer Weikusat wrote: [...] > > - if (unix_peer(other) != sk && unix_recvq_full(other)) { > - if (!timeo) { > - err = -EAGAIN; > - goto out_unlock; > - } > + if (unix_peer(sk) == other && !unix_dg

Re: 4.3.0+ breaks software VPN

2015-11-13 Thread Jens Axboe
On 11/13/2015 02:44 PM, Nikolay Aleksandrov wrote: On 11/13/2015 10:37 PM, Jens Axboe wrote: Hi, Tried to connect to sw vpn today, and it isn't working. Running git as-of yesterday. In dmesg: [23703.921542] vpn0: set_features() failed (-1); wanted 0x008048c1, left 0x0080001b48c9

Re: 4.3.0+ breaks software VPN

2015-11-13 Thread Nikolay Aleksandrov
On 11/13/2015 10:37 PM, Jens Axboe wrote: > Hi, > > Tried to connect to sw vpn today, and it isn't working. Running git as-of > yesterday. In dmesg: > > [23703.921542] vpn0: set_features() failed (-1); wanted 0x008048c1, > left 0x0080001b48c9 > > Reverting: > > fd867d51f889 > 5ba3

Re: 4.3.0+ breaks software VPN

2015-11-13 Thread Dave Jones
On Fri, Nov 13, 2015 at 02:37:00PM -0700, Jens Axboe wrote: > Hi, > > Tried to connect to sw vpn today, and it isn't working. Running git > as-of yesterday. In dmesg: > > [23703.921542] vpn0: set_features() failed (-1); wanted > 0x008048c1, left 0x0080001b48c9 > > Revertin

Re: kernel panic in 4.2.3, rb_erase in sch_fq

2015-11-13 Thread Denys Fedoryshchenko
I can confirm, after patch this issue never appeared again. So maybe good to push it to stable and etc :) Thanks a lot Eric, you saved me again. Still i have some weird panic issues, maybe related to conntrack, but they are rare even on high load, so i am slowly gathering data, and i found a

4.3.0+ breaks software VPN

2015-11-13 Thread Jens Axboe
Hi, Tried to connect to sw vpn today, and it isn't working. Running git as-of yesterday. In dmesg: [23703.921542] vpn0: set_features() failed (-1); wanted 0x008048c1, left 0x0080001b48c9 Reverting: fd867d51f889 5ba3f7d61a3a e7868a85e1b2 in reverse order makes it work again. Ho

Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec

2015-11-13 Thread David Miller
From: Sabrina Dubroca Date: Thu, 12 Nov 2015 10:48:22 +0100 > 2015-11-10, 16:03:52 -0800, Greg Kroah-Hartman wrote: >> On Tue, Nov 10, 2015 at 05:59:26PM -0600, Josh Hunt wrote: >> > On Thu, Oct 29, 2015 at 5:00 AM, Sabrina Dubroca >> > wrote: >> > > 2015-10-15, 14:25:03 +0200, Sabrina Dubroca

Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-13 Thread Andrew Lunn
On Thu, Nov 12, 2015 at 04:02:18PM +, Premkumar Jonnala wrote: > Packet forwarding to/from bond interfaces is done in software. > > This patch enables certain platforms to bridge traffic to/from > bond interfaces in hardware. Notifications are sent out when > the "active" slave set for a bon

Re: [PATCH -stable] multiple backports requested

2015-11-13 Thread David Miller
From: "Charles (Chas) Williams" <3ch...@gmail.com> Date: Fri, 13 Nov 2015 15:13:11 -0500 > Dave, could you please add the following backports? > > For the 3.14.y stable queue: I am no longer handling 3.14.y -stable submissions, sorry... > For the 4.1.y stable queue: > > commit 74e98eb085

Re: via-velocity skb_over_panic

2015-11-13 Thread David Miller
From: Timo Teras Date: Fri, 13 Nov 2015 18:49:47 +0200 > + if (pkt_len < 4 || pkt_len > vptr->rx.buf_sz) { > + VELOCITY_PRT(MSG_LEVEL_VERBOSE, KERN_ERR " %s : the received > frame size %d is inconsistent.\n", vptr->netdev->name, pkt_len); ... > This seems to have fixed the panic

[PATCH -stable] multiple backports requested

2015-11-13 Thread Charles (Chas) Williams
Dave, could you please add the following backports? For the 3.14.y stable queue: commit 77751427a1ff25b27d47a4c36b12c3c8667855ac ipv6: addrconf: validate new MTU before applying it This addresses CVE-2015-0272 commit 74e98eb085889b0d2d4908f59f6e00026063014f

Re: [patch] netlink: fix a limit in NETLINK_LIST_MEMBERSHIPS

2015-11-13 Thread Dan Carpenter
Oh. Crap... My mistake. Sorry for the noise. The original code is fine. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-13 Thread David Miller
From: Florian Fainelli Date: Fri, 13 Nov 2015 10:38:48 -0800 > This is a good explanation of why you want the changes, and how this is > implemented in a system utilizing that, but this is not documenting why > you are making these changes to the bonding code, nor how they are > supposed to be us

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

2015-11-13 Thread Rainer Weikusat
Hannes Frederic Sowa writes: > On Wed, Nov 11, 2015, at 17:12, Rainer Weikusat wrote: >> Hannes Frederic Sowa writes: >> > On Tue, Nov 10, 2015, at 22:55, Rainer Weikusat wrote: >> >> An AF_UNIX datagram socket being the client in an n:1 association with >> >> some server socket is only allowed t

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

2015-11-13 Thread Rainer Weikusat
An AF_UNIX datagram socket being the client in an n:1 association with some server socket is only allowed to send messages to the server if the receive queue of this socket contains at most sk_max_ack_backlog datagrams. This implies that prospective writers might be forced to go to sleep despite no

Re: [PATCH 00/10] Netfilter fixes for net

2015-11-13 Thread Jozsef Kadlecsik
On Fri, 13 Nov 2015, Josh Boyer wrote: > On Wed, Nov 11, 2015 at 12:33 PM, Pablo Neira Ayuso > wrote: > > Jozsef Kadlecsik (3): > > netfilter: ipset: Fix extension alignment > > netfilter: ipset: Fix hash:* type expiration > > netfilter: ipset: Fix hash type expire: release emp

Re: [net-next 04/17] drivers/net/intel: use napi_complete_done()

2015-11-13 Thread Alexander Duyck
On 11/13/2015 08:49 AM, Eric Dumazet wrote: On Fri, 2015-11-13 at 08:06 -0800, Alexander Duyck wrote: Yes, I'm pretty certain you cannot use this napi_complete_done with anything that support busy poll sockets. The problem is you need to flush any existing lists before yielding to the socket p

Re: [PATCH] bonding: Offloading bonds to hardware

2015-11-13 Thread Florian Fainelli
On 12/11/15 08:02, Premkumar Jonnala wrote: > Packet forwarding to/from bond interfaces is done in software. > > This patch enables certain platforms to bridge traffic to/from > bond interfaces in hardware. Notifications are sent out when > the "active" slave set for a bond interface is updated

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-13 Thread Florian Fainelli
On 13/11/15 05:54, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > When __netdev_update_features() was updated to ensure some features are > disabled on new lower devices, an error was introduced for devices which > don't have the ndo_set_features() method set. Before we'll just set th

[PATCH V3 2/2] arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS

2015-11-13 Thread Yang Shi
Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP in prologue in order to get the correct stack backtrace. However, ARM64 JIT used FP (x29) as eBPF fp register, FP is subjected to change during function call so it may cause the BPF prog stack base address change too. Use x25

Re: linux-next: Tree for Nov 13 (netfilter)

2015-11-13 Thread Randy Dunlap
On 11/12/15 18:23, Stephen Rothwell wrote: > Hi all, > > Please do *not* add any material intended for v4.5 to your linux-next > included branches until after v4.4-rc1 has been released. > > Changes since 20151112: > on x86_64: net/built-in.o: In function `tee_tg6': xt_TEE.c:(.text+0x4b28b):

Re: [PATCH 00/10] Netfilter fixes for net

2015-11-13 Thread Josh Boyer
On Wed, Nov 11, 2015 at 12:33 PM, Pablo Neira Ayuso wrote: > Jozsef Kadlecsik (3): > netfilter: ipset: Fix extension alignment > netfilter: ipset: Fix hash:* type expiration > netfilter: ipset: Fix hash type expire: release empty hash bucket block Should these three go to stable

Re: [iproute PATCH 05/12] ip{,6}tunnel: align do_tunnels_list() a bit

2015-11-13 Thread Phil Sutter
On Fri, Nov 13, 2015 at 05:30:10PM +, David Laight wrote: > From: Phil Sutter > > Sent: 13 November 2015 17:09 > > In iptunnel, declare loop variables inside the loop as done in > > ip6tunnel. > ... > > @@ -396,14 +396,8 @@ static void print_tunnel(struct ip_tunnel_parm *p) > > > > static int

RE: [iproute PATCH 05/12] ip{,6}tunnel: align do_tunnels_list() a bit

2015-11-13 Thread David Laight
From: Phil Sutter > Sent: 13 November 2015 17:09 > In iptunnel, declare loop variables inside the loop as done in > ip6tunnel. ... > @@ -396,14 +396,8 @@ static void print_tunnel(struct ip_tunnel_parm *p) > > static int do_tunnels_list(struct ip_tunnel_parm *p) > { > - char name[IFNAMSIZ]; >

Re: [PATCH 2/2] arm64: bpf: make BPF prologue and epilogue align with ARM64 AAPCS

2015-11-13 Thread Shi, Yang
On 11/12/2015 7:28 PM, Z Lim wrote: On Thu, Nov 12, 2015 at 1:57 PM, Yang Shi wrote: Save and restore FP/LR in BPF prog prologue and epilogue, save SP to FP in prologue in order to get the correct stack backtrace. However, ARM64 JIT used FP (x29) as eBPF fp register, FP is subjected to change

[iproute PATCH 06/12] ip6tunnel: print local/remote addresses like iptunnel does

2015-11-13 Thread Phil Sutter
This makes output consistent with iptunnel, also supporting reverse DNS lookup for remote address if requested. Signed-off-by: Phil Sutter --- ip/ip6tunnel.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/ip/ip6tunnel.c b/ip/ip6tunnel.c index ba92518..9eb5b2f

[iproute PATCH 09/12] iptunnel: simplify parsing TTL, allow 'hlim' as identifier

2015-11-13 Thread Phil Sutter
Instead of parsing an unsigned integer and checking boundaries, simply parse u8. This and the added ttl alias 'hlim' provide consistency with ip6tunnel. Signed-off-by: Phil Sutter --- ip/iptunnel.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ip/iptunnel.c b/ip/ip

[iproute PATCH 05/12] ip{,6}tunnel: align do_tunnels_list() a bit

2015-11-13 Thread Phil Sutter
In iptunnel, declare loop variables inside the loop as done in ip6tunnel. Fix and simplify goto logic in ip6tunnel: - Failure to read over header lines would have left fp opened. - By returning directly upon fopen() failure, fp can be closed unconditionally in the end. Use the same goto logic i

[iproute PATCH 10/12] iptunnel: share common code when determining the default interface name

2015-11-13 Thread Phil Sutter
Signed-off-by: Phil Sutter --- ip/iptunnel.c | 70 +-- 1 file changed, 25 insertions(+), 45 deletions(-) diff --git a/ip/iptunnel.c b/ip/iptunnel.c index 8c05f6f..3b46a15 100644 --- a/ip/iptunnel.c +++ b/ip/iptunnel.c @@ -239,10 +239,26 @@

[iproute PATCH 01/12] ip{,6}tunnel: get rid of extraneous whitespace when printing

2015-11-13 Thread Phil Sutter
Put whitespace in the beginning of optional parts, not as suffix anywhere. Also drop double whitespaces in between words. Signed-off-by: Phil Sutter --- ip/ip6tunnel.c | 4 ++-- ip/iptunnel.c | 16 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/ip/ip6tunnel.c

[iproute PATCH 11/12] iptunnel: sanitize copying tunnel name

2015-11-13 Thread Phil Sutter
Since p->name is only IFNAMSIZ bytes, do not copy more than IFNAMSIZ - 1 bytes into it so there remains at least a single null byte in the end. Signed-off-by: Phil Sutter --- ip/iptunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iptunnel.c b/ip/iptunnel.c index 3b4

[iproute PATCH 04/12] iptunnel: use ll_name_to_index() for physical interface lookup

2015-11-13 Thread Phil Sutter
Although the cache is only initialized in do_show(), this way it is at least consistent with ip6tunnel. Signed-off-by: Phil Sutter --- ip/iptunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iptunnel.c b/ip/iptunnel.c index 803bb83..a547852 100644 --- a/ip/iptunnel.c

[iproute PATCH 02/12] ip/tunnel: introduce tnl_parse_key()

2015-11-13 Thread Phil Sutter
Instead of duplicating the same code six times (key, ikey and okey in iptunnel and ip6tunnel), have a common parsing routine. This has the added benefit of having the same verbose error message in ip6tunnel as well as iptunnel. I'm not sure if parsing an IPv4 address as key makes sense for ip6tunn

[iproute PATCH 12/12] ip{,6}tunnel: put spaces around non-unary operators

2015-11-13 Thread Phil Sutter
Signed-off-by: Phil Sutter --- ip/ip6tunnel.c | 16 ip/iptunnel.c | 40 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/ip/ip6tunnel.c b/ip/ip6tunnel.c index d8957f0..320d253 100644 --- a/ip/ip6tunnel.c +++ b/ip/ip6tunnel

[iproute PATCH 07/12] ip6tunnel: fix coding style: no newline between brace and else

2015-11-13 Thread Phil Sutter
Signed-off-by: Phil Sutter --- ip/ip6tunnel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ip/ip6tunnel.c b/ip/ip6tunnel.c index 9eb5b2f..d8957f0 100644 --- a/ip/ip6tunnel.c +++ b/ip/ip6tunnel.c @@ -262,8 +262,7 @@ static int parse_args(int argc, char **argv, int cmd, st

[iproute PATCH 03/12] ip{,6}tunnel: unify behaviour if physical device is not found

2015-11-13 Thread Phil Sutter
Make ip6tunnel print an error message as well. While there, get rid of unnecessary line breaking. Signed-off-by: Phil Sutter --- ip/ip6tunnel.c | 4 +++- ip/iptunnel.c | 3 +-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ip/ip6tunnel.c b/ip/ip6tunnel.c index 8b842b6..410276f

[iproute PATCH 00/12] smaller iptunnel and ip6tunnel review

2015-11-13 Thread Phil Sutter
In an effort to try and merge iptunnel and ip6tunnel support code, I found a few things worth changing, mainly by comparing the two files. Please note that I did not test functionality of all supported tunnel modes, but since the changes are fairly small and obvious I hopefully didn't introduce to

[iproute PATCH 08/12] iptunnel: share common code when setting tunnel mode

2015-11-13 Thread Phil Sutter
Signed-off-by: Phil Sutter --- ip/iptunnel.c | 39 ++- 1 file changed, 14 insertions(+), 25 deletions(-) diff --git a/ip/iptunnel.c b/ip/iptunnel.c index e323c1f..92edb34 100644 --- a/ip/iptunnel.c +++ b/ip/iptunnel.c @@ -47,6 +47,15 @@ static void usage(void)

[PATCH 1/1] net: usb: cdc_ether: add Dell DW5580 as a mobile broadband adapter

2015-11-13 Thread Daniele Palmas
Since Dell DW5580 is a 3G modem, this patch adds the device as a mobile broadband adapter Signed-off-by: Daniele Palmas --- drivers/net/usb/cdc_ether.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 35a2bff..5e92076 100644

via-velocity skb_over_panic

2015-11-13 Thread Timo Teras
Hi, I recently saw via-velocity skb_over_panic() on one of my locations. The panic happened with two separate hardware devices, so it appears to be network related, not broken hardware. I did not get the actual over_panic printk, as I got only screen shot of them monitor. But the visible part of

Re: [net-next 04/17] drivers/net/intel: use napi_complete_done()

2015-11-13 Thread Eric Dumazet
On Fri, 2015-11-13 at 08:06 -0800, Alexander Duyck wrote: > Yes, I'm pretty certain you cannot use this napi_complete_done with > anything that support busy poll sockets. The problem is you need to > flush any existing lists before yielding to the socket polling in order > to avoid packet orde

Re: [PATCH] net: hisilicon: fix binding document of mdio

2015-11-13 Thread Arnd Bergmann
On Friday 13 November 2015 08:44:57 Rob Herring wrote: > > Please reformat like this: > > - compatible: can be one of: > "hisilicon,hns-mdio" > "hisilicon,mdio" > For hip04 board, must be "hisilicon,mdio". > Otherwise, must be "hisilicon,hns-mdio". should we recommend the use

Re: [PATCH 06/14] net: tcp_memcontrol: remove dead per-memcg count of allocated sockets

2015-11-13 Thread David Miller
From: Johannes Weiner Date: Thu, 12 Nov 2015 18:41:25 -0500 > The number of allocated sockets is used for calculations in the soft > limit phase, where packets are accepted but the socket is under memory > pressure. Since there is no soft limit phase in tcp_memcontrol, and > memory pressure is on

Re: [net-next 04/17] drivers/net/intel: use napi_complete_done()

2015-11-13 Thread Alexander Duyck
On 11/12/2015 09:18 PM, Eric Dumazet wrote: On Thu, 2015-10-15 at 14:43 -0700, Jeff Kirsher wrote: From: Jesse Brandeburg As per Eric Dumazet's previous patches: (see commit (24d2e4a50737) - tg3: use napi_complete_done()) Quoting verbatim: Using napi_complete_done() instead of napi_complete()

Re: [PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol calls by jump-label

2015-11-13 Thread David Miller
From: Johannes Weiner Date: Thu, 12 Nov 2015 18:41:24 -0500 > Move the jump-label from sock_update_memcg() and sock_release_memcg() > to the callsite, and so eliminate those function calls when socket > accounting is not enabled. > > This also eliminates the need for dummy functions because the

Re: [PATCH 03/14] net: tcp_memcontrol: properly detect ancestor socket pressure

2015-11-13 Thread David Miller
From: Johannes Weiner Date: Thu, 12 Nov 2015 18:41:22 -0500 > When charging socket memory, the code currently checks only the local > page counter for excess to determine whether the memcg is under socket > pressure. But even if the local counter is fine, one of the ancestors > could have breache

Re: [PATCH 04/14] net: tcp_memcontrol: remove bogus hierarchy pressure propagation

2015-11-13 Thread David Miller
From: Johannes Weiner Date: Thu, 12 Nov 2015 18:41:23 -0500 > When a cgroup currently breaches its socket memory limit, it enters > memory pressure mode for itself and its *ancestors*. This throttles > transmission in unrelated sibling and cousin subtrees that have > nothing to do with the breach

Re: [PATCH 02/14] mm: vmscan: simplify memcg vs. global shrinker invocation

2015-11-13 Thread David Miller
From: Johannes Weiner Date: Thu, 12 Nov 2015 18:41:21 -0500 > Letting shrink_slab() handle the root_mem_cgroup, and implicitely the > !CONFIG_MEMCG case, allows shrink_zone() to invoke the shrinkers > unconditionally from within the memcg iteration loop. > > Signed-off-by: Johannes Weiner > Ack

Re: [PATCH 01/14] mm: memcontrol: export root_mem_cgroup

2015-11-13 Thread David Miller
From: Johannes Weiner Date: Thu, 12 Nov 2015 18:41:20 -0500 > A later patch will need this symbol in files other than memcontrol.c, > so export it now and replace mem_cgroup_root_css at the same time. > > Signed-off-by: Johannes Weiner > Acked-by: Michal Hocko Acked-by: David S. Miller -- To

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-11-13 Thread Or Gerlitz
On Fri, Nov 13, 2015 at 10:14 AM, Joe Stringer wrote: > I don't follow the logic. You observed one flow which matched on > TTL=64, therefore all vxlan packets terminated at OVS have TTL=64? > If OVS received packets with different TTLs, they would miss and > ovs-vswitchd would generate flows to

Re: [PATCH] net: hisilicon: fix binding document of mdio

2015-11-13 Thread Rob Herring
On Fri, Nov 13, 2015 at 10:23:44AM +0800, huangdaode wrote: > This patch fixes explain the occasion of "hisilcon,mdio" according to > Arnd's comments. specify it is only used for hip04. > > First, please give your commnents. > > Signed-off-by: huangdaode > --- > Documentation/devicetree/binding

Re: [patch] netlink: fix a limit in NETLINK_LIST_MEMBERSHIPS

2015-11-13 Thread David Herrmann
Hi On Fri, Nov 13, 2015 at 3:20 PM, Dan Carpenter wrote: > This condition doesn't work when len is smaller than expected and not a > multiple of 4. In that situation "len - pos" is negative and type > promoted to a high unsigned value and we do not break out of the loop. > It causes the program

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-13 Thread Jarod Wilson
Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov When __netdev_update_features() was updated to ensure some features are disabled on new lower devices, an error was introduced for devices which don't have the ndo_set_features() method set. Before we'll just set the new features, but now we r

[patch] netlink: fix a limit in NETLINK_LIST_MEMBERSHIPS

2015-11-13 Thread Dan Carpenter
This condition doesn't work when len is smaller than expected and not a multiple of 4. In that situation "len - pos" is negative and type promoted to a high unsigned value and we do not break out of the loop. It causes the program calling it to crash. Fixes: b42be38b2778 ('netlink: add API to ret

[PATCH net] net: fix __netdev_update_features return on ndo_set_features failure

2015-11-13 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov If ndo_set_features fails __netdev_update_features() will return -1 but this is wrong because it is expected to return 0 if no features were changed (see netdev_update_features()), which will cause a netdev notifier to be called without any actual changes. Fix this by re

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-13 Thread Andy Gospodarek
On Fri, Nov 13, 2015 at 02:54:01PM +0100, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > When __netdev_update_features() was updated to ensure some features are > disabled on new lower devices, an error was introduced for devices which > don't have the ndo_set_features() method set. B

Re: [PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-13 Thread Jiri Pirko
Fri, Nov 13, 2015 at 02:54:01PM CET, ra...@blackwall.org wrote: >From: Nikolay Aleksandrov > >When __netdev_update_features() was updated to ensure some features are >disabled on new lower devices, an error was introduced for devices which >don't have the ndo_set_features() method set. Before we'l

[PATCH net] net: fix feature changes on devices without ndo_set_features

2015-11-13 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov When __netdev_update_features() was updated to ensure some features are disabled on new lower devices, an error was introduced for devices which don't have the ndo_set_features() method set. Before we'll just set the new features, but now we return an error and don't set

Re: [PATCH net] switchdev: bridge: Check return code is not EOPNOTSUPP

2015-11-13 Thread Sander Eikelenboom
On 2015-11-13 13:43, Ido Schimmel wrote: Fri, Nov 13, 2015 at 02:34:45PM IST, li...@eikelenboom.it wrote: On 2015-11-13 12:06, Ido Schimmel wrote: When NET_SWITCHDEV=n, switchdev_port_attr_set simply returns EOPNOTSUPP. In this case we should not emit errors and warnings to the kernel log. H

Re: [PATCH net] switchdev: bridge: Check return code is not EOPNOTSUPP

2015-11-13 Thread Ido Schimmel
Fri, Nov 13, 2015 at 02:34:45PM IST, li...@eikelenboom.it wrote: >On 2015-11-13 12:06, Ido Schimmel wrote: >> When NET_SWITCHDEV=n, switchdev_port_attr_set simply returns >> EOPNOTSUPP. >> In this case we should not emit errors and warnings to the kernel log. > >Hi Ido, > >Thanks for your patch! >

Re: [PATCH net] switchdev: bridge: Check return code is not EOPNOTSUPP

2015-11-13 Thread Sander Eikelenboom
On 2015-11-13 12:06, Ido Schimmel wrote: When NET_SWITCHDEV=n, switchdev_port_attr_set simply returns EOPNOTSUPP. In this case we should not emit errors and warnings to the kernel log. Hi Ido, Thanks for your patch! It fixes these: [ 207.245442] vif vif-1-0 vif1.0: failed to set HW ageing t

[PATCH net] switchdev: bridge: Check return code is not EOPNOTSUPP

2015-11-13 Thread Ido Schimmel
When NET_SWITCHDEV=n, switchdev_port_attr_set simply returns EOPNOTSUPP. In this case we should not emit errors and warnings to the kernel log. Reported-by: Sander Eikelenboom Fixes: 0bc05d585d38 ("switchdev: allow caller to explicitly request attr_set as deferred") Fixes: 6ac311ae8bfb ("Adding s

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-13 Thread Nikolay Aleksandrov
On 11/13/2015 11:29 AM, Jiri Pirko wrote: > Fri, Nov 13, 2015 at 01:26:18AM CET, f.faine...@gmail.com wrote: >> On 04/11/15 18:56, David Miller wrote: Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack") >>> ... Reported-by: Nikolay Aleksandrov

Re: [PATCH net] ravb: Fix int mask value overwritten issue

2015-11-13 Thread Geert Uytterhoeven
Hi Kaneko-san, On Fri, Nov 13, 2015 at 11:24 AM, Yoshihiro Kaneko wrote: > From: Masaru Nagai > > When RX/TX interrupt for Network Control queue and Best Effort queue > is issued at the same time, the interrupt mask of Network Control > queue will be reset when the mask of Best Effort queue is s

Re: [PATCH 10/14] mm: memcontrol: generalize the socket accounting jump label

2015-11-13 Thread Michal Hocko
On Thu 12-11-15 18:41:29, Johannes Weiner wrote: > The unified hierarchy memory controller is going to use this jump > label as well to control the networking callbacks. Move it to the > memory controller code and give it a more generic name. > > Signed-off-by: Johannes Weiner Yes it makes more

[PATCH] net ipv4: use preferred log methods

2015-11-13 Thread Bastian Stender
Replace printk calls with preferred unconditional log method calls to keep kernel messages clean. Added newline to "too small MTU" message. Signed-off-by: Bastian Stender --- net/ipv4/ipconfig.c| 73 ++ net/ipv4/netfilter/arp_tables.c

[PATCH v2] net ipv4: use preferred log methods

2015-11-13 Thread Bastian Stender
Replace printk calls with preferred unconditional log method calls to keep kernel messages clean. Conditional printks were left untouched to avoid change in behaviour. Furthermore a newline was added to the "too small MTU" message. -- To unsubscribe from this list: send the line "unsubscribe netd

Re: [PATCH 11/14] mm: memcontrol: do not account memory+swap on unified hierarchy

2015-11-13 Thread Michal Hocko
On Thu 12-11-15 18:41:30, Johannes Weiner wrote: > The unified hierarchy memory controller doesn't expose the memory+swap > counter to userspace, but its accounting is hardcoded in all charge > paths right now, including the per-cpu charge cache ("the stock"). > > To avoid adding yet more pointles

[PATCH net-next 1/2] be2net: remove unused local rsstable array

2015-11-13 Thread Ivan Vecera
Remove rsstable array and its initialization from be_set_rss_hash_opts(). The array became unused after "e255787 be2net: Support for configurable RSS hash key". The initial RSS table is now filled and stored for later usage during Rx queue creation. Signed-off-by: Ivan Vecera --- drivers/net/eth

[PATCH net-next 2/2] be2net: replace hardcoded values with existing define

2015-11-13 Thread Ivan Vecera
Signed-off-by: Ivan Vecera --- drivers/net/ethernet/emulex/benet/be_ethtool.c | 3 ++- drivers/net/ethernet/emulex/benet/be_main.c| 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethto

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-13 Thread Jiri Pirko
Fri, Nov 13, 2015 at 01:26:18AM CET, f.faine...@gmail.com wrote: >On 04/11/15 18:56, David Miller wrote: >>> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev >>> features down stack") >> ... >>> Reported-by: Nikolay Aleksandrov >>> Signed-off-by: Jarod Wilson >>> --- >>> v2:

[PATCH net] ravb: Fix int mask value overwritten issue

2015-11-13 Thread Yoshihiro Kaneko
From: Masaru Nagai When RX/TX interrupt for Network Control queue and Best Effort queue is issued at the same time, the interrupt mask of Network Control queue will be reset when the mask of Best Effort queue is set. This patch fixes this problem. Signed-off-by: Masaru Nagai Signed-off-by: Yosh

Re: [PATCH] net: phy: vitesse: add support for VSC8601

2015-11-13 Thread Måns Rullgård
Mason writes: > On 12/11/2015 19:41, Mans Rullgard wrote: > >> +.phy_id = PHY_ID_VSC8601, >> +.name = "Vitesse VSC8601", >> +.phy_id_mask= 0x0000, >> +.features = PHY_GBIT_FEATURES, >> +.flags = PHY_HAS_INTERRUPT, >> +.config_init

[PATCH net] be2net: check properly status in lancer_cmd_get_file_len()

2015-11-13 Thread Ivan Vecera
The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get the current size of registers for ethtool registers dump. The size is stored in data_read but only when the returned status is 0 otherwise it is uninitialized thus random. Signed-off-by: Ivan Vecera --- drivers/net/ethernet/emul

Re: [PATCH net-next RFC V3 0/3] basic busy polling support for vhost_net

2015-11-13 Thread Jason Wang
On 11/12/2015 08:02 PM, Felipe Franciosi wrote: > Hi Jason, > > I understand your busy loop timeout is quite conservative at 50us. Did you > try any other values? I've also tried 20us. And results shows 50us was better in: - very small packet tx (e.g 64bytes at most 46% improvement) - TCP_RR (

Re: [PATCH] net: phy: vitesse: add support for VSC8601

2015-11-13 Thread Mason
On 12/11/2015 19:41, Mans Rullgard wrote: > + .phy_id = PHY_ID_VSC8601, > + .name = "Vitesse VSC8601", > + .phy_id_mask= 0x0000, > + .features = PHY_GBIT_FEATURES, > + .flags = PHY_HAS_INTERRUPT, > + .config_init= &genphy_config_

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

2015-11-13 Thread Joe Stringer
On 11 November 2015 at 22:34, Or Gerlitz wrote: > On Thu, Nov 12, 2015 at 12:44 AM, Jesse Gross wrote: >> On Wed, Nov 11, 2015 at 6:47 AM, Or Gerlitz wrote: >>> Hi Joe/Jesse, >>> >>> We've noticed that VXLAN decap rules set by OVS in the below trivial VXLAN >>> config contain full match on TTL=6

Re: [PATCH v2] stmmac: avoid ipq806x constant overflow warning

2015-11-13 Thread Geert Uytterhoeven
Hi Joe, On Fri, Nov 13, 2015 at 8:52 AM, Joe Perches wrote: > On Fri, 2015-11-13 at 08:37 +0100, Geert Uytterhoeven wrote: >> On Thu, Nov 12, 2015 at 10:03 PM, Arnd Bergmann >> wrote: >> > Building dwmac-ipq806x on a 64-bit architecture produces a harmless >> > warning from gcc: >> > >> > stmmac