Hello!
> >> If you think I should reconsider the patch, you should resubmit it.
> >
> > I understand this, of course. But, before doing this i'd like to
> > clarify your concern, why exactly you think that loopback test will
> > break.
>
> If I didn't reply it means I don't have anything constr
On Thu, Nov 12, 2015 at 12:44 AM, Jesse Gross wrote:
> On Wed, Nov 11, 2015 at 6:47 AM, Or Gerlitz wrote:
>> Hi Joe/Jesse,
>>
>> We've noticed that VXLAN decap rules set by OVS in the below trivial VXLAN
>> config contain full match on TTL=64 for the outer headers, can you explain
>> the reasonin
12.11.2015, 01:41, "Vincent Li" :
> Hi
>
> Sorry I am not sure if this is the right list to ask this question,
> please direct me to the correct one. thanks!
>
> I am using Intel 82599 on Dell PowerEdge R710 which should support
> NUMA node, the box is running ubuntu 14.01.1 LTS , I am wondering
On 11/11/2015 05:35 PM, Stephen Hemminger wrote:
On Thu, 22 Oct 2015 16:26:36 -0700
Alexander Duyck wrote:
+static int ixgbe_uc_unsync(struct net_device *netdev, const unsigned char
*addr)
+{
+ struct ixgbe_adapter *adapter = netdev_priv(netdev);
+
+ ixgbe_del_mac_filter(adapter,
now sctp auth cannot work well when setting a hmacid manually, which
is caused by that we didn't use the network order for hmacid, so fix
it by adding the transformation in sctp_auth_ep_set_hmacs.
even we set hmacid with the network order in userspace, it still
can't work, because of this conditio
Hi David & Folks,
Soon I will submit a virtual tunnel device driver to LKML for review.
It uses rtnl_link_register to create a virtual network interface,
which then handles encryption, authentication, and some other things,
amongst various configured peers.
Right now the device is configurable vi
Thanks, Colin.
Signed-off-by: Taku Izumi
> -Original Message-
> From: Colin King [mailto:colin.k...@canonical.com]
> Sent: Thursday, November 12, 2015 12:23 AM
> To: David S. Miller; Izumi, Taku/泉 拓; Markus Elfring; netdev@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
> Subject: [PA
On 2015/11/3 6:05, Arnd Bergmann wrote:
On Saturday 31 October 2015 02:18:19 Salil Mehta wrote:
On 10/31/2015 1:40 AM, huangdaode wrote:
On 2015/10/30 22:20, Arnd Bergmann wrote:
On Tuesday 27 October 2015 19:16:34 huangdaode wrote:
mdio@803c {
#address-c
On Thu, 22 Oct 2015 16:26:36 -0700
Alexander Duyck wrote:
> +static int ixgbe_uc_unsync(struct net_device *netdev, const unsigned char
> *addr)
> +{
> + struct ixgbe_adapter *adapter = netdev_priv(netdev);
> +
> + ixgbe_del_mac_filter(adapter, addr, VMDQ_P(0));
> +
> + return 0;
Why
On Wed, 2015-11-11 at 10:43 -0800, Eric Dumazet wrote:
> On Wed, 2015-11-11 at 10:23 -0800, Tom Herbert wrote:
>
> > How about doing this in shutdown called for a listener?
>
> Seems a good idea, I will try it, thanks !
>
Arg, I forgot about this shutdown() discussion we had recently
with Oracl
On Mon, Nov 09, 2015 at 09:54:34AM +0200, Yuval Mintz wrote:
> From: Sudarsana Kalluru
>
> This adds the first FW entry to the newly added
> Qlogic Ethernet Driver product series.
>
> Signed-off-by: Sudarsana Kalluru
> Signed-off-by: Yuval Mintz
Applied, thanks.
--Kyle
--
To unsubscribe from
Yes PowerEdge R710 is Nehalem based Intel system. thank you for the answer
On Wed, Nov 11, 2015 at 3:25 PM, Alexander Duyck
wrote:
> On 11/11/2015 02:41 PM, Vincent Li wrote:
>>
>> Hi
>>
>> Sorry I am not sure if this is the right list to ask this question,
>> please direct me to the correct one.
On Wed, Nov 11, 2015 at 11:21:35PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 11, 2015 at 11:55:59AM -0800, Alexei Starovoitov wrote:
> > Therefore things like memory barriers, full set of atomics are not
> > applicable
> > in bpf world.
>
> There are still plenty of wait-free constructs one can
-Original Message-
From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On
Behalf Of Alexander Duyck
Sent: Thursday, October 22, 2015 4:27 PM
To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T
Subject: [Intel-wired-lan] [net-next PATCH 1/3
On 11/11/2015 02:41 PM, Vincent Li wrote:
Hi
Sorry I am not sure if this is the right list to ask this question,
please direct me to the correct one. thanks!
I am using Intel 82599 on Dell PowerEdge R710 which should support
NUMA node, the box is running ubuntu 14.01.1 LTS , I am wondering why
On Wed, Nov 11, 2015 at 6:07 PM, Daniel Borkmann wrote:
> On 11/11/2015 11:55 PM, Willem de Bruijn wrote:
>>
>> On Wed, Nov 11, 2015 at 5:25 PM, Daniel Borkmann
>> wrote:
>
> ...
>>>
>>> + if (!gso_type && (len > dev->mtu + reserve + extra_len) &&
>>> + !packet_extra_vlan_len_allo
On Wed, Nov 11, 2015 at 5:25 PM, Daniel Borkmann wrote:
> In case no struct sockaddr_ll has been passed to packet
> socket's sendmsg() when doing a TX_RING flush run, then
> skb->protocol is set to po->num instead, which is the protocol
> passed via socket(2)/bind(2).
>
> Applications only xmittin
On 11/11/2015 11:55 PM, Willem de Bruijn wrote:
On Wed, Nov 11, 2015 at 5:25 PM, Daniel Borkmann wrote:
...
+ if (!gso_type && (len > dev->mtu + reserve + extra_len) &&
+ !packet_extra_vlan_len_allowed(dev, skb)) {
+ err = -EMSGSIZE;
+ goto out_free;
On Wed, Nov 11, 2015 at 5:25 PM, Daniel Borkmann wrote:
> Since it's introduction in commit 69e3c75f4d54 ("net: TX_RING and
> packet mmap"), TX_RING could be used from SOCK_DGRAM and SOCK_RAW
> side. When used with SOCK_DGRAM only, the size_max > dev->mtu +
> reserve check should have reserve as 0
On Wed, Nov 11, 2015 at 5:25 PM, Daniel Borkmann wrote:
> Packet sockets can be used by various net devices and are not
> really restricted to ARPHRD_ETHER device types. However, when
> currently checking for the extra 4 bytes that can be transmitted
> in VLAN case, our assumption is that we gener
Hello,
On Wed, 11 Nov 2015, Kouya Shimura wrote:
> Hi
>
> When both server and client are on the same machine and each their
> socket option is set to SO_BINDTODEVICE, sometimes a packet doesn't
> reach to the server.
>
> The reproducible test program is attached. (modify "IF_ADDR=, IP
On Wed, Nov 11, 2015 at 6:47 AM, Or Gerlitz wrote:
> Hi Joe/Jesse,
>
> We've noticed that VXLAN decap rules set by OVS in the below trivial VXLAN
> config contain full match on TTL=64 for the outer headers, can you explain
> the reasoning behind it? is that justa typo in dumping the flow?
Looking
Hi
Sorry I am not sure if this is the right list to ask this question,
please direct me to the correct one. thanks!
I am using Intel 82599 on Dell PowerEdge R710 which should support
NUMA node, the box is running ubuntu 14.01.1 LTS , I am wondering why I
get NUMA socket -1.
in BIOS, the memory "
On 11/11/2015 03:56 PM, Willem de Bruijn wrote:
On Tue, Nov 10, 2015 at 6:51 PM, Daniel Borkmann wrote:
...
Saw that, so we need the check as one more fix for 57f89bfa2140 ("network:
Allow af_packet to transmit +4 bytes for VLAN packets.") as well.
I'll see to respin a v3 tomorrow.
Thanks,
Signed-off-by: Francois Romieu
Reported-by: Dave Jones
Fixes: d7d2d89d4b0af ("r8169: Add software counter for multicast packages")
Acked-by: Eric Dumazet
Acked-by: Corinna Vinschen
---
Applies to davem's net as of c5a37883f42be712a989e54d5d6c0159b0e56599
("Merge branch 'akpm' (patches from A
Fixes a couple of issues in packet sockets, i.e. on TX ring side. See
individual patches for details.
v2 -> v3:
- First two patches unchanged, kept Jason's Ack
- Reworked 3rd patch and split into 3:
- check for dev type as discussed with Willem
- infer skb->protocol
- fix max len for dgram
We concluded that the skb_probe_transport_header() should better be
called unconditionally. Avoiding the call into the flow dissector has
also not really much to do with the direct xmit mode.
While it seems that only virtio_net code makes use of GSO from non
RX/TX ring packet socket paths, we shou
In case no struct sockaddr_ll has been passed to packet
socket's sendmsg() when doing a TX_RING flush run, then
skb->protocol is set to po->num instead, which is the protocol
passed via socket(2)/bind(2).
Applications only xmitting can go the path of allocating the
socket as socket(PF_PACKET, , 0)
Since it's introduction in commit 69e3c75f4d54 ("net: TX_RING and
packet mmap"), TX_RING could be used from SOCK_DGRAM and SOCK_RAW
side. When used with SOCK_DGRAM only, the size_max > dev->mtu +
reserve check should have reserve as 0, but currently, this is
unconditionally set (in it's original fo
Packet sockets can be used by various net devices and are not
really restricted to ARPHRD_ETHER device types. However, when
currently checking for the extra 4 bytes that can be transmitted
in VLAN case, our assumption is that we generally probe on
ARPHRD_ETHER devices. Therefore, before looking int
In tpacket_fill_skb() commit c1aad275b029 ("packet: set transport
header before doing xmit") and later on 40893fd0fd4e ("net: switch
to use skb_probe_transport_header()") was probing for a transport
header on the skb from a ring buffer slot, but at a time, where
the skb has _not even_ been filled w
Use the local uapi headers to keep in sync with "recently" added #define's
(e.g. SKF_AD_VLAN_TPID). Refactored CFLAGS, and bpf_asm doesn't need -I.
Fixes: 3f356385e8a449e1d7cfc6b6f8d634ac4f5581a0
Signed-off-by: Kamal Mostafa
---
tools/net/Makefile | 7 ---
1 file changed, 4 insertions(+), 3
On Wed, Nov 11, 2015 at 11:55:59AM -0800, Alexei Starovoitov wrote:
> Therefore things like memory barriers, full set of atomics are not applicable
> in bpf world.
There are still plenty of wait-free constructs one can make using them.
Say a barrier/rendezvous construct for knowing when an event
William,
Emil S wrote:
>> It also fixes my issue: even if eth{2,3} are still up with no carrier, I
>> don't have any kworker in D state.
>
> It appears that you have 2 ports with empty cages. If that is the case there
> is no reason to keep the interfaces up. If you bring them down, or plug the
On 11/11/2015 01:34 PM, William Dauchy wrote:
On Nov11 20:33, Tantilov, Emil S wrote:
If the diff above is the patch you are referring to then you will break the
SFP+ detection in the case where the driver was loaded while there were no
SFP+ modules present in the cages.
understood, I was surpr
On Nov11 20:33, Tantilov, Emil S wrote:
> If the diff above is the patch you are referring to then you will break the
> SFP+ detection in the case where the driver was loaded while there were no
> SFP+ modules present in the cages.
understood, I was surprised of the modification of behavior.
--
Hi!
We are pleased to announce that registration is now open for netdev 1.1,
the community-driven Linux networking conference held back-to-back with
netconf in Sevilla, Spain, February 10-12, 2016.
Registration is now open at: https://www.netdevconf.org/1.1/registration.html
= Fees =
* Regular
David Miller writes:
> From: Måns Rullgård
> Date: Wed, 11 Nov 2015 19:35:05 +
>
>>> I don't think it's silly at all.
>>
>> I'm sure I read somewhere that the time spent spinning on a lock should
>> be kept as small as possible.
>>
>>> And unless you can measure it making a difference, don
>-Original Message-
>From: William Dauchy [mailto:will...@gandi.net]
>Sent: Wednesday, November 11, 2015 9:35 AM
>To: Kirsher, Jeffrey T; Tantilov, Emil S
>Cc: da...@davemloft.net; netdev@vger.kernel.org; Schmitt, Phillip J; intel-
>wired-...@lists.osuosl.org
>Subject: regression in ixgbe S
On Wed, Nov 11, 2015, at 21:09, Eric Dumazet wrote:
> On Wed, 2015-11-11 at 20:58 +0100, Hannes Frederic Sowa wrote:
> >
> > On Wed, Nov 11, 2015, at 20:42, Eric Dumazet wrote:
> > > On Wed, 2015-11-11 at 20:35 +0100, Hannes Frederic Sowa wrote:
> > > >
> > > > On Wed, Nov 11, 2015, at 20:28, Er
On Wed, 2015-11-11 at 20:58 +0100, Hannes Frederic Sowa wrote:
>
> On Wed, Nov 11, 2015, at 20:42, Eric Dumazet wrote:
> > On Wed, 2015-11-11 at 20:35 +0100, Hannes Frederic Sowa wrote:
> > >
> > > On Wed, Nov 11, 2015, at 20:28, Eric Dumazet wrote:
> > > > On Wed, 2015-11-11 at 20:14 +0100, Hann
On Wed, Nov 11, 2015, at 20:42, Eric Dumazet wrote:
> On Wed, 2015-11-11 at 20:35 +0100, Hannes Frederic Sowa wrote:
> >
> > On Wed, Nov 11, 2015, at 20:28, Eric Dumazet wrote:
> > > On Wed, 2015-11-11 at 20:14 +0100, Hannes Frederic Sowa wrote:
> > > > On Wed, Nov 11, 2015, at 19:58, Eric Dumaz
On Wed, Nov 11, 2015 at 07:54:15PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 11, 2015 at 07:44:27PM +0100, Peter Zijlstra wrote:
> > On Wed, Nov 11, 2015 at 07:31:28PM +0100, Peter Zijlstra wrote:
> > > > Add new one that does 'fetch_and_add' ? What is the real use case it
> > > > will be used for
Since the expires of the DST_NOCACHE rt can be set during
the ip6_rt_update_pmtu(), we also need to consider the expires
value when doing ip6_dst_check().
This patches creates __rt6_check_expired() to only
check the expire value (if one exists) of the current rt.
In rt6_dst_from_check(), it adds
All DST_NOCACHE rt6_info used to have rt->dst.from set to
its parent.
After commit 8e3d5be73681 ("ipv6: Avoid double dst_free"),
DST_NOCACHE is also set to rt6_info which does not have
a parent (i.e. rt->dst.from is NULL).
This patch catches the rt->dst.from == NULL case.
Fixes: 8e3d5be73681 ("i
This patchset fixes:
1. An oops during IPv6 pmtu update on a IPv4 GRE running
in an IPSec setup
2. Misc fixes on DST_NOCACHE route
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kerne
The original bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1272571
The setup has a IPv4 GRE tunnel running in a IPSec. The bug
happens when ndisc starts sending router solicitation at the gre
interface. The simplified oops stack is like:
__lock_acquire+0x1b2/0x1c30
lock_acquire+0xb9/0
From: Måns Rullgård
Date: Wed, 11 Nov 2015 19:35:05 +
>> I don't think it's silly at all.
>
> I'm sure I read somewhere that the time spent spinning on a lock should
> be kept as small as possible.
>
>> And unless you can measure it making a difference, don't knock the idea.
>
> I tried us
On Wed, 2015-11-11 at 20:35 +0100, Hannes Frederic Sowa wrote:
>
> On Wed, Nov 11, 2015, at 20:28, Eric Dumazet wrote:
> > On Wed, 2015-11-11 at 20:14 +0100, Hannes Frederic Sowa wrote:
> > > On Wed, Nov 11, 2015, at 19:58, Eric Dumazet wrote:
> >
> > > Can you elaborate?
> > >
> > > I use tail
On 11/11/2015 08:23 PM, Peter Zijlstra wrote:
On Wed, Nov 11, 2015 at 07:50:15PM +0100, Daniel Borkmann wrote:
Well, on that note, it's not like you just change the target to bpf in your
Makefile and can compile (& load into the kernel) anything you want with it.
You do have to write small, rest
From: Måns Rullgård
Date: Wed, 11 Nov 2015 19:25:46 +
> David Miller writes:
>
>> From: Måns Rullgård
>> Date: Wed, 11 Nov 2015 19:17:07 +
>>
>>> David Miller writes:
>>>
From: Måns Rullgård
Date: Wed, 11 Nov 2015 19:09:19 +
> David Miller writes:
>
David Miller writes:
> From: Måns Rullgård
> Date: Wed, 11 Nov 2015 19:25:46 +
>
>> David Miller writes:
>>
>>> From: Måns Rullgård
>>> Date: Wed, 11 Nov 2015 19:17:07 +
>>>
David Miller writes:
> From: Måns Rullgård
> Date: Wed, 11 Nov 2015 19:09:19 +
>
>
On Wed, Nov 11, 2015, at 20:28, Eric Dumazet wrote:
> On Wed, 2015-11-11 at 20:14 +0100, Hannes Frederic Sowa wrote:
> > On Wed, Nov 11, 2015, at 19:58, Eric Dumazet wrote:
>
> > Can you elaborate?
> >
> > I use tail as a cookie and check if we already tried to append to the
> > same tail skb w
On Wed, 2015-11-11 at 20:14 +0100, Hannes Frederic Sowa wrote:
> On Wed, Nov 11, 2015, at 19:58, Eric Dumazet wrote:
> Can you elaborate?
>
> I use tail as a cookie and check if we already tried to append to the
> same tail skb with skb_append_pagefrags. If during allocation, which we
> do outsid
David Miller writes:
> From: Måns Rullgård
> Date: Wed, 11 Nov 2015 19:17:07 +
>
>> David Miller writes:
>>
>>> From: Måns Rullgård
>>> Date: Wed, 11 Nov 2015 19:09:19 +
>>>
David Miller writes:
> From: Måns Rullgård
> Date: Wed, 11 Nov 2015 18:25:05 +
>
>
On Wed, Nov 11, 2015 at 07:50:15PM +0100, Daniel Borkmann wrote:
> Well, on that note, it's not like you just change the target to bpf in your
> Makefile and can compile (& load into the kernel) anything you want with it.
> You do have to write small, restricted programs from scratch for a specific
From: Måns Rullgård
Date: Wed, 11 Nov 2015 19:17:07 +
> David Miller writes:
>
>> From: Måns Rullgård
>> Date: Wed, 11 Nov 2015 19:09:19 +
>>
>>> David Miller writes:
>>>
From: Måns Rullgård
Date: Wed, 11 Nov 2015 18:25:05 +
> If the TX DMA channel is idle whe
On Wed, Nov 11, 2015, at 20:14, Hannes Frederic Sowa wrote:
> On Wed, Nov 11, 2015, at 19:58, Eric Dumazet wrote:
> > On Tue, 2015-11-10 at 16:23 +0100, Hannes Frederic Sowa wrote:
> > > During splicing an af-unix socket to a pipe we have to drop all
> > > af-unix socket locks. While doing so we al
David Miller writes:
> From: Måns Rullgård
> Date: Wed, 11 Nov 2015 19:09:19 +
>
>> David Miller writes:
>>
>>> From: Måns Rullgård
>>> Date: Wed, 11 Nov 2015 18:25:05 +
>>>
If the TX DMA channel is idle when start_xmit is called, it can be
started immediately. Checking the
On Wed, Nov 11, 2015, at 19:58, Eric Dumazet wrote:
> On Tue, 2015-11-10 at 16:23 +0100, Hannes Frederic Sowa wrote:
> > During splicing an af-unix socket to a pipe we have to drop all
> > af-unix socket locks. While doing so we allow another reader to enter
> > unix_stream_read_generic which can r
From: Måns Rullgård
Date: Wed, 11 Nov 2015 19:09:19 +
> David Miller writes:
>
>> From: Måns Rullgård
>> Date: Wed, 11 Nov 2015 18:25:05 +
>>
>>> If the TX DMA channel is idle when start_xmit is called, it can be
>>> started immediately. Checking the DMA status and starting it if
>>>
David Miller writes:
> From: Måns Rullgård
> Date: Wed, 11 Nov 2015 18:25:05 +
>
>> If the TX DMA channel is idle when start_xmit is called, it can be
>> started immediately. Checking the DMA status and starting it if
>> idle has to be done atomically somehow.
>
> ->ndo_start_xmit() is guar
From: Daniel Borkmann
Date: Wed, 11 Nov 2015 19:50:15 +0100
> Well, on that note, it's not like you just change the target to bpf
> in your Makefile and can compile (& load into the kernel) anything
> you want with it. You do have to write small, restricted programs
> from scratch for a specific
From: Måns Rullgård
Date: Wed, 11 Nov 2015 18:25:05 +
> If the TX DMA channel is idle when start_xmit is called, it can be
> started immediately. Checking the DMA status and starting it if
> idle has to be done atomically somehow.
->ndo_start_xmit() is guaranteed to be invoked atomically, p
From: Alexei Starovoitov
Date: Wed, 11 Nov 2015 10:11:33 -0800
> bpf_xadd was never meant to be __sync_fetch_and_add equivalent.
> From the day one it meant to be atomic_add() as kernel does it.
+1
> I did piggy back on __sync in the llvm backend because it was the quick
> and dirty way to move
From: Will Deacon
Date: Wed, 11 Nov 2015 17:44:01 +
> On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote:
>> From: Alexei Starovoitov
>> Date: Wed, 11 Nov 2015 09:27:00 -0800
>>
>> > BPF_XADD == atomic_add() in kernel. period.
>> > we are not going to deprecate it or introduce som
On Tue, 2015-11-10 at 16:23 +0100, Hannes Frederic Sowa wrote:
> During splicing an af-unix socket to a pipe we have to drop all
> af-unix socket locks. While doing so we allow another reader to enter
> unix_stream_read_generic which can read, copy and finally free another
> skb. If exactly this sk
On Wed, Nov 11, 2015 at 07:44:27PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 11, 2015 at 07:31:28PM +0100, Peter Zijlstra wrote:
> > > Add new one that does 'fetch_and_add' ? What is the real use case it
> > > will be used for?
> >
> > Look at all the atomic_{add,dec}_return*() users in the kerne
Hi,
On Wed, Nov 11, 2015, at 17:12, Rainer Weikusat wrote:
> Hannes Frederic Sowa writes:
> > On Tue, Nov 10, 2015, at 22:55, Rainer Weikusat wrote:
> >> An AF_UNIX datagram socket being the client in an n:1 association with
> >> some server socket is only allowed to send messages to the server i
On 11/11/2015 07:31 PM, Peter Zijlstra wrote:
On Wed, Nov 11, 2015 at 10:11:33AM -0800, Alexei Starovoitov wrote:
On Wed, Nov 11, 2015 at 06:57:41PM +0100, Peter Zijlstra wrote:
On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote:
From: Alexei Starovoitov
Date: Wed, 11 Nov 2015 09:27
On Wed, Nov 11, 2015 at 10:11:33AM -0800, Alexei Starovoitov wrote:
> On Wed, Nov 11, 2015 at 06:57:41PM +0100, Peter Zijlstra wrote:
> > On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote:
> > > From: Alexei Starovoitov
> > > Date: Wed, 11 Nov 2015 09:27:00 -0800
> > >
> > > > BPF_XADD
On Wed, Nov 11, 2015 at 07:31:28PM +0100, Peter Zijlstra wrote:
> > Add new one that does 'fetch_and_add' ? What is the real use case it
> > will be used for?
>
> Look at all the atomic_{add,dec}_return*() users in the kernel. A typical
> example would be a reader-writer lock implementations. See
On Wed, 2015-11-11 at 10:23 -0800, Tom Herbert wrote:
> How about doing this in shutdown called for a listener?
Seems a good idea, I will try it, thanks !
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo in
On Wed, Nov 11, 2015 at 07:31:28PM +0100, Peter Zijlstra wrote:
> > Adding new intrinsic to llvm is not a big deal. I'll add it as soon
> > as I have time to work on it or if somebody beats me to it I would be
> > glad to test it and apply it.
>
> This isn't a speed coding contest. You want to thi
On Wed, Nov 11, 2015 at 10:11:33AM -0800, Alexei Starovoitov wrote:
> On Wed, Nov 11, 2015 at 06:57:41PM +0100, Peter Zijlstra wrote:
> > On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote:
> > > From: Alexei Starovoitov
> > > Date: Wed, 11 Nov 2015 09:27:00 -0800
> > >
> > > > BPF_XADD
David Miller writes:
> From: Måns Rullgård
> Date: Wed, 11 Nov 2015 13:04:07 +
>
>> Måns Rullgård writes:
>>
>>> David Miller writes:
>>>
From: Måns Rullgård
Date: Wed, 11 Nov 2015 00:40:09 +
> When the DMA complete interrupt arrives, the next chain should be
>
On Wed, Nov 11, 2015 at 9:23 AM, Eric Dumazet wrote:
> On Wed, 2015-11-11 at 09:05 -0800, Tom Herbert wrote:
>> On Tue, Nov 10, 2015 at 10:19 PM, Eric Dumazet
>> wrote:
>> > On Tue, 2015-11-10 at 21:41 -0800, Tom Herbert wrote:
>> >> Tolga, are you still planning to respin this patch (when tree
On Wed, Nov 11, 2015 at 06:57:41PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote:
> > From: Alexei Starovoitov
> > Date: Wed, 11 Nov 2015 09:27:00 -0800
> >
> > > BPF_XADD == atomic_add() in kernel. period.
> > > we are not going to deprecate it or in
On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote:
> From: Alexei Starovoitov
> Date: Wed, 11 Nov 2015 09:27:00 -0800
>
> > BPF_XADD == atomic_add() in kernel. period.
> > we are not going to deprecate it or introduce something else.
>
> Agreed, it makes no sense to try and tie C99 or
On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote:
> From: Alexei Starovoitov
> Date: Wed, 11 Nov 2015 09:27:00 -0800
>
> > BPF_XADD == atomic_add() in kernel. period.
> > we are not going to deprecate it or introduce something else.
>
> Agreed, it makes no sense to try and tie C99 or
Hi Rainer,
> +
> +/* Needs sk unix state lock. After recv_ready indicated not ready,
> + * establish peer_wait connection if still needed.
> + */
> +static int unix_dgram_peer_wake_me(struct sock *sk, struct sock *other)
> +{
> + int connected;
> +
> + connected = unix_dgram_peer_wake_conn
From: Alexei Starovoitov
Date: Wed, 11 Nov 2015 09:27:00 -0800
> BPF_XADD == atomic_add() in kernel. period.
> we are not going to deprecate it or introduce something else.
Agreed, it makes no sense to try and tie C99 or whatever atomic
semantics to something that is already clearly defined to h
From: Florian Westphal
nf_hook_list_active() always returns true once at least one device has
NF_INGRESS hook enabled.
Thus, don't use this function. Instead, inverse the test and use the static
key to elide list_empty test if no NF_INGRESS hooks are active.
Signed-off-by: Florian Westphal
Sig
Hello,
I upgraded a machine from 3.14.x to v4.1.x and noted that I now have two
kworker very often on D state, just after boot while I am not doing
anything special. This issue remains indefinitely.
This machine has four network interfaces:
01:00.0 Ethernet controller: Intel Corporation 82576 G
The input and output interfaces in nf_hook_state_init() are flipped.
This fixes iif matching on nftables.
Reported-by: Patrick McHardy
Signed-off-by: Pablo Neira Ayuso
---
include/linux/netfilter_ingress.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/net
From: Jozsef Kadlecsik
When all entries are expired/all slots are empty, release the bucket.
Signed-off-by: Jozsef Kadlecsik
---
net/netfilter/ipset/ip_set_hash_gen.h | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/net/netfilter/ipset/ip_set_hash_gen.h
b/net/
From: Arnd Bergmann
After a recent (correct) change, gcc started warning about the use
of the 'flags' variable in nfulnl_recv_config()
net/netfilter/nfnetlink_log.c: In function 'nfulnl_recv_config':
net/netfilter/nfnetlink_log.c:320:14: warning: 'flags' may be used
uninitialized in this functi
Hi David,
The following patchset contains Netfilter fixes for your net tree. This
large batch that includes fixes for ipset, netfilter ingress, nf_tables
dynamic set instantiation and a longstanding Kconfig dependency problem.
More specifically, they are:
1) Add missing check for empty hook list
With the conversion of the counter expressions to make it percpu, we
need to clone the percpu memory area, otherwise we crash when using
counters from flow tables.
Signed-off-by: Pablo Neira Ayuso
---
include/net/netfilter/nf_tables.h | 16 +++--
net/netfilter/nft_counter.c | 49 ++
From: Arnd Bergmann
Kconfig is too smart for its own good: a Kconfig line that states
select NF_DEFRAG_IPV6 if IP6_NF_IPTABLES
means that if IP6_NF_IPTABLES is set to 'm', then NF_DEFRAG_IPV6 will
also be set to 'm', regardless of the state of the symbol from which
it is selected. When
From: Jozsef Kadlecsik
Incorrect index was used when the data blob was shrinked at expiration,
which could lead to falsely expired entries and memory leak when
the comment extension was used too.
Signed-off-by: Jozsef Kadlecsik
---
net/netfilter/ipset/ip_set_hash_gen.h | 2 +-
1 file changed,
From: Jozsef Kadlecsik
The data extensions in ipset lacked the proper memory alignment and
thus could lead to kernel crash on several architectures. Therefore
the structures have been reorganized and alignment attributes added
where needed. The patch was tested on armv7h by Gerhard Wiesinger and
From: Anthony Lineham
The uninitialized tuple structure caused incorrect hash calculation
and the lookup failed.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=106441
Signed-off-by: Anthony Lineham
Signed-off-by: Pablo Neira Ayuso
---
net/ipv4/netfilter/nf_nat_pptp.c | 2 +-
1 file changed
nf_tables may create percpu counters from the packet path through its
dynamic set instantiation infrastructure, so we need a way to allocate
this through GFP_ATOMIC.
Signed-off-by: Pablo Neira Ayuso
Acked-by: David S. Miller
---
include/linux/netdevice.h | 27 +++
1 file
On Wed, Nov 11, 2015 at 04:23:41PM +, Will Deacon wrote:
>
> If we're going to document it, a bug tracker might be a good place to
> start. The behaviour, as it stands, is broken wrt the definition of the
> __sync primitives. That is, there is no way to build __sync_fetch_and_add
> out of BPF_
On Wed, 2015-11-11 at 09:05 -0800, Tom Herbert wrote:
> On Tue, Nov 10, 2015 at 10:19 PM, Eric Dumazet wrote:
> > On Tue, 2015-11-10 at 21:41 -0800, Tom Herbert wrote:
> >> Tolga, are you still planning to respin this patch (when tree opens?)
> >
> > I was planning to add an union on skc_tx_queue_
On Tue, Nov 10, 2015 at 10:19 PM, Eric Dumazet wrote:
> On Tue, 2015-11-10 at 21:41 -0800, Tom Herbert wrote:
>> Tolga, are you still planning to respin this patch (when tree opens?)
>
> I was planning to add an union on skc_tx_queue_mapping and
> sk_max_ack_backlog, so that adding a check on sk_m
On Wed, 11 Nov 2015 11:57:24 -0500 (EST)
David Miller wrote:
> > I left this last time because Dave usually likes to pick up networking
> > docs patches himself. This wasn't sent to netdev, though, so that's
> > unlikely to happen. I've gone ahead and applied it, since it seems
> > clearly corr
From: Jonathan Corbet
Date: Wed, 11 Nov 2015 09:50:02 -0700
> On Mon, 9 Nov 2015 14:58:49 +0100
> Niklas Cassel wrote:
>
>> Commit c39c4c6abb89 ("tcp: double default TSQ output bytes limit")
>> updated default value for tcp_limit_output_bytes
>
> I left this last time because Dave usually like
Begin forwarded message:
Date: Wed, 4 Nov 2015 10:46:56 +
From: "bugzilla-dae...@bugzilla.kernel.org"
To: "shemmin...@linux-foundation.org"
Subject: [Bug 107141] New: [1177853.192071] INFO: task accel-pppd:24263 blocked
for more than 120 seconds.
https://bugzilla.kernel.org/show_bug.cg
1 - 100 of 150 matches
Mail list logo
