From: Markus Elfring
Date: Fri, 6 Nov 2015 08:48:23 +0100
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
d
On Tue, Sep 29, 2015 at 6:12 PM, Anand Gurram
wrote:
> Any additional ideas and suggestions on debugging in above scenario?
You may give a try with the recent patch:
packet: race condition in packet_bind
http://www.spinics.net/lists/netdev/msg351337.html
--
William
--
To unsubscribe from this l
On Thu, Nov 5, 2015 at 7:52 PM, Jason A. Donenfeld wrote:
> Hi folks,
>
> When sending arbitrary SKBs with udp_tunnel_xmit_skb, the networking
> stack does not appear to be utilizing UFO on the outgoing UDP packets,
> which significantly caps the transmission speed. I see about 50% CPU
> usage in
From: Markus Elfring
Date: Fri, 6 Nov 2015 08:00:22 +0100
The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
driver
This patch fixes the RGMII 10/100M mode by reprogramming the clock.
Signed-off-by: Iyappan Subramanian
Tested-by: Fushen Chen
---
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 49 +++-
drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | 1 +
drivers/net/ethernet/apm/xge
On Fri, Nov 06, 2015 at 02:31:59AM +0100, Jason A. Donenfeld wrote:
>
> So far implementing (3) is failing miserably. Is there anything wrong
> with my general idea that might make this a priori impossible? For
> example, will udp_tunnel_xmit_skb not accept super-packets? Or, am I
> just not makin
Hi folks,
I'm still facing some considerable problems. Please see below.
On Thu, Nov 5, 2015 at 5:28 PM, Jason A. Donenfeld wrote:
> As mentioned, I receive packets on ndo_start_xmit, "do something to
> them with function magic()", and then push them out of a UDP socket
> using udp_tunnel_xmit_s
OK, wow, this list is super high traffic. I'm going to unsubscribe now.
Feel free to get in contact with me directly (not via the list) if you like.
It'd be lovely if someone wants to fix the regression I reported,
especially as it looks pretty simple to achieve. (Just don't silently fail
if you
On 11/05/2015 05:17 PM, Eric Dumazet wrote:
On Thu, 2015-11-05 at 13:56 +0100, Daniel Borkmann wrote:
On 11/05/2015 12:38 PM, Eric Dumazet wrote:
If I am not mistaken, af_packet also lacks the ability to properly set
skb->protocol
I noticed this using trafgen on a bonding device, when I did
On Thu, Nov 05, 2015 at 03:55:22PM -0500, Johannes Weiner wrote:
> On Thu, Nov 05, 2015 at 03:40:02PM +0100, Michal Hocko wrote:
> > This would be true if they moved on to the new cgroup API intentionally.
> > The reality is more complicated though. AFAIK sysmted is waiting for
> > cgroup2 already
On Thu, Nov 05, 2015 at 05:28:03PM +0100, Michal Hocko wrote:
> On Thu 05-11-15 11:16:09, David S. Miller wrote:
> > From: Michal Hocko
> > Date: Thu, 5 Nov 2015 15:40:02 +0100
> >
> > > On Wed 04-11-15 14:50:37, Johannes Weiner wrote:
> > > [...]
> > >> Because it goes without saying that once t
On Thu, 5 Nov 2015, Joe Perches wrote:
> On Thu, 2015-11-05 at 20:38 +0100, Julia Lawall wrote:
> > On Thu, 5 Nov 2015, David Miller wrote:
> > > From: Julia Lawall
> > > Date: Thu, 5 Nov 2015 11:18:16 +0100>
> > > > Move the variable declarations from the for_nexthops macro to the
> > > > su
On Thu, 2015-11-05 at 20:38 +0100, Julia Lawall wrote:
> On Thu, 5 Nov 2015, David Miller wrote:
> > From: Julia Lawall
> > Date: Thu, 5 Nov 2015 11:18:16 +0100>
> > > Move the variable declarations from the for_nexthops macro to the
> > > surrounding context, so that it is clear where these var
From: Eric Dumazet
Date: Thu, 05 Nov 2015 13:39:24 -0800
> From: Eric Dumazet
>
> In commit e446f9dfe17b ("net: synack packets can be attached to request
> sockets"), I missed one remaining case of invalid skb->sk->sk_security
> access.
>
> Dmitry Vyukov got a KASan report pointing to it.
>
>
From: Eric Dumazet
In commit e446f9dfe17b ("net: synack packets can be attached to request
sockets"), I missed one remaining case of invalid skb->sk->sk_security
access.
Dmitry Vyukov got a KASan report pointing to it.
Add selinux_skb_sk() helper that is responsible to get back to the
listener
From: Michael Chan
Date: Thu, 5 Nov 2015 16:25:46 -0500
> Miscellaneous small bug fixes.
This looks fine, series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.
While reading through net-code i came across some code in tcp_sendpage which i
think
it is not working in the intended way all tie time. But as this code is at that
a
central place and pretty old, im suspicious if my analysis is really right.
The code in question is this
(from net/ipv4/tcp.c)
From: Jeffrey Huang
In order to use offset 0x4014 for reading CAG interrupt status,
the actual CAG register must be mapped to GRC bar0 window #4.
Otherwise, the driver is reading garbage. This patch corrects
this issue.
Signed-off-by: Jeffrey Huang
Signed-off-by: Michael Chan
---
drivers/net/
Assign the return value from bitmap_find_free_region() to an integer
variable and check for negative error codes first, before assigning
the bit ID to the unsigned sw_id field.
Reported-by: Dan Carpenter
Cc: Dan Carpenter
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.
The profile ID in the completion record needs to be ANDed with the
profile ID mask of 0x1f. This bug was causing the SKB hash type
and the gso_type to be wrong in some cases.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 12 +++-
1 file changed, 7 insertion
Miscellaneous small bug fixes.
Michael Chan (5):
bnxt_en: Change sp events definitions to represent bit position.
bnxt_en: Determine tcp/ipv6 RSS hash type correctly.
bnxt_en: map CAG_REG_LEGACY_INT_STATUS_MASK to GRC window #4
bnxt_en: Fix comparison of u16 sw_id against negative value.
From: Jeffrey Huang
Instead of always calling pci_sriov_disable() in remove_one(),
the driver should detect whether VFs are currently assigned
to the VMs. If the VFs are active in VMs, then it should not
disable SRIOV as it is catastrophic to the VMs. Instead,
it just leaves the VFs alone and con
From: Jeffrey Huang
Fix the sp event bits to be bit positions instead of bit values since
the bit helper functions are expecting the former.
Signed-off-by: Jeffrey Huang
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 10 +-
1 file changed, 5 insertions(+),
Hi Francesco,
On Thu, Nov 5, 2015 at 5:16 PM, Francesco Ruggeri
wrote:
> There is a race conditions between packet_notifier and packet_bind{_spkt}.
>
> It happens if packet_notifier(NETDEV_UNREGISTER) executes between the
> time packet_bind{_spkt} takes a reference on the new netdevice and the
>
From: Eric Dumazet
Date: Thu, 05 Nov 2015 12:50:19 -0800
> From: Eric Dumazet
>
> I mistakenly took wrong request sock pointer when calling tcp_move_syn()
>
> @req_unhash is either a copy of @req, or a NULL value for
> FastOpen connexions (as we do not expect to unhash the temporary
> request
From: Florian Fainelli
Date: Tue, 03 Nov 2015 15:44:14 -0800
> On 29/10/15 18:11, Florian Fainelli wrote:
>> The EPHY on GENET v1->v3 is extremely finicky, and will show occasional
>> failures based on the timing and reset sequence, ranging from duplicate
>> packets, to extremely high latencies.
On Thu, Nov 05, 2015 at 03:40:02PM +0100, Michal Hocko wrote:
> On Wed 04-11-15 14:50:37, Johannes Weiner wrote:
> [...]
> > Because it goes without saying that once the cgroupv2 interface is
> > released, and people use it in production, there is no way we can then
> > *add* dentry cache, inode ca
From: Eric Dumazet
I mistakenly took wrong request sock pointer when calling tcp_move_syn()
@req_unhash is either a copy of @req, or a NULL value for
FastOpen connexions (as we do not expect to unhash the temporary
request sock from ehash table)
Fixes: 805c4bc05705 ("tcp: fix req->saved_syn rac
On Thu, 2015-11-05 at 11:07 -0800, Eric Dumazet wrote:
> From: Eric Dumazet
>
> For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix
> ireq->pktopts race"), we need to make sure we do not access
> req->saved_syn unless we own the request sock.
>
> This fixes races for listeners using
On 11/05/2015 03:12 PM, David Miller wrote:
> From: Sasha Levin
> Date: Thu, 5 Nov 2015 15:07:44 -0500
>
>> > The current implementation used a bitfield with a corresponding array to
>> > manage assignment of call ids. Rather than open-coding it, use IDR for
>> > this.
>> >
>> > Signed-off-by:
From: Julia Lawall
Date: Thu, 5 Nov 2015 21:08:17 +0100 (CET)
> On Thu, 5 Nov 2015, David Miller wrote:
>
>> From: Julia Lawall
>> Date: Thu, 5 Nov 2015 11:18:16 +0100
>>
>> > Move the variable declarations from the for_nexthops macro to the
>> > surrounding context, so that it is clear where
From: Sasha Levin
Date: Thu, 5 Nov 2015 15:07:44 -0500
> The current implementation used a bitfield with a corresponding array to
> manage assignment of call ids. Rather than open-coding it, use IDR for
> this.
>
> Signed-off-by: Sasha Levin
Please resubmit this when the net-next tree opens b
On Thu, 5 Nov 2015, David Miller wrote:
> From: Julia Lawall
> Date: Thu, 5 Nov 2015 11:18:16 +0100
>
> > Move the variable declarations from the for_nexthops macro to the
> > surrounding context, so that it is clear where these variables are
> > declared. This also makes it possible to remove
The current implementation used a bitfield with a corresponding array to
manage assignment of call ids. Rather than open-coding it, use IDR for
this.
Signed-off-by: Sasha Levin
---
drivers/net/ppp/pptp.c | 67 +---
1 file changed, 29 insertions(+), 3
I found recently that, if I disabled address promotion in the kernel, that
ip addr flush dev
would fail with an EADDRNOTAVAIL errno (though the flush operation would in fact
flush all addresses from an interface properly)
Whats happening is that, if I add a primary and multiple secondary address
From: frugg...@aristanetworks.com (Francesco Ruggeri)
Date: Thu, 05 Nov 2015 08:16:14 -0800
> There is a race conditions between packet_notifier and packet_bind{_spkt}.
>
> It happens if packet_notifier(NETDEV_UNREGISTER) executes between the
> time packet_bind{_spkt} takes a reference on the new
On Thu, 2015-11-05 at 20:36 +0100, Dmitry Vyukov wrote:
> Hello,
>
> I've updated from bcee19f424a0d8c26ecf2607b73c690802658b29 (Sep 21) to
> 8e483ed1342a4ea45b70f0f33ac54eff7a33d918 (Nov 4) and start seeing the
> following use-after-free reports:
>
Thanks for your report, I will add a followup
On Thu, 5 Nov 2015, David Miller wrote:
> From: Julia Lawall
> Date: Thu, 5 Nov 2015 11:18:16 +0100
>
> > Move the variable declarations from the for_nexthops macro to the
> > surrounding context, so that it is clear where these variables are
> > declared. This also makes it possible to remove
Hello,
I've updated from bcee19f424a0d8c26ecf2607b73c690802658b29 (Sep 21) to
8e483ed1342a4ea45b70f0f33ac54eff7a33d918 (Nov 4) and start seeing the
following use-after-free reports:
BUG: KASan: use after free in selinux_ip_postroute_compat+0x2af/0x2d0
at addr 88003dbdc148
Read of size 8 by t
From: Eric Dumazet
Date: Thu, 05 Nov 2015 11:07:13 -0800
> From: Eric Dumazet
>
> For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix
> ireq->pktopts race"), we need to make sure we do not access
> req->saved_syn unless we own the request sock.
>
> This fixes races for listeners u
From: Eric Dumazet
Date: Thu, 05 Nov 2015 11:34:06 -0800
> From: Eric Dumazet
>
> Before converting a 'socket pointer' into inet socket,
> use sk_fullsock() to detect timewait or request sockets.
>
> Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead
> of listener")
V20: Added attribute parsing of inner vlan to consolidated vlan parsing fn.
Added vport vlan mtu size changes to vport from vport-netdev.c in V18. All
changes are in Pacch 3 of the series. Patches 1 and 2 have already been
acked to V18 submission.
V19: Rebased to latest net-next 4.3.0-rc6+
commit
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
vport has vlan mtu adjustm
This is to simplify using double tagged vlans. This function allows all
valid vlan ethertypes to be checked in a single function call.
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b/inclu
From: Eric Dumazet
Before converting a 'socket pointer' into inet socket,
use sk_fullsock() to detect timewait or request sockets.
Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of
listener")
Signed-off-by: Eric Dumazet
Reported-by: Dmitry Vyukov
Tested-by: Dmitr
On Thu, Nov 5, 2015 at 8:31 PM, David Miller wrote:
> From: Andy Shevchenko
> Date: Thu, 5 Nov 2015 20:13:21 +0200
>
>> What about
>>
>> if (!addr)
>> return -ENODATA;
>
> I totally disagree. of_get_phy_mode() and other similar attribute
> probing mechanisms use -ENODEV.
Okay, then just
if (!a
+netdev, lkml
Adding public lists as requested.
Below is a use-after-free report in ipv4_conntrack_defrag and a fix from Eric.
On Thu, Nov 5, 2015 at 7:57 PM, Eric Dumazet wrote:
> On Thu, Nov 5, 2015 at 10:33 AM, Dmitry Vyukov wrote:
>> Hello,
>>
>> I've updated from bcee19f424a0d8c26ecf2607b
From: Julia Lawall
Date: Thu, 5 Nov 2015 11:18:16 +0100
> Move the variable declarations from the for_nexthops macro to the
> surrounding context, so that it is clear where these variables are
> declared. This also makes it possible to remove the endfor_nexthops macro.
>
> This change adds new
From: LABBE Corentin
Date: Thu, 5 Nov 2015 10:26:46 +0100
> The variable phy_iface is double-initialized to itself.
> This patch remove that.
>
> Reported-by: coverity (CID 1271141)
> Signed-off-by: LABBE Corentin
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" i
From: Eric Dumazet
For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix
ireq->pktopts race"), we need to make sure we do not access
req->saved_syn unless we own the request sock.
This fixes races for listeners using TCP_SAVE_SYN option.
Fixes: e994b2f0fb92 ("tcp: do not lock listene
On Thu, Nov 05, 2015 at 01:29:15PM -0500, David Miller wrote:
> From: Sergei Shtylyov
> Date: Thu, 5 Nov 2015 20:19:17 +0300
>
> >Hmm, I hadn't seen your announcement, else I would have refrained from
> >sending. Will look for it now...
>
> I really don't know how to better get pe
From: Dan Carpenter
Date: Thu, 5 Nov 2015 11:41:28 +0300
> We accidentally return success instead of -ENOMEM here.
>
> Fixes: fe56b9e6a8d9 ('qed: Add module with basic common support')
> Signed-off-by: Dan Carpenter
Applied, thanks Dan.
--
To unsubscribe from this list: send the line "unsubscr
On 11/05/2015 09:29 PM, David Miller wrote:
Hmm, I hadn't seen your announcement, else I would have refrained from
sending. Will look for it now...
I really don't know how to better get people's attention than this:
http://marc.info/?l=linux-netdev&m=144652382428132&w=2
U
From: Vivien Didelot
Date: Wed, 4 Nov 2015 17:23:40 -0500
> The DSA documentation specifies that each port must be capable of
> forwarding frames to the CPU port. The last changes on bridging support
> for the mv88e6xxx driver broke this requirement for non-bridged ports.
>
> So as for the brid
From: Andy Shevchenko
Date: Thu, 5 Nov 2015 20:13:21 +0200
> What about
>
> if (!addr)
> return -ENODATA;
I totally disagree. of_get_phy_mode() and other similar attribute
probing mechanisms use -ENODEV.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a mes
From: Sergei Shtylyov
Date: Thu, 5 Nov 2015 20:19:17 +0300
>Hmm, I hadn't seen your announcement, else I would have refrained from
>sending. Will look for it now...
I really don't know how to better get people's attention than this:
http://marc.info/?l=linux-netdev&m=14465238242
On Thu, Nov 5, 2015 at 6:05 PM, David Miller wrote:
> From: David Miller
> Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST)
>
>> I'll see if I can cook something up.
>
> How does this look?
I like it, though couple of style related comments.
>
>
> net: Add eth_platform_get_mac_a
On 11/05/2015 08:19 PM, Sergei Shtylyov wrote:
You guys really make an enormous amount of work and stress for me when you
submit net-next patches when I _CLEARLY_ and _EXPLICITLY_ state that the
tree is closed right now.
Hmm, I hadn't seen your announcement, else I would have refrained fro
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, November 05, 2015 8:29 AM
>
> From: Sowmini Varadhan
> Date: Thu, 5 Nov 2015 11:28:31 -0500
>
> > On (11/05/15 11:05), David Miller wrote:
> >> From: David Miller
> >> Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST)
> >>
> >> > I'l
Hello.
On 11/05/2015 07:13 PM, David Miller wrote:
While the ring allocation is done by a single function,
sh_eth_ring_init(),
the ring deallocation was split into two functions (almost always
called
one after the other) for no good reason. Merge
sh_eth_free_dma_buffer()
into sh_eth_ring_free()
On (11/05/15 11:29), David Miller wrote:
>
> The intention is to let your patch go in as-is, then try and update
> ixgbe/i40e later in net-next or similar.
Sounds good, I can take care of ixgbe/i40e after that happens.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
From: Petr Štetiar
Date: Thu, 5 Nov 2015 12:55:01 +0100
> This device has same vendor and product IDs as G2K devices, but it has
> different number of interfaces(4 vs 5) and also different interface
> layout where EC20 has QMI on interface 4 instead of 0.
>
> lsusb output:
...
> Signed-off-by:
From: Johan Hedberg
Date: Thu, 5 Nov 2015 08:19:29 +0200
> The following set of Bluetooth patches would be good to get into 4.4-rc1
> if possible:
>
> - Fix for missing LE CoC parameter validity checks
> - Fix for potential deadlock in btusb
> - Fix for issuing unsupported commands during HCI
From: Michal Hocko
Date: Thu, 5 Nov 2015 17:28:03 +0100
> Yes, that part is clear and Johannes made it clear that the kmem tcp
> part is disabled by default. Or are you considering also all the slab
> usage by the networking code as well?
I'm still thinking about the implications of that aspect,
On (11/05/15 11:05), David Miller wrote:
> From: David Miller
> Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST)
>
> > I'll see if I can cook something up.
>
> How does this look?
Looks good to me,
Do you want me to respin patch v7 with this? Or update ixgbe/i40e to use
this later, after this goes
From: Sowmini Varadhan
Date: Thu, 5 Nov 2015 11:28:31 -0500
> On (11/05/15 11:05), David Miller wrote:
>> From: David Miller
>> Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST)
>>
>> > I'll see if I can cook something up.
>>
>> How does this look?
>
> Looks good to me,
>
> Do you want me to respi
On Thu, Nov 5, 2015 at 4:56 PM, Eric Dumazet wrote:
> It is a performance benefit only if you use the helpers from
> net/core/tso.c as some drivers already do.
>
> Otherwise, calling the skb_gso_segment() from your driver has no gain
> compared to the one done from core networking stack.
Interest
On Thu 05-11-15 11:16:09, David S. Miller wrote:
> From: Michal Hocko
> Date: Thu, 5 Nov 2015 15:40:02 +0100
>
> > On Wed 04-11-15 14:50:37, Johannes Weiner wrote:
> > [...]
> >> Because it goes without saying that once the cgroupv2 interface is
> >> released, and people use it in production, the
There is a race conditions between packet_notifier and packet_bind{_spkt}.
It happens if packet_notifier(NETDEV_UNREGISTER) executes between the
time packet_bind{_spkt} takes a reference on the new netdevice and the
time packet_do_bind sets po->ifindex.
In this case the notification can be missed.
From: Michal Hocko
Date: Thu, 5 Nov 2015 15:40:02 +0100
> On Wed 04-11-15 14:50:37, Johannes Weiner wrote:
> [...]
>> Because it goes without saying that once the cgroupv2 interface is
>> released, and people use it in production, there is no way we can then
>> *add* dentry cache, inode cache, an
On Thu, 2015-11-05 at 13:56 +0100, Daniel Borkmann wrote:
> On 11/05/2015 12:38 PM, Eric Dumazet wrote:
> > If I am not mistaken, af_packet also lacks the ability to properly set
> > skb->protocol
> >
> > I noticed this using trafgen on a bonding device, when I did my SYNFLOOD
> > tests for TCP li
From: Sergei Shtylyov
Date: Thu, 5 Nov 2015 15:53:24 +0300
> Hello.
>
> On 11/5/2015 4:59 AM, David Miller wrote:
>
>>> While the ring allocation is done by a single function,
>>> sh_eth_ring_init(),
>>> the ring deallocation was split into two functions (almost always
>>> called
>>> one after
From: David Miller
Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST)
> I'll see if I can cook something up.
How does this look?
net: Add eth_platform_get_mac_address() helper.
A repeating pattern in drivers has become to use OF node information
and, if not found, platform specif
On Thu, 2015-11-05 at 16:00 +0100, Jason A. Donenfeld wrote:
> Right -- I saw the expansion in the header file -- it gets the various
> TSOs plus UFO. So what this means is that the packet hasn't yet been
> split up? So were I to add this option, then my driver would have to
> be responsible for s
From: Guy Harris
Date: Thu, 5 Nov 2015 00:14:51 -0800
> As a core libpcap developer, I will at least state that it works a
> *lot* better than v1 and v2 did. Having buffer slots that can hold
> only one packet is *really* suboptimal for packet capture; having
> buffer slots that can hold multipl
From: Sowmini Varadhan
Date: Wed, 4 Nov 2015 18:21:00 -0500
> This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC
> address in Open Firmware or IDPROM").
>
> As with that fix, attempt to look up the MAC address in Open Firmware
> on systems that support it, and use IDPROM on
Hi Herbert,
Thanks for your response!
On Thu, Nov 5, 2015 at 1:15 PM, Herbert Xu wrote:
> The NETIF_F_GSO flag turns on software GSO which should be on
> anyway. So that could be why it seems to make no difference.
GSO is on by default? That makes sense, okay.
>
> NETIF_F_GSO_SOFTWARE is actu
On Wed 04-11-15 14:50:37, Johannes Weiner wrote:
[...]
> Because it goes without saying that once the cgroupv2 interface is
> released, and people use it in production, there is no way we can then
> *add* dentry cache, inode cache, and others to memory.current. That
> would be an unacceptable chang
Hello,
On Tue, Nov 3, 2015, at 15:00, Florian Weimer wrote:
> On 11/03/2015 02:48 PM, Hannes Frederic Sowa wrote:
> > Hello,
> >
> > On Fri, Oct 23, 2015, at 21:07, Florian Weimer wrote:
> >> (By the way, we'd also love to have a better kernel interface to fulfill
> >> the needs for getaddrinfo a
Petr Štetiar writes:
> This device has same vendor and product IDs as G2K devices, but it has
> different number of interfaces(4 vs 5) and also different interface
> layout where EC20 has QMI on interface 4 instead of 0.
>
> lsusb output:
>
> Bus 002 Device 003: ID 05c6:9215 Qualcomm, Inc.
This patch fix the following warnings:
- braces {} should be used on all arms of this statement
- Prefer seq_puts to seq_printf
- No space is necessary after a cast
- Missing a blank line after declarations
- Please don't use multiple blank lines
- Comparison to NULL could be written
- networking b
Now that stmmac use netdev_xxx, some __func__ are not necessary since their
use was to clearly identify which driver was logging.
Moreover, as pointed by Joe Perches, using __func__ in xxx_dbg functions
is relatively low value and dynamic debug can add it.
This patch remove __func__ where such pri
As sugested by Joe Perches, we could replace all
if (netif_msg_type(priv)) dev_xxx(priv->devices, ...)
by the simplier macro netif_xxx(priv, hw, priv->dev, ...)
Signed-off-by: LABBE Corentin
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 58 ++-
1 file changed, 25 in
Some printing have the function name hardcoded.
It is better to use __func__ instead.
Signed-off-by: LABBE Corentin
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
b
Hello
This patch series try to improve logging of the stmmac driver.
Changes since v3
- Fix a missing comma for letting patch to be used atomaticly.
Changes since v2
- Rollback to dev_ for some early init printing
- rebased on 4.4-rc1
Changes since v1
- Use netdev_xxx instead of dev_xxx
- Use n
The stmmac driver use lots of pr_xxx functions to print information.
This is bad since we cannot know which device logs the information.
(moreover if two stmmac device are present)
Furthermore, it seems that it assumes wrongly that all logs will always
be subsequent by using a dev_xxx then some in
On 11/05/2015 12:38 PM, Eric Dumazet wrote:
On Thu, 2015-11-05 at 10:39 +0100, Daniel Borkmann wrote:
On 11/05/2015 10:07 AM, Arnd Bergmann wrote:
On Thursday 05 November 2015 00:04:14 David Miller wrote:
As part of fixing y2038 problems, Arnd is going to have to make a new
version fo the AF_P
Hello.
On 11/5/2015 4:59 AM, David Miller wrote:
While the ring allocation is done by a single function, sh_eth_ring_init(),
the ring deallocation was split into two functions (almost always called
one after the other) for no good reason. Merge sh_eth_free_dma_buffer()
into sh_eth_ring_free()
On Thu, Nov 05, 2015 at 06:58:17PM +0800, kbuild test robot wrote:
> Hi LABBE,
>
> [auto build test ERROR on: net/master]
> [also build test ERROR on: v4.3 next-20151105]
>
> url:
> https://github.com/0day-ci/linux/commits/LABBE-Corentin/stmmac-replace-all-pr_xx
On Wed, Nov 04, 2015 at 12:24:47PM +0100, Jason A. Donenfeld wrote:
>
> Strangely, the performance does not change at all regardless of
> whether or not NETIF_F_GSO is specified.
The NETIF_F_GSO flag turns on software GSO which should be on
anyway. So that could be why it seems to make no differ
This device has same vendor and product IDs as G2K devices, but it has
different number of interfaces(4 vs 5) and also different interface
layout where EC20 has QMI on interface 4 instead of 0.
lsusb output:
Bus 002 Device 003: ID 05c6:9215 Qualcomm, Inc. Acer Gobi 2000
Device Des
On Thu, 2015-11-05 at 10:39 +0100, Daniel Borkmann wrote:
> On 11/05/2015 10:07 AM, Arnd Bergmann wrote:
> > On Thursday 05 November 2015 00:04:14 David Miller wrote:
> >> As part of fixing y2038 problems, Arnd is going to have to make a new
> >> version fo the AF_PACKET mmap() tpacker descriptors
Hi LABBE,
[auto build test ERROR on: net/master]
[also build test ERROR on: v4.3 next-20151105]
url:
https://github.com/0day-ci/linux/commits/LABBE-Corentin/stmmac-replace-all-pr_xxx-by-their-netdev_xxx-counterpart/20151105-163344
config: m68k-allyesconfig (attached as .config)
reproduce
Hi folks,
When sending arbitrary SKBs with udp_tunnel_xmit_skb, the networking
stack does not appear to be utilizing UFO on the outgoing UDP packets,
which significantly caps the transmission speed. I see about 50% CPU
usage in this send path, triggered for every single outgoing packet.
Is there a
Move the variable declarations from the for_nexthops macro to the
surrounding context, so that it is clear where these variables are
declared. This also makes it possible to remove the endfor_nexthops macro.
This change adds new arguments to the macro for_nexthops. They are ordered
such that a p
bnx2x: Don't notify about scratchpad parities
This is a (trivial) "backport" of ad6afbe9578d1fa26680faf78c846bd8c00d1d6e to
stable kernel 3.14.56.
Original commit message:
The scratchpad is a shared block between all functions of a given device.
Due to HW limitations, we can't properly close it
On 11/05/2015 10:07 AM, Arnd Bergmann wrote:
On Thursday 05 November 2015 00:04:14 David Miller wrote:
As part of fixing y2038 problems, Arnd is going to have to make a new
version fo the AF_PACKET mmap() tpacker descriptors in order to extend
the time values to 64-bit.
So I want everyone to th
The variable phy_iface is double-initialized to itself.
This patch remove that.
Reported-by: coverity (CID 1271141)
Signed-off-by: LABBE Corentin
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/st
Hello,
On Thu, 5 Nov 2015, Johannes Berg wrote:
> From: Johannes Berg
>
> In order to solve a problem with 802.11, the so-called hole-196 attack,
> add an option (sysctl) called "drop_unicast_in_l2_multicast" which, if
> enabled, causes the stack to drop IPv4 unicast packets encapsulat
1 - 100 of 117 matches
Mail list logo
