Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

于 2015/10/23 23:12, Peter Zijlstra 写道: > On Fri, Oct 23, 2015 at 02:52:11PM +0200, Peter Zijlstra wrote: >> On Thu, Oct 22, 2015 at 06:28:22PM +0800, Wangnan (F) wrote: >>> information to analysis when glitch happen. Another way we are trying to >>> implement >>> now is to dynamically turn events o

stmmac: Reporting ethtool_ts_info

G'day All, The stmmac driver checks (priv->hwts_tx_en) && (priv->hwts_rx_en) before reporting WHTSTAMP capabilities. No other driver seems to do this. hwts_*_en indicate if timestamping is enabled, not if the interface is capable of it. Instead they check there capabilities. Which would be (pr

Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

> + > +static struct ethtool_ops nb8800_ethtool_ops = { Ops should be const > + .get_settings = nb8800_get_settings, > + .set_settings = nb8800_set_settings, > + .nway_reset = nb8800_nway_reset, > + .get_link = ethtool_op_get_link, > +

Re: [PATCH v1 1/3] virtio-net: Using single MSIX IRQ for TX/RX Q pair

On 10/27/2015 01:52 AM, Ravi Kerur wrote: > Ported earlier patch from Jason Wang (dated 12/26/2014). > > This patch tries to reduce the number of MSIX irqs required for > virtio-net by sharing a MSIX irq for each TX/RX queue pair through > channels. If transport support channel, about half of the

Re: [PATCH v3] net: tso: add support for IPv6

From: Emmanuel Grumbach Date: Mon, 26 Oct 2015 10:31:29 +0200 > Adding IPv6 for the TSO helper API is trivial: > * Don't play with the id (which doesn't exist in IPv6) > * Correctly update the payload_len (don't include the > length of the IP header itself) > > Signed-off-by: Emmanuel Grumbach

Re: [GIT PULL v2] ARCNET: code simplification and features

From: Michael Grzeschik Date: Mon, 26 Oct 2015 09:23:14 +0100 > This series includes code simplifaction. The main changes are the correct > xceiver handling (enable/disable) of the com20020 cards. The driver now > handles > link status change detection. The EAE PCI-ARCNET cards now make use of t

Re: [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event

On Mon, Oct 26, 2015 at 11:59:13PM +0200, Julian Anastasov wrote: > When nexthop is part of multipath route we should clear the > LINKDOWN flag when link goes UP or when first address is added. > This is needed because we always set LINKDOWN flag when DEAD flag > was set but now on UP the nexthop i

Re: [PATCH 0/8] add missing of_node_put

From: Julia Lawall Date: Sun, 25 Oct 2015 14:56:59 +0100 > The various for_each device_node iterators performs an of_node_get on each > iteration, so a break out of the loop requires an of_node_put. > > The complete semantic patch that fixes this problem is > (http://coccinelle.lip6.fr): ... S

Re: [PATCH] ipv6 route: Use flag instead of calling fib6_get_table() twice

From: Masashi Honma Date: Sun, 25 Oct 2015 11:44:27 +0900 > The fib6_get_table() is called twice to show the warning. > This patch reduces calling the function. > > Signed-off-by: Masashi Honma I think the added cost of passing a reference to an on-stack variable exceeds the value of whatever

Re: [PATCH net] ipv6: gre: support SIT encapsulation

From: Eric Dumazet Date: Sat, 24 Oct 2015 05:47:44 -0700 > From: Eric Dumazet > > gre_gso_segment() chokes if SIT frames were aggregated by GRO engine. > > Fixes: 61c1db7fae21e ("ipv6: sit: add GSO/TSO support") > Signed-off-by: Eric Dumazet Applied and queued up for -stable, thanks Eric. --

Re: [PATCH net-next] ipv6: icmp: include addresses in debug messages

From: Bjørn Mork Date: Sat, 24 Oct 2015 14:00:20 +0200 > Messages like "icmp6_send: no reply to icmp error" are close > to useless. Adding source and destination addresses to provide > some more clue. > > Signed-off-by: Bjørn Mork This is fine, applied, thanks. -- To unsubscribe from this list

Re: [PATCH net-next] bpf: make tracing helpers gpl only

From: Alexei Starovoitov Date: Fri, 23 Oct 2015 14:58:19 -0700 > exported perf symbols are GPL only, mark eBPF helper functions > used in tracing as GPL only as well. > > Suggested-by: Peter Zijlstra > Signed-off-by: Alexei Starovoitov Applied. -- To unsubscribe from this list: send the line

Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

From: Alexei Starovoitov Date: Thu, 22 Oct 2015 17:10:14 -0700 > Fix safety checks for bpf_perf_event_read(): > - only non-inherited events can be added to perf_event_array map > (do this check statically at map insertion time) > - dynamically check that event is local and !pmu->count > Otherwi

Re: [PATCH net-next] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

Hi Roopa, [auto build test ERROR on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Roopa-Prabhu/bridge-set-is_local-and-is_static-before-fdb-entry-is-added-to-the-fdb-hashtable/20151027-1

[PATCH net-next] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

From: Roopa Prabhu Problem Description: We can add fdbs pointing to the bridge with NULL ->dst but that has a few race conditions because br_fdb_insert() is used which first creates the fdb and then, after the fdb has been published/linked, sets "is_local" to 1 and in that time frame if a packet

Re: [PATCH net-next] seccomp, ptrace: add support for dumping seccomp filters

On Tue, Oct 27, 2015 at 09:23:59AM +0900, Tycho Andersen wrote: > This patch adds support for dumping a process' (classic BPF) seccomp > filters via ptrace. > > PTRACE_SECCOMP_GET_FILTER allows the tracer to dump the user's classic BPF > seccomp filters. addr should be an integer which represents

Re: [PATCH] bpf: sample: define aarch64 specific registers

On Mon, Oct 26, 2015 at 05:02:19PM -0700, Yang Shi wrote: > Define aarch64 specific registers for building bpf samples correctly. > > Signed-off-by: Yang Shi looks good to me. Acked-by: Alexei Starovoitov -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mes

Re: [PATCH net] macvtap: unbreak receiving of gro skb with frag list

On 10/26/2015 04:30 PM, Michael S. Tsirkin wrote: > On Mon, Oct 26, 2015 at 02:53:38PM +0800, Jason Wang wrote: >> >> On 10/26/2015 02:09 PM, Michael S. Tsirkin wrote: >>> On Mon, Oct 26, 2015 at 11:15:57AM +0800, Jason Wang wrote: On 10/23/2015 09:37 PM, Michael S. Tsirkin wrote: > On F

Re: [PATCH net-next V18 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

On Sun, Oct 25, 2015 at 5:11 PM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double > tagged vlan. Inner TPID encode

Re: [PATCH net] ipv4: fix problems from the RTNH_F_LINKDOWN introduction

On Mon, Oct 26, 2015 at 11:15:57PM +0200, Julian Anastasov wrote: > > Hello, > > On Mon, 26 Oct 2015, Andy Gospodarek wrote: > > > On Sat, Oct 24, 2015 at 09:20:00PM +0300, Julian Anastasov wrote: > > > When fib_netdev_event calls fib_disable_ip on NETDEV_DOWN event > > > we should not del

Re: [PATCH 0/2] sh_eth: RX buffer alignment fixes

From: Sergei Shtylyov Date: Sat, 24 Oct 2015 00:44:27 +0300 >Here's a set of 2 patches against DaveM's 'net.git' repo which are the > fixes > to the RX buffer size calculation. > > [1/2] sh_eth: fix RX buffer size alignment > [2/2] sh_eth: fix RX buffer size calculation Series applied, tha

Re: [PATCH net-next] net: dsa: bcm_sf2: Unhardcode port numbers

From: Florian Fainelli Date: Fri, 23 Oct 2015 12:11:08 -0700 > While the current driver mostly supports BCM7445 which has a hardcoded > location for its MoCA port on port 7 and port 0 for its internal PHY, > this is not necessarily true for all other chips out there such as > BCM3390 for instance

Re: [PATCH 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs

From: Jakub Kicinski Date: Fri, 23 Oct 2015 19:58:11 +0100 > +struct nfp_net_tx_buf { > + struct sk_buff *skb; > + dma_addr_t dma_addr; > + short int fidx; > + u16 pkt_cnt; > + u32 real_len; > +}; This packs very poorly, and has a lot of padding holes. Better ordering would

Re: [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

From: Florian Fainelli Date: Fri, 23 Oct 2015 11:38:07 -0700 > Add support for the FDB add, delete, and dump operations. The add and > delete operations are implemented using directed ARL operations using > the specified MAC address and consist in a read operation, write and > readback operation.

Re: [PATCH 0/4] net: mitigating kmem_cache slowpath for network stack in NAPI context

From: Jesper Dangaard Brouer Date: Fri, 23 Oct 2015 14:46:01 +0200 > It have been a long road. Back in July 2014 I realized that network > stack were hitting the kmem_cache/SLUB slowpath when freeing SKBs, but > had no solution. In Dec 2014 I had implemented a solution called > qmempool[1], that

[PATCH net-next 1/2] mpls: fix forwarding using v4/v6 explicit null

Fill in the via address length for the predefined IPv4 and IPv6 explicit-null label routes. Fixes: f8efb73c97e2 ("mpls: multipath route support") Signed-off-by: Robert Shearman --- net/mpls/af_mpls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c in

[PATCH net-next 0/2] mpls: mulipath improvements

Two improvements to the recently added mpls multipath support. The first is a fix for missing initialisation the nexthop address length for the v4 and v6 explicit null label routes, and the second is to reduce the amount of memory used by mpls routes by changing the way the via addresses are stored

[PATCH net-next 2/2] mpls: reduce memory usage of routes

Nexthops for MPLS routes have a via address field sized for the largest via address that is expected, which is 32 bytes. This means that in the most common case of having ipv4 via addresses, 28 bytes of memory more than required are used per nexthop. In the other common case of an ipv6 nexthop then

[PATCH net-next] seccomp, ptrace: add support for dumping seccomp filters

This patch adds support for dumping a process' (classic BPF) seccomp filters via ptrace. PTRACE_SECCOMP_GET_FILTER allows the tracer to dump the user's classic BPF seccomp filters. addr should be an integer which represents the ith seccomp filter (0 is the most recently installed filter). data sho

seccomp c/r patch

Hi all, Here is a patch that we'd like to go via net-next, as it depends on previous changes in that tree. Thanks, Tycho -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majo

Re: [PATCH net-next 0/4] Automatic adjustment of max frame size

From: "Keller, Jacob E" Date: Mon, 26 Oct 2015 20:50:45 + > I am not sure why it failed to mail to it, unless netdev blocks non > subscribers from sending mail (it probably does) It absolutely does not. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mes

[PATCH] ixgbe: check Master Disable bit after setting

From: Dan Streetman Spec section 8.2.4.1.1 notes that after setting the PCIe Master Disable bit, it must be read to verify it was set before polling the Master Enable status bit. This adds the check to verify the Master Disable bit was set. This also corrects the spec section number reference -

[PATCH] bpf: sample: define aarch64 specific registers

Define aarch64 specific registers for building bpf samples correctly. Signed-off-by: Yang Shi --- samples/bpf/bpf_helpers.h | 12 1 file changed, 12 insertions(+) diff --git a/samples/bpf/bpf_helpers.h b/samples/bpf/bpf_helpers.h index 3a44d3a..af44e56 100644 --- a/samples/bpf/bpf_

Re: [PATCH v8] seccomp, ptrace: add support for dumping seccomp filters

Hi Tycho, On 10/27/2015 01:04 AM, Tycho Andersen wrote: On Mon, Oct 26, 2015 at 04:07:01PM +0900, Kees Cook wrote: On Mon, Oct 26, 2015 at 3:46 PM, Kees Cook wrote: Cool, thanks. I'll get this into my tree after kernel summit. Thanks for suffering through all this Tycho! Actually, since thi

[PATCH] ixgbe: Wait for 1ms, not 1us, after RST

From: Dan Streetman The driver currently waits 1us after issuing a RST, but the spec requires it to wait 1ms. Signed-off-by: Dan Streetman Signed-off-by: Dan Streetman --- drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/d

Re: [PATCH v8] seccomp, ptrace: add support for dumping seccomp filters

Hi David, On Mon, Oct 26, 2015 at 04:07:01PM +0900, Kees Cook wrote: > On Mon, Oct 26, 2015 at 3:46 PM, Kees Cook wrote: > > Cool, thanks. I'll get this into my tree after kernel summit. Thanks > > for suffering through all this Tycho! > > Actually, since this depends on changes in net, could th

Re: [BUG] bnx2x_config_vlan_mac called a NULL function pointer

Thank you Ariel, just let me know if you find anything. On 23. Oct (Friday) v 08:16:01 + 2015, Ariel Elior wrote: > Looking into it... > > > Hello netdev, > > I probably found a bug in kernel-4.3.0-0.rc5 (bnx2x driver). So I opened > > new bug report in our bugzilla [0]. Michal Schmidt told

Re: ip_no_pmtu_disc and UDP

On Mon, Oct 26, 2015, at 23:53, Vincent Li wrote: > ok, I observed if i increase the UDP client packet size > local > interface MTU 1500, the client will fragment the packet first and > then send it out, if the UDP client packet size < local interface MTU > 1500, the DF bit will be set when ip_no

Re: ip_no_pmtu_disc and UDP

ok, I observed if i increase the UDP client packet size > local interface MTU 1500, the client will fragment the packet first and then send it out, if the UDP client packet size < local interface MTU 1500, the DF bit will be set when ip_no_pmtu_disc set to 0, is this expected behavior ? On Mon

Re: [PATCH RFT v2] sh_eth: fix kernel oops in skb_put()

Hi Sergei, Thank you for your patch! On Sun, 25 Oct 2015 07:42:33 +0900, Sergei Shtylyov wrote: > > In a low memory situation the following kernel oops occurs: > > Unable to handle kernel NULL pointer dereference at virtual address 0050 > pgd = 8490c000 > [0050] *pgd=4651e831, *pte=

Re: ip_no_pmtu_disc and UDP

I test again and i did see DF bit now, it is weird. I am going to do more test, sorry for the noise. On Mon, Oct 26, 2015 at 3:12 PM, Hannes Frederic Sowa wrote: > Hello, > > On Mon, Oct 26, 2015, at 23:00, Vincent Li wrote: >> the UDP packet size is about 768, here is how packet path like: >> >

[PATCH net-next v2 1/2] drivers: net: xgene: Add support RGMII TX/RX delay configuration

Add RGMII TX/RX delay configuration support. RGMII standard requires 2ns delay to help the RGMII bridge receiver to sample data correctly. If the default value does not provide proper centering of the data sample, the TX/RX delay parameters can be used to adjust accordingly. Signed-off-by: Iyappan

[PATCH net-next v2 2/2] Documentation: dts: xgene: Add TX/RX delay field

Signed-off-by: Iyappan Subramanian --- Documentation/devicetree/bindings/net/apm-xgene-enet.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt index f55aa28..07806

[PATCH net-next v2 0/2] drivers: xgene: Add support RGMII TX/RX delay configuration

X-Gene RGMII ethernet controller has a RGMII bridge that performs the task of converting the RGMII signal {RX_CLK,RX_CTL, RX_DATA[3:0]} from PHY to GMII signal {RX_DV,RX_ER,RX_DATA[7:0]} and vice versa. This RGMII bridge has a provision to internally delay the input RX_CLK and the output TX_CLK us

[PATCH net] amd-xgbe: Fix race between access of desc and desc index

During Tx cleanup it's still possible for the descriptor data to be read ahead of the descriptor index. A memory barrier is required between the read of the descriptor index and the start of the Tx cleanup loop. This allows a change to a lighter-weight barrier in the Tx transmit routine just before

Re: ip_no_pmtu_disc and UDP

Hello, On Mon, Oct 26, 2015, at 23:00, Vincent Li wrote: > the UDP packet size is about 768, here is how packet path like: > > client > server > (eth0 mtu 1500 ip 10.3.72.69) (eth0 mtu 1500 ip

Re: ip_no_pmtu_disc and UDP

the UDP packet size is about 768, here is how packet path like: client server (eth0 mtu 1500 ip 10.3.72.69) (eth0 mtu 1500 ip 10.3.72.1, (eth0 mtu 1500 ip 10.2.72.99)

[PATCHv2 net 0/2] ipv4: fix problems from the RTNH_F_LINKDOWN introduction

Fix two problems from the change that introduced RTNH_F_LINKDOWN flag. The first patch deals with the removal of local route on DOWN event. The second patch makes sure the RTNH_F_LINKDOWN flag is properly updated on UP event because the DOWN event sets it in all cases. v1->v2: - forgot to add ifco

[PATCHv2 net 1/2] ipv4: fix to not remove local route on link down

When fib_netdev_event calls fib_disable_ip on NETDEV_DOWN event we should not delete the local routes if the local address is still present. The confusion comes from the fact that both fib_netdev_event and fib_inetaddr_event use the NETDEV_DOWN constant. Fix it by returning back the variable 'force

[PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event

When nexthop is part of multipath route we should clear the LINKDOWN flag when link goes UP or when first address is added. This is needed because we always set LINKDOWN flag when DEAD flag was set but now on UP the nexthop is not dead anymore. Examples when LINKDOWN bit can be forgotten when no NE

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

On Mon, Oct 26, 2015 at 2:35 PM, Andreas Petlund wrote: > > > > On 26 Oct 2015, at 15:50, Neal Cardwell wrote: > > > > On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad > > wrote: > >> @@ -2409,6 +2412,15 @@ static int do_tcp_setsockopt(struct sock *sk, int > >> level, > > ... > >> +

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

> On 26 Oct 2015, at 15:50, Neal Cardwell wrote: > > On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad > wrote: >> @@ -2409,6 +2412,15 @@ static int do_tcp_setsockopt(struct sock *sk, int >> level, > ... >> + case TCP_RDB: >> + if (val < 0 || val > 1) { >> +

Re: [PATCH v3 1/2] devicetree: add binding for Aurora VLSI NB8800 Ethernet controller

Forgot to CC netdev. Mans Rullgard writes: > This adds a binding for the Aurora VLSI NB8800 Ethernet controller > using the "aurora,nb8800" compatible string. When used in Sigma > Designs chips a few additional features are available. These variants > are indicated by a "sigma,-ethernet" compa

[PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

This adds a driver for the Aurora VLSI NB8800 Ethernet controller. It is an almost complete rewrite of a driver originally found in a Sigma Designs 2.6.22 tree. Signed-off-by: Mans Rullgard --- Changes: - remove check for wake on lan irq as it is never requested - prettify mac address setting - u

Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper

On 10/26/15 5:54 AM, Wangnan (F) wrote: On 2015/10/26 20:32, Peter Zijlstra wrote: On Sun, Oct 25, 2015 at 09:23:36AM -0700, Alexei Starovoitov wrote: bpf_perf_event_read() muxes of -EINVAL into return value, but it's non ambiguous to the program whether it got an error or real counter value.

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

On Mon, Oct 26, 2015, at 20:39, Tom Herbert wrote: > On Mon, Oct 26, 2015 at 11:44 AM, Hannes Frederic Sowa > wrote: > > > > > > On Mon, Oct 26, 2015, at 15:19, Tom Herbert wrote: > >> > We already concluded that drivers do have this problem and not the stack > >> > above ip6_fragment. The places

[PATCH v7 3/3] geneve: add IPv6 bits to geneve_fill_metadata_dst

Signed-off-by: John W. Linville --- v7 -- initial version (numbered to match earlier patches in series) drivers/net/geneve.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 44e724508c55..be532d7b8

Re: [PATCH net] ipv4: fix problems from the RTNH_F_LINKDOWN introduction

Hello, On Mon, 26 Oct 2015, Andy Gospodarek wrote: > On Sat, Oct 24, 2015 at 09:20:00PM +0300, Julian Anastasov wrote: > > When fib_netdev_event calls fib_disable_ip on NETDEV_DOWN event > > we should not delete the local routes if the local address > > is still present. The confusion co

[PATCH v7 2/3] geneve: handle ipv6 priority like ipv4 tos

Other callers of udp_tunnel6_xmit_skb just pass 0 for the prio argument. Jesse Gross suggested that prio is really the same as IPv4's tos and should be handled the same, so this is my interpretation of that suggestion. Signed-off-by: John W. Linville Reported-by: Jesse Gross Reviewed-by: Jesse

[PATCH v7 1/3] geneve: implement support for IPv6-based tunnels

NOTE: Link-local IPv6 addresses for remote endpoints are not supported, since the driver currently has no capacity for binding a geneve interface to a specific link. Signed-off-by: John W. Linville Reviewed-by: Jesse Gross --- v7: - rebase on top of commit fc4099f17240 ("openvswitch: Fix egress

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

On 10/26/2015 01:45 PM, Hannes Frederic Sowa wrote: Hi, On Mon, Oct 26, 2015, at 20:16, Jay Vosburgh wrote: Hannes Frederic Sowa wrote: Hello Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: Seems like this code isn't quite correct. You are calling ipv6_add_dev for slave devic

Re: [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

On Oct. Friday 23 (43) 11:38 AM, Florian Fainelli wrote: > Add support for the FDB add, delete, and dump operations. The add and > delete operations are implemented using directed ARL operations using > the specified MAC address and consist in a read operation, write and > readback operation. > >

Re: [PATCH net-next 0/4] Automatic adjustment of max frame size

On Mon, 2015-10-26 at 09:56 +0900, Toshiaki Makita wrote: > On 2015/10/24 17:50, Toshiaki Makita wrote: > > David, > > > > I found my patch set is marked with Changes Requested, but I > > haven't > > seen any feedback. > > > > Could you give me your feedback? > > Somehow the mail from LD Linux C

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

Hi, On Mon, Oct 26, 2015, at 20:16, Jay Vosburgh wrote: > Hannes Frederic Sowa wrote: > > >Hello Alex, > > > >On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: > >> Seems like this code isn't quite correct. You are calling ipv6_add_dev > >> for slave devices, and if I understand things co

Re: [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

On 23/10/15 15:44, Vivien Didelot wrote: > On Oct. Friday 23 (43) 01:20 PM, Florian Fainelli wrote: >> On 23/10/15 12:28, Vivien Didelot wrote: >>> On Oct. Friday 23 (43) 11:38 AM, Florian Fainelli wrote: +static int bcm_sf2_sw_fdb_del(struct dsa_switch *ds, int port, +

Re: [PATCH net] ipv4: fix problems from the RTNH_F_LINKDOWN introduction

On Sat, Oct 24, 2015 at 09:20:00PM +0300, Julian Anastasov wrote: > When fib_netdev_event calls fib_disable_ip on NETDEV_DOWN event > we should not delete the local routes if the local address > is still present. The confusion comes from the fact that both > fib_netdev_event and fib_inetaddr_event

[PATCH v6 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- Remove empty line suggested by Sergei drivers/net/wireless/ath/wcn36xx/main.c | 4

Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

On Fri, Oct 23, 2015 at 12:26 AM, Sergei Shtylyov wrote: > On 10/22/2015 09:47 PM, Punit Vara wrote: > >> Remove black line suggested by Sergei > > >Such kind of comments should be under the --- tear line. > >> >> This patch is to the ath5k/eeprom.c that fixes up warning caught by >> coccichec

Re: [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

Hi, On Mon, Oct 26, 2015 at 11:55:39AM -0700, Ani Sinha wrote: > netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get Please, no need to Cc everyone here. Please, submit your Netfilter patches to netfilter-de...@vger.kernel.org. Moreover, it would be great if the subject includes somet

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

On Mon, Oct 26, 2015 at 11:44 AM, Hannes Frederic Sowa wrote: > > > On Mon, Oct 26, 2015, at 15:19, Tom Herbert wrote: >> > We already concluded that drivers do have this problem and not the stack >> > above ip6_fragment. The places I am aware of I fixed in this patch. Also >> > IPv4 to me seems u

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

Hannes Frederic Sowa wrote: >Hello Alex, > >On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: >> Seems like this code isn't quite correct. You are calling ipv6_add_dev >> for slave devices, and if I understand things correctly I don't believe >> that was happening before and may be an uni

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

Hi Alex, On Mon, Oct 26, 2015, at 18:07, Alexander Duyck wrote: > Might be a bit longer. I just realized that I think there is another > bug here where you are going through the NETDEV_UP path even though the > interface isn't up. I'll run through some testing this morning to work > out the k

[PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.

netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get Lets look at destroy_conntrack: hlist_nulls_del_rcu(&ct->tuplehash[IP_CT_DIR_ORIGINAL].hnnode); ... nf_conntrack_free(ct) kmem_cache_free(net->ct.nf_conntrack_cachep, ct); net->ct.nf_conntrack_cachep is created with SLAB_DEST

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

On Mon, Oct 26, 2015, at 15:19, Tom Herbert wrote: > > We already concluded that drivers do have this problem and not the stack > > above ip6_fragment. The places I am aware of I fixed in this patch. Also > > IPv4 to me seems unaffected, albeit one can certainly clean up the logic > > in net-next

Re: [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

On 10/26/2015 12:02 PM, Or Gerlitz wrote: On Mon, Oct 26, 2015 at 5:15 PM, wrote: From: Carol L Soto If the caps.eqe_size is bigger than the struct mlx4_eqe then there is a potential for corrupting data at the master context. We can see the message "Master failed to generate an EQE for sla

Re: [PATCH 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

Hi Eric, > > When the op_mode sends an skb whose payload is bigger than > MSS, PCIe will create an A-MSDU out of it. PCIe assumes > that the skb that is coming from the op_mode can fit in one > A-MSDU. It is the op_mode's responsibility to make sure > that this guarantee holds. > > Additional head

Re: [PATCH v1 2/3] virtio: vp_find_vqs accept channel setting params

Hi Ravi, [auto build test ERROR on char-misc/char-misc-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Ravi-Kerur/virtio-net-Using-single-MSIX-IRQ-for-TX-RX-Q-pair/20151027-015503 config: x86_64-rand

Re: [PATCH v1 2/3] virtio: vp_find_vqs accept channel setting params

Hi Ravi, [auto build test WARNING on char-misc/char-misc-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Ravi-Kerur/virtio-net-Using-single-MSIX-IRQ-for-TX-RX-Q-pair/20151027-015503 config: x86_64-ra

[net-next PATCH v2] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

This change makes it so that we reinitialize the interface if the MTU is increased back above IPV6_MIN_MTU and the interface is up. Cc: Hannes Frederic Sowa Signed-off-by: Alexander Duyck --- net/ipv6/addrconf.c | 46 +++--- 1 file changed, 27 insertion

[PATCH v1 3/3] virtio-pci: Introduce channels

Port earlier patch from Jason Wang (dated 12/26/2014). This patch introduces virtio pci channel which are virtqueue groups that sharing a single MSIX irq. This can be used to reduce the irqs needed by virtio device. The channel are in fact a list of virtqueues, and vp_channel_interrupt() was intr

[PATCH v1 1/3] virtio-net: Using single MSIX IRQ for TX/RX Q pair

Ported earlier patch from Jason Wang (dated 12/26/2014). This patch tries to reduce the number of MSIX irqs required for virtio-net by sharing a MSIX irq for each TX/RX queue pair through channels. If transport support channel, about half of the MSIX irqs were reduced. Signed-off-by: Ravi Kerur

[PATCH v1 2/3] virtio: vp_find_vqs accept channel setting params

Port earlier patch from Jason Wang (dated 12/26/2014). This patch lets vp_find_vqs function accept channel parameters. For the transports that do not support channel currently, all the parameters are ignored. For the device that does not use channel, it can simply pass NULL to transport. Signed-o

Re: [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

On Thu, Oct 22, 2015 at 09:45:10PM +0300, Vladimir Davydov wrote: > Hi Johannes, > > On Thu, Oct 22, 2015 at 12:21:28AM -0400, Johannes Weiner wrote: > ... > > Patch #5 adds accounting and tracking of socket memory to the unified > > hierarchy memory controller, as described above. It uses the exi

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

Hi Alex, On Mon, Oct 26, 2015, at 18:07, Alexander Duyck wrote: > >> Seems like this code isn't quite correct. You are calling ipv6_add_dev > >> for slave devices, and if I understand things correctly I don't believe > >> that was happening before and may be an unintended side effect. > > Hmm, co

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

On 10/26/2015 09:05 AM, Hannes Frederic Sowa wrote: Hi Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: On 10/26/2015 07:36 AM, Hannes Frederic Sowa wrote: Take into consideration that the interface might be disabled for IPv6, thus switch event type. Signed-off-by: Hannes Frederic

Re: [PATCH net-next 2/8] xen-netback: remove GSO information from xenvif_rx_meta

On Wed, Oct 21, 2015 at 11:36:19AM +0100, Paul Durrant wrote: > The code in net_rx_action() that builds rx responses has direct access > to the skb so there is no need to copy this information into the meta > structure. > > This patch removes the extraneous fields, saves space in the array and > r

Re: [PATCH net-next 3/8] xen-netback: support multiple extra info segments passed from frontend

On Wed, Oct 21, 2015 at 11:36:20AM +0100, Paul Durrant wrote: > The code does not currently allow a frontend to pass multiple extra info > segments to the backend in a tx request. A subsequent patch in this series > needs this functionality so it is added here, without any other > modification, for

Re: [PATCH net-next 8/8] xen-netback: add support for toeplitz hashing

On Wed, Oct 21, 2015 at 11:36:25AM +0100, Paul Durrant wrote: > This patch adds all the necessary infrastructure to allow a frontend to > specify toeplitz hashing of network packets on its receive side. (See > netif.h for details of the xenbus protocol). > > The toeplitz hash algorithm itself was

Re: [PATCH net-next 6/8] xen-netback: pass an L4 or L3 skb hash value to the frontend

On Wed, Oct 21, 2015 at 11:36:23AM +0100, Paul Durrant wrote: > If the frontend indicates it's capable (see netif.h for details) and an > skb has an L4 or L3 hash value then pass the value to the frontend in > a xen_netif_extra_info segment. > > Signed-off-by: Paul Durrant > Cc: Ian Campbell > C

Re: [PATCH net-next 1/8] xen-netback: re-import canonical netif header

On Wed, Oct 21, 2015 at 11:36:18AM +0100, Paul Durrant wrote: > The canonical netif header (in the Xen source repo) and the Linux variant > have diverged significantly. Recently much documentation has been added to > the canonical header and new definitions and types to support packet hash > config

Re: [PATCH net-next 4/8] xen-netback: accept an L4 or L3 skb hash value from the frontend

On Wed, Oct 21, 2015 at 11:36:21AM +0100, Paul Durrant wrote: > This patch adds an indication that netback is capable of handling hash > values passed from the frontend (see netif.h for details), and the code > necessary to process the additional xen_netif_extra_info segment and > set a hash on the

Re: [PATCH net-next 7/8] xen-netback: add support for a multi-queue hash mapping table

On Wed, Oct 21, 2015 at 11:36:24AM +0100, Paul Durrant wrote: > Advertise the capability to handle a hash mapping specified by the > frontend (see netif.h for details). > > Add an ndo_select() entry point so that, of the frontend does specify a "if the frontend ..." > hash mapping, the skb hash

Re: [PATCH v2] net/mlx4: Memcpy at slave_event should copy sizeof mlx4_eqe

On Mon, Oct 26, 2015 at 5:15 PM, wrote: > From: Carol L Soto > > If the caps.eqe_size is bigger than the struct mlx4_eqe then there > is a potential for corrupting data at the master context. We can see > the message "Master failed to generate an EQE for slave: X" when the > event_eqe array wrap

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

On Fri, Oct 23, 2015 at 06:59:57AM -0700, David Miller wrote: > From: Michal Hocko > Date: Fri, 23 Oct 2015 15:19:56 +0200 > > > On Thu 22-10-15 00:21:33, Johannes Weiner wrote: > >> Socket memory can be a significant share of overall memory consumed by > >> common workloads. In order to provide

Re: Missing IPv4 routes

On 10/26/2015 11:28 AM, Alexander Duyck wrote: On 10/24/2015 06:32 AM, Brian Rak wrote: On 10/23/2015 6:32 PM, Alexander Duyck wrote: On 10/23/2015 02:34 PM, Brian Rak wrote: I've got a weird situation here. I have a route that the kernel knows about, but won't display via the general RTM

Re: [PATCH net] RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv

On 10/26/2015 9:46 AM, Sowmini Varadhan wrote: Either of pskb_pull() or pskb_trim() may fail under low memory conditions. If rds_tcp_data_recv() ignores such failures, the application will receive corrupted data because the skb has not been correctly carved to the RDS datagram size. Avoid this

[PATCH net] RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv

Either of pskb_pull() or pskb_trim() may fail under low memory conditions. If rds_tcp_data_recv() ignores such failures, the application will receive corrupted data because the skb has not been correctly carved to the RDS datagram size. Avoid this by handling pskb_pull/pskb_trim failure in the sa

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

Hello Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: > Seems like this code isn't quite correct. You are calling ipv6_add_dev > for slave devices, and if I understand things correctly I don't believe > that was happening before and may be an unintended side effect. Ah, btw., auto

[PATCH] forcedeth: fix unilateral interrupt disabling in netpoll path

Forcedeth currently uses disable_irq_lockdep and enable_irq_lockdep, which in some configurations simply calls local_irq_disable. This causes errant warnings in the netpoll path as in netpoll_send_skb_on_dev, where we disable irqs using local_irq_save, leading to the following warning: WARNING: a

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

Hi Alex, On Mon, Oct 26, 2015, at 16:52, Alexander Duyck wrote: > On 10/26/2015 07:36 AM, Hannes Frederic Sowa wrote: > > Take into consideration that the interface might be disabled for IPv6, > > thus switch event type. > > > > Signed-off-by: Hannes Frederic Sowa > > --- > > net/ipv6/addrconf.

  1   2   >